Re: [ibm-acpi-devel] Bug report - Lenovo T440s

2015-03-02 Thread Lyude
: http://sourceforge.net/p/ibm-acpi/mailman/message/33520975/ Cheers, Lyude -- Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot

Re: [ibm-acpi-devel] Bug report - Lenovo T440s

2015-03-02 Thread Lyude
: http://sourceforge.net/p/ibm-acpi/mailman/message/33520975/ Cheers, Lyude -- Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot

[ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200

2016-06-08 Thread Lyude
e HKEY version 0x100 without parameter). Passing parameter value 2 to MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in that case there is no adaptive keyboard available. Signed-off-by: Dennis Wassenberg <dennis.wassenb...@secunet.com> Signed-off-by: Lyude <cp...@red

[ibm-acpi-devel] Getting 'thinkpad_acpi: Add support for HKEY version 0x200' upstream?

2016-06-01 Thread Lyude
with getting this merged? I've got a few laptops with this (T560, T460s, P50, and if I look hard enough a X260) and the capability to do any testing needed for this to get merged upstream.  -- Cheers, Lyude Desktop Engineer at Red Hat

[ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode

2016-10-27 Thread Lyude
since v1: - Clarify kernel output when finding the tablet mode switch Signed-off-by: Lyude <ly...@redhat.com> --- drivers/platform/x86/thinkpad_acpi.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acp

[ibm-acpi-devel] [PATCH v3 1/3] thinkpad_acpi: Move tablet detection into separate function

2016-11-07 Thread Lyude
reporting the machine supports. Suggested by Daniel Martin <consume.no...@gmail.com> Signed-off-by: Lyude <ly...@redhat.com> Cc: Daniel Martin <consume.no...@gmail.com> Signed-off-by: Lyude <ly...@redhat.com> --- Changes since v1: - Don't use bool for in_tablet_mode (fixe

[ibm-acpi-devel] [PATCH v4 3/3] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode

2016-11-07 Thread Lyude
Martin <consume.no...@gmail.com> Signed-off-by: Lyude <ly...@redhat.com> --- Changes since v1: - Clarify kernel output when finding the tablet mode switch Changes since v2: - Rebase on top of previous patch - Use an enum for hotkey_tablet. This does make a bit more sense then just ad

[ibm-acpi-devel] [PATCH 2/3] thinkpad_acpi: Don't repeat ourselves in hotkey_init_tablet_mode()

2016-11-07 Thread Lyude
There's no need to have multiple copies of the logic we use for checking whether or not we're in tablet mode, so just use hotkey_get_tablet_mode() when checking the initial state in hotkey_init_tablet_mode(). Cc: Daniel Martin <consume.no...@gmail.com> Signed-off-by: Lyude <ly...@r

[ibm-acpi-devel] [PATCH 1/3 v4] thinkpad_acpi: Move tablet detection into separate function

2016-11-10 Thread Lyude
reporting the machine supports. Suggested by Daniel Martin <consume.no...@gmail.com> Signed-off-by: Lyude <ly...@redhat.com> Cc: Daniel Martin <consume.no...@gmail.com> --- Changes since v1: - Don't use bool for in_tablet_mode (fixes complaints from kbuild test robot) Change

[ibm-acpi-devel] [PATCH v4 1/2] thinkpad_acpi: Move tablet detection into separate function

2016-11-11 Thread Lyude
reporting the machine supports. Suggested by Daniel Martin <consume.no...@gmail.com> Signed-off-by: Lyude <ly...@redhat.com> Cc: Daniel Martin <consume.no...@gmail.com> Acked-by: Henrique de Moraes Holschuh <h...@hmh.eng.br> --- Changes since v3: - Fix style nitpic

[ibm-acpi-devel] [PATCH v5 2/2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode

2016-11-11 Thread Lyude
-by: Daniel Martin <consume.no...@gmail.com> Signed-off-by: Lyude <ly...@redhat.com> --- Changes since v4: - Get rid of patch #2 - Add BIOS model - Update documentation Documentation/laptops/thinkpad-acpi.txt | 1 + drivers/platform/x86/thinkpad_acpi.c| 39

[ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode

2016-11-11 Thread Lyude
-by: Lyude <ly...@redhat.com> --- So HOPEFULLY I actually did this right. There was some discussion here previously about supporting this, and it was previously mentioned that the IOST method was responsible for holding the current tablet status. However, it really doesn't seem like this is th

[ibm-acpi-devel] [PATCH 3/3 v3] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode

2016-10-31 Thread Lyude
: Daniel Martin <consume.no...@gmail.com> Signed-off-by: Lyude <ly...@redhat.com> --- drivers/platform/x86/thinkpad_acpi.c | 37 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/

[ibm-acpi-devel] [PATCH 2/3] thinkpad_acpi: Don't repeat ourselves in hotkey_init_tablet_mode()

2016-10-31 Thread Lyude
There's no need to have multiple copies of the logic we use for checking whether or not we're in tablet mode, so just use hotkey_get_tablet_mode() when checking the initial state in hotkey_init_tablet_mode(). Cc: Daniel Martin <consume.no...@gmail.com> Signed-off-by: Lyude <ly...@r

[ibm-acpi-devel] [PATCH 0/3] Add support for X1 Yoga (2016) Tablet Mode + refactors

2016-10-31 Thread Lyude
, otherwise I'll test it out when I get to the office on Thursday. Signed-off-by: Lyude <ly...@redhat.com> Cc: Daniel Martin <consume.no...@gmail.com> Lyude (3): thinkpad_acpi: Move tablet detection into separate function thinkpad_acpi: Don't repeat ourselves in hotkey_init_tablet_mode() t

[ibm-acpi-devel] [PATCH 1/3] thinkpad_acpi: Move tablet detection into separate function

2016-10-31 Thread Lyude
tablet mode reporting the machine supports. Signed-off-by: Lyude <ly...@redhat.com> Cc: Daniel Martin <consume.no...@gmail.com> --- drivers/platform/x86/thinkpad_acpi.c | 50 +++- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/dr

[ibm-acpi-devel] [PATCH v2 1/3] thinkpad_acpi: Move tablet detection into separate function

2016-10-31 Thread Lyude
tablet mode reporting the machine supports. Changes since v1: - Don't use bool for in_tablet_mode (fixes complaints from kbuild test robot) Signed-off-by: Lyude <ly...@redhat.com> Cc: Daniel Martin <consume.no...@gmail.com> --- drivers/platform/x86/th

[ibm-acpi-devel] [PATCH RESEND] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode

2016-10-27 Thread Lyude
-by: Lyude <ly...@redhat.com> --- (Resending since I just confirmed this didn't make it to the mailing list the first time.) So HOPEFULLY I actually did this right. There was some discussion here previously about supporting this, and it was previously mentioned that the IOST method was respo

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for HKEY version 0x200

2016-06-07 Thread Lyude Paul
 */ > + > + /* Paranoia check AND init hotkey_all_mask */ > + if (!acpi_evalf(hkey_handle, _all_mask, > + "MHKA", "dd", 1)) { > +

Re: [ibm-acpi-devel] [PATCH 0/3] Add support for X1 Yoga (2016) Tablet Mode + refactors

2016-11-01 Thread Lyude Paul
Got in touch with a friend who happened to have a X201 and had them test the patches, so I've confirmed this doesn't break anything with older ThinkPad tablets. On Mon, 2016-10-31 at 18:55 -0400, Lyude wrote: > Updated patchset for adding support for detecting tablet mode on the > X1 Yoga

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode

2016-10-27 Thread Lyude Paul
as well, can someone confirm this patch made it to the ibm-acpi-devel list? When I originally sent this I realized I wasn't subscribed to the list, so I'm guessing I might need to resend. On Tue, 2016-10-25 at 18:12 -0400, Lyude wrote: > For whatever reason, the X1 Yoga doesn't support the nor

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Implement tablet mode resolving using GMMS method

2017-09-18 Thread Lyude Paul
Reviewed-by: Lyude Paul <ly...@redhat.com> On Fri, 2017-09-15 at 15:20 +0200, Benjamin Berg wrote: > Many thinkpad laptops and convertibles provide the GMMS method to > resolve how far the laptop has been opened and whether it has been > converted into tablet mode. This allows r

[ibm-acpi-devel] [PATCH 0/2] Fix detection of 2nd fan on X1C9

2022-04-29 Thread Lyude Paul
Some recent changes broke detection of the second fan on the X1 Carbon 9th generation, so here's some patches to fix it. Lyude Paul (2): platform/x86: thinkpad_acpi: Restore X1 Carbon 9th Gen dual fan quirk platform/x86: thinkpad_acpi: Don't probe 2nd fan if enabled by quirk drivers

[ibm-acpi-devel] [PATCH 2/2] platform/x86: thinkpad_acpi: Don't probe 2nd fan if enabled by quirk

2022-04-29 Thread Lyude Paul
into a single group of if/else statements. This is because there's no situations where there's more then one quirk on a device. Signed-off-by: Lyude Paul Fixes: bf779aaf56ea ("platform/x86: thinkpad_acpi: Add dual fan probe") Cc: Mark Pearson Cc: Hans de Goede Cc: Henrique de Moraes Holschuh

[ibm-acpi-devel] [PATCH 1/2] platform/x86: thinkpad_acpi: Restore X1 Carbon 9th Gen dual fan quirk

2022-04-29 Thread Lyude Paul
is machine powers on quite often without either of the two fans spinning. So let's fix this by adding back the dual fan quirk for the X1 Carbon 9th Gen. Signed-off-by: Lyude Paul Fixes: bf779aaf56ea ("platform/x86: thinkpad_acpi: Add dual fan probe") Cc: Mark Pearson Cc: Hans de Go

Re: [ibm-acpi-devel] [External] [PATCH 1/2] platform/x86: thinkpad_acpi: Restore X1 Carbon 9th Gen dual fan quirk

2022-05-02 Thread Lyude Paul
Some answers/comments down below On Fri, 2022-04-29 at 21:25 -0400, Mark Pearson wrote: > Hi Lyude > > On 4/29/22 17:14, Lyude Paul wrote: > > The new method of probing dual fan support introduced in: > > > > bf779aaf56ea ("platform/x86: thinkpad_acpi: Add