Re: [Imdbpy-devel] IMDbPY revamp

2017-11-11 Thread Davide Alberani
On Wed, Nov 1, 2017 at 3:02 PM, Davide Alberani wrote: > > as many of you know, IMDbPY is in need of a revamp. :-) A quick update: I've just merged back into master the many changes of the "codename-simply" branch (which should now be considered closed; I'll delete it

Re: [Imdbpy-devel] IMDbPY revamp

2017-11-06 Thread Davide Alberani
On Mon, Nov 6, 2017 at 1:56 PM, Davide Alberani wrote: > > I'm ok with including them into IMDbPY itself: it may motivate others > to write more tests. :-) Merged in the codename-simplify branch your test-suite and changes for PEP8 compliance. If I'll be able to

Re: [Imdbpy-devel] IMDbPY revamp

2017-11-06 Thread Davide Alberani
On Sun, Nov 5, 2017 at 7:16 PM, H. Turgut Uyar wrote: > > Great work, thanks! What is the minimal supported Python 3 version? Not thought too much about it; I guess 3.3 / 3.4 is ok. > I would rather have bsoup removed at the moment and maybe added back > later. Ok. I'll

Re: [Imdbpy-devel] IMDbPY revamp

2017-11-06 Thread H. Turgut Uyar
Hello again, I've created a new repository which contains some tests I had written for the HTTP movie combined page parser. Most of the 70+ tests pass for Python 3.3 to 3.6 with and without lxml installed. Pretty good start. https://github.com/uyar/imdbpy-tests To run, just type "tox". This

Re: [Imdbpy-devel] IMDbPY revamp

2017-11-05 Thread H. Turgut Uyar
Hi, Great work, thanks! What is the minimal supported Python 3 version? I would rather have bsoup removed at the moment and maybe added back later. Currently the bsoup and lxml parsers require different preprocessors because their parsers come up with different DOM trees. When I refactored the

Re: [Imdbpy-devel] IMDbPY revamp

2017-11-05 Thread Davide Alberani
Hi everyone, I've completed a first round of changes into the https://github.com/alberanid/imdbpy/tree/codename-simplify branch. Right now: - Python 3 is supported, for http parser - I've simplified the setup.py to always require lxml and only support SQLAlchemy What can be done: 1. I've not

Re: [Imdbpy-devel] IMDbPY revamp

2017-11-02 Thread Davide Alberani
On Thu, Nov 2, 2017 at 5:51 PM, H. Turgut Uyar wrote: > > A similar thing could be done with respect to the print function. Out of > curiosity, do > you plan to use 2to3 for this, or do you plan to do it manually? Both: first round with 2to3, then some manual fixes. I also

Re: [Imdbpy-devel] IMDbPY revamp

2017-11-02 Thread H. Turgut Uyar
OK, let me know when there's something you would like to delegate. When I looked at the code with the intention of porting, one of the difficult issues I saw was the mixed use of strings and unicode objects. Probably adding a future import for unicode_literals and removing the u'' literals would

Re: [Imdbpy-devel] IMDbPY revamp

2017-11-02 Thread Davide Alberani
On Wed, Nov 1, 2017 at 5:24 PM, H. Turgut Uyar wrote: > > In short, how can I help? I think it's better if you finish the cleanup > first before I start fiddling. But after that I can help with the Python > 3 porting. Great, thanks! I plan to do some work to introduce Python

Re: [Imdbpy-devel] IMDbPY revamp

2017-11-01 Thread H. Turgut Uyar
Hi, That's wonderful news! I'd be happy to help. I think removing BeautifulSoup support and going with lxml is a good idea. We did want IMDbPY to be pure Python and self-contained but not if that's making the move to Python 3 more difficult. And once we have the code simplified, I can try to

[Imdbpy-devel] IMDbPY revamp

2017-11-01 Thread Davide Alberani
Hi all, as many of you know, IMDbPY is in need of a revamp. :-) So, while I (again and again) have very little time to devote to it, I try to slowly improve it. Right now I've created a "codename-simply" branch, with the intent of reducing the amount of legacy code and some of the oddities of my