Re: [Intel-gfx] [PATCH] drm/i915: Clear any errors recorded before i915.ko is loaded

2011-04-06 Thread Chris Wilson
On Tue, 05 Apr 2011 18:27:45 -0700, Keith Packard kei...@keithp.com wrote: On Tue, 5 Apr 2011 23:00:46 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: This looks like it fixes two bugs: 1) What if there is an error recorded before we start and so we immediately service an IIR/EIR

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Initialise g4x watermarks for disabled pipes

2011-04-06 Thread Chris Wilson
On Tue, 05 Apr 2011 18:02:51 -0700, Keith Packard kei...@keithp.com wrote: On Tue, 05 Apr 2011 22:12:19 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: Indeed, I started by setting them to zero in the caller. Decided that there was some precedent to use the guard_size as the minimum

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Initialise g4x watermarks for disabled pipes

2011-04-06 Thread Chris Wilson
On Wed, 06 Apr 2011 00:36:50 -0700, Keith Packard kei...@keithp.com wrote: On Wed, 06 Apr 2011 07:59:37 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: I'd prefer to keep the mucking around with intel_watermak_params in the one spot. How about: My concern is that g4x_compute_wm0 is

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Initialise g4x watermarks for disabled pipes

2011-04-06 Thread Keith Packard
On Wed, 06 Apr 2011 09:02:22 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: Looks like we can now indeed merge g4x_compute_wm0 and ironlake_compute_wm0 and ignore the off-values for gen5+. They do seem surprisingly similar at this point... So fix the use of uninitialised values for

[Intel-gfx] [PATCH] drm/i915: disable RC6+ on Sandy Bridge

2011-04-06 Thread Jesse Barnes
RC6+ can cause trouble, so keep it disabled (this costs us a little power, around 20mW I think, but better safe than sorry). Cc: sta...@kernel.org Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c |1 - 1 files changed, 0 insertions(+), 1

Re: [Intel-gfx] [intel-gpu-tools] [PATCH 1/3] intel-gpu-tools add ioctl interface usage

2011-04-06 Thread Kenneth Graunke
On 04/05/2011 12:33 PM, Ben Widawsky wrote: Added the mechnanism to communicate with the i915 IOCTL interface, and removed the existing forcewake code, as it is not reliable. Modified gpu_top to take a flag -i, to use the IOCTL interface. Previous gpu_top behavior with no args is maintained

[Intel-gfx] Trying to understand the URB code

2011-04-06 Thread Kenneth Graunke
Hi Nanhai, I'm trying to understand how the Gen6 URB setup works, and I had some questions... if (IS_GT1(intel-intelScreen-deviceID)) { urb_size = 32 * 1024; max_urb_entry = 128; } else { urb_size = 64 * 1024; max_urb_entry = 256; } I see in vol5c.5