Re: [Intel-gfx] [PATCH 3/7] drm/exynos: Renaming DP training vswing pre emph defines

2014-08-28 Thread Jingoo Han
On Thursday, August 28, 2014 1:33 PM, Sonika Sonika wrote: On 8/28/2014 6:25 AM, Jingoo Han wrote: On Friday, August 08, 2014 7:54 PM, Sonika Jindal wrote: From: Sonika Jindal sonika.jin...@intel.com Rename the defines to have levels instead of values for vswing and pre-emph levels as

Re: [Intel-gfx] [PATCH 3/7] drm/exynos: Renaming DP training vswing pre emph defines

2014-08-28 Thread Jindal, Sonika
On 8/28/2014 11:36 AM, Jingoo Han wrote: On Thursday, August 28, 2014 1:33 PM, Sonika Sonika wrote: On 8/28/2014 6:25 AM, Jingoo Han wrote: On Friday, August 08, 2014 7:54 PM, Sonika Jindal wrote: From: Sonika Jindal sonika.jin...@intel.com Rename the defines to have levels instead of

Re: [Intel-gfx] [PATCH] igt/gem_workarounds: igt to test workaround registers

2014-08-28 Thread Damien Lespiau
On Thu, Aug 28, 2014 at 06:55:37AM +0100, Chris Wilson wrote: On Wed, Aug 27, 2014 at 11:30:35PM +0100, Damien Lespiau wrote: On Wed, Aug 27, 2014 at 06:52:57PM +0100, Chris Wilson wrote: Just to clarify, he was not ok because the list we maintain in the test can get out of sync with

Re: [Intel-gfx] [PATCH 1/7] drm: Renaming DP training vswing pre emph defines

2014-08-28 Thread Damien Lespiau
On Wed, Aug 27, 2014 at 03:11:08PM +0200, Thierry Reding wrote: So we're left with #define DP_TRAIN_VOLTAGE_SWING_LEVEL_0 (0 0) Vs #define DP_TRAIN_VOLTAGE_SWING_LEVEL(x) ((x) 0) The second variant doesn't really bring much more clarity? Can we just go with

Re: [Intel-gfx] [PATCH] drm/i915: Remove bogus __init annotation from DMI callbacks

2014-08-28 Thread Jani Nikula
On Wed, 27 Aug 2014, Mathias Krause mini...@googlemail.com wrote: The __init annotations for the DMI callback functions are wrong as this code can be called even after the module has been initialized, e.g. like this: # echo 1 /sys/bus/pci/devices/:00:02.0/remove # modprobe i915 #

[Intel-gfx] [QA 08/28 ww35] Testing report for `drm-intel-testing` (was: Updated -next)

2014-08-28 Thread Sun, Yi
Summary We covered the platform: Broadwell, Baytrail-M, Haswell (mobile, desktop and ULT), Ivybridge, SandyBridge, IronLake. In this circle, 1 new bugs is filed. Bug 83094https://bugs.freedesktop.org/show_bug.cgi?id=83094 - [BDW Bisected]System dmesg contains ERROR when machine resumes from s3

Re: [Intel-gfx] [PATCH v3] drm/i915/bdw: BDW Software Turbo

2014-08-28 Thread Chris Wilson
On Wed, Aug 27, 2014 at 08:57:56PM +0200, Daniel Vetter wrote: On Thu, Aug 14, 2014 at 12:37:53PM -0700, Jesse Barnes wrote: On Mon, 11 Aug 2014 23:33:57 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Mon, Aug 11, 2014 at 11:08:38AM -0700, Daisy Sun wrote: BDW supports GT C0

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Render state init for Execlists

2014-08-28 Thread Daniel Vetter
On Thu, Aug 21, 2014 at 11:40:54AM +0100, Thomas Daniel wrote: From: Oscar Mateo oscar.ma...@intel.com The batchbuffer that sets the render context state is submitted in a different way, and from different places. We needed to make both the render state preparation and free functions

[Intel-gfx] [PULL] drm-intel-fixes

2014-08-28 Thread Jani Nikula
Hi Dave - Some more fixes for 3.17, mostly stable material. BR, Jani. The following changes since commit 52addcf9d6669fa439387610bc65c92fa0980cef: Linux 3.17-rc2 (2014-08-25 15:36:20 -0700) are available in the git repository at: git://anongit.freedesktop.org/drm-intel

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

2014-08-28 Thread Sean V Kelley
On Mon, Aug 25, 2014 at 3:22 AM, Jani Nikula jani.nik...@intel.com wrote: [just moving from lkml to intel-gfx for a better fitting audience] On Mon, 25 Aug 2014, Jani Nikula jani.nik...@intel.com wrote: On Fri, 22 Aug 2014, Eric Rannaud eric.rann...@gmail.com wrote: Hi, Between 3.15.4

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

2014-08-28 Thread Eric Rannaud
On Thu, Aug 28, 2014 at 9:41 AM, Sean V Kelley sean.v.kel...@intel.com wrote: For what it's worth, I have a Mid-2014, Macbook Pro Retina (13inch display), running Archlinux with 3.16. Definitely, enable_fbc is a win for me and I do manually enable it. But I am still seeing what I believe to

[Intel-gfx] [PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

2014-08-28 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Due to the upcoming atomic modesetting feature we need to separate some update functions into a check step that can fail and a commit step that should, ideally, never fail. This commit splits intel_update_plane() and its commit part can still

[Intel-gfx] [PATCH 8/9] drm/i915: return error if fb is NULL

2014-08-28 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk intel_pipe_check_base() should return an error is the fb received is set to NULL. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Intel-gfx] [PATCH 9/9] drm/i915: split intel_pipe_set_base() into check() and commit()

2014-08-28 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Take out some parts of code that can fail from it and move them to intel_pipe_check_base(), the only failure point in intel_pipe_set_base() now is the fb pinning procudure. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk ---

[Intel-gfx] [PATCH 6/9] drm/i915: split intel_crtc_cursor_set_obj() into check() and commit()

2014-08-28 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Create intel_crtc_cursor_create_obj() to check any need setting before we call intel_crtc_cursor_set_obj() to apply the cursor updates. intel_crtc_cursor_check_obj() must always be called before intel_crtc_cursor_set_obj(). Signed-off-by:

[Intel-gfx] [PATCH 3/9] drm/i915: fix memleak in intel_set_config_save_state()

2014-08-28 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk If the save_encoder_crtcs or save_connector_encoders allocation fail we need to free everything we have already allocated. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/i915/intel_display.c | 10

[Intel-gfx] [PATCH 1/9] drm/i915: init sprites with univeral plane init function

2014-08-28 Thread Gustavo Padovan
From: Derek Foreman derek.fore...@collabora.co.uk Really just for completeness - old init function ends up making the plane exactly the same way due to the way the enums are set up. Signed-off-by: Derek Foreman derek.fore...@collabora.co.uk --- drivers/gpu/drm/i915/intel_sprite.c | 8

[Intel-gfx] [PATCH 7/9] drm/i915: split intel_primary_plane_setplane() into check() and commit()

2014-08-28 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk As a preparation for atomic updates we need to split the code to check everything we are going to commit first. This patch starts the work to split intel_primary_plane_setplane() into check() and commit() parts. More work is expected on this

[Intel-gfx] [PATCH 5/9] drm/i915: split intel_cursor_plane_update() into check() and commit()

2014-08-28 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Due to the upcoming atomic modesetting feature we need to separate some update functions into a check step that can fail and a commit step that should, ideally, never fail. The commit part can still fail, but that should be solved in another

[Intel-gfx] [PATCH 2/9] drm/i915: trivial: remove unneed set to NULL

2014-08-28 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk At this point of the code the obj var is already NULL, so we don't need to set it again to NULL. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/i915/intel_display.c | 1 - 1 file changed, 1 deletion(-)

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

2014-08-28 Thread Lu, Ran
Hi, On Tuesday 26 August 2014 16:00:51, Eric Rannaud wrote: On Tue, Aug 26, 2014 at 1:59 PM, Daniel Vetter daniel.vet...@ffwll.ch wrote: Forcing FBC with i915.enable_fbc=1 brings the idle power consumption back to under 7W, however. This is all on 3.15.4-ARCH-00041-gf4db98240ac2. Any