Re: [Intel-gfx] [RFC v2 3/4] drm/panel: Add new panel driver based on crystal cove pmic

2015-01-12 Thread Kumar, Shobhit
On 1/9/2015 6:38 PM, Jani Nikula wrote: On Fri, 02 Jan 2015, Shobhit Kumar shobhit.ku...@intel.com wrote: This driver provides support for the crystal_cove_panel cell device. On BYT-T pmic has to be used to enable/disable panel. This needs to be sent to dri-devel. Will do for the updated

Re: [Intel-gfx] WARNING at drivers/gpu/drm/i915/intel_audio.c:291 ilk_audio_codec_disable

2015-01-12 Thread Jani Nikula
On Sun, 11 Jan 2015, Daniel Borkmann dbork...@redhat.com wrote: I constantly get this warning triggered on bootup. Any ideas? ;) Please add drm.debug=14 module parameter, and share the dmesg all the way from the beginning. BR, Jani. Thanks a lot, Daniel [...] [4.634728] [drm] Memory

Re: [Intel-gfx] [RFC v2 3/4] drm/panel: Add new panel driver based on crystal cove pmic

2015-01-12 Thread Kumar, Shobhit
On 1/12/2015 1:56 PM, Kumar, Shobhit wrote: On 1/9/2015 6:38 PM, Jani Nikula wrote: On Fri, 02 Jan 2015, Shobhit Kumar shobhit.ku...@intel.com wrote: This driver provides support for the crystal_cove_panel cell device. On BYT-T pmic has to be used to enable/disable panel. This needs to be

Re: [Intel-gfx] [RFC v2 4/4] drm/i915: Enable DSI panel enable/disable based on PMIC

2015-01-12 Thread Kumar, Shobhit
On 1/9/2015 6:47 PM, Jani Nikula wrote: On Fri, 02 Jan 2015, Shobhit Kumar shobhit.ku...@intel.com wrote: This allows for proper PPS during enable/disable of BYT-T platforms where these signals are routed through PMIC. Needs DRM_PANEL to be selected by default as well Signed-off-by: Shobhit

Re: [Intel-gfx] drm stuck on render ring starting xlock on a x201 using SNA

2015-01-12 Thread Chris Wilson
On Sun, Jan 11, 2015 at 07:06:19PM -0500, Charles Devereaux wrote: Hello Aftertrying to leave an xlock started with  xlock -nolock +use3d -mode gears, I get a drm stuck on render ring error. The funny thing is this problem did not happen on the exact same thinkpad x201 laptop

[Intel-gfx] [PATCH i-g-t v2] lib/Android.mk: add -DHAVE_LINUX_KD_H to fix android build

2015-01-12 Thread tim . gore
From: Tim Gore tim.g...@intel.com commit cf93bc8df9f5f94a0aedc8b52bad0ad4e036737c by Alan Coopersmith (introduced to enable solaris builds) reqires HAVE_LINUX_KD_H to be set in order for kd.h to get picked up in igt_kms.c. This is not currently set in the Android makefile so Android builds are

[Intel-gfx] [PATCH i-g-t] tests/gem_exec_params: change flags used in invalid-flags test

2015-01-12 Thread tim . gore
From: Tim Gore tim.g...@intel.com The invalid-flags test in gem_exec_params uses (I915_EXEC_HANDLE_LUT 1) as an invalid flag, but this is no longer invalid for recent android versions, and may not be invalid in Linux in the future. So I have changed this test to use (__I915_EXEC_UNKNOWN_FLAGS)

[Intel-gfx] [PATCH] drm/i915: fix build for CONFIG_BUG=n

2015-01-12 Thread Jani Nikula
If CONFIG_BUG=n __WARN_printf won't be defined leading to the below build failure. The double underscores should have told us to steer clear of it anyway. drivers/gpu/drm/i915/intel_display.c: In function ‘assert_pll’: drivers/gpu/drm/i915/intel_display.c:1027:2: error: implicit declaration of

Re: [Intel-gfx] [PATCH] drm/i915: Enable the HiZ RAW Stall Optimization on Gen8.

2015-01-12 Thread Ville Syrjälä
On Sat, Jan 10, 2015 at 06:44:49PM -0800, Kenneth Graunke wrote: This is an important optimization for avoiding read-after-write (RAW) stalls in the HiZ buffer. Certain workloads would run very slowly with HiZ enabled, but run much faster with the hiz=false driconf option. With this patch,

Re: [Intel-gfx] [PATCH] drm/i915: Improve HiZ throughput on Cherryview.

2015-01-12 Thread Ville Syrjälä
On Sat, Jan 10, 2015 at 06:02:22PM -0800, Kenneth Graunke wrote: Found by reading the HIZ_CHICKEN documentation. Improves performance in a HiZ microbenchmark by around 50%. Improves performance in OglZBuffer by around 18%. Thanks to Chris Wilson for helping me figure out where to put this.

Re: [Intel-gfx] [PATCH] drm/i915: fix inconsistent brightness after resume

2015-01-12 Thread Jani Nikula
On Sat, 10 Jan 2015, Jeremiah Mahler jmmah...@gmail.com wrote: Commit 6dda730e55f4 introduced a bug which resulted in inconsistent brightness levels on different machines. If a suspended was entered with the screen off some machines would resume with the screen at minimum brightness and others

Re: [Intel-gfx] [Mesa-dev] [PATCH] drm/i915: Enable the HiZ RAW Stall Optimization on Gen8.

2015-01-12 Thread Ville Syrjälä
On Sun, Jan 11, 2015 at 07:14:57PM -0800, Ben Widawsky wrote: On Sun, Jan 11, 2015 at 07:05:21PM -0800, Kenneth Graunke wrote: On Sunday, January 11, 2015 05:46:09 PM Ben Widawsky wrote: On Sun, Jan 11, 2015 at 04:05:25PM -0800, Kenneth Graunke wrote: On Sunday, January 11, 2015 01:49:41

Re: [Intel-gfx] [PATCH] drm/i915: Cleaning up encoder in the end on intel_dp_encoder_destroy

2015-01-12 Thread Ville Syrjälä
On Mon, Jan 12, 2015 at 10:30:41AM +0530, Sonika Jindal wrote: We clean up the encoder and then try to acquire pps_lock where it tries to get the encoder. So moving the cleanup to the end. Suggested-by: Satheeshakrishna M satheeshakrishn...@intel.com Signed-off-by: Sonika Jindal

[Intel-gfx] [PATCH 3/4] drm/i915: Remove FIXME_lrc_ctx backpointer

2015-01-12 Thread Nick Hoath
The first pass implementation of execlists required a backpointer to the context to be held in the intel_ringbuffer. However the context pointer is available higher in the call stack. Remove the backpointer from the ring buffer structure and instead pass it down through the call stack. v2:

[Intel-gfx] [PATCH 1/4] drm/i915: execlist request keeps ptr/ref to gem_request

2015-01-12 Thread Nick Hoath
Add a reference and pointer from the execlist queue item to the associated gem request. For execlist requests that don't have a request, create one as a placeholder. Issue: VIZ-4274 v1: Rebase after upstream of Replace seqno values with request structures patchset. Signed-off-by: Nick Hoath

[Intel-gfx] [PATCH] drm/i915: Initialize primary plane src/dst coords when reading hw state

2015-01-12 Thread Ander Conselvan de Oliveira
Otherwise setting the rotation property will cause the primary plane to be disabled, caused by having a 0x0 initial value. Cc: sta...@vger.kernel.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87662 Signed-off-by: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com ---

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_exec_params: change flags used in invalid-flags test

2015-01-12 Thread Gore, Tim
-Original Message- From: Gordon, David S Sent: Monday, January 12, 2015 4:04 PM To: Gore, Tim; intel-gfx@lists.freedesktop.org Cc: Wood, Thomas Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/gem_exec_params: change flags used in invalid-flags test On 12/01/15 14:09,

Re: [Intel-gfx] [PATCH] drm/i915: cleanup lrc engine state when lrc is freed

2015-01-12 Thread Ville Syrjälä
On Fri, Jan 09, 2015 at 06:47:41PM +, Dave Gordon wrote: On 08/01/15 13:40, Mika Kuoppala wrote: i915_gem_validate_context() will check the engine-state to see if it can submit into a ringbuffer. But when we are releasing the context we leave the engine state to a non null value. Thus

[Intel-gfx] [PATCH v2] drm/i915: fix inconsistent brightness after resume

2015-01-12 Thread Jeremiah Mahler
Commit 6dda730e55f4 introduced a bug which resulted in inconsistent brightness levels on different machines. If a suspended was entered with the screen off some machines would resume with the screen at minimum brightness and others at maximum brightness. The following commands can be used to

Re: [Intel-gfx] [PATCH] drm/i915: fix build for CONFIG_BUG=n

2015-01-12 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 354/354

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Subsume intel_ctx_submit_request in to drm_i915_gem_request

2015-01-12 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV -2 354/354

[Intel-gfx] [PATCH] Revert drm/i915/chv: Use timeout mode for RC6 on chv

2015-01-12 Thread Rodrigo Vivi
This reverts commit 5a0afd4b78ec23f27f5d486ac3d102c2e8d66bd7. Although timeout mode allows higher residency it impact badly on performance. I believe while we don't have a way to balance between performance and power savings at runtime I believe we have to revert and prioritize performance that

Re: [Intel-gfx] [PATCH] drm/i915: Enable the HiZ RAW Stall Optimization on Gen8.

2015-01-12 Thread Kenneth Graunke
On Monday, January 12, 2015 02:32:20 PM Ville Syrjälä wrote: On Sat, Jan 10, 2015 at 06:44:49PM -0800, Kenneth Graunke wrote: This is an important optimization for avoiding read-after-write (RAW) stalls in the HiZ buffer. Certain workloads would run very slowly with HiZ enabled, but run

Re: [Intel-gfx] [PATCH 3.16.y-ckt 030/168] drm/i915: Handle failure to kick out a conflicting fb driver

2015-01-12 Thread Daniel Vetter
On Mon, Jan 12, 2015 at 6:43 PM, Luis Henriques luis.henriq...@canonical.com wrote: On Mon, Jan 12, 2015 at 06:20:22PM +0100, Daniel Vetter wrote: On Sun, Jan 11, 2015 at 10:49 PM, Ben Hutchings b...@decadent.org.uk wrote: On Mon, 2014-12-15 at 14:24 +, Luis Henriques wrote: 3.16.7-ckt3

[Intel-gfx] [PULL] topic/i915-hda-componentized

2015-01-12 Thread Daniel Vetter
Hi Takashi, So here's the stable tag with Imre's i915/hda componentized refactoring, based upon 3.19-rc4. I'll pull in the same tag into drm-intel-next. Cheers, Daniel The following changes since commit eaa27f34e91a14cdceed26ed6c6793ec1d186115: linux 3.19-rc4 (2015-01-11 12:44:53 -0800)

Re: [Intel-gfx] [PATCH v2] drm/i915: Add the predicate source registers to the register whitelist

2015-01-12 Thread Daniel Vetter
On Fri, Jan 09, 2015 at 04:41:10PM +, Neil Roberts wrote: Hi, Daniel Vetter dan...@ffwll.ch writes: Ok, I've merged this one, since that means you at least won't get an -EINVAL. But you can't yet enable the feature in mesa since it's still no-opped out. Let's hope that v3 actually

Re: [Intel-gfx] [RFC v2 1/4] drm: Add support to find drm_panel by name

2015-01-12 Thread Daniel Vetter
On Fri, Jan 9, 2015 at 1:50 PM, Jani Nikula jani.nik...@intel.com wrote: I have a slightly uneasy feeling about handing out drm_panel pointers (both from here and of_drm_find_panel) without refcounting. If the panel driver gets removed, whoever called the find functions will have a dangling

Re: [Intel-gfx] [PATCH 0/7] drm/i915: Disable hpd for disabled eDP ports

2015-01-12 Thread Sean V Kelley
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/09/2015 04:21 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com My BSW has a nasty problem where it generates tons of spurious hpd interrupts when the eDP display is disabled. The best solution

Re: [Intel-gfx] [PATCH] drm/i915: Initialize primary plane src/dst coords when reading hw state

2015-01-12 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 354/354

[Intel-gfx] [965GM kms] Many kernel warnings, resume-from-suspend broken

2015-01-12 Thread Gilles-Philippe Morin
Hello, I am in deep trouble now that I have upgraded to Fedora 21. My main production computer — a Dell Inspiron 1525 laptop — fails most of the time to resume from RAM suspend and thus I cannot use it at school anymore. At the same time, this issue is accompanied by many graphical issues. I do

[Intel-gfx] [PATCH 2/3] tests/gem_exec_params: check the invalid flags for dual bsd ring

2015-01-12 Thread Zhipeng Gong
v2: add more tests to address Daniel's comments(Zhipeng) Signed-off-by: Zhipeng Gong zhipeng.g...@intel.com --- tests/gem_exec_params.c | 41 + 1 file changed, 41 insertions(+) diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c index

[Intel-gfx] [PATCH 3/3] test/gem_dummy_reloc_loop: add tests for dual bsd ring

2015-01-12 Thread Zhipeng Gong
Signed-off-by: Zhipeng Gong zhipeng.g...@intel.com --- tests/gem_dummy_reloc_loop.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/gem_dummy_reloc_loop.c b/tests/gem_dummy_reloc_loop.c index 335700d..5e0a10a 100644 --- a/tests/gem_dummy_reloc_loop.c +++

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_exec_params: change flags used in invalid-flags test

2015-01-12 Thread Daniel Vetter
On Mon, Jan 12, 2015 at 04:14:03PM +, Gore, Tim wrote: -Original Message- From: Gordon, David S Sent: Monday, January 12, 2015 4:04 PM To: Gore, Tim; intel-gfx@lists.freedesktop.org Cc: Wood, Thomas Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/gem_exec_params: change

Re: [Intel-gfx] [RFC v2 4/4] drm/i915: Enable DSI panel enable/disable based on PMIC

2015-01-12 Thread Daniel Vetter
On Mon, Jan 12, 2015 at 01:53:08PM +0530, Kumar, Shobhit wrote: static bool intel_dsi_get_hw_state(struct intel_encoder *encoder, @@ -896,6 +901,17 @@ void intel_dsi_init(struct drm_device *dev) fixed_mode-type |= DRM_MODE_TYPE_PREFERRED; intel_panel_init(intel_connector-panel,

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Don't register HDMI connectors for eDP ports on VLV/CHV

2015-01-12 Thread Daniel Vetter
On Fri, Jan 09, 2015 at 05:02:40PM +0200, Jani Nikula wrote: On Fri, 09 Jan 2015, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com If we determine that a specific port is eDP, don't register the HDMI connector/encoder for it. The reason being that we

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Don't pretend SDVO hotplug works on 915

2015-01-12 Thread Daniel Vetter
On Fri, Jan 09, 2015 at 02:21:15PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com 915 doens't support hotplug at all, so we shouldn't try to pretend otherwise in the SDVO code. It actually has a hpd pin, but since it's just one for all ports we

Re: [Intel-gfx] [Mesa-dev] [PATCH] drm/i915: Enable the HiZ RAW Stall Optimization on Gen8.

2015-01-12 Thread Ben Widawsky
On Mon, Jan 12, 2015 at 06:09:12PM +, Dave Gordon wrote: On 12/01/15 18:02, Ben Widawsky wrote: On Mon, Jan 12, 2015 at 02:02:34PM +0200, Ville Syrjälä wrote: On Sun, Jan 11, 2015 at 07:14:57PM -0800, Ben Widawsky wrote: On Sun, Jan 11, 2015 at 07:05:21PM -0800, Kenneth Graunke wrote:

[Intel-gfx] [PATCH i-g-t 0/3] tests: Add tests for new exec flags to export two bsd rings

2015-01-12 Thread Zhipeng Gong
The Broadwell GT3 machine has two independent BSD rings that can be used to process the video commands. New execution flags are added to export the two rings to userspace so that userspace can specify the bsd ring. The LOCAL_ flags could be removed when this patch is merged into libdrm and i-g-t

[Intel-gfx] [PATCH 1/3] i-g-t: check whether kernel has dual bsd ring

2015-01-12 Thread Zhipeng Gong
v2: change the number to be consistent with upstream (Zhipeng) Signed-off-by: Zhipeng Gong zhipeng.g...@intel.com --- lib/ioctl_wrappers.c | 16 lib/ioctl_wrappers.h | 1 + 2 files changed, 17 insertions(+) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c index

[Intel-gfx] [PATCH 2/2] drm/i915: add I915_PARAM_HAS_BSD2 to i915_getparam

2015-01-12 Thread Zhipeng Gong
This will let userland only try to use the new ring when the appropriate kernel is present v2: change the number to be consistent with upstream (Zhipeng) Signed-off-by: Zhipeng Gong zhipeng.g...@intel.com Reviewed--by: Rodrigo Vivi rodrigo.v...@intel.com (for v1) ---

[Intel-gfx] [PATCH 1/2] drm/i915: Specify bsd rings through exec flag

2015-01-12 Thread Zhipeng Gong
On Skylake GT3 we have 2 Video Command Streamers (VCS), which is asymmetrical. For example, HEVC GPU commands can be only dispatched to VCS1 ring. But userspace has no control when using VCS1 or VCS2. This patch introduces a mechanism to avoid the default ping-pong mode and use one specific ring

Re: [Intel-gfx] [PATCH 9/9] drm/i915: PSR: Expose wakeup time.

2015-01-12 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 354/354

Re: [Intel-gfx] [PATCH] drm/i915: Initialize primary plane src/dst coords when reading hw state

2015-01-12 Thread Daniel Vetter
On Mon, Jan 12, 2015 at 05:36:52PM +0200, Ander Conselvan de Oliveira wrote: Otherwise setting the rotation property will cause the primary plane to be disabled, caused by having a 0x0 initial value. Cc: sta...@vger.kernel.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87662

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add I915_PARAM_HAS_BSD2 to i915_getparam

2015-01-12 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 354/354

Re: [Intel-gfx] [PULL] topic/i915-hda-componentized

2015-01-12 Thread Takashi Iwai
At Mon, 12 Jan 2015 23:47:42 +0100, Daniel Vetter wrote: Hi Takashi, So here's the stable tag with Imre's i915/hda componentized refactoring, based upon 3.19-rc4. I'll pull in the same tag into drm-intel-next. Great, I pulled the branch now. Thanks! Takashi Cheers, Daniel The

[Intel-gfx] [PATCH 4/4] drm/i915: Subsume intel_ctx_submit_request in to drm_i915_gem_request

2015-01-12 Thread Nick Hoath
Move all remaining elements that were unique to execlists queue items in to the associated request. Issue: VIZ-4274 v2: Rebase. Fixed issue of overzealous freeing of request. v3: Removed re-addition of cleanup work queue (found by Daniel Vetter) v4: Rebase. v5: Actual removal of

[Intel-gfx] [PATCH 0/4] drm/i915: Untangle execlist tracking

2015-01-12 Thread Nick Hoath
This patchset merges execlist queue items in to gem requests. It does this by using the reference count added by the Replace seqno values with request structures patchset to ensure that the gem request is available for the whole execlist submission lifespan. v2: merge intel_ctx_submit_request

[Intel-gfx] [PATCH 2/4] drm/i915: Removed duplicate members from submit_request

2015-01-12 Thread Nick Hoath
Where there were duplicate variables for the tail, context and ring (engine) in the gem request and the execlist queue item, use the one from the request and remove the duplicate from the execlist queue item. Issue: VIZ-4274 v1: Rebase v2: Fixed build issues. Keep separate postfix tail pointers

[Intel-gfx] [PATCH 4/9] drm/i915: Add missing vbt check.

2015-01-12 Thread Rodrigo Vivi
Let's respect vbt full_link (link_standby) on source side as well. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index

[Intel-gfx] [PATCH 9/9] drm/i915: PSR: Expose wakeup time.

2015-01-12 Thread Rodrigo Vivi
This will be useful for automated test to know for how long to wait for PSR to comeback before time out. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_psr.c| 5 +++-- 3

[Intel-gfx] [PATCH 3/9] drm/i915: PSR HSW/BDW: Fix inverted logic at sink main_link_active bit.

2015-01-12 Thread Rodrigo Vivi
We have only two possible states with so many names and combinations that might be confusing. 1 - Main link active / enabled / stand by / on 2 - Main link disabled / off / full off Let's start organizing it by fixing a inverted logic when setting the sink bit. Signed-off-by: Rodrigo Vivi

[Intel-gfx] [PATCH 1/9] drm/i915: VLV/CHV PSR needs to exit PSR on every flush.

2015-01-12 Thread Rodrigo Vivi
ON these platforms we don't have hardware tracking working for any case. So we need to fake this on software by forcing psr to exit on every flush. Manual tests indicated this was needed. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/intel_psr.c | 6 ++ 1 file

[Intel-gfx] [PATCH 2/9] drm/i915: PSR VLV/CHV: Remove condition checks that only applies to Haswell.

2015-01-12 Thread Rodrigo Vivi
These conditions applies only to Haswell and we were also checking for them on Valleyview/Cherryview. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/intel_psr.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git

[Intel-gfx] [PATCH 7/9] drm/i915: PSR VLV/CHV: let's respect link_standby here as well.

2015-01-12 Thread Rodrigo Vivi
Let's respect vbt and panel for link_standby/on x link_disabled Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/intel_psr.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_psr.c

[Intel-gfx] [PATCH 5/9] drm/i915: group link_standby setup and let this info visible everywhere.

2015-01-12 Thread Rodrigo Vivi
No functional changes on this patch. Just grouping the link_standy decision to avoid miss any change and also making this info available everywhere what will help to decide when to use vbt's tp time on following patch. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com ---

[Intel-gfx] [PATCH 0/9] PSR stability patches for HSW/BDW and VLV/CHV.

2015-01-12 Thread Rodrigo Vivi
Here goes my latest work on PSR for better stability. Unfortunatelly I'm not enabling it by default yet because it still needs to be intensivelly validated and there is one still pending flicker when I force link standby on HSW BDW. Since I'm going to start the bug maintainance team now I'm

Re: [Intel-gfx] [PATCH] Add jobserver flag (+) to deb-pkg build commands

2015-01-12 Thread Dave Gordon
On 09/01/15 16:14, Gordon, David S wrote: This gets rid of some annoying warnings and allows GNU make to parallelise more parts of a deb-pkg build. The message is ... make[3]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. ... so I've added the '+' as

[Intel-gfx] [PATCH 6/9] drm/i915: PSR link standby at debugfs

2015-01-12 Thread Rodrigo Vivi
It is useful to know at debug time if we are keeping main link on. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index

[Intel-gfx] [PATCH 8/9] drm/i915: PSR: respect vbt time for link trains when available.

2015-01-12 Thread Rodrigo Vivi
If link is off we need to give enough time for source to do link train. This time is usually set at VBT. VBT tp time comse in multiple of hundreds. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/intel_psr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [Intel-gfx] [Mesa-dev] [PATCH] drm/i915: Enable the HiZ RAW Stall Optimization on Gen8.

2015-01-12 Thread Dave Gordon
On 12/01/15 18:02, Ben Widawsky wrote: On Mon, Jan 12, 2015 at 02:02:34PM +0200, Ville Syrjälä wrote: On Sun, Jan 11, 2015 at 07:14:57PM -0800, Ben Widawsky wrote: On Sun, Jan 11, 2015 at 07:05:21PM -0800, Kenneth Graunke wrote: On Sunday, January 11, 2015 05:46:09 PM Ben Widawsky wrote: On

[Intel-gfx] [PATCH i-g-t 15/15] tests/kms_psr_sink_crc: Add own loop.

2015-01-12 Thread Rodrigo Vivi
Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- tests/kms_psr_sink_crc.c | 119 --- 1 file changed, 61 insertions(+), 58 deletions(-) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index 9616b4c..741c45d 100644 ---

[Intel-gfx] [PATCH i-g-t 11/15] test/kms_psr_sink_crc: Split plane setup operations

2015-01-12 Thread Rodrigo Vivi
No functional changes. This reorg will allow to do some operations like suspend/resume and dpms off/on at some specific points where we know PSR state. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- tests/kms_psr_sink_crc.c | 141 +-- 1 file

[Intel-gfx] [PATCH i-g-t 12/15] test/kms_psr_sink_crc: Add suspend/resume tests

2015-01-12 Thread Rodrigo Vivi
Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- tests/kms_psr_sink_crc.c | 24 1 file changed, 24 insertions(+) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index 4e4a4cd..331ac5b 100644 --- a/tests/kms_psr_sink_crc.c +++

[Intel-gfx] [PATCH i-g-t 08/15] lib/igt_aux: Introduce igt_debug_warn_and_wait_for_key.

2015-01-12 Thread Rodrigo Vivi
This is an extention of igt_debug_wait_for_keypress that also can have customized message and return key pressed. v2: This is actualy a v2. V1 was an extension of original igt_debug_wait_for_keypress but it was nacked. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- lib/igt_aux.c |

[Intel-gfx] [PATCH i-g-t 10/15] tests/kms_psr_sink_crc: Use PSR wakeup 2 + timeout for waiting psr active.

2015-01-12 Thread Rodrigo Vivi
This wakeup time is now set from VBT and sometimes it can be bigger than 10 seconds we used here. So let's use at least 2 seconds plus VBT. We grab this info from debugfs. Also since this timeout can be bigger, in manual mode we warn tester we are waiting. Signed-off-by: Rodrigo Vivi

[Intel-gfx] [PATCH i-g-t 02/15] tests/kms_psr_sink_crc: Make render visible to human eyes

2015-01-12 Thread Rodrigo Vivi
This will allow manual tests when crc isn't available. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- tests/kms_psr_sink_crc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index ad440a8..892bba6 100644 ---

[Intel-gfx] [PATCH i-g-t 01/15] tests/kms_psr_sink_crc: Make blt visible to human eyes

2015-01-12 Thread Rodrigo Vivi
This will allow manual tests when crc isn't available. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- tests/kms_psr_sink_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index 98b60cf..ad440a8 100644 ---

[Intel-gfx] [PATCH i-g-t 13/15] test/kms_psr_sink_crc: Add dpms off/on tests.

2015-01-12 Thread Rodrigo Vivi
Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- tests/kms_psr_sink_crc.c | 33 + 1 file changed, 33 insertions(+) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index 331ac5b..9616b4c 100644 --- a/tests/kms_psr_sink_crc.c +++

[Intel-gfx] [PATCH i-g-t 07/15] tests/kms_psr_sink_crc: Add manual mode.

2015-01-12 Thread Rodrigo Vivi
Sink CRC is the most reliable way to test PSR. However in some platforms apparently auto generated packages force panel to keep calculating CRC invalidating our current sink crc check over debugfs. So, this manual test help us to find possible gaps on this platforms where we cannot trust on

[Intel-gfx] [PATCH i-g-t 09/15] tests/kms_psr_sink_crc: Use pressed key to pass/fail.

2015-01-12 Thread Rodrigo Vivi
This is useful when 1 person is running all tests and other one is reading log willing to know what tests passed and which failed. So tester is able to run all tests without stop and send log to developer. v2: Rebased after igt_debug_warn_and_wait_for_key Signed-off-by: Rodrigo Vivi

[Intel-gfx] [PATCH i-g-t 03/15] tests/kms_psr_sink_crc: Make mmaps visible to human eyes

2015-01-12 Thread Rodrigo Vivi
this will allow manual tests when crc isn't available. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- tests/kms_psr_sink_crc.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index

[Intel-gfx] [PATCH i-g-t 06/15] lib: s/IGT_DEBUG_INTERACTIVE/--interactive-debug=var

2015-01-12 Thread Rodrigo Vivi
Use cmdline variable for interactive debug instead of env var. v2: Make interactive-debug domain optional and use all when not set. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- lib/igt_aux.c | 20 ++-- lib/igt_aux.h | 2 +- lib/igt_core.c | 9 +

[Intel-gfx] [PATCH i-g-t 14/15] lib/igt_core: introduce --loop.

2015-01-12 Thread Rodrigo Vivi
This loop option can help intensive tests everywhere. The only caveat is that tests reimplementing main function has to implement his own loop. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- lib/igt_core.c | 11 +++ lib/igt_core.h | 18 -- 2 files changed, 23

[Intel-gfx] [PATCH i-g-t 04/15] tests/kms_psr_sink_crc: Make plane_move visible to human eyes

2015-01-12 Thread Rodrigo Vivi
this will allow manual tests when crc isn't available. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- tests/kms_psr_sink_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index 865ac70..155c25f 100644 ---

[Intel-gfx] [PATCH i-g-t 05/15] lib/igt_aux: Don't remove echo from terminal

2015-01-12 Thread Rodrigo Vivi
It is simply annoying to loose terminal echo. When debugging many times you CTRL+C on terminal to kill test while it is waiting for key and than you keep without echo. And this function is used whey you are debugging in manual modes. So let's keep ECHO. Signed-off-by: Rodrigo Vivi

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_exec_params: change flags used in invalid-flags test

2015-01-12 Thread Dave Gordon
On 12/01/15 14:09, tim.g...@intel.com wrote: From: Tim Gore tim.g...@intel.com The invalid-flags test in gem_exec_params uses (I915_EXEC_HANDLE_LUT 1) as an invalid flag, but this is no longer invalid for recent android versions, and may not be invalid in Linux in the future. So I have

Re: [Intel-gfx] [PATCH 3.16.y-ckt 030/168] drm/i915: Handle failure to kick out a conflicting fb driver

2015-01-12 Thread Luis Henriques
On Mon, Jan 12, 2015 at 06:20:22PM +0100, Daniel Vetter wrote: On Sun, Jan 11, 2015 at 10:49 PM, Ben Hutchings b...@decadent.org.uk wrote: On Mon, 2014-12-15 at 14:24 +, Luis Henriques wrote: 3.16.7-ckt3 -stable review patch. If anyone has any objections, please let me know.

Re: [Intel-gfx] Question regarding forcewake in i915

2015-01-12 Thread Dave Gordon
On 07/01/15 08:13, Jaeyong Yoo wrote: Thanks a lot. It is very helpful. Couple of follow-up questions below. -Original Message- From: Dave Gordon [mailto:david.s.gor...@intel.com] Sent: Wednesday, January 07, 2015 12:19 AM To: jaeyong@samsung.com Cc:

Re: [Intel-gfx] [Mesa-dev] [PATCH] drm/i915: Enable the HiZ RAW Stall Optimization on Gen8.

2015-01-12 Thread Ben Widawsky
On Mon, Jan 12, 2015 at 02:02:34PM +0200, Ville Syrjälä wrote: On Sun, Jan 11, 2015 at 07:14:57PM -0800, Ben Widawsky wrote: On Sun, Jan 11, 2015 at 07:05:21PM -0800, Kenneth Graunke wrote: On Sunday, January 11, 2015 05:46:09 PM Ben Widawsky wrote: On Sun, Jan 11, 2015 at 04:05:25PM

Re: [Intel-gfx] [PATCH 3.16.y-ckt 030/168] drm/i915: Handle failure to kick out a conflicting fb driver

2015-01-12 Thread Ben Hutchings
On Mon, 2015-01-12 at 18:20 +0100, Daniel Vetter wrote: On Sun, Jan 11, 2015 at 10:49 PM, Ben Hutchings b...@decadent.org.uk wrote: On Mon, 2014-12-15 at 14:24 +, Luis Henriques wrote: 3.16.7-ckt3 -stable review patch. If anyone has any objections, please let me know.

Re: [Intel-gfx] [PATCH 3.16.y-ckt 030/168] drm/i915: Handle failure to kick out a conflicting fb driver

2015-01-12 Thread Daniel Vetter
On Sun, Jan 11, 2015 at 10:49 PM, Ben Hutchings b...@decadent.org.uk wrote: On Mon, 2014-12-15 at 14:24 +, Luis Henriques wrote: 3.16.7-ckt3 -stable review patch. If anyone has any objections, please let me know. -- From: Chris Wilson ch...@chris-wilson.co.uk commit

Re: [Intel-gfx] [PATCH] drm/i915: fix inconsistent brightness after resume

2015-01-12 Thread Jeremiah Mahler
Jani, On Mon, Jan 12, 2015 at 12:31:09PM +0200, Jani Nikula wrote: On Sat, 10 Jan 2015, Jeremiah Mahler jmmah...@gmail.com wrote: [...] I think part of the problem is that the userspace sets brightness to minimum before suspend, but apparently does not restore it after resume. The dmesg