Re: [Intel-gfx] [PATCH 10/14] drm/i915: Add MIPI_IO WA

On Thu, 12 Jan 2017, Mika Kahola wrote: > This is definitely needed to pass igt test on bxt > > 'gem_exec_suspend --run-subtest basic-S3' > > Tested-by: Mika Kahola > > On Mon, 2017-01-09 at 14:46 +0530, Vidya Srinivas wrote: >> From: Uma Shankar

Re: [Intel-gfx] [PATCH 29/37] drm/i915: Fill different pages of the GTT

On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote: > Exercise filling different pages of the GTT > > Signed-off-by: Chris Wilson > +static int walk_hole(struct drm_i915_private *i915, > > +  struct i915_address_space *vm, > > +  u64

Re: [Intel-gfx] [PATCH] drm/i915: Fix up kerneldoc parameters for i915_gem_gtt_*()

On to, 2017-01-12 at 16:45 +, Chris Wilson wrote: > Parameter: good. > Parameter - bad. > > One day I'll learn the syntax. > > Fixes: 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a > helper") > Fixes: e007b19d7ba7 ("drm/i915: Use the MRU stack search after evicting") >

Re: [Intel-gfx] DP compliance failure due to dithering for 18bpp video pattern

On Fri, 13 Jan 2017, Manasi Navare wrote: > On Thu, Jan 12, 2017 at 03:41:07PM -0800, Rodrigo Vivi wrote: >> On Thu, Jan 12, 2017 at 3:30 PM, Manasi Navare >> wrote: >> > On Thu, Jan 12, 2017 at 12:32:09PM +0200, Jani Nikula wrote: >> >> On

Re: [Intel-gfx] [PATCH] dim: Triple-check and tripe warning when merging patches that touch files outside i915.

On Fri, 13 Jan 2017, Rodrigo Vivi wrote: > Most of commiters already knows that by heart and also dim already > have this warning. So maybe this is just Bart writing to blackboard. Duh! > > Anyway for my own usage this tripe check will help for sure. > Maybe it help

Re: [Intel-gfx] [PATCH v5 0/3] support DP MST audio

>-Original Message- >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter >Sent: Thursday, January 12, 2017 5:10 PM >To: Jani Nikula >Cc: Yang, Libin ; intel-gfx@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH 05/10] drm/i915/psr: enable ALPM for psr2

patches 3, 4 and 5 merged to dinq. Thanks for patches and reviews. On Thu, Jan 5, 2017 at 12:38 PM, Jim Bride wrote: > On Mon, Jan 02, 2017 at 05:00:58PM +0530, vathsala nagaraju wrote: >> As per edp1.4 spec , alpm is required for psr2 operation as it's >> used for all

[Intel-gfx] [PATCH 07/10] drm/i915/psr: set PSR_MASK bits for deep sleep

Program EDP_PSR_DEBUG_CTL (PSR_MASK) to enable system to go to deep sleep while in psr2.PSR2_STATUS bit 31:28 should report value 8 , if system enters deep sleep state. Also, EDP_FRAMES_BEFORE_SU_ENTRY is set 1 , if not set, flickering is observed on psr2 panel. v2: (Ilia Mirkin) - Remove

Re: [Intel-gfx] DP compliance failure due to dithering for 18bpp video pattern

On Thu, Jan 12, 2017 at 03:41:07PM -0800, Rodrigo Vivi wrote: > On Thu, Jan 12, 2017 at 3:30 PM, Manasi Navare > wrote: > > On Thu, Jan 12, 2017 at 12:32:09PM +0200, Jani Nikula wrote: > >> On Wed, 11 Jan 2017, Ville Syrjälä wrote: > >> >

Re: [Intel-gfx] DP compliance failure due to dithering for 18bpp video pattern

On Thu, Jan 12, 2017 at 3:30 PM, Manasi Navare wrote: > On Thu, Jan 12, 2017 at 12:32:09PM +0200, Jani Nikula wrote: >> On Wed, 11 Jan 2017, Ville Syrjälä wrote: >> > On Wed, Jan 11, 2017 at 05:09:16PM +0200, Jani Nikula wrote: >> >> On

Re: [Intel-gfx] DP compliance failure due to dithering for 18bpp video pattern

On Thu, Jan 12, 2017 at 12:32:09PM +0200, Jani Nikula wrote: > On Wed, 11 Jan 2017, Ville Syrjälä wrote: > > On Wed, Jan 11, 2017 at 05:09:16PM +0200, Jani Nikula wrote: > >> On Tue, 10 Jan 2017, Manasi Navare wrote: > >> > Hi All, > >> >

[Intel-gfx] [PATCH] dim: Triple-check and tripe warning when merging patches that touch files outside i915.

Most of commiters already knows that by heart and also dim already have this warning. So maybe this is just Bart writing to blackboard. Duh! Anyway for my own usage this tripe check will help for sure. Maybe it help someone else in the future. Cc: Daniel Vetter Cc: Jani

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: reinstate call to trace_i915_vma_bind

== Series Details == Series: drm/i915: reinstate call to trace_i915_vma_bind URL : https://patchwork.freedesktop.org/series/17929/ State : success == Summary == Series 17929v1 drm/i915: reinstate call to trace_i915_vma_bind

Re: [Intel-gfx] [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc

On Thu, Jan 12, 2017 at 04:24:50PM -0600, l...@pengaru.com wrote: > On Thu, Jan 12, 2017 at 09:17:06PM +, Chris Wilson wrote: > > On Mon, Jan 09, 2017 at 11:19:32AM +, Chris Wilson wrote: > > > On a non-llc system, the objects are created with .cache_level = > > > CACHE_NONE and so the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/7] drm/i915: Name the anonymous structs inside i915_ggtt_view

== Series Details == Series: series starting with [v2,1/7] drm/i915: Name the anonymous structs inside i915_ggtt_view URL : https://patchwork.freedesktop.org/series/17923/ State : success == Summary == Series 17923v1 Series without cover letter

[Intel-gfx] [PATCH] drm/i915: reinstate call to trace_i915_vma_bind

From: Daniele Ceraolo Spurio The call went away in: commit 3b16525cc4c1a43e9053cfdc414356eea24bdfad Author: Chris Wilson Date: Thu Aug 4 16:32:25 2016 +0100 drm/i915: Split insertion/binding of an object into the VM It is

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

Hi, On 12 January 2017 at 18:11, Ville Syrjälä wrote: > On Thu, Jan 12, 2017 at 05:50:15PM +, Daniel Stone wrote: >> struct drm_plane { >> struct { >> uint32_t format; >> uint64_t modifiers[]; >> } formats[]; >> } > > Flipping formats[]

[Intel-gfx] [PATCH v2 4/7] drm/i915: Stop clearing i915_ggtt_view

As we now use a compact memcmp in i915_vma_compare(), we can forgo clearing the entire view and only set the precise parameters used in this view. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git

[Intel-gfx] [PATCH v2 6/7] drm/i915: Eliminate superfluous i915_ggtt_view_rotated

It is only being used to clear a struct and set the type, after which it is overwritten. Since we no longer check the unset bits of the union, skipping the clear is permissible. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen

[Intel-gfx] [PATCH v2 7/7] drm/i915: Eliminate superfluous i915_ggtt_view_normal

Since commit 058d88c4330f ("drm/i915: Track pinned VMA"), there is only one user of i915_ggtt_view_normal rodate. Just treat NULL as no special view in pin_to_display() like everywhere else. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen

[Intel-gfx] [PATCH v2 5/7] drm/i915: Convert i915_ggtt_view to use an anonymous union

Save a lot of characters by making the union anonymous, with the side-effect of ignoring unset bits when comparing views. v2: Roll up the memcmps back into one. v3: And split again as Ville points out we can't trust the compiler. Signed-off-by: Chris Wilson Cc: Daniel

[Intel-gfx] [PATCH v2 1/7] drm/i915: Name the anonymous structs inside i915_ggtt_view

Naming this pair will become useful shortly... Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_gtt.h | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] Anonymouse ggtt_view params

No one else liked packing the partial parameters into a single u64, so we are back to a full 32bit for the partial size, and using __packed and a bunch of asserts to ensure we have no unused bits inside each struct of the union. Hopefully that's the last contentios point! -Chris

[Intel-gfx] [PATCH v2 3/7] drm/i915: Compact memcmp in i915_vma_compare()

In preparation for the next patch to convert to using an anonymous union and leaving the excess bytes in the union uninitialised, we first need to make sure we do not compare using those uninitialised bytes. We also want to preserve the compactness of the code, avoiding a second call to memcmp or

[Intel-gfx] [PATCH v2 2/7] drm/i915: Mark the ggtt_view structs as packed

In the next few patches, we will depend upon there being no uninitialised bits inside the ggtt_view. To ensure this we add the __packed attribute and double check with a build on that gcc hasn't expanded the struct to include some padding bytes. Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc

On Mon, Jan 09, 2017 at 11:19:32AM +, Chris Wilson wrote: > On a non-llc system, the objects are created with .cache_level = > CACHE_NONE and so the transition to uncached for scanout is a no-op. > However, if the object was never written to, it will still be in the CPU > domain (having been

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Declare i915_gem_object_create_internal() as taking phys_addr_t size (rev2)

On Thu, Jan 12, 2017 at 05:24:12PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Declare i915_gem_object_create_internal() as taking > phys_addr_t size (rev2) > URL : https://patchwork.freedesktop.org/series/17905/ > State : warning > > == Summary == > > Series 17905v2

Re: [Intel-gfx] [PATCH] drm/i915: Fix up kerneldoc parameters for i915_gem_gtt_*()

On Thu, Jan 12, 2017 at 05:33:44PM +, Matthew Auld wrote: > On 12 January 2017 at 16:45, Chris Wilson wrote: > > Parameter: good. > > Parameter - bad. > > > > One day I'll learn the syntax. > > > > Fixes: 625d988acc28 ("drm/i915: Extract reserving space in the GTT to

Re: [Intel-gfx] [PATCH 01/14] drm/i915: Store the pipe pixel rate in the crtc state

On Tue, Dec 20, 2016 at 03:29:54PM +0200, Ville Syrjälä wrote: > On Tue, Dec 20, 2016 at 03:10:53PM +0200, Ander Conselvan De Oliveira wrote: > > On Mon, 2016-12-19 at 19:28 +0200, ville.syrj...@linux.intel.com wrote: > > > From: Ville Syrjälä > > > > > > Rather

Re: [Intel-gfx] [PATCH 06/10] drm/i915/psr: set CHICKEN_TRANS for psr2

Reviewed-by: Rodrigo Vivi On Fri, 2017-01-13 at 00:31 +0530, vathsala nagaraju wrote: > As per bpsec, CHICKEN_TRANS_EDP bit 12 ,15 must be programmed in > psr2 enable sequence. > bit 12 : Program Transcoder EDP VSC DIP header with a valid setting for > PSR2 and

[Intel-gfx] [PATCH 06/10] drm/i915/psr: set CHICKEN_TRANS for psr2

As per bpsec, CHICKEN_TRANS_EDP bit 12 ,15 must be programmed in psr2 enable sequence. bit 12 : Program Transcoder EDP VSC DIP header with a valid setting for PSR2 and Set CHICKEN_TRANS_EDP(0x420cc) bit 12 for programmable header packet. bit 15 : Set CHICKEN_TRANS_EDP(0x420cc) bit

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Add format modifiers for Intel

On 17-01-12 20:32:07, Ville Syrjälä wrote: On Thu, Jan 12, 2017 at 10:00:55AM -0800, Ben Widawsky wrote: On 17-01-12 12:51:20, Ville Syrjälä wrote: >On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote: >> This was based on a patch originally by Kristian. It has been modified >> pretty

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix up kerneldoc parameters for i915_gem_gtt_*()

== Series Details == Series: drm/i915: Fix up kerneldoc parameters for i915_gem_gtt_*() URL : https://patchwork.freedesktop.org/series/17915/ State : success == Summary == Series 17915v1 drm/i915: Fix up kerneldoc parameters for i915_gem_gtt_*()

Re: [Intel-gfx] [PATCH 3/7] i2c: designware-baytrail: Take punit lock on bus acquire

On Sun, Jan 08, 2017 at 02:44:23PM +0100, Hans de Goede wrote: > Take the punit lock to stop others from accessing the punit while the > pmic i2c bus is in use. This is necessary because accessing the punit > from the kernel may result in the punit trying to access the pmic i2c > bus, which

Re: [Intel-gfx] [PATCH 4/7] i2c: designware-baytrail: Call pmic_bus_access_notifier_chain

On Sun, Jan 08, 2017 at 02:44:24PM +0100, Hans de Goede wrote: > Call the iosf_mbi pmic_bus_access_notifier_chain on bus acquire / release. > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=155241 > Signed-off-by: Hans de Goede > Tested-by: tagorereddy

Re: [Intel-gfx] [GLK MIPI DSI V3 3/7] drm/i915/glk: Add MIPIIO Enable/disable sequence

Line 427 is under the if on line 422 and the subsequent lines are not. It is not clear at all what is intended. julia -- Forwarded message -- Date: Fri, 13 Jan 2017 02:13:07 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall

Re: [Intel-gfx] [PATCH 03/10] drm/i915/psr: fix blank screen issue for psr2

Reviewed-by: Rodrigo Vivi On Thu, 2017-01-12 at 23:30 +0530, vathsala nagaraju wrote: > Psr1 and psr2 are mutually exclusive,ie when psr2 is enabled, > psr1 should be disabled.When psr2 is exited , bit 31 of reg > PSR2_CTL must be set to 0 but currently bit 31 of SRD_CTL

Re: [Intel-gfx] [PATCH v4 00/10] Execlist based engine-reset (v4)

On 11/01/17 23:30, Chris Wilson wrote: I'm sorry to do this, but there is a regression fix for gen3 required first that makes this more complicated. https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=prescheduler=de399a0a6baae97910796d81d8b9324db3fdd77c

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Add format modifiers for Intel

On Thu, Jan 12, 2017 at 10:00:55AM -0800, Ben Widawsky wrote: > On 17-01-12 12:51:20, Ville Syrjälä wrote: > >On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote: > >> This was based on a patch originally by Kristian. It has been modified > >> pretty heavily to use the new callbacks from

Re: [Intel-gfx] [PATCH i-g-t rfc 01/29] lib/igt_debugfs: Prevent buffer overflow

Robert Foss schreef op do 12-01-2017 om 11:30 [-0500]: > > On 2017-01-12 04:14 AM, Lankhorst, Maarten wrote: > > > > Robert Foss schreef op wo 11-01-2017 om 15:41 [-0500]: > > > > > > buf array may overflow with when writing '\0' if > > > MAX_LINE_LEN bytes are read during read(). > > How? > >

Re: [Intel-gfx] [PATCH v6] drm/i915: Use __sg_alloc_table_from_pages for userptr allocations

Hi Tvrtko, [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20170111] [cannot apply to v4.10-rc3] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

On Thu, Jan 12, 2017 at 05:50:15PM +, Daniel Stone wrote: > Hi, > > On 12 January 2017 at 17:45, Ville Syrjälä > wrote: > > On Thu, Jan 12, 2017 at 05:04:46PM +, Daniel Stone wrote: > >> Implicit is clever but horrible. AFAICT, the only way to do it > >>

Re: [Intel-gfx] [PATCH] drm/probe-helpers: Drop locking from poll_enable

Fixes locking issues I've witnessed on the W541. Tested-by: Lyude Reviewed-by: Lyude On Wed, 2017-01-11 at 10:01 +0100, Daniel Vetter wrote: > It was only needed to protect the connector_list walking, see > > commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Add format modifiers for Intel

On 17-01-12 12:51:20, Ville Syrjälä wrote: On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote: This was based on a patch originally by Kristian. It has been modified pretty heavily to use the new callbacks from the previous patch. Cc: Kristian H. Kristensen

[Intel-gfx] [PATCH 03/10] drm/i915/psr: fix blank screen issue for psr2

Psr1 and psr2 are mutually exclusive,ie when psr2 is enabled, psr1 should be disabled.When psr2 is exited , bit 31 of reg PSR2_CTL must be set to 0 but currently bit 31 of SRD_CTL (psr1 control register)is set to 0. Also ,PSR2_IDLE state is looked up from SRD_STATUS(psr1 register) instead of

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Don't race connector registration

== Series Details == Series: drm: Don't race connector registration URL : https://patchwork.freedesktop.org/series/17910/ State : success == Summary == Series 17910v1 drm: Don't race connector registration https://patchwork.freedesktop.org/api/1.0/series/17910/revisions/1/mbox/ fi-bdw-5557u

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

Hi, On 12 January 2017 at 17:45, Ville Syrjälä wrote: > On Thu, Jan 12, 2017 at 05:04:46PM +, Daniel Stone wrote: >> Implicit is clever but horrible. AFAICT, the only way to do it >> properly would be to have a nested forwards loop walk when you first >> hit a

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

On Thu, Jan 12, 2017 at 05:04:46PM +, Daniel Stone wrote: > Hi, > > On 12 January 2017 at 14:56, Rob Clark wrote: > > On Thu, Jan 12, 2017 at 4:38 AM, Ville Syrjälä > > wrote: > >> Isn't an implicit offset enough? As in first mask for a

Re: [Intel-gfx] [PATCH 33/37] drm/i915: Verify page layout for rotated VMA

On 11/01/2017 21:09, Chris Wilson wrote: Exercise creating rotated VMA and checking the page order within. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_vma.c | 130 ++ 1 file changed, 130 insertions(+) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Fix up kerneldoc parameters for i915_gem_gtt_*()

On 12 January 2017 at 16:45, Chris Wilson wrote: > Parameter: good. > Parameter - bad. > > One day I'll learn the syntax. > > Fixes: 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a > helper") > Fixes: e007b19d7ba7 ("drm/i915: Use the MRU stack search

Re: [Intel-gfx] [PATCH 18/37] drm/i915: Test exhaustion of the mmap space

On 11 January 2017 at 21:09, Chris Wilson wrote: > An unlikely error condition that we can simulate by stealing the most of s/the most/most/ > the range before trying to insert new objects. > > Signed-off-by: Chris Wilson > --- >

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Declare i915_gem_object_create_internal() as taking phys_addr_t size (rev2)

== Series Details == Series: drm/i915: Declare i915_gem_object_create_internal() as taking phys_addr_t size (rev2) URL : https://patchwork.freedesktop.org/series/17905/ State : warning == Summary == Series 17905v2 drm/i915: Declare i915_gem_object_create_internal() as taking phys_addr_t

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

Hi, On 12 January 2017 at 14:56, Rob Clark wrote: > On Thu, Jan 12, 2017 at 4:38 AM, Ville Syrjälä > wrote: >> Isn't an implicit offset enough? As in first mask for a specific >> modifier is for format indexes 0-63, second mask for the same

Re: [Intel-gfx] [PATCH] drm/i915/huc: Support HuC authentication

On Thu, Jan 12, 2017 at 08:35:01AM -0800, Anusha Srivatsa wrote: > diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c > index c6be352..f53ca8d 100644 > --- a/drivers/gpu/drm/i915/intel_uc.c > +++ b/drivers/gpu/drm/i915/intel_uc.c > @@ -46,7 +46,7 @@ static bool

[Intel-gfx] [PATCH] drm/i915/huc: Support HuC authentication

From: Peter Antoine The HuC authentication is done by host2guc call. The HuC RSA keys are sent to GuC for authentication. v2: rebased on top of drm-intel-nightly. changed name format and upped version 1.7. v3: rebased on top of drm-intel-nightly. v4: changed

Re: [Intel-gfx] [PATCH] drm: Don't race connector registration

On Thu, Jan 12, 2017 at 05:15:56PM +0100, Daniel Vetter wrote: > I was under the misconception that the sysfs dev stuff can be fully > set up, and then registered all in one step with device_add. That's > true for properties and property groups, but not for parents and child > devices. Those must

[Intel-gfx] [PATCH] drm/i915: Fix up kerneldoc parameters for i915_gem_gtt_*()

Parameter: good. Parameter - bad. One day I'll learn the syntax. Fixes: 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a helper") Fixes: e007b19d7ba7 ("drm/i915: Use the MRU stack search after evicting") Signed-off-by: Chris Wilson Cc: Joonas Lahtinen

[Intel-gfx] [PATCH] drm/i915/huc: Add HuC fw loading support

The HuC loading process is similar to GuC. The intel_uc_fw_fetch() is used for both cases. HuC loading needs to be before GuC loading. The WOPCM setting must be done early before loading any of them. v2: rebased on-top of drm-intel-nightly. removed if(HAS_GUC()) before the guc call.

[Intel-gfx] [PATCH] drm/i915/huc: Support HuC authentication

From: Peter Antoine The HuC authentication is done by host2guc call. The HuC RSA keys are sent to GuC for authentication. v2: rebased on top of drm-intel-nightly. changed name format and upped version 1.7. v3: rebased on top of drm-intel-nightly. v4: changed

Re: [Intel-gfx] [PATCH i-g-t rfc 01/29] lib/igt_debugfs: Prevent buffer overflow

On 2017-01-12 04:14 AM, Lankhorst, Maarten wrote: Robert Foss schreef op wo 11-01-2017 om 15:41 [-0500]: buf array may overflow with when writing '\0' if MAX_LINE_LEN bytes are read during read(). How? char buf[MAX_LINE_LEN + 1]; I actually missed the + 1, but parts of the commit are

Re: [Intel-gfx] [PATCH] drm: Don't race connector registration

On Thu, Jan 12, 2017 at 05:15:56PM +0100, Daniel Vetter wrote: > I was under the misconception that the sysfs dev stuff can be fully > set up, and then registered all in one step with device_add. That's > true for properties and property groups, but not for parents and child > devices. Those must

[Intel-gfx] [PATCH] drm: Don't race connector registration

I was under the misconception that the sysfs dev stuff can be fully set up, and then registered all in one step with device_add. That's true for properties and property groups, but not for parents and child devices. Those must be fully registered before you can register a child. Add a bit of

Re: [Intel-gfx] [RFC PATCH 2/3] drm/i915: IOMMU based SVM implementation v16

On Jan 12, 2017 8:04 AM, "Chris Wilson" wrote: On Thu, Jan 12, 2017 at 05:48:49PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Mon, Jan 09, 2017 at 06:52:53PM +0200, Mika Kuoppala wrote: > >> +static int

Re: [Intel-gfx] [RFC PATCH 2/3] drm/i915: IOMMU based SVM implementation v16

On Thu, Jan 12, 2017 at 05:48:49PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Mon, Jan 09, 2017 at 06:52:53PM +0200, Mika Kuoppala wrote: > >> +static int i915_gem_context_enable_svm(struct i915_gem_context *ctx) > >> +{ > >> + int ret; > >> + > >> +

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Add name for WaDisablePWMClockGating workaround

== Series Details == Series: series starting with [1/3] drm/i915: Add name for WaDisablePWMClockGating workaround URL : https://patchwork.freedesktop.org/series/17904/ State : success == Summary == Series 17904v1 Series without cover letter

Re: [Intel-gfx] [RFC PATCH 2/3] drm/i915: IOMMU based SVM implementation v16

Chris Wilson writes: > On Mon, Jan 09, 2017 at 06:52:53PM +0200, Mika Kuoppala wrote: >> +static int i915_gem_context_enable_svm(struct i915_gem_context *ctx) >> +{ >> +int ret; >> + >> +if (!HAS_SVM(ctx->i915)) >> +return -ENODEV; > > How does

Re: [Intel-gfx] [PATCH] drm/i915/huc: Add HuC fw loading support

>-Original Message- >From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] >Sent: Wednesday, January 11, 2017 6:24 AM >To: Wajdeczko, Michal >Cc: Srivatsa, Anusha ; intel- >g...@lists.freedesktop.org; Alex Dai ;

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Expand ggtt_view paramters for debugfs (rev3)

== Series Details == Series: drm/i915: Expand ggtt_view paramters for debugfs (rev3) URL : https://patchwork.freedesktop.org/series/17896/ State : success == Summary == Series 17896v3 drm/i915: Expand ggtt_view paramters for debugfs

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

On Thu, Jan 12, 2017 at 03:00:20PM +, Tvrtko Ursulin wrote: > > On 12/01/2017 11:33, Chris Wilson wrote: > >On Wed, Jan 11, 2017 at 09:51:03PM +, Chris Wilson wrote: > >>In preparation for the next patch to convert to using an anonymous union > >>and leaving the excess bytes in the union

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

On 12/01/2017 11:33, Chris Wilson wrote: On Wed, Jan 11, 2017 at 09:51:03PM +, Chris Wilson wrote: In preparation for the next patch to convert to using an anonymous union and leaving the excess bytes in the union uninitialised, we first need to make sure we do not compare using those

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

On Thu, Jan 12, 2017 at 4:38 AM, Ville Syrjälä wrote: > On Wed, Jan 11, 2017 at 08:43:16PM -0500, Rob Clark wrote: >> On Wed, Jan 11, 2017 at 7:51 PM, Ben Widawsky wrote: >> > >> > +struct drm_format_modifier { >> > + /* Bitmask of formats

Re: [Intel-gfx] [PATCH] drm/i915: Remove useless casts to intel_plane_state

Op 12-01-17 om 10:58 schreef Ville Syrjälä: > On Thu, Jan 12, 2017 at 10:43:45AM +0100, Maarten Lankhorst wrote: >> The visible member used to be in intel_plane_state->visible, >> but has been moved to drm_plane_state->visible. In the conversion >> some casts were left in that are now useless. >>

Re: [Intel-gfx] [PATCH 06/37] drm/i915: Add unit tests for the breadcrumb rbtree, wakeups

On Thu, Jan 12, 2017 at 11:11:20AM +, Tvrtko Ursulin wrote: > > On 11/01/2017 21:09, Chris Wilson wrote: > >Third retroactive test, make sure that the seqno waiters are woken. > > There are some open questions from the previous round (early > December), not least of which is that I think we

Re: [Intel-gfx] [PATCH v2 2/5] drm/edid: Introduce drm_default_rgb_quant_range()

On Thu, Jan 12, 2017 at 11:29:18AM +0200, Jani Nikula wrote: > On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Make the code selecting the RGB quantization range a little less magicy > > by wrapping it up in a small helper.

[Intel-gfx] [PULL] drm-intel-fixes

Hi Dave - Mostly GVT-g fixes, with a couple of other fixes from Chris. BR, Jani. The following changes since commit a121103c922847ba5010819a3f250f1f7fc84ab8: Linux 4.10-rc3 (2017-01-08 14:18:17 -0800) are available in the git repository at: git://anongit.freedesktop.org/git/drm-intel

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Update i915_reset parameter for kerneldoc

Michel Thierry writes: > Since commit c033666a94b57 ("drm/i915: Store a i915 backpointer from > engine, and use it") i915_reset receives dev_priv, but the kerneldoc > was not updated. > > Signed-off-by: Michel Thierry Pushed patches 01/10 and

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Pack the partial view size and offset into a single u64

On Wed, Jan 11, 2017 at 09:51:02PM +, Chris Wilson wrote: > Since the partial offset must be page aligned, we can use those low 12 > bits to encode the size of the partial view (which then cannot be larger > than 8MiB in pages). A requirement for avoiding unused bits inside the > struct is

Re: [Intel-gfx] [PATCH 28/37] drm/i915: Exercising filling the top/bottom portions of the global GTT

On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote: > Same test as previously for the per-process GTT instead applied to the > global GTT. > > Signed-off-by: Chris Wilson > @@ -218,28 +209,94 @@ static int igt_ppgtt_fill(void *arg) >   >  

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

On Thu, Jan 12, 2017 at 01:53:40PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/2] drm/i915: Invalidate the guc ggtt TLB > upon insertion > URL : https://patchwork.freedesktop.org/series/17898/ > State : failure > > == Summary == > > Series 17898v1

Re: [Intel-gfx] [PATCHv2] drm/i915: Remove WaDisableLSQCROPERFforOCL KBL workaround.

Francisco Jerez writes: > Daniel Vetter writes: > >> On Wed, Jan 11, 2017 at 12:24:59PM +, Chris Wilson wrote: >>> On Wed, Jan 11, 2017 at 02:07:37PM +0200, Mika Kuoppala wrote: >>> > Daniel Vetter writes: >>> > >>> > > On Mon, Jan

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

== Series Details == Series: series starting with [CI,1/2] drm/i915: Invalidate the guc ggtt TLB upon insertion URL : https://patchwork.freedesktop.org/series/17898/ State : failure == Summary == Series 17898v1 Series without cover letter

Re: [Intel-gfx] [PATCH i-g-t 1/5] tests/kms_plane_multiple: Add TEST_ONLY flag

Op 30-12-16 om 13:00 schreef Mika Kahola: > Add TEST_ONLY flag to test atomic modesetting commits without > actual real-life commit. > > Signed-off-by: Mika Kahola > --- > tests/kms_plane_multiple.c | 79 > -- > 1 file changed,

Re: [Intel-gfx] [PATCH v2] drm/i915: Declare i915_gem_object_create_internal() as taking phys_addr_t size

On to, 2017-01-12 at 13:04 +, Chris Wilson wrote: > The internal object is a collection of struct pages and so is > intrinsically linked to the available physical memory on the machine, > and not an arbitrary type from the uabi. Use phys_addr_t so the link > between size and memory consumption

Re: [Intel-gfx] [PATCH 27/37] drm/i915: Exercising filling the top/bottom portions of the ppgtt

On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote: > Allocate objects with varying number of pages (which should hopefully > consist of a mixture of contiguous page chunks and so coalesced sg > lists) and check that the sg walkers in insert_pages cope. > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 09/37] drm/i915: Mock infrastructure for request emission

On Thu, Jan 12, 2017 at 01:11:50PM +, Tvrtko Ursulin wrote: > > On 11/01/2017 21:09, Chris Wilson wrote: > >+struct i915_gem_context * > >+mock_context(struct drm_i915_private *i915, > >+ const char *name) > >+{ > >+struct i915_gem_context *ctx; > >+int ret; > >+ > >+ctx =

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove WaDisableLSQCROPERFforOCL KBL workaround. (rev2)

== Series Details == Series: drm/i915: Remove WaDisableLSQCROPERFforOCL KBL workaround. (rev2) URL : https://patchwork.freedesktop.org/series/17659/ State : success == Summary == Series 17659v2 drm/i915: Remove WaDisableLSQCROPERFforOCL KBL workaround.

Re: [Intel-gfx] [PATCH 09/37] drm/i915: Mock infrastructure for request emission

On 11/01/2017 21:09, Chris Wilson wrote: Create a fake engine that runs requests using a timer to simulate hw. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_context.c| 4 + drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c | 11 +-

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Update i915.reset to handle engine resets

On Thu, Jan 12, 2017 at 02:22:21PM +0200, Joonas Lahtinen wrote: > On ke, 2017-01-11 at 20:18 -0800, Michel Thierry wrote: > > From: Arun Siluvery > > > > In preparation for engine reset work update this parameter to handle more > > than one type of reset. Default

[Intel-gfx] [PATCH v2] drm/i915: Declare i915_gem_object_create_internal() as taking phys_addr_t size

The internal object is a collection of struct pages and so is intrinsically linked to the available physical memory on the machine, and not an arbitrary type from the uabi. Use phys_addr_t so the link between size and memory consumption is clear, and then double check that we don't overflow the

[Intel-gfx] [PATCH] drm/i915: Declare i915_gem_object_create_internal() as taking phys_addr_t size

The internal object is a collection of struct pages and so is intrinsically linked to the available physical memory on the machine, and not an arbitrary type from the uabi. Use phys_addr_t so the link between size and memory consumption is clear, and then double check that we don't overflow the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove useless casts to intel_plane_state

== Series Details == Series: drm/i915: Remove useless casts to intel_plane_state URL : https://patchwork.freedesktop.org/series/17894/ State : success == Summary == Series 17894v1 drm/i915: Remove useless casts to intel_plane_state

Re: [Intel-gfx] [PATCH 26/37] drm/i915: Assert that we have allocated the drm_mm_node upon pinning

On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote: > We currently check after the slow path that the vma is bound correctly, > but we don't currently check after the fast path. This is important in > case we accidentally take the fast path and leave the vma misplaced. > > Signed-off-by: Chris

Re: [Intel-gfx] [PATCH 25/37] drm/i915: Move i915_ppgtt_close() into i915_gem_gtt.c

On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote: > Move it alongside its ppgtt counterparts, in order to make it available > for the ppgtt selftests. > > Signed-off-by: Chris Wilson Positive side-effects. Reviewed-by: Joonas Lahtinen

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Update i915.reset to handle engine resets

On ke, 2017-01-11 at 20:18 -0800, Michel Thierry wrote: > From: Arun Siluvery > > In preparation for engine reset work update this parameter to handle more > than one type of reset. Default at the moment is still full gpu reset. > > Cc: Chris Wilson

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Change number of iterations

> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Thursday, January 12, 2017 2:00 PM > To: Maarten Lankhorst > Cc: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH

Re: [Intel-gfx] [PATCH 14/37] drm/i915: Simple selftest to exercise live requests

On Thu, Jan 12, 2017 at 12:10:08PM +, Tvrtko Ursulin wrote: > > On 11/01/2017 21:09, Chris Wilson wrote: > >Just create several batches of requests and expect it to not fall over! > > > >Signed-off-by: Chris Wilson > >--- > >

Re: [Intel-gfx] [PATCH 14/37] drm/i915: Simple selftest to exercise live requests

On 11/01/2017 21:09, Chris Wilson wrote: Just create several batches of requests and expect it to not fall over! Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_gem_request.c | 78 ++

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Change number of iterations

On Thu, Jan 12, 2017 at 12:53:30PM +0100, Maarten Lankhorst wrote: > Op 12-01-17 om 12:12 schreef Mika Kahola: > > In CI system, the default 64 iterations of this test may cause CRC overflow > > warnings in dmesg when debugfs is enabled in kernel config. To keep dmesg > > warning noise in minimum,

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Change number of iterations

Op 12-01-17 om 12:12 schreef Mika Kahola: > In CI system, the default 64 iterations of this test may cause CRC overflow > warnings in dmesg when debugfs is enabled in kernel config. To keep dmesg > warning noise in minimum, let's run this test only once by default. > > Signed-off-by: Mika Kahola

[Intel-gfx] [PATCH 3/3] drm/i915/glk: Turn on workarounds that apply to Geminilake too

Apply workarounds to Geminilake, and annoatate those that are applied uncondionally when they apply to GLK based on the workaround database. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++--

  1   2   >