Re: [Intel-gfx] [PATCH v3 1/7] drm/atomic: Add new iterators over all state, v3.

Op 17-01-17 om 00:11 schreef Laurent Pinchart: > Hi Maarten, > > Thank you for the patch. > > On Monday 16 Jan 2017 10:37:38 Maarten Lankhorst wrote: >> Add for_each_(old)(new)_(plane,connector,crtc)_in_state iterators to >> replace the old for_each_xxx_in_state ones. This is useful for >1 flip >>

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Add a check that the VMA instance we lookup matches the request

On ma, 2017-01-16 at 15:21 +, Chris Wilson wrote: > Just as added paranoia against our future-selves add another check that > the lookup/created VMA instance matches the request. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen

Re: [Intel-gfx] [PATCH] drm/i915: Assert internal objects are page aligned

On ma, 2017-01-16 at 14:52 +, Chris Wilson wrote: > Internal objects must be passed a page-aligned size. Check it. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen

Re: [Intel-gfx] DP compliance failure due to dithering for 18bpp video pattern

On Fri, Jan 13, 2017 at 09:11:49AM +0200, Jani Nikula wrote: > On Fri, 13 Jan 2017, Manasi Navare wrote: > > On Thu, Jan 12, 2017 at 03:41:07PM -0800, Rodrigo Vivi wrote: > >> On Thu, Jan 12, 2017 at 3:30 PM, Manasi Navare > >> wrote: > >> >

Re: [Intel-gfx] [PATCH v3 0/7] drm/atomic: Add accessor macros for all atomic state.

Hi Maarten, One more thing. On Monday 16 Jan 2017 10:37:37 Maarten Lankhorst wrote: > Fourth iteration. Instead of trying to convert all drivers straight away, > implement all macros that are required to get state working. > > Old situation: > Use obj->state, which can refer to old or new

Re: [Intel-gfx] [PATCH v3 6/7] drm/atomic: Convert get_existing_state callers to get_old/new_state, v2.

Hi Maarten, One more thing. On Monday 16 Jan 2017 10:37:43 Maarten Lankhorst wrote: > This is a straightforward conversion that converts all the users of > get_existing_state in atomic core to use get_old_state or get_new_state > > Changes since v1: > - Fix using the wrong state in >

Re: [Intel-gfx] [PATCH v3 7/7] drm/blend: Use new atomic iterator macros.

Hi Maarten, Thank you for the patch. On Monday 16 Jan 2017 10:37:44 Maarten Lankhorst wrote: Could we please get a commit message ? Apart from that, Reviewed-by: Laurent Pinchart > Signed-off-by: Maarten Lankhorst > ---

Re: [Intel-gfx] [PATCH v3 6/7] drm/atomic: Convert get_existing_state callers to get_old/new_state, v2.

Hi Maarten, Thank you for the patch. I don't think you need the "v2" at the end of the subject line. On Monday 16 Jan 2017 10:37:43 Maarten Lankhorst wrote: > This is a straightforward conversion that converts all the users of > get_existing_state in atomic core to use get_old_state or

Re: [Intel-gfx] [PATCH v3 5/7] drm/atomic: Add macros to access existing old/new state

Hi Maarten, Thank you for the patch. On Monday 16 Jan 2017 10:37:42 Maarten Lankhorst wrote: > After atomic commit, these macros should be used in place of > get_existing_state. Also after commit get_xx_state should no longer > be used because it may not have the required locks. Should this be

Re: [Intel-gfx] [PATCH v3 4/7] drm/atomic: Fix atomic helpers to use the new iterator macros.

Hi Maarten, (CC'ing Daniel) Thank you for the patch. On Monday 16 Jan 2017 10:37:41 Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/drm_atomic_helper.c | 293 +--- > 1 file changed, 152

[Intel-gfx] linux-next: manual merge of the drm tree with the drm-misc-fixes tree

Hi Dave, Today's linux-next merge of the drm tree got a conflict in: include/drm/drm_atomic.h between commit: 7e9081c5aac7 ("drm/fence: fix memory overwrite when setting out_fence fd") from the drm-misc-fixes tree and commit: bdc571464c49 ("drm/atomic: Clean up wait_for_vblanks, v2.")

Re: [Intel-gfx] [PATCH v3 0/7] drm/atomic: Add accessor macros for all atomic state.

Hi Maarten, Thank you for the patches. On Monday 16 Jan 2017 10:37:37 Maarten Lankhorst wrote: > Fourth iteration. Instead of trying to convert all drivers straight away, > implement all macros that are required to get state working. > > Old situation: > Use obj->state, which can refer to old

Re: [Intel-gfx] [PATCH v3 3/7] drm/atomic: Use new atomic iterator macros.

Hi Maarten, Thank you for the patch. On Monday 16 Jan 2017 10:37:40 Maarten Lankhorst wrote: Could we please get a description ? Apart from that, Reviewed-by: Laurent Pinchart > Signed-off-by: Maarten Lankhorst > --- >

Re: [Intel-gfx] [PATCH v3 2/7] drm/atomic: Make add_affected_connectors look at crtc_state.

Hi Maarten, Thank you for the patch. On Monday 16 Jan 2017 10:37:39 Maarten Lankhorst wrote: > This kills another dereference of connector->state. connector_mask > holds all unchanged connectors at least and any changed connectors > are already in state anyway. > > Signed-off-by: Maarten

Re: [Intel-gfx] [PATCH v3 1/7] drm/atomic: Add new iterators over all state, v3.

Hi Maarten, Thank you for the patch. On Monday 16 Jan 2017 10:37:38 Maarten Lankhorst wrote: > Add for_each_(old)(new)_(plane,connector,crtc)_in_state iterators to > replace the old for_each_xxx_in_state ones. This is useful for >1 flip > depth and getting rid of all xxx->state dereferences. >

Re: [Intel-gfx] [PATCH 17/37] drm/i915: Test partial mappings

On Mon, Jan 16, 2017 at 10:05:21PM +, Matthew Auld wrote: > On 11 January 2017 at 21:09, Chris Wilson wrote: > > Create partial mappings to cover a large object, investigating tiling > > (fenced regions) and VMA reuse. > > > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 17/37] drm/i915: Test partial mappings

On 11 January 2017 at 21:09, Chris Wilson wrote: > Create partial mappings to cover a large object, investigating tiling > (fenced regions) and VMA reuse. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/selftests/i915_gem_object.c

Re: [Intel-gfx] [PATCH i-g-t v4 0/5] Add support for the Chamelium

(CCing Tomeu Vizoso here since it looks like I somehow had suppresscc turned on by accident) On Mon, 2017-01-16 at 14:26 -0500, Lyude wrote: > This adds basic support for using the Chamelium in hotplugging tests, > along > with checking video outputs. > > So far there's

[Intel-gfx] [PATCH i-g-t v2 1/5] igt_aux: Add igt_set_autoresume_delay()

The default autoresume delay is about 5 seconds. It's possible on a system that's not very fast this might not be a long enough time, since an asynchronous hotplug event we scheduled on the chamelium that was intended to happen during suspend could happen before we actually manage to suspend. So,

[Intel-gfx] [PATCH i-g-t v4 0/5] Add support for the Chamelium

This adds basic support for using the Chamelium in hotplugging tests, along with checking video outputs. So far there's still definitely some bugs with video capturing, however they seem to mostly be the Chamelium's fault. Since we really need to try to at least get basic support for this into

[Intel-gfx] [PATCH i-g-t v4 5/5] Add support for hotplug testing with the Chamelium

For the purpose of testing things such as hotplugging and bad monitors, the ChromeOS team ended up designing a neat little device known as the Chamelium. More information on this can be found here: https://www.chromium.org/chromium-os/testing/chamelium This adds support for a couple of

[Intel-gfx] [PATCH i-g-t v3 2/5] igt_kms: Add helpers for watching for sysfs hotplug events

This adds some basic helpers for connecting to udev and watching for sysfs hotplug events. Cc: Tomeu Vizoso Signed-off-by: Lyude Changes since v1: - Remove unused arg from documentation Changes since v2: - Make udev_monitor explicit so that we can use

[Intel-gfx] [PATCH i-g-t 3/5] igt_kms: Add igt_output_from_connector

A simple helper for getting the igt_output_t struct corresponding to the given DRM connector id. Cc: Tomeu Vizoso Signed-off-by: Lyude --- lib/igt_kms.c | 26 ++ lib/igt_kms.h | 2 ++ 2 files changed, 28 insertions(+) diff

[Intel-gfx] [PATCH i-g-t 4/5] igt_kms: Add kmstest_set_connector_broadcast_rgb()

A simple helper that checks whether or not the given connector has the "Broadcast RGB" prop, and if so sets it to the given mode. Required for working with the Chamelium since the Chamelium EDIDs enable limited color ranges by default on i915 and break frame dump comparisons/CRCs. Cc: Tomeu

Re: [Intel-gfx] State of development of X11 driver

On 01/13/2017 09:24 AM, Michael Cronenworth wrote: - What is the state of the X11 intel driver? Alive? Dead? Silence best describes the answer to this question. Thanks, Michael ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

[Intel-gfx] (no subject)

Hi everyone, I don't know if this is too specialised for this list. Anyway, no harm in asking the question :-) *Preamble* Build: Yocto from the Apollo Lake BSP release *gold, * Hardware: Oxbow Hill Rev B CRB with Intel Atom E3950 and 4GB DDR3 RAM (one SODIMM) Build: core-image-sato-sdk Installed

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v2,1/5] drm/i915: Track pinned vma in intel_plane_state

== Series Details == Series: series starting with [v2,1/5] drm/i915: Track pinned vma in intel_plane_state URL : https://patchwork.freedesktop.org/series/18066/ State : warning == Summary == Series 18066v1 Series without cover letter

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Move engine reset preparation to i915_gem_reset_prepare() (rev2)

== Series Details == Series: series starting with [1/2] drm/i915: Move engine reset preparation to i915_gem_reset_prepare() (rev2) URL : https://patchwork.freedesktop.org/series/18048/ State : success == Summary == Series 18048v2 Series without cover letter

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Assert internal objects are page aligned

== Series Details == Series: drm/i915: Assert internal objects are page aligned URL : https://patchwork.freedesktop.org/series/18064/ State : success == Summary == Series 18064v1 drm/i915: Assert internal objects are page aligned

[Intel-gfx] [PATCH v2 3/5] drm/i915: Add a check that the VMA instance we lookup matches the request

Just as added paranoia against our future-selves add another check that the lookup/created VMA instance matches the request. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_vma.c | 1 + 1 file changed, 1

[Intel-gfx] [PATCH v2 5/5] drm/i915: Remove i915_gem_object_to_ggtt()

With the last user of this convenience wrapper gone, we can kill the wrapper and in the process make the lookup function static. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 7 --- drivers/gpu/drm/i915/i915_vma.c | 27

[Intel-gfx] [PATCH v2 4/5] drm/i915: Remove i915_vma_create from VMA API

With the introduce of i915_vma_instance() for obtaining the VMA singleton for a (obj, vm, view) tuple, we can remove the i915_vma_create() in favour of a single entry point. We do incur a lookup onto an empty tree, but the i915_vma_create() were being called infrequently and during initialisation,

[Intel-gfx] [PATCH v2 1/5] drm/i915: Track pinned vma in intel_plane_state

With atomic plane states we are able to track an allocation right from preparation, during use and through to the final free after being swapped out for a new plane. We can couple the VMA we pin for the framebuffer (and its rotation) to this lifetime and avoid all the clumsy lookups in between.

[Intel-gfx] [PATCH v2 2/5] drm/i915: Rename some warts in the VMA API

Whilst writing testcases to exercise the VMA API, some oddities came to light, such as i915_gem_obj_lookup_or_create(). Joonas suggested i915_vma_instance() as a neat replacement, so rename them, move them to i915_vma.c and add some kerneldoc as a sugary bonus.

[Intel-gfx] [PATCH] drm/i915: Detect a failed GPU reset+recovery

If we can't recover the GPU after the reset, mark it as wedged to cancel the outstanding tasks and to prevent new users from trying to use the broken GPU. v2: Check the same ring is hung again before declaring the reset broken. Signed-off-by: Chris Wilson Cc: Mika

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] lib/scatterlist: Fix offset type in sg_alloc_table_from_pages

== Series Details == Series: series starting with [1/4] lib/scatterlist: Fix offset type in sg_alloc_table_from_pages URL : https://patchwork.freedesktop.org/series/18062/ State : success == Summary == Series 18062v1 Series without cover letter

[Intel-gfx] [PATCH] drm/i915: Assert internal objects are page aligned

Internal objects must be passed a page-aligned size. Check it. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_gem_internal.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Intel-gfx] regression since v4.9-rcX: "Resetting chip after gpu hang" times out(?) and is repeated every 20th second

Hello, I've been having occasional GPU HANGs on my Skylake laptop ever since I got it, originally reported here: https://bugs.freedesktop.org/show_bug.cgi?id=96894 But this is not the reason I try this list. The HANGs used to be resolved nicely by the driver up to and including v4.8. The GPU

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move engine reset preparation to i915_gem_reset_prepare()

Chris Wilson writes: > On Mon, Jan 16, 2017 at 04:03:16PM +0200, Mika Kuoppala wrote: >> Chris Wilson writes: >> >> > Now that we have prepare/finish routines for the GEM reset, move the >> > disabling of the engine->irq_tasklet into them to

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix compiler warnings for i915_edp_psr_status()

== Series Details == Series: series starting with [1/2] drm/i915: Fix compiler warnings for i915_edp_psr_status() URL : https://patchwork.freedesktop.org/series/18056/ State : success == Summary == Series 18056v1 Series without cover letter

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move engine reset preparation to i915_gem_reset_prepare()

On Mon, Jan 16, 2017 at 04:03:16PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > Now that we have prepare/finish routines for the GEM reset, move the > > disabling of the engine->irq_tasklet into them to reduce repetition. The > > device irq enable/disable is

[Intel-gfx] [PATCH 3/4] lib/scatterlist: Introduce and export __sg_alloc_table_from_pages

From: Tvrtko Ursulin Drivers like i915 benefit from being able to control the maxium size of the sg coallesced segment while building the scatter- gather list. Introduce and export the __sg_alloc_table_from_pages function which will allow it that control. v2: Reorder

[Intel-gfx] [PATCH 4/4] drm/i915: Use __sg_alloc_table_from_pages for userptr allocations

From: Tvrtko Ursulin With the addition of __sg_alloc_table_from_pages we can control the maximum coallescing size and eliminate a separate path for allocating backing store here. Similar to 871dfbd67d4e ("drm/i915: Allow compaction upto SWIOTLB max segment size") this

[Intel-gfx] [PATCH 2/4] lib/scatterlist: Avoid potential scatterlist entry overflow

From: Tvrtko Ursulin Since the scatterlist length field is an unsigned int, make sure that sg_alloc_table_from_pages does not overflow it while coallescing pages to a single entry. v2: Drop reference to future use. Use UINT_MAX. v3: max_segment must be page aligned.

[Intel-gfx] [PATCH 1/4] lib/scatterlist: Fix offset type in sg_alloc_table_from_pages

From: Tvrtko Ursulin Scatterlist entries have an unsigned int for the offset so correct the sg_alloc_table_from_pages function accordingly. Since these are offsets withing a page, unsigned int is wide enough. Also converts callers which were using unsigned long

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move engine reset preparation to i915_gem_reset_prepare()

Chris Wilson writes: > Now that we have prepare/finish routines for the GEM reset, move the > disabling of the engine->irq_tasklet into them to reduce repetition. The > device irq enable/disable is split out to ensure it is run first and > last always (even if the GPU

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/kms_plane_multiple: Relax atomic commit time requirement

On Mon, 2017-01-16 at 14:26 +0100, Maarten Lankhorst wrote: > Op 16-01-17 om 14:09 schreef Mika Kahola: > > > > Relax required time to atomic commits from 1 vblank to 2 vblanks. > > > > Reference: Issues seen on BYT CI tests > > > > Cc: Maarten Lankhorst > >

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/kms_plane_multiple: Cleanup in favor of library functions

Op 16-01-17 om 14:09 schreef Mika Kahola: > Cleaunup by replacing get_vblank() function with library function > kmstest_get_vblank(). > > Cc: Maarten Lankhorst > > Signed-off-by: Mika Kahola > --- > tests/kms_plane_multiple.c | 27

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/kms_plane_multiple: Relax atomic commit time requirement

Op 16-01-17 om 14:09 schreef Mika Kahola: > Relax required time to atomic commits from 1 vblank to 2 vblanks. > > Reference: Issues seen on BYT CI tests > > Cc: Maarten Lankhorst > > Signed-off-by: Mika Kahola > --- >

[Intel-gfx] [PATCH i-g-t 2/2] tests/kms_plane_multiple: Cleanup in favor of library functions

Cleaunup by replacing get_vblank() function with library function kmstest_get_vblank(). Cc: Maarten Lankhorst Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 27 +++ 1 file changed, 3 insertions(+),

[Intel-gfx] [PATCH i-g-t 1/2] tests/kms_plane_multiple: Relax atomic commit time requirement

Relax required time to atomic commits from 1 vblank to 2 vblanks. Reference: Issues seen on BYT CI tests Cc: Maarten Lankhorst Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 9 + 1 file changed, 5 insertions(+), 4

[Intel-gfx] [PATCH i-g-t 0/2] tests/kms_plane_multiple: Fix CI issues

Fixes for issues seen on CI tests. The patches provide relaxed timing requirement for atomic commit as well as general cleanup to favor library functions. Mika Kahola (2): tests/kms_plane_multiple: Relax atomic commit time requirement tests/kms_plane_multiple: Cleanup in favor of library

[Intel-gfx] [PATCH 1/2] drm/i915: Fix compiler warnings for i915_edp_psr_status()

Appease both the poor reader and the compiler by rewriting the string lookup for EDP_PSR2_STATUS_CTL: drivers/gpu/drm/i915/i915_debugfs.c:2662 i915_edp_psr_status() warn: if statement not indented Fixes: 6ba1f9e1772f ("drm/i915/psr: report live PSR2 State") Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 2/2] drm/i915/psr: Fix compiler warnings for hsw_psr_disable()

drivers/gpu/drm/i915/intel_psr.c:634 hsw_psr_disable() warn: if statement not indented drivers/gpu/drm/i915/intel_psr.c:644 hsw_psr_disable() warn: if statement not indented Fixes: 3fcb0ca1d8db ("drm/i915/psr: fix blank screen issue for psr2") Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Only call skl_check_plane_surface() for visible planes

On Fri, Jan 13, 2017 at 11:54:10AM -0800, Matt Roper wrote: > When a plane is fully clipped (either because it's positioned offscreen, > or because the CRTC is currently off), the clipping calculations we do > during check_plane will leave nonsense/negative coordinates in plane's > source

Re: [Intel-gfx] [PATCH] drm/i915: Catch attempting to use the aliasing_gtt's drm_mm

On Mon, Jan 16, 2017 at 02:10:33PM +0200, Joonas Lahtinen wrote: > On su, 2017-01-15 at 13:47 +, Chris Wilson wrote: > > The aliasing_gtt is just that, an alias of the global GTT. We do not > > populate it directly, instead we always use the global GTT. Catch any > > attempt to incorrectly

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Rename some warts in the VMA API

== Series Details == Series: series starting with [1/2] drm/i915: Rename some warts in the VMA API URL : https://patchwork.freedesktop.org/series/18050/ State : warning == Summary == Series 18050v1 Series without cover letter

Re: [Intel-gfx] [PATCH] drm/i915: Catch attempting to use the aliasing_gtt's drm_mm

On su, 2017-01-15 at 13:47 +, Chris Wilson wrote: > The aliasing_gtt is just that, an alias of the global GTT. We do not > populate it directly, instead we always use the global GTT. Catch any > attempt to incorrectly allocate ranges from the aliasing_gtt. > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove i915_vma_create from VMA API

On ma, 2017-01-16 at 09:49 +, Chris Wilson wrote: > With the introduce of i915_vma_instance() for obtaining the VMA > singleton for a (obj, vm, view) tuple, we can remove the > i915_vma_create() in favour of a single entry point. We do incur a > lookup onto an empty tree, but the

Re: [Intel-gfx] [PATCH] drm/i915: Flush the change in debugobject before reallocation

On pe, 2017-01-13 at 21:43 +, Chris Wilson wrote: > When marking the debugobject as freed, be sure that write is flushed > before another CPU may see it on a reallocation path. > > Only seen once in CI: > > [  159.240873] WARNING: CPU: 3 PID: 6735 at lib/debugobjects.c:263 >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Move engine reset preparation to i915_gem_reset_prepare()

== Series Details == Series: series starting with [1/2] drm/i915: Move engine reset preparation to i915_gem_reset_prepare() URL : https://patchwork.freedesktop.org/series/18048/ State : success == Summary == Series 18048v1 Series without cover letter

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: Silence compiler for missing prototype

On la, 2017-01-14 at 10:51 +, Chris Wilson wrote: > drivers/gpu/drm/i915/intel_dp.c:3063:6: warning: no previous prototype for > ‘intel_dp_get_alpm_status’ [-Wmissing-prototypes] >  bool intel_dp_get_alpm_status(struct intel_dp *intel_dp) > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use __printf markup to silence compiler

On la, 2017-01-14 at 10:51 +, Chris Wilson wrote: > drivers/gpu/drm/i915/i915_gpu_error.c: In function ‘i915_error_vprintf’: > drivers/gpu/drm/i915/i915_gpu_error.c:137:3: warning: > function might be possible candidate for ‘gnu_printf’ format attribute > [-Wsuggest-attribute=format] >    len

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Skip switch to kernel context if already done

On la, 2017-01-14 at 16:23 +, Chris Wilson wrote: > Some engines are never user or already sitting idle in the kernel > context and for those we can skip flushing the current context for > i915_gem_switch_to_kernel_context(). We used to perform this > optimisation but that was removed for

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Rename some warts in the VMA API

On ma, 2017-01-16 at 09:49 +, Chris Wilson wrote: > Whilst writing testcases to exercise the VMA API, some oddities came to > light, such as i915_gem_obj_lookup_or_create(). Joonas suggested > i915_vma_instance() as a neat replacement, so rename them, move them to > i915_vma.c  and add some

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/atomic: Add accessor macros for all atomic state. (rev4)

== Series Details == Series: drm/atomic: Add accessor macros for all atomic state. (rev4) URL : https://patchwork.freedesktop.org/series/17745/ State : warning == Summary == Series 17745v4 drm/atomic: Add accessor macros for all atomic state.

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Detect a failed GPU reset+recovery

On Mon, Jan 16, 2017 at 09:42:52AM +, Chris Wilson wrote: > If we can't recover the GPU after the reset, mark it as wedged to cancel > the outstanding tasks and to prevent new users from trying to use the > broken GPU. > > Signed-off-by: Chris Wilson > Cc: Mika

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Fix POWER_DOMAIN_AUDIO refcounting.

Op 11-01-17 om 17:13 schreef Daniel Vetter: > On Thu, Dec 15, 2016 at 03:29:43PM +0100, Maarten Lankhorst wrote: >> If the crtc was brought up with audio before the driver loads, >> then crtc_disable will remove a refcount to audio that doesn't exist >> before. >> >> Fortunately we already set

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Rename some warts in the VMA API

On Mon, Jan 16, 2017 at 09:49:45AM +, Chris Wilson wrote: > Whilst writing testcases to exercise the VMA API, some oddities came to > light, such as i915_gem_obj_lookup_or_create(). Joonas suggested > i915_vma_instance() as a neat replacement, so rename them, move them to > i915_vma.c and add

Re: [Intel-gfx] [PATCH] drm: Fix for invalid pruning of modes in dual display cases

> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Tuesday, December 13, 2016 9:17 PM > To: Jani Nikula > Cc: Chris Wilson ; Srinivas, Vidya > ;

Re: [Intel-gfx] [PATCH v4] lib/scatterlist: Avoid potential scatterlist entry overflow

On Mon, Jan 16, 2017 at 12:05 PM, Tvrtko Ursulin wrote: > - for (i = 1; i < n_pages; ++i) > + for (i = 1; i < n_pages; ++i) { // Are compilers so stupid doing calculation per iteration in for-conditional? // for (i = 0; i + 1 <

Re: [Intel-gfx] [PATCH 10/14] drm/i915: Add MIPI_IO WA

> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Friday, January 13, 2017 9:02 PM > To: Deak, Imre > Cc: Jani Nikula ; Kahola, Mika > ; Srinivas, Vidya

Re: [Intel-gfx] [PATCH v4] lib/scatterlist: Avoid potential scatterlist entry overflow

On 13/01/2017 22:23, Andy Shevchenko wrote: @@ -402,9 +403,16 @@ int sg_alloc_table_from_pages(struct sg_table *sgt, /* compute number of contiguous chunks */ chunks = 1; - for (i = 1; i < n_pages; ++i) - if (page_to_pfn(pages[i]) != page_to_pfn(pages[i -

Re: [Intel-gfx] [PATCH 06/10] drm/i915/psr: set CHICKEN_TRANS for psr2

On Fri, 13 Jan 2017, Rodrigo Vivi wrote: > This and all the remaining patches on this series (6,7,8 and 9) got > merged to dinq. Given that this patch series was not properly sent as a thread, I don't think our CI ran it as a whole, and it should not have been pushed

Re: [Intel-gfx] [PATCH 10/14] drm/i915: Add MIPI_IO WA

> -Original Message- > From: Kahola, Mika > Sent: Thursday, January 12, 2017 5:13 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 10/14] drm/i915: Add MIPI_IO WA > > This is definitely needed to pass igt test on

[Intel-gfx] [PATCH 2/2] drm/i915: Remove i915_vma_create from VMA API

With the introduce of i915_vma_instance() for obtaining the VMA singleton for a (obj, vm, view) tuple, we can remove the i915_vma_create() in favour of a single entry point. We do incur a lookup onto an empty tree, but the i915_vma_create() were being called infrequently and during initialisation,

[Intel-gfx] [PATCH 1/2] drm/i915: Rename some warts in the VMA API

Whilst writing testcases to exercise the VMA API, some oddities came to light, such as i915_gem_obj_lookup_or_create(). Joonas suggested i915_vma_instance() as a neat replacement, so rename them, move them to i915_vma.c and add some kerneldoc as a sugary bonus.

Re: [Intel-gfx] [PATCH 0/8] HuC Loading Patches

On Mon, 16 Jan 2017, Jani Nikula wrote: > On Fri, 13 Jan 2017, Anusha Srivatsa wrote: >> The patches add HuC loading support. The driver builds a frame level >> workload which is stored in the graphics memory. This workload is presented >>

[Intel-gfx] [PATCH 2/2] drm/i915: Detect a failed GPU reset+recovery

If we can't recover the GPU after the reset, mark it as wedged to cancel the outstanding tasks and to prevent new users from trying to use the broken GPU. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Tvrtko Ursulin

[Intel-gfx] [PATCH 1/2] drm/i915: Move engine reset preparation to i915_gem_reset_prepare()

Now that we have prepare/finish routines for the GEM reset, move the disabling of the engine->irq_tasklet into them to reduce repetition. The device irq enable/disable is split out to ensure it is run first and last always (even if the GPU reset fails). Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH v3 2/7] drm/atomic: Make add_affected_connectors look at crtc_state.

This kills another dereference of connector->state. connector_mask holds all unchanged connectors at least and any changed connectors are already in state anyway. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic.c | 11 --- 1 file

[Intel-gfx] [PATCH v3 6/7] drm/atomic: Convert get_existing_state callers to get_old/new_state, v2.

This is a straightforward conversion that converts all the users of get_existing_state in atomic core to use get_old_state or get_new_state Changes since v1: - Fix using the wrong state in drm_atomic_helper_update_legacy_modeset_state. Signed-off-by: Maarten Lankhorst

[Intel-gfx] [PATCH v3 3/7] drm/atomic: Use new atomic iterator macros.

Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 18cdf2c956c6..7b61e0da9ace 100644 ---

[Intel-gfx] [PATCH v3 5/7] drm/atomic: Add macros to access existing old/new state

After atomic commit, these macros should be used in place of get_existing_state. Also after commit get_xx_state should no longer be used because it may not have the required locks. Signed-off-by: Maarten Lankhorst --- include/drm/drm_atomic.h | 99

[Intel-gfx] [PATCH v3 1/7] drm/atomic: Add new iterators over all state, v3.

Add for_each_(old)(new)_(plane,connector,crtc)_in_state iterators to replace the old for_each_xxx_in_state ones. This is useful for >1 flip depth and getting rid of all xxx->state dereferences. This requires extra fixups done when committing a state after duplicating, which in general isn't valid

[Intel-gfx] [PATCH v3 0/7] drm/atomic: Add accessor macros for all atomic state.

Fourth iteration. Instead of trying to convert all drivers straight away, implement all macros that are required to get state working. Old situation: Use obj->state, which can refer to old or new state. Use drm_atomic_get_(existing_)obj_state, which can refer to new or old state. Use

[Intel-gfx] [dim PATCH] dim: fix message about fetching drm-tip

Set $remote before using it. Signed-off-by: Jani Nikula --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index 6bbbec1cc0a3..ebb4fa97f45a 100755 --- a/dim +++ b/dim @@ -439,8 +439,8 @@ function dim_rebuild_tip exit 1

[Intel-gfx] [PATCH v3 7/7] drm/blend: Use new atomic iterator macros.

Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_blend.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c index 5c45d0852608..78cf9f6cae08 100644 ---

[Intel-gfx] [PATCH v3 4/7] drm/atomic: Fix atomic helpers to use the new iterator macros.

Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic_helper.c | 293 +++- 1 file changed, 152 insertions(+), 141 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c

Re: [Intel-gfx] [GIT PULL] GVT-g fixes for 4.10-rc5

On Mon, 16 Jan 2017, Zhenyu Wang wrote: > Hi, > > This pull contains vGPU/mdev reset fixes from Changbin to fix vGPU hang > for VM reboot and vGPU/mdev instance reuse issues that might impact usage. > Several preparation patches are to align reset code for each

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Construct a request even if the GPU is currently hung

On la, 2017-01-14 at 16:23 +, Chris Wilson wrote: > As we now have the ability to directly reset the GPU from the waiter > (and so do not need to drop the lock in order to let the reset proceed) > and also do not lose requests over a reset, we can now simply queue the > request to occur after

Re: [Intel-gfx] [PATCH] drm/i915: Assert we do not attempt to reuse an allocated node

On su, 2017-01-15 at 17:27 +, Chris Wilson wrote: > i915_gem_gtt_reserve() and i915_gem_gtt_insert() can only work on > unallocated nodes. Check that the callers complies. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen

Re: [Intel-gfx] [PATCH 0/8] HuC Loading Patches

On Fri, 13 Jan 2017, Anusha Srivatsa wrote: > The patches add HuC loading support. The driver builds a frame level > workload which is stored in the graphics memory. This workload is presented > to HuC for processing. The driver, therefore should first determine if the

Re: [Intel-gfx] [PATCH v2.1 1/7] drm/atomic: Add new iterators over all state, v3.

Op 15-01-17 om 20:56 schreef Laurent Pinchart: > Hi Maarten, > > Thank you for the patch. > > On Tuesday 10 Jan 2017 14:46:58 Maarten Lankhorst wrote: >> Add for_each_(old)(new)_(plane,connector,crtc)_in_state iterators to >> replace the old for_each_xxx_in_state ones. This is useful for >1 flip

Re: [Intel-gfx] [PATCH] drm/i915: Avoid drm_atomic_state_put(NULL) in intel_display_resume

Hi Chris, this fixes the problem for me, thanks! Tested-by: Stefan Seyfried Am 15.01.2017 um 13:58 schrieb Chris Wilson: > intel_display_resume() may be called without a atomic state to restore, > i.e. dev_priv->modeset_reset_restore state is NULL. One such case

Re: [Intel-gfx] [RESEND PATCH v14 2/2] drm/i915: Put "cooked" vlank counters in frame CRC lines

On 10 January 2017 at 17:31, Daniel Vetter wrote: > On Tue, Jan 10, 2017 at 05:54:57PM +0200, Ville Syrjälä wrote: >> On Tue, Jan 10, 2017 at 02:43:05PM +0100, Tomeu Vizoso wrote: >> > Use drm_accurate_vblank_count so we have the full 32 bit to represent >> > the frame counter

Re: [Intel-gfx] [RFC] drm/i915/guc: Move GuC log related functions into dedicated file

On Mon, Jan 16, 2017 at 08:25:57AM +, Tvrtko Ursulin wrote: > > On 13/01/2017 17:49, Chris Wilson wrote: > > On Fri, Jan 13, 2017 at 05:41:57PM +, Michal Wajdeczko wrote: > > > Functions supporting GuC logging capabilities were spread across > > > many files, with unnecessary exposures

Re: [Intel-gfx] [RFC] drm/i915/guc: Move GuC log related functions into dedicated file

On 13/01/2017 17:49, Chris Wilson wrote: On Fri, Jan 13, 2017 at 05:41:57PM +, Michal Wajdeczko wrote: Functions supporting GuC logging capabilities were spread across many files, with unnecessary exposures and mixed with unrelated code. Dedicate file will make maintenance of all GuC