[Intel-gfx] [drm-tip:drm-tip 1685/1713] htmldocs: drivers/gpu/drm/drm_syncobj.c:230: warning: Function parameter or member 'flags' not described in 'drm_syncobj_find_fence'

2018-10-16 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: c4fc9e99d838c9b9a3f6bdb6e609b0cf820f9aef commit: 649fdce23cdf516e69aa8c18f4b44c62127f0e83 [1685/1713] drm: add flags to drm_syncobj_find_fence reproduce: make htmldocs All warnings (new ones prefixed by >>):

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/atomic_helper: Stop modesets on unregistered connectors harder (rev2)

2018-10-16 Thread Patchwork
== Series Details == Series: drm/atomic_helper: Stop modesets on unregistered connectors harder (rev2) URL : https://patchwork.freedesktop.org/series/51041/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4990_full -> Patchwork_10480_full = == Summary - SUCCESS == No

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/guc: rename __create/destroy_doorbell

2018-10-16 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/guc: rename __create/destroy_doorbell URL : https://patchwork.freedesktop.org/series/51090/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4991 -> Patchwork_10483 = == Summary - FAILURE == Serious unknown

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/guc: rename __create/destroy_doorbell

2018-10-16 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/guc: rename __create/destroy_doorbell URL : https://patchwork.freedesktop.org/series/51090/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7ece2bdc16d7 drm/i915/guc: rename __create/destroy_doorbell 0b8643c82cf6

[Intel-gfx] [PATCH 4/4] HAX enable GuC for CI

2018-10-16 Thread Daniele Ceraolo Spurio
From: Michal Wajdeczko Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 7e56c516c815..c681537bcb92 100644 ---

[Intel-gfx] [PATCH 3/4] drm/i915/guc: do not print drbreg on error

2018-10-16 Thread Daniele Ceraolo Spurio
The only content of the register apart from the valid bit is the lower part of the physical memory address. If the valid bit is 0 the address is meaningless, while if it is 1 we don't know which descriptor it came from (since the doorbell is in an unexpected state) so we can't match it to an

[Intel-gfx] [PATCH 2/4] drm/i915/guc: reserve the doorbell before selecting the cacheline

2018-10-16 Thread Daniele Ceraolo Spurio
Cacheline selection is only needed if we actually manage to reserve a doorbell. Cc: Michal Wajdeczko Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/intel_guc_submission.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH 1/4] drm/i915/guc: rename __create/destroy_doorbell

2018-10-16 Thread Daniele Ceraolo Spurio
The 2 functions don't create or destroy anything, they just update the doorbell state in memory. Use init and fini instead for clarity. Cc: Michal Wajdeczko Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/intel_guc_submission.c | 12 ++--

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/guc: fix GuC suspend/resume

2018-10-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/guc: fix GuC suspend/resume URL : https://patchwork.freedesktop.org/series/51088/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4991 -> Patchwork_10482 = == Summary - FAILURE == Serious unknown changes

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915/guc: fix GuC suspend/resume

2018-10-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/guc: fix GuC suspend/resume URL : https://patchwork.freedesktop.org/series/51088/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8971200da2a4 drm/i915/guc: fix GuC suspend/resume -:102: CHECK:LINE_SPACING:

Re: [Intel-gfx] [PATCH] drm/i915/cnp+: update to the new RAWCLK_FREQ recommendations

2018-10-16 Thread Rodrigo Vivi
On Tue, Oct 16, 2018 at 04:00:26PM -0700, Paulo Zanoni wrote: > Em Sex, 2018-10-12 às 15:42 +0300, Ville Syrjälä escreveu: > > On Thu, Oct 11, 2018 at 05:40:45PM -0700, Paulo Zanoni wrote: > > > These are the new recommended values provided by our spec (18 -> 19 > > > and 23 -> 24). It seems this

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds

2018-10-16 Thread Daniele Ceraolo Spurio
On 16/10/18 01:59, Michal Wajdeczko wrote: In commit 4502e9ec820d ("drm/i915/uc: Unify firmware loading") we stopped converting errors detected during firmware transfer into -EAGAIN and this indirectly killed our workarounds for Gen9 GuC. Reactivate those workarounds by looking for actual

Re: [Intel-gfx] [PATCH] drm/i915/cnp+: update to the new RAWCLK_FREQ recommendations

2018-10-16 Thread Paulo Zanoni
Em Sex, 2018-10-12 às 15:42 +0300, Ville Syrjälä escreveu: > On Thu, Oct 11, 2018 at 05:40:45PM -0700, Paulo Zanoni wrote: > > These are the new recommended values provided by our spec (18 -> 19 > > and 23 -> 24). It seems this should help fixing GMBUS issues. Since > > we're doing pretty much the

Re: [Intel-gfx] [PATCH 02/11] drm/i915: remove padding from struct skl_wm_level

2018-10-16 Thread Lucas De Marchi
On Tue, Oct 16, 2018 at 03:01:24PM -0700, Paulo Zanoni wrote: > This reduces the size of struct skl_wm_level from 6 to 4, which > reduces the size of struct skl_plane_wm from 104 to 70, which reduces > the size of struct skl_pipe_wm from 524 to 356. A reduction of 168 > padding bytes per pipe.

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for More watermarks improvements

2018-10-16 Thread Paulo Zanoni
Em Ter, 2018-10-16 às 22:39 +, Patchwork escreveu: > == Series Details == > > Series: More watermarks improvements > URL : https://patchwork.freedesktop.org/series/51086/ > State : failure > > == Summary == > > = CI Bug Log - changes from CI_DRM_4990 -> Patchwork_10481 = > > == Summary -

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Get ref on CRTC commit object when waiting for flip_done

2018-10-16 Thread Patchwork
== Series Details == Series: drm: Get ref on CRTC commit object when waiting for flip_done URL : https://patchwork.freedesktop.org/series/51079/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4990_full -> Patchwork_10479_full = == Summary - FAILURE == Serious unknown

[Intel-gfx] [PATCH v2 1/2] drm/i915/guc: fix GuC suspend/resume

2018-10-16 Thread Daniele Ceraolo Spurio
The ENTER/EXIT_S_STATE actions queue the save/restore operation in GuC FW and then return, so waiting on the H2G is not enough to guarantee GuC is done. When all the processing is done, GuC writes 0 to scratch register 14, so we can poll on that. Note that GuC does not ensure that the value in the

[Intel-gfx] [PATCH v2 2/2] HAX enable GuC for CI

2018-10-16 Thread Daniele Ceraolo Spurio
From: Michal Wajdeczko Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 7e56c516c815..c681537bcb92 100644 ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for More watermarks improvements

2018-10-16 Thread Patchwork
== Series Details == Series: More watermarks improvements URL : https://patchwork.freedesktop.org/series/51086/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4990 -> Patchwork_10481 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_10481 absolutely

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More watermarks improvements

2018-10-16 Thread Paulo Zanoni
Em Ter, 2018-10-16 às 22:21 +, Patchwork escreveu: > == Series Details == > > Series: More watermarks improvements > URL : https://patchwork.freedesktop.org/series/51086/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > 6a8c3f3d3663 drm/i915: don't apply Display

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for More watermarks improvements

2018-10-16 Thread Patchwork
== Series Details == Series: More watermarks improvements URL : https://patchwork.freedesktop.org/series/51086/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: don't apply Display WAs 1125 and 1126 to GLK/CNL+ Okay! Commit: drm/i915: remove

[Intel-gfx] [PATCH i-g-t 4/5] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property

2018-10-16 Thread Deepak Rawat
Some simple test cases to use FB_DAMAGE_CLIPS plane property. Signed-off-by: Deepak Rawat --- lib/igt_kms.c | 1 + lib/igt_kms.h | 1 + tests/kms_atomic.c | 260 + 3 files changed, 262 insertions(+) diff --git a/lib/igt_kms.c

[Intel-gfx] [PATCH i-g-t 5/5] tests/kms_selftest: Integrate kernel selftest test-drm_modeset

2018-10-16 Thread Deepak Rawat
Call kernel selftest module test-drm_modeset for testing KMS. v2: - Add test alphabetically. - Add test to meson build. v3: Rename to kms_selftest. Signed-off-by: Deepak Rawat --- tests/Makefile.sources| 1 + tests/igt_command_line.sh | 2 +- tests/kms_selftest.c | 10 ++

[Intel-gfx] [PATCH i-g-t 3/5] lib: Don't call igt_require_fb_modifiers() when no modifier

2018-10-16 Thread Deepak Rawat
vmwgfx and amdgpu doesn't support fb modifiers, yet kms_addfb() requires modifier support. Since many tests don't need this to run, the requirement can be made less broad. Therefore, tighten the requirement to cases where modifiers are actually needed. v2: * In create_fb() calls to kms_addfb(),

[Intel-gfx] [PATCH i-g-t 1/5] lib/igt_fb: Call dumb_destroy ioctl in case of dumb buffers

2018-10-16 Thread Deepak Rawat
vmwgfx does not support GEM interface so calling gem_close on vmwgfx results in error. v2: Use drmIoctl with error when ioctl() failed. v3: Seperate ioctl wrapper. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 5 - lib/igt_kms.c | 22 ++ lib/igt_kms.h | 1 + 3

[Intel-gfx] [PATCH i-g-t 2/5] lib/igt_fb: Check for cairo surface success

2018-10-16 Thread Deepak Rawat
For vmwgfx cairo surface creation fails due to stride mismatch, add a igt_require_f() for surface. v2: Check for surface creation failure. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/igt_fb.c b/lib/igt_fb.c index 335ece69..1bb6d324

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More watermarks improvements

2018-10-16 Thread Patchwork
== Series Details == Series: More watermarks improvements URL : https://patchwork.freedesktop.org/series/51086/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6a8c3f3d3663 drm/i915: don't apply Display WAs 1125 and 1126 to GLK/CNL+ 6165f4257098 drm/i915: remove padding from

[Intel-gfx] ✓ Fi.CI.IGT: success for shmem, drm/i915: Mark pinned shmemfs pages as unevictable

2018-10-16 Thread Patchwork
== Series Details == Series: shmem, drm/i915: Mark pinned shmemfs pages as unevictable URL : https://patchwork.freedesktop.org/series/51078/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4990_full -> Patchwork_10478_full = == Summary - SUCCESS == No regressions found.

[Intel-gfx] [PATCH 03/11] drm/i915: fix handling of invisible planes in watermarks code

2018-10-16 Thread Paulo Zanoni
Before the patch, if a plane was not visible, skl_compute_plane_wm_params() would return early without writing anything to the wm_params struct. This would leave garbage in the struct since it is not previously zeroed, and then we would later check for wm_params.is_planar, which could be true due

[Intel-gfx] [PATCH 10/11] drm/i915: add pipe_htotal to struct skl_wm_params

2018-10-16 Thread Paulo Zanoni
With this one here we can finally drop the intel state structures from the functions that compute watermark values: they all rely on struct skl_wm_params now. This should help the watermarks code be a little more clear on its intent and also match the spec a little bit more with the carefully

[Intel-gfx] [PATCH 09/11] drm/i915: make skl_needs_memory_bw_wa() take dev_priv instead of state

2018-10-16 Thread Paulo Zanoni
The function only really needs dev_priv to make its decision. If we ever need more, we can change it again. But then, in this case we should make needs_memory_bw_wa be a variable inside struct skl_wm_params so we won't need to keep passing intel states deep inside pure watermark value calculation

[Intel-gfx] [PATCH 08/11] drm/i915: reorganize the error message for invalid watermarks

2018-10-16 Thread Paulo Zanoni
Print a more generic "failed to compute watermark levels" whenever any of skl_compute_wm_levels() fail, and print only the specific error message for the specific cases. This allows us to stop passing pstate everywhere, making the watermarks computation code a little less dependent on random intel

[Intel-gfx] [PATCH 04/11] drm/i915: remove useless memset() for watermarks parameters

2018-10-16 Thread Paulo Zanoni
The skl_compute_plane_wm_params() already completely sets the contents of its struct, or returns plane_visible=0 or returns an error code. There's no need to memset() it at this point for the same reason we don't zero-initialize it up when dealing with plane 0. If we want to keep the memset "just

[Intel-gfx] [PATCH 00/11] More watermarks improvements

2018-10-16 Thread Paulo Zanoni
Except for maybe patch 1, I don't believe this series will allow us to close any real bugs, but at least it should make the code more readable. Please notice that we removed more lines than we added :). Thanks, Paulo Paulo Zanoni (11): drm/i915: don't apply Display WAs 1125 and 1126 to

[Intel-gfx] [PATCH 06/11] drm/i915: refactor skl_write_plane_wm()

2018-10-16 Thread Paulo Zanoni
Its control flow is not as easy to follow as it could be. We recently even had a double register write that went unnoticed until commit 9e44b180f81b ("drm/i915: don't write PLANE_BUF_CFG twice every time") fixed it. The return statement in the middle along with the fact that it's on a void

[Intel-gfx] [PATCH 07/11] drm/i915: move ddb_blocks to be a watermark parameter

2018-10-16 Thread Paulo Zanoni
The goal of struct skl_wm_params is to cache every watermark parameter so the other functions can just use them without worrying about the appropriate place to fetch each parameter requested by the spec, and without having to recompute parameters that are used in different steps of the

[Intel-gfx] [PATCH 11/11] drm/i915: pass dev_priv instead of cstate to skl_compute_transition_wm()

2018-10-16 Thread Paulo Zanoni
Stop passing modeset state structures to functions that should work only with the skl_wm_params. The only use for cstate there was to reach dev_priv, so pass it directly. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_pm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[Intel-gfx] [PATCH 05/11] drm/i915: simplify wm->is_planar assignment

2018-10-16 Thread Paulo Zanoni
We're currently doing it in two different ways, none of them based on the wm_params struct. Both places are correct, so I chose to keep the one in skl_compute_wm_levels() since it's the function that sets the other values for the same struct. But I'm open to better suggestions on the place to

[Intel-gfx] [PATCH 02/11] drm/i915: remove padding from struct skl_wm_level

2018-10-16 Thread Paulo Zanoni
This reduces the size of struct skl_wm_level from 6 to 4, which reduces the size of struct skl_plane_wm from 104 to 70, which reduces the size of struct skl_pipe_wm from 524 to 356. A reduction of 168 padding bytes per pipe. This will increase even more the next time we bump I915_MAX_PLANES.

[Intel-gfx] [PATCH 01/11] drm/i915: don't apply Display WAs 1125 and 1126 to GLK/CNL+

2018-10-16 Thread Paulo Zanoni
BSpec does not show these WAs as applicable to GLK, and for CNL it only shows them applicable for a super early pre-production stepping we shouldn't be caring about anymore. Remove these so we can avoid them on ICL too. Cc: Matt Roper Signed-off-by: Paulo Zanoni ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gen9+: Fix initial readout for Y tiled framebuffers

2018-10-16 Thread Patchwork
== Series Details == Series: drm/i915/gen9+: Fix initial readout for Y tiled framebuffers URL : https://patchwork.freedesktop.org/series/51075/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4990_full -> Patchwork_10477_full = == Summary - SUCCESS == No regressions

Re: [Intel-gfx] [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Manasi Navare
On Tue, Oct 16, 2018 at 02:04:21PM -0700, Manasi Navare wrote: > On Tue, Oct 16, 2018 at 10:45:55PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 16, 2018 at 12:42:05PM -0700, Manasi Navare wrote: > > > On Tue, Oct 16, 2018 at 10:19:06PM +0300, Ville Syrjälä wrote: > > > > On Tue, Oct 16, 2018 at

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/atomic_helper: Stop modesets on unregistered connectors harder (rev2)

2018-10-16 Thread Patchwork
== Series Details == Series: drm/atomic_helper: Stop modesets on unregistered connectors harder (rev2) URL : https://patchwork.freedesktop.org/series/51041/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4990 -> Patchwork_10480 = == Summary - SUCCESS == No regressions

Re: [Intel-gfx] [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Manasi Navare
On Tue, Oct 16, 2018 at 10:45:55PM +0300, Ville Syrjälä wrote: > On Tue, Oct 16, 2018 at 12:42:05PM -0700, Manasi Navare wrote: > > On Tue, Oct 16, 2018 at 10:19:06PM +0300, Ville Syrjälä wrote: > > > On Tue, Oct 16, 2018 at 10:01:11PM +0300, Ville Syrjälä wrote: > > > > On Fri, Oct 05, 2018 at

Re: [Intel-gfx] [PATCH v5 20/28] drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling

2018-10-16 Thread Manasi Navare
On Tue, Oct 16, 2018 at 12:58:24PM -0700, Srivatsa, Anusha wrote: > > > >-Original Message- > >From: Navare, Manasi D > >Sent: Friday, October 5, 2018 4:23 PM > >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > >Cc: Navare, Manasi D ; Jani Nikula > >; Ville Syrjala

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use i915_gem_object_get_dma_address() to populate rotated vmas

2018-10-16 Thread Patchwork
== Series Details == Series: drm/i915: Use i915_gem_object_get_dma_address() to populate rotated vmas URL : https://patchwork.freedesktop.org/series/51072/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4990_full -> Patchwork_10476_full = == Summary - SUCCESS == No

[Intel-gfx] [PATCH v2] drm/atomic_helper: Stop modesets on unregistered connectors harder

2018-10-16 Thread Lyude Paul
Unfortunately, it appears our fix in: commit b5d29843d8ef ("drm/atomic_helper: Allow DPMS On<->Off changes for unregistered connectors") Which attempted to work around the problems introduced by: commit 4d80273976bf ("drm/atomic_helper: Disallow new modesets on unregistered connectors") Is still

Re: [Intel-gfx] [PATCH 01/10] drm/i915: Remove crtc->config dereference from drrs_ctl

2018-10-16 Thread Ville Syrjälä
On Thu, Oct 11, 2018 at 12:04:48PM +0200, Maarten Lankhorst wrote: > Wait for idle, and iterate over connectors instead of encoders. > With this information we know crtc->state is the actual state, > and we can enable/disable drrs safely. > > Signed-off-by: Maarten Lankhorst Looks sensible

Re: [Intel-gfx] [PATCH v5 20/28] drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling

2018-10-16 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Friday, October 5, 2018 4:23 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org >Cc: Navare, Manasi D ; Jani Nikula >; Ville Syrjala ; >Srivatsa, Anusha >Subject: [PATCH v5 20/28] drm/i915/dp: Configure i915

Re: [Intel-gfx] [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 12:42:05PM -0700, Manasi Navare wrote: > On Tue, Oct 16, 2018 at 10:19:06PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 16, 2018 at 10:01:11PM +0300, Ville Syrjälä wrote: > > > On Fri, Oct 05, 2018 at 04:22:57PM -0700, Manasi Navare wrote: > > > > On Icelake, a separate

Re: [Intel-gfx] [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Manasi Navare
On Tue, Oct 16, 2018 at 10:19:06PM +0300, Ville Syrjälä wrote: > On Tue, Oct 16, 2018 at 10:01:11PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 05, 2018 at 04:22:57PM -0700, Manasi Navare wrote: > > > On Icelake, a separate power well PG2 is created for > > > VDSC engine used for eDP/MIPI DSI.

Re: [Intel-gfx] [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 12:19:24PM -0700, Manasi Navare wrote: > Thanks for your review comments. > > On Tue, Oct 16, 2018 at 10:01:11PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 05, 2018 at 04:22:57PM -0700, Manasi Navare wrote: > > > On Icelake, a separate power well PG2 is created for > > >

Re: [Intel-gfx] [PATCH v5 26/28] drm/i915/dsc: Enable and disable appropriate power wells for VDSC

2018-10-16 Thread Ville Syrjälä
On Fri, Oct 05, 2018 at 04:23:04PM -0700, Manasi Navare wrote: > A separate power well 2 (PG2) is required for VDSC on eDP transcoder > whereas all other transcoders use the power wells associated with the > transcoders for VDSC. > This patch adds a helper to obtain correct power domain depending

Re: [Intel-gfx] [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 10:01:11PM +0300, Ville Syrjälä wrote: > On Fri, Oct 05, 2018 at 04:22:57PM -0700, Manasi Navare wrote: > > On Icelake, a separate power well PG2 is created for > > VDSC engine used for eDP/MIPI DSI. This patch adds a new > > display power domain for Power well 2. > > > >

Re: [Intel-gfx] [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Manasi Navare
Thanks for your review comments. On Tue, Oct 16, 2018 at 10:01:11PM +0300, Ville Syrjälä wrote: > On Fri, Oct 05, 2018 at 04:22:57PM -0700, Manasi Navare wrote: > > On Icelake, a separate power well PG2 is created for > > VDSC engine used for eDP/MIPI DSI. This patch adds a new > > display power

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Mark pinned shmemfs pages as unevictable

2018-10-16 Thread Michal Hocko
On Tue 16-10-18 19:31:06, Chris Wilson wrote: > Quoting Michal Hocko (2018-10-16 19:21:55) > > On Wed 17-10-18 01:43:00, Kuo-Hsin Yang wrote: > > > The i915 driver use shmemfs to allocate backing storage for gem objects. > > > These shmemfs pages can be pinned (increased ref count) by > > >

Re: [Intel-gfx] [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Ville Syrjälä
On Fri, Oct 05, 2018 at 04:22:57PM -0700, Manasi Navare wrote: > On Icelake, a separate power well PG2 is created for > VDSC engine used for eDP/MIPI DSI. This patch adds a new > display power domain for Power well 2. > > v2: > * Fix the power well mismatch CI error (Ville) > * Rename as

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: fix GuC suspend/resume

2018-10-16 Thread Michal Wajdeczko
On Tue, 16 Oct 2018 19:15:19 +0200, Daniele Ceraolo Spurio wrote: On 10/16/2018 2:21 AM, Daniel Vetter wrote: On Tue, Oct 16, 2018 at 1:44 AM Daniele Ceraolo Spurio wrote: On 15/10/18 15:47, Patchwork wrote: == Series Details == Series: series starting with [1/2] drm/i915/guc: fix

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Get ref on CRTC commit object when waiting for flip_done

2018-10-16 Thread Patchwork
== Series Details == Series: drm: Get ref on CRTC commit object when waiting for flip_done URL : https://patchwork.freedesktop.org/series/51079/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4990 -> Patchwork_10479 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Ensure _print_param() builds with Clang

2018-10-16 Thread Nick Desaulniers
On Tue, Oct 16, 2018 at 8:18 AM Chris Wilson wrote: > > Quoting Jani Nikula (2018-10-16 13:29:37) > > When building the kernel with Clang with defconfig and CONFIG_64BIT > > disabled, vmlinux fails to link because of the BUILD_BUG in > > _print_param. > > > > ld:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ensure intel_engine_init_execlist() builds with Clang

2018-10-16 Thread Nick Desaulniers
On Tue, Oct 16, 2018 at 8:35 AM Stephen Boyd wrote: > > Quoting Jani Nikula (2018-10-16 05:29:38) > > Clang build with UBSAN enabled leads to the following build error: I'm overjoyed that you're testing this configuration! If you find more bugs, we're happy to help triage if you let us know

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Mark pinned shmemfs pages as unevictable

2018-10-16 Thread Chris Wilson
Quoting Michal Hocko (2018-10-16 19:21:55) > On Wed 17-10-18 01:43:00, Kuo-Hsin Yang wrote: > > The i915 driver use shmemfs to allocate backing storage for gem objects. > > These shmemfs pages can be pinned (increased ref count) by > > shmem_read_mapping_page_gfp(). When a lot of pages are pinned,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Get ref on CRTC commit object when waiting for flip_done

2018-10-16 Thread Patchwork
== Series Details == Series: drm: Get ref on CRTC commit object when waiting for flip_done URL : https://patchwork.freedesktop.org/series/51079/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6539ec3e48f4 drm: Get ref on CRTC commit object when waiting for flip_done -:13:

[Intel-gfx] ✓ Fi.CI.BAT: success for shmem, drm/i915: Mark pinned shmemfs pages as unevictable

2018-10-16 Thread Patchwork
== Series Details == Series: shmem, drm/i915: Mark pinned shmemfs pages as unevictable URL : https://patchwork.freedesktop.org/series/51078/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4990 -> Patchwork_10478 = == Summary - SUCCESS == No regressions found. External

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Mark pinned shmemfs pages as unevictable

2018-10-16 Thread Michal Hocko
On Wed 17-10-18 01:43:00, Kuo-Hsin Yang wrote: > The i915 driver use shmemfs to allocate backing storage for gem objects. > These shmemfs pages can be pinned (increased ref count) by > shmem_read_mapping_page_gfp(). When a lot of pages are pinned, vmscan > wastes a lot of time scanning these

Re: [Intel-gfx] [PATCH] drm/i915: Use i915_gem_object_get_dma_address() to populate rotated vmas

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 06:54:59PM +0100, Tvrtko Ursulin wrote: > > On 16/10/2018 16:04, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Replace the kvmalloc_array() with i915_gem_object_get_dma_address() when > > populating rotated vmas. One random access mechanism ought to be enough > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: rename and move intel_get_pipe_from_connector()

2018-10-16 Thread Patchwork
== Series Details == Series: drm/i915: rename and move intel_get_pipe_from_connector() URL : https://patchwork.freedesktop.org/series/51071/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4988_full -> Patchwork_10475_full = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 07:00:11PM +0300, Imre Deak wrote: > If BIOS configured a Y tiled FB we failed to set up the backing object > tiling accordingly, leading to a lack of GT fence installed and a > garbled console. > > The problem was bisected to > commit 011f22eb545a ("drm/i915: Do NOT skip

Re: [Intel-gfx] [PATCH] drm/i915: Use i915_gem_object_get_dma_address() to populate rotated vmas

2018-10-16 Thread Tvrtko Ursulin
On 16/10/2018 16:04, Ville Syrjala wrote: From: Ville Syrjälä Replace the kvmalloc_array() with i915_gem_object_get_dma_address() when populating rotated vmas. One random access mechanism ought to be enough for everyone? To calculate the size of the radix tree I think we can do something

[Intel-gfx] [PATCH v2] drm: Get ref on CRTC commit object when waiting for flip_done

2018-10-16 Thread sunpeng.li
From: Leo Li This fixes a general protection fault, caused by accessing the contents of a flip_done completion object that has already been freed. It occurs due to the preemption of a non-blocking commit worker thread W by another commit thread X. X continues to clear its atomic state at the

[Intel-gfx] [PATCH 1/2] shmem: export shmem_unlock_mapping

2018-10-16 Thread Kuo-Hsin Yang
By exporting this function, drivers can mark/unmark a shmemfs address space as unevictable in the following way: 1. mark an address space as unevictable with mapping_set_unevictable(), pages in the address space will be moved to unevictable list in vmscan. 2. mark an address space evictable with

[Intel-gfx] [PATCH 2/2] drm/i915: Mark pinned shmemfs pages as unevictable

2018-10-16 Thread Kuo-Hsin Yang
The i915 driver use shmemfs to allocate backing storage for gem objects. These shmemfs pages can be pinned (increased ref count) by shmem_read_mapping_page_gfp(). When a lot of pages are pinned, vmscan wastes a lot of time scanning these pinned pages. Mark these pinned pages as unevictable to

[Intel-gfx] [PATCH 0/2] shmem, drm/i915: Mark pinned shmemfs pages as unevictable

2018-10-16 Thread Kuo-Hsin Yang
When a graphics heavy application is running, i915 driver may pin a lot of shmemfs pages and vmscan slows down significantly by scanning these pinned pages. This patch is an alternative to the patch by Chris Wilson [1]. As i915 driver pins all pages in an address space, marking an address space as

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gen9+: Fix initial readout for Y tiled framebuffers

2018-10-16 Thread Patchwork
== Series Details == Series: drm/i915/gen9+: Fix initial readout for Y tiled framebuffers URL : https://patchwork.freedesktop.org/series/51075/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4990 -> Patchwork_10477 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: split out display quirks to a new file

2018-10-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: split out display quirks to a new file URL : https://patchwork.freedesktop.org/series/51070/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4988_full -> Patchwork_10474_full = == Summary - WARNING ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gen9+: Fix initial readout for Y tiled framebuffers

2018-10-16 Thread Patchwork
== Series Details == Series: drm/i915/gen9+: Fix initial readout for Y tiled framebuffers URL : https://patchwork.freedesktop.org/series/51075/ State : warning == Summary == $ dim checkpatch origin/drm-tip 030f7e7d682d drm/i915/gen9+: Fix initial readout for Y tiled framebuffers -:14:

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: fix GuC suspend/resume

2018-10-16 Thread Daniele Ceraolo Spurio
On 10/16/2018 2:21 AM, Daniel Vetter wrote: On Tue, Oct 16, 2018 at 1:44 AM Daniele Ceraolo Spurio wrote: On 15/10/18 15:47, Patchwork wrote: == Series Details == Series: series starting with [1/2] drm/i915/guc: fix GuC suspend/resume URL :

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use i915_gem_object_get_dma_address() to populate rotated vmas

2018-10-16 Thread Patchwork
== Series Details == Series: drm/i915: Use i915_gem_object_get_dma_address() to populate rotated vmas URL : https://patchwork.freedesktop.org/series/51072/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4990 -> Patchwork_10476 = == Summary - SUCCESS == No regressions

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Use i915_gem_object_get_dma_address() to populate rotated vmas

2018-10-16 Thread Patchwork
== Series Details == Series: drm/i915: Use i915_gem_object_get_dma_address() to populate rotated vmas URL : https://patchwork.freedesktop.org/series/51072/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Use i915_gem_object_get_dma_address()

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: fix GuC suspend/resume

2018-10-16 Thread Daniele Ceraolo Spurio
On 10/16/2018 3:26 AM, Michal Wajdeczko wrote: On Tue, 16 Oct 2018 00:10:08 +0200, Daniele Ceraolo Spurio wrote: The ENTER/EXIT_S_STATE actions queue the save/restore operation in GuC FW and then return, so waiting on the H2H is not enough to guarantee GuC is done. When all the processing

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Limit number of scratch registers used for H2G

2018-10-16 Thread Daniele Ceraolo Spurio
On 10/16/2018 4:44 AM, Chris Wilson wrote: Quoting Michal Wajdeczko (2018-10-16 10:42:06) We wrongly assumed that GuC is only using last scratch register for G2H messages, but in fact it is also using register [14] to report sleep state status. Remove that register from our H2G send registers

Re: [Intel-gfx] [PATCH v3 04/18] drm/selftest: Add drm damage helper selftest

2018-10-16 Thread Deepak Singh Rawat
> > On Tue, Oct 16, 2018 at 02:21:17PM +0200, Daniel Vetter wrote: > > On Mon, Oct 15, 2018 at 04:11:41PM +, Deepak Singh Rawat wrote: > > > > On Wed, Oct 10, 2018 at 05:16:43PM -0700, Deepak Rawat wrote: > > > > > Selftest for drm damage helper iterator functions. > > > > > > > > > > Cc:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/icl: dsi enabling (rev2)

2018-10-16 Thread Patchwork
== Series Details == Series: drm/i915/icl: dsi enabling (rev2) URL : https://patchwork.freedesktop.org/series/51011/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4987_full -> Patchwork_10473_full = == Summary - FAILURE == Serious unknown changes coming with

Re: [Intel-gfx] [PATCH v2] drm/i915/icl: Introduce new macros to get combophy registers

2018-10-16 Thread Rodrigo Vivi
On Mon, Oct 15, 2018 at 07:35:17PM -0700, Lucas De Marchi wrote: > combo-phy register instances are at same offset from base for each > combo-phy port, i.e. > > Port A base offset: 0x16200 > Port B base offset: 0x6C000 > > All the other addresses for both ports can be derived by calculating >

Re: [Intel-gfx] [PATCH v3 04/18] drm/selftest: Add drm damage helper selftest

2018-10-16 Thread Deepak Singh Rawat
> > > Obviously needs some adjusting on the igt side too, since we seem to be > > > missing the igt scaffolding for tests-drm-helper.ko. > > > -Daniel > > > > Hi Daniel, > > > > Thanks for the review. I am a little confused here. Should we have single > > kernel module for drm plane helper

[Intel-gfx] [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers

2018-10-16 Thread Imre Deak
If BIOS configured a Y tiled FB we failed to set up the backing object tiling accordingly, leading to a lack of GT fence installed and a garbled console. The problem was bisected to commit 011f22eb545a ("drm/i915: Do NOT skip the first 4k of stolen memory for pre-allocated buffers v2") but it

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: rename and move intel_get_pipe_from_connector()

2018-10-16 Thread Patchwork
== Series Details == Series: drm/i915: rename and move intel_get_pipe_from_connector() URL : https://patchwork.freedesktop.org/series/51071/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4988 -> Patchwork_10475 = == Summary - SUCCESS == No regressions found. External

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ensure intel_engine_init_execlist() builds with Clang

2018-10-16 Thread Stephen Boyd
Quoting Jani Nikula (2018-10-16 05:29:38) > Clang build with UBSAN enabled leads to the following build error: > > drivers/gpu/drm/i915/intel_engine_cs.o: In function > `intel_engine_init_execlist': > drivers/gpu/drm/i915/intel_engine_cs.c:411: undefined reference to >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: split out display quirks to a new file

2018-10-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: split out display quirks to a new file URL : https://patchwork.freedesktop.org/series/51070/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4988 -> Patchwork_10474 = == Summary - SUCCESS == No regressions

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Ensure _print_param() builds with Clang

2018-10-16 Thread Chris Wilson
Quoting Jani Nikula (2018-10-16 13:29:37) > When building the kernel with Clang with defconfig and CONFIG_64BIT > disabled, vmlinux fails to link because of the BUILD_BUG in > _print_param. > > ld: drivers/gpu/drm/i915/i915_params.o: in function `i915_params_dump': > i915_params.c:(.text+0x56):

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ensure intel_engine_init_execlist() builds with Clang

2018-10-16 Thread Chris Wilson
Quoting Jani Nikula (2018-10-16 13:29:38) > Clang build with UBSAN enabled leads to the following build error: > > drivers/gpu/drm/i915/intel_engine_cs.o: In function > `intel_engine_init_execlist': > drivers/gpu/drm/i915/intel_engine_cs.c:411: undefined reference to >

Re: [Intel-gfx] [PATCH] drm/i915: rename and move intel_get_pipe_from_connector()

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 05:50:44PM +0300, Jani Nikula wrote: > Rename intel_get_pipe_from_connector() to intel_connector_get_pipe() and > move it near its connector function friends in intel_connector.c. No > functional changes. > > Signed-off-by: Jani Nikula > --- >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/quirks: pass dev_priv instead of drm dev to quirk code

2018-10-16 Thread Chris Wilson
Quoting Jani Nikula (2018-10-16 16:09:34) > On Tue, 16 Oct 2018, Chris Wilson wrote: > > Quoting Jani Nikula (2018-10-16 15:42:28) > >> Pass the type we want to simplify. No functional changes. > > > > But is there any reason to use dev_priv here? > > You mean as opposed to "i915"? I guess I can

Re: [Intel-gfx] [PATCH 1/2] drm/i915: split out display quirks to a new file

2018-10-16 Thread Jani Nikula
On Tue, 16 Oct 2018, Chris Wilson wrote: > Quoting Jani Nikula (2018-10-16 15:42:27) >> Reduce intel_display.c by splitting out intel_quirks.c. No functional >> changes. >> >> Signed-off-by: Jani Nikula > > I was thinking intel_display_quirks, but it is dev_priv->quirks so that > seems over

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ensure intel_engine_init_execlist() builds with Clang

2018-10-16 Thread Nathan Chancellor
On Tue, Oct 16, 2018 at 03:29:38PM +0300, Jani Nikula wrote: > Clang build with UBSAN enabled leads to the following build error: > > drivers/gpu/drm/i915/intel_engine_cs.o: In function > `intel_engine_init_execlist': > drivers/gpu/drm/i915/intel_engine_cs.c:411: undefined reference to >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Ensure _print_param() builds with Clang

2018-10-16 Thread Nathan Chancellor
On Tue, Oct 16, 2018 at 03:29:37PM +0300, Jani Nikula wrote: > When building the kernel with Clang with defconfig and CONFIG_64BIT > disabled, vmlinux fails to link because of the BUILD_BUG in > _print_param. > > ld: drivers/gpu/drm/i915/i915_params.o: in function `i915_params_dump': >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/quirks: pass dev_priv instead of drm dev to quirk code

2018-10-16 Thread Jani Nikula
On Tue, 16 Oct 2018, Chris Wilson wrote: > Quoting Jani Nikula (2018-10-16 15:42:28) >> Pass the type we want to simplify. No functional changes. > > But is there any reason to use dev_priv here? You mean as opposed to "i915"? I guess I can reroll with that if you like. BR, Jani. -- Jani

[Intel-gfx] [PATCH] drm/i915: Use i915_gem_object_get_dma_address() to populate rotated vmas

2018-10-16 Thread Ville Syrjala
From: Ville Syrjälä Replace the kvmalloc_array() with i915_gem_object_get_dma_address() when populating rotated vmas. One random access mechanism ought to be enough for everyone? To calculate the size of the radix tree I think we can do something like this (assuming 64bit pointers): num_pages

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: split out display quirks to a new file

2018-10-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: split out display quirks to a new file URL : https://patchwork.freedesktop.org/series/51070/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: split out display quirks to a new

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: split out display quirks to a new file

2018-10-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: split out display quirks to a new file URL : https://patchwork.freedesktop.org/series/51070/ State : warning == Summary == $ dim checkpatch origin/drm-tip fab3a4d687b6 drm/i915: split out display quirks to a new file -:225:

  1   2   >