Re: [Intel-gfx] [PATCH 0/6] Add uAPI to support ICL VME hardware for new media-driver

2019-02-04 Thread Stéphane Marchesin
On Mon, Feb 4, 2019 at 1:07 AM Daniel Vetter wrote: > > On Mon, Feb 04, 2019 at 10:57:24AM +0200, Joonas Lahtinen wrote: > > Quoting Joonas Lahtinen (2019-01-15 16:47:27) > > > Hi all, > > > > > > I would like to have some Acked-by's from you, the distro media > > > folks Cc'd here, to document

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/dsc: Add kernel documentation for DRM DP DSC helpers

2019-02-04 Thread Patchwork
== Series Details == Series: drm/dsc: Add kernel documentation for DRM DP DSC helpers URL : https://patchwork.freedesktop.org/series/56206/ State : success == Summary == CI Bug Log - changes from CI_DRM_5537_full -> Patchwork_12133_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Rename HAS_GMCH

2019-02-04 Thread Patchwork
== Series Details == Series: drm/i915: Rename HAS_GMCH URL : https://patchwork.freedesktop.org/series/56203/ State : success == Summary == CI Bug Log - changes from CI_DRM_5537_full -> Patchwork_12132_full Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/i915: Rename HAS_GMCH

2019-02-04 Thread Souza, Jose
On Mon, 2019-02-04 at 14:25 -0800, Rodrigo Vivi wrote: > First of all GMCH can be considered a feature by itself > since it is a chip present in some platforms that connects > the IA processor to memory and other components in PC. > > Also with the introduction of display block at device info, >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/dsc: Add kernel documentation for DRM DP DSC helpers

2019-02-04 Thread Patchwork
== Series Details == Series: drm/dsc: Add kernel documentation for DRM DP DSC helpers URL : https://patchwork.freedesktop.org/series/56206/ State : success == Summary == CI Bug Log - changes from CI_DRM_5537 -> Patchwork_12133 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/dsc: Add kernel documentation for DRM DP DSC helpers

2019-02-04 Thread Patchwork
== Series Details == Series: drm/dsc: Add kernel documentation for DRM DP DSC helpers URL : https://patchwork.freedesktop.org/series/56206/ State : warning == Summary == $ dim checkpatch origin/drm-tip c4d880a3c147 drm/dsc: Add kernel documentation for DRM DP DSC helpers -:6:

[Intel-gfx] [PATCH] drm/dsc: Add kernel documentation for DRM DP DSC helpers

2019-02-04 Thread Manasi Navare
This patch adds appropiate kernel documentation for DRM DP helpers used for enabling Display Stream compression functionality in drm_dp_helper.h and drm_dp_helper.c as well as for the DSC spec related structure definitions and helpers in drm_dsc.c and drm_dsc.h Also add links between the functions

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Rename HAS_GMCH

2019-02-04 Thread Patchwork
== Series Details == Series: drm/i915: Rename HAS_GMCH URL : https://patchwork.freedesktop.org/series/56203/ State : success == Summary == CI Bug Log - changes from CI_DRM_5537 -> Patchwork_12132 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: W/A for underruns with WM1+ disabled on icl

2019-02-04 Thread Matt Roper
On Mon, Feb 04, 2019 at 10:22:32PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Disabling WM1+ on ICL causes tons of underruns with > linear/X-tiled framebuffers. We can avoid this by flipping > on a chicken bit affecting the way the hw fill the FIFO. > This may not be the final

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Setup PIPE_CHICKEN for fastsets too

2019-02-04 Thread Matt Roper
On Mon, Feb 04, 2019 at 10:22:14PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Configure PIPE_CHICKEN during intel_update_pipe_config() to make > sure we have our chickens in a row with fastboot too. > > v2: Apparently PIPE_CHICKEN is icl+ only > > Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Extract icl_set_pipe_chicken()

2019-02-04 Thread Matt Roper
On Mon, Feb 04, 2019 at 10:21:39PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We need configure PIPE_CHICKEN during fastboot as well. Let's extract > it to a helper. > > v2: Apparently PIPE_CHICKEN is icl+ only > > Signed-off-by: Ville Syrjälä Reviewed-by: Matt Roper > --- >

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Fix wm latency==0 disable on skl+

2019-02-04 Thread Matt Roper
On Mon, Feb 04, 2019 at 08:45:20PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > When adding the early latency==0 check back I neglected to > realize that we no longer have a way to return a failure > from the wm computation like we had in the past (since we > now calculate wms before

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Rename HAS_GMCH

2019-02-04 Thread Patchwork
== Series Details == Series: drm/i915: Rename HAS_GMCH URL : https://patchwork.freedesktop.org/series/56203/ State : warning == Summary == $ dim checkpatch origin/drm-tip 95ec42fb699e drm/i915: Rename HAS_GMCH -:64: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Include register polling in reg_rw traces

2019-02-04 Thread Patchwork
== Series Details == Series: drm/i915: Include register polling in reg_rw traces URL : https://patchwork.freedesktop.org/series/56201/ State : success == Summary == CI Bug Log - changes from CI_DRM_5536_full -> Patchwork_12131_full Summary

[Intel-gfx] [PATCH] drm/i915: Rename HAS_GMCH

2019-02-04 Thread Rodrigo Vivi
First of all GMCH can be considered a feature by itself since it is a chip present in some platforms that connects the IA processor to memory and other components in PC. Also with the introduction of display block at device info, we got a redundant definition: .display.has_gmch_display = 1, So,

Re: [Intel-gfx] [PATCH v2 RESEND 2/2] drm/i915/icl: Implement half float formats

2019-02-04 Thread Strasser, Kevin
Ville Syrjälä wrote: > Kevin Strasser wrote: > > Ville Syrjälä wrote: > > > is_hdr_plane() is around now, please use it. > > > > I don't think I can use icl_is_hdr_plane here without some refactoring. It > > requires the plane->base to be initialized through drm_universal_plane_init, > > which

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Fix wm latency==0 disable on skl+ (rev4)

2019-02-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Fix wm latency==0 disable on skl+ (rev4) URL : https://patchwork.freedesktop.org/series/56199/ State : success == Summary == CI Bug Log - changes from CI_DRM_5536_full -> Patchwork_12130_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Include register polling in reg_rw traces

2019-02-04 Thread Patchwork
== Series Details == Series: drm/i915: Include register polling in reg_rw traces URL : https://patchwork.freedesktop.org/series/56201/ State : success == Summary == CI Bug Log - changes from CI_DRM_5536 -> Patchwork_12131 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Include register polling in reg_rw traces

2019-02-04 Thread Chris Wilson
Quoting Ville Syrjala (2019-02-04 21:16:44) > From: Ville Syrjälä > > We generally omit register polling from the i915_reg_rw tracepoint. > Understandable since polling could generate a lot of noise in the > trace. The downside is that the trace is incomplete. As a compromise > let's trace the

Re: [Intel-gfx] [PATCH 15/22] drm/i915: Make request allocation caches global

2019-02-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-02-04 18:48:50) > > On 04/02/2019 13:22, Chris Wilson wrote > > -int __init i915_global_active_init(void) > > +int i915_global_active_init(void) > > These can't remain __init, since they are only called from the global > __init one? I ran into problems, and removed

Re: [Intel-gfx] [PATCH v2 RESEND 2/2] drm/i915/icl: Implement half float formats

2019-02-04 Thread Ville Syrjälä
On Fri, Feb 01, 2019 at 09:38:57PM +, Strasser, Kevin wrote: > Ville Syrjälä wrote: > > > @@ -1774,6 +1776,45 @@ static const u32 skl_planar_formats[] = { > > >DRM_FORMAT_NV12, > > > }; > > > > > > +static const uint32_t icl_hdr_plane_formats[] = { > > > > Please switch to u32 & co.

[Intel-gfx] [PATCH] drm/i915: Include register polling in reg_rw traces

2019-02-04 Thread Ville Syrjala
From: Ville Syrjälä We generally omit register polling from the i915_reg_rw tracepoint. Understandable since polling could generate a lot of noise in the trace. The downside is that the trace is incomplete. As a compromise let's trace the final register value observed while polling. That should

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Fix wm latency==0 disable on skl+ (rev4)

2019-02-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Fix wm latency==0 disable on skl+ (rev4) URL : https://patchwork.freedesktop.org/series/56199/ State : success == Summary == CI Bug Log - changes from CI_DRM_5536 -> Patchwork_12130

[Intel-gfx] [PATCH v2 4/4] drm/i915: W/A for underruns with WM1+ disabled on icl

2019-02-04 Thread Ville Syrjala
From: Ville Syrjälä Disabling WM1+ on ICL causes tons of underruns with linear/X-tiled framebuffers. We can avoid this by flipping on a chicken bit affecting the way the hw fill the FIFO. This may not be the final solution but should hopefully avoid some underruns in the meantime. v2:

[Intel-gfx] [PATCH v2 3/4] drm/i915: Setup PIPE_CHICKEN for fastsets too

2019-02-04 Thread Ville Syrjala
From: Ville Syrjälä Configure PIPE_CHICKEN during intel_update_pipe_config() to make sure we have our chickens in a row with fastboot too. v2: Apparently PIPE_CHICKEN is icl+ only Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+)

[Intel-gfx] [PATCH v2 2/4] drm/i915: Extract icl_set_pipe_chicken()

2019-02-04 Thread Ville Syrjala
From: Ville Syrjälä We need configure PIPE_CHICKEN during fastboot as well. Let's extract it to a helper. v2: Apparently PIPE_CHICKEN is icl+ only Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 31 ++-- 1 file changed, 20 insertions(+), 11

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Fix wm latency==0 disable on skl+

2019-02-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Fix wm latency==0 disable on skl+ URL : https://patchwork.freedesktop.org/series/56199/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5536 -> Patchwork_12129

Re: [Intel-gfx] [PATCH] drm/i915: Trim NEWCLIENT boosting

2019-02-04 Thread Tvrtko Ursulin
On 04/02/2019 15:01, Chris Wilson wrote: Limit the NEWCLIENT boost to only give its small priority boost to fresh clients only that have no dependencies. The idea for using NEWCLIENT boosting, commit b16c765122f9 ("drm/i915: Priority boost for new clients"), is that short-lived streams are

Re: [Intel-gfx] [PATCH 19/22] drm/i915/execlists: Refactor out can_merge_rq()

2019-02-04 Thread Tvrtko Ursulin
On 04/02/2019 13:22, Chris Wilson wrote: In the next patch, we add another user that wants to check whether requests can be merge into a single HW execution, and in the future we want to add more conditions under which requests from the same context cannot be merge. In preparation, extract out

Re: [Intel-gfx] [PATCH 18/22] drm/i915: Keep timeline HWSP allocated until idle across the system

2019-02-04 Thread Tvrtko Ursulin
On 04/02/2019 13:22, Chris Wilson wrote: In preparation for enabling HW semaphores, we need to keep in flight timeline HWSP alive until its use across entire system has completed, as any other timeline active on the GPU may still refer back to the already retired timeline. We both have to delay

Re: [Intel-gfx] [PATCH 17/22] drm/i915: Pull i915_gem_active into the i915_active family

2019-02-04 Thread Tvrtko Ursulin
On 04/02/2019 13:22, Chris Wilson wrote: Looking forward, we need to break the struct_mutex dependency on i915_gem_active. In the meantime, external use of i915_gem_active is quite beguiling, little do new users suspect that it implies a barrier as each request it tracks must be ordered wrt the

Re: [Intel-gfx] [PATCH 15/22] drm/i915: Make request allocation caches global

2019-02-04 Thread Tvrtko Ursulin
On 04/02/2019 13:22, Chris Wilson wrote As kmem_caches share the same properties (size, allocation/free behaviour) for all potential devices, we can use global caches. While this potential has worse fragmentation behaviour (one can argue that different devices would have different activity

[Intel-gfx] [PATCH 4/4] drm/i915: W/A for underruns with WM1+ disabled on icl

2019-02-04 Thread Ville Syrjala
From: Ville Syrjälä Disabling WM1+ on ICL causes tons of underruns with linear/X-tiled framebuffers. We can avoid this by flipping on a chicken bit affecting the way the hw fill the FIFO. This may not be the final solution but should hopefully avoid some underruns in the meantime.

[Intel-gfx] [PATCH 2/4] drm/i915: Extract skl_set_pipe_chicken()

2019-02-04 Thread Ville Syrjala
From: Ville Syrjälä We need configure PIPE_CHICKEN during fastboot as well. Let's extract it to a helper. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 32 ++-- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git

[Intel-gfx] [PATCH 1/4] drm/i915: Fix wm latency==0 disable on skl+

2019-02-04 Thread Ville Syrjala
From: Ville Syrjälä When adding the early latency==0 check back I neglected to realize that we no longer have a way to return a failure from the wm computation like we had in the past (since we now calculate wms before ddb allocations). Also plane_en being false doesn't actually indicate that

[Intel-gfx] [PATCH 3/4] drm/i915: Setup PIPE_CHICKEN for fastsets too

2019-02-04 Thread Ville Syrjala
From: Ville Syrjälä Configure PIPE_CHICKEN during intel_update_pipe_config() to make sure we have our chickens in a row with fastboot too. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Intel-gfx] [PATCH 14/22] drm/i915: Allocate active tracking nodes from a slabcache

2019-02-04 Thread Tvrtko Ursulin
On 04/02/2019 13:22, Chris Wilson wrote: Wrap the active tracking for a GPU references in a slabcache for faster allocations, and hopefully better fragmentation reduction. v3: Nothing device specific left, it's just a slabcache that we can make global. v4: Include i915_active.h and don't put

Re: [Intel-gfx] [v10 1/3] drm: Add HDMI colorspace property

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Ville Syrjälä >Sent: Monday, February 4, 2019 10:54 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville ; >dri- >de...@lists.freedesktop.org; Lankhorst, Maarten >

Re: [Intel-gfx] [PATCH] drm/i915: do not return invalid pointers as a *dentry

2019-02-04 Thread Rodrigo Vivi
On Thu, Jan 31, 2019 at 07:17:02PM +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 31, 2019 at 09:59:26AM -0800, Rodrigo Vivi wrote: > > On Thu, Jan 31, 2019 at 02:15:07PM +0100, Greg Kroah-Hartman wrote: > > > When calling debugfs functions, they can now return error values if > > > something went

Re: [Intel-gfx] [PATCH 6/6] drm/drv: Remove drm_dev_unplug()

2019-02-04 Thread Oleksandr Andrushchenko
On 2/3/19 5:42 PM, Noralf Trønnes wrote: > There are no users left. > > Signed-off-by: Noralf Trønnes Reviewed-by: Oleksandr Andrushchenko > --- > drivers/gpu/drm/drm_drv.c | 17 - > include/drm/drm_drv.h | 1 - > 2 files changed, 18 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH 5/6] drm/xen: Use drm_dev_unregister()

2019-02-04 Thread Oleksandr Andrushchenko
On 2/3/19 5:41 PM, Noralf Trønnes wrote: > drm_dev_unplug() has been stripped down and is going away. Open code its > 2 remaining function calls. > > Also remove the drm_dev_is_unplugged() check since this can't be true > before drm_dev_unregister() is called which happens after the check. > > Cc:

Re: [Intel-gfx] [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug()

2019-02-04 Thread Oleksandr Andrushchenko
On 2/3/19 5:41 PM, Noralf Trønnes wrote: > The only thing now that makes drm_dev_unplug() special is that it sets > drm_device->unplugged. Move this code to drm_dev_unregister() so that we > can remove drm_dev_unplug(). > > Signed-off-by: Noralf Trønnes Reviewed-by: Oleksandr Andrushchenko > ---

Re: [Intel-gfx] [PATCH 1/6] drm: Fix drm_release() and device unplug

2019-02-04 Thread Oleksandr Andrushchenko
On 2/3/19 5:41 PM, Noralf Trønnes wrote: > If userspace has open fd(s) when drm_dev_unplug() is run, it will result > in drm_dev_unregister() being called twice. First in drm_dev_unplug() and > then later in drm_release() through the call to drm_put_dev(). > > Since userspace already holds a ref

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Drop WaIncreaseLatencyIPCEnabled/1140 for cnl

2019-02-04 Thread Ville Syrjälä
On Mon, Feb 04, 2019 at 09:49:42AM -0800, Rodrigo Vivi wrote: > On Mon, Feb 04, 2019 at 07:40:56PM +0200, Ville Syrjälä wrote: > > On Thu, Jan 31, 2019 at 10:10:47AM -0800, Rodrigo Vivi wrote: > > > On Thu, Jan 31, 2019 at 09:42:16AM +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: HDCP state handling in ddi_update_pipe (rev2)

2019-02-04 Thread Patchwork
== Series Details == Series: drm/i915: HDCP state handling in ddi_update_pipe (rev2) URL : https://patchwork.freedesktop.org/series/56182/ State : success == Summary == CI Bug Log - changes from CI_DRM_5536_full -> Patchwork_12128_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/22] drm/i915/execlists: Suppress mere WAIT preemption (rev2)

2019-02-04 Thread Patchwork
== Series Details == Series: series starting with [01/22] drm/i915/execlists: Suppress mere WAIT preemption (rev2) URL : https://patchwork.freedesktop.org/series/56183/ State : success == Summary == CI Bug Log - changes from CI_DRM_5536_full -> Patchwork_12127_full

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Drop WaIncreaseLatencyIPCEnabled/1140 for cnl

2019-02-04 Thread Rodrigo Vivi
On Mon, Feb 04, 2019 at 07:40:56PM +0200, Ville Syrjälä wrote: > On Thu, Jan 31, 2019 at 10:10:47AM -0800, Rodrigo Vivi wrote: > > On Thu, Jan 31, 2019 at 09:42:16AM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Drop WaIncreaseLatencyIPCEnabled/Display w/a #1140 for > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: HDCP state handling in ddi_update_pipe

2019-02-04 Thread Patchwork
== Series Details == Series: drm/i915: HDCP state handling in ddi_update_pipe URL : https://patchwork.freedesktop.org/series/56182/ State : success == Summary == CI Bug Log - changes from CI_DRM_5536_full -> Patchwork_12125_full Summary

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Drop WaIncreaseLatencyIPCEnabled/1140 for cnl

2019-02-04 Thread Ville Syrjälä
On Thu, Jan 31, 2019 at 10:10:47AM -0800, Rodrigo Vivi wrote: > On Thu, Jan 31, 2019 at 09:42:16AM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Drop WaIncreaseLatencyIPCEnabled/Display w/a #1140 for > > early cnl steppings. Also switch the kbl/cfl case to check > > for

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: Enable transition watermarks for glk

2019-02-04 Thread Ville Syrjälä
On Thu, Jan 31, 2019 at 08:07:35PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [1/4] drm/i915: Enable transition watermarks for > glk > URL : https://patchwork.freedesktop.org/series/56025/ > State : failure > > == Summary == > > CI Bug Log - changes from

Re: [Intel-gfx] [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug()

2019-02-04 Thread Noralf Trønnes
Den 04.02.2019 16.41, skrev Daniel Vetter: > On Sun, Feb 03, 2019 at 04:41:56PM +0100, Noralf Trønnes wrote: >> The only thing now that makes drm_dev_unplug() special is that it sets >> drm_device->unplugged. Move this code to drm_dev_unregister() so that we >> can remove drm_dev_unplug(). >> >>

Re: [Intel-gfx] [v10 1/3] drm: Add HDMI colorspace property

2019-02-04 Thread Ville Syrjälä
On Mon, Feb 04, 2019 at 05:08:40PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > >Sent: Monday, February 4, 2019 8:55 PM > >To: Shankar, Uma > >Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > >; > >Lankhorst,

Re: [Intel-gfx] [PATCH] drm/i915: HDCP state handling in ddi_update_pipe

2019-02-04 Thread C, Ramalingam
On 2/4/2019 10:34 PM, Maarten Lankhorst wrote: Op 04-02-2019 om 17:51 schreef C, Ramalingam: On 2/4/2019 10:13 PM, Maarten Lankhorst wrote: Op 04-02-2019 om 16:44 schreef Ramalingam C: The downgrade of the fullmodeset into fastset intel_encoder->update_pipe, in possible scenario, skips the

Re: [Intel-gfx] [v10 3/3] drm/i915: Attach colorspace property and enable modeset

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Ville Syrjälä >Sent: Saturday, February 2, 2019 12:31 AM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville ; >Lankhorst, Maarten ; dri- >de...@lists.freedesktop.org

[Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Verify that waiters do not report as busy

2019-02-04 Thread Chris Wilson
If we queue requests that must wait for the current spinner to finish, those waiting engines should not be reported as busy (or else we perturb scheduling logic that tries to distribute workloads onto idle engines -- if all engines are busy, even those waiting, it degrades into a round-robin

Re: [Intel-gfx] [v10 2/3] drm: Add DP colorspace property

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Ville Syrjälä >Sent: Saturday, February 2, 2019 12:48 AM >To: Shankar, Uma >Cc: emil.l.veli...@gmail.com; intel-gfx@lists.freedesktop.org; Syrjala, Ville >; Lankhorst, Maarten ;

Re: [Intel-gfx] [v10 1/3] drm: Add HDMI colorspace property

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Monday, February 4, 2019 8:55 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville ; >Lankhorst, Maarten ; dri- >de...@lists.freedesktop.org >Subject: Re: [Intel-gfx] [v10 1/3]

Re: [Intel-gfx] [PATCH] drm/i915: HDCP state handling in ddi_update_pipe

2019-02-04 Thread Maarten Lankhorst
Op 04-02-2019 om 17:51 schreef C, Ramalingam: > > > On 2/4/2019 10:13 PM, Maarten Lankhorst wrote: >> Op 04-02-2019 om 16:44 schreef Ramalingam C: >>> The downgrade of the fullmodeset into fastset >>> intel_encoder->update_pipe, in possible scenario, skips the En/Dis-able >>> DDI. Hence breaks the

Re: [Intel-gfx] [PATCH] drm/i915: HDCP state handling in ddi_update_pipe

2019-02-04 Thread C, Ramalingam
On 2/4/2019 10:13 PM, Maarten Lankhorst wrote: Op 04-02-2019 om 16:44 schreef Ramalingam C: The downgrade of the fullmodeset into fastset intel_encoder->update_pipe, in possible scenario, skips the En/Dis-able DDI. Hence breaks the HDCP state change handling. We also don't have any hdcp

Re: [Intel-gfx] [PATCH 05/22] drm/i915: Show support for accurate sw PMU busyness tracking

2019-02-04 Thread Chris Wilson
Quoting Chris Wilson (2019-02-04 13:21:57) > Expose whether or not we support the PMU software tracking in our > scheduler capabilities, so userspace can query at runtime. Another datum: /* * Also there is software busyness tracking available we do not * need the timer

Re: [Intel-gfx] [PATCH] drm/i915: HDCP state handling in ddi_update_pipe

2019-02-04 Thread Maarten Lankhorst
Op 04-02-2019 om 16:44 schreef Ramalingam C: > The downgrade of the fullmodeset into fastset > intel_encoder->update_pipe, in possible scenario, skips the En/Dis-able > DDI. Hence breaks the HDCP state change handling. > > We also don't have any hdcp tests in CI, because the shard runs don't >

Re: [Intel-gfx] [PATCH v10 38/40] drm/i915: Fix KBL HDCP2.2 encrypt status signalling

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 38/40] drm/i915: Fix KBL HDCP2.2

Re: [Intel-gfx] [PATCH v10 36/40] misc/mei/hdcp: Component framework for I915 Interface

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 36/40] misc/mei/hdcp: Component

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: HDCP state handling in ddi_update_pipe (rev2)

2019-02-04 Thread Patchwork
== Series Details == Series: drm/i915: HDCP state handling in ddi_update_pipe (rev2) URL : https://patchwork.freedesktop.org/series/56182/ State : success == Summary == CI Bug Log - changes from CI_DRM_5536 -> Patchwork_12128 Summary

Re: [Intel-gfx] [PATCH v10 35/40] misc/mei/hdcp: Closing wired HDCP2.2 Tx Session

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 35/40] misc/mei/hdcp: Closing wired

Re: [Intel-gfx] [PATCH v10 34/40] misc/mei/hdcp: Enabling the HDCP authentication

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 34/40] misc/mei/hdcp: Enabling the

Re: [Intel-gfx] [PATCH v10 33/40] misc/mei/hdcp: Verify M_prime

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 33/40] misc/mei/hdcp: Verify

Re: [Intel-gfx] [PATCH v10 32/40] misc/mei/hdcp: Repeater topology verification and ack

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 32/40] misc/mei/hdcp: Repeater

Re: [Intel-gfx] [PATCH v10 31/40] misc/mei/hdcp: Prepare Session Key

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 31/40] misc/mei/hdcp: Prepare

Re: [Intel-gfx] [PATCH v10 30/40] misc/mei/hdcp: Verify L_prime

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 30/40] misc/mei/hdcp: Verify

Re: [Intel-gfx] [PATCH v10 29/40] misc/mei/hdcp: Initiate Locality check

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 29/40] misc/mei/hdcp: Initiate

Re: [Intel-gfx] [PATCH v10 28/40] misc/mei/hdcp: Store the HDCP Pairing info

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Ramalingam C >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma

Re: [Intel-gfx] [PATCH v10 20/40] drm/i915: Add HDCP2.2 support for HDMI connectors

2019-02-04 Thread C, Ramalingam
On 2/4/2019 9:34 PM, Winkler, Tomas wrote: On HDMI connector init, intel_hdcp_init is passed with a flag for hdcp2.2 support based on the platform capability. v2: Rebased. v3: Collected the reviewed-by received. Signed-off-by: Ramalingam C Reviewed-by: Uma Shankar ---

Re: [Intel-gfx] [PATCH v10 27/40] misc/mei/hdcp: Verify H_prime

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 27/40] misc/mei/hdcp: Verify

Re: [Intel-gfx] [PATCH v10 26/40] misc/mei/hdcp: Verify Receiver Cert and prepare km

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 26/40] misc/mei/hdcp: Verify

Re: [Intel-gfx] [PATCH v10 25/40] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 25/40] misc/mei/hdcp: Initiate

Re: [Intel-gfx] [PATCH v10 19/40] drm/i915: Add HDCP2.2 support for DP connectors

2019-02-04 Thread Winkler, Tomas
> -Original Message- > From: C, Ramalingam > Sent: Thursday, January 31, 2019 09:00 > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, > Uma > Cc: C, Ramalingam > Subject: [PATCH v10 19/40] drm/i915: Add HDCP2.2

Re: [Intel-gfx] [PATCH v10 24/40] misc/mei/hdcp: Define ME FW interface for HDCP2.2

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 24/40] misc/mei/hdcp: Define ME FW

Re: [Intel-gfx] [PATCH v10 20/40] drm/i915: Add HDCP2.2 support for HDMI connectors

2019-02-04 Thread Winkler, Tomas
> > On HDMI connector init, intel_hdcp_init is passed with a flag for hdcp2.2 > support based on the platform capability. > > v2: > Rebased. > v3: > Collected the reviewed-by received. > > Signed-off-by: Ramalingam C > Reviewed-by: Uma Shankar > --- > drivers/gpu/drm/i915/intel_hdmi.c |

Re: [Intel-gfx] [PATCH v10 17/40] drm/i915: Implement the HDCP2.2 support for HDMI

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 17/40] drm/i915: Implement the

Re: [Intel-gfx] [PATCH v10 16/40] drm/i915: Implement the HDCP2.2 support for DP

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 16/40] drm/i915: Implement the

[Intel-gfx] [PATCH] drm/i915: HDCP state handling in ddi_update_pipe

2019-02-04 Thread Ramalingam C
The downgrade of the fullmodeset into fastset intel_encoder->update_pipe, in possible scenario, skips the En/Dis-able DDI. Hence breaks the HDCP state change handling. We also don't have any hdcp tests in CI, because the shard runs don't have hdcp capable outputs :-/ So this change fixs it by

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/22] drm/i915/execlists: Suppress mere WAIT preemption (rev2)

2019-02-04 Thread Patchwork
== Series Details == Series: series starting with [01/22] drm/i915/execlists: Suppress mere WAIT preemption (rev2) URL : https://patchwork.freedesktop.org/series/56183/ State : success == Summary == CI Bug Log - changes from CI_DRM_5536 -> Patchwork_12127

Re: [Intel-gfx] [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug()

2019-02-04 Thread Daniel Vetter
On Sun, Feb 03, 2019 at 04:41:56PM +0100, Noralf Trønnes wrote: > The only thing now that makes drm_dev_unplug() special is that it sets > drm_device->unplugged. Move this code to drm_dev_unregister() so that we > can remove drm_dev_unplug(). > > Signed-off-by: Noralf Trønnes > --- > > Maybe

Re: [Intel-gfx] [PATCH v10 38/40] drm/i915: Fix KBL HDCP2.2 encrypt status signalling

2019-02-04 Thread C, Ramalingam
daniel, Could you please review this patch too.? Already Updated this as per your previous review comment. --Ram On 1/31/2019 12:29 PM, Ramalingam C wrote: Implement the required WA sequence for KBL to fix the incorrect positioning of the window of oppurtunity and enc_en signalling. v2:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/22] drm/i915/execlists: Suppress mere WAIT preemption (rev2)

2019-02-04 Thread Patchwork
== Series Details == Series: series starting with [01/22] drm/i915/execlists: Suppress mere WAIT preemption (rev2) URL : https://patchwork.freedesktop.org/series/56183/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/execlists: Suppress mere

Re: [Intel-gfx] [PATCH 7/7] drm/i915/perf: add flushing ioctl

2019-02-04 Thread Lionel Landwerlin
On 22/01/2019 16:25, Joonas Lahtinen wrote: Quoting Lionel Landwerlin (2019-01-16 17:36:22) With the currently available parameters for the i915-perf stream, there are still situations that are not well covered : If an application opens the stream with polling disable or at very low frequency

Re: [Intel-gfx] [v10 1/3] drm: Add HDMI colorspace property

2019-02-04 Thread Ville Syrjälä
On Fri, Feb 01, 2019 at 08:50:11PM +0200, Ville Syrjälä wrote: > On Wed, Jan 30, 2019 at 06:24:24PM +0530, Uma Shankar wrote: > > Create a new connector property to program colorspace to sink > > devices. Modern sink devices support more than 1 type of > > colorspace like 601, 709, BT2020 etc.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/22] drm/i915/execlists: Suppress mere WAIT preemption (rev2)

2019-02-04 Thread Patchwork
== Series Details == Series: series starting with [01/22] drm/i915/execlists: Suppress mere WAIT preemption (rev2) URL : https://patchwork.freedesktop.org/series/56183/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1436da54695c drm/i915/execlists: Suppress mere WAIT

Re: [Intel-gfx] [PATCH v10 02/40] i915/snd_hdac: I915 subcomponent for the snd_hdac

2019-02-04 Thread Takashi Iwai
On Mon, 04 Feb 2019 16:00:18 +0100, Daniel Vetter wrote: > > On Thu, Jan 31, 2019 at 12:29:18PM +0530, Ramalingam C wrote: > > From: Daniel Vetter > > > > Since we need multiple components for I915 for different purposes > > (Audio & Mei_hdcp), we adopt the subcomponents methodology introduced

[Intel-gfx] [PATCH] drm/i915: Trim NEWCLIENT boosting

2019-02-04 Thread Chris Wilson
Limit the NEWCLIENT boost to only give its small priority boost to fresh clients only that have no dependencies. The idea for using NEWCLIENT boosting, commit b16c765122f9 ("drm/i915: Priority boost for new clients"), is that short-lived streams are often interactive and require lower latency --

Re: [Intel-gfx] [PATCH v10 02/40] i915/snd_hdac: I915 subcomponent for the snd_hdac

2019-02-04 Thread Daniel Vetter
On Thu, Jan 31, 2019 at 12:29:18PM +0530, Ramalingam C wrote: > From: Daniel Vetter > > Since we need multiple components for I915 for different purposes > (Audio & Mei_hdcp), we adopt the subcomponents methodology introduced > by the previous patch (mentioned below). > > Author: Daniel

Re: [Intel-gfx] [PATCH v10 12/40] drm: HDCP2.2 link check period

2019-02-04 Thread C, Ramalingam
On 2/4/2019 7:54 PM, Shankar, Uma wrote: -Original Message- From: C, Ramalingam Sent: Thursday, January 31, 2019 12:29 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, Uma Cc: C, Ramalingam Subject: [PATCH

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/22] drm/i915/execlists: Suppress mere WAIT preemption

2019-02-04 Thread Patchwork
== Series Details == Series: series starting with [01/22] drm/i915/execlists: Suppress mere WAIT preemption URL : https://patchwork.freedesktop.org/series/56183/ State : success == Summary == CI Bug Log - changes from CI_DRM_5536 -> Patchwork_12126

Re: [Intel-gfx] [PATCH v10 07/40] drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking

2019-02-04 Thread C, Ramalingam
On 2/4/2019 7:39 PM, Shankar, Uma wrote: -Original Message- From: C, Ramalingam Sent: Thursday, January 31, 2019 12:29 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, Uma Cc: C, Ramalingam Subject: [PATCH

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: HDCP state handling in ddi_update_pipe

2019-02-04 Thread Patchwork
== Series Details == Series: drm/i915: HDCP state handling in ddi_update_pipe URL : https://patchwork.freedesktop.org/series/56182/ State : success == Summary == CI Bug Log - changes from CI_DRM_5536 -> Patchwork_12125 Summary ---

Re: [Intel-gfx] [PATCH v10 15/40] drm: removing the DP Errata msg and its msg id

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 15/40] drm: removing the DP Errata

Re: [Intel-gfx] [PATCH v10 14/40] drm/i915: Handle HDCP2.2 downstream topology change

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:30 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 14/40] drm/i915: Handle HDCP2.2

Re: [Intel-gfx] [PATCH v10 13/40] drm/i915: Implement HDCP2.2 link integrity check

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:29 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 13/40] drm/i915: Implement HDCP2.2

Re: [Intel-gfx] [PATCH v10 12/40] drm: HDCP2.2 link check period

2019-02-04 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Thursday, January 31, 2019 12:29 PM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, >Uma >Cc: C, Ramalingam >Subject: [PATCH v10 12/40] drm: HDCP2.2 link check

  1   2   >