== Series Details ==
Series: Documentation/i915: fix file references after display/ subdir renames
URL : https://patchwork.freedesktop.org/series/62197/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6287_full -> Patchwork_13307_full
On Tue, Jun 18, 2019 at 12:41:32PM +0800, James (Qian) Wang wrote:
> On Mon, Jun 17, 2019 at 03:43:45PM +0200, Daniel Vetter wrote:
> > On Mon, Jun 17, 2019 at 06:26:08AM +, james qian wang (Arm Technology
> > China) wrote:
> > > On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote:
On 6/14/19 11:35 PM, Daniel Vetter wrote:
They're the default.
Aside: Would be really nice to switch the others over to
drm_gem_object_funcs.
Signed-off-by: Daniel Vetter
Cc: Oleksandr Andrushchenko
Cc: xen-de...@lists.xenproject.org
Reviewed-by: Oleksandr Andrushchenko
---
Hi,
> > While most callbacks are pretty straight forward (just hook the same
> > callbacks into the drm_gem_object_funcs. struct) the mmap bits are a
> > bit more obscure.
> >
> > First, there seem to be two ways to mmap a gem buffer:
> >
> > (1) drm_driver->fops->mmap, and
> > (2)
== Series Details ==
Series: drm/i915/guc: Reduce verbosity on log overflows
URL : https://patchwork.freedesktop.org/series/62195/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6287_full -> Patchwork_13306_full
Summary
On Mon, Jun 17, 2019 at 03:43:45PM +0200, Daniel Vetter wrote:
> On Mon, Jun 17, 2019 at 06:26:08AM +, james qian wang (Arm Technology
> China) wrote:
> > On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote:
> > > Read the docs, komeda is not an old enough driver for this :-)
> > >
== Series Details ==
Series: Update whitelist support for new hardware (rev2)
URL : https://patchwork.freedesktop.org/series/62076/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6289 -> Patchwork_13319
Summary
---
On 6/13/2019 23:48, Tvrtko Ursulin wrote:
On 14/06/2019 01:28, Robert M. Fosha wrote:
From: John Harrison
Newer hardware adds flags to the whitelist work-around register. These
allow per access direction privileges and ranges.
Signed-off-by: John Harrison
Signed-off-by: Robert M. Fosha
From: John Harrison
Recent hardware adds support for finer-grained control over
whitelisting, allowing registers to be whitelisted independently
for reads and/or writes. This series will add the basic plumbing
to support that.
John Harrison (3):
drm/i915: Support flags in whitlist WAs
From: John Harrison
Newer hardware requires setting up whitelists on engines other than
render. So, extend the whitelist code to support all engines.
Signed-off-by: John Harrison
Signed-off-by: Robert M. Fosha
Cc: Tvrtko Ursulin
Cc: Chris Wilson
---
From: "Robert M. Fosha"
Updates the live_workarounds selftest to handle whitelisted
registers that are flagged as read only.
Signed-off-by: Robert M. Fosha
Signed-off-by: John Harrison
---
.../gpu/drm/i915/gt/selftest_workarounds.c| 43 +--
1 file changed, 39
From: John Harrison
Newer hardware adds flags to the whitelist work-around register. These
allow per access direction privileges and ranges.
Signed-off-by: John Harrison
Signed-off-by: Robert M. Fosha
Cc: Tvrtko Ursulin
Cc: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 9
From: John Harrison
Updated whitelist table for ICL.
v2: Reduce changes to just those required for media driver until
the selftest can be updated to support the new features of the
other entries.
Signed-off-by: John Harrison
Signed-off-by: Robert M. Fosha
Cc: Tvrtko Ursulin
Cc: Chris Wilson
== Series Details ==
Series: drm/i915/ehl: Allow combo PHY A to drive a third external display (rev2)
URL : https://patchwork.freedesktop.org/series/62131/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6289 -> Patchwork_13318
== Series Details ==
Series: drm/i915: Keep engine alive as we retire the context (rev3)
URL : https://patchwork.freedesktop.org/series/62191/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6284_full -> Patchwork_13304_full
== Series Details ==
Series: drm/i915/ehl: Allow combo PHY A to drive a third external display (rev2)
URL : https://patchwork.freedesktop.org/series/62131/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
128ee0ddef48 drm/i915/ehl: Allow combo PHY A to drive a third external
EHL has a mux on combo PHY A that allows it to be driven either by an
internal display (DDI-A or DSI DPHY) or by an external display (DDI-D).
This is a motherboard design decision that can not be changed on the
fly. Unfortunately there are no strap registers that allow us to detect
the board
Hi,
Just a comment style nit below...
On 6/16/19 7:04 PM, Alastair D'Silva wrote:
> From: Alastair D'Silva
>
> This patch removes the hardcoded row limits and allows for
> other lengths. These lengths must still be a multiple of
> groupsize.
>
> This allows structs that are not 16/32 bytes to
== Series Details ==
Series: series starting with [v9,1/2] drm/i915: Introduce async plane update to
i915
URL : https://patchwork.freedesktop.org/series/62255/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6289 -> Patchwork_13317
Den 17.06.2019 23.20, skrev Daniel Vetter:
> On Mon, Jun 17, 2019 at 06:54:04PM +0200, Noralf Trønnes wrote:
>>
>>
>> Den 17.06.2019 18.29, skrev Daniel Vetter:
>>> On Mon, Jun 17, 2019 at 05:47:50PM +0200, Noralf Trønnes wrote:
Den 14.06.2019 22.35, skrev Daniel Vetter:
>
From: Gustavo Padovan
Replace the legacy cursor implementation by the async callbacks
Signed-off-by: Gustavo Padovan
Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Helen Koike
---
Changes in v9:
- v8: https://patchwork.kernel.org/patch/10843397/
- rebased and fixed conflicts on top
From: Gustavo Padovan
Add implementation for async plane update callbacks
Signed-off-by: Gustavo Padovan
Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Tina Zhang
Signed-off-by: Helen Koike
Tested-by: Tina Zhang
---
Hi,
I tested this patch set with igt (ksm_cursor_legacy and
On Mon, Jun 17, 2019 at 06:54:04PM +0200, Noralf Trønnes wrote:
>
>
> Den 17.06.2019 18.29, skrev Daniel Vetter:
> > On Mon, Jun 17, 2019 at 05:47:50PM +0200, Noralf Trønnes wrote:
> >>
> >>
> >> Den 14.06.2019 22.35, skrev Daniel Vetter:
> >>> We're kinda going in the wrong direction. Spotted
On Mon, Jun 17, 2019 at 11:36:36AM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/ehl: Introduce Mule Creek Canyon PCH (rev3)
> URL : https://patchwork.freedesktop.org/series/61137/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_6279_full ->
Here it looks like, we are changing all the helpers to accept intel_crtc_state
as an argument
and then use the intel_crtc_state->hw and ->uapi whereever needed inside the
function.
But with seperating the drm_crtc_state now into hw and uapi, wasnt one of the
goals
to retain teh helpers taking
== Series Details ==
Series: drm/i915/psr: Force manual PSR exit in older gens
URL : https://patchwork.freedesktop.org/series/62249/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6287 -> Patchwork_13316
Summary
---
On Mon, Jun 17, 2019 at 12:51:54PM -0700, José Roberto de Souza wrote:
> To do frontbuffer tracking we are depending on Display WA #0884 to
> exit PSR when there is a frontbuffer modification but according to
> user reports a write to CURSURFLIVE do not cause PSR to exit in older
> gens so lets
Quoting Tvrtko Ursulin (2019-06-17 19:12:36)
> From: Tvrtko Ursulin
>
> Scratch vma lives under gt but the API used to work on i915. Make this
> consistent by renaming the function to intel_gt_scratch_offset and make
> it take struct intel_gt.
>
> v2:
> * Move to intel_gt. (Chris)
>
>
Quoting Tvrtko Ursulin (2019-06-17 19:12:30)
> From: Tvrtko Ursulin
>
> Continuing on the theme of better logical organization of our code, make
> the first step towards making the ggtt code better isolated from wider
> struct drm_i915_private.
>
> v2:
> * Bring the ickle onion unwind back.
Quoting Tvrtko Ursulin (2019-06-17 19:12:27)
> From: Tvrtko Ursulin
>
> This aligns better with the rest of restructuring.
>
> v2:
> * Move call out of line. (Chris)
>
> Signed-off-by: Tvrtko Ursulin
> Suggested-by: Chris Wilson
Reviewed-by: Chris Wilson
-Chris
Quoting Tvrtko Ursulin (2019-06-17 19:12:26)
> From: Tvrtko Ursulin
>
> Having introduced struct intel_gt (named the anonymous structure in i915)
> we can start using it to compartmentalize our code better. It makes more
> sense logically to have the code internally like this and it will also
>
== Series Details ==
Series: drm/i915: Signal fence completion from i915_request_wait
URL : https://patchwork.freedesktop.org/series/62241/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6287 -> Patchwork_13315
Summary
Quoting Tvrtko Ursulin (2019-06-17 19:12:11)
> From: Tvrtko Ursulin
>
> Two easy opportunities to compact the code by using the existing helper.
>
> Signed-off-by: Tvrtko Ursulin
> Suggested-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/i915_gem_fence_reg.c | 9 ++---
> 1 file changed, 2
To do frontbuffer tracking we are depending on Display WA #0884 to
exit PSR when there is a frontbuffer modification but according to
user reports a write to CURSURFLIVE do not cause PSR to exit in older
gens so lets force a PSR exit.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110799
On 17/06/2019 08:19, Chris Wilson wrote:
We were using the last_fence to track the last request that used this
vma that might be interpreted by a fence register and forced ourselves
to wait for this request before modifying any fence register that
overlapped our vma. Due to requirement that we
== Series Details ==
Series: drm/rcar-du: Fix error check when retrieving crtc state
URL : https://patchwork.freedesktop.org/series/62234/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6287 -> Patchwork_13314
Summary
With the upcoming change to automanaged i915_active, the intent is that
whenever we wait on the set of active fences, they are signaled and
collected. The requirement is that all successful returns from
i915_request_wait() signal the fence, so fixup the one remaining path
where we may return
On 17/06/2019 08:19, Chris Wilson wrote:
As we need to use a mutex to serialisation i915_active activation
to serialise
(because we want to allow the callback to sleep), we need to push the
i915_active.retire into a worker callback in case we get need to retire
from an atomic context.
== Series Details ==
Series: Display uncore prep patches
URL : https://patchwork.freedesktop.org/series/62232/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6287 -> Patchwork_13312
Summary
---
**SUCCESS**
No
== Series Details ==
Series: Implicit dev_priv removal and GT compartmentalization (rev9)
URL : https://patchwork.freedesktop.org/series/62046/
State : failure
== Summary ==
Applying: drm/i915: Convert intel_vgt_(de)balloon to uncore
Applying: drm/i915: Introduce struct intel_gt as
== Series Details ==
Series: drm/i915/icl: Add missing device ID
URL : https://patchwork.freedesktop.org/series/62187/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6284_full -> Patchwork_13303_full
Summary
---
On 17/06/2019 08:19, Chris Wilson wrote:
If we introduce a callback for i915_active that is only called the first
time we use the i915_active and is symmetrically paired with the
i915_active.retire callback, we can replace the open-coded and
non-atomic implementations -- which will be very
== Series Details ==
Series: Display uncore prep patches
URL : https://patchwork.freedesktop.org/series/62232/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2803e5056bc3 drm/i915: use vfuncs for reg_read/write_fw_domains
-:61: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func'
== Series Details ==
Series: prime doc polish and ... a few cleanups (rev2)
URL : https://patchwork.freedesktop.org/series/62135/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6287 -> Patchwork_13311
Summary
---
== Series Details ==
Series: prime doc polish and ... a few cleanups (rev2)
URL : https://patchwork.freedesktop.org/series/62135/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/prime: Update docs
Okay!
Commit: drm/prime: Unconditionally set up
== Series Details ==
Series: prime doc polish and ... a few cleanups (rev2)
URL : https://patchwork.freedesktop.org/series/62135/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9afe73fb9d83 drm/prime: Update docs
-:378: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open
Hi Daniel,
On Fri, 14 Jun 2019 at 21:36, Daniel Vetter wrote:
>
> Hi all,
>
> So I figured let's get going and polish the docs for the last part of drm
> core/helpers that hasn't yet seen some neat polish last few years. With
> the goal to make docs for driver kapi a requirement henceforth - see
== Series Details ==
Series: drm/i915/gtt: Serialise both updates to PDE and our shadow (rev2)
URL : https://patchwork.freedesktop.org/series/62203/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6287 -> Patchwork_13310
From: Sean Paul
drm_atomic_get_crtc_state() returns an error pointer when it fails, so
the null check is doing nothing here.
Credit to 0-day/Dan Carpenter for reporting this.
Fixes: 6f3b62781bbd ("drm: Convert connector_helper_funcs->atomic_check to
accept drm_atomic_state")
Cc: Daniel Vetter
From: Tvrtko Ursulin
Scratch vma lives under gt but the API used to work on i915. Make this
consistent by renaming the function to intel_gt_scratch_offset and make
it take struct intel_gt.
v2:
* Move to intel_gt. (Chris)
Signed-off-by: Tvrtko Ursulin
---
From: Tvrtko Ursulin
Move all timeline code under gt and rename to intel_gt prefix.
Signed-off-by: Tvrtko Ursulin
Suggested-by: Chris Wilson
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/Makefile.header-test | 1 -
From: Tvrtko Ursulin
For gt related operations it makes more logical sense to stay in the realm
of gt instead of dereferencing via driver i915.
This patch handles a few of the easy ones with work requiring more
refactoring still outstanding.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris
From: Tvrtko Ursulin
This will become useful in the following patch.
v2:
* Assign the pointer through a helper on the top level to work around
the layering violation. (Chris)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/gt/intel_gt.c | 5 +
From: Tvrtko Ursulin
Continuing on the theme of better logical organization of our code, make
the first step towards making the ggtt code better isolated from wider
struct drm_i915_private.
v2:
* Bring the ickle onion unwind back. (Chris)
* Rename to i915_init_ggtt. (Chris)
Signed-off-by:
From: Tvrtko Ursulin
Our timelines are stored inside intel_gt so we can convert the interface
to take exactly that and not i915.
At the same time re-order the params to our more typical layout and
replace the backpointer to the new containing structure.
Signed-off-by: Tvrtko Ursulin
From: Tvrtko Ursulin
Having introduced struct intel_gt (named the anonymous structure in i915)
we can start using it to compartmentalize our code better. It makes more
sense logically to have the code internally like this and it will also
help with future split between gt and display in i915.
From: Tvrtko Ursulin
Continuing on the theme of compartmentalizing the code better to make
future split between gt and display in global i915 clearer.
v2:
* Pass in ggtt instead of gt. (Chris)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
From: Tvrtko Ursulin
This aligns better with the rest of restructuring.
v2:
* Move call out of line. (Chris)
Signed-off-by: Tvrtko Ursulin
Suggested-by: Chris Wilson
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 +++--
drivers/gpu/drm/i915/gem/i915_gem_phys.c| 3 ++-
From: Tvrtko Ursulin
Continuing on the theme of better logical organization of our code, make
the first step towards making the timeline code better isolated from wider
struct drm_i915_private.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_timeline.c |
From: Tvrtko Ursulin
Continuing on the theme of better logical organization of our code, make
the first step towards making the ggtt code better isolated from wider
struct drm_i915_private.
v2:
* Cleanup of mm.wc_stash does not need struct_mutex. (Chris)
Signed-off-by: Tvrtko Ursulin
From: Tvrtko Ursulin
This will come useful in the following patch.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 16 ++--
drivers/gpu/drm/i915/i915_gem_gtt.h | 1 +
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git
From: Tvrtko Ursulin
It is more logical for ggtt invalidation to take ggtt as input parameter.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 51 ++---
drivers/gpu/drm/i915/i915_gem_gtt.h | 2 +-
2 files changed, 26
From: Tvrtko Ursulin
More legacy mmio accessor removal. We pass in intel_gt explicitly allowing
code to use new intel_uncore_read/write helpers.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_gem.c| 2 +-
drivers/gpu/drm/i915/intel_wopcm.c | 31
From: Tvrtko Ursulin
Having made start to better code compartmentalization by introducing
struct intel_gt, continue the theme elsewhere in code by making functions
take parameters take what logically makes most sense for them instead of
the global struct drm_i915_private.
Signed-off-by: Tvrtko
From: Tvrtko Ursulin
More removal of implicit dev_priv from using old mmio accessors.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
drivers/gpu/drm/i915/i915_gem_gtt.c | 102 ++--
From: Tvrtko Ursulin
Having made start to better code compartmentalization by introducing
struct intel_gt, continue the theme elsewhere in code by making functions
take parameters take what logically makes most sense for them instead of
the global struct drm_i915_private.
Signed-off-by: Tvrtko
From: Tvrtko Ursulin
As it will grow in a following patch make a new home for it.
v2:
* Convert mock_gem_device as well. (Chris)
v3:
* Rename to intel_gt_init_early and move call site to i915_drv.c. (Chris)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Rodrigo Vivi # v2
---
From: Tvrtko Ursulin
Replace some gen6/7 open coded rmw with intel_uncore_rmw.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 41 +
1 file changed, 18 insertions(+), 23 deletions(-)
diff --git
From: Tvrtko Ursulin
Two easy opportunities to compact the code by using the existing helper.
Signed-off-by: Tvrtko Ursulin
Suggested-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_gem_fence_reg.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git
From: Tvrtko Ursulin
More removal of implicit dev_priv from using old mmio accessors.
Actually the top level function remains but is split into a part which
writes to i915 and part which operates on intel_gt in order to initialize
the hardware.
GuC and engines are the only odd ones out
From: Tvrtko Ursulin
And also rename to intel_gt_pm_init_early and make it operate on gt.
Signed-off-by: Tvrtko Ursulin
Suggested-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_gt.c | 3 +++
drivers/gpu/drm/i915/gt/intel_gt_pm.c| 6 +++---
From: Tvrtko Ursulin
More removal of implicit dev_priv from using old mmio accessors.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_mocs.c | 52 +---
drivers/gpu/drm/i915/gt/intel_mocs.h | 3 +-
From: Tvrtko Ursulin
We need an easy way to get back to i915 and uncore.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_gt.c | 7 ++-
drivers/gpu/drm/i915/gt/intel_gt.h | 4 +++-
From: Tvrtko Ursulin
Having made start to better code compartmentalization by introducing
struct intel_gt, continue the theme elsewhere in code by making functions
take parameters take what logically makes most sense for them instead of
the global struct drm_i915_private.
Signed-off-by: Tvrtko
From: Tvrtko Ursulin
More removal of implicit dev_priv from using old mmio accessors.
Furthermore these calls really operate on ggtt so it logically makes sense
if they take it as parameter.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 4
From: Tvrtko Ursulin
Start using the newly introduced struct intel_gt to fuse together correct
logical init flow with uncore for more removal of implicit dev_priv in
mmio access.
v2:
* Move code to i915_gem_fence_reg. (Chris)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Rodrigo Vivi
---
From: Tvrtko Ursulin
More conversion of i915_gem_init_hw to uncore.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 +-
drivers/gpu/drm/i915/gt/intel_workarounds.h | 6 +++---
drivers/gpu/drm/i915/i915_gem.c |
From: Tvrtko Ursulin
Continuing the conversion and elimination of implicit dev_priv.
Signed-off-by: Tvrtko Ursulin
Suggested-by: Rodrigo Vivi
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 4 +-
drivers/gpu/drm/i915/gt/intel_gt.c| 129
From: Tvrtko Ursulin
It will come useful in the next patch.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c| 1 +
drivers/gpu/drm/i915/gt/intel_engine_types.h | 2 ++
2 files changed, 3 insertions(+)
diff --git
From: Tvrtko Ursulin
More removal of implicit dev_priv from using old mmio accessors.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 42 ++---
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git
From: Tvrtko Ursulin
We have long been slighlty annoyed by the anonymous i915->gt.
Promote it to a separate structure and give it its own header.
This is a first step towards cleaning up the separation between i915 and gt.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
From: Tvrtko Ursulin
Since this part still operates on i915 and not intel_gt, move it to the
common (top-level) function.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 29 ++---
1 file changed, 22 insertions(+), 7
From: Tvrtko Ursulin
Review feedback from v4 only this time.
Tvrtko Ursulin (33):
drm/i915: Convert intel_vgt_(de)balloon to uncore
drm/i915: Introduce struct intel_gt as replacement for anonymous
i915->gt
drm/i915: Move intel_gt initialization to a separate file
drm/i915: Store
Instead of going through the if-else chain every time, let's save the
function in the uncore structure. Note that the new functions are
purposely not used from the reg read/write functions to keep the
inlining there.
While at it, use the new macro to call the old ones to clean the code a
bit.
We'd like to introduce a display uncore with no forcewake domains, so
let's avoid wasting memory and be ready to allocate only what we need.
Even without multiple uncore, we still don't need all the domains on all
gens.
Signed-off-by: Daniele Ceraolo Spurio
---
Let's get rid of it before it proliferates, since with split GT/Display
uncores the container_of won't work anymore.
I've kept the rpm pointer as well to minimize the pointer chasing in the
MMIO accessors.
Signed-off-by: Daniele Ceraolo Spurio
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
With multiple uncore to initialize (GT vs Display), it makes little
sense to have the vgpu_check inside uncore_init(). We also have
a catch-22 scenario where the uncore is required to read the vgpu
capabilities while the vgpu capabilities are required to decide if
we need to initialize forcewake
uncore_sanitize performs no action on the uncore structure and just
calls intel_sanitize_gt_powersave, so we can just call the latter
directly.
Signed-off-by: Daniele Ceraolo Spurio
Reviewed-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.c | 12 ++--
We always call some of the setup/cleanup functions for forcewake, even
if the feature is not actually available. Skipping these operations if
forcewake is not available saves us some operations on older gens and
prepares us for having a forcewake-less display uncore.
The suspend/resume functions
These are preparatory patches for the display/gt uncore split that make
sense even before the split is done. Main goal is to better isolate
forcewake-related actions and to perform some cleanup/simplification of
the code.
Cc: Chris Wilson
Cc: Tvrtko Ursulin
Daniele Ceraolo Spurio (6):
== Series Details ==
Series: drm/i915: Use the correct style for SPDX License Identifier
URL : https://patchwork.freedesktop.org/series/62208/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6287 -> Patchwork_13309
Summary
== Series Details ==
Series: drm/i915/gtt: Serialise both updates to PDE and our shadow (rev2)
URL : https://patchwork.freedesktop.org/series/62203/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/gtt: Serialise both updates to PDE and our
On 2019/06/17, james qian wang (Arm Technology China) wrote:
> On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote:
> > Read the docs, komeda is not an old enough driver for this :-)
> >
> > Signed-off-by: Daniel Vetter
> > Cc: "James (Qian) Wang"
> > Cc: Liviu Dudau
> > ---
> >
On 2019/06/14, Daniel Vetter wrote:
> Split out to make the functional changes stick out more.
>
Since this patch flew-by, as standalone one (intentionally or not) I'd
add, anything vaguely like:
"Core users of DRIVER_PRIME were removed from core with prior patches."
HTH
Emil
On 2019/06/14, Daniel Vetter wrote:
> Drivers must fill out the handle_to_fd and fd_to_handle hooks to
> enable export/import prime functionality already. The additional
> DRIVER_PRIME flag doesn't serve any real purpose, since the overall
> flag doesn't even tell you whether import or export or
On 2019/06/14, Daniel Vetter wrote:
> Yes this is a bit a big patch, but since it's essentially a complete
> rewrite of all the prime docs I didn't see how to better split it up.
>
> Changes:
> - Consistently point to drm_gem_object_funcs as the preferred hooks,
> where applicable.
>
> -
>-Original Message-
>From: De Marchi, Lucas
>Sent: Friday, June 14, 2019 2:37 PM
>To: Srivatsa, Anusha
>Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
>Subject: Re: [PATCH 9/9] drm/i915/dmc: protect against loading wrong firmware
>
>On Fri, Jun 14, 2019 at 12:44:50PM -0700, Anusha
== Series Details ==
Series: Documentation/i915: fix file references after display/ subdir renames
URL : https://patchwork.freedesktop.org/series/62197/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6287 -> Patchwork_13307
== Series Details ==
Series: series starting with [1/6] dma-buf: add dynamic DMA-buf handling v10
URL : https://patchwork.freedesktop.org/series/62204/
State : failure
== Summary ==
Applying: dma-buf: add dynamic DMA-buf handling v10
Applying: drm/ttm: remove the backing store if no placement
== Series Details ==
Series: drm/i915/guc: Reduce verbosity on log overflows
URL : https://patchwork.freedesktop.org/series/62195/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6287 -> Patchwork_13306
Summary
---
1 - 100 of 227 matches
Mail list logo
