== Series Details ==
Series: drm/i915/display/tgl: Do not program clockgating (rev2)
URL : https://patchwork.freedesktop.org/series/70076/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7467_full -> Patchwork_15547_full
== Series Details ==
Series: drm/i915/irq: Refactor gen11 display interrupt handling (rev2)
URL : https://patchwork.freedesktop.org/series/70303/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7467_full -> Patchwork_15546_full
On 2019-11-28 at 16:05:03 +0200, Jani Nikula wrote:
> On Mon, 18 Nov 2019, Anshuman Gupta wrote:
> > Putting down the AUX power domain reference count in
> > edp vdd off async sequence takes too much of time
> > (relative to panel power cycle delay) therefore it make sense
> > to expose the panel
On Fri, Nov 01, 2019 at 07:21:16PM +, Chris Wilson wrote:
> Avoid
>
> drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
>
> simply by inverting the predicate and reversing the ternary.
>
> v2: More the long lines into their own function so there is no confusion
> on
== Series Details ==
Series: series starting with [1/3] drm/i915: Lift i915_vma_pin() out of
intel_renderstate_emit()
URL : https://patchwork.freedesktop.org/series/70315/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7465_full -> Patchwork_15544_full
== Series Details ==
Series: series starting with [1/2] drm/i915/dp: Define each HBR link rate
URL : https://patchwork.freedesktop.org/series/70323/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7467 -> Patchwork_15551
TGL has now a table for RBR and HBR and another table for HBR2 over
combo phys. The HBR2 one has some small changes comparing to the ICL
one, so adding two new tables and adding a function to return TGL
combo phy tables.
BSpec: 49291
Cc: Lucas De Marchi
Cc: Matt Roper
Signed-off-by: José
This is better than keep those values in the code that you always
need to check the DP spec to know what level of HBR it is.
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/display/intel_ddi.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/display: Check the old state to
find port sync slave (rev2)
URL : https://patchwork.freedesktop.org/series/70320/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7467 -> Patchwork_15550
== Series Details ==
Series: drm/i915/gt: Set the PD again for Haswell
URL : https://patchwork.freedesktop.org/series/70321/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7467 -> Patchwork_15549
Summary
---
== Series Details ==
Series: drm/i915/gt: Set the PD again for Haswell
URL : https://patchwork.freedesktop.org/series/70321/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f3e73d979d73 drm/i915/gt: Set the PD again for Haswell
-:22: WARNING:COMMIT_LOG_LONG_LINE: Possible
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/display: Check the old state to
find port sync slave
URL : https://patchwork.freedesktop.org/series/70320/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7467 -> Patchwork_15548
== Series Details ==
Series: drm/i915/gem: Unbind all current vma on changing cache-level (rev2)
URL : https://patchwork.freedesktop.org/series/70182/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7463_full -> Patchwork_15542_full
== Series Details ==
Series: drm/i915/display/tgl: Do not program clockgating (rev2)
URL : https://patchwork.freedesktop.org/series/70076/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7467 -> Patchwork_15547
Summary
== Series Details ==
Series: drm/i915/irq: Refactor gen11 display interrupt handling (rev2)
URL : https://patchwork.freedesktop.org/series/70303/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7467 -> Patchwork_15546
== Series Details ==
Series: Enable second DBuf slice for ICL and TGL (rev4)
URL : https://patchwork.freedesktop.org/series/70059/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7467 -> Patchwork_15545
Summary
---
And Haswell still occasionally forgets it is meant to be using a new
page directory, so repeat ourselves a little louder.
<7> [509.919864] heartbeat rcs0 heartbeat {prio:-2147483645} not ticking
<7> [509.919895] heartbeat Awake? 8
<7> [509.919903] heartbeat Barriers?: no
<7>
If the CRTC is going from enabled to disabled and it is a port sync
slave, it needs to check to the old state to be disabled before the
port sync master.
Cc: Manasi Navare
Cc: Matt Roper
Cc: Maarten Lankhorst
Cc: Ville Syrjälä
Reviewed-by: Ville Syrjälä
Signed-off-by: José Roberto de Souza
Disabling pipe/transcoder clock before power down sink could cause
sink lost signal, causing it to trigger a hotplug to notify source
that link signal was lost.
Cc: Lucas De Marchi
Reviewed-by: Ville Syrjälä
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/display/intel_ddi.c | 2
Moving just to simplify handling as there is no change in behavior.
Cc: Lucas De Marchi
Reviewed-by: Ville Syrjälä
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/display/intel_ddi.c| 14 +++---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 1 -
2 files changed, 7
On Thu, 2019-11-28 at 14:06 +0200, Ville Syrjälä wrote:
> On Thu, Nov 28, 2019 at 01:14:37AM +, Souza, Jose wrote:
> > On Wed, 2019-11-27 at 21:59 +0200, Ville Syrjälä wrote:
> > > On Tue, Nov 26, 2019 at 08:30:31PM +, Souza, Jose wrote:
> > > > On Tue, 2019-11-26 at 22:05 +0200, Ville
== Series Details ==
Series: series starting with [1/3] drm/i915: Lift i915_vma_pin() out of
intel_renderstate_emit()
URL : https://patchwork.freedesktop.org/series/70315/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7465 -> Patchwork_15544
== Series Details ==
Series: drm/i915: add display uncore helpers
URL : https://patchwork.freedesktop.org/series/70298/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7462_full -> Patchwork_15539_full
Summary
---
== Series Details ==
Series: series starting with [1/3] drm/i915: Lift i915_vma_pin() out of
intel_renderstate_emit()
URL : https://patchwork.freedesktop.org/series/70315/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
67a6e5056310 drm/i915: Lift i915_vma_pin() out of
Talked with HW team and this is a left over, driver should not
program clockgating, dekel firmware will be reponsible for any
clockgating programing.
v2:
Added WARN_ON
BSpec issue: 20885
BSpec: 49292
Cc: Lucas De Marchi
Cc: Matt Roper
Cc: Jani Nikula
Reviewed-by: Matt Roper
Signed-off-by:
On Mon, Dec 02, 2019 at 07:51:10PM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/irq: Refactor gen11 display interrupt handling
> URL : https://patchwork.freedesktop.org/series/70303/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7463 ->
On Fri, 2019-11-29 at 05:21 +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/display: Suspend MST topology manager before destroy
> fbdev (rev3)
> URL : https://patchwork.freedesktop.org/series/70081/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from
> -Original Message-
> From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of
> Matt Roper
> Sent: Monday, December 2, 2019 9:16 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: De Marchi, Lucas
> Subject: [Intel-gfx] [PATCH] drm/i915/irq: Refactor gen11 display
It is not acceptable for context pinning to fail with -ENOSPC as we
should always be able to make space in the GGTT. The only reason we may
fail is that other "temporary" context pins are reserving their space
and we need to wait for an available slot.
Closes:
Removing all vma from the VM is best effort -- we only remove all those
ready to be removed, so forgive and VMA that becomes pinned. While
forgiving those that become pinned, also take a second look for any that
became unpinned as we waited.
Signed-off-by: Chris Wilson
---
Once inside a request, inside the timeline->mutex, pinning is verboten.
<4> [896.032829] ==
<4> [896.032831] WARNING: possible circular locking dependency detected
<4> [896.032835] 5.4.0-rc8-CI-Patchwork_15533+ #1 Tainted: G U
<4>
On Fri, 2019-11-29 at 08:22 +, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [CI,1/5] drm/i915/psr: Add bits per
> pixel limitation
> URL : https://patchwork.freedesktop.org/series/70133/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from
On Mon, Dec 02, 2019 at 11:08:35AM +, Chris Wilson wrote:
> Now that we have soft-rc6 in place, we can use that instead of the
> forcewake to disable rc6 while active; preferred by a few
> microbenchmarks.
>
> Signed-off-by: Chris Wilson
Acked-by: Andi Shyti
Thanks,
Andi
== Series Details ==
Series: drm/i915/gem: Unbind all current vma on changing cache-level (rev2)
URL : https://patchwork.freedesktop.org/series/70182/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7463 -> Patchwork_15542
== Series Details ==
Series: Changes for DP 1.4 Compliance test 4.2.2.6
URL : https://patchwork.freedesktop.org/series/70314/
State : failure
== Summary ==
Applying: drm: Add support for DP 1.4 Compliance edid corruption test 4.2.2.6
error: sha1 information is lacking or useless
On Thu, Nov 28, 2019 at 02:12:30PM +0200, Joonas Lahtinen wrote:
Quoting Niranjan Vishwanathapura (2019-11-27 21:23:56)
>We should try to have the uAPI as final as early as possible. The
>change process is harder the later it is done, even for RFC :)
>
>On the same note, I'm inclined to have
Unlike DP 1.2 Compliance test 4.2.2.6, DP 1.4 requires to calculate real
CRC value of the last edid data block, and write it back.
Current edid CRC calculate routine adds the last CRC byte, and check if
non-zero or not. Need to return the actual CRC value when corruption is
detected.
[For CI]
DP 1.4 edid corruption test requires source DUT to write calculated
CRC, not the corrupted CRC from reference sink.
Return the calculated CRC back, and initiate the required sequence.
-v2: Have separate routine for returning real CRC
-v3: Rewrite checksum computation routine to avoid duplicated
-v3: Rename to avoid confusion
Signed-off-by: Jerry (Fangzhi) Zuo
Reviewed-by: Harry Wentland
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 35 +-
1 file changed, 7 insertions(+), 28 deletions(-)
diff --git
== Series Details ==
Series: drm/i915/irq: Refactor gen11 display interrupt handling
URL : https://patchwork.freedesktop.org/series/70303/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7463 -> Patchwork_15541
Summary
On Tue, Nov 26, 2019 at 04:03:21PM +0200, Joonas Lahtinen wrote:
Quoting Niranjana Vishwanathapura (2019-11-22 22:57:21)
Shared Virtual Memory (SVM) allows the programmer to use a single virtual
address space which will be shared between threads executing on CPUs and GPUs.
It abstracts away
== Series Details ==
Series: series starting with [1/2] drm/i915: Specialise i915_active.work lock
classes
URL : https://patchwork.freedesktop.org/series/70301/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7463 -> Patchwork_15540
On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson wrote:
>
> Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > -Wtautological-compare was recently added to -Wall in LLVM, which
> > exposed an if statement in i915 that is always false:
> >
> >
== Series Details ==
Series: series starting with [1/4] drm/i915: Lift i915_vma_pin() out of
intel_renderstate_emit()
URL : https://patchwork.freedesktop.org/series/70296/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7460_full -> Patchwork_15538_full
On Thu, Nov 28, 2019 at 7:22 PM Patchwork
wrote:
>
> == Series Details ==
>
> Series: drm/i915/dsb: fix cmd_buf being wrongly set
> URL : https://patchwork.freedesktop.org/series/70129/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7434_full -> Patchwork_15475_full
>
== Series Details ==
Series: drm/i915: add display uncore helpers
URL : https://patchwork.freedesktop.org/series/70298/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7462 -> Patchwork_15539
Summary
---
**SUCCESS**
Avoid dangerous race handling of destroyed vma by unbinding all vma
instead. Unfortunately, this stops us from trying to be clever and only
doing the minimal change required, so on first use of scanout we may
encounter an annoying stall as it transitions to a new cache level.
Bugzilla:
On Fri, Nov 29, 2019 at 4:24 PM Daniel Vetter wrote:
>
> Oh, another display subsystem? Intriguing ...
>
> Reviewed-by: Daniel Vetter
It is intended for displays that are not intended as the usual/main
display, e.g. very small LCDs :)
Reviewed-by: Miguel Ojeda
Cheers,
Miguel
On 2019-11-29 11:29, Jani Nikula wrote:
Now that the fbops member of struct fb_info is const, we can start
making the ops const as well.
Cc: Miguel Ojeda Sandonis
Cc: Robin van der Gracht
Signed-off-by: Jani Nikula
---
drivers/auxdisplay/cfag12864bfb.c | 2 +-
drivers/auxdisplay/ht16k33.c
> On 27 Nov 2019, at 17:32, Jani Nikula wrote:
>
> Now that the fbops member of struct fb_info is const, we can star making
s/star/start/
> the ops const as well.
>
> Cc: Kirti Wankhede
> Cc: k...@vger.kernel.org
> Signed-off-by: Jani Nikula
> ---
> samples/vfio-mdev/mdpy-fb.c | 2 +-
> 1
On 2019-11-29 21:59, Miguel Ojeda wrote:
On Fri, Nov 29, 2019 at 9:30 PM Daniel Vetter wrote:
Well we do have very small lcd display drivers in drm, and before that
in
fbdev. And you have a fbdev framebuffer driver in there, which looks a
bit
misplaced ...
Afaiui you also have some even
On Fri, Nov 29, 2019 at 9:30 PM Daniel Vetter wrote:
>
> Well we do have very small lcd display drivers in drm, and before that in
> fbdev. And you have a fbdev framebuffer driver in there, which looks a bit
> misplaced ...
>
> Afaiui you also have some even tinier lcd drivers where you don't
Hi Chris,
On Mon, Dec 02, 2019 at 11:08:36AM +, Chris Wilson wrote:
> Quite simply we only need to check for prior corruption on enabling rc6
> on module load and resume, so by hooking into the common entry points.
>
> Signed-off-by: Chris Wilson
makes sense!
Acked-by: Andi Shyti
Quoting Matthew Auld (2019-12-02 17:17:48)
> On Thu, 28 Nov 2019 at 22:42, Chris Wilson wrote:
> >
> > Avoid dangerous race handling of destroyed vma by unbinding all vma
> > instead. Unfortunately, this stops us from trying to be clever and only
> > doing the minimal change required, so on first
== Series Details ==
Series: drm/i915: add display uncore helpers
URL : https://patchwork.freedesktop.org/series/70298/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
aa62137b3200 drm/i915/gvt: use intel uncore functions for forcewake register
access
-:66: ERROR:CODE_INDENT:
On Thu, 28 Nov 2019 at 22:42, Chris Wilson wrote:
>
> Avoid dangerous race handling of destroyed vma by unbinding all vma
> instead. Unfortunately, this stops us from trying to be clever and only
> doing the minimal change required, so on first use of scanout we may
> encounter an annoying stall
Let's move handling and reset for gen11 display IRQs to their own
functions, similar to how we deal with GT interrupts. This will make
the top-level functions a bit easier to read and potentially make things
easier to deal with in the future if new platforms wind up needing
different display
On 02/12/2019 16:25, Chris Wilson wrote:
> Quoting Jani Nikula (2019-12-02 11:36:01)
>> On Mon, 02 Dec 2019, "Peres, Martin" wrote:
>>> On 02/12/2019 12:30, Jani Nikula wrote:
On Mon, 25 Nov 2019, Chris Wilson wrote:
> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o,
On 2019-12-02 at 18:24:56 +0200, Ville Syrjälä wrote:
> On Mon, Dec 02, 2019 at 09:10:08PM +0530, Ramalingam C wrote:
> > On 2019-11-29 at 20:54:34 +0200, Ville Syrjala wrote:
> > > From: Ville Syrjälä
> > >
> > > Migrate away from the legacy encoder->crtc and connector->encoder links
> > > in
As the i915_active.retire() may be running on another CPU as we detect
that the i915_active is idle, we may not wait for the retirement itself.
Wait for the remote callback by waiting for the retirement worker.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112424
Signed-off-by: Chris
Similar to for i915_active.mutex, we require each class of i915_active
to have distinct lockdep chains as some, but by no means all,
i915_active are used within the shrinker and so have much more severe
usage constraints. By using a lockclass local to i915_active_init() all
i915_active workers
== Series Details ==
Series: series starting with [1/4] drm/i915: Lift i915_vma_pin() out of
intel_renderstate_emit()
URL : https://patchwork.freedesktop.org/series/70296/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7460 -> Patchwork_15538
== Series Details ==
Series: series starting with [1/2] drm/i915: Specialise i915_active.work lock
classes
URL : https://patchwork.freedesktop.org/series/70293/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7460 -> Patchwork_15537
On Mon, Dec 02, 2019 at 09:10:08PM +0530, Ramalingam C wrote:
> On 2019-11-29 at 20:54:34 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Migrate away from the legacy encoder->crtc and connector->encoder links
> > in the debugfs display_info code. Other users still remain so can't
On Fri, Nov 29, 2019 at 04:17:45AM +, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [CI,1/3] drm/i915: Handle SDEISR according to
> PCH rather than platform
> URL : https://patchwork.freedesktop.org/series/70130/
> State : failure
>
> == Summary ==
>
> CI Bug
Quoting Jani Nikula (2019-12-02 16:00:50)
> Move away from I915_READ_FW() and I915_WRITE_FW() and switch to using
> intel_uncore_read_fw() and intel_uncore_write_fw(), respectively.
>
> No functional changes.
>
> Cc: Chris Wilson
> Signed-off-by: Jani Nikula
> ---
>
Quoting Jani Nikula (2019-12-02 16:00:49)
> Move away from I915_READ_FW() and I915_WRITE_FW() and switch to using
> intel_uncore_read_fw() and intel_uncore_write_fw(), respectively.
I've a patch to switch gvt over to using gt->uncore, gt->engines etc.
-Chris
Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
switch to using intel_de_read_fw() and intel_de_write_fw(),
respectively.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_pm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
Add convenience helpers for the most common uncore operations with
struct drm_i915_private * as context rather than struct intel_uncore *.
The goal is to replace all instances of I915_READ(),
I915_POSTING_READ(), I915_WRITE(), I915_READ_FW(), and I915_WRITE_FW()
in display/ with these, to finally
Move away from I915_READ_FW() and I915_WRITE_FW() and switch to using
intel_uncore_read_fw() and intel_uncore_write_fw(), respectively.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_csr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
switch to using intel_de_read_fw() and intel_de_write_fw(),
respectively.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_irq.c | 22 --
1 file changed, 12 insertions(+),
We've transitioned all users to either specific intel de uncore
functions or the more generic intel uncore functions. Remove the macros.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 29 -
1 file changed, 29 deletions(-)
diff --git
Actual v1 after the RFC https://patchwork.freedesktop.org/series/68713/
Get rid of I915_READ_FW() and I915_WRITE_FW() as part of this series.
BR,
Jani.
Jani Nikula (10):
drm/i915/gvt: use intel uncore functions for forcewake register access
drm/i915/debugfs: use intel uncore functions for
Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
switch to using intel_de_read_fw() and intel_de_write_fw(),
respectively. Also switch I915_READ() and I915_WRITE() over in this file
while at it.
No functional changes.
Signed-off-by: Jani Nikula
---
Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
switch to using intel_de_read_fw() and intel_de_write_fw(),
respectively.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 79 +++-
1 file changed, 42
Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
switch to using intel_de_read_fw() and intel_de_write_fw(),
respectively. Also switch I915_READ() and I915_WRITE() over in this file
while at it.
No functional changes.
Signed-off-by: Jani Nikula
---
Move away from I915_READ_FW() and I915_WRITE_FW() and switch to using
intel_uncore_read_fw() and intel_uncore_write_fw(), respectively.
No functional changes.
Cc: Zhenyu Wang
Cc: Zhi Wang
Cc: intel-gvt-...@lists.freedesktop.org
Signed-off-by: Jani Nikula
---
Move away from I915_READ_FW() and I915_WRITE_FW() and switch to using
intel_uncore_read_fw() and intel_uncore_write_fw(), respectively.
No functional changes.
Cc: Chris Wilson
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_debugfs.c | 14 +-
1 file changed, 9
== Series Details ==
Series: series starting with [1/4] drm/i915: Lift i915_vma_pin() out of
intel_renderstate_emit()
URL : https://patchwork.freedesktop.org/series/70296/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
dca8f4ab5637 drm/i915: Lift i915_vma_pin() out of
HI,
On 02-12-2019 12:53, Jani Nikula wrote:
On Mon, 02 Dec 2019, Linus Walleij wrote:
Hi Hans,
thank you for your patch!
On Fri, Nov 29, 2019 at 7:58 PM Hans de Goede wrote:
- /* GPIO Desc for CRC based Panel control */
+ /* GPIO Desc for panel and backlight control */
On 2019-12-02 at 20:38:23 +0530, Ramalingam C wrote:
> On 2019-11-29 at 20:54:32 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Use the canonicalt "[CRTC:%d:%s]" format for the obj id/name
%s/canonicalt/canonical
> > in the debugfs display_info dump. Everyone should already be
> >
On 2019-11-29 at 20:54:34 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Migrate away from the legacy encoder->crtc and connector->encoder links
> in the debugfs display_info code. Other users still remain so can't kill
> these off yet.
May be I missed why we want to kill encoder->crtc
On Tue, Nov 05, 2019 at 07:14:47PM +0200, Ville Syrjälä wrote:
From: Ville Syrjälä
It's hard to see what is going on when the function mixes drm_
and intel_ types. Switch to intel_ types.
Signed-off-by: Ville Syrjälä
Reviewed-by: Lucas De Marchi
Lucas De Marchi
---
On 2019-11-29 at 20:54:33 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Let's make the display info more useful by dumping both
> the uapi and hw states for each crtc/plane.
Looks good to me.
Reviewed-by: Ramalingam C
>
> Signed-off-by: Ville Syrjälä
> ---
>
On 2019-11-29 at 20:54:32 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use the canonicalt "[CRTC:%d:%s]" format for the obj id/name
> in the debugfs display_info dump. Everyone should already be
> familiar with the format since it's used in the debug logs
> extensively.
Looks good to
On 2019-11-29 at 20:54:31 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Make out life easier by just grabbing all modeset locks around
> the display_info dump.
>
Looks good to me.
Reviewed-by: Ramalingam C
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/i915_debugfs.c |
Quoting Janusz Krzysztofik (2019-12-02 14:42:58)
> Hi Chris,
>
> I have a few questions rather than comments. I hope they are worth spending
> your time.
>
> On Wednesday, November 13, 2019 1:52:40 PM CET Chris Wilson wrote:
> > I915_CONTEXT_PARAM_RINGSIZE specifies how large to create the
On 2019-11-29 at 20:54:30 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> No point in repeating the crtc mode for each cloned encoder.
> Just print it once, and avoid using multiple lines for it.
> And while at let's polish the fixed mode print to fit on
> one line as well.
Looks good to
It is not acceptable for context pinning to fail with -ENOSPC as we
should always be able to make space in the GGTT. The only reason we may
fail is that other "temporary" context pins are reserving their space
and we need to wait for an available slot.
Closes:
Removing all vma from the VM is best effort -- we only remove all those
ready to be removed, so forgive and VMA that becomes pinned. While
forgiving those that become pinned, also take a second look for any that
became unpinned as we waited.
Signed-off-by: Chris Wilson
---
Once inside a request, inside the timeline->mutex, pinning is verboten.
<4> [896.032829] ==
<4> [896.032831] WARNING: possible circular locking dependency detected
<4> [896.032835] 5.4.0-rc8-CI-Patchwork_15533+ #1 Tainted: G U
<4>
As the caller may be keeping the engines awake, even though
wait-for-idle will flush the contexts, the contexts will not be unpinned
until the engine is parked. Manually flush the idle barriers to ensure
that any context that can be unpinned, will be.
Signed-off-by: Chris Wilson
---
Hi Chris,
I have a few questions rather than comments. I hope they are worth spending
your time.
On Wednesday, November 13, 2019 1:52:40 PM CET Chris Wilson wrote:
> I915_CONTEXT_PARAM_RINGSIZE specifies how large to create the command
> ringbuffer for logical ring contects. This directly
On 2019-11-29 at 20:54:29 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Pull the crtc dumping stuff into a nice function so the
> loop over the crtcs doesn't look like crap.
Looks good to me.
Reviewed-by: Ramalingam C
>
> Signed-off-by: Ville Syrjälä
> ---
>
On 2019-11-29 at 20:54:28 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Eliminate the special cases for the primary and cursor planes and just
> dump all the information consistently for all the planes.
>
Lookd good to me.
Reviewed-by: Ramalingam C
> Signed-off-by: Ville Syrjälä
>
Quoting Jani Nikula (2019-12-02 11:36:01)
> On Mon, 02 Dec 2019, "Peres, Martin" wrote:
> > On 02/12/2019 12:30, Jani Nikula wrote:
> >> On Mon, 25 Nov 2019, Chris Wilson wrote:
> >>> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
> >>> update the user instructions
== Series Details ==
Series: series starting with [1/3] drm/i915: Manually flush barriers on
eviction (rev2)
URL : https://patchwork.freedesktop.org/series/70278/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7460_full -> Patchwork_15533_full
== Series Details ==
Series: series starting with [1/2] drm/i915/dp: Take display powerwell before
intel_dp_detect_dpcd
URL : https://patchwork.freedesktop.org/series/70283/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7460 -> Patchwork_15536
As the i915_active.retire() may be running on another CPU as we detect
that the i915_active is idle, we may not wait for the retirement itself.
Wait for the remote callback by waiting for the retirement worker.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112424
Signed-off-by: Chris
Similar to for i915_active.mutex, we require each class of i915_active
to have distinct lockdep chains as some, but by no means all,
i915_active are used within the shrinker and so have much more severe
usage constraints. By using a lockclass local to i915_active_init() all
i915_active workers
1 - 100 of 123 matches
Mail list logo
