Re: [Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-27 Thread Lucas De Marchi
On Fri, Nov 27, 2020 at 02:57:48PM +, Chris Wilson wrote: We now use ilk_hpd_irq_setup for all GMCH platforms that do not have hotplug. These are early gen3 and gen2 devices that now explode on boot as they try to access non-existent registers. humn... true, my bad. But I don't think a

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Disable outputs during unregister

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915: Disable outputs during unregister URL : https://patchwork.freedesktop.org/series/84371/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9401 -> Patchwork_19008 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Differentiate oom failures from invalid map types

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915/gem: Differentiate oom failures from invalid map types URL : https://patchwork.freedesktop.org/series/84365/ State : success == Summary == CI Bug Log - changes from CI_DRM_9401_full -> Patchwork_19006_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly"

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly" URL : https://patchwork.freedesktop.org/series/84368/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9401 -> Patchwork_19007

[Intel-gfx] [PATCH] drm/i915: Disable outputs during unregister

2020-11-27 Thread Chris Wilson
Switch off the scanout during driver unregister, so we can shutdown the HW immediately for unbind. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Differentiate oom failures from invalid map types

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915/gem: Differentiate oom failures from invalid map types URL : https://patchwork.freedesktop.org/series/84365/ State : success == Summary == CI Bug Log - changes from CI_DRM_9401 -> Patchwork_19006

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_capture: Trim the blocking workload

2020-11-27 Thread Chris Wilson
While we want the capture to last long enough to delay the concurrent client, we don't want to wait forever for the capture to complete to proceed with the testing. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2559 Signed-off-by: Chris Wilson --- tests/i915/gem_exec_capture.c | 12

Re: [Intel-gfx] [PATCH] drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly"

2020-11-27 Thread Souza, Jose
On Fri, 2020-11-27 at 21:00 +, Chris Wilson wrote: > We know a problem exists in the ifwi shipped with the early > pre-production Tigerlake and DG1 prototypes, later revisions are fine. > However, CI still relies on the earlier ifwi and we grow tired of > the volume of warnings as we wait for

[Intel-gfx] [PATCH] drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly"

2020-11-27 Thread Chris Wilson
We know a problem exists in the ifwi shipped with the early pre-production Tigerlake and DG1 prototypes, later revisions are fine. However, CI still relies on the earlier ifwi and we grow tired of the volume of warnings as we wait for replacements. Since the warning is a bug, we do not want to

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Record the plane update times for debugging (rev8)

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Record the plane update times for debugging (rev8) URL : https://patchwork.freedesktop.org/series/84174/ State : success == Summary == CI Bug Log - changes from CI_DRM_9399_full -> Patchwork_19004_full

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

2020-11-27 Thread Chris Wilson
Quoting Pandey, Hariom (2020-10-28 11:55:04) > Ok, I have initiated the steps to upgrade the CI machine's silicon & BIOS. The single ehl we have in CI is still failing to enter rc6, both in the selftest and runtime testing. And I note that RAPL doesn't recognise it, so it doesn't report the power

Re: [Intel-gfx] [RFC PATCH 006/162] drm/i915: split gen8+ flush and bb_start emission functions to their own file

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:04:42) > From: Daniele Ceraolo Spurio > > These functions are independent from the backend used and can therefore > be split out of the exelists submission file, so they can be re-used by > the upcoming GuC submission backend. > > Based on a patch by Chris

Re: [Intel-gfx] [RFC PATCH 005/162] drm/i915/gt: Rename lrc.c to execlists_submission.c

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:04:41) > From: Chris Wilson > > We want to separate the utility functions for controlling the logical > ring context from the execlists submission mechanism (which is an > overgrown scheduler). > > This is similar to Daniele's work to split up the files, but

Re: [Intel-gfx] [RFC PATCH 004/162] drm/i915/gt: Move move context layout registers and offsets to lrc_reg.h

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:04:40) > From: Chris Wilson > > Cleanup intel_lrc.h by moving some of the residual common register > definitions into intel_lrc_reg.h, prior to rebranding and splitting off > the submission backends. > > v2: keep the SCHEDULE enum in the old file, since it is

[Intel-gfx] [PATCH] drm/i915/gem: Differentiate oom failures from invalid map types

2020-11-27 Thread Chris Wilson
After a cursory check on the parameters to i915_gem_object_pin_map(), where we return a precise error, if the backend rejects the mapping we always return PTR_ERR(-ENOMEM). Let us also return a more precise error here so we can differentiate between running out of memory and programming errors (or

[Intel-gfx] ✗ Fi.CI.IGT: failure for Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-27 Thread Patchwork
== Series Details == Series: Revert "drm/i915: re-order if/else ladder for hpd_irq_setup" URL : https://patchwork.freedesktop.org/series/84352/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9399_full -> Patchwork_19003_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: remove trailing semicolon in macro definition

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915: remove trailing semicolon in macro definition URL : https://patchwork.freedesktop.org/series/84354/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9399 -> Patchwork_19005 Summary

Re: [Intel-gfx] [RFC PATCH 001/162] drm/i915/selftest: also consider non-contiguous objects

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:04:37) > In igt_ppgtt_sanity_check we should also exercise the non-contiguous > option for LMEM, since this will give us slightly different sg layouts > and alignment. > > Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson -Chris

Re: [Intel-gfx] [PATCH] drm/i915: remove trailing semicolon in macro definition

2020-11-27 Thread Chris Wilson
Quoting t...@redhat.com (2020-11-27 16:28:28) > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > --- > drivers/gpu/drm/i915/intel_device_info.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [RFC PATCH 092/162] drm/i915/uapi: introduce drm_i915_gem_create_ext

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:08) > +int > +i915_gem_create_ioctl(struct drm_device *dev, void *data, > + struct drm_file *file) > +{ > + struct drm_i915_private *i915 = to_i915(dev); > + struct create_ext ext_data = { .i915 = i915 }; > + struct

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: remove trailing semicolon in macro definition

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915: remove trailing semicolon in macro definition URL : https://patchwork.freedesktop.org/series/84354/ State : warning == Summary == $ dim checkpatch origin/drm-tip ba9e1a69788c drm/i915: remove trailing semicolon in macro definition -:19:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Record the plane update times for debugging (rev8)

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Record the plane update times for debugging (rev8) URL : https://patchwork.freedesktop.org/series/84174/ State : success == Summary == CI Bug Log - changes from CI_DRM_9399 -> Patchwork_19004

[Intel-gfx] ✓ Fi.CI.IGT: success for Enable HDR on MCA LSPCON based Gen9 devices (rev14)

2020-11-27 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev14) URL : https://patchwork.freedesktop.org/series/68081/ State : success == Summary == CI Bug Log - changes from CI_DRM_9399_full -> Patchwork_19001_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-27 Thread Patchwork
== Series Details == Series: Revert "drm/i915: re-order if/else ladder for hpd_irq_setup" URL : https://patchwork.freedesktop.org/series/84352/ State : success == Summary == CI Bug Log - changes from CI_DRM_9399 -> Patchwork_19003 Summary

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-11-27 Thread Imre Deak
On Fri, Nov 27, 2020 at 04:19:20PM +0100, Daniel Vetter wrote: > On Fri, Nov 27, 2020 at 04:31:00PM +0200, Imre Deak wrote: > > Hi Daniel, Jani, > > > > is it ok to merge this patch along with 2/2 via the i915 tree? > > Ack from mesa (userspace in general, but mesa is kinda mandatory) is >

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/4] drm/i915/display/psr: Calculate selective fetch plane registers

2020-11-27 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm/i915/display/psr: Calculate selective fetch plane registers URL : https://patchwork.freedesktop.org/series/84350/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9399 -> Patchwork_19002

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] drm/i915/gt: Replace direct submit with direct call to tasklet

2020-11-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Replace direct submit with direct call to tasklet URL : https://patchwork.freedesktop.org/series/84345/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9398_full -> Patchwork_19000_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v3,1/4] drm/i915/display/psr: Calculate selective fetch plane registers

2020-11-27 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm/i915/display/psr: Calculate selective fetch plane registers URL : https://patchwork.freedesktop.org/series/84350/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable HDR on MCA LSPCON based Gen9 devices (rev14)

2020-11-27 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev14) URL : https://patchwork.freedesktop.org/series/68081/ State : success == Summary == CI Bug Log - changes from CI_DRM_9399 -> Patchwork_19001 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable HDR on MCA LSPCON based Gen9 devices (rev14)

2020-11-27 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev14) URL : https://patchwork.freedesktop.org/series/68081/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable HDR on MCA LSPCON based Gen9 devices (rev14)

2020-11-27 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev14) URL : https://patchwork.freedesktop.org/series/68081/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7f90737a12fb drm/i915/display: Add HDR Capability detection for LSPCON a44d7eb6654e

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Record the plane update times for debugging (rev7)

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Record the plane update times for debugging (rev7) URL : https://patchwork.freedesktop.org/series/84174/ State : success == Summary == CI Bug Log - changes from CI_DRM_9398_full -> Patchwork_18998_full

[Intel-gfx] [PATCH] drm/i915: remove trailing semicolon in macro definition

2020-11-27 Thread trix
From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- drivers/gpu/drm/i915/intel_device_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c index

[Intel-gfx] [PATCH v2] drm/i915/display: Record the plane update times for debugging

2020-11-27 Thread Chris Wilson
Since we try and estimate how long we require to update the registers to perform a plane update, it is of vital importance that we measure the distribution of plane updates to better guide our estimate. If we underestimate how long it takes to perform the plane update, we may slip into the next

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/gt: Replace direct submit with direct call to tasklet

2020-11-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Replace direct submit with direct call to tasklet URL : https://patchwork.freedesktop.org/series/84345/ State : success == Summary == CI Bug Log - changes from CI_DRM_9398 -> Patchwork_19000

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] drm/i915/gt: Replace direct submit with direct call to tasklet

2020-11-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Replace direct submit with direct call to tasklet URL : https://patchwork.freedesktop.org/series/84345/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit

[Intel-gfx] ✗ Fi.CI.BAT: failure for DG1 + LMEM enabling

2020-11-27 Thread Patchwork
== Series Details == Series: DG1 + LMEM enabling URL : https://patchwork.freedesktop.org/series/84344/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9398 -> Patchwork_18999 Summary --- **FAILURE** Serious unknown

Re: [Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-27 Thread Jani Nikula
On Fri, 27 Nov 2020, Chris Wilson wrote: > We now use ilk_hpd_irq_setup for all GMCH platforms that do not have > hotplug. These are early gen3 and gen2 devices that now explode on boot > as they try to access non-existent registers. > > Fixes: 794d61a19090 ("drm/i915: re-order if/else ladder for

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-11-27 Thread Daniel Vetter
On Fri, Nov 27, 2020 at 04:31:00PM +0200, Imre Deak wrote: > Hi Daniel, Jani, > > is it ok to merge this patch along with 2/2 via the i915 tree? Ack from mesa (userspace in general, but mesa is kinda mandatory) is missing I think. With that Acked-by: Daniel Vetter > > --Imre > > On Mon, Nov

[Intel-gfx] ✗ Fi.CI.DOCS: warning for DG1 + LMEM enabling

2020-11-27 Thread Patchwork
== Series Details == Series: DG1 + LMEM enabling URL : https://patchwork.freedesktop.org/series/84344/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DG1 + LMEM enabling

2020-11-27 Thread Patchwork
== Series Details == Series: DG1 + LMEM enabling URL : https://patchwork.freedesktop.org/series/84344/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-27 Thread Chris Wilson
We now use ilk_hpd_irq_setup for all GMCH platforms that do not have hotplug. These are early gen3 and gen2 devices that now explode on boot as they try to access non-existent registers. Fixes: 794d61a19090 ("drm/i915: re-order if/else ladder for hpd_irq_setup") Signed-off-by: Chris Wilson Cc:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DG1 + LMEM enabling

2020-11-27 Thread Patchwork
== Series Details == Series: DG1 + LMEM enabling URL : https://patchwork.freedesktop.org/series/84344/ State : warning == Summary == $ dim checkpatch origin/drm-tip ecc99f864651 drm/i915/selftest: also consider non-contiguous objects 3c1e72a3ebbe drm/i915/selftest: assert we get 2M GTT pages

Re: [Intel-gfx] [v12 11/15] drm/i915/lspcon: Create separate infoframe_enabled helper

2020-11-27 Thread Ville Syrjälä
On Fri, Nov 27, 2020 at 02:33:10AM +0530, Uma Shankar wrote: > Lspcon has Infoframes as well as DIP for HDR metadata(DRM Infoframe). > Create a separate mechanism for lspcon compared to HDMI in order to > address the same and ensure future scalability. > > v2: Streamlined this as per Ville's

Re: [Intel-gfx] [v12 14/15] drm/i915/lspcon: Do not send DRM infoframes to non-HDMI sinks

2020-11-27 Thread Ville Syrjälä
On Fri, Nov 27, 2020 at 02:33:13AM +0530, Uma Shankar wrote: > Non-HDMI sinks shouldn't be sent Dynamic Range and Mastering infoframes. > Check for that when using LSPCON. > > Signed-off-by: Uma Shankar > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 10 +- > 1 file changed, 9

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Record the plane update times for debugging (rev7)

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Record the plane update times for debugging (rev7) URL : https://patchwork.freedesktop.org/series/84174/ State : success == Summary == CI Bug Log - changes from CI_DRM_9398 -> Patchwork_18998

Re: [Intel-gfx] [v3 1/2] drm/i915/display/tgl: Disable FBC with PSR2

2020-11-27 Thread Ville Syrjälä
On Wed, Nov 25, 2020 at 05:52:10PM +, Souza, Jose wrote: > On Wed, 2020-11-25 at 18:17 +0200, Ville Syrjälä wrote: > > On Tue, Nov 24, 2020 at 10:03:35PM +, Souza, Jose wrote: > > > On Fri, 2020-11-20 at 01:06 +0530, Uma Shankar wrote: > > > > There are some corner cases wrt underrun when

Re: [Intel-gfx] [RFC PATCH 160/162] drm/i915/dg1: Fix GPU hang due to shmemfs page drop

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:16) > From: Venkata Ramana Nayana > > This is to fix a bug in upstream > commit a6326a4f8ffb ("drm/i915/gt: Keep a no-frills swappable copy of the > default context state") > > We allocate context state obj ce->state from lmem, so in >

Re: [Intel-gfx] [RFC PATCH 157/162] drm/i915: Improve accuracy of eviction stats

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:13) > From: Tvrtko Ursulin > > Current code uses jiffie time to do the accounting and then does: > > diff = jiffies - start; > msec = diff * 1000 / HZ; > ... > atomic_long_add(msec, >time_swap_out_ms); > > If we assume jiffie can be as

Re: [Intel-gfx] [RFC PATCH 150/162] drm/i915: need consider system BO snoop for dgfx

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:06) > From: CQ Tang > > When cache_level is NONE, we check HAS_LLC(i915). > But additionally for DGFX, we also need to check > HAS_SNOOP(i915) on system memory object to use > I915_BO_CACHE_COHERENT_FOR_READ. on dg1, has_llc=0, and > has_snoop=1. Otherwise,

[Intel-gfx] [PATCH v3 3/4] drm/i915/display/psr: Program plane's calculated offset to plane SF register

2020-11-27 Thread José Roberto de Souza
It programs Plane's calculated x, y, offset to Plane SF register. It does the calculation of x and y offsets using skl_calc_main_surface_offset(). v3: Update commit message Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza Reviewed-by: Gwan-gyeong Mun Tested-by:

[Intel-gfx] [PATCH v3 4/4] HAX/DO_NOT_MERGE_IT: drm/i915/display: Enable PSR2 selective fetch for testing

2020-11-27 Thread José Roberto de Souza
Enabling it to check if it causes regressions in CI but the feature is still not ready to be enabled by default. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h

[Intel-gfx] [PATCH v3 2/4] drm/i915/display: Split and export main surface calculation from skl_check_main_surface()

2020-11-27 Thread José Roberto de Souza
The calculation the offsets of the main surface will be needed by PSR2 selective fetch code so here splitting and exporting it. No functional changes were done here. v3: Rebased Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza Reviewed-by: Gwan-gyeong Mun Tested-by:

[Intel-gfx] [PATCH v3 1/4] drm/i915/display/psr: Calculate selective fetch plane registers

2020-11-27 Thread José Roberto de Souza
Add the calculations to set plane selective fetch registers depending in the value of the area damaged. It is still using the whole plane area as damaged but that will change in next patches. v2: - fixed new_plane_state->uapi.dst.y2 typo in intel_psr2_sel_fetch_update() - do not shifthing

Re: [Intel-gfx] [RFC PATCH 148/162] drm/i915: suspend/resume enable blitter eviction

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:04) > From: Venkata Ramana Nayana > > In suspend mode use blitter eviction before disable the runtime > interrupts and in resume use blitter after the gem resume happens. Consider add it to the suspend prepare function. -Chris

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-11-27 Thread Imre Deak
Hi Daniel, Jani, is it ok to merge this patch along with 2/2 via the i915 tree? --Imre On Mon, Nov 23, 2020 at 08:26:30PM +0200, Imre Deak wrote: > From: Radhakrishna Sripada > > Gen12 display can decompress surfaces compressed by render engine with > Clear Color, add a new modifier as the

Re: [Intel-gfx] [RFC PATCH 147/162] drm/i915/gt: Allocate default ctx objects in SMEM

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:03) > From: Venkata Ramana Nayana > > If record default objects are created in LMEM and in suspend > pin the pages of obj (src) and use blitter for eviction. But > during request creation using blitter context and try to pin the same > default object, to

Re: [Intel-gfx] [RFC PATCH 146/162] drm/i915/pm: suspend and restore ppgtt mapping

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:02) > From: Prathap Kumar Valsan > > During suspend we will lose all page tables as they are allocated in > LMEM. In-order to make sure that the contexts do not access the > corrupted page table after we restore, we are evicting all vma's that > are bound

Re: [Intel-gfx] [RFC PATCH 144/162] drm/i915: Reset blitter context when unpark engine

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:00) > From: Venkata Ramana Nayana > > We are only doing it now for kernel_context. We also need to do for the > copy engine blitter context. > > Signed-off-by: Venkata Ramana Nayana > --- > drivers/gpu/drm/i915/gt/intel_engine_pm.c | 5 + > 1 file

Re: [Intel-gfx] [RFC PATCH 143/162] drm/i915: suspend/resume eviction

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:59) > +static int intel_dmem_evict_buffers(struct drm_device *dev, bool in_suspend) > +{ > + struct drm_i915_private *i915 = to_i915(dev); > + struct drm_i915_gem_object *obj; > + struct intel_memory_region *mem; > + int id, ret = 0; >

Re: [Intel-gfx] [RFC PATCH 141/162] drm/i915: Lmem eviction statistics by category

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:57) > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 82f431cc38cd..6f0ab363bdee 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1225,6 +1225,11 @@ struct drm_i915_private { >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Record the plane update times for debugging (rev7)

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Record the plane update times for debugging (rev7) URL : https://patchwork.freedesktop.org/series/84174/ State : warning == Summary == $ dim checkpatch origin/drm-tip 36f4f615f69a drm/i915/display: Record the plane update times for debugging

Re: [Intel-gfx] [RFC PATCH 140/162] drm/i915: window_blt_copy is used for swapin and swapout

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:56) > From: Ramalingam C > > window_blt_copy feature is used for swapin and swapout based on the i915 > module parameter called enable_eviction. A module parameter? -Chris ___ Intel-gfx mailing list

Re: [Intel-gfx] [RFC PATCH 137/162] drm/i915: blt copy between objs using pre-created vma windows

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:53) > +int i915_window_blt_copy(struct drm_i915_gem_object *dst, > +struct drm_i915_gem_object *src) > +{ > + struct drm_i915_private *i915 = to_i915(src->base.dev); > + struct intel_context *ce =

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/5] drm/i915/display/psr: Calculate selective fetch plane registers

2020-11-27 Thread Patchwork
== Series Details == Series: series starting with [v3,1/5] drm/i915/display/psr: Calculate selective fetch plane registers URL : https://patchwork.freedesktop.org/series/84340/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9398 -> Patchwork_18997

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Declare gen9 has 64 mocs entries!

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915/gt: Declare gen9 has 64 mocs entries! URL : https://patchwork.freedesktop.org/series/84339/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9397_full -> Patchwork_18996_full Summary

Re: [Intel-gfx] [RFC PATCH 134/162] drm/i915/dg1: Measure swap in/out timing stats

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:50) > From: Sudeep Dutt > > Signed-off-by: Sudeep Dutt > --- > drivers/gpu/drm/i915/gem/i915_gem_region.c | 16 ++-- > drivers/gpu/drm/i915/i915_debugfs.c| 3 +++ > drivers/gpu/drm/i915/i915_drv.h| 2 ++ > 3 files

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/display: Split and export main surface calculation from skl_check_main_surface()

2020-11-27 Thread Souza, Jose
On Fri, 2020-11-27 at 12:50 +0200, Gwan-gyeong Mun wrote: > From: José Roberto de Souza > > The calculation the offsets of the main surface will be needed by PSR2 > selective fetch code so here splitting and exporting it. > No functional changes were done here. > > v3: Rebased > > Cc:

Re: [Intel-gfx] [RFC PATCH 133/162] drm/i915/dg1: Track swap in/out stats via debugfs

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:49) > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 1366b53ac8c9..7b1e95d494e6 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1214,6 +1214,9 @@ struct drm_i915_private { >

Re: [Intel-gfx] [RFC PATCH 128/162] drm/i915/dg1: intel_memory_region_evict() changes for eviction

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:44) > From: CQ Tang > > Function i915_gem_shrink_memory_region() is changed to > intel_memory_region_evict() and moved from i915_gem_shrinker.c > to intel_memory_region.c, this function is used to handle local > memory swapping, in addition to evict

Re: [Intel-gfx] [RFC PATCH 126/162] drm/i915/gem: Update shmem available memory

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:42) > From: Bommu Krishnaiah > > Update shmem available memory in “intel_memory_region” Was avail ever set? -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [v12 08/15] drm/i915/display: Enable colorspace programming for LSPCON devices

2020-11-27 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjälä > Sent: Friday, November 27, 2020 7:15 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [v12 08/15] drm/i915/display: Enable colorspace programming for > LSPCON devices > > On Fri, Nov 27, 2020 at 02:33:07AM +0530,

Re: [Intel-gfx] [RFC PATCH 125/162] drm/i915/lmem: Limit block size to 4G

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:41) > From: Venkata Sandeep Dhanalakota > > when allocating pages to lmem object of size 4G or greater > we allocate memory blocks from buddy system. Any lmem object is from the buddy system. > In this scenario > buddy sytem can allocate blocks that can

Re: [Intel-gfx] [RFC PATCH 124/162] drm/i915/lmem: allocate HWSP in lmem

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:40) > From: Michel Thierry Rationale goes here. Is this wise? HWSP is very frequently read by the CPU, and expected to be cached on the CPU. What do the performance profiles indicate? -Chris ___ Intel-gfx

[Intel-gfx] [v13 08/15] drm/i915/display: Enable colorspace programming for LSPCON devices

2020-11-27 Thread Uma Shankar
Enable HDMI Colorspace for LSPCON based devices. Sending Colorimetry data for HDR using AVI infoframe. LSPCON firmware expects this and though SOC drives DP, for HDMI panel AVI infoframe is sent to the LSPCON device which transfers the same to HDMI sink. v2: Dropped state managed in drm core as

[Intel-gfx] [v13 06/15] drm/i915/display: Attach content type property for LSPCON

2020-11-27 Thread Uma Shankar
Content type is supported on HDMI sink devices. Attached the property for the same for LSPCON based devices. v2: Added the content type programming when we are attaching the property to connector, as suggested by Ville. v3: Need to attach content type on intel_dp_add_properties as creating of

Re: [Intel-gfx] [RFC PATCH 118/162] drm/i915/dg1: Reserve first 1MB of local memory

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:34) > From: Imre Deak > > On DG1 A0/B0 steppings the first 1MB of local memory must be reserved. > One reason for this is that the 0xA-0xB range is not accessible > by the display, probably since this region is redirected to another > memory

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v3,1/5] drm/i915/display/psr: Calculate selective fetch plane registers

2020-11-27 Thread Patchwork
== Series Details == Series: series starting with [v3,1/5] drm/i915/display/psr: Calculate selective fetch plane registers URL : https://patchwork.freedesktop.org/series/84340/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/5] drm/i915/display/psr: Calculate selective fetch plane registers

2020-11-27 Thread Patchwork
== Series Details == Series: series starting with [v3,1/5] drm/i915/display/psr: Calculate selective fetch plane registers URL : https://patchwork.freedesktop.org/series/84340/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0519f1c556bc drm/i915/display/psr: Calculate

Re: [Intel-gfx] [PATCH 07/15] drm/i915: Remove references to struct drm_device.pdev

2020-11-27 Thread Thomas Zimmermann
Hi Am 27.11.20 um 14:20 schrieb Joonas Lahtinen: Quoting Thomas Zimmermann (2020-11-24 13:38:16) Using struct drm_device.pdev is deprecated. Convert i915 to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi

Re: [Intel-gfx] [v12 08/15] drm/i915/display: Enable colorspace programming for LSPCON devices

2020-11-27 Thread Ville Syrjälä
On Fri, Nov 27, 2020 at 02:33:07AM +0530, Uma Shankar wrote: > Enable HDMI Colorspace for LSPCON based devices. Sending Colorimetry > data for HDR using AVI infoframe. LSPCON firmware expects this and though > SOC drives DP, for HDMI panel AVI infoframe is sent to the LSPCON device > which

Re: [Intel-gfx] [RFC PATCH 103/162] drm/i915: allocate context from LMEM

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:19) > Based on a patch from Michel Thierry. > > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Abdiel Janulgue > --- > .../drm/i915/gt/intel_execlists_submission.c | 31 ++- > 1 file changed, 30 insertions(+), 1 deletion(-) > >

Re: [Intel-gfx] [RFC PATCH 101/162] drm/i915/gtt/dg1: add PTE_LM plumbing for PPGTT

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:17) > For the PTEs we get an LM bit, to signal whether the page resides in > SMEM or LMEM. > > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Abdiel Janulgue > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Niranjana Vishwanathapura >

Re: [Intel-gfx] [RFC PATCH 098/162] drm/i915/gtt: map the PD up front

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:14) > We need to general our accessor for the page directories and tables from > using the simple kmap_atomic to support local memory, and this setup > must be done on acquisition of the backing storage prior to entering > fence execution contexts. Here we

Re: [Intel-gfx] [RFC PATCH 097/162] drm/i915: Distinction of memory regions

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:13) > From: Zbigniew Kempczyński > > IGTs should be able to choose testing strategy depending on memory > regions and its sizes. Add region instance number to make this > easier and descriptive. > > Cc: Matthew Auld > Cc: Ramalingam C > Cc: Tvrtko

Re: [Intel-gfx] [RFC PATCH 093/162] drm/i915/lmem: allocate cmd ring in lmem

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:09) > From: Michel Thierry > > Signed-off-by: Michel Thierry > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Abdiel Janulgue > --- > drivers/gpu/drm/i915/gt/intel_ring.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-)

[Intel-gfx] [PULL] drm-intel-next-queued

2020-11-27 Thread Jani Nikula
Hi Dave & Daniel - Last feature pull for v5.11. drm-intel-next-queued-2020-11-27: drm/i915 features for v5.11: Highlights: - Enable big joiner to join two pipes to one port to overcome pipe restrictions (Manasi, Ville, Maarten) Display: - More DG1 enabling (Lucas, Aditya) - Fixes to cases

Re: [Intel-gfx] [PULL] gvt-next

2020-11-27 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2020-11-24 05:13:59) > On 2020.11.23 11:32:38 +0200, Joonas Lahtinen wrote: > > Quoting Zhenyu Wang (2020-11-23 11:05:17) > > > > > > Hi, > > > > > > Here's gvt next pull for v5.11. Mostly it's for host suspend/resume > > > fix with vGPU active and with some other

Re: [Intel-gfx] [RFC PATCH 092/162] drm/i915/uapi: introduce drm_i915_gem_create_ext

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:08) > Same old gem_create but with now with extensions support. This is needed > to support various upcoming usecases. For now we use the extensions > mechanism to support setting an immutable-priority-list of potential > placements, at creation time. > > If

Re: [Intel-gfx] [PATCH 07/15] drm/i915: Remove references to struct drm_device.pdev

2020-11-27 Thread Joonas Lahtinen
Quoting Thomas Zimmermann (2020-11-24 13:38:16) > Using struct drm_device.pdev is deprecated. Convert i915 to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi Any chance of sharing used a cocci

Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression

2020-11-27 Thread Chris Wilson
Quoting Xing Zhengjun (2020-11-27 01:51:41) > > > On 11/27/2020 5:34 AM, Chris Wilson wrote: > > Quoting Xing Zhengjun (2020-11-26 01:44:55) > >> > >> > >> On 11/25/2020 4:47 AM, Chris Wilson wrote: > >>> Quoting Oliver Sang (2020-11-19 07:20:18) > On Fri, Nov 13, 2020 at 04:27:13PM +0200,

Re: [Intel-gfx] [PATCH 03/17] drivers/gpu: Convert to mem*_page()

2020-11-27 Thread Joonas Lahtinen
+ intel-gfx mailing list Quoting ira.we...@intel.com (2020-11-24 08:07:41) > From: Ira Weiny > > The pattern of kmap/mem*/kunmap is repeated. Use the new mem*_page() > calls instead. > > Cc: Patrik Jakobsson > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Signed-off-by: Ira

[Intel-gfx] [CI 2/2] drm/i915/gt: ce->inflight updates are now serialised

2020-11-27 Thread Chris Wilson
Since schedule-in and schedule-out are now both always under the tasklet bitlock, we can reduce the individual atomic operations to simple instructions and worry less. This notably eliminates the race observed with intel_context_inflight in __engine_unpark(). Closes:

[Intel-gfx] [CI 1/2] drm/i915/gt: Replace direct submit with direct call to tasklet

2020-11-27 Thread Chris Wilson
Rather than having special case code for opportunistically calling process_csb() and performing a direct submit while holding the engine spinlock for submitting the request, simply call the tasklet directly. This allows us to retain the direct submission path, including the CS draining to allow

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Declare gen9 has 64 mocs entries!

2020-11-27 Thread Patchwork
== Series Details == Series: drm/i915/gt: Declare gen9 has 64 mocs entries! URL : https://patchwork.freedesktop.org/series/84339/ State : success == Summary == CI Bug Log - changes from CI_DRM_9397 -> Patchwork_18996 Summary ---

[Intel-gfx] [RFC PATCH 162/162] drm/i915: drop fake lmem

2020-11-27 Thread Matthew Auld
Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_drv.c| 15 drivers/gpu/drm/i915/i915_params.c | 5 -- drivers/gpu/drm/i915/i915_params.h | 1 - drivers/gpu/drm/i915/intel_memory_region.c | 11 +-- drivers/gpu/drm/i915/intel_region_lmem.c | 96

[Intel-gfx] [RFC PATCH 159/162] drm/i915/dg1: Fix mapping type for default state object

2020-11-27 Thread Matthew Auld
From: Venkata Ramana Nayana Use I915_MAP_WC when default state object is allocated on LMEM. Signed-off-by: Venkata Ramana Nayana --- drivers/gpu/drm/i915/gt/shmem_utils.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/shmem_utils.c

[Intel-gfx] [RFC PATCH 158/162] drm/i915: Support ww locks in suspend/resume

2020-11-27 Thread Matthew Auld
From: Venkata Ramana Nayana Add ww locks during suspend/resume. Signed-off-by: Venkata Ramana Nayana --- drivers/gpu/drm/i915/i915_drv.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [RFC PATCH 161/162] drm/i915/dg1: allow pci to auto probe

2020-11-27 Thread Matthew Auld
From: Lucas De Marchi Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index c3d9b36ef651..603976b9a973 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++

[Intel-gfx] [RFC PATCH 160/162] drm/i915/dg1: Fix GPU hang due to shmemfs page drop

2020-11-27 Thread Matthew Auld
From: Venkata Ramana Nayana This is to fix a bug in upstream commit a6326a4f8ffb ("drm/i915/gt: Keep a no-frills swappable copy of the default context state") We allocate context state obj ce->state from lmem, so in __engines_record_defaults(), we call shmem_create_from_object(). Because it

  1   2   3   >