[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake URL : https://patchwork.freedesktop.org/series/88673/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9925_full -> Patchwork_19890_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display/psr: Disable DC3CO when the PSR2 is used.

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915/display/psr: Disable DC3CO when the PSR2 is used. URL : https://patchwork.freedesktop.org/series/88672/ State : success == Summary == CI Bug Log - changes from CI_DRM_9925_full -> Patchwork_19889_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add Wa_14010733141

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915: Add Wa_14010733141 URL : https://patchwork.freedesktop.org/series/88670/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9925_full -> Patchwork_19888_full Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Uninit the DMC FW loader state during shutdown

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915: Uninit the DMC FW loader state during shutdown URL : https://patchwork.freedesktop.org/series/87883/ State : success == Summary == CI Bug Log - changes from CI_DRM_9849_full -> Patchwork_19781_full

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Uninit the DMC FW loader state during shutdown

2021-04-01 Thread Imre Deak
On Thu, Mar 11, 2021 at 05:42:07PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Uninit the DMC FW loader state during shutdown > URL : https://patchwork.freedesktop.org/series/87883/ > State : failure Thanks for the reports testing and review, patch pushed to -din. One

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915: Extract intel_adjusted_rate() (rev2)

2021-04-01 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Extract intel_adjusted_rate() (rev2) URL : https://patchwork.freedesktop.org/series/88592/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9923_full -> Patchwork_19887_full

Re: [Intel-gfx] [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-04-01 Thread Navare, Manasi
On Fri, Mar 26, 2021 at 06:15:22PM +0200, Ville Syrjälä wrote: > On Thu, Mar 25, 2021 at 03:01:29PM -0700, Navare, Manasi wrote: > > On Fri, Mar 19, 2021 at 11:27:59PM +0200, Ville Syrjälä wrote: > > > On Fri, Mar 19, 2021 at 02:26:24PM -0700, Navare, Manasi wrote: > > > > On Fri, Mar 19, 2021 at

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake URL : https://patchwork.freedesktop.org/series/88673/ State : success == Summary == CI Bug Log - changes from CI_DRM_9925 -> Patchwork_19890

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake URL : https://patchwork.freedesktop.org/series/88673/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning:

Re: [Intel-gfx] [PATCH v3 13/16] drm/i915/pxp: User interface for Protected buffer

2021-04-01 Thread Daniele Ceraolo Spurio
On 4/1/2021 5:05 AM, Lionel Landwerlin wrote: On 29/03/2021 01:57, Daniele Ceraolo Spurio wrote: From: Bommu Krishnaiah This api allow user mode to create Protected buffers. Only contexts marked as protected are allowed to operate on protected buffers. We only allow setting the flags at

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake URL : https://patchwork.freedesktop.org/series/88673/ State : warning == Summary == $ dim checkpatch origin/drm-tip 35268f22aac5 drm/i915/display/psr: Configure and Program IO buffer Wake and

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/psr: Disable DC3CO when the PSR2 is used.

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915/display/psr: Disable DC3CO when the PSR2 is used. URL : https://patchwork.freedesktop.org/series/88672/ State : success == Summary == CI Bug Log - changes from CI_DRM_9925 -> Patchwork_19889 Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display/psr: Disable DC3CO when the PSR2 is used.

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915/display/psr: Disable DC3CO when the PSR2 is used. URL : https://patchwork.freedesktop.org/series/88672/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add Wa_14010733141

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915: Add Wa_14010733141 URL : https://patchwork.freedesktop.org/series/88670/ State : success == Summary == CI Bug Log - changes from CI_DRM_9925 -> Patchwork_19888 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Add Wa_14010733141

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915: Add Wa_14010733141 URL : https://patchwork.freedesktop.org/series/88670/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add Wa_14010733141

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915: Add Wa_14010733141 URL : https://patchwork.freedesktop.org/series/88670/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8a3e1ee2de0c drm/i915: Add Wa_14010733141 -:38: WARNING:BAD_SIGN_OFF: Co-developed-by: must be immediately followed by

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Extract intel_adjusted_rate() (rev2)

2021-04-01 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Extract intel_adjusted_rate() (rev2) URL : https://patchwork.freedesktop.org/series/88592/ State : success == Summary == CI Bug Log - changes from CI_DRM_9923 -> Patchwork_19887

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v2,1/2] drm/i915: Extract intel_adjusted_rate() (rev2)

2021-04-01 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Extract intel_adjusted_rate() (rev2) URL : https://patchwork.freedesktop.org/series/88592/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix an uninitialized variable issue

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915: Fix an uninitialized variable issue URL : https://patchwork.freedesktop.org/series/88660/ State : success == Summary == CI Bug Log - changes from CI_DRM_9922_full -> Patchwork_19886_full Summary

Re: [Intel-gfx] [PATCH] drm/i915/display/psr: Disable DC3CO when the PSR2 is used.

2021-04-01 Thread Souza, Jose
On Thu, 2021-04-01 at 20:02 +0300, Gwan-gyeong Mun wrote: > Due to the changed sequence of activating/deactivating DC3CO, disable > DC3CO until the changed dc3co activating/deactivating sequence is applied. Reviewed-by: José Roberto de Souza > > References:

[Intel-gfx] [PATCH] drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake

2021-04-01 Thread Gwan-gyeong Mun
As per b.spec 49274, the IO buffer Wake lines and Fast Wake lines can be calculated based on the following formula. IO buffer wake lines = ROUNDUP(PSR2 IO wake time / total line time in microseconds) Fast wake lines = ROUNDUP(PSR2 aux transaction time / total line time in microseconds) For

[Intel-gfx] [PATCH] drm/i915/display/psr: Disable DC3CO when the PSR2 is used.

2021-04-01 Thread Gwan-gyeong Mun
Due to the changed sequence of activating/deactivating DC3CO, disable DC3CO until the changed dc3co activating/deactivating sequence is applied. References: https://gitlab.freedesktop.org/drm/intel/-/issues/3134 Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/intel_psr.c | 7

[Intel-gfx] [PATCH] drm/i915: Add Wa_14010733141

2021-04-01 Thread Aditya Swarup
The WA requires the following procedure for VDBox SFC reset: If (MFX-SFC usage is 1) { 1.Issue a MFX-SFC forced lock 2.Wait for MFX-SFC forced lock ack 3.Check the MFX-SFC usage bit If (MFX-SFC usage bit is 1) Reset VDBOX and SFC else

[Intel-gfx] [PATCH v2 1/2] drm/i915: Extract intel_adjusted_rate()

2021-04-01 Thread Ville Syrjala
From: Ville Syrjälä Extract a small helper to calculate the downscaling adjusted pixel rate/data rate/etc. v2: Drop the plane visibility check and add a comment explaining why Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- .../gpu/drm/i915/display/intel_atomic_plane.c | 36

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Extract intel_adjusted_rate()

2021-04-01 Thread Ville Syrjälä
On Thu, Apr 01, 2021 at 05:32:20PM +0300, Ville Syrjälä wrote: > On Thu, Apr 01, 2021 at 03:43:37PM +0300, Jani Nikula wrote: > > On Tue, 30 Mar 2021, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Extract a small helper to calculate the downscaling > > > adjusted pixel rate/data

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel_gpu_top: Document how to use JSON output

2021-04-01 Thread Matthew Auld
On Thu, 1 Apr 2021 at 15:58, Tvrtko Ursulin wrote: > > > On 01/04/2021 15:49, Matthew Auld wrote: > > On Wed, 31 Mar 2021 at 10:12, Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Put a note on how to use JSON output into the man page. > >> > >> Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH] drm/i915: Uninit the DMC FW loader state during shutdown

2021-04-01 Thread Ville Syrjälä
On Thu, Mar 11, 2021 at 04:45:29PM +0200, Imre Deak wrote: > We need to wait for the DMC FW loader work to complete during shutdown, > even if it's unlikely to be still pending by that time, fix this. > > This also fixes the wakeref tracking WARN during shutdown about the > leaked reference we

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel_gpu_top: Document how to use JSON output

2021-04-01 Thread Tvrtko Ursulin
On 01/04/2021 15:49, Matthew Auld wrote: On Wed, 31 Mar 2021 at 10:12, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Put a note on how to use JSON output into the man page. Signed-off-by: Tvrtko Ursulin References: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/100 ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix an uninitialized variable issue

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915: Fix an uninitialized variable issue URL : https://patchwork.freedesktop.org/series/88660/ State : success == Summary == CI Bug Log - changes from CI_DRM_9922 -> Patchwork_19886 Summary ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reuse intel_adjusted_rate() for pfit pixel rate adjustment

2021-04-01 Thread Jani Nikula
On Thu, 01 Apr 2021, Ville Syrjälä wrote: > On Thu, Apr 01, 2021 at 03:55:20PM +0300, Jani Nikula wrote: >> On Tue, 30 Mar 2021, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > Replace the hand rolled pfit downscale calculations with >> > intel_adjusted_rate(). >> > >> > Signed-off-by:

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel_gpu_top: Document how to use JSON output

2021-04-01 Thread Matthew Auld
On Wed, 31 Mar 2021 at 10:12, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Put a note on how to use JSON output into the man page. > > Signed-off-by: Tvrtko Ursulin > References: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/100 > --- > man/intel_gpu_top.rst | 5 + > 1

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdmi: convert intel_hdmi_to_dev to intel_hdmi_to_i915

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915/hdmi: convert intel_hdmi_to_dev to intel_hdmi_to_i915 URL : https://patchwork.freedesktop.org/series/88657/ State : success == Summary == CI Bug Log - changes from CI_DRM_9921_full -> Patchwork_19885_full

[Intel-gfx] [RFC PATCH i-g-t 6/6] tests/core_hotunplug: Add 'GEM spin' variants

2021-04-01 Thread Janusz Krzysztofik
Verify if a device with a GEM spin batch job still running on a GPU can be hot-unbound/unplugged cleanly and released. Signed-off-by: Janusz Krzysztofik --- tests/core_hotunplug.c | 124 + 1 file changed, 124 insertions(+) diff --git

[Intel-gfx] [RFC PATCH i-g-t 5/6] tests/core_hotunplug: Add 'PRIME handle' variants

2021-04-01 Thread Janusz Krzysztofik
Even if all device file descriptors are closed on device hotunbind / hotunplug, PRIME exported objects may still exists, referenced by still open dma-buf file descriptors. Add subtests that keep such descriptor open on device hotunbind / hotunplug. Signed-off-by: Janusz Krzysztofik ---

[Intel-gfx] [RFC PATCH i-g-t 4/6] tests/core_hotunplug: Add 'userptr GEM object' variants

2021-04-01 Thread Janusz Krzysztofik
Verify if userptr GM objects are cleaned up equally well as regular GEM objects on device hotunbind / hotunplug. Signed-off-by: Janusz Krzysztofik --- tests/core_hotunplug.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/tests/core_hotunplug.c

[Intel-gfx] [RFC PATCH i-g-t 3/6] tests/core_hotunplug: Add 'GEM object' variants

2021-04-01 Thread Janusz Krzysztofik
GEM objects belonging to user file descriptors still open on device hotunbind / hotunplug may exhibit still more driver issues. Add subtests that implements these scenarios. Signed-off-by: Janusz Krzysztofik --- tests/core_hotunplug.c | 85 ++ 1 file

[Intel-gfx] [RFC PATCH i-g-t 1/6] tests/core_hotunplug: Add 'GEM context' variants

2021-04-01 Thread Janusz Krzysztofik
Verify if an additional context associated with an open device file descriptor is cleaned up correctly on device hotunbind / hotunplug. Signed-off-by: Janusz Krzysztofik --- tests/core_hotunplug.c | 79 ++ 1 file changed, 79 insertions(+) diff --git

[Intel-gfx] [RFC PATCH i-g-t 2/6] tests/core_hotunplug: Add 'GEM address space' variants

2021-04-01 Thread Janusz Krzysztofik
Verify if an additional address space associated with an open device file descriptor is cleaned up correctly on device hotunbind / hotunplug. Signed-off-by: Janusz Krzysztofik --- tests/core_hotunplug.c | 79 ++ 1 file changed, 79 insertions(+) diff

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Extract intel_adjusted_rate()

2021-04-01 Thread Ville Syrjälä
On Thu, Apr 01, 2021 at 03:43:37PM +0300, Jani Nikula wrote: > On Tue, 30 Mar 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Extract a small helper to calculate the downscaling > > adjusted pixel rate/data rate/etc. > > > > Signed-off-by: Ville Syrjälä > > --- > >

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix an uninitialized variable issue

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915: Fix an uninitialized variable issue URL : https://patchwork.freedesktop.org/series/88660/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reuse intel_adjusted_rate() for pfit pixel rate adjustment

2021-04-01 Thread Ville Syrjälä
On Thu, Apr 01, 2021 at 03:55:20PM +0300, Jani Nikula wrote: > On Tue, 30 Mar 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Replace the hand rolled pfit downscale calculations with > > intel_adjusted_rate(). > > > > Signed-off-by: Ville Syrjälä > > --- > >

Re: [Intel-gfx] drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal

2021-04-01 Thread Colin Ian King
Hi, Static analysis with Coverity on Linux-next has detected a potential issue with the following commit: commit 480ae79537b28f30ef6e07b7de69a9ae2599daa7 Author: Maarten Lankhorst Date: Tue Mar 23 16:50:49 2021 +0100 drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal The

Re: [Intel-gfx] [PATCH v2 00/20] drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers

2021-04-01 Thread Jani Nikula
On Fri, 26 Mar 2021, Lyude Paul wrote: > Since it's been asked quite a few times on some of the various DP > related patch series I've submitted to use the new DRM printk helpers, > and it technically wasn't really trivial to do this before due to the > lack of a consistent way to find a

Re: [Intel-gfx] [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux

2021-04-01 Thread Jani Nikula
On Fri, 26 Mar 2021, Lyude Paul wrote: > * The @dev field should be set to a pointer to the device that implements > the > - * AUX channel. > + * AUX channel. As well, the @drm_dev field should be set to the _device > + * that will be using this AUX channel as early as possible. For many >

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] scripts/trace.pl: Remove the tool

2021-04-01 Thread Matthew Auld
On Mon, 22 Mar 2021 at 14:12, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Tool has been broken for a while after changes to tracepoint format an format and? > behaviour. Although I have patches somewhere to mostly fix it, it seems > that it has outlived its usefulness and could be

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel_gpu_top: Do not print client header if no client stats

2021-04-01 Thread Matthew Auld
On Wed, 31 Mar 2021 at 09:57, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Add a check if client stats are present to init_clients() so that the > returned clients data can be null from the start. This prevents the client > stats header to be printed on old kernels. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Split out glk_plane_min_cdclk()

2021-04-01 Thread Jani Nikula
On Tue, 30 Mar 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Split the glk+ stuff into it's own version of the .min_cdclk() > vfunc. > > Signed-off-by: Ville Syrjälä For the series, Reviewed-by: Jani Nikula > --- > .../drm/i915/display/skl_universal_plane.c| 53

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdmi: convert intel_hdmi_to_dev to intel_hdmi_to_i915

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915/hdmi: convert intel_hdmi_to_dev to intel_hdmi_to_i915 URL : https://patchwork.freedesktop.org/series/88657/ State : success == Summary == CI Bug Log - changes from CI_DRM_9921 -> Patchwork_19885

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reuse intel_adjusted_rate() for pfit pixel rate adjustment

2021-04-01 Thread Jani Nikula
On Tue, 30 Mar 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the hand rolled pfit downscale calculations with > intel_adjusted_rate(). > > Signed-off-by: Ville Syrjälä > --- > .../gpu/drm/i915/display/intel_atomic_plane.c | 6 ++--- >

[Intel-gfx] [PATCH][next] drm/i915: Fix an uninitialized variable issue

2021-04-01 Thread Colin King
From: Colin Ian King Currently there is a while loop that contains a handful of continue statements that can skip over the assignment of the variable err. At the end of the loop there is a potiential for err to be unassigned and possibly causing issues when err is checked for a non-zero value.

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/hdmi: convert intel_hdmi_to_dev to intel_hdmi_to_i915

2021-04-01 Thread Patchwork
== Series Details == Series: drm/i915/hdmi: convert intel_hdmi_to_dev to intel_hdmi_to_i915 URL : https://patchwork.freedesktop.org/series/88657/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Extract intel_adjusted_rate()

2021-04-01 Thread Jani Nikula
On Tue, 30 Mar 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Extract a small helper to calculate the downscaling > adjusted pixel rate/data rate/etc. > > Signed-off-by: Ville Syrjälä > --- > .../gpu/drm/i915/display/intel_atomic_plane.c | 27 +-- > 1 file changed, 19

Re: [Intel-gfx] [PATCH v3 00/16] Introduce Intel PXP

2021-04-01 Thread Lionel Landwerlin
On 29/03/2021 01:56, Daniele Ceraolo Spurio wrote: PXP (Protected Xe Path) is an i915 component, available on GEN12+, that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. Lots of minor changes and fixes, but the

Re: [Intel-gfx] [PATCH v3 11/16] drm/i915/pxp: interface for marking contexts as using protected content

2021-04-01 Thread Lionel Landwerlin
On 29/03/2021 01:57, Daniele Ceraolo Spurio wrote: Extra tracking and checks around protected objects, coming in a follow-up patch, will be enabled only for contexts that opt in. Contexts can only be marked as using protected content at creation time and they must be both bannable and not

Re: [Intel-gfx] [PATCH v3 13/16] drm/i915/pxp: User interface for Protected buffer

2021-04-01 Thread Lionel Landwerlin
On 29/03/2021 01:57, Daniele Ceraolo Spurio wrote: From: Bommu Krishnaiah This api allow user mode to create Protected buffers. Only contexts marked as protected are allowed to operate on protected buffers. We only allow setting the flags at creation time. All protected objects that have

Re: [Intel-gfx] [PATCH i-g-t] gem_watchdog: Fix autotools build

2021-04-01 Thread Petri Latvala
On Thu, Apr 01, 2021 at 12:43:16PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Correcting a brain malfunction while typing in Makefile.sources. > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Petri Latvala > --- > tests/Makefile.sources | 2 +- > 1 file changed, 1 insertion(+),

[Intel-gfx] [PATCH] drm/i915/hdmi: convert intel_hdmi_to_dev to intel_hdmi_to_i915

2021-04-01 Thread Jani Nikula
Prefer i915 over drm pointer. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hdmi.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index

[Intel-gfx] [PATCH i-g-t] gem_watchdog: Fix autotools build

2021-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Correcting a brain malfunction while typing in Makefile.sources. Signed-off-by: Tvrtko Ursulin --- tests/Makefile.sources | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.sources b/tests/Makefile.sources index e992285fedc5..194df8e27dd0

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status

2021-04-01 Thread Tvrtko Ursulin
On 01/04/2021 11:24, Tamminen, Eero T wrote: Hi, On Thu, 2021-04-01 at 05:54 -0400, Rodrigo Vivi wrote: On Thu, Apr 01, 2021 at 10:38:11AM +0100, Tvrtko Ursulin wrote: ... I think it is possible to argue both ways. 1) HAS_RC6 means hardware has RC6 so if we view PMU as very low level we

[Intel-gfx] [PULL] drm-misc-next

2021-04-01 Thread Maxime Ripard
Hi Dave, Daniel, It's still a fairly quiet week, but here's what should be our last drm-misc-next PR for 5.13 Maxime drm-misc-next-2021-04-01: drm-misc-next for 5.13: UAPI Changes: Cross-subsystem Changes: Core Changes: - mst: Improve topology logging - edid: Rework and improvements for

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status

2021-04-01 Thread Tamminen, Eero T
Hi, On Thu, 2021-04-01 at 05:54 -0400, Rodrigo Vivi wrote: > On Thu, Apr 01, 2021 at 10:38:11AM +0100, Tvrtko Ursulin wrote: ... > > I think it is possible to argue both ways. > > > > 1) > > HAS_RC6 means hardware has RC6 so if we view PMU as very low level > > we can > > say always export it. >

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status

2021-04-01 Thread Rodrigo Vivi
On Thu, Apr 01, 2021 at 10:38:11AM +0100, Tvrtko Ursulin wrote: > > On 01/04/2021 10:19, Rodrigo Vivi wrote: > > On Wed, Mar 31, 2021 at 11:18:50AM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > RC6 support cannot be simply established by looking at the static device > > >

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status

2021-04-01 Thread Tvrtko Ursulin
On 01/04/2021 10:19, Rodrigo Vivi wrote: On Wed, Mar 31, 2021 at 11:18:50AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin RC6 support cannot be simply established by looking at the static device HAS_RC6() flag. There are cases which disable RC6 at driver load time so use the status of

Re: [Intel-gfx] [PATCH] drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active()

2021-04-01 Thread Rodrigo Vivi
On Tue, Mar 30, 2021 at 06:01:18PM +0300, Imre Deak wrote: > Fix the > > Documentation/gpu/i915:22: /drivers/gpu/drm/i915/intel_runtime_pm.c:423: > WARNING: Inline strong start-string without end-string. > > warning from the htmldocs build. > > Fixes: 9d58aa46291d ("drm/i915: Fix the GT fence

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Do not report 100% RC6 if not supported

2021-04-01 Thread Rodrigo Vivi
On Tue, Mar 30, 2021 at 04:06:37PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > We use GT parked status to estimate RC6 while not in use, however if RC6 > is not supported to start with that does not work very well and produces a > false 100% RC6 readout. oh! I had missed this one...

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status

2021-04-01 Thread Rodrigo Vivi
On Wed, Mar 31, 2021 at 11:18:50AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > RC6 support cannot be simply established by looking at the static device > HAS_RC6() flag. There are cases which disable RC6 at driver load time so > use the status of those check when deciding whether to

[Intel-gfx] [PULL] drm-intel-next

2021-04-01 Thread Jani Nikula
Hi Dave & Daniel - The final drm-intel-next feature pull for v5.13. Or, truthfully, a pull request of refactoring both to clean up and prepare for future. Joonas will still send a drm-intel-gt-next pull request, probably next week due to easter holidays. We'll do backmerges to sync up after

Re: [Intel-gfx] [PATCH V2] drm/i915/display: Disable PSR2 on Gen12/12+

2021-04-01 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Tejas > Upadhyay > Sent: Monday, March 22, 2021 4:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Pandey, Hariom > Subject: [Intel-gfx] [PATCH V2] drm/i915/display: Disable PSR2 on Gen12/12+ > > In light of PSR2 can be enabled