Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Move mdev attribute groups into kvmgt module

2021-04-27 Thread Zhenyu Wang
On 2021.04.27 09:12:35 -0300, Jason Gunthorpe wrote: > On Tue, Apr 27, 2021 at 10:45:06AM +0800, Zhenyu Wang wrote: > > On 2021.04.26 10:39:24 -0300, Jason Gunthorpe wrote: > > > On Mon, Apr 26, 2021 at 05:41:42PM +0800, Zhenyu Wang wrote: > > > > @@ -1667,19 +1773,26 @@ static struct

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add support for querying engine cycles

2021-04-27 Thread Patchwork
== Series Details == Series: Add support for querying engine cycles URL : https://patchwork.freedesktop.org/series/89561/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10019_full -> Patchwork_20009_full Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for Simplify intel_setup_outputs (rev3)

2021-04-27 Thread Patchwork
== Series Details == Series: Simplify intel_setup_outputs (rev3) URL : https://patchwork.freedesktop.org/series/88988/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10019 -> Patchwork_20012 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/drm_mst: Use Extended Base Receiver Capability DPCD space (rev4)

2021-04-27 Thread Patchwork
== Series Details == Series: drm/drm_mst: Use Extended Base Receiver Capability DPCD space (rev4) URL : https://patchwork.freedesktop.org/series/89559/ State : failure == Summary == Applying: drm/drm_mst: Use Extended Base Receiver Capability DPCD space error: sha1 information is lacking or

Re: [Intel-gfx] [PATCH 01/21] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

2021-04-27 Thread Jason Ekstrand
On Tue, Apr 27, 2021 at 4:32 AM Daniel Vetter wrote: > > On Fri, Apr 23, 2021 at 05:31:11PM -0500, Jason Ekstrand wrote: > > This reverts commit 88be76cdafc7 ("drm/i915: Allow userspace to specify > > ringsize on construction"). This API was originally added for OpenCL > > but the

[Intel-gfx] ✓ Fi.CI.IGT: success for Add support for querying engine cycles

2021-04-27 Thread Patchwork
== Series Details == Series: Add support for querying engine cycles URL : https://patchwork.freedesktop.org/series/89560/ State : success == Summary == CI Bug Log - changes from CI_DRM_10018_full -> Patchwork_20008_full Summary ---

[Intel-gfx] [PATCH] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-27 Thread Nikola Cornij
[why] DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is set, Extended Base Receiver Capability DPCD space must be used. Without doing that, the three DPCD values that differ will be wrong, leading to incorrect or limited functionality. MST link rate, for example, could have a

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Remove reference to struct drm_device.pdev (rev2)

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915/gem: Remove reference to struct drm_device.pdev (rev2) URL : https://patchwork.freedesktop.org/series/89545/ State : success == Summary == CI Bug Log - changes from CI_DRM_10018_full -> Patchwork_20006_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for Simplify intel_setup_outputs (rev2)

2021-04-27 Thread Patchwork
== Series Details == Series: Simplify intel_setup_outputs (rev2) URL : https://patchwork.freedesktop.org/series/88988/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10019 -> Patchwork_20011 Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for querying engine cycles

2021-04-27 Thread Patchwork
== Series Details == Series: Add support for querying engine cycles URL : https://patchwork.freedesktop.org/series/89561/ State : success == Summary == CI Bug Log - changes from CI_DRM_10019 -> Patchwork_20009 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/drm_mst: Use Extended Base Receiver Capability DPCD space (rev3)

2021-04-27 Thread Patchwork
== Series Details == Series: drm/drm_mst: Use Extended Base Receiver Capability DPCD space (rev3) URL : https://patchwork.freedesktop.org/series/89559/ State : failure == Summary == Applying: drm/drm_mst: Use Extended Base Receiver Capability DPCD space error: sha1 information is lacking or

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Add support for querying engine cycles

2021-04-27 Thread Patchwork
== Series Details == Series: Add support for querying engine cycles URL : https://patchwork.freedesktop.org/series/89561/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./include/uapi/drm/i915_drm.h:2234: warning: Incorrect use of kernel-doc format: *

[Intel-gfx] [PATCH v2 1/4] drm/i915/display: move vbt check to intel_ddi_init()

2021-04-27 Thread Lucas De Marchi
Since commit 45c0673aac97 ("drm/i915/bios: start using the intel_bios_encoder_data directly") we lookup the devdata for each port in intel_ddi_init() and just return if the port is not present in VBT (or if we didn't create a fake devdata for it if VBT is not available). So in intel_display.c we

[Intel-gfx] [PATCH v2 0/4] Simplify intel_setup_outputs

2021-04-27 Thread Lucas De Marchi
First and second patches should be straightforward. Third patch is a simplification for gen9+ since we are not supposed to check the straps anymore and rely on VBT. Finally last patch may or may not make sense: I'm trying to hide these hacks in intel_bios.c so we have a clean init sequence. Lucas

[Intel-gfx] [PATCH v2 4/4] drm/i915/display: hide workaround for broken vbt in intel_bios.c

2021-04-27 Thread Lucas De Marchi
Instead of poluting the normal code path in intel_display.c, make intel_bios.c handle the brokenness of the VBT. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_bios.c| 15 +++ drivers/gpu/drm/i915/display/intel_display.c | 14 ++ 2 files

[Intel-gfx] [PATCH v2 3/4] drm/i915/display: remove strap checks from gen 9

2021-04-27 Thread Lucas De Marchi
Direction on gen9+ was to stop reading the straps and only rely on the VBT for marking the port presence. This happened while dealing with WaIgnoreDDIAStrap and instead of using it as a WA, it should now be the normal flow. See commit 885d3e5b6f08 ("drm/i915/display: fix comment on skl straps").

[Intel-gfx] [PATCH v2 2/4] drm/i915/display: remove FIXME comment for intended feature

2021-04-27 Thread Lucas De Marchi
Direction on gen >= 9 was to stop using straps and rely on VBT indicating if the port is present or not. Remove FIXME comment since this will never be "fixed". Signed-off-by: Lucas De Marchi Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- 1 file changed, 6

Re: [Intel-gfx] [PATCH v2 00/13] Remove vfio_mdev.c, mdev_parent_ops and more

2021-04-27 Thread Alex Williamson
On Tue, 27 Apr 2021 19:20:26 -0300 Jason Gunthorpe wrote: > On Tue, Apr 27, 2021 at 03:30:42PM -0600, Alex Williamson wrote: > > > It'd be really helpful if you could consistently copy at least one > > list, preferably one monitored by patchwork, for an entire series. The > > kvm list is

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for querying engine cycles

2021-04-27 Thread Patchwork
== Series Details == Series: Add support for querying engine cycles URL : https://patchwork.freedesktop.org/series/89560/ State : success == Summary == CI Bug Log - changes from CI_DRM_10018 -> Patchwork_20008 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Add support for querying engine cycles

2021-04-27 Thread Patchwork
== Series Details == Series: Add support for querying engine cycles URL : https://patchwork.freedesktop.org/series/89560/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./include/uapi/drm/i915_drm.h:2234: warning: Incorrect use of kernel-doc format: *

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-27 Thread Patchwork
== Series Details == Series: drm/drm_mst: Use Extended Base Receiver Capability DPCD space URL : https://patchwork.freedesktop.org/series/89559/ State : success == Summary == CI Bug Log - changes from CI_DRM_10018 -> Patchwork_20007

[Intel-gfx] [PATCH] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-27 Thread Nikola Cornij
[why] DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is set, Extended Base Receiver Capability DPCD space must be used. Without doing that, the three DPCD values that differ will be wrong, leading to incorrect or limited functionality. MST link rate, for example, could have a

[Intel-gfx] [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-27 Thread Umesh Nerlige Ramappa
Perf measurements rely on CPU and engine timestamps to correlate events of interest across these time domains. Current mechanisms get these timestamps separately and the calculated delta between these timestamps lack enough accuracy. To improve the accuracy of these time measurements to within a

[Intel-gfx] [PATCH 0/1] Add support for querying engine cycles

2021-04-27 Thread Umesh Nerlige Ramappa
This is just a refresh of the earlier patch along with cover letter for the IGT testing. The query provides the engine cs cycles counter. v2: Use GRAPHICS_VER() instead of IG_GEN() v3: Add R-b to the patch Signed-off-by: Umesh Nerlige Ramappa Test-with:

[Intel-gfx] [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-27 Thread Umesh Nerlige Ramappa
Perf measurements rely on CPU and engine timestamps to correlate events of interest across these time domains. Current mechanisms get these timestamps separately and the calculated delta between these timestamps lack enough accuracy. To improve the accuracy of these time measurements to within a

[Intel-gfx] [PATCH 0/1] Add support for querying engine cycles

2021-04-27 Thread Umesh Nerlige Ramappa
This is just a refresh of the earlier patch along with cover letter for the IGT testing. The query provides the engine cs cycles counter. v2: Use GRAPHICS_VER() instead of IG_GEN() Signed-off-by: Umesh Nerlige Ramappa Test-with: 20210421172046.65062-1-umesh.nerlige.rama...@intel.com Umesh

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-27 Thread Patchwork
== Series Details == Series: drm/drm_mst: Use Extended Base Receiver Capability DPCD space URL : https://patchwork.freedesktop.org/series/89559/ State : warning == Summary == $ dim checkpatch origin/drm-tip 63120ebc08ec drm/drm_mst: Use Extended Base Receiver Capability DPCD space -:22:

Re: [Intel-gfx] [PATCH] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-27 Thread Cornij, Nikola
[AMD Official Use Only - Internal Distribution Only] Hi, drm/radeon/ part is still WIP (i.e. I doubt it'll work as is), but drm/i915 and drm/nouveau/ should be OK. Would it be possible to test those while I'm figuring out drm/radeon/ settings? I'm pretty sure the follow-up change would affect

Re: [Intel-gfx] [PATCH v2 00/13] Remove vfio_mdev.c, mdev_parent_ops and more

2021-04-27 Thread Alex Williamson
On Mon, 26 Apr 2021 17:00:02 -0300 Jason Gunthorpe wrote: > The mdev bus's core part for managing the lifecycle of devices is mostly > as one would expect for a driver core bus subsystem. > > However instead of having a normal 'struct device_driver' and binding the > actual mdev drivers through

[Intel-gfx] [PATCH] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-27 Thread Nikola Cornij
[why] DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is set, Extended Base Receiver Capability DPCD space must be used. Without doing that, the three DPCD values that differ will be wrong, leading to incorrect or limited functionality. MST link rate, for example, could have a

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: move crtc and dpll declarations where they belong

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915/display: move crtc and dpll declarations where they belong URL : https://patchwork.freedesktop.org/series/89551/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10017_full -> Patchwork_20005_full

Re: [Intel-gfx] [PATCH] drm/i915/hdcp: add intel_dp_hdcp.h and rename init accordingly

2021-04-27 Thread Rodrigo Vivi
On Tue, Apr 27, 2021 at 02:45:20PM +0300, Jani Nikula wrote: > Add separate intel_dp_hdcp.h to go with intel_dp_hdcp.c, and rename the > init function intel_dp_hdcp_init() to follow naming where function > prefix matches the file name. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hdcp: add intel_dp_hdcp.h and rename init accordingly

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: add intel_dp_hdcp.h and rename init accordingly URL : https://patchwork.freedesktop.org/series/89550/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10017_full -> Patchwork_20004_full

Re: [Intel-gfx] [PATCH 2/2] Revert "vfio/gvt: Make DRM_I915_GVT depend on VFIO_MDEV"

2021-04-27 Thread Alex Williamson
On Tue, 27 Apr 2021 13:31:39 +0800 Zhenyu Wang wrote: > On 2021.04.26 14:40:17 -0300, Jason Gunthorpe wrote: > > On Mon, Apr 26, 2021 at 10:55:55AM -0600, Alex Williamson wrote: > > > On Mon, 26 Apr 2021 17:41:43 +0800 > > > Zhenyu Wang wrote: > > > > > > > This reverts commit

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Remove reference to struct drm_device.pdev

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915/gem: Remove reference to struct drm_device.pdev URL : https://patchwork.freedesktop.org/series/89545/ State : success == Summary == CI Bug Log - changes from CI_DRM_10017_full -> Patchwork_20002_full

Re: [Intel-gfx] [PATCH] drm/i915/display: move crtc and dpll declarations where they belong

2021-04-27 Thread Ville Syrjälä
On Tue, Apr 27, 2021 at 03:03:15PM +0300, Jani Nikula wrote: > The definitions are in the crtc and dpll files; move the declarations to > the corresponding headers. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/icl_dsi.c| 1 + >

Re: [Intel-gfx] [PATCH v3 15/16] drm/i915/pxp: black pixels on pxp disabled

2021-04-27 Thread Ville Syrjälä
On Tue, Apr 27, 2021 at 04:15:04PM +0530, Anshuman Gupta wrote: > When protected sufaces has flipped and pxp session is disabled, > display black pixels by using plane color CTM correction. > > v2: > - Display black pixels in aysnc flip too. We can't change any of that with an async flip. > >

Re: [Intel-gfx] [PATCH v3 14/16] drm/i915/pxp: Add plane decryption support

2021-04-27 Thread Ville Syrjälä
On Tue, Apr 27, 2021 at 04:13:11PM +0530, Anshuman Gupta wrote: > Add support to enable/disable PLANE_SURF Decryption Request bit. > It requires only to enable plane decryption support when following > condition met. > 1. PXP session is enabled. > 2. Buffer object is protected. > > v2: > - Used

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Remove reference to struct drm_device.pdev (rev2)

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915/gem: Remove reference to struct drm_device.pdev (rev2) URL : https://patchwork.freedesktop.org/series/89545/ State : success == Summary == CI Bug Log - changes from CI_DRM_10018 -> Patchwork_20006

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Remove reference to struct drm_device.pdev (rev2)

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915/gem: Remove reference to struct drm_device.pdev (rev2) URL : https://patchwork.freedesktop.org/series/89545/ State : warning == Summary == $ dim checkpatch origin/drm-tip 78c7c6f906c5 drm/i915/gem: Remove reference to struct drm_device.pdev -:35:

Re: [Intel-gfx] [PATCH v2] drm/i915/gem: Remove reference to struct drm_device.pdev

2021-04-27 Thread Ruhl, Michael J
>-Original Message- >From: Thomas Zimmermann >Sent: Tuesday, April 27, 2021 1:49 PM >To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo >; airl...@linux.ie; dan...@ffwll.ch; Auld, Matthew >; Ruhl, Michael J >Cc: intel-gfx@lists.freedesktop.org;

[Intel-gfx] [PATCH v2] drm/i915/gem: Remove reference to struct drm_device.pdev

2021-04-27 Thread Thomas Zimmermann
References to struct drm_device.pdev should not be used any longer as the field will be moved into the struct's legacy section. Add a fix for the rsp commit. v2: * fix an error in the commit description (Michael) Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula Fixes:

Re: [Intel-gfx] [PATCH] drm/i915/gem: Remove reference to struct drm_device.pdev

2021-04-27 Thread Thomas Zimmermann
Am 27.04.21 um 16:39 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Thomas Zimmermann Sent: Tuesday, April 27, 2021 7:08 AM To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo ; airl...@linux.ie; dan...@ffwll.ch; Auld, Matthew

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Simplify userptr locking (rev2)

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915: Simplify userptr locking (rev2) URL : https://patchwork.freedesktop.org/series/88974/ State : success == Summary == CI Bug Log - changes from CI_DRM_10016_full -> Patchwork_2_full Summary ---

Re: [Intel-gfx] [PATCH v2 0/9] drm: Add privacy-screen class and connector properties

2021-04-27 Thread Marco Trevisan
Hi, >>> There now is GNOME userspace code using the new properties: >>> https://hackmd.io/@3v1n0/rkyIy3BOw >> >> Thanks for working on this. >> >> Can these patches be submitted as merge requests against the upstream >> projects? It would be nice to get some feedback from the maintainers, >>

Re: [Intel-gfx] [PATCH 000/190] Revertion of all of the umn.edu commits

2021-04-27 Thread Greg Kroah-Hartman
On Wed, Apr 21, 2021 at 07:35:44PM +0200, Daniel Vetter wrote: > On Wed, Apr 21, 2021 at 3:01 PM Greg Kroah-Hartman > wrote: > > > > I have been meaning to do this for a while, but recent events have > > finally forced me to do so. > > > > Commits from @umn.edu addresses have been found to be

[Intel-gfx] PR ADL-P DMC

2021-04-27 Thread Srivatsa, Anusha
Sending PR for ADL-P DMC for CI to pull the changes: The following changes since commit fa0efeff4894e36b9c3964376f2c99fae101d147: linux-firmware: Update firmware file for Intel Bluetooth AX210 (2021-04-26 07:00:56 -0400) are available in the Git repository at:

Re: [Intel-gfx] [PATCH] drm/i915: Stop using crtc->index as the pipe

2021-04-27 Thread Souza, Jose
On Tue, 2021-04-27 at 10:51 +0300, Jani Nikula wrote: > On Tue, 27 Apr 2021, Ville Syrjälä wrote: > > On Tue, Apr 27, 2021 at 12:07:21AM +, Souza, Jose wrote: > > > On Mon, 2021-04-26 at 21:56 +0300, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > > > > > > The pipe crc code slipped

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/8] drm/arm: Don't set allow_fb_modifiers explicitly

2021-04-27 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/arm: Don't set allow_fb_modifiers explicitly URL : https://patchwork.freedesktop.org/series/89531/ State : success == Summary == CI Bug Log - changes from CI_DRM_10015_full -> Patchwork_1_full

Re: [Intel-gfx] [PATCH 2/8] drm/arm/malidp: Always list modifiers

2021-04-27 Thread Liviu Dudau
On Tue, Apr 27, 2021 at 11:20:12AM +0200, Daniel Vetter wrote: > Even when all we support is linear, make that explicit. Otherwise the > uapi is rather confusing. :) > > Cc: sta...@vger.kernel.org > Cc: Pekka Paalanen > Cc: Liviu Dudau > Cc: Brian Starkey > Signed-off-by: Daniel Vetter

Re: [Intel-gfx] [PATCH] drm: i915: fix build when ACPI is disabled and BACKLIGHT=m

2021-04-27 Thread Randy Dunlap
On 4/27/21 1:03 AM, Jani Nikula wrote: > On Mon, 26 Apr 2021, Randy Dunlap wrote: >> When CONFIG_DRM_I915=y, CONFIG_ACPI is not set, and >> CONFIG_BACKLIGHT_CLASS_DEVICE=m, not due to I915 config, >> there are build errors trying to reference backlight_device_{un}register(). >> >> Changing the

Re: [Intel-gfx] [PATCH 1/8] drm/arm: Don't set allow_fb_modifiers explicitly

2021-04-27 Thread Liviu Dudau
On Tue, Apr 27, 2021 at 11:20:11AM +0200, Daniel Vetter wrote: > Since > > commit 890880ddfdbe256083170866e49c87618b706ac7 > Author: Paul Kocialkowski > Date: Fri Jan 4 09:56:10 2019 +0100 > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > this is done

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: move crtc and dpll declarations where they belong

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915/display: move crtc and dpll declarations where they belong URL : https://patchwork.freedesktop.org/series/89551/ State : success == Summary == CI Bug Log - changes from CI_DRM_10017 -> Patchwork_20005

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915/gtt/dgfx: place the PD in LMEM

2021-04-27 Thread Tvrtko Ursulin
On 27/04/2021 09:54, Matthew Auld wrote: It's a requirement that for dgfx we place all the paging structures in device local-memory. v2: use i915_coherent_map_type() v3: improve the shared dma-resv object comment Signed-off-by: Matthew Auld Cc: Tvrtko Ursulin ---

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915/gtt/dgfx: place the PD in LMEM

2021-04-27 Thread Matthew Auld
On 27/04/2021 14:34, Tang, CQ wrote: -Original Message- From: Intel-gfx On Behalf Of Matthew Auld Sent: Tuesday, April 27, 2021 1:54 AM To: intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Subject: [Intel-gfx] [PATCH v2 4/7] drm/i915/gtt/dgfx: place the PD in LMEM

Re: [Intel-gfx] [PATCH v2 3/7] drm/i915/gtt: map the PD up front

2021-04-27 Thread Tvrtko Ursulin
On 27/04/2021 09:54, Matthew Auld wrote: We need to generalise our accessor for the page directories and tables from using the simple kmap_atomic to support local memory, and this setup must be done on acquisition of the backing storage prior to entering fence execution contexts. Here we

Re: [Intel-gfx] [PATCH] drm/i915/gem: Remove reference to struct drm_device.pdev

2021-04-27 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Thomas Zimmermann >Sent: Tuesday, April 27, 2021 7:08 AM >To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo >; airl...@linux.ie; dan...@ffwll.ch; Auld, Matthew > >Cc: Tvrtko Ursulin ; Ursulin, Tvrtko >; Mika

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: add intel_dp_hdcp.h and rename init accordingly

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: add intel_dp_hdcp.h and rename init accordingly URL : https://patchwork.freedesktop.org/series/89550/ State : success == Summary == CI Bug Log - changes from CI_DRM_10017 -> Patchwork_20004

Re: [Intel-gfx] [PATCH 08/20] drm/i915/gem: Disallow bonding of virtual engines (v2)

2021-04-27 Thread Daniel Vetter
On Mon, Apr 26, 2021 at 06:43:30PM -0500, Jason Ekstrand wrote: > This adds a bunch of complexity which the media driver has never > actually used. The media driver does technically bond a balanced engine > to another engine but the balanced engine only has one engine in the > sibling set. This

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-27 Thread Jason Ekstrand
On Fri, Apr 23, 2021 at 5:31 PM Jason Ekstrand wrote: > > This adds a bunch of complexity which the media driver has never > actually used. The media driver does technically bond a balanced engine > to another engine but the balanced engine only has one engine in the > sibling set. This doesn't

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hdcp: add intel_dp_hdcp.h and rename init accordingly

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: add intel_dp_hdcp.h and rename init accordingly URL : https://patchwork.freedesktop.org/series/89550/ State : warning == Summary == $ dim checkpatch origin/drm-tip 268ac60ecd8b drm/i915/hdcp: add intel_dp_hdcp.h and rename init accordingly -:79:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Remove reference to struct drm_device.pdev

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915/gem: Remove reference to struct drm_device.pdev URL : https://patchwork.freedesktop.org/series/89545/ State : success == Summary == CI Bug Log - changes from CI_DRM_10017 -> Patchwork_20002 Summary

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: Move struct drm_device.pdev to legacy (rev7)

2021-04-27 Thread Patchwork
== Series Details == Series: drm: Move struct drm_device.pdev to legacy (rev7) URL : https://patchwork.freedesktop.org/series/84205/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915/gtt/dgfx: place the PD in LMEM

2021-04-27 Thread Tang, CQ
> -Original Message- > From: Intel-gfx On Behalf Of > Matthew Auld > Sent: Tuesday, April 27, 2021 1:54 AM > To: intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 4/7] drm/i915/gtt/dgfx: place the PD in LMEM > > It's a requirement

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/7] drm/i915/dg1: Fix mapping type for default state object

2021-04-27 Thread Patchwork
== Series Details == Series: series starting with [v2,1/7] drm/i915/dg1: Fix mapping type for default state object URL : https://patchwork.freedesktop.org/series/89529/ State : success == Summary == CI Bug Log - changes from CI_DRM_10014_full -> Patchwork_19998_full

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Introduce Intel PXP (rev5)

2021-04-27 Thread Patchwork
== Series Details == Series: Introduce Intel PXP (rev5) URL : https://patchwork.freedesktop.org/series/86798/ State : failure == Summary == Applying: drm/i915/pxp: Define PXP component interface Applying: mei: pxp: export pavp client to me client bus Applying: drm/i915/pxp: define PXP device

Re: [Intel-gfx] [PATCH v7 0/4] drm: Move struct drm_device.pdev to legacy

2021-04-27 Thread Jani Nikula
On Tue, 27 Apr 2021, Thomas Zimmermann wrote: > Hi Jani > > Am 27.04.21 um 14:04 schrieb Jani Nikula: >> On Tue, 27 Apr 2021, Thomas Zimmermann wrote: >>> V7 of the patchset fixes some bitrot in the intel driver. >>> >>> The pdev field in struct drm_device points to a PCI device structure and

Re: [Intel-gfx] [PATCH] drm/i915/gem: Remove reference to struct drm_device.pdev

2021-04-27 Thread Jani Nikula
On Tue, 27 Apr 2021, Thomas Zimmermann wrote: > References to struct drm_device.pdev should be used any longer as > the field will be moved into the struct's legacy section. Add a fix > for the rsp commit. > > Signed-off-by: Thomas Zimmermann > Fixes: d57d4a1daf5e ("drm/i915: Create stolen

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Simplify userptr locking (rev2)

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915: Simplify userptr locking (rev2) URL : https://patchwork.freedesktop.org/series/88974/ State : success == Summary == CI Bug Log - changes from CI_DRM_10016 -> Patchwork_2 Summary ---

Re: [Intel-gfx] [PATCH 8/8] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-27 Thread Daniel Vetter
On Tue, Apr 27, 2021 at 12:32:19PM +0100, Emil Velikov wrote: > Hi Daniel, > > On Tue, 27 Apr 2021 at 10:20, Daniel Vetter wrote: > > > @@ -360,6 +373,9 @@ static int __drm_universal_plane_init(struct drm_device > > *dev, > > * drm_universal_plane_init() to let the DRM managed resource > >

Re: [Intel-gfx] [PATCH v7 0/4] drm: Move struct drm_device.pdev to legacy

2021-04-27 Thread Thomas Zimmermann
Hi Jani Am 27.04.21 um 14:04 schrieb Jani Nikula: On Tue, 27 Apr 2021, Thomas Zimmermann wrote: V7 of the patchset fixes some bitrot in the intel driver. The pdev field in struct drm_device points to a PCI device structure and goes back to UMS-only days when all DRM drivers were for PCI

Re: [Intel-gfx] [PATCH v7 0/4] drm: Move struct drm_device.pdev to legacy

2021-04-27 Thread Jani Nikula
On Tue, 27 Apr 2021, Thomas Zimmermann wrote: > V7 of the patchset fixes some bitrot in the intel driver. > > The pdev field in struct drm_device points to a PCI device structure and > goes back to UMS-only days when all DRM drivers were for PCI devices. > Meanwhile we also support USB, SPI and

[Intel-gfx] [PATCH] drm/i915/display: move crtc and dpll declarations where they belong

2021-04-27 Thread Jani Nikula
The definitions are in the crtc and dpll files; move the declarations to the corresponding headers. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c| 1 + drivers/gpu/drm/i915/display/intel_crt.c | 1 + drivers/gpu/drm/i915/display/intel_crtc.h | 3 +++

[Intel-gfx] [PATCH] drm/i915/hdcp: add intel_dp_hdcp.h and rename init accordingly

2021-04-27 Thread Jani Nikula
Add separate intel_dp_hdcp.h to go with intel_dp_hdcp.c, and rename the init function intel_dp_hdcp_init() to follow naming where function prefix matches the file name. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 5 +++--

Re: [Intel-gfx] [PATCH 8/8] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-27 Thread Emil Velikov
Hi Daniel, On Tue, 27 Apr 2021 at 10:20, Daniel Vetter wrote: > @@ -360,6 +373,9 @@ static int __drm_universal_plane_init(struct drm_device > *dev, > * drm_universal_plane_init() to let the DRM managed resource infrastructure > * take care of cleanup and deallocation. > * > + * Drivers

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/8] drm/arm: Don't set allow_fb_modifiers explicitly

2021-04-27 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/arm: Don't set allow_fb_modifiers explicitly URL : https://patchwork.freedesktop.org/series/89531/ State : success == Summary == CI Bug Log - changes from CI_DRM_10015 -> Patchwork_1

[Intel-gfx] [PATCH v7 4/4] drm: Move struct drm_device.pdev to legacy section

2021-04-27 Thread Thomas Zimmermann
Struct drm_device.pdev is being moved to legacy status as only legacy DRM drivers use it. A possible follow-up patchset could remove pdev entirely. v4: * rebased Signed-off-by: Thomas Zimmermann Reviewed-by: Chris Wilson Acked-by: Sam Ravnborg --- include/drm/drm_device.h | 6 +++---

[Intel-gfx] [PATCH v7 3/4] drm/i915: Don't assign to struct drm_device.pdev

2021-04-27 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Don't assign it. Users should upcast from struct drm_device.dev. v6: * also fix the assignment in selftests in this patch (Chris) Signed-off-by: Thomas Zimmermann Reviewed-by: Chris Wilson Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo

[Intel-gfx] [PATCH v7 1/4] drm/i915/gt: Remove reference to struct drm_device.pdev

2021-04-27 Thread Thomas Zimmermann
References to struct drm_device.pdev should be used any longer as the field will be moved into the struct's legacy section. Add a fix for the rsp commit. Signed-off-by: Thomas Zimmermann Fixes: a50ca39fbd01 ("drm/i915: setup the LMEM region") Cc: Lucas De Marchi Cc: Joonas Lahtinen Cc: Rodrigo

[Intel-gfx] [PATCH v7 0/4] drm: Move struct drm_device.pdev to legacy

2021-04-27 Thread Thomas Zimmermann
V7 of the patchset fixes some bitrot in the intel driver. The pdev field in struct drm_device points to a PCI device structure and goes back to UMS-only days when all DRM drivers were for PCI devices. Meanwhile we also support USB, SPI and platform devices. Each of those uses the generic device

[Intel-gfx] [PATCH v7 2/4] drm/i915: Remove reference to struct drm_device.pdev

2021-04-27 Thread Thomas Zimmermann
References to struct drm_device.pdev should be used any longer as the field will be moved into the struct's legacy section. Fix a rsp comment. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/intel_runtime_pm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH] drm/i915/gem: Remove reference to struct drm_device.pdev

2021-04-27 Thread Thomas Zimmermann
References to struct drm_device.pdev should be used any longer as the field will be moved into the struct's legacy section. Add a fix for the rsp commit. Signed-off-by: Thomas Zimmermann Fixes: d57d4a1daf5e ("drm/i915: Create stolen memory region from local memory") Cc: CQ Tang Cc: Matthew Auld

Re: [Intel-gfx] [PATCH v2 01/13] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE

2021-04-27 Thread Cornelia Huck
On Mon, 26 Apr 2021 17:00:03 -0300 Jason Gunthorpe wrote: > For some reason the vfio_mdev shim mdev_driver has its own module and > kconfig. As the next patch requires access to it from mdev.ko merge the > two modules together and remove VFIO_MDEV_DEVICE. > > A later patch deletes this driver

[Intel-gfx] [PATCH v3 15/16] drm/i915/pxp: black pixels on pxp disabled

2021-04-27 Thread Anshuman Gupta
When protected sufaces has flipped and pxp session is disabled, display black pixels by using plane color CTM correction. v2: - Display black pixels in aysnc flip too. Cc: Ville Syrjälä Cc: Gaurav Kumar Cc: Shankar Uma Signed-off-by: Anshuman Gupta Signed-off-by: Daniele Ceraolo Spurio ---

[Intel-gfx] [PATCH v3 14/16] drm/i915/pxp: Add plane decryption support

2021-04-27 Thread Anshuman Gupta
Add support to enable/disable PLANE_SURF Decryption Request bit. It requires only to enable plane decryption support when following condition met. 1. PXP session is enabled. 2. Buffer object is protected. v2: - Used gen fb obj user_flags instead gem_object_metadata. [Krishna] v3: -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/arm: Don't set allow_fb_modifiers explicitly

2021-04-27 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/arm: Don't set allow_fb_modifiers explicitly URL : https://patchwork.freedesktop.org/series/89531/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6bdfcd621a6a drm/arm: Don't set allow_fb_modifiers explicitly -:8:

[Intel-gfx] [PATCH] drm/i915: Simplify userptr locking

2021-04-27 Thread Thomas Hellström
Use an rwlock instead of spinlock for the global notifier lock to reduce risk of contention in execbuf. Protect object state with the object lock whenever possible rather than with the global notifier lock Don't take an explicit page_ref in userptr_submit_init() but rather call get_pages() after

Re: [Intel-gfx] [PATCH] drm/i915: Stop using crtc->index as the pipe

2021-04-27 Thread Jani Nikula
On Mon, 26 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > The pipe crc code slipped theough the net when we tried to > eliminate all crtc->index==pipe abuses. Remedy that. > > And while at it get rid of those nasty intel_crtc+drm_crtc > pointer aliases. > > Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] Intel-gfx Digest, Vol 159, Issue 337

2021-04-27 Thread 625124588wzy
___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 07/21] drm/i915: Drop getparam support for I915_CONTEXT_PARAM_ENGINES

2021-04-27 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:17PM -0500, Jason Ekstrand wrote: > This has never been used by any userspace except IGT and provides no > real functionality beyond parroting back parameters userspace passed in > as part of context creation or via setparam. If the context is in > legacy mode (where

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Stop using crtc->index as the pipe

2021-04-27 Thread Patchwork
== Series Details == Series: drm/i915: Stop using crtc->index as the pipe URL : https://patchwork.freedesktop.org/series/89511/ State : success == Summary == CI Bug Log - changes from CI_DRM_10013_full -> Patchwork_19996_full Summary

Re: [Intel-gfx] [PATCH 06/21] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v3)

2021-04-27 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:16PM -0500, Jason Ekstrand wrote: > This API is entirely unnecessary and I'd love to get rid of it. If > userspace wants a single timeline across multiple contexts, they can > either use implicit synchronization or a syncobj, both of which existed > at the time this

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/7] drm/i915/dg1: Fix mapping type for default state object

2021-04-27 Thread Patchwork
== Series Details == Series: series starting with [v2,1/7] drm/i915/dg1: Fix mapping type for default state object URL : https://patchwork.freedesktop.org/series/89529/ State : success == Summary == CI Bug Log - changes from CI_DRM_10014 -> Patchwork_19998

Re: [Intel-gfx] [PATCH 05/21] drm/i915: Drop the CONTEXT_CLONE API

2021-04-27 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:15PM -0500, Jason Ekstrand wrote: > This API allows one context to grab bits out of another context upon > creation. It can be used as a short-cut for setparam(getparam()) for > things like I915_CONTEXT_PARAM_VM. However, it's never been used by any > real

Re: [Intel-gfx] [PATCH 04/21] drm/i915/gem: Return void from context_apply_all

2021-04-27 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:14PM -0500, Jason Ekstrand wrote: > None of the callbacks we use with it return an error code anymore; they > all return 0 unconditionally. > > Signed-off-by: Jason Ekstrand Nice. Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c |

Re: [Intel-gfx] [PATCH] drm/i9i5/gt: Fix a double free in gen8_preallocate_top_level_pdp

2021-04-27 Thread Matthew Auld
On Mon, 26 Apr 2021 at 13:44, Lv Yunlong wrote: > > Our code analyzer reported a double free bug. > > In gen8_preallocate_top_level_pdp, pde and pde->pt.base are allocated > via alloc_pd(vm) with one reference. If pin_pt_dma() failed, pde->pt.base > is freed by i915_gem_object_put() with a

Re: [Intel-gfx] [PATCH 03/21] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem

2021-04-27 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:13PM -0500, Jason Ekstrand wrote: > Instead of handling it like a context param, unconditionally set it when > intel_contexts are created. This doesn't fix anything but does simplify > the code a bit. > > Signed-off-by: Jason Ekstrand So the idea here is that

[Intel-gfx] [PATCH v2 08/13] vfio/gvt: Convert to use vfio_register_group_dev()

2021-04-27 Thread Jason Gunthorpe
While there is a confusing mess of pointers and structs in this driver, the struct kvmgt_vdev (which in turn is 1:1 with a struct intel_vgpu) is what holds the vfio_device. Replace all the drvdata's and weird derivations of vgpu and vdev with container_of() or vdev->vgpu. Signed-off-by: Jason

[Intel-gfx] [PATCH v2 01/13] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE

2021-04-27 Thread Jason Gunthorpe
For some reason the vfio_mdev shim mdev_driver has its own module and kconfig. As the next patch requires access to it from mdev.ko merge the two modules together and remove VFIO_MDEV_DEVICE. A later patch deletes this driver entirely. Signed-off-by: Jason Gunthorpe ---

Re: [Intel-gfx] [PATCH 01/12] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE

2021-04-27 Thread Jason Gunthorpe
On Fri, Apr 23, 2021 at 05:08:10PM -0700, Randy Dunlap wrote: > On 4/23/21 4:02 PM, Jason Gunthorpe wrote: > > @@ -171,7 +171,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB > > > > config SAMPLE_VFIO_MDEV_MBOCHS > > tristate "Build VFIO mdpy example mediated device sample code -- > > loadable

  1   2   >