== Series Details ==
Series: drm/i915: keep backlight_enable on until turn eDP display off (rev4)
URL : https://patchwork.freedesktop.org/series/91780/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8f8d8fc4ecbc drm/i915: keep backlight_enable on until turn eDP display off
On Wed, Jun 23, 2021 at 02:44:34PM -0400, Qian Cai wrote:
> is_swiotlb_force_bounce at /usr/src/linux-next/./include/linux/swiotlb.h:119
>
> is_swiotlb_force_bounce() was the new function introduced in this patch here.
>
> +static inline bool is_swiotlb_force_bounce(struct device *dev)
> +{
> +
This workaround is specific for a particular panel on Google
chromebook project. When user space daemon enter idle state.
It request adjust brightness to 0, turn backlight_enable signal
off and keep eDP main link active.
On general LCD, this behavior might not be a problem.
But on this panel, its
Please ignore this last patch. It was put together as an afterthought
and wasn't properly tested.
-David
On Thu, Jun 24, 2021 at 12:59 PM David Stevens wrote:
>
> Return struct page instead of pfn from gfn_to_mfn. This function is only
> used to determine if the page is a transparent hugepage,
== Series Details ==
Series: KVM: Remove uses of struct page from x86 and arm64 MMU
URL : https://patchwork.freedesktop.org/series/91836/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
CALLscripts/atomic/check-atomics.sh
DESCEND objtool
CHK
Return struct page instead of pfn from gfn_to_mfn. This function is only
used to determine if the page is a transparent hugepage, to enable 2MB
huge gtt shadowing. Returning the page directly avoids the risk of
calling pfn_to_page on a VM_IO|VM_PFNMAP pfn.
This change also properly releases the
From: David Stevens
Remove two warnings that require ref counts for pages to be non-zero, as
mapped pfns from follow_pfn may not have an initialized ref count.
Signed-off-by: David Stevens
---
arch/x86/kvm/mmu/mmu.c | 7 ---
virt/kvm/kvm_main.c| 2 +-
2 files changed, 1 insertion(+),
From: David Stevens
Avoid converting pfns returned by follow_fault_pfn to struct pages to
transiently take a reference. The reference was originally taken to
match the reference taken by gup. However, pfns returned by
follow_fault_pfn may not have a struct page set up for reference
counting.
From: David Stevens
Avoid converting pfns returned by follow_fault_pfn to struct pages to
transiently take a reference. The reference was originally taken to
match the reference taken by gup. However, pfns returned by
follow_fault_pfn may not have a struct page set up for reference
counting.
From: David Stevens
Return a struct kvm_pfn_page containing both a pfn and an optional
struct page from the gfn_to_pfn family of functions. This differentiates
the gup and follow_fault_pfn cases, which allows callers that only need
a pfn to avoid touching the page struct in the latter case. For
From: David Stevens
Signed-off-by: David Stevens
---
arch/x86/kvm/mmu/mmu_audit.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/kvm/mmu/mmu_audit.c b/arch/x86/kvm/mmu/mmu_audit.c
index cedc17b2f60e..97ff184084b4 100644
--- a/arch/x86/kvm/mmu/mmu_audit.c
+++
KVM supports mapping VM_IO and VM_PFNMAP memory into the guest by using
follow_pte in gfn_to_pfn. However, the resolved pfns may not have
assoicated struct pages, so they should not be passed to pfn_to_page.
This series removes such calls from the x86 and arm64 secondary MMU. To
do this, this
On Thu, 24 June 2021, Jani Nikula wrote:
>On Tue, 22 Jun 2021, Lee Shawn C wrote:
>> This workaround is specific for a particular panel on Google
>> chromebook project. When user space daemon enter idle state.
>> It request adjust brightness to 0, turn backlight_enable signal off
>> and keep
On Mon, May 31, 2021 at 09:48:45AM +0300, Stanislav Lisovskiy wrote:
> PSF GV points are an additional factor that can limit the
> bandwidth available to display, separate from the traditional
> QGV points. Whereas traditional QGV points represent possible
> memory clock frequencies, PSF GV
On Mon, May 31, 2021 at 09:48:44AM +0300, Stanislav Lisovskiy wrote:
> According to BSpec there is now also a code 0x02,
> which corresponds to QGV point being rejected,
> this code so lets extend mask to check this.
>
> Signed-off-by: Stanislav Lisovskiy
Reviewed-by: Matt Roper
> ---
>
== Series Details ==
Series: drm/i915/display: Fix shared dpll mismatch for bigjoiner slave
URL : https://patchwork.freedesktop.org/series/91830/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10268_full -> Patchwork_20446_full
On 6/16/2021 11:43 PM, Dale B Stimson wrote:
As part of the System Managemenent Interface (SMI), use the HWMON
subsystem to display power utilization.
The following standard HWMON power sensors are currently supported
(and appropriately scaled):
/sys/class/drm/card0/device/hwmon/hwmon
Hi Matthew,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next
tegra-drm/drm/tegra/for-next drm/drm-next v5.13-rc7 next-20210623]
[If your patch is applied to the wrong git tree
== Series Details ==
Series: implicit fencing/dma-resv rules for shared buffers (rev5)
URL : https://patchwork.freedesktop.org/series/91789/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10268_full -> Patchwork_20444_full
== Series Details ==
Series: drm/i915/ttm: fix static warning
URL : https://patchwork.freedesktop.org/series/91821/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10268_full -> Patchwork_20443_full
Summary
---
Hi Matthew,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next
tegra-drm/drm/tegra/for-next drm/drm-next v5.13-rc7 next-20210623]
[If your patch is applied to the wrong git tree
== Series Details ==
Series: drm/i915/display: Fix shared dpll mismatch for bigjoiner slave
URL : https://patchwork.freedesktop.org/series/91830/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20446
On Wed, 23 Jun 2021 at 20:15, Daniel Vetter wrote:
>
> On Wed, Jun 23, 2021 at 06:27:06PM +0100, Matthew Auld wrote:
> > Looks like it got lost along the way, so add it back. This is needed for
> > the region query uAPI where we want to report a snapshot of how much
> > lmem is available.
> >
> >
Looks good to me.
Reviewed-by: Gwan-gyeong Mun
On 6/16/21 11:31 PM, José Roberto de Souza wrote:
Another WA that is required for PSR2.
BSpec: 54369
Cc: Gwan-gyeong Mun
Cc: Matt Atwood
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/display/intel_psr.c | 15 +++
== Series Details ==
Series: series starting with [v2,1/2] drm/i915: support forcing the page size
with lmem
URL : https://patchwork.freedesktop.org/series/91820/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10268_full -> Patchwork_20442_full
On Wed, Jun 23, 2021 at 06:47:37PM +0200, Boris Brezillon wrote:
> On Tue, 22 Jun 2021 18:55:02 +0200
> Daniel Vetter wrote:
>
> > Currently this has no practial relevance I think because there's not
> > many who can pull off a setup with panfrost and another gpu in the
> > same system. But the
Am 23.06.21 um 17:12 schrieb Daniel Vetter:
On Wed, Jun 23, 2021 at 05:07:17PM +0200, Christian König wrote:
Am 23.06.21 um 17:03 schrieb Daniel Vetter:
On Wed, Jun 23, 2021 at 04:58:27PM +0200, Bas Nieuwenhuizen wrote:
On Wed, Jun 23, 2021 at 4:50 PM Daniel Vetter wrote:
On Wed, Jun 23,
On Wed, Jun 23, 2021 at 06:27:06PM +0100, Matthew Auld wrote:
> Looks like it got lost along the way, so add it back. This is needed for
> the region query uAPI where we want to report a snapshot of how much
> lmem is available.
>
> This time around let's push it directly into the allocator,
== Series Details ==
Series: drm/i915/display: Fix shared dpll mismatch for bigjoiner slave
URL : https://patchwork.freedesktop.org/series/91830/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9fd0e560efbd drm/i915/display: Fix shared dpll mismatch for bigjoiner slave
-:10:
Am 23.06.21 um 17:03 schrieb Daniel Vetter:
On Wed, Jun 23, 2021 at 04:58:27PM +0200, Bas Nieuwenhuizen wrote:
On Wed, Jun 23, 2021 at 4:50 PM Daniel Vetter wrote:
On Wed, Jun 23, 2021 at 4:02 PM Christian König
wrote:
Am 23.06.21 um 15:49 schrieb Daniel Vetter:
On Wed, Jun 23, 2021 at
On 6/16/21 11:31 PM, José Roberto de Souza wrote:
Implements changes around PSR for alderlake-P:
- EDP_SU_TRACK_ENABLE was removed and bit 30 now has other function
- Some bits of PSR2_MAN_TRK_CTL moved and SF_PARTIAL_FRAME_UPDATE was
removed setting SU_REGION_START/END_ADDR will do this job
Currently when we do the HW state readout, we dont set the shared dpll to NULL
for the bigjoiner slave which should not have a DPLL assigned. So it has
some garbage while the HW state readout is NULL. So explicitly reset
the shared dpll for bigjoiner slave pipe.
Bug:
== Series Details ==
Series: drm/i915: Move system memory to TTM for discrete (rev9)
URL : https://patchwork.freedesktop.org/series/90898/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10268_full -> Patchwork_20441_full
looks good to me
Reviewed-by: Gwan-gyeong Mun
On 6/16/21 11:31 PM, José Roberto de Souza wrote:
PSR2 is not compatible with DC3CO or VRR in this stepping, so not
enabling PSR2 if VRR will be enabled or not enabling DC3CO if PSR2 is
possible.
BSpec: 54369
Cc: Gwan-gyeong Mun
Cc: Matt Atwood
looks good to me.
Reviewed-by: Gwan-gyeong Mun
On 6/16/21 11:31 PM, José Roberto de Souza wrote:
In some modes there is not enough time during hblank to transmit PSR2
SDP plus the pixels CRC SDP, if such case happens PSR2 needs to be
disabled.
But eDP spec 1.4b allows to transmit PSR2 SDP in a
== Series Details ==
Series: drm/i915: add back the avail tracking
URL : https://patchwork.freedesktop.org/series/91826/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20445
Summary
---
**FAILURE**
Am 23.06.21 um 15:49 schrieb Daniel Vetter:
On Wed, Jun 23, 2021 at 3:44 PM Christian König
wrote:
Am 23.06.21 um 15:38 schrieb Bas Nieuwenhuizen:
On Wed, Jun 23, 2021 at 2:59 PM Christian König
wrote:
Am 23.06.21 um 14:18 schrieb Daniel Vetter:
On Wed, Jun 23, 2021 at 11:45 AM Bas
Am 23.06.21 um 15:38 schrieb Bas Nieuwenhuizen:
On Wed, Jun 23, 2021 at 2:59 PM Christian König
wrote:
Am 23.06.21 um 14:18 schrieb Daniel Vetter:
On Wed, Jun 23, 2021 at 11:45 AM Bas Nieuwenhuizen
wrote:
On Tue, Jun 22, 2021 at 6:55 PM Daniel Vetter wrote:
WARNING: Absolutely untested
== Series Details ==
Series: series starting with [1/2] ALSA: hda: Release controller display power
during shutdown/reboot
URL : https://patchwork.freedesktop.org/series/91815/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10268_full -> Patchwork_20440_full
== Series Details ==
Series: implicit fencing/dma-resv rules for shared buffers (rev5)
URL : https://patchwork.freedesktop.org/series/91789/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20444
Summary
Hi Daniel, looks good.
On Wed, Jun 23, 2021 at 06:24:56PM +0200, Daniel Vetter wrote:
> It's tedious to review this all the time, and my audit showed that
> arcpgu actually forgot to set this.
>
> Make this the default and stop worrying.
>
> Again I sprinkled WARN_ON_ONCE on top to make sure we
Hi Daniel, looks good.
On Wed, Jun 23, 2021 at 06:17:12PM +0200, Daniel Vetter wrote:
> Also review & update everything while we're at it.
>
> This is prep work to smash a ton of stuff into the kerneldoc for
> @resv.
>
> v2: Move the doc for sysfs_entry.attachment_uid to the right place too
>
Looks like it got lost along the way, so add it back. This is needed for
the region query uAPI where we want to report a snapshot of how much
lmem is available.
This time around let's push it directly into the allocator, which
simplifies things, like not having to care about internal
== Series Details ==
Series: implicit fencing/dma-resv rules for shared buffers (rev5)
URL : https://patchwork.freedesktop.org/series/91789/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: implicit fencing/dma-resv rules for shared buffers (rev5)
URL : https://patchwork.freedesktop.org/series/91789/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
ec4dbdd1b8f4 dma-resv: Fix kerneldoc
-:11: ERROR:GIT_COMMIT_ID: Please use git commit
== Series Details ==
Series: drm/i915/ttm: fix static warning
URL : https://patchwork.freedesktop.org/series/91821/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20443
Summary
---
**SUCCESS**
Am 23.06.21 um 14:18 schrieb Daniel Vetter:
On Wed, Jun 23, 2021 at 11:45 AM Bas Nieuwenhuizen
wrote:
On Tue, Jun 22, 2021 at 6:55 PM Daniel Vetter wrote:
WARNING: Absolutely untested beyond "gcc isn't dying in agony".
Implicit fencing done properly needs to treat the implicit fencing
slots
On Tue, 22 Jun 2021 18:55:00 +0200
Daniel Vetter wrote:
> drm/scheduler requires a lock between _init and _push_job, but the
> reservation lock dance doesn't. So shrink the critical section a
> notch.
>
> v2: Lucas pointed out how this should really work, I got it all wrong
> in v1.
>
>
On Tue, 22 Jun 2021 18:55:01 +0200
Daniel Vetter wrote:
> More consistency and prep work for the next patch.
>
> Aside: I wonder whether we shouldn't just move this entire xarray
> business into the scheduler so that not everyone has to reinvent the
> same wheels. Cc'ing some scheduler people
On Tue, 22 Jun 2021 18:55:02 +0200
Daniel Vetter wrote:
> Currently this has no practial relevance I think because there's not
> many who can pull off a setup with panfrost and another gpu in the
> same system. But the rules are that if you're setting an exclusive
> fence, indicating a gpu write
On Tue, 22 Jun 2021, Lee Shawn C wrote:
> This workaround is specific for a particular panel on Google
> chromebook project. When user space daemon enter idle state.
> It request adjust brightness to 0, turn backlight_enable signal
> off and keep eDP main link active.
>
> On general LCD, this
On Wed, Jun 23, 2021 at 5:38 PM Thomas Hellström
wrote:
>
> Thanks for reviewing, Daniel.
>
> On 6/23/21 5:09 PM, Daniel Vetter wrote:
> >
> >>
> >> +unsigned int mem_flags:2;
> > Is the entire bitfield array all protected by dma_resv_lock? If not I'd
> > just go with a full field, avoids
== Series Details ==
Series: drm/i915/ttm: fix static warning
URL : https://patchwork.freedesktop.org/series/91821/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/ttm: fix static warning
URL : https://patchwork.freedesktop.org/series/91821/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
884185292bdf drm/i915/ttm: fix static warning
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit
== Series Details ==
Series: series starting with [v2,1/2] drm/i915: support forcing the page size
with lmem
URL : https://patchwork.freedesktop.org/series/91820/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20442
It's tedious to review this all the time, and my audit showed that
arcpgu actually forgot to set this.
Make this the default and stop worrying.
Again I sprinkled WARN_ON_ONCE on top to make sure we don't have
strange combinations of hooks: cleanup_fb without prepare_fb doesn't
make sense, and
There's a bunch of atomic drivers who don't do this quite correctly,
luckily most of them aren't in wide use or people would have noticed
the tearing.
By making this the default we avoid the constant audit pain and can
additionally remove a ton of lines from vfuncs for a bit more clarity
in
Docs for struct dma_resv are fairly clear:
"A reservation object can have attached one exclusive fence (normally
associated with write operations) or N shared fences (read
operations)."
https://dri.freedesktop.org/docs/drm/driver-api/dma-buf.html#reservation-objects
Furthermore a review across
Also review & update everything while we're at it.
This is prep work to smash a ton of stuff into the kerneldoc for
@resv.
v2: Move the doc for sysfs_entry.attachment_uid to the right place too
(Sam)
Acked-by: Christian König
Cc: Sam Ravnborg
Reviewed-by: Alex Deucher
Signed-off-by: Daniel
== Series Details ==
Series: series starting with [v2,1/2] drm/i915: support forcing the page size
with lmem
URL : https://patchwork.freedesktop.org/series/91820/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be
== Series Details ==
Series: series starting with [v2,1/2] drm/i915: support forcing the page size
with lmem
URL : https://patchwork.freedesktop.org/series/91820/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
870ae7fc4949 drm/i915: support forcing the page size with lmem
== Series Details ==
Series: drm/i915: Move system memory to TTM for discrete (rev9)
URL : https://patchwork.freedesktop.org/series/90898/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20441
Summary
Hi Daniel,
> > >* equivalent functionality should be implemented through private
> > >* members in the plane structure.
> > >*
> > > - * Drivers which always have their buffers pinned should use
> > > - * drm_gem_plane_helper_prepare_fb() for this hook.
> > > +
Thanks for reviewing, Daniel.
On 6/23/21 5:09 PM, Daniel Vetter wrote:
+ unsigned int mem_flags:2;
Is the entire bitfield array all protected by dma_resv_lock? If not I'd
just go with a full field, avoids headaches and all that.
Also kerneldoc for this would be really sweet. Means some
On 6/16/21 11:31 PM, José Roberto de Souza wrote:
The PSR2_CTL io buffer wake and fast wake values do not match
expected in pre production hardware, so here adding a table that
matches with HW to program it with values that HW expect.
Cc: Gwan-gyeong Mun
Signed-off-by: José Roberto de Souza
On 6/23/21 4:34 PM, Matthew Auld wrote:
warning: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static?
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
== Series Details ==
Series: drm/i915: Move system memory to TTM for discrete (rev9)
URL : https://patchwork.freedesktop.org/series/90898/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: series starting with [1/2] ALSA: hda: Release controller display power
during shutdown/reboot
URL : https://patchwork.freedesktop.org/series/91815/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20440
On Wed, Jun 23, 2021 at 10:31:18AM +0200, Christian König wrote:
> Am 22.06.21 um 18:54 schrieb Daniel Vetter:
> > Oversight from
> >
> > commit 6edbd6abb783d54f6ac4c3ed5cd9e50cff6c15e9
> > Author: Christian König
> > Date: Mon May 10 16:14:09 2021 +0200
> >
> > dma-buf: rename and
On Wed, Jun 23, 2021 at 05:07:17PM +0200, Christian König wrote:
> Am 23.06.21 um 17:03 schrieb Daniel Vetter:
> > On Wed, Jun 23, 2021 at 04:58:27PM +0200, Bas Nieuwenhuizen wrote:
> > > On Wed, Jun 23, 2021 at 4:50 PM Daniel Vetter
> > > wrote:
> > > > On Wed, Jun 23, 2021 at 4:02 PM Christian
On Mon, Jun 21, 2021 at 09:36:42PM +0200, Thomas Hellström wrote:
> The object ops i915_GEM_OBJECT_HAS_IOMEM and the object
> I915_BO_ALLOC_STRUCT_PAGE flags are considered immutable by
> much of our code. Introduce a new mem_flags member to hold these
> and make sure checks for these flags being
On Wed, Jun 23, 2021 at 04:58:27PM +0200, Bas Nieuwenhuizen wrote:
> On Wed, Jun 23, 2021 at 4:50 PM Daniel Vetter wrote:
> >
> > On Wed, Jun 23, 2021 at 4:02 PM Christian König
> > wrote:
> > >
> > > Am 23.06.21 um 15:49 schrieb Daniel Vetter:
> > > > On Wed, Jun 23, 2021 at 3:44 PM Christian
On Wed, Jun 23, 2021 at 4:50 PM Daniel Vetter wrote:
>
> On Wed, Jun 23, 2021 at 4:02 PM Christian König
> wrote:
> >
> > Am 23.06.21 um 15:49 schrieb Daniel Vetter:
> > > On Wed, Jun 23, 2021 at 3:44 PM Christian König
> > > wrote:
> > >> Am 23.06.21 um 15:38 schrieb Bas Nieuwenhuizen:
> > >>>
On Wed, 23 Jun 2021 15:46:00 +0200,
Imre Deak wrote:
>
> Make sure the HDA driver's display power reference is released during
> shutdown/reboot.
>
> During the shutdown/reboot sequence the pci device core calls the
> pm_runtime_resume handler for all devices before calling the driver's
>
On Wed, Jun 23, 2021 at 4:02 PM Christian König
wrote:
>
> Am 23.06.21 um 15:49 schrieb Daniel Vetter:
> > On Wed, Jun 23, 2021 at 3:44 PM Christian König
> > wrote:
> >> Am 23.06.21 um 15:38 schrieb Bas Nieuwenhuizen:
> >>> On Wed, Jun 23, 2021 at 2:59 PM Christian König
> >>> wrote:
> Am
== Series Details ==
Series: series starting with [1/2] ALSA: hda: Release controller display power
during shutdown/reboot
URL : https://patchwork.freedesktop.org/series/91815/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
150ed9082a2d ALSA: hda: Release controller display
== Series Details ==
Series: series starting with [1/3] drm/i915/ttm: consider all placements for
the page alignment
URL : https://patchwork.freedesktop.org/series/91811/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20439
On Tue, 08 Jun 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> adls is supposed to use special buf trans tables. Add what's
> missing.
>
> v2: Drop the RBR/HBR table since it's the same as for tgl
>
> Signed-off-by: Ville Syrjälä
Pedantically reviewed every value,
Reviewed-by: Jani
warning: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static?
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
== Series Details ==
Series: series starting with [1/3] drm/i915/ttm: consider all placements for
the page alignment
URL : https://patchwork.freedesktop.org/series/91811/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't
On 6/18/21 1:25 AM, Claire Chang wrote:
> On Fri, Jun 18, 2021 at 7:30 AM Stefano Stabellini
> wrote:
>>
>> On Thu, 17 Jun 2021, Claire Chang wrote:
>>> Add a new function, swiotlb_init_io_tlb_mem, for the io_tlb_mem struct
>>> initialization to make the code reusable.
>>>
>>> Signed-off-by:
The min_page_size is only needed for pages inserted into the GTT, and
for our paging structures we only need at most 4K bytes, so simply
ignore the min_page_size restrictions here, otherwise we might see some
severe overallocation on some devices.
v2(Thomas): add some commentary
Signed-off-by:
For some specialised objects we might need something larger than the
regions min_page_size due to some hw restriction, and slightly more
hairy is needing something smaller with the guarantee that such objects
will never be inserted into any GTT, which is the case for the paging
structures.
This
On Tue, 08 Jun 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> All the foo_get_buf_trans_hdmi() functions just reuturn a single table.
> Remove the pointless wrappers.
>
> v2: Handle adl-p
>
> Signed-off-by: Ville Syrjälä
Less is more.
Reviewed-by: Jani Nikula
> ---
>
On Tue, 08 Jun 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The jsl/ehl buf trans functions are needlessly conplicated.
^
My only disappointment here is that now some of the
*_get_combo_buf_trans_edp() functions handle low vswing
After a TTM move or object init we need to update the i915 gem flags and
caching settings to reflect the new placement. Currently caching settings
are not changed during the lifetime of an object, although that might
change moving forward if we run into performance issues or issues with
WC system
For discrete, use TTM for both cached and WC system memory. That means
we currently rely on the TTM memory accounting / shrinker. For cached
system memory we should consider remaining shmem-backed, which can be
implemented from our ttm_tt_populate callback. We can then also reuse our
own very
The object ops i915_GEM_OBJECT_HAS_IOMEM and the object
I915_BO_ALLOC_STRUCT_PAGE flags are considered immutable by
much of our code. Introduce a new mem_flags member to hold these
and make sure checks for these flags being set are either done
under the object lock or with pages properly pinned.
Early implementation of moving system memory for discrete cards over to
TTM. We first add the notion of objects being migratable under the object
lock to i915 gem, and add some asserts to verify that objects are either
locked or pinned when the placement is checked by the gem code.
Patch 2 deals
On Tue, 08 Jun 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> EHL is supposed to use special buf trans values for eDP HBR2+.
> Add such a table.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> .../drm/i915/display/intel_ddi_buf_trans.c| 28 +--
>
On Wed, Jun 23, 2021 at 3:44 PM Christian König
wrote:
>
> Am 23.06.21 um 15:38 schrieb Bas Nieuwenhuizen:
> > On Wed, Jun 23, 2021 at 2:59 PM Christian König
> > wrote:
> >> Am 23.06.21 um 14:18 schrieb Daniel Vetter:
> >>> On Wed, Jun 23, 2021 at 11:45 AM Bas Nieuwenhuizen
> >>> wrote:
>
Similarly to the previous patch for the HDA controller make sure here
that codecs also drop the display power reference during shutdown and
reboot.
This fixes a power ref leaked WARN in i915 during shutdown if the HDA
driver is built with CONFIG_PM=n.
Suggested-by: Takashi Iwai
References:
Make sure the HDA driver's display power reference is released during
shutdown/reboot.
During the shutdown/reboot sequence the pci device core calls the
pm_runtime_resume handler for all devices before calling the driver's
shutdown callback and so the HDA driver's runtime resume callback will
On Wed, Jun 23, 2021 at 10:07:21AM +0200, Takashi Iwai wrote:
> On Tue, 22 Jun 2021 21:58:13 +0200,
> Imre Deak wrote:
> >
> > On Tue, Jun 22, 2021 at 04:18:14PM +0200, Takashi Iwai wrote:
> > > On Mon, 21 Jun 2021 19:44:15 +0200,
> > > Imre Deak wrote:
> > > >
> > > > Make sure the HDA driver's
On 6/23/21 3:38 PM, Matthew Auld wrote:
On 23/06/2021 14:32, Thomas Hellström wrote:
On 6/23/21 1:26 PM, Matthew Auld wrote:
The min_page_size is only needed for pages inserted into the GTT, and
for our paging structures we only need at most 4K bytes, so simply
ignore the min_page_size
On Wed, Jun 23, 2021 at 2:59 PM Christian König
wrote:
>
> Am 23.06.21 um 14:18 schrieb Daniel Vetter:
> > On Wed, Jun 23, 2021 at 11:45 AM Bas Nieuwenhuizen
> > wrote:
> >> On Tue, Jun 22, 2021 at 6:55 PM Daniel Vetter
> >> wrote:
> >>> WARNING: Absolutely untested beyond "gcc isn't dying in
On 23/06/2021 14:32, Thomas Hellström wrote:
On 6/23/21 1:26 PM, Matthew Auld wrote:
The min_page_size is only needed for pages inserted into the GTT, and
for our paging structures we only need at most 4K bytes, so simply
ignore the min_page_size restrictions here, otherwise we might see some
On 6/23/21 1:26 PM, Matthew Auld wrote:
The min_page_size is only needed for pages inserted into the GTT, and
for our paging structures we only need at most 4K bytes, so simply
ignore the min_page_size restrictions here, otherwise we might see some
severe overallocation on some devices.
On Thu, 17 Jun 2021, Daniel Vetter wrote:
> I think stuffing this into topic/core-for-CI is fine, lets wait a bit more
> until mesa and everything is ready with adding the pciids to an official
> tree.
On a related note, I think we'll need rationale documented for each
commit in
On Fri, Jun 18, 2021 at 03:30:28PM +0300, Jani Nikula wrote:
> On Tue, 08 Jun 2021, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > The icl combo phy DP HBR2 is identical to the eDP HBR3 table.
> > Get rid of one redundant copy.
> >
> > Signed-off-by: Ville Syrjälä
>
> Reviewed-by: Jani
1 - 100 of 153 matches
Mail list logo
