[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [RFC,1/2] drm/i915/dmc: Add soc stepping to intel_step

2021-06-29 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915/dmc: Add soc stepping to intel_step URL : https://patchwork.freedesktop.org/series/92039/ State : success == Summary == CI Bug Log - changes from CI_DRM_10290_full -> Patchwork_20490_full

Re: [Intel-gfx] [PATCH V2] drm/i915/ehl: Update MOCS table for EHL

2021-06-29 Thread Lucas De Marchi
On Mon, Jun 21, 2021 at 06:26:22PM +0530, Tejas Upadhyay wrote: From: Matt Roper These extra EHL entries were not behaving as expected without proper flushing implemented in kernel. Commit a679f58d0510 ("drm/i915: Flush pages on acquisition") introduces proper flushing to make it work as

[Intel-gfx] ✗ Fi.CI.IGT: failure for GuC submission / DRM scheduler integration plan + new uAPI

2021-06-29 Thread Patchwork
== Series Details == Series: GuC submission / DRM scheduler integration plan + new uAPI URL : https://patchwork.freedesktop.org/series/92028/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10289_full -> Patchwork_20489_full

Re: [Intel-gfx] [PATCH 11/47] drm/i915/guc: Implement GuC submission tasklet

2021-06-29 Thread Matthew Brost
On Tue, Jun 29, 2021 at 03:04:56PM -0700, John Harrison wrote: > On 6/24/2021 00:04, Matthew Brost wrote: > > Implement GuC submission tasklet for new interface. The new GuC > > interface uses H2G to submit contexts to the GuC. Since H2G use a single > > channel, a single tasklet submits is used

Re: [Intel-gfx] [PATCH 08/47] drm/i915/guc: Add new GuC interface defines and structures

2021-06-29 Thread Matthew Brost
On Tue, Jun 29, 2021 at 02:11:00PM -0700, John Harrison wrote: > On 6/24/2021 00:04, Matthew Brost wrote: > > Add new GuC interface defines and structures while maintaining old ones > > in parallel. > > > > Cc: John Harrison > > Signed-off-by: Matthew Brost > I think there was some difference

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RFC,1/2] drm/i915/dmc: Add soc stepping to intel_step

2021-06-29 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915/dmc: Add soc stepping to intel_step URL : https://patchwork.freedesktop.org/series/92039/ State : success == Summary == CI Bug Log - changes from CI_DRM_10290 -> Patchwork_20490

Re: [Intel-gfx] [PATCH v5 3/3] drm: protect drm_master pointers in drm_lease.c

2021-06-29 Thread Emil Velikov
Hi Desmond, Couple of small suggestions, with those the series is: Reviewed-by: Emil Velikov On Tue, 29 Jun 2021 at 04:38, Desmond Cheong Zhi Xi wrote: > @@ -128,13 +137,20 @@ bool drm_lease_held(struct drm_file *file_priv, int id) > struct drm_master *master; > bool ret; > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [RFC,1/2] drm/i915/dmc: Add soc stepping to intel_step

2021-06-29 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915/dmc: Add soc stepping to intel_step URL : https://patchwork.freedesktop.org/series/92039/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RFC,1/2] drm/i915/dmc: Add soc stepping to intel_step

2021-06-29 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915/dmc: Add soc stepping to intel_step URL : https://patchwork.freedesktop.org/series/92039/ State : warning == Summary == $ dim checkpatch origin/drm-tip 15f341baff60 drm/i915/dmc: Add soc stepping to intel_step 9ab5d8facd04

[Intel-gfx] [RFC 2/2] drm/i915/dmc: Modify stepping/substepping table

2021-06-29 Thread Anusha Srivatsa
Grab the stepping info from RUNTIME_INFO(dev_priv)->step on the dmc side to grab the right blob. Adding the helper intel_get_soc_info() that has SOC stepping lookup table. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 113

[Intel-gfx] [RFC 1/2] drm/i915/dmc: Add soc stepping to intel_step

2021-06-29 Thread Anusha Srivatsa
DMC firmware looks for SOC stepping to load specific firmware. While we maintained a separate lookup table, lets consolidate SOC steppings with gt and display steppings. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_step.c | 46

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Introduce a migrate interface (rev5)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/gem: Introduce a migrate interface (rev5) URL : https://patchwork.freedesktop.org/series/91890/ State : success == Summary == CI Bug Log - changes from CI_DRM_10289_full -> Patchwork_20488_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: address potential UAF bugs with drm_master ptrs (rev2)

2021-06-29 Thread Patchwork
== Series Details == Series: drm: address potential UAF bugs with drm_master ptrs (rev2) URL : https://patchwork.freedesktop.org/series/91969/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10289_full -> Patchwork_20487_full

Re: [Intel-gfx] [PATCH] drm/i915/display/tgl: Implement Wa_14013120569

2021-06-29 Thread Souza, Jose
On Mon, 2021-06-28 at 16:50 -0700, Madhumitha Tolakanahalli Pradeep wrote: > PCH display HPD IRQ is not detected with default filter value. > So, PP_CONTROL is manually reprogrammed. > > Signed-off-by: Madhumitha Tolakanahalli Pradeep > > --- > .../gpu/drm/i915/display/intel_display_power.c

Re: [Intel-gfx] [PATCH 12/47] drm/i915/guc: Add bypass tasklet submission path to GuC

2021-06-29 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Add bypass tasklet submission path to GuC. The tasklet is only used if H2G channel has backpresure. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 37 +++ 1 file

Re: [Intel-gfx] [PATCH 11/47] drm/i915/guc: Implement GuC submission tasklet

2021-06-29 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Implement GuC submission tasklet for new interface. The new GuC interface uses H2G to submit contexts to the GuC. Since H2G use a single channel, a single tasklet submits is used for the submission path. Re-word? 'a single tasklet submits is used...'

Re: [Intel-gfx] [PATCH i-g-t v2] gem_watchdog: Skip test if default request expiry is not compiled in

2021-06-29 Thread Dixit, Ashutosh
On Mon, 24 May 2021 07:38:01 -0700, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Test incorrectly assumes no modparam means default expiry, while in > reality no modparam means old kernel / de-selected feature in which > case test should skip. > > v2: > * New line. (Petri) Reviewed-by:

[Intel-gfx] [CI] PR for new GuC v62.0.3 and HuC v7.9.3 binaries

2021-06-29 Thread John . C . Harrison
The following changes since commit d79c26779d459063b8052b7fe0a48bce4e08d0d9: amdgpu: update vcn firmware for green sardine for 21.20 (2021-06-29 07:26:03 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware guc_62.0_huc_7.9 for you to fetch changes

Re: [Intel-gfx] [PATCH 10/47] drm/i915/guc: Add lrc descriptor context lookup array

2021-06-29 Thread John Harrison
On 6/25/2021 10:26, Matthew Brost wrote: On Fri, Jun 25, 2021 at 03:17:51PM +0200, Michal Wajdeczko wrote: On 24.06.2021 09:04, Matthew Brost wrote: Add lrc descriptor context lookup array which can resolve the intel_context from the lrc descriptor index. In addition to lookup, it can

Re: [Intel-gfx] [PATCH 08/47] drm/i915/guc: Add new GuC interface defines and structures

2021-06-29 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Add new GuC interface defines and structures while maintaining old ones in parallel. Cc: John Harrison Signed-off-by: Matthew Brost I think there was some difference of opinion over whether these additions should be squashed in to the specific patches

[Intel-gfx] ✓ Fi.CI.BAT: success for GuC submission / DRM scheduler integration plan + new uAPI

2021-06-29 Thread Patchwork
== Series Details == Series: GuC submission / DRM scheduler integration plan + new uAPI URL : https://patchwork.freedesktop.org/series/92028/ State : success == Summary == CI Bug Log - changes from CI_DRM_10289 -> Patchwork_20489 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GuC submission / DRM scheduler integration plan + new uAPI

2021-06-29 Thread Patchwork
== Series Details == Series: GuC submission / DRM scheduler integration plan + new uAPI URL : https://patchwork.freedesktop.org/series/92028/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9534ae8c12da drm/doc/rfc: i915 GuC submission / DRM scheduler -:44:

Re: [Intel-gfx] [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Das, Nirmoy
LGTM Acked-by: Nirmoy Das On 6/29/2021 3:58 PM, Thomas Zimmermann wrote: Print the name of the DRM driver when taking over fbdev devices. Makes the output to dmesg more consistent. Note that the driver name is only used for printing a string to the kernel log. No UAPI is affected by this

[Intel-gfx] [PATCH 0/2] GuC submission / DRM scheduler integration plan + new uAPI

2021-06-29 Thread Matthew Brost
Subject and patches say it all. v2: Address comments, patches have details of changes v3: Address comments, patches have details of changes v4: Address comments, patches have details of changes v5: Fix checkpatch and docs warnings Signed-off-by: Matthew Brost Matthew Brost (2): drm/doc/rfc:

[Intel-gfx] [PATCH 1/2] drm/doc/rfc: i915 GuC submission / DRM scheduler

2021-06-29 Thread Matthew Brost
Add entry for i915 GuC submission / DRM scheduler integration plan. Follow up patch with details of new parallel submission uAPI to come. v2: (Daniel Vetter) - Expand explaination of why bonding isn't supported for GuC submission - CC some of the DRM scheduler maintainers - Add

[Intel-gfx] [PATCH 2/2] drm/doc/rfc: i915 new parallel submission uAPI plan

2021-06-29 Thread Matthew Brost
Add entry for i915 new parallel submission uAPI plan. v2: (Daniel Vetter): - Expand logical order explaination - Add dummy header - Only allow N BBs in execbuf IOCTL - Configure parallel submission per slot not per gem context v3: (Marcin Ślusarz): - Lot's of typos / bad english fixed

[Intel-gfx] [PULL] drm-intel-next-fixes

2021-06-29 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-fixes-2021-06-29: The biggest fix is the restoration of mmap ioctl for gen12 integrated parts which lack was breaking ADL-P with media stack. Besides that a small selftest fix and a theoretical overflow on i915->pipe_to_crtc_mapping. Thanks, Rodrigo.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Introduce a migrate interface (rev5)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/gem: Introduce a migrate interface (rev5) URL : https://patchwork.freedesktop.org/series/91890/ State : success == Summary == CI Bug Log - changes from CI_DRM_10289 -> Patchwork_20488 Summary ---

Re: [Intel-gfx] [PATCH v5 1/3] drm/i915/gem: Implement object migration

2021-06-29 Thread Matthew Auld
On Tue, 29 Jun 2021 at 16:50, Daniel Vetter wrote: > > On Tue, Jun 29, 2021 at 05:12:01PM +0200, Thomas Hellström wrote: > > Introduce an interface to migrate objects between regions. > > This is primarily intended to migrate objects to LMEM for display and > > to SYSTEM for dma-buf, but might be

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gem: Introduce a migrate interface (rev5)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/gem: Introduce a migrate interface (rev5) URL : https://patchwork.freedesktop.org/series/91890/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Introduce a migrate interface (rev5)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/gem: Introduce a migrate interface (rev5) URL : https://patchwork.freedesktop.org/series/91890/ State : warning == Summary == $ dim checkpatch origin/drm-tip e12a3001cec3 drm/i915/gem: Implement object migration 7f6ae4d61ef2 drm/i915/gem: Introduce a

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Patchwork
== Series Details == Series: drm/aperture: Pass DRM driver structure instead of driver name URL : https://patchwork.freedesktop.org/series/92015/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10287_full -> Patchwork_20486_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: address potential UAF bugs with drm_master ptrs (rev2)

2021-06-29 Thread Patchwork
== Series Details == Series: drm: address potential UAF bugs with drm_master ptrs (rev2) URL : https://patchwork.freedesktop.org/series/91969/ State : success == Summary == CI Bug Log - changes from CI_DRM_10289 -> Patchwork_20487 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: address potential UAF bugs with drm_master ptrs (rev2)

2021-06-29 Thread Patchwork
== Series Details == Series: drm: address potential UAF bugs with drm_master ptrs (rev2) URL : https://patchwork.freedesktop.org/series/91969/ State : warning == Summary == $ dim checkpatch origin/drm-tip 74cef89ae027 drm: avoid circular locks in drm_mode_getconnector cb2470da87f5 drm: add a

Re: [Intel-gfx] [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Neil Armstrong
Hi, On 29/06/2021 15:58, Thomas Zimmermann wrote: > Print the name of the DRM driver when taking over fbdev devices. Makes > the output to dmesg more consistent. Note that the driver name is only > used for printing a string to the kernel log. No UAPI is affected by this > change. > >

Re: [Intel-gfx] [PATCH] drm/i915: Drop all references to DRM IRQ midlayer

2021-06-29 Thread Daniel Vetter
On Tue, Jun 29, 2021 at 6:11 PM Ville Syrjälä wrote: > > On Fri, Jun 25, 2021 at 10:47:40AM +0200, Thomas Zimmermann wrote: > > Remove all references to DRM's IRQ midlayer. > > > > The code in xcs_resume() probably didn't work as intended. It uses > > struct drm_device.irq, which is allocated to

Re: [Intel-gfx] [PATCH] drm/i915: Drop all references to DRM IRQ midlayer

2021-06-29 Thread Ville Syrjälä
On Fri, Jun 25, 2021 at 10:47:40AM +0200, Thomas Zimmermann wrote: > Remove all references to DRM's IRQ midlayer. > > The code in xcs_resume() probably didn't work as intended. It uses > struct drm_device.irq, which is allocated to 0, but never initialized > by i915 to the device's interrupt

Re: [Intel-gfx] [PATCH v5 3/3] drm: protect drm_master pointers in drm_lease.c

2021-06-29 Thread Daniel Vetter
On Tue, Jun 29, 2021 at 11:37:06AM +0800, Desmond Cheong Zhi Xi wrote: > Currently, direct copies of drm_file->master pointers should be > protected by drm_device.master_mutex when being dereferenced. This is > because drm_file->master is not invariant for the lifetime of > drm_file. If drm_file

Re: [Intel-gfx] [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Chen-Yu Tsai
On Tue, Jun 29, 2021 at 9:58 PM Thomas Zimmermann wrote: > > Print the name of the DRM driver when taking over fbdev devices. Makes > the output to dmesg more consistent. Note that the driver name is only > used for printing a string to the kernel log. No UAPI is affected by this > change. > >

Re: [Intel-gfx] [PATCH v2] drm/i915/display: replace boilerplate code with helper macros

2021-06-29 Thread Ville Syrjälä
On Sat, Jun 26, 2021 at 03:32:27AM -0400, Hamza Mahfooz wrote: > As per commit 22be87401289 ("drm: TODO: Add DRM_MODESET_LOCK_ALL* > conversion to todo.rst"), > drm_modeset_lock_all()/drm_modeset_unlock_all() and boilerplate code > surrounding instances of drm_modeset_lock_all_ctx() with a local

Re: [Intel-gfx] [PATCH v5 1/3] drm/i915/gem: Implement object migration

2021-06-29 Thread Daniel Vetter
On Tue, Jun 29, 2021 at 05:12:01PM +0200, Thomas Hellström wrote: > Introduce an interface to migrate objects between regions. > This is primarily intended to migrate objects to LMEM for display and > to SYSTEM for dma-buf, but might be reused in one form or another for > performance-based

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Patchwork
== Series Details == Series: drm/aperture: Pass DRM driver structure instead of driver name URL : https://patchwork.freedesktop.org/series/92015/ State : success == Summary == CI Bug Log - changes from CI_DRM_10287 -> Patchwork_20486

Re: [Intel-gfx] [PATCH] drm/i915/jsl: Remove require_force_probe protection

2021-06-29 Thread Rodrigo Vivi
On Tue, Jun 29, 2021 at 11:17:55AM -0400, Rodrigo Vivi wrote: > On Tue, Jun 29, 2021 at 04:23:56PM +0530, Tejas Upadhyay wrote: > > Removing force probe protection from JSL platform. Did > > not observe warnings, errors, flickering or any visual > > defects while doing ordinary tasks like browsing

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

2021-06-29 Thread Rodrigo Vivi
On Tue, Jun 29, 2021 at 11:18:09AM -0400, Rodrigo Vivi wrote: > On Tue, Jun 29, 2021 at 04:19:54PM +0530, Tejas Upadhyay wrote: > > Removing force probe protection from EHL platform. Did > > not observe warnings, errors, flickering or any visual > > defects while doing ordinary tasks like browsing

Re: [Intel-gfx] [PATCH] drm/i915/jsl: Remove require_force_probe protection

2021-06-29 Thread Rodrigo Vivi
On Tue, Jun 29, 2021 at 04:23:56PM +0530, Tejas Upadhyay wrote: > Removing force probe protection from JSL platform. Did > not observe warnings, errors, flickering or any visual > defects while doing ordinary tasks like browsing and > editing documents in a two monitor setup. > > For more info

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

2021-06-29 Thread Rodrigo Vivi
On Tue, Jun 29, 2021 at 04:19:54PM +0530, Tejas Upadhyay wrote: > Removing force probe protection from EHL platform. Did > not observe warnings, errors, flickering or any visual > defects while doing ordinary tasks like browsing and > editing documents in a two monitor setup. > > For more info

[Intel-gfx] [PATCH v5 3/3] drm/i915/display: Migrate objects to LMEM if possible for display

2021-06-29 Thread Thomas Hellström
Objects intended to be used as display framebuffers must reside in LMEM for discrete. If they happen to not do that, migrate them to LMEM before pinning. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/display/intel_display.c | 5 -

[Intel-gfx] [PATCH v5 2/3] drm/i915/gem: Introduce a selftest for the gem object migrate functionality

2021-06-29 Thread Thomas Hellström
From: Matthew Auld A selftest for the gem object migrate functionality. Slightly adapted from the original by Matthew to the new interface and new fill blit code. v4: - Initialize buffers and check contents after migration (Suggested by Matthew Auld) - Perform async migration (if implemented)

[Intel-gfx] [PATCH v5 1/3] drm/i915/gem: Implement object migration

2021-06-29 Thread Thomas Hellström
Introduce an interface to migrate objects between regions. This is primarily intended to migrate objects to LMEM for display and to SYSTEM for dma-buf, but might be reused in one form or another for performance-based migration. v2: - Verify that the memory region given as an id really exists.

[Intel-gfx] [PATCH v5 0/3] drm/i915/gem: Introduce a migrate interface

2021-06-29 Thread Thomas Hellström
We want to be able to explicitly migrate objects between gem memory regions, initially for display and dma-buf, but there might be more use-cases coming up. Introduce a gem migrate interface, add a selftest and use it for display fb pinning and dma-buf mapping. This series should make

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Patchwork
== Series Details == Series: drm/aperture: Pass DRM driver structure instead of driver name URL : https://patchwork.freedesktop.org/series/92015/ State : warning == Summary == $ dim checkpatch origin/drm-tip bdaa421adb16 drm/aperture: Pass DRM driver structure instead of driver name -:310:

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable

2021-06-29 Thread Jani Nikula
On Tue, 29 Jun 2021, venkata.sai.patn...@intel.com wrote: > From: Anusha Srivatsa > > DSC can be supported per DP connector. This patch creates > a per connector debugfs node to expose the Input and > Compressed BPP. > > The same node can be used from userspace to force > DSC to a certain BPP. >

[Intel-gfx] [PATCH v5 3/3] drm: protect drm_master pointers in drm_lease.c

2021-06-29 Thread Desmond Cheong Zhi Xi
Currently, direct copies of drm_file->master pointers should be protected by drm_device.master_mutex when being dereferenced. This is because drm_file->master is not invariant for the lifetime of drm_file. If drm_file is not the creator of master, then drm_file->is_master is false, and a call to

[Intel-gfx] [PATCH v5 2/3] drm: add a locked version of drm_is_current_master

2021-06-29 Thread Desmond Cheong Zhi Xi
While checking the master status of the DRM file in drm_is_current_master(), the device's master mutex should be held. Without the mutex, the pointer fpriv->master may be freed concurrently by another process calling drm_setmaster_ioctl(). This could lead to use-after-free errors when the pointer

[Intel-gfx] [PATCH v5 0/3] drm: address potential UAF bugs with drm_master ptrs

2021-06-29 Thread Desmond Cheong Zhi Xi
This patch series addresses potential use-after-free errors when dereferencing pointers to struct drm_master. These were identified after one such bug was caught by Syzbot in drm_getunique(): https://syzkaller.appspot.com/bug?id=148d2f1dfac64af52ffd27b661981a540724f803 The series is broken up

[Intel-gfx] [PATCH v5 1/3] drm: avoid circular locks in drm_mode_getconnector

2021-06-29 Thread Desmond Cheong Zhi Xi
In preparation for a future patch to take a lock on drm_device.master_mutex inside drm_is_current_master(), we first move the call to drm_is_current_master() in drm_mode_getconnector out from the section locked by >mode_config.mutex. This avoids creating a circular lock dependency. Failing to

[Intel-gfx] [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Thomas Zimmermann
Print the name of the DRM driver when taking over fbdev devices. Makes the output to dmesg more consistent. Note that the driver name is only used for printing a string to the kernel log. No UAPI is affected by this change. Signed-off-by: Thomas Zimmermann ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/jsl: Remove require_force_probe protection (rev2)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/jsl: Remove require_force_probe protection (rev2) URL : https://patchwork.freedesktop.org/series/82710/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10285_full -> Patchwork_20484_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ehl: Remove require_force_probe protection (rev2)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Remove require_force_probe protection (rev2) URL : https://patchwork.freedesktop.org/series/82413/ State : success == Summary == CI Bug Log - changes from CI_DRM_10285_full -> Patchwork_20483_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/jsl: Remove require_force_probe protection (rev2)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/jsl: Remove require_force_probe protection (rev2) URL : https://patchwork.freedesktop.org/series/82710/ State : success == Summary == CI Bug Log - changes from CI_DRM_10285 -> Patchwork_20484 Summary

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gem: Introduce a migrate interface (rev4)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/gem: Introduce a migrate interface (rev4) URL : https://patchwork.freedesktop.org/series/91890/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

Re: [Intel-gfx] [PATCH v4 1/3] drm/i915/gem: Implement object migration

2021-06-29 Thread Matthew Auld
On Tue, 29 Jun 2021 at 12:37, Thomas Hellström wrote: > > Introduce an interface to migrate objects between regions. > This is primarily intended to migrate objects to LMEM for display and > to SYSTEM for dma-buf, but might be reused in one form or another for > performance-based migration. > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: Remove require_force_probe protection (rev2)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Remove require_force_probe protection (rev2) URL : https://patchwork.freedesktop.org/series/82413/ State : success == Summary == CI Bug Log - changes from CI_DRM_10285 -> Patchwork_20483 Summary

Re: [Intel-gfx] [PATCH] drm/i915/xelpd: Enabling dithering after the CC1

2021-06-29 Thread Jani Nikula
Cc: Ville and Daniel for archeology... On Fri, 11 Jun 2021, Nischal Varide wrote: > If the panel is 12bpc then Dithering is not enabled in the Legacy > dithering block , instead its Enabled after the C1 CC1 pipe post > color space conversion.For a 6bpc pannel Dithering is enabled in > Legacy

Re: [Intel-gfx] [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-29 Thread Werner Sembach
Am 29.06.21 um 13:17 schrieb Pekka Paalanen: > On Tue, 29 Jun 2021 08:12:54 + > Simon Ser wrote: > >> On Tuesday, June 22nd, 2021 at 09:15, Pekka Paalanen >> wrote: >> >>> yes, I think this makes sense, even if it is a property that one can't >>> tell for sure what it does before hand.

[Intel-gfx] [PATCH v4 3/3] drm/i915/display: Migrate objects to LMEM if possible for display

2021-06-29 Thread Thomas Hellström
Objects intended to be used as display framebuffers must reside in LMEM for discrete. If they happen to not do that, migrate them to LMEM before pinning. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/display/intel_display.c | 5 -

Re: [Intel-gfx] [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-29 Thread Werner Sembach
Am 29.06.21 um 13:17 schrieb Pekka Paalanen: > On Tue, 29 Jun 2021 08:12:54 + > Simon Ser wrote: > >> On Tuesday, June 22nd, 2021 at 09:15, Pekka Paalanen >> wrote: >> >>> yes, I think this makes sense, even if it is a property that one can't >>> tell for sure what it does before hand. >>>

[Intel-gfx] [PATCH v4 2/3] drm/i915/gem: Introduce a selftest for the gem object migrate functionality

2021-06-29 Thread Thomas Hellström
From: Matthew Auld A selftest for the gem object migrate functionality. Slightly adapted from the original by Matthew to the new interface and new fill blit code. v4: - Initialize buffers and check contents after migration (Suggested by Matthew Auld) - Perform async migration (if implemented)

[Intel-gfx] [PATCH v4 1/3] drm/i915/gem: Implement object migration

2021-06-29 Thread Thomas Hellström
Introduce an interface to migrate objects between regions. This is primarily intended to migrate objects to LMEM for display and to SYSTEM for dma-buf, but might be reused in one form or another for performance-based migration. v2: - Verify that the memory region given as an id really exists.

[Intel-gfx] [PATCH v4 0/3] drm/i915/gem: Introduce a migrate interface

2021-06-29 Thread Thomas Hellström
We want to be able to explicitly migrate objects between gem memory regions, initially for display and dma-buf, but there might be more use-cases coming up. Introduce a gem migrate interface, add a selftest and use it for display fb pinning and dma-buf mapping. This series should make

Re: [Intel-gfx] [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-29 Thread Pekka Paalanen
On Tue, 29 Jun 2021 08:12:54 + Simon Ser wrote: > On Tuesday, June 22nd, 2021 at 09:15, Pekka Paalanen > wrote: > > > yes, I think this makes sense, even if it is a property that one can't > > tell for sure what it does before hand. > > > > Using a pair of properties, preference and

[Intel-gfx] [PATCH] drm/i915/jsl: Remove require_force_probe protection

2021-06-29 Thread Tejas Upadhyay
Removing force probe protection from JSL platform. Did not observe warnings, errors, flickering or any visual defects while doing ordinary tasks like browsing and editing documents in a two monitor setup. For more info drm-tip idle run results :

Re: [Intel-gfx] [PATCH v4 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-29 Thread Werner Sembach
Am 28.06.21 um 19:03 schrieb Werner Sembach: > Am 18.06.21 um 11:11 schrieb Werner Sembach: >> Add a new general drm property "active bpc" which can be used by graphic >> drivers to report the applied bit depth per pixel back to userspace. >> >> While "max bpc" can be used to change the color

[Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

2021-06-29 Thread Tejas Upadhyay
Removing force probe protection from EHL platform. Did not observe warnings, errors, flickering or any visual defects while doing ordinary tasks like browsing and editing documents in a two monitor setup. For more info drm-tip idle run results :

Re: [Intel-gfx] [PATCH v4 19/27] drm/stm: Don't set struct drm_device.irq_enabled

2021-06-29 Thread yannick Fertre
Hello Thomas, thanks for the patch. Tested-by: Yannick Fertre Best regards On 6/25/21 10:22 AM, Thomas Zimmermann wrote: The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in stm. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent

Re: [Intel-gfx] [PATCH v3 4/5] drm/i915/gem: Fix same-driver-another-instance dma-buf export

2021-06-29 Thread Thomas Hellström
On 6/29/21 10:43 AM, Daniel Vetter wrote: On Mon, Jun 28, 2021 at 07:45:31PM +, Ruhl, Michael J wrote: -Original Message- From: Thomas Hellström Sent: Monday, June 28, 2021 10:46 AM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Auld, Matthew ;

Re: [Intel-gfx] [PATCH 1/4] Klock work Fix for NULL dereferencing in i915_gem_ttm.c

2021-06-29 Thread Ramalingam C
On 2021-06-28 at 20:08:26 +0530, Bommu Krishnaiah wrote: > Signed-off-by: Bommu Krishnaiah > Cc: Maarten Lankhorst > --- > drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c >

Re: [Intel-gfx] [PATCH 2/4] Klock work Fix for NULL dereferencing in i915_gem_mman.c

2021-06-29 Thread Ramalingam C
On 2021-06-28 at 20:08:27 +0530, Bommu Krishnaiah wrote: > Signed-off-by: Bommu Krishnaiah > Cc: Abdiel Janulgue > --- > drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/dsc: Set BPP in the kernel (rev2)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/display/dsc: Set BPP in the kernel (rev2) URL : https://patchwork.freedesktop.org/series/91917/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10285_full -> Patchwork_20482_full Summary

Re: [Intel-gfx] [PATCH 4/4] Klock work Fix for uninitialized array intel_migrate.c

2021-06-29 Thread Ramalingam C
On 2021-06-28 at 20:08:29 +0530, Bommu Krishnaiah wrote: > Signed-off-by: Bommu Krishnaiah > Cc: Chris Wilson > --- > drivers/gpu/drm/i915/gt/intel_migrate.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c >

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915/gem: Implement object migration

2021-06-29 Thread Daniel Vetter
On Mon, Jun 28, 2021 at 04:46:22PM +0200, Thomas Hellström wrote: > Introduce an interface to migrate objects between regions. > This is primarily intended to migrate objects to LMEM for display and > to SYSTEM for dma-buf, but might be reused in one form or another for > performance-based

Re: [Intel-gfx] [PATCH v3 4/5] drm/i915/gem: Fix same-driver-another-instance dma-buf export

2021-06-29 Thread Daniel Vetter
On Mon, Jun 28, 2021 at 07:45:31PM +, Ruhl, Michael J wrote: > >-Original Message- > >From: Thomas Hellström > >Sent: Monday, June 28, 2021 10:46 AM > >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > >Cc: Auld, Matthew ; > >maarten.lankho...@linux.intel.com;

Re: [Intel-gfx] [PATCH 0/4] The Following Patches are to Fix the Critical KclockWork Errors in i915_gem and gt

2021-06-29 Thread Ramalingam C
each patch's commit message is empty except for signed-off and cc. Please provide corresponding KclockWork Errors that is getting fixed. Ram. On 2021-06-28 at 20:08:25 +0530, Bommu Krishnaiah wrote: > Klock work Fix for NULL dereferencing in i915_gem_ttm.c > original issue statement "Pointer

Re: [Intel-gfx] [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-29 Thread Simon Ser
On Tuesday, June 22nd, 2021 at 09:15, Pekka Paalanen wrote: > yes, I think this makes sense, even if it is a property that one can't > tell for sure what it does before hand. > > Using a pair of properties, preference and active, to ask for something > and then check what actually worked is

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/dsc: Set BPP in the kernel (rev2)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/display/dsc: Set BPP in the kernel (rev2) URL : https://patchwork.freedesktop.org/series/91917/ State : success == Summary == CI Bug Log - changes from CI_DRM_10285 -> Patchwork_20482 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display/dsc: Set BPP in the kernel (rev2)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/display/dsc: Set BPP in the kernel (rev2) URL : https://patchwork.freedesktop.org/series/91917/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dsc: Set BPP in the kernel (rev2)

2021-06-29 Thread Patchwork
== Series Details == Series: drm/i915/display/dsc: Set BPP in the kernel (rev2) URL : https://patchwork.freedesktop.org/series/91917/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8c10d57a92b5 drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable -:71:

[Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable

2021-06-29 Thread venkata . sai . patnana
From: Anusha Srivatsa DSC can be supported per DP connector. This patch creates a per connector debugfs node to expose the Input and Compressed BPP. The same node can be used from userspace to force DSC to a certain BPP. force_dsc_bpp is written through this debugfs node to force DSC BPP to

[Intel-gfx] [PATCH v2 2/2] drm/i915/display/dsc: Set BPP in the kernel

2021-06-29 Thread venkata . sai . patnana
From: Anusha Srivatsa Set compress BPP in kernel while connector DP or eDP Cc: Vandita Kulkarni Cc: Navare Manasi D Signed-off-by: Anusha Srivatsa Signed-off-by: Patnana Venkata Sai --- drivers/gpu/drm/i915/display/intel_dp.c | 23 ++- 1 file changed, 18 insertions(+),

[Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel

2021-06-29 Thread venkata . sai . patnana
From: Patnana Venkata Sai DSC can be supported per DP connector. This patch creates a per connector debugfs node to expose the Input and Compressed BPP. The same node can be used from userspace to force DSC to a certain BPP. force_dsc_bpp is written through this debugfs node to force DSC BPP