[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dmc: Use RUNTIME_INFO->stp for DMC

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Use RUNTIME_INFO->stp for DMC URL : https://patchwork.freedesktop.org/series/92088/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10295_full -> Patchwork_20500_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg1: Compute MEM Bandwidth using MCHBAR

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Compute MEM Bandwidth using MCHBAR URL : https://patchwork.freedesktop.org/series/92094/ State : success == Summary == CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20501 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/dg1: Correctly map DPLLs during state readout

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915/display/dg1: Correctly map DPLLs during state readout URL : https://patchwork.freedesktop.org/series/92086/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10295_full -> Patchwork_20499_full

[Intel-gfx] [PATCH 1/1] drm/i915/dg1: Compute MEM Bandwidth using MCHBAR

2021-06-30 Thread Lucas De Marchi
From: Clint Taylor The PUNIT FW is currently returning 0 for all memory bandwidth parameters. Read the values directly from MCHBAR offsets 0x5918 and 0x4000(4). v2 (Lucas): tidy up checking for ret slightly v3 (Lucas): - Squash change to double the memory bandwidth based on MCHBAR

[Intel-gfx] [PATCH 0/1] drm/i915/dg1: Compute MEM Bandwidth using MCHBAR

2021-06-30 Thread Lucas De Marchi
Replacement for https://patchwork.freedesktop.org/series/91848/ Those 2 commits are now squashed and received a round of cleanup. My changes were mostly cosmetic, so I'm leaving my r-b there. It would be good to get an ack though. Clint Taylor (1): drm/i915/dg1: Compute MEM Bandwidth using

[Intel-gfx] ✗ Fi.CI.IGT: failure for Update to new HuC for TGL+ and enable GuC/HuC on ADL-P (rev2)

2021-06-30 Thread Patchwork
== Series Details == Series: Update to new HuC for TGL+ and enable GuC/HuC on ADL-P (rev2) URL : https://patchwork.freedesktop.org/series/91932/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10295_full -> Patchwork_20498_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Fix -EDEADLK handling regression

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix -EDEADLK handling regression URL : https://patchwork.freedesktop.org/series/92082/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10295_full -> Patchwork_20497_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for New uAPI drm properties for color management (rev3)

2021-06-30 Thread Patchwork
== Series Details == Series: New uAPI drm properties for color management (rev3) URL : https://patchwork.freedesktop.org/series/91523/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10295_full -> Patchwork_20496_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: address potential UAF bugs with drm_master ptrs

2021-06-30 Thread Patchwork
== Series Details == Series: drm: address potential UAF bugs with drm_master ptrs URL : https://patchwork.freedesktop.org/series/92076/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10295_full -> Patchwork_20495_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/vgem: Use 256B aligned pitch

2021-06-30 Thread Patchwork
== Series Details == Series: drm/vgem: Use 256B aligned pitch URL : https://patchwork.freedesktop.org/series/92067/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10295_full -> Patchwork_20492_full Summary ---

Re: [Intel-gfx] [PATCH 5/7] drm/i915/guc: Add stall timer to non blocking CTB send function

2021-06-30 Thread Matthew Brost
On Thu, Jul 01, 2021 at 01:23:36AM +0200, Michal Wajdeczko wrote: > > > On 28.06.2021 01:14, Matthew Brost wrote: > > Implement a stall timer which fails H2G CTBs once a period of time > > with no forward progress is reached to prevent deadlock. > > > > v2: > > (Michal) > > - Improve error

Re: [Intel-gfx] [PATCH 4/7] drm/i915/guc: Add non blocking CTB send function

2021-06-30 Thread Matthew Brost
On Thu, Jul 01, 2021 at 12:52:58AM +0200, Michal Wajdeczko wrote: > > > On 28.06.2021 01:14, Matthew Brost wrote: > > Add non blocking CTB send function, intel_guc_send_nb. GuC submission > > will send CTBs in the critical path and does not need to wait for these > > CTBs to complete before

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC

2021-06-30 Thread Lucas De Marchi
On Wed, Jun 30, 2021 at 05:15:00PM -0700, Jose Souza wrote: On Wed, 2021-06-30 at 17:01 -0700, Lucas De Marchi wrote: Typo: RUNTIME_INFO->stp On Wed, Jun 30, 2021 at 04:06:24PM -0700, Anusha Srivatsa wrote: > On the dmc side,we maintain a lookup table with different display >

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC

2021-06-30 Thread Souza, Jose
On Wed, 2021-06-30 at 17:01 -0700, Lucas De Marchi wrote: > Typo: RUNTIME_INFO->stp > > On Wed, Jun 30, 2021 at 04:06:24PM -0700, Anusha Srivatsa wrote: > > On the dmc side,we maintain a lookup table with different display > > stepping-substepping combinations. > > > > Instead of adding new

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: IRQ fixes (rev2)

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915: IRQ fixes (rev2) URL : https://patchwork.freedesktop.org/series/92053/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10295_full -> Patchwork_20491_full Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC

2021-06-30 Thread Lucas De Marchi
Typo: RUNTIME_INFO->stp On Wed, Jun 30, 2021 at 04:06:24PM -0700, Anusha Srivatsa wrote: On the dmc side,we maintain a lookup table with different display stepping-substepping combinations. Instead of adding new table for every new platform, lets ues the stepping info from

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Use RUNTIME_INFO->stp for DMC

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Use RUNTIME_INFO->stp for DMC URL : https://patchwork.freedesktop.org/series/92088/ State : success == Summary == CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20500 Summary ---

Re: [Intel-gfx] [PATCH 5/7] drm/i915/guc: Add stall timer to non blocking CTB send function

2021-06-30 Thread Michal Wajdeczko
On 28.06.2021 01:14, Matthew Brost wrote: > Implement a stall timer which fails H2G CTBs once a period of time > with no forward progress is reached to prevent deadlock. > > v2: > (Michal) > - Improve error message in ct_deadlock() > - Set broken when ct_deadlock() returns true > -

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dmc: Use RUNTIME_INFO->stp for DMC

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Use RUNTIME_INFO->stp for DMC URL : https://patchwork.freedesktop.org/series/92088/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: Use RUNTIME_INFO->stp for DMC

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Use RUNTIME_INFO->stp for DMC URL : https://patchwork.freedesktop.org/series/92088/ State : warning == Summary == $ dim checkpatch origin/drm-tip dc34e57ce634 drm/i915/dmc: Use RUNTIME_INFO->stp for DMC -:29: CHECK:BRACES: Blank lines aren't

[Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC

2021-06-30 Thread Anusha Srivatsa
On the dmc side,we maintain a lookup table with different display stepping-substepping combinations. Instead of adding new table for every new platform, lets ues the stepping info from RUNTIME_INFO(dev_priv)->step Adding the helper intel_get_display_step(). Cc: Lucas De Marchi Signed-off-by:

Re: [Intel-gfx] [PATCH 4/7] drm/i915/guc: Add non blocking CTB send function

2021-06-30 Thread Michal Wajdeczko
On 28.06.2021 01:14, Matthew Brost wrote: > Add non blocking CTB send function, intel_guc_send_nb. GuC submission > will send CTBs in the critical path and does not need to wait for these > CTBs to complete before moving on, hence the need for this new function. > > The non-blocking CTB now

Re: [Intel-gfx] [PATCH] drm/i915/display/dg1: Correctly map DPLLs during state readout

2021-06-30 Thread Lucas De Marchi
On Wed, Jun 30, 2021 at 02:05:22PM -0700, Jose Souza wrote: _DG1_DPCLKA0_CFGCR0 maps between DPLL 0 and 1 with one bit for phy A and B while _DG1_DPCLKA1_CFGCR0 maps between DPLL 2 and 3 with one bit for phy C and D. Reusing _cnl_ddi_get_pll() don't take that into cosideration returing DPLL 0

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/dg1: Correctly map DPLLs during state readout

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915/display/dg1: Correctly map DPLLs during state readout URL : https://patchwork.freedesktop.org/series/92086/ State : success == Summary == CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20499

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dg1: Correctly map DPLLs during state readout

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915/display/dg1: Correctly map DPLLs during state readout URL : https://patchwork.freedesktop.org/series/92086/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5fce8912a42d drm/i915/display/dg1: Correctly map DPLLs during state readout -:23:

[Intel-gfx] [PATCH] drm/i915/display/dg1: Correctly map DPLLs during state readout

2021-06-30 Thread José Roberto de Souza
_DG1_DPCLKA0_CFGCR0 maps between DPLL 0 and 1 with one bit for phy A and B while _DG1_DPCLKA1_CFGCR0 maps between DPLL 2 and 3 with one bit for phy C and D. Reusing _cnl_ddi_get_pll() don't take that into cosideration returing DPLL 0 and 1 for phy C and D. That is a regression introduced in the

[Intel-gfx] ✓ Fi.CI.BAT: success for Update to new HuC for TGL+ and enable GuC/HuC on ADL-P (rev2)

2021-06-30 Thread Patchwork
== Series Details == Series: Update to new HuC for TGL+ and enable GuC/HuC on ADL-P (rev2) URL : https://patchwork.freedesktop.org/series/91932/ State : success == Summary == CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20498

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Fix -EDEADLK handling regression

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix -EDEADLK handling regression URL : https://patchwork.freedesktop.org/series/92082/ State : success == Summary == CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20497 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for New uAPI drm properties for color management (rev3)

2021-06-30 Thread Patchwork
== Series Details == Series: New uAPI drm properties for color management (rev3) URL : https://patchwork.freedesktop.org/series/91523/ State : success == Summary == CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20496 Summary ---

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2021-06-30 Thread Rodrigo Vivi
On Wed, Jun 30, 2021 at 01:05:35PM +0300, Jani Nikula wrote: > On Tue, 29 Jun 2021, Rodrigo Vivi wrote: > > Hi Dave and Daniel, > > > > Here goes drm-intel-next-fixes-2021-06-29: > > > > The biggest fix is the restoration of mmap ioctl for gen12 integrated parts > > which lack was breaking ADL-P

Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+

2021-06-30 Thread John Harrison
On 6/30/2021 01:22, Martin Peres wrote: On 24/06/2021 10:05, Matthew Brost wrote: From: Daniele Ceraolo Spurio Unblock GuC submission on Gen11+ platforms. Signed-off-by: Michal Wajdeczko Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Matthew Brost ---  

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for New uAPI drm properties for color management (rev3)

2021-06-30 Thread Patchwork
== Series Details == Series: New uAPI drm properties for color management (rev3) URL : https://patchwork.freedesktop.org/series/91523/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for New uAPI drm properties for color management (rev3)

2021-06-30 Thread Patchwork
== Series Details == Series: New uAPI drm properties for color management (rev3) URL : https://patchwork.freedesktop.org/series/91523/ State : warning == Summary == $ dim checkpatch origin/drm-tip de5b09605b88 drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check -:32:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: address potential UAF bugs with drm_master ptrs

2021-06-30 Thread Patchwork
== Series Details == Series: drm: address potential UAF bugs with drm_master ptrs URL : https://patchwork.freedesktop.org/series/92076/ State : success == Summary == CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20495 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: address potential UAF bugs with drm_master ptrs

2021-06-30 Thread Patchwork
== Series Details == Series: drm: address potential UAF bugs with drm_master ptrs URL : https://patchwork.freedesktop.org/series/92076/ State : warning == Summary == $ dim checkpatch origin/drm-tip 13940bd0a105 drm: avoid circular locks in drm_mode_getconnector dbd6d7ef5160 drm: avoid

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: dma-buf fixes for migration

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915/gem: dma-buf fixes for migration URL : https://patchwork.freedesktop.org/series/92070/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20494 Summary ---

Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+

2021-06-30 Thread Matthew Brost
On Wed, Jun 30, 2021 at 11:22:38AM +0300, Martin Peres wrote: > > > On 24/06/2021 10:05, Matthew Brost wrote: > > From: Daniele Ceraolo Spurio > > > > Unblock GuC submission on Gen11+ platforms. > > > > Signed-off-by: Michal Wajdeczko > > Signed-off-by: Daniele Ceraolo Spurio > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: dma-buf fixes for migration

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915/gem: dma-buf fixes for migration URL : https://patchwork.freedesktop.org/series/92070/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3b50433924c8 drm/i915/gem: Make our dma-buf exporter dynamic -:16: WARNING:COMMIT_LOG_LONG_LINE: Possible

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/vgem: Use 256B aligned pitch

2021-06-30 Thread Patchwork
== Series Details == Series: drm/vgem: Use 256B aligned pitch URL : https://patchwork.freedesktop.org/series/92067/ State : success == Summary == CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20492 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: address potential UAF bugs with drm_master ptrs (rev3)

2021-06-30 Thread Patchwork
== Series Details == Series: drm: address potential UAF bugs with drm_master ptrs (rev3) URL : https://patchwork.freedesktop.org/series/91969/ State : failure == Summary == Applying: drm: avoid circular locks in drm_mode_getconnector Applying: drm: add a locked version of

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gem: Make our dma-buf exporter dynamic

2021-06-30 Thread Daniel Vetter
On Wed, Jun 30, 2021 at 4:01 PM Daniel Vetter wrote: > On Wed, Jun 30, 2021 at 03:07:00PM +0200, Thomas Hellström wrote: > > If our exported dma-bufs are imported by another instance of our driver, > > that instance will typically have the imported dma-bufs locked during > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: IRQ fixes (rev2)

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915: IRQ fixes (rev2) URL : https://patchwork.freedesktop.org/series/92053/ State : success == Summary == CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20491 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume

2021-06-30 Thread Daniel Vetter
On Wed, Jun 30, 2021 at 4:18 PM Thomas Zimmermann wrote: > > Hi > > Am 30.06.21 um 12:49 schrieb Daniel Vetter: > > On Wed, Jun 30, 2021 at 11:52:27AM +0200, Thomas Zimmermann wrote: > >> The code in xcs_resume() probably didn't work as intended. It uses > >> struct drm_device.irq, which is

Re: [Intel-gfx] [PATCH 1/2] drm/i915/ttm: Reorganize the ttm move code somewhat

2021-06-30 Thread Daniel Vetter
On Wed, Jun 30, 2021 at 6:54 PM Matthew Auld wrote: > > On Wed, 30 Jun 2021 at 16:27, Thomas Hellström > wrote: > > > > On Wed, 2021-06-30 at 15:19 +0100, Matthew Auld wrote: > > > On Thu, 24 Jun 2021 at 20:31, Thomas Hellström > > > wrote: > > > > > > > > In order to make the code a bit more

Re: [Intel-gfx] [PATCH 1/2] drm/i915/ttm: Reorganize the ttm move code somewhat

2021-06-30 Thread Matthew Auld
On Wed, 30 Jun 2021 at 16:27, Thomas Hellström wrote: > > On Wed, 2021-06-30 at 15:19 +0100, Matthew Auld wrote: > > On Thu, 24 Jun 2021 at 20:31, Thomas Hellström > > wrote: > > > > > > In order to make the code a bit more readable and to facilitate > > > async memcpy moves, reorganize the move

[Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression

2021-06-30 Thread Ville Syrjala
From: Ville Syrjälä The conversion to ww mutexes failed to address the fence code which already returns -EDEADLK when we run out of fences. Ww mutexes on the other hand treat -EDEADLK as an internal errno value indicating a need to restart the operation due to a deadlock. So now when the fence

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: IRQ fixes (rev2)

2021-06-30 Thread Patchwork
== Series Details == Series: drm/i915: IRQ fixes (rev2) URL : https://patchwork.freedesktop.org/series/92053/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

Re: [Intel-gfx] [PATCH 1/2] drm/i915/ttm: Reorganize the ttm move code somewhat

2021-06-30 Thread Thomas Hellström
On Wed, 2021-06-30 at 15:19 +0100, Matthew Auld wrote: > On Thu, 24 Jun 2021 at 20:31, Thomas Hellström > wrote: > > > > In order to make the code a bit more readable and to facilitate > > async memcpy moves, reorganize the move code a little. Determine > > at an early stage whether to copy or

[Intel-gfx] [PATCH v5 15/17] drm/uAPI: Move "Broadcast RGB" property from driver specific to general context

2021-06-30 Thread Werner Sembach
Add "Broadcast RGB" to general drm context so that more drivers besides i915 and gma500 can implement it without duplicating code. Userspace can use this property to tell the graphic driver to use full or limited color range for a given connector, overwriting the default behaviour/automatic

[Intel-gfx] [PATCH v5 11/17] drm/i915/display: Add handling for new "active color range" property

2021-06-30 Thread Werner Sembach
This commit implements the "active color range" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 7 +++ drivers/gpu/drm/i915/display/intel_dp.c | 1 + drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 +

[Intel-gfx] [PATCH v5 16/17] drm/i915/display: Use the general "Broadcast RGB" implementation

2021-06-30 Thread Werner Sembach
Change from the i915 specific "Broadcast RGB" drm property implementation to the general one. This commit delete all traces of the former "Broadcast RGB" implementation and add a new one using the new driver agnoistic functions an variables. Signed-off-by: Werner Sembach ---

[Intel-gfx] [PATCH v5 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-30 Thread Werner Sembach
Add a new general drm property "preferred color format" which can be used by userspace to tell the graphic drivers to which color format to use. Possible options are: - auto (default/current behaviour) - rgb - ycbcr444 - ycbcr422 (not supported by both amdgpu and i915) -

[Intel-gfx] [PATCH v5 13/17] drm/amd/display: Add handling for new "preferred color format" property

2021-06-30 Thread Werner Sembach
This commit implements the "preferred color format" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 30 +++ .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 28 insertions(+), 6

[Intel-gfx] [PATCH v5 04/17] drm/amd/display: Add handling for new "active bpc" property

2021-06-30 Thread Werner Sembach
This commit implements the "active bpc" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 24 ++- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 2 files changed, 27 insertions(+), 1 deletion(-) diff

[Intel-gfx] [PATCH v5 17/17] drm/amd/display: Add handling for new "Broadcast RGB" property

2021-06-30 Thread Werner Sembach
This commit implements the "Broadcast RGB" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +++--- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 4 2 files changed, 15 insertions(+), 3

[Intel-gfx] [PATCH v5 14/17] drm/i915/display: Add handling for new "preferred color format" property

2021-06-30 Thread Werner Sembach
This commit implements the "preferred color format" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 + drivers/gpu/drm/i915/display/intel_hdmi.c | 6 ++ 3

[Intel-gfx] [PATCH v5 08/17] drm/i915/display: Add handling for new "active color format" property

2021-06-30 Thread Werner Sembach
This commit implements the "active color format" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 22 +++- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/intel_dp_mst.c |

[Intel-gfx] [PATCH v5 10/17] drm/amd/display: Add handling for new "active color range" property

2021-06-30 Thread Werner Sembach
This commit implements the "active color range" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 33 +++ .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 37 insertions(+) diff --git

[Intel-gfx] [PATCH v5 09/17] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-30 Thread Werner Sembach
Add a new general drm property "active color range" which can be used by graphic drivers to report the used color range back to userspace. There was no way to check which color range got actually used on a given monitor. To surely predict this, one must know the exact capabilities of the monitor

[Intel-gfx] [PATCH v5 06/17] drm/uAPI: Add "active color format" drm property as feedback for userspace

2021-06-30 Thread Werner Sembach
Add a new general drm property "active color format" which can be used by graphic drivers to report the used color format back to userspace. There was no way to check which color format got actually used on a given monitor. To surely predict this, one must know the exact capabilities of the

[Intel-gfx] [PATCH v5 05/17] drm/i915/display: Add handling for new "active bpc" property

2021-06-30 Thread Werner Sembach
This commit implements the "active bpc" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 19 +++ drivers/gpu/drm/i915/display/intel_dp.c | 7 +-- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5

[Intel-gfx] [PATCH v5 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-30 Thread Werner Sembach
Add a new general drm property "active bpc" which can be used by graphic drivers to report the applied bit depth per pixel color back to userspace. While "max bpc" can be used to change the color depth, there was no way to check which one actually got used. While in theory the driver chooses the

[Intel-gfx] [PATCH v5 01/17] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check

2021-06-30 Thread Werner Sembach
Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check that was performed in the drm_mode_is_420_only() case, but not in the drm_mode_is_420_also() && force_yuv420_output case. Without further knowledge if YCbCr 4:2:0 is supported outside of HDMI, there is no reason to use RGB when the display reports

[Intel-gfx] [PATCH v5 07/17] drm/amd/display: Add handling for new "active color format" property

2021-06-30 Thread Werner Sembach
This commit implements the "active color format" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 +-- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 31 insertions(+), 2

[Intel-gfx] [PATCH v5 00/17] New uAPI drm properties for color management

2021-06-30 Thread Werner Sembach
Implementation of https://lkml.org/lkml/2021/5/12/764 now feature complete albeit not fully tested. I have now corrected the DSC behavior, but still no wait to test it. Exact dithering behavior remains a mistery so in case dithering is active it's not 100% clear what "active bpc" means, or where

[Intel-gfx] [PATCH v5 02/17] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc

2021-06-30 Thread Werner Sembach
convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an integer had the casses for COLOR_DEPTH_999 and COLOR_DEPTH_11 missing. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 1 file changed, 4 insertions(+) diff --git

[Intel-gfx] [PATCH v6 1/4] drm: avoid circular locks in drm_mode_getconnector

2021-06-30 Thread Desmond Cheong Zhi Xi
In preparation for a future patch to take a lock on drm_device.master_mutex inside drm_is_current_master(), we first move the call to drm_is_current_master() in drm_mode_getconnector out from the section locked by >mode_config.mutex. This avoids creating a circular lock dependency. Failing to

[Intel-gfx] [PATCH v6 0/4] drm: address potential UAF bugs with drm_master ptrs

2021-06-30 Thread Desmond Cheong Zhi Xi
This patch series addresses potential use-after-free errors when dereferencing pointers to struct drm_master. These were identified after one such bug was caught by Syzbot in drm_getunique(): https://syzkaller.appspot.com/bug?id=148d2f1dfac64af52ffd27b661981a540724f803 The series is broken up

[Intel-gfx] [PATCH v6 3/4] drm: add a locked version of drm_is_current_master

2021-06-30 Thread Desmond Cheong Zhi Xi
While checking the master status of the DRM file in drm_is_current_master(), the device's master mutex should be held. Without the mutex, the pointer fpriv->master may be freed concurrently by another process calling drm_setmaster_ioctl(). This could lead to use-after-free errors when the pointer

[Intel-gfx] [PATCH v6 4/4] drm: protect drm_master pointers in drm_lease.c

2021-06-30 Thread Desmond Cheong Zhi Xi
Currently, direct copies of drm_file->master pointers should be protected by drm_device.master_mutex when being dereferenced. This is because drm_file->master is not invariant for the lifetime of drm_file. If drm_file is not the creator of master, then drm_file->is_master is false, and a call to

[Intel-gfx] [PATCH v6 2/4] drm: avoid circular locks in __drm_mode_object_find

2021-06-30 Thread Desmond Cheong Zhi Xi
In a future patch, _drm_lease_held will dereference drm_file->master only after making a call to drm_file_get_master which increments the reference count of drm_file->master while holding a lock on drm_device.master_mutex. In preparation for this, the call to _drm_lease_held should be moved out

Re: [Intel-gfx] [PATCH 2/2] drm/ttm, drm/i915: Update ttm_move_memcpy for async use

2021-06-30 Thread Matthew Auld
On Thu, 24 Jun 2021 at 20:31, Thomas Hellström wrote: > > The buffer object argument to ttm_move_memcpy was only used to > determine whether the destination memory should be cleared only > or whether we should copy data. Replace it with a "clear" bool, and > update the callers. > > The intention

Re: [Intel-gfx] [PATCH 1/2] drm/i915/ttm: Reorganize the ttm move code somewhat

2021-06-30 Thread Matthew Auld
On Thu, 24 Jun 2021 at 20:31, Thomas Hellström wrote: > > In order to make the code a bit more readable and to facilitate > async memcpy moves, reorganize the move code a little. Determine > at an early stage whether to copy or to clear. > > Signed-off-by: Thomas Hellström > --- >

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume

2021-06-30 Thread Thomas Zimmermann
Hi Am 30.06.21 um 12:49 schrieb Daniel Vetter: On Wed, Jun 30, 2021 at 11:52:27AM +0200, Thomas Zimmermann wrote: The code in xcs_resume() probably didn't work as intended. It uses struct drm_device.irq, which is allocated to 0, but never initialized by i915 to the device's interrupt number.

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gem: Make our dma-buf exporter dynamic

2021-06-30 Thread Ruhl, Michael J
>-Original Message- >From: Daniel Vetter >Sent: Wednesday, June 30, 2021 10:02 AM >To: Thomas Hellström ; Christian König > >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Auld, >Matthew ; maarten.lankho...@linux.intel.com; >dan...@ffwll.ch; Ruhl, Michael J

Re: [Intel-gfx] [PATCH] drm/vgem: Use 256B aligned pitch

2021-06-30 Thread Daniel Vetter
On Wed, Jun 30, 2021 at 12:46:27PM +, Surendrakumar Upadhyay, TejaskumarX wrote: > > > > -Original Message- > > From: Daniel Vetter > > Sent: 30 June 2021 17:52 > > To: Surendrakumar Upadhyay, TejaskumarX > > > > Cc: dri-de...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gem: Make our dma-buf exporter dynamic

2021-06-30 Thread Daniel Vetter
On Wed, Jun 30, 2021 at 03:07:00PM +0200, Thomas Hellström wrote: > If our exported dma-bufs are imported by another instance of our driver, > that instance will typically have the imported dma-bufs locked during > dma_buf_map_attachment(). But the exporter also locks the same reservation > object

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable

2021-06-30 Thread Patnana, Venkata Sai
> -Original Message- > From: Patnana, Venkata Sai > Sent: Wednesday, June 30, 2021 11:59 AM > To: Jani Nikula ; > intel-gfx@lists.freedesktop.org; > Navare, Manasi D ; Kulkarni, Vandita > > Subject: RE: [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per > connector > debugfs

[Intel-gfx] [PATCH 1/2] drm/i915/gem: Make our dma-buf exporter dynamic

2021-06-30 Thread Thomas Hellström
If our exported dma-bufs are imported by another instance of our driver, that instance will typically have the imported dma-bufs locked during dma_buf_map_attachment(). But the exporter also locks the same reservation object in the map_dma_buf() callback, which leads to recursive locking. Add a

[Intel-gfx] [PATCH 2/2] drm/i915/gem: Migrate to system at dma-buf map time

2021-06-30 Thread Thomas Hellström
Until we support p2p dma or as a complement to that, migrate data to system memory at dma-buf map time if possible. v2: - Rebase on dynamic exporter. Update the igt_dmabuf_import_same_driver selftest to migrate if we are LMEM capable. v3: - Migrate also in the pin() callback. Signed-off-by:

[Intel-gfx] [PATCH 0/2] drm/i915/gem: dma-buf fixes for migration

2021-06-30 Thread Thomas Hellström
Our dma-buf code is currently completely broken unless the importer is dynamic in which case the sg_list caching saves the day. In particular, the case where another instance of our driver tries to import a dma-buf exported by our driver ends up in a recursive lock. Since the recent TTM migration

Re: [Intel-gfx] [PATCH] drm/vgem: Use 256B aligned pitch

2021-06-30 Thread Surendrakumar Upadhyay, TejaskumarX
> -Original Message- > From: Daniel Vetter > Sent: 30 June 2021 17:52 > To: Surendrakumar Upadhyay, TejaskumarX > > Cc: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; > ch...@chris-wilson.co.uk > Subject: Re: [Intel-gfx] [PATCH] drm/vgem: Use 256B aligned pitch > >

Re: [Intel-gfx] [PATCH v5 3/3] drm: protect drm_master pointers in drm_lease.c

2021-06-30 Thread Desmond Cheong Zhi Xi
On 30/6/21 4:02 pm, Daniel Vetter wrote: On Wed, Jun 30, 2021 at 9:18 AM Desmond Cheong Zhi Xi wrote: On 30/6/21 12:07 am, Daniel Vetter wrote: On Tue, Jun 29, 2021 at 11:37:06AM +0800, Desmond Cheong Zhi Xi wrote: Currently, direct copies of drm_file->master pointers should be protected by

Re: [Intel-gfx] [PATCH v5 3/3] drm: protect drm_master pointers in drm_lease.c

2021-06-30 Thread Desmond Cheong Zhi Xi
On 30/6/21 12:07 am, Daniel Vetter wrote: On Tue, Jun 29, 2021 at 11:37:06AM +0800, Desmond Cheong Zhi Xi wrote: Currently, direct copies of drm_file->master pointers should be protected by drm_device.master_mutex when being dereferenced. This is because drm_file->master is not invariant for

Re: [Intel-gfx] [PATCH v15 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

2021-06-30 Thread Will Deacon
On Wed, Jun 30, 2021 at 05:17:27PM +0800, Claire Chang wrote: > On Wed, Jun 30, 2021 at 9:43 AM Nathan Chancellor wrote: > > > > On Thu, Jun 24, 2021 at 11:55:20PM +0800, Claire Chang wrote: > > > Propagate the swiotlb_force into io_tlb_default_mem->force_bounce and > > > use it to determine

Re: [Intel-gfx] [PATCH v5 3/3] drm: protect drm_master pointers in drm_lease.c

2021-06-30 Thread Desmond Cheong Zhi Xi
On 30/6/21 8:16 am, Emil Velikov wrote: Hi Desmond, Couple of small suggestions, with those the series is: Reviewed-by: Emil Velikov On Tue, 29 Jun 2021 at 04:38, Desmond Cheong Zhi Xi wrote: @@ -128,13 +137,20 @@ bool drm_lease_held(struct drm_file *file_priv, int id) struct

Re: [Intel-gfx] [PATCH] drm/vgem: Use 256B aligned pitch

2021-06-30 Thread Daniel Vetter
On Wed, Jun 30, 2021 at 05:32:15PM +0530, Tejas Upadhyay wrote: > Having different alignment requirement by different drivers, > 256B aligned should work for all drm drivers. What. Like yes vgem abuses dumb_create, but it's not a kms driver. Pitch is meaningless, and that's why we align it

Re: [Intel-gfx] [v2] drm/i915: Tweaked Wa_14010685332 for all PCHs

2021-06-30 Thread Anshuman Gupta
On 2021-06-30 at 19:19:04 +0800, acelan@canonical.com wrote: > > dispcnlunit1_cp_xosc_clkreq clock observed to be active on TGL-H platform > > despite Wa_14010685332 original sequence, thus blocks entry to deeper s0ix > > state. > > > > The Tweaked Wa_14010685332 sequence fixes this issue,

[Intel-gfx] [PATCH] drm/vgem: Use 256B aligned pitch

2021-06-30 Thread Tejas Upadhyay
Having different alignment requirement by different drivers, 256B aligned should work for all drm drivers. Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/vgem/vgem_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer

2021-06-30 Thread Thomas Zimmermann
Hi Am 30.06.21 um 12:06 schrieb Greg KH: On Wed, Jun 30, 2021 at 11:52:28AM +0200, Thomas Zimmermann wrote: Remove all references to DRM's IRQ midlayer. i915 uses Linux' interrupt functions directly. v2: * also remove an outdated comment * move IRQ fix into separate patch

Re: [Intel-gfx] [v2] drm/i915: Tweaked Wa_14010685332 for all PCHs

2021-06-30 Thread Gupta, Anshuman
> -Original Message- > From: AceLan Kao On Behalf Of > acelan@canonical.com > Sent: Wednesday, June 30, 2021 4:49 PM > To: Gupta, Anshuman ; intel- > g...@lists.freedesktop.org > Subject: Re: [v2] drm/i915: Tweaked Wa_14010685332 for all PCHs > > > dispcnlunit1_cp_xosc_clkreq

Re: [Intel-gfx] [RFC v3 1/2] drm/i915/dg1: Adjust the AUDIO power domain

2021-06-30 Thread Gupta, Anshuman
> -Original Message- > From: Deak, Imre > Sent: Monday, June 28, 2021 11:12 PM > To: Gupta, Anshuman > Cc: intel-gfx@lists.freedesktop.org; Ville Syrjälä > ; > Kai Vehmanen ; Shankar, Uma > > Subject: Re: [RFC v3 1/2] drm/i915/dg1: Adjust the AUDIO power domain > > On Tue, Jun 01,

Re: [Intel-gfx] [PATCH 04/21] drm/i915/xelpd: Define Degamma Lut range struct for HDR planes

2021-06-30 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Harry > Wentland > Sent: Monday, June 28, 2021 8:45 PM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; > dri- > de...@lists.freedesktop.org > Cc: Modem, Bhanuprakash > Subject: Re: [PATCH 04/21] drm/i915/xelpd: Define Degamma

Re: [Intel-gfx] [v2] drm/i915: Tweaked Wa_14010685332 for all PCHs

2021-06-30 Thread acelan . kao
> dispcnlunit1_cp_xosc_clkreq clock observed to be active on TGL-H platform > despite Wa_14010685332 original sequence, thus blocks entry to deeper s0ix > state. > > The Tweaked Wa_14010685332 sequence fixes this issue, therefore use tweaked > Wa_14010685332 sequence for every PCH since PCH_CNP.

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume

2021-06-30 Thread Daniel Vetter
On Wed, Jun 30, 2021 at 11:52:27AM +0200, Thomas Zimmermann wrote: > The code in xcs_resume() probably didn't work as intended. It uses > struct drm_device.irq, which is allocated to 0, but never initialized > by i915 to the device's interrupt number. > > v3: > * also use

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer

2021-06-30 Thread Greg KH
On Wed, Jun 30, 2021 at 11:52:28AM +0200, Thomas Zimmermann wrote: > Remove all references to DRM's IRQ midlayer. i915 uses Linux' interrupt > functions directly. > > v2: > * also remove an outdated comment > * move IRQ fix into separate patch > * update Fixes tag (Daniel) > >

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2021-06-30 Thread Jani Nikula
On Tue, 29 Jun 2021, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Here goes drm-intel-next-fixes-2021-06-29: > > The biggest fix is the restoration of mmap ioctl for gen12 integrated parts > which lack was breaking ADL-P with media stack. > Besides that a small selftest fix and a theoretical

[Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume

2021-06-30 Thread Thomas Zimmermann
The code in xcs_resume() probably didn't work as intended. It uses struct drm_device.irq, which is allocated to 0, but never initialized by i915 to the device's interrupt number. v3: * also use intel_synchronize_hardirq() at another callsite v2: * wrap irq code in

[Intel-gfx] [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer

2021-06-30 Thread Thomas Zimmermann
Remove all references to DRM's IRQ midlayer. i915 uses Linux' interrupt functions directly. v2: * also remove an outdated comment * move IRQ fix into separate patch * update Fixes tag (Daniel) Signed-off-by: Thomas Zimmermann Fixes: b318b82455bd ("drm/i915: Nuke

[Intel-gfx] [PATCH v3 0/2] drm/i915: IRQ fixes

2021-06-30 Thread Thomas Zimmermann
Fix a bug in the usage of IRQs and cleanup references to the DRM IRQ midlayer. Preferably this patchset would be merged through drm-misc-next. v3: * also use intel_synchronize_hardirq() from other callsite v2: * split patch * also fix comment * add

  1   2   >