Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel tree

2021-08-10 Thread Joonas Lahtinen
+ Dave as FYI Quoting Daniel Vetter (2021-08-10 09:27:25) > On Mon, Aug 09, 2021 at 09:19:39AM -0700, Matt Roper wrote: > > On Mon, Aug 09, 2021 at 04:05:59PM +0200, Daniel Vetter wrote: > > > On Fri, Aug 06, 2021 at 09:36:56AM +0300, Joonas Lahtinen wrote: > > > > Hi Matt, > > > > > > > >

[Intel-gfx] [PATCH v3] drm/i915/display: Fix the 12 BPC bits for PIPE_MISC reg

2021-08-10 Thread Ankit Nautiyal
Till DISPLAY12 the PIPE_MISC bits 5-7 are used to set the Dithering BPC, with valid values of 6, 8, 10 BPC. For ADLP+ these bits are used to set the PORT OUTPUT BPC, with valid values of: 6, 8, 10, 12 BPC, and need to be programmed whether dithering is enabled or not. This patch: -corrects the

[Intel-gfx] missing signoff on drm-intel-gt-next pull

2021-08-10 Thread Dave Airlie
dim: db47fe727e1f ("drm/i915/step: s/_revid_tbl/_revids"): committer Signed-off-by missing. I'm not sure how much pain it is to fix that up, but commit db47fe727e1fc516cf60fc9ab8299605ef3c2d54 Author: Anusha Srivatsa Commit: Matt Roper drm/i915/step: s/_revid_tbl/_revids Simplify the

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/hdcp: reuse rx_info for mst stream type1 capability check

2021-08-10 Thread Ramalingam C
On 2021-08-10 at 16:52:12 -0700, Juston Li wrote: > On some MST docking stations, rx_info can only be read after > RepeaterAuth_Send_ReceiverID_List and the RxStatus READY bit is set > otherwise the read will return -EIO. > > This behavior causes the mst stream type1 capability test to fail to >

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/hdcp: read RxInfo once when reading RepeaterAuth_Send_ReceiverID_List

2021-08-10 Thread Ramalingam C
On 2021-08-10 at 16:52:11 -0700, Juston Li wrote: > When reading RepeaterAuth_Send_ReceiverID_List, RxInfo is read by itself > once to retrieve the DEVICE_COUNT to calculate the size of the > ReceiverID list then read a second time as a part of reading ReceiverID > list. > > On some MST docking

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915/hdcp: update cp_irq_count_cached in intel_dp_hdcp2_read_msg()

2021-08-10 Thread Ramalingam C
On 2021-08-10 at 16:52:10 -0700, Juston Li wrote: > Update cp_irq_count_cached when reading messages rather than when > writing a message to make sure the value is up to date and not > stale from a previously handled CP_IRQ. > > AKE flow doesn't always respond to a read with a ACK write msg. >

Re: [Intel-gfx] [V3 2/7] drm/i915/jsl: program DSI panel GPIOs

2021-08-10 Thread Lee, Shawn C
On Tue, 10 Aug 2021, Jani Nikula wrote: >On Tue, 10 Aug 2021, "Lee, Shawn C" wrote: >> On Tue, 10 Aug 2021, Jani Nikula wrote: >>>On Fri, 23 Jul 2021, Lee Shawn C wrote: DSI driver should have its own implementation to toggle gpio pins based on GPIO info coming from VBT sequences.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: HDCP2.2 MST dock fixes (rev3)

2021-08-10 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: HDCP2.2 MST dock fixes (rev3) URL : https://patchwork.freedesktop.org/series/93570/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10465 -> Patchwork_20796 Summary ---

Re: [Intel-gfx] [PATCH v5 2/9] drm/i915/xehp: Loop over all gslices for INSTDONE processing

2021-08-10 Thread Lucas De Marchi
On Thu, Aug 05, 2021 at 09:36:40AM -0700, Matt Roper wrote: We no longer have traditional slices on Xe_HP platforms, but the INSTDONE registers are replicated according to gslice representation which is similar. We can mostly re-use the existing instdone code with just a few modifications: *

Re: [Intel-gfx] [PATCH v5.1 4/9] drm/i915/xehpsdv: Add compute DSS type

2021-08-10 Thread Lucas De Marchi
On Fri, Aug 06, 2021 at 10:29:01AM -0700, Matt Roper wrote: From: Stuart Summers Starting in XeHP, the concept of slice has been removed in favor of DSS (Dual-Subslice) masks for various workload types. These workloads have been divided into those enabled for geometry and those enabled for

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/hdcp: HDCP2.2 MST dock fixes (rev3)

2021-08-10 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: HDCP2.2 MST dock fixes (rev3) URL : https://patchwork.freedesktop.org/series/93570/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v3 2/3] drm/i915/hdcp: read RxInfo once when reading RepeaterAuth_Send_ReceiverID_List

2021-08-10 Thread Juston Li
When reading RepeaterAuth_Send_ReceiverID_List, RxInfo is read by itself once to retrieve the DEVICE_COUNT to calculate the size of the ReceiverID list then read a second time as a part of reading ReceiverID list. On some MST docking stations, RxInfo can only be read after the RxStatus READY bit

[Intel-gfx] [PATCH v3 3/3] drm/i915/hdcp: reuse rx_info for mst stream type1 capability check

2021-08-10 Thread Juston Li
On some MST docking stations, rx_info can only be read after RepeaterAuth_Send_ReceiverID_List and the RxStatus READY bit is set otherwise the read will return -EIO. This behavior causes the mst stream type1 capability test to fail to read rx_info and determine if the topology supports type1 and

[Intel-gfx] [PATCH v3 1/3] drm/i915/hdcp: update cp_irq_count_cached in intel_dp_hdcp2_read_msg()

2021-08-10 Thread Juston Li
Update cp_irq_count_cached when reading messages rather than when writing a message to make sure the value is up to date and not stale from a previously handled CP_IRQ. AKE flow doesn't always respond to a read with a ACK write msg. E.g. AKE_Send_Pairing_Info will "timeout" because we received a

[Intel-gfx] [PATCH v3 0/3] drm/i915/hdcp: HDCP2.2 MST dock fixes

2021-08-10 Thread Juston Li
Fixes to get HDCP2.2 over MST working on MST docking stations with certain behaviors that cause the current flow to fail. Tested with Dell WD-19 and Lenovo ThinkPad USB Type-C Dock Gen 2. These fixes should make the flow more robust to handle behaviors that as far as I can tell are unclear in the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use locked access to ctx->engines in set_priority

2021-08-10 Thread Patchwork
== Series Details == Series: drm/i915: Use locked access to ctx->engines in set_priority URL : https://patchwork.freedesktop.org/series/93558/ State : success == Summary == CI Bug Log - changes from CI_DRM_10465_full -> Patchwork_20794_full

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/hdcp: HDCP2.2 MST dock fixes (rev2)

2021-08-10 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: HDCP2.2 MST dock fixes (rev2) URL : https://patchwork.freedesktop.org/series/93570/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h CC

[Intel-gfx] ✗ Fi.CI.IGT: failure for Tweaked Wa_14010685332 for all PCHs

2021-08-10 Thread Patchwork
== Series Details == Series: Tweaked Wa_14010685332 for all PCHs URL : https://patchwork.freedesktop.org/series/93548/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10464_full -> Patchwork_20792_full Summary ---

[Intel-gfx] [PATCH v2 3/3] drm/i915/hdcp: reuse rx_info for mst stream type1 capability check

2021-08-10 Thread Juston Li
On some MST docking stations, rx_info can only be read after RepeaterAuth_Send_ReceiverID_List and the RxStatus READY bit is set otherwise the read will return -EIO. This behavior causes the mst stream type1 capability test to fail to read rx_info and determine if the topology supports type1 and

[Intel-gfx] [PATCH v2 2/3] drm/i915/hdcp: read RxInfo once when reading RepeaterAuth_Send_ReceiverID_List

2021-08-10 Thread Juston Li
When reading RepeaterAuth_Send_ReceiverID_List, RxInfo is read by itself once to retrieve the DEVICE_COUNT to calculate the size of the ReceiverID list then read a second time as a part of reading ReceiverID list. On some MST docking stations, RxInfo can only be read after the RxStatus READY bit

[Intel-gfx] [PATCH v2 1/3] drm/i915/hdcp: update cp_irq_count_cached in intel_dp_hdcp2_read_msg()

2021-08-10 Thread Juston Li
Update cp_irq_count_cached when reading messages rather than when writing a message to make sure the value is up to date and not stale from a previously handled CP_IRQ. AKE flow doesn't always respond to a read with a ACK write msg. E.g. AKE_Send_Pairing_Info will "timeout" because we received a

[Intel-gfx] [PATCH v2 0/3] drm/i915/hdcp: HDCP2.2 MST dock fixes

2021-08-10 Thread Juston Li
Fixes to get HDCP2.2 over MST working on MST docking stations with certain behaviors that cause the current flow to fail. Tested with Dell WD-19 and Lenovo ThinkPad USB Type-C Dock Gen 2. These fixes should make the flow more robust to handle behaviors that as far as I can tell are unclear in the

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gen12: Update shadowed register table

2021-08-10 Thread Yokoyama, Caz
Reviewed-by: Caz Yokoyama -caz On Wed, 2021-07-28 at 22:41 -0700, Matt Roper wrote: > The bspec lists many shadowed registers (i.e., registers for which we > don't need to grab forcewake when writing) that we weren't tracking > in > the driver. Although we may not actually use all of these

Re: [Intel-gfx] [PATCH 4/6] drm/i915/gen11: Update shadowed register table

2021-08-10 Thread Yokoyama, Caz
Reviewed-by: Caz Yokoyama -caz On Wed, 2021-07-28 at 22:41 -0700, Matt Roper wrote: > The bspec lists many shadowed registers (i.e., registers for which we > don't need to grab forcewake when writing) that we weren't tracking > in > the driver. Although we may not actually use all of these

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915: Make shadow tables range-based

2021-08-10 Thread Yokoyama, Caz
Reviewed-by: Caz Yokoyama -caz On Thu, 2021-07-29 at 14:59 -0700, Matt Roper wrote: > On Thu, Jul 29, 2021 at 02:55:17PM -0700, Yokoyama, Caz wrote: > > On Thu, 2021-07-29 at 08:21 -0700, Matt Roper wrote: > > > Rather than defining our shadow tables as a list of individual > > > registers,

[Intel-gfx] [PATCH 2/3] drm/i915/hdcp: read RxInfo once when reading RepeaterAuth_Send_ReceiverID_List

2021-08-10 Thread Juston Li
From: Juston Li Date: Mon, 9 Aug 2021 12:55:06 -0700 Subject: [Intel-gfx] [PATCH 3/3] drm/i915/hdcp: reuse rx_info for mst stream type1 capability check On some MST docking stations, rx_info can only be read after RepeaterAuth_Send_ReceiverID_List and the RxStatus READY bit is set otherwise the

[Intel-gfx] [PATCH 2/3] drm/i915/hdcp: read RxInfo once when reading RepeaterAuth_Send_ReceiverID_List

2021-08-10 Thread Juston Li
When reading RepeaterAuth_Send_ReceiverID_List, RxInfo is read by itself once to retrieve the DEVICE_COUNT to calculate the size of the ReceiverID list then read a second time as a part of reading ReceiverID list. On some MST docking stations, RxInfo can only be read after the RxStatus READY bit

[Intel-gfx] [PATCH 1/3] drm/i915/hdcp: update cp_irq_count_cached in intel_dp_hdcp2_read_msg()

2021-08-10 Thread Juston Li
Update cp_irq_count_cached when reading messages rather than when writing a message to make sure the value is up to date and not stale from a previously handled CP_IRQ. AKE flow doesn't always respond to a read with a ACK write msg. E.g. AKE_Send_Pairing_Info will "timeout" because we received a

[Intel-gfx] [PATCH 0/3] drm/i915/hdcp: HDCP2.2 MST dock fixes

2021-08-10 Thread Juston Li
Fixes to get HDCP2.2 over MST working on MST docking stations with certain behaviors that cause the current flow to fail. Tested with Dell WD-19 and Lenovo ThinkPad USB Type-C Dock Gen 2. These fixes should make the flow more robust to handle behaviors that as far as I can tell are unclear in the

Re: [Intel-gfx] [PATCH v5 9/9] drm/i915/dg2: Configure PCON in DP pre-enable path

2021-08-10 Thread Souza, Jose
On Thu, 2021-08-05 at 09:36 -0700, Matt Roper wrote: > From: Ankit Nautiyal > > Add the functions to configure HDMI2.1 pcon for DG2, before DP link > training. Reviewed-by: José Roberto de Souza > > Signed-off-by: Ankit Nautiyal > Signed-off-by: Matt Roper > --- >

Re: [Intel-gfx] [PATCH 10/46] drm/i915/guc: Take engine PM when a context is pinned with GuC submission

2021-08-10 Thread Matthew Brost
On Tue, Aug 10, 2021 at 08:43:50AM +0200, Daniel Vetter wrote: > On Mon, Aug 09, 2021 at 06:11:37PM +, Matthew Brost wrote: > > On Mon, Aug 09, 2021 at 04:23:42PM +0200, Daniel Vetter wrote: > > > On Tue, Aug 03, 2021 at 03:29:07PM -0700, Matthew Brost wrote: > > > > Taking a PM reference to

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/doc/rfc: drop lmem uapi section

2021-08-10 Thread Patchwork
== Series Details == Series: drm/doc/rfc: drop lmem uapi section URL : https://patchwork.freedesktop.org/series/93553/ State : success == Summary == CI Bug Log - changes from CI_DRM_10465_full -> Patchwork_20793_full Summary ---

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Tweaked Wa_14010685332 for all PCHs

2021-08-10 Thread Vudum, Lakshminarayana
Re-reported. -Original Message- From: Gupta, Anshuman Sent: Tuesday, August 10, 2021 8:23 AM To: Vudum, Lakshminarayana Cc: intel-gfx@lists.freedesktop.org Subject: Re: ✗ Fi.CI.BAT: failure for Tweaked Wa_14010685332 for all PCHs On 2021-08-10 at 13:57:29 +, Patchwork wrote: > ==

[Intel-gfx] [PATCH 5.13 059/175] drm/i915: fix i915_globals_exit() section mismatch error

2021-08-10 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit a07296453bf2778952a09b6244a695bf7607babb ] Fix modpost Section mismatch error in i915_globals_exit(). Since both an __init function and an __exit function can call i915_globals_exit(), any function that i915_globals_exit() calls should not be marked as

Re: [Intel-gfx] [PATCH 25/46] drm/i915/guc: Update debugfs for GuC multi-lrc

2021-08-10 Thread Matthew Brost
On Tue, Aug 10, 2021 at 11:27:31AM +0200, Daniel Vetter wrote: > On Tue, Aug 10, 2021 at 11:23:39AM +0200, Daniel Vetter wrote: > > On Mon, Aug 09, 2021 at 07:13:11PM +, Matthew Brost wrote: > > > On Mon, Aug 09, 2021 at 06:36:44PM +0200, Daniel Vetter wrote: > > > > On Tue, Aug 03, 2021 at

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use locked access to ctx->engines in set_priority

2021-08-10 Thread Patchwork
== Series Details == Series: drm/i915: Use locked access to ctx->engines in set_priority URL : https://patchwork.freedesktop.org/series/93558/ State : success == Summary == CI Bug Log - changes from CI_DRM_10465 -> Patchwork_20794 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Tweaked Wa_14010685332 for all PCHs

2021-08-10 Thread Patchwork
== Series Details == Series: Tweaked Wa_14010685332 for all PCHs URL : https://patchwork.freedesktop.org/series/93548/ State : success == Summary == CI Bug Log - changes from CI_DRM_10464 -> Patchwork_20792 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 1/2] ALSA: hda: Release controller display power during shutdown/reboot

2021-08-10 Thread youling 257
my 7820hk sound card is alc662 android_x86:/ # aplay -l List of PLAYBACK Hardware Devices card 0: PCH [HDA Intel PCH], device 0: ALC662 rev3 Analog [ALC662 rev3 Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: PCH [HDA Intel PCH], device 3: HDMI 0 [HDMI 0] Subdevices:

Re: [Intel-gfx] [PATCH 1/2] ALSA: hda: Release controller display power during shutdown/reboot

2021-08-10 Thread youling257
it cause my intel 7820hk cpu failed shutdown.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Use locked access to ctx->engines in set_priority

2021-08-10 Thread Patchwork
== Series Details == Series: drm/i915: Use locked access to ctx->engines in set_priority URL : https://patchwork.freedesktop.org/series/93558/ State : warning == Summary == $ dim checkpatch origin/drm-tip cc99b1d7369b drm/i915: Use locked access to ctx->engines in set_priority -:8:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/doc/rfc: drop lmem uapi section

2021-08-10 Thread Patchwork
== Series Details == Series: drm/doc/rfc: drop lmem uapi section URL : https://patchwork.freedesktop.org/series/93553/ State : success == Summary == CI Bug Log - changes from CI_DRM_10465 -> Patchwork_20793 Summary --- **SUCCESS**

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Tweaked Wa_14010685332 for all PCHs

2021-08-10 Thread Anshuman Gupta
On 2021-08-10 at 13:57:29 +, Patchwork wrote: > == Series Details == > > Series: Tweaked Wa_14010685332 for all PCHs > URL : https://patchwork.freedesktop.org/series/93548/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10464 -> Patchwork_20792 >

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/doc/rfc: drop lmem uapi section

2021-08-10 Thread Patchwork
== Series Details == Series: drm/doc/rfc: drop lmem uapi section URL : https://patchwork.freedesktop.org/series/93553/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/rfc/i915_gem_lmem.rst:21: WARNING: Unknown target name: "i915

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/doc/rfc: drop lmem uapi section

2021-08-10 Thread Patchwork
== Series Details == Series: drm/doc/rfc: drop lmem uapi section URL : https://patchwork.freedesktop.org/series/93553/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9b42c1263b1c drm/doc/rfc: drop lmem uapi section -:13: ERROR:GIT_COMMIT_ID: Please use git commit description

Re: [Intel-gfx] [PATCH v2] fbdev/efifb: Release PCI device's runtime PM ref during FB destroy

2021-08-10 Thread Kai-Heng Feng
On Tue, Aug 10, 2021 at 10:49 PM Alex Deucher wrote: > > On Tue, Aug 10, 2021 at 4:36 AM Imre Deak wrote: > > > > Hi Kai-Heng, Alex, > > > > could you add your ack if the fix looks ok and you're ok if I push it to > > the i915 tree? > > > > Acked-by: Alex Deucher Acked-by: Kai-Heng Feng > >

Re: [Intel-gfx] [PATCH v2] fbdev/efifb: Release PCI device's runtime PM ref during FB destroy

2021-08-10 Thread Alex Deucher
On Tue, Aug 10, 2021 at 4:36 AM Imre Deak wrote: > > Hi Kai-Heng, Alex, > > could you add your ack if the fix looks ok and you're ok if I push it to > the i915 tree? > Acked-by: Alex Deucher > Thanks, > Imre > > On Mon, Aug 09, 2021 at 04:31:46PM +0300, Imre Deak wrote: > > Atm the EFI FB

Re: [Intel-gfx] [PATCH] drm/doc/rfc: drop lmem uapi section

2021-08-10 Thread Jason Ekstrand
Acked-by: Jason Ekstrand On Tue, Aug 10, 2021 at 7:34 AM Daniel Vetter wrote: > > We still have quite a bit more work to do with overall reworking of > the ttm-based dg1 code, but the uapi stuff is now finalized with the > latest pull. So remove that. > > This also fixes kerneldoc build

[Intel-gfx] ✗ Fi.CI.BAT: failure for Tweaked Wa_14010685332 for all PCHs

2021-08-10 Thread Patchwork
== Series Details == Series: Tweaked Wa_14010685332 for all PCHs URL : https://patchwork.freedesktop.org/series/93548/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10464 -> Patchwork_20792 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Make workaround upper bounds exclusive

2021-08-10 Thread Vivi, Rodrigo
On Tue, 2021-08-10 at 15:58 +0300, Jani Nikula wrote: > On Mon, 19 Jul 2021, "Souza, Jose" wrote: > > On Fri, 2021-07-16 at 22:14 -0700, Matt Roper wrote: > > > Workarounds are documented in the bspec with an exclusive upper > > > bound > > > (i.e., a "fixed" stepping that no longer needs the

Re: [Intel-gfx] [PULL] gvt-fixes

2021-08-10 Thread Rodrigo Vivi
On Tue, Aug 10, 2021 at 01:01:33PM +0800, Zhenyu Wang wrote: > > Hi, > > Here's one regression fix for windows VM hang issue on recent drivers. > > Thanks > -- > The following changes since commit c90b4503ccf42d9d367e843c223df44aa550e82a: > > drm/i915/gvt: Clear d3_entered on elsp cmd

[Intel-gfx] [PULL] drm-intel-next

2021-08-10 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-next-2021-08-10-1: drm/i915 changes for v5.15: Features: - Basic DG2 platform enabling (Matt, Animesh, Gwan-gyeong, José) - Add PSF GV point support for display bandwidth calculation (Stan) - Add platform release id version support (Lucas) - Add support for forcing

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Tweaked Wa_14010685332 for all PCHs

2021-08-10 Thread Patchwork
== Series Details == Series: Tweaked Wa_14010685332 for all PCHs URL : https://patchwork.freedesktop.org/series/93548/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0af364b94893 drm/i915: Tweaked Wa_14010685332 for all PCHs -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix shared dpll mismatch for bigjoiner slave

2021-08-10 Thread Jani Nikula
On Wed, 14 Jul 2021, Manasi Navare wrote: > Currently when we do the HW state readout, we dont set the shared dpll to NULL > for the bigjoiner slave which should not have a DPLL assigned. So it has > some garbage while the HW state readout is NULL. So explicitly reset > the shared dpll for

[Intel-gfx] [PATCH] drm/i915: Use locked access to ctx->engines in set_priority

2021-08-10 Thread Daniel Vetter
This essentially reverts commit 89ff76bf9b3b0b86e6bbe344bd6378d8661303fc Author: Chris Wilson Date: Thu Apr 2 13:42:18 2020 +0100 drm/i915/gem: Utilize rcu iteration of context engines Note that the other use of __context_engines_await have disappeard in the following commits:

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Make workaround upper bounds exclusive

2021-08-10 Thread Jani Nikula
On Mon, 19 Jul 2021, "Souza, Jose" wrote: > On Fri, 2021-07-16 at 22:14 -0700, Matt Roper wrote: >> Workarounds are documented in the bspec with an exclusive upper bound >> (i.e., a "fixed" stepping that no longer needs the workaround). This >> makes our driver's use of an inclusive upper bound

[Intel-gfx] [PATCH] drm/doc/rfc: drop lmem uapi section

2021-08-10 Thread Daniel Vetter
We still have quite a bit more work to do with overall reworking of the ttm-based dg1 code, but the uapi stuff is now finalized with the latest pull. So remove that. This also fixes kerneldoc build warnings because we've included the same headers in two places, resulting in sphinx complaining

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem/ttm: prefer kernel types

2021-08-10 Thread Patchwork
== Series Details == Series: drm/i915/gem/ttm: prefer kernel types URL : https://patchwork.freedesktop.org/series/93541/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10464 -> Patchwork_20791 Summary --- **FAILURE**

Re: [Intel-gfx] [V3 2/7] drm/i915/jsl: program DSI panel GPIOs

2021-08-10 Thread Jani Nikula
On Tue, 10 Aug 2021, "Lee, Shawn C" wrote: > On Tue, 10 Aug 2021, Jani Nikula wrote: >>On Fri, 23 Jul 2021, Lee Shawn C wrote: >>> DSI driver should have its own implementation to toggle gpio pins >>> based on GPIO info coming from VBT sequences. >> >>Why? >> > > Without this change, we are not

Re: [Intel-gfx] [PATCH] drm/i915/gem/ttm: prefer kernel types

2021-08-10 Thread Jani Nikula
On Tue, 10 Aug 2021, Daniel Vetter wrote: > On Tue, Aug 10, 2021 at 11:41:28AM +0300, Jani Nikula wrote: >> Avoid uintXX_t types in the driver. >> >> Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend") >> Cc: Thomas Hellström >> Cc: Matthew Auld >> Cc: Maarten

[Intel-gfx] [CI v2 1/1] drm/i915: Tweaked Wa_14010685332 for all PCHs

2021-08-10 Thread Anshuman Gupta
dispcnlunit1_cp_xosc_clkreq clock observed to be active on TGL-H platform despite Wa_14010685332 original sequence, thus blocks entry to deeper s0ix state. The Tweaked Wa_14010685332 sequence fixes this issue, therefore use tweaked Wa_14010685332 sequence for every PCH since PCH_CNP. v2: -

[Intel-gfx] [CI v2 0/1] Tweaked Wa_14010685332 for all PCHs

2021-08-10 Thread Anshuman Gupta
This revision is floated to get the CI results. Rev3 Patchwork Link : https://patchwork.freedesktop.org/series/88435/#rev3 David Box has tested the Rev3 and provided that confirmation that it is working on TGL-H Dell platforms. Rev4 and Rev5 have some patchwork issues due to that CI build is

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Fix the 12 BPC bits for PIPE_MISC reg

2021-08-10 Thread Shankar, Uma
> -Original Message- > From: Nautiyal, Ankit K > Sent: Monday, August 2, 2021 6:27 PM > To: intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; Zanoni, Paulo R > ; ville.syrj...@linux.intel.com; > daniel.vet...@ffwll.ch; > jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com;

Re: [Intel-gfx] [PATCH] DRM: i915: i915_perf: Fixed compiler warning

2021-08-10 Thread Lionel Landwerlin
On 09/08/2021 05:33, Julius Victorian wrote: From: Julius Fixed compiler warning: "left shift of negative value" Signed-off-by: Julius Victorian Reviewed-by: Lionel Landwerlin Thanks! --- drivers/gpu/drm/i915/i915_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Intel-gfx] [PATCH 3/3] drm/i915/selftests: Add initial GuC selftest for scrubbing lost G2H

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 07:41:29PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 04:03:28PM +0200, Daniel Vetter wrote: > > On Sun, Aug 08, 2021 at 11:07:57AM -0700, Matthew Brost wrote: > > > While debugging an issue with full GT resets I went down a rabbit hole > > > thinking the

Re: [Intel-gfx] [PATCH 2/3] drm/i915/selftests: Fix memory corruption in live_lrc_isolation

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 07:37:39PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 03:38:38PM +0200, Daniel Vetter wrote: > > On Sun, Aug 08, 2021 at 11:07:56AM -0700, Matthew Brost wrote: > > > GuC submission has exposed an existing memory corruption in > > > live_lrc_isolation. We believe

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Fix several issues related to resets / request cancelation

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 07:35:22PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 03:35:26PM +0200, Daniel Vetter wrote: > > On Sun, Aug 08, 2021 at 11:07:55AM -0700, Matthew Brost wrote: > > > Resets are notoriously hard to get fully working and notoriously racey, > > > especially with

Re: [Intel-gfx] [PATCH] drm/i915/gem/ttm: prefer kernel types

2021-08-10 Thread Daniel Vetter
On Tue, Aug 10, 2021 at 11:41:28AM +0300, Jani Nikula wrote: > Avoid uintXX_t types in the driver. > > Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend") > Cc: Thomas Hellström > Cc: Matthew Auld > Cc: Maarten Lankhorst > Signed-off-by: Jani Nikula > --- >

Re: [Intel-gfx] [PATCH] drm/i915: Release ctx->syncobj on final put, not on ctx close

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 08:47:14PM +0200, Daniel Vetter wrote: > On Sun, Aug 8, 2021 at 2:56 AM Jason Ekstrand wrote: > > > > On August 6, 2021 15:18:59 Daniel Vetter wrote: > > > >> gem context refcounting is another exercise in least locking design it > >> seems, where most things get

Re: [Intel-gfx] [V3 2/7] drm/i915/jsl: program DSI panel GPIOs

2021-08-10 Thread Lee, Shawn C
On Tue, 10 Aug 2021, Jani Nikula wrote: >On Fri, 23 Jul 2021, Lee Shawn C wrote: >> DSI driver should have its own implementation to toggle gpio pins >> based on GPIO info coming from VBT sequences. > >Why? > Without this change, we are not able to control gpio signal output to meet MIPI

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Free all DMC payloads

2021-08-10 Thread Petri Latvala
On Mon, Aug 09, 2021 at 03:05:37PM -0700, Lucas De Marchi wrote: > On Mon, Aug 09, 2021 at 10:00:34PM +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: Free all DMC payloads > > URL : https://patchwork.freedesktop.org/series/93521/ > > State : failure > > > > ==

Re: [Intel-gfx] [V3 2/7] drm/i915/jsl: program DSI panel GPIOs

2021-08-10 Thread Jani Nikula
On Fri, 23 Jul 2021, Lee Shawn C wrote: > DSI driver should have its own implementation to toggle > gpio pins based on GPIO info coming from VBT sequences. Why? > > Cc: Ville Syrjala > Cc: Jani Nikula > Cc: Vandita Kulkarni > Cc: Cooper Chiou > Cc: William Tseng > Signed-off-by: Lee Shawn

Re: [Intel-gfx] [PATCH 25/46] drm/i915/guc: Update debugfs for GuC multi-lrc

2021-08-10 Thread Daniel Vetter
On Tue, Aug 10, 2021 at 11:23:39AM +0200, Daniel Vetter wrote: > On Mon, Aug 09, 2021 at 07:13:11PM +, Matthew Brost wrote: > > On Mon, Aug 09, 2021 at 06:36:44PM +0200, Daniel Vetter wrote: > > > On Tue, Aug 03, 2021 at 03:29:22PM -0700, Matthew Brost wrote: > > > > Display the workqueue

Re: [Intel-gfx] [PATCH 25/46] drm/i915/guc: Update debugfs for GuC multi-lrc

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 07:13:11PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 06:36:44PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:22PM -0700, Matthew Brost wrote: > > > Display the workqueue status in debugfs for GuC contexts that are in > > > parent-child

Re: [Intel-gfx] [PATCH 20/46] drm/i915/guc: Add hang check to GuC submit engine

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 07:05:58PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 05:35:25PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:17PM -0700, Matthew Brost wrote: > > > The heartbeat uses a single instance of a GuC submit engine (GSE) to do > > > the hang check. As

Re: [Intel-gfx] [PATCH 19/46] drm/i915/guc: Assign contexts in parent-child relationship consecutive guc_ids

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 07:03:12PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 05:31:38PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:16PM -0700, Matthew Brost wrote: > > > Assign contexts in parent-child relationship consecutive guc_ids. This > > > is accomplished by

Re: [Intel-gfx] [PATCH 16/46] drm/i915/guc: Implement GuC parent-child context pin / unpin functions

2021-08-10 Thread Daniel Vetter
On Tue, Aug 10, 2021 at 10:53:37AM +0200, Daniel Vetter wrote: > On Mon, Aug 09, 2021 at 06:58:23PM +, Matthew Brost wrote: > > On Mon, Aug 09, 2021 at 05:17:34PM +0200, Daniel Vetter wrote: > > > On Tue, Aug 03, 2021 at 03:29:13PM -0700, Matthew Brost wrote: > > > > Implement GuC parent-child

Re: [Intel-gfx] [PATCH 16/46] drm/i915/guc: Implement GuC parent-child context pin / unpin functions

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 06:58:23PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 05:17:34PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:13PM -0700, Matthew Brost wrote: > > > Implement GuC parent-child context pin / unpin functions in which in any > > > contexts in the

Re: [Intel-gfx] [PATCH 15/46] drm/i915/guc: Introduce context parent-child relationship

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 06:44:16PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 04:37:55PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:12PM -0700, Matthew Brost wrote: > > > Introduce context parent-child relationship. Once this relationship is > > > created all pinning

[Intel-gfx] [PATCH] drm/i915/gem/ttm: prefer kernel types

2021-08-10 Thread Jani Nikula
Avoid uintXX_t types in the driver. Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend") Cc: Thomas Hellström Cc: Matthew Auld Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Intel-gfx] [PATCH v2] fbdev/efifb: Release PCI device's runtime PM ref during FB destroy

2021-08-10 Thread Imre Deak
Hi Kai-Heng, Alex, could you add your ack if the fix looks ok and you're ok if I push it to the i915 tree? Thanks, Imre On Mon, Aug 09, 2021 at 04:31:46PM +0300, Imre Deak wrote: > Atm the EFI FB platform driver gets a runtime PM reference for the > associated GFX PCI device during probing the

Re: [Intel-gfx] [PATCH v4 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set

2021-08-10 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [Intel-gfx] [PATCH 14/46] drm/i915: Expose logical engine instance to user

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 06:37:01PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 04:30:06PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:11PM -0700, Matthew Brost wrote: > > > Expose logical engine instance to user via query engine info IOCTL. This > > > is required for

Re: [Intel-gfx] [PATCH 13/46] drm/i915: Add logical engine mapping

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 06:28:58PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 04:28:04PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:10PM -0700, Matthew Brost wrote: > > > Add logical engine mapping. This is required for split-frame, as > > > workloads need to be

Re: [Intel-gfx] [PATCH 11/46] drm/i915/guc: Don't call switch_to_kernel_context with GuC submission

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 06:20:51PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 04:27:01PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:08PM -0700, Matthew Brost wrote: > > > Calling switch_to_kernel_context isn't needed if the engine PM reference > > > is taken while all

Re: [Intel-gfx] [PATCH 10/46] drm/i915/guc: Take engine PM when a context is pinned with GuC submission

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 06:11:37PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 04:23:42PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:07PM -0700, Matthew Brost wrote: > > > Taking a PM reference to prevent intel_gt_wait_for_idle from short > > > circuiting while a

Re: [Intel-gfx] [PATCH 0/1] Fix gem_ctx_persistence failures with GuC submission

2021-08-10 Thread Daniel Vetter
On Wed, Jul 28, 2021 at 05:33:59PM -0700, Matthew Brost wrote: > Should fix below failures with GuC submission for the following tests: > gem_exec_balancer --r noheartbeat > gem_ctx_persistence --r heartbeat-close > > Not going to fix: > gem_ctx_persistence --r heartbeat-many >

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Check if engine has heartbeat when closing a context

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 04:12:52PM -0700, John Harrison wrote: > On 8/6/2021 12:46, Daniel Vetter wrote: > > Seen this fly by and figured I dropped a few thoughts in here. At the > > likely cost of looking a bit out of whack :-) > > > > On Fri, Aug 6, 2021 at 8:01 PM John Harrison > > wrote: >

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel tree

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 09:19:39AM -0700, Matt Roper wrote: > On Mon, Aug 09, 2021 at 04:05:59PM +0200, Daniel Vetter wrote: > > On Fri, Aug 06, 2021 at 09:36:56AM +0300, Joonas Lahtinen wrote: > > > Hi Matt, > > > > > > Always use the dim tooling when applying patches, it will do the right > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Free all DMC payloads (rev2)

2021-08-10 Thread Patchwork
== Series Details == Series: drm/i915: Free all DMC payloads (rev2) URL : https://patchwork.freedesktop.org/series/93521/ State : success == Summary == CI Bug Log - changes from CI_DRM_10462_full -> Patchwork_20790_full Summary ---