[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Wait request to finish

== Series Details == Series: drm/i915/selftests: Wait request to finish URL : https://patchwork.freedesktop.org/series/95926/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10750 -> Patchwork_21363 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Wait request to finish

== Series Details == Series: drm/i915/selftests: Wait request to finish URL : https://patchwork.freedesktop.org/series/95926/ State : warning == Summary == $ dim checkpatch origin/drm-tip cc4b6b8dafe9 drm/i915/selftests: Wait request to finish -:23: CHECK:SPACING: spaces preferred around that

[Intel-gfx] [PATCH] drm/i915/selftests: Wait request to finish

Caller of function igt_gpu_fill_dw assumes when this function returns, the gpu command to fill dword is already finished. Caller usually checks the GPU filling result immediately, see the usage in function __igt_write_huge. If there is no wait, when function igt_gpu_fill_dw returns, the GPU

[Intel-gfx] ✗ Fi.CI.IGT: failure for finish/rebase fbdev pin refactor.

== Series Details == Series: finish/rebase fbdev pin refactor. URL : https://patchwork.freedesktop.org/series/95925/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10750_full -> Patchwork_21362_full Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Declare .(de)gamma_lut_tests for icl+ (rev2)

== Series Details == Series: series starting with [1/2] drm/i915: Declare .(de)gamma_lut_tests for icl+ (rev2) URL : https://patchwork.freedesktop.org/series/95841/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10750_full -> Patchwork_21361_full

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Introduce lpt_pch_disable()

On Fri, Oct 15, 2021 at 5:17 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Let's add lpt_pch_disable() as the counterpart to > lpt_pch_enable(). > > Note that unlike the ilk+ code the fdi_link_train() > and fdi_disable() calls are still left directly in > intel_crt.c. If we wanted to move

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Move intel_ddi_fdi_post_disable() to fdi code

On Fri, Oct 15, 2021 at 5:17 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Reanme intel_ddi_fdi_post_disable() to hsw_fdi_disable() and > relocate it next to all the other code dealing with FDI_RX. > intel_ddi.c has now been cleansed of FDI_RX. > > In order to avoid exposing

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Introduce ilk_pch_disable() and ilk_pch_post_disable()

On Fri, Oct 15, 2021 at 5:17 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Hoover the remaining open coded PCH modeset sequence bits > out from ilk_crtc_disable(). Somewhat annoyingly the > enable vs. disable is a bit asymmetric so we need two > functions for the disable case. > > Cc: Dave

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Move iCLKIP readout to the pch code

On Fri, Oct 15, 2021 at 5:17 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Move the lpt_get_iclkip() call from hsw_crt_get_config() > since that's where we have the lpt_program_iclkip() call > as well. > > Tehcnically this isn't perhaps quite right since iCLKIP > is providing the CRT

[Intel-gfx] ✓ Fi.CI.BAT: success for finish/rebase fbdev pin refactor.

== Series Details == Series: finish/rebase fbdev pin refactor. URL : https://patchwork.freedesktop.org/series/95925/ State : success == Summary == CI Bug Log - changes from CI_DRM_10750 -> Patchwork_21362 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Extract ilk_pch_get_config()

On Fri, Oct 15, 2021 at 5:16 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Pull the ilk+ PCH state readout into its own function and relocate > to the appropriate file. > > The clock readout parts are perhaps a bit iffy since we depend > on the gmch DPLL readout code. But we can think

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Move LPT PCH readout code

On Fri, Oct 15, 2021 at 5:16 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Nuke the hsw_get_ddi_port_state() eyesore by putting the > readout code into intel_pch_display.c, and calling it directly > from hsw_crt_get_config(). > > Cc: Dave Airlie > Cc: Jani Nikula > Signed-off-by: Ville

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for finish/rebase fbdev pin refactor.

== Series Details == Series: finish/rebase fbdev pin refactor. URL : https://patchwork.freedesktop.org/series/95925/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for finish/rebase fbdev pin refactor.

== Series Details == Series: finish/rebase fbdev pin refactor. URL : https://patchwork.freedesktop.org/series/95925/ State : warning == Summary == $ dim checkpatch origin/drm-tip f1c4731db194 drm/i915/display: refactor fbdev pin/unpin out into functions. -:38: WARNING:BRACES: braces {} are

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Clean up the {ilk, lpt}_pch_enable() calling convention

On Fri, Oct 15, 2021 at 5:16 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Use the clean "atomic_state+crtc" approach of passing > arguments to the top level PCH modeset code. > > And while at it we can also just pass the whole crtc to > ilk_disable_pch_transcoder(). Some minor

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Move PCH refclok stuff into its own file

On Fri, Oct 15, 2021 at 5:16 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Move the PCH refclk stuff (including all the LPT/WPT > iCLKIP/CLKOUT_DP things) to its own file. > > We also suck in the mPHY programming from intel_fdi.c > since we're the only caller. The title of the patch has a

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Move PCH modeset code to its own file

On Fri, Oct 15, 2021 at 5:16 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Start moving the code for PCH modeset sequence/etc. to > its own file. > > Still not sure about the file name though... Name is good enough for now, there aren't a lot of great names, no point getting stuck on it.

Re: [Intel-gfx] [PATCH 0/4] drm/i915: Make the driver not oops on load on old machines

On Thu, 14 Oct 2021 at 19:09, Ville Syrjala wrote: > > From: Ville Syrjälä > > Fix a pile of regression on older machines which just oops the driver > on load. > For all 4: Reviewed-by: Dave Airlie though it would be nice if the clflushes has more justifications on initial patch

[Intel-gfx] [PATCH 3/4] drm/i915/display: drop unused parameter to dpt pin

From: Dave Airlie The uses_fence isn't used. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_fb_pin.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c b/drivers/gpu/drm/i915/display/intel_fb_pin.c index

[Intel-gfx] [PATCH 4/4] drm/i915/display: drop some unused includes

From: Dave Airlie These aren't used since refactoring. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_display.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index

[Intel-gfx] [PATCH 2/4] drm/i915/display: move fbdev pin code into fb_pin

From: Dave Airlie This moves the fbdev pin code over and moves the internal interfaces to static. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_fb_pin.c | 37 +++-- drivers/gpu/drm/i915/display/intel_fb_pin.h | 15 -

[Intel-gfx] [PATCH 0/4] finish/rebase fbdev pin refactor.

Jani had some extra review for the refactor patch. Address that. Dave.

[Intel-gfx] [PATCH 1/4] drm/i915/display: refactor fbdev pin/unpin out into functions.

From: Dave Airlie This just cleans up the calls a bit. v2: fix unpin in vaddr fail path (Jani) Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_fbdev.c | 67 +- 1 file changed, 41 insertions(+), 26 deletions(-) diff --git

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Declare .(de)gamma_lut_tests for icl+ (rev2)

== Series Details == Series: series starting with [1/2] drm/i915: Declare .(de)gamma_lut_tests for icl+ (rev2) URL : https://patchwork.freedesktop.org/series/95841/ State : success == Summary == CI Bug Log - changes from CI_DRM_10750 -> Patchwork_21361

Re: [Intel-gfx] [PATCH] drm/i915/gt: make a gt sysfs group and move power management files

Hi Sujaritha, [...] > > +void intel_gt_sysfs_unregister(struct intel_gt *gt) > > +{ > > +} > > Is there a reason for this function to not be populated ? yes, there is, indeed, something missing here. There has been a fix bout this floating around from Chris about sysfs_gt kobjects. I will

Re: [Intel-gfx] [PATCH v2 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

On Wed, Oct 13, 2021 at 08:36:01PM +0200, Nirmoy Das wrote: > Debugfs APIs returns encoded error on failure so use > debugfs_lookup() instead of checking for NULL. The commit message no longer matches up with the patch itself (debugfs_lookup() isn't called). My suggestion would be something

[Intel-gfx] ✗ Fi.CI.IGT: failure for replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi (rev3)

== Series Details == Series: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi (rev3) URL : https://patchwork.freedesktop.org/series/95880/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10744_full -> Patchwork_21360_full

[Intel-gfx] ✓ Fi.CI.BAT: success for replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi (rev3)

== Series Details == Series: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi (rev3) URL : https://patchwork.freedesktop.org/series/95880/ State : success == Summary == CI Bug Log - changes from CI_DRM_10744 -> Patchwork_21360

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi (rev3)

== Series Details == Series: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi (rev3) URL : https://patchwork.freedesktop.org/series/95880/ State : warning == Summary == $ dim checkpatch origin/drm-tip bcbb68918d43 gpu/drm: make drm_add_edid_modes() consistent when updating

Re: [Intel-gfx] intel_mei_pxp: needs better help text

Thank you, we will handle that. Please mind our weekend. Thanks Tomas > -Original Message- > From: Pavel Machek > Sent: Sunday, October 17, 2021 10:24 > To: kernel list ; Lubart, Vitaly > ; Winkler, Tomas ; > Ceraolo Spurio, Daniele ; > jani.nik...@linux.intel.com;

Re: [Intel-gfx] intel_mei_pxp: needs better help text

Hi! Extended Cc list. Should I attempt to prepare a patch? Best regards, Pavel On Thu 2021-10-14 12:53:34, Pavel Machek wrote: > > CONFIG_INTEL_MEI_PXP: > > MEI Support for PXP Services on Intel platforms. > > Enables the ME FW services