[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation

2022-02-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation URL : https://patchwork.freedesktop.org/series/99597/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11176 -> Patchwork_22151

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation

2022-02-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation URL : https://patchwork.freedesktop.org/series/99597/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation

2022-02-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation URL : https://patchwork.freedesktop.org/series/99597/ State : warning == Summary == $ dim checkpatch origin/drm-tip 737921ca12bb drm/mm: Add an iterator to optimally

[Intel-gfx] [PATCH 2/2] drm/i915/gem: Don't try to map and fence large scanout buffers (v5)

2022-02-01 Thread Vivek Kasireddy
On platforms capable of allowing 8K (7680 x 4320) modes, pinning 2 or more framebuffers/scanout buffers results in only one that is mappable/ fenceable. Therefore, pageflipping between these 2 FBs where only one is mappable/fenceable creates latencies large enough to miss alternate vblanks thereby

[Intel-gfx] [PATCH 1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation

2022-02-01 Thread Vivek Kasireddy
This iterator relies on drm_mm_first_hole() and drm_mm_next_hole() functions to identify suitable holes for an allocation of a given size by efficently traversing the rbtree associated with the given allocator. It replaces the for loop in drm_mm_insert_node_in_range() and can also be used by drm

Re: [Intel-gfx] [PATCH 16/19] drm/i915/guc: Use a single pass to calculate regset

2022-02-01 Thread Daniele Ceraolo Spurio
On 1/26/2022 12:36 PM, Lucas De Marchi wrote: The ADS initialitazion was using 2 passes to calculate the regset sent to GuC to initialize each engine: the first pass to just have the final object size and the second to set each register in place in the final gem object. However in order to

Re: [Intel-gfx] [PATCH v2 03/11] drm/i915: Use str_yes_no()

2022-02-01 Thread Matt Roper
On Wed, Jan 26, 2022 at 01:39:43AM -0800, Lucas De Marchi wrote: > Remove the local yesno() implementation and adopt the str_yes_no() from > linux/string_helpers.h. > > Signed-off-by: Lucas De Marchi > Acked-by: Daniel Vetter > Acked-by: Jani Nikula Reviewed-by: Matt Roper > --- >

Re: [Intel-gfx] [PATCH v2 04/11] drm/i915: Use str_enable_disable()

2022-02-01 Thread Matt Roper
On Wed, Jan 26, 2022 at 01:39:44AM -0800, Lucas De Marchi wrote: > Remove the local enabledisable() implementation and adopt the > str_enable_disable() from linux/string_helpers.h. > > Signed-off-by: Lucas De Marchi > Acked-by: Daniel Vetter > Acked-by: Jani Nikula There's an open-coded

Re: [Intel-gfx] [PATCH v2 05/11] drm/i915: Use str_enabled_disabled()

2022-02-01 Thread Matt Roper
On Wed, Jan 26, 2022 at 01:39:45AM -0800, Lucas De Marchi wrote: > Remove the local enableddisabled() implementation and adopt the > str_enabled_disabled() from linux/string_helpers.h. > > Signed-off-by: Lucas De Marchi > Acked-by: Daniel Vetter > Acked-by: Jani Nikula There's two open-coded

Re: [Intel-gfx] [PATCH v2 06/11] drm/i915: Use str_on_off()

2022-02-01 Thread Matt Roper
On Wed, Jan 26, 2022 at 01:39:46AM -0800, Lucas De Marchi wrote: > Remove the local onoff() implementation and adopt the > str_on_off() from linux/string_helpers.h. > > Signed-off-by: Lucas De Marchi > Acked-by: Daniel Vetter > Acked-by: Jani Nikula Reviewed-by: Matt Roper > --- >

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Dave Airlie
On Tue, 1 Feb 2022 at 07:06, Daniel Vetter wrote: > > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/core/ |

[Intel-gfx] ✗ Fi.CI.BAT: failure for discrete card 64K page support (rev5)

2022-02-01 Thread Patchwork
== Series Details == Series: discrete card 64K page support (rev5) URL : https://patchwork.freedesktop.org/series/99119/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11175 -> Patchwork_22150 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH] drm/i915: Introduce G12 subplatform of DG2

2022-02-01 Thread Sripada, Radhakrishna
> -Original Message- > From: Intel-gfx On Behalf Of Matt > Roper > Sent: Thursday, January 20, 2022 3:50 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915: Introduce G12 subplatform of DG2 > > Another fork of the DG2 design has appeared, known as

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for discrete card 64K page support (rev5)

2022-02-01 Thread Patchwork
== Series Details == Series: discrete card 64K page support (rev5) URL : https://patchwork.freedesktop.org/series/99119/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for discrete card 64K page support (rev5)

2022-02-01 Thread Patchwork
== Series Details == Series: discrete card 64K page support (rev5) URL : https://patchwork.freedesktop.org/series/99119/ State : warning == Summary == $ dim checkpatch origin/drm-tip 640354f70085 drm/i915: add needs_compact_pt flag 7dc2679d906a drm/i915: enforce min GTT alignment for discrete

[Intel-gfx] [PATCH v7 4/5] drm/i915: add gtt misalignment test

2022-02-01 Thread Robert Beckett
add test to check handling of misaligned offsets and sizes v4: * remove spurious blank lines * explicitly cast intel_region_id to intel_memory_type in misaligned_pin Reported-by: kernel test robot v6: * use NEEDS_COMPACT_PT instead of hard coding for DG2 v7: * use

[Intel-gfx] [PATCH v7 5/5] drm/i915/uapi: document behaviour for DG2 64K support

2022-02-01 Thread Robert Beckett
From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for this. v3: fix typos and less emphasis v2: Fixed suggestions on

[Intel-gfx] [PATCH v7 3/5] drm/i915: support 64K GTT pages for discrete cards

2022-02-01 Thread Robert Beckett
From: Matthew Auld discrete cards optimise 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly. 4K pages for local-memory are no

[Intel-gfx] [PATCH v7 2/5] drm/i915: enforce min GTT alignment for discrete cards

2022-02-01 Thread Robert Beckett
From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. We need to support vm->min_alignment > 4K, depending on the vm itself and the type of object we are inserting. With this in mind update the GTT selftests to take this into

[Intel-gfx] [PATCH v7 0/5] discrete card 64K page support

2022-02-01 Thread Robert Beckett
This series continues support for 64K pages for discrete cards. It supersedes the 64K patches from https://patchwork.freedesktop.org/series/95686/#rev4 Changes since that series: - set min alignment for DG2 to 2MB in i915_address_space_init - replace coloring with simpler 2MB VA alignment for

[Intel-gfx] [PATCH v7 1/5] drm/i915: add needs_compact_pt flag

2022-02-01 Thread Robert Beckett
From: Ramalingam C Add a new platform flag, needs_compact_pt, to mark the requirement of compact pt layout support for the ppGTT when using 64K GTT pages. With this flag has_64k_pages will only indicate requirement of 64K GTT page sizes or larger for device local memory access. v6: *

Re: [Intel-gfx] [PATCH v3 1/3] drm: Stop spamming log with drm_cache message

2022-02-01 Thread Lucas De Marchi
On Tue, Feb 01, 2022 at 09:12:05AM -0800, Jose Souza wrote: On Mon, 2022-01-31 at 08:59 -0800, Lucas De Marchi wrote: Only x86 and in some cases PPC have support added in drm_cache.c for the clflush class of functions. However warning once is sufficient to taint the log instead of spamming it

[Intel-gfx] ✗ Fi.CI.IGT: failure for Compile out integrated

2022-02-01 Thread Patchwork
== Series Details == Series: Compile out integrated URL : https://patchwork.freedesktop.org/series/99570/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11172_full -> Patchwork_22149_full Summary --- **FAILURE**

Re: [Intel-gfx] [RFC 0/2] Compile out integrated

2022-02-01 Thread Lucas De Marchi
On Tue, Feb 01, 2022 at 07:09:14PM +0200, Jani Nikula wrote: On Tue, 01 Feb 2022, Lucas De Marchi wrote: On Tue, Feb 01, 2022 at 11:15:31AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Quicky and dirty hack based on some old ideas. Thought maybe the approach might interest the Arm port

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915: Do not spam log with missing arch support

2022-02-01 Thread Souza, Jose
On Mon, 2022-01-31 at 08:59 -0800, Lucas De Marchi wrote: > Following what was done in drm_cache.c, when the stub for > remap_io_mapping() was added in commit 67c430bbaae1 ("drm/i915: Skip > remap_io_mapping() for non-x86 platforms"), it included a log message > with pr_err(). However just the

Re: [Intel-gfx] [PATCH v3 1/3] drm: Stop spamming log with drm_cache message

2022-02-01 Thread Souza, Jose
On Mon, 2022-01-31 at 08:59 -0800, Lucas De Marchi wrote: > Only x86 and in some cases PPC have support added in drm_cache.c for the > clflush class of functions. However warning once is sufficient to taint > the log instead of spamming it with "Architecture has no drm_cache.c > support" every few

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915: Fix header test for !CONFIG_X86

2022-02-01 Thread Souza, Jose
On Mon, 2022-01-31 at 08:59 -0800, Lucas De Marchi wrote: > Architectures others than x86 have a stub implementation calling > WARN_ON_ONCE(). The appropriate headers need to be included, otherwise > the header-test target will fail with: > > HDRTEST drivers/gpu/drm/i915/i915_mm.h > In file

Re: [Intel-gfx] [RFC 0/2] Compile out integrated

2022-02-01 Thread Jani Nikula
On Tue, 01 Feb 2022, Lucas De Marchi wrote: > On Tue, Feb 01, 2022 at 11:15:31AM +, Tvrtko Ursulin wrote: >>From: Tvrtko Ursulin >> >>Quicky and dirty hack based on some old ideas. Thought maybe the approach >>might >>interest the Arm port guys. But with IS_GEN_RANGE removed easy gains are

Re: [Intel-gfx] [RFC 0/2] Compile out integrated

2022-02-01 Thread Lucas De Marchi
On Tue, Feb 01, 2022 at 11:15:31AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Quicky and dirty hack based on some old ideas. Thought maybe the approach might interest the Arm port guys. But with IS_GEN_RANGE removed easy gains are not so big so meh.. Maybe some more easy wins with

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/: Re-work clflush_write32

2022-02-01 Thread Tvrtko Ursulin
On 01/02/2022 15:41, Michael Cheng wrote: Ah, thanks for the clarification! While discussion goes on about the route you suggested, could we land these patches (after addressing the reviews) to unblock compiling i915 on arm? I am 60-40 to no, since follow up can be hard. I'd prefer a little

Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Daniel Vetter
On Tue, Feb 1, 2022 at 3:52 PM Helge Deller wrote: > > On 2/1/22 14:45, Daniel Vetter wrote: > > On Tue, Feb 1, 2022 at 12:01 PM Helge Deller wrote: > >> On 2/1/22 11:36, Daniel Vetter wrote: > >>> On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: > > On 1/31/22 22:05, Daniel Vetter

Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Improve error message when insufficient privilege

2022-02-01 Thread Dixit, Ashutosh
On Tue, 01 Feb 2022 07:19:46 -0800, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Print out end user friendly help text when the running user has > insufficient privilege for accessing system wide performance counters. Reviewed-by: Ashutosh Dixit > Signed-off-by: Tvrtko Ursulin > Issue:

Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference

2022-02-01 Thread Jani Nikula
Thanks for the patch, adding some Cc's from the commit that regressed. BR, Jani. On Tue, 01 Feb 2022, Lukasz Bartosik wrote: > From: Łukasz Bartosik > > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel. > The root cause is null pointer defeference of bi_next > in

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/: Re-work clflush_write32

2022-02-01 Thread Michael Cheng
Ah, thanks for the clarification! While discussion goes on about the route you suggested, could we land these patches (after addressing the reviews) to unblock compiling i915 on arm? On 2022-02-01 1:25 a.m., Tvrtko Ursulin wrote: On 31/01/2022 17:02, Michael Cheng wrote: Hey Tvrtko, Are

[Intel-gfx] [PATCH i-g-t] intel_gpu_top: Improve error message when insufficient privilege

2022-02-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Print out end user friendly help text when the running user has insufficient privilege for accessing system wide performance counters. Signed-off-by: Tvrtko Ursulin Issue: https://gitlab.freedesktop.org/drm/intel/-/issues/5018 --- tools/intel_gpu_top.c | 9 + 1

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Geert Uytterhoeven
On Mon, Jan 31, 2022 at 10:06 PM Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/core/ |

Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 2/1/22 14:45, Daniel Vetter wrote: > On Tue, Feb 1, 2022 at 12:01 PM Helge Deller wrote: >> On 2/1/22 11:36, Daniel Vetter wrote: >>> On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: On 1/31/22 22:05, Daniel Vetter wrote: > This functionally undoes 39aead8373b3 ("fbcon:

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Jani Nikula
On Mon, 31 Jan 2022, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/core/ | head -n5 >

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Nuke intel_bw_calc_min_cdclk()

2022-02-01 Thread Lisovskiy, Stanislav
On Tue, Feb 01, 2022 at 03:45:35PM +0200, Ville Syrjälä wrote: > On Tue, Feb 01, 2022 at 01:18:18PM +0200, Lisovskiy, Stanislav wrote: > > On Tue, Feb 01, 2022 at 12:05:13PM +0200, Ville Syrjälä wrote: > > > On Tue, Feb 01, 2022 at 10:52:39AM +0200, Lisovskiy, Stanislav wrote: > > > > On Tue, Jan

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Javier Martinez Canillas
On 1/31/22 22:05, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/core/ | head -n5 >

[Intel-gfx] ✓ Fi.CI.BAT: success for Compile out integrated

2022-02-01 Thread Patchwork
== Series Details == Series: Compile out integrated URL : https://patchwork.freedesktop.org/series/99570/ State : success == Summary == CI Bug Log - changes from CI_DRM_11172 -> Patchwork_22149 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Nuke intel_bw_calc_min_cdclk()

2022-02-01 Thread Ville Syrjälä
On Tue, Feb 01, 2022 at 01:18:18PM +0200, Lisovskiy, Stanislav wrote: > On Tue, Feb 01, 2022 at 12:05:13PM +0200, Ville Syrjälä wrote: > > On Tue, Feb 01, 2022 at 10:52:39AM +0200, Lisovskiy, Stanislav wrote: > > > On Tue, Jan 18, 2022 at 11:23:50AM +0200, Ville Syrjala wrote: > > > > From: Ville

Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Daniel Vetter
On Tue, Feb 1, 2022 at 12:01 PM Helge Deller wrote: > On 2/1/22 11:36, Daniel Vetter wrote: > > On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: > >> > >> On 1/31/22 22:05, Daniel Vetter wrote: > >>> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated > >>> scrolling"), but

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Compile out integrated

2022-02-01 Thread Patchwork
== Series Details == Series: Compile out integrated URL : https://patchwork.freedesktop.org/series/99570/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Compile out integrated

2022-02-01 Thread Patchwork
== Series Details == Series: Compile out integrated URL : https://patchwork.freedesktop.org/series/99570/ State : warning == Summary == $ dim checkpatch origin/drm-tip 15e05554122b igp kconfig -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:18:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg2: Enabling 64k page size and flat ccs (rev5)

2022-02-01 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Enabling 64k page size and flat ccs (rev5) URL : https://patchwork.freedesktop.org/series/95686/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11172 -> Patchwork_22148 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg2: Enabling 64k page size and flat ccs (rev5)

2022-02-01 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Enabling 64k page size and flat ccs (rev5) URL : https://patchwork.freedesktop.org/series/95686/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: Enabling 64k page size and flat ccs (rev5)

2022-02-01 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Enabling 64k page size and flat ccs (rev5) URL : https://patchwork.freedesktop.org/series/95686/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7f652d8d712c drm/i915: add needs_compact_pt flag f93c6346dd31 drm/i915: enforce min GTT

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: Return some errors instead of trying memcpy move

2022-02-01 Thread Thomas Hellström
On 2/1/22 10:16, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* drm/i915/ttm: Return some errors instead of trying memcpy move *URL:* https://patchwork.freedesktop.org/series/99553/ *State:*failure *Details:*

Re: [Intel-gfx] [RFC 2/2] jsl/ehl

2022-02-01 Thread Jani Nikula
On Tue, 01 Feb 2022, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin Should be split out and posted independently. Maybe we should consider s/IS_PLATFORM/__IS_PLATFORM/g too. BR, Jani. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 4 ++-- >

Re: [Intel-gfx] [PATCH 04/19] drm/i915: Move the power domain->well mappings to intel_display_power_map.c

2022-02-01 Thread Jani Nikula
On Tue, 01 Feb 2022, Jani Nikula wrote: > On Mon, 31 Jan 2022, Imre Deak wrote: >> On Mon, Jan 31, 2022 at 02:15:25PM +0200, Jani Nikula wrote: >>> On Fri, 28 Jan 2022, Imre Deak wrote: >>> > Move the list of platform specific power domain -> power well >>> > definitions to

Re: [Intel-gfx] [PATCH 10/19] drm/i915: Convert the u64 power well domains mask to a bitmap

2022-02-01 Thread Jani Nikula
On Fri, 28 Jan 2022, Imre Deak wrote: > To remove the aliasing of the power domain enum values in a follow-up > patch in this patchset (requiring a bigger mask) and allow for defining > additional power domains in the future (at least some upcoming TypeC > changes requires this) convert the u64

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Nuke intel_bw_calc_min_cdclk()

2022-02-01 Thread Lisovskiy, Stanislav
On Tue, Feb 01, 2022 at 12:05:13PM +0200, Ville Syrjälä wrote: > On Tue, Feb 01, 2022 at 10:52:39AM +0200, Lisovskiy, Stanislav wrote: > > On Tue, Jan 18, 2022 at 11:23:50AM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > intel_bw_calc_min_cdclk() is entirely pointless. All it

[Intel-gfx] [RFC 2/2] jsl/ehl

2022-02-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 4 ++-- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- drivers/gpu/drm/i915/i915_drv.h| 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [RFC 1/2] igp kconfig

2022-02-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig | 5 + drivers/gpu/drm/i915/Kconfig.platforms | 7 ++ drivers/gpu/drm/i915/i915_drv.h| 126 +++-- drivers/gpu/drm/i915/i915_pci.c| 44 - 4 files

[Intel-gfx] [RFC 0/2] Compile out integrated

2022-02-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Quicky and dirty hack based on some old ideas. Thought maybe the approach might interest the Arm port guys. But with IS_GEN_RANGE removed easy gains are not so big so meh.. Maybe some more easy wins with IS_DISPLAY_VER but I haven't looked into that side. 3884664 449681

Re: [Intel-gfx] [PULL] drm-misc-next

2022-02-01 Thread Thomas Zimmermann
Hi Am 01.02.22 um 09:17 schrieb Maarten Lankhorst: Op 01-02-2022 om 07:38 schreef Dave Airlie: On Thu, 27 Jan 2022 at 21:57, Maarten Lankhorst wrote: Hi Dave & Daniel, First pull for v5.18 I was trying to be all efficient and get this pulled in time for once. However it broke building on

Re: [Intel-gfx] [PATCH 09/19] drm/i915: Convert the power well descriptor domain mask to a list

2022-02-01 Thread Jani Nikula
On Fri, 28 Jan 2022, Imre Deak wrote: > The next patch converts the i915_power_well_desc::domain mask from a u64 > mask to a bitmap. I didn't find a reasonably simple way to initialize > bitmaps statically, so prepare for the next patch here by converting the > masks to a list and initing the

Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 2/1/22 11:36, Daniel Vetter wrote: > On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: >> >> On 1/31/22 22:05, Daniel Vetter wrote: >>> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated >>> scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION >>> option. >> >>

Re: [Intel-gfx] [PATCH 04/19] drm/i915: Move the power domain->well mappings to intel_display_power_map.c

2022-02-01 Thread Jani Nikula
On Mon, 31 Jan 2022, Imre Deak wrote: > On Mon, Jan 31, 2022 at 02:15:25PM +0200, Jani Nikula wrote: >> On Fri, 28 Jan 2022, Imre Deak wrote: >> > Move the list of platform specific power domain -> power well >> > definitions to intel_display_power_map.c. While at it group the >> > platforms'

Re: [Intel-gfx] [PATCH v5 07/19] drm/i915/migrate: add acceleration support for DG2

2022-02-01 Thread Matthew Auld
On 01/02/2022 10:41, Ramalingam C wrote: From: Matthew Auld This is all kinds of awkward since we now have to contend with using 64K GTT pages when mapping anything in LMEM(including the page-tables themselves). v2: Rebased [Ram] Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc:

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Greg Kroah-Hartman
On Tue, Feb 01, 2022 at 11:19:54AM +0100, Thomas Zimmermann wrote: > > > Am 31.01.22 um 22:05 schrieb Daniel Vetter: > > Ever since Tomi extracted the core code in 2014 it's been defacto me > > maintaining this, with help from others from dri-devel and sometimes > > Linus (but those are mostly

[Intel-gfx] [PATCH v5 18/19] drm/i915/Flat-CCS: Document on Flat-CCS memory compression

2022-02-01 Thread Ramalingam C
Documents the Flat-CCS feature and kernel handling required along with modifiers used. Signed-off-by: Ramalingam C cc: Simon Ser cc: Pekka Paalanen Cc: Jordan Justen Cc: Kenneth Graunke Cc: mesa-...@lists.freedesktop.org Cc: Tony Ye Cc: Slawomir Milczarek ---

[Intel-gfx] [PATCH v5 17/19] drm/i915/dg2: Flat CCS Support

2022-02-01 Thread Ramalingam C
From: Anshuman Gupta DG2 onwards discrete gfx has support for new flat CCS mapping, which brings in display feature in to avoid Aux walk for compressed surface. This support build on top of Flat CCS support added in XEHPSDV. FLAT CCS surface base address should be 64k aligned, Compressed

[Intel-gfx] [PATCH v5 16/19] uapi/drm/dg2: Introduce format modifier for DG2 clear color

2022-02-01 Thread Ramalingam C
From: Mika Kahola DG2 clear color render compression uses Tile4 layout. Therefore, we need to define a new format modifier for uAPI to support clear color rendering. v2: Display version is fixed. [Imre] KDoc is enhanced for cc modifier. [Nanley & Lionel] Signed-off-by: Mika Kahola cc:

[Intel-gfx] [PATCH v5 15/19] drm/i915/dg2: Add DG2 unified compression

2022-02-01 Thread Ramalingam C
From: Matt Roper DG2 unifies render compression and media compression into a single format for the first time. The programming and buffer layout is supposed to match compression on older gen12 platforms, but the actual compression algorithm is different from any previous platform; as such, we

[Intel-gfx] [PATCH v5 14/19] drm/i915/dg2: Tile 4 plane format support

2022-02-01 Thread Ramalingam C
From: Stanislav Lisovskiy Tile4 in bspec format is 4K tile organized into 64B subtiles with same basic shape as for legacy TileY which will be supported by Display13. v2: - Moved Tile4 assocating struct for modifier/display to the beginning(Imre Deak) - Removed unneeded case

[Intel-gfx] [PATCH v5 13/19] drm/i915: Introduce new Tile 4 format

2022-02-01 Thread Ramalingam C
From: Stanislav Lisovskiy This tiling layout uses 4KB tiles in a row-major layout. It has the same shape as Tile Y at two granularities: 4KB (128B x 32) and 64B (16B x 4). It only differs from Tile Y at the 256B granularity in between. At this granularity, Tile Y has a shape of 16B x 32 rows,

[Intel-gfx] [PATCH v5 12/19] drm/i915/gt: Clear compress metadata for Xe_HP platforms

2022-02-01 Thread Ramalingam C
From: Ayaz A Siddiqui Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. Flat CCS memory can not be directly accessed by S/W.

[Intel-gfx] [PATCH v5 11/19] drm/i915/lmem: Enable lmem for platforms with Flat CCS

2022-02-01 Thread Ramalingam C
From: Abdiel Janulgue A portion of device memory is reserved for Flat CCS so usable device memory will be reduced by size of Flat CCS. Size of Flat CCS is specified in “XEHPSDV_FLAT_CCS_BASE_ADDR”. So to get effective device memory we need to subtract total device memory by Flat CCS memory size.

[Intel-gfx] [PATCH v5 10/19] drm/i915/xehpsdv: Add has_flat_ccs to device info

2022-02-01 Thread Ramalingam C
From: CQ Tang Platforms of XeHP and beyond support 3D surface (buffer) compression and various compression formats. This is accomplished by an additional compression control state (CCS) stored for each surface. Gen 12 devices(TGL family and DG1) stores compression states in a separate region of

[Intel-gfx] [PATCH v5 09/19] Doc/gpu/rfc/i915: i915 DG2 64k pagesize uAPI

2022-02-01 Thread Ramalingam C
Details of the 64k pagesize support added as part of DG2 enabling and its implicit impact on the uAPI. v2: improvised the Flat-CCS documentation [Danvet & CQ] v3: made only for 64k pagesize support Signed-off-by: Ramalingam C cc: Daniel Vetter cc: Matthew Auld cc: Simon Ser cc: Pekka

[Intel-gfx] [PATCH v5 08/19] drm/i915/uapi: document behaviour for DG2 64K support

2022-02-01 Thread Ramalingam C
From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for this. v3: fix typos and less emphasis v2: Fixed suggestions on

[Intel-gfx] [PATCH v5 07/19] drm/i915/migrate: add acceleration support for DG2

2022-02-01 Thread Ramalingam C
From: Matthew Auld This is all kinds of awkward since we now have to contend with using 64K GTT pages when mapping anything in LMEM(including the page-tables themselves). v2: Rebased [Ram] Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C ---

[Intel-gfx] [PATCH v5 04/19] drm/i915: add gtt misalignment test

2022-02-01 Thread Ramalingam C
From: Robert Beckett add test to check handling of misaligned offsets and sizes v4: * remove spurious blank lines * explicitly cast intel_region_id to intel_memory_type in misaligned_pin Reported-by: kernel test robot v6: * use NEEDS_COMPACT_PT instead of hard coding

[Intel-gfx] [PATCH v5 06/19] drm/i915/gtt: add xehpsdv_ppgtt_insert_entry

2022-02-01 Thread Ramalingam C
From: Matthew Auld If this is LMEM then we get a 32 entry PT, with each PTE pointing to some 64K block of memory, otherwise it's just the usual 512 entry PT. This very much assumes the caller knows what they are doing. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C

[Intel-gfx] [PATCH v5 05/19] drm/i915/gtt: allow overriding the pt alignment

2022-02-01 Thread Ramalingam C
From: Matthew Auld On some platforms we have alignment restrictions when accessing LMEM from the GTT. In the next patch few patches we need to be able to modify the page-tables directly via the GTT itself. Suggested-by: Ramalingam C Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc:

[Intel-gfx] [PATCH v5 03/19] drm/i915: support 64K GTT pages for discrete cards

2022-02-01 Thread Ramalingam C
From: Matthew Auld discrete cards optimise 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly. 4K pages for local-memory are no

[Intel-gfx] [PATCH v5 02/19] drm/i915: enforce min GTT alignment for discrete cards

2022-02-01 Thread Ramalingam C
From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. We need to support vm->min_alignment > 4K, depending on the vm itself and the type of object we are inserting. With this in mind update the GTT selftests to take this into

[Intel-gfx] [PATCH v5 01/19] drm/i915: add needs_compact_pt flag

2022-02-01 Thread Ramalingam C
Add a new platform flag, needs_compact_pt, to mark the requirement of compact pt layout support for the ppGTT when using 64K GTT pages. With this flag has_64k_pages will only indicate requirement of 64K GTT page sizes or larger for device local memory access. v6: * minor doc formatting

[Intel-gfx] [PATCH v5 00/19] drm/i915/dg2: Enabling 64k page size and flat ccs

2022-02-01 Thread Ramalingam C
This series introduces the enabling patches for new memory compression feature Flat CCS and 64k page support for i915 local memory, along with documentation on the uAPI impact. Included the details of the feature and the implications on the uAPI below. Which is also added into

Re: [Intel-gfx] [PATCH 09/20] drm/i915/buddy: tweak 2big check

2022-02-01 Thread Thomas Hellström
On Wed, 2022-01-26 at 15:21 +, Matthew Auld wrote: > Otherwise we get -EINVAL, instead of the more useful -E2BIG if the > allocation doesn't fit within the pfn range, like with mappable lmem. > The hugepages selftest, for example, needs this to know if a smaller > size is needed. > >

Re: [Intel-gfx] [PATCH 08/20] drm/i915/buddy: adjust res->start

2022-02-01 Thread Thomas Hellström
On Wed, 2022-01-26 at 15:21 +, Matthew Auld wrote: > Differentiate between mappable vs non-mappable resources, also if > this > is an actual range allocation ensure we set res->start as the > starting > pfn. Later when we need to do non-mappable -> mappable moves then we > want TTM to see that

Re: [Intel-gfx] [PATCH 09/21] fbcon: Replace FBCON_FLAGS_INIT with a boolean

2022-02-01 Thread Thomas Zimmermann
Am 31.01.22 um 22:05 schrieb Daniel Vetter: It's only one flag and slightly tidier code. Signed-off-by: Daniel Vetter Cc: Daniel Vetter Cc: Tetsuo Handa Cc: Greg Kroah-Hartman Cc: Du Cheng Cc: Thomas Zimmermann Cc: Claudio Suarez Acked-by: Thomas Zimmermann ---

Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Daniel Vetter
On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: > > On 1/31/22 22:05, Daniel Vetter wrote: > > This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated > > scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION > > option. > > you have two trivial copy-n-paste errors in

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Helge Deller
On 1/31/22 22:05, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/core/ | head -n5 > 35

Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 1/31/22 22:05, Daniel Vetter wrote: > This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated > scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION > option. you have two trivial copy-n-paste errors in this patch which still prevent the console acceleration. > diff

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Thomas Zimmermann
Am 31.01.22 um 22:05 schrieb Daniel Vetter: Ever since Tomi extracted the core code in 2014 it's been defacto me maintaining this, with help from others from dri-devel and sometimes Linus (but those are mostly merge conflicts): $ git shortlog -ns drivers/video/fbdev/core/ | head -n5 35

[Intel-gfx] ✗ Fi.CI.IGT: failure for Minor Fixes and Refactoring for HDMI PCON stuff (rev2)

2022-02-01 Thread Patchwork
== Series Details == Series: Minor Fixes and Refactoring for HDMI PCON stuff (rev2) URL : https://patchwork.freedesktop.org/series/99311/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11168_full -> Patchwork_22146_full

Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 2/1/22 11:16, Helge Deller wrote: > On 1/31/22 22:05, Daniel Vetter wrote: >> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated >> scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION >> option. > > you have two trivial copy-n-paste errors in this patch which

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Nuke intel_bw_calc_min_cdclk()

2022-02-01 Thread Ville Syrjälä
On Tue, Feb 01, 2022 at 10:52:39AM +0200, Lisovskiy, Stanislav wrote: > On Tue, Jan 18, 2022 at 11:23:50AM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > intel_bw_calc_min_cdclk() is entirely pointless. All it manages to do is > > somehow conflate the per-pipe min cdclk with dbuf

Re: [Intel-gfx] [PATCH] drm/i915/ttm: Return some errors instead of trying memcpy move

2022-02-01 Thread Matthew Auld
On 01/02/2022 07:03, Thomas Hellström wrote: The i915_ttm_accel_move() function may return error codes that should be propagated further up the stack rather than consumed assuming that the accel move failed and could be replaced with a memcpy move. For -EINTR, -ERESTARTSYS and -EAGAIN, just

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gt: Re-work invalidate_csb_entries

2022-02-01 Thread Tvrtko Ursulin
On 31/01/2022 14:15, Mika Kuoppala wrote: Tvrtko Ursulin writes: On 28/01/2022 22:10, Michael Cheng wrote: Re-work invalidate_csb_entries to use drm_clflush_virt_range. This will prevent compiler errors when building for non-x86 architectures. Signed-off-by: Michael Cheng ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm-misc-next (rev2)

2022-02-01 Thread Patchwork
== Series Details == Series: drm-misc-next (rev2) URL : https://patchwork.freedesktop.org/series/31921/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11169 -> Patchwork_22147 Summary --- **FAILURE** Serious

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/: Re-work clflush_write32

2022-02-01 Thread Tvrtko Ursulin
On 31/01/2022 17:02, Michael Cheng wrote: Hey Tvrtko, Are you saying when adding drm_clflush_virt_range(addr, sizeof(addr), this function forces an x86 code path only? If that is the case, drm_clflush_virt_range(addr, sizeof(addr) currently has ifdefs that seperate out x86 and powerpc, so

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: Return some errors instead of trying memcpy move

2022-02-01 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Return some errors instead of trying memcpy move URL : https://patchwork.freedesktop.org/series/99553/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11168_full -> Patchwork_22145_full

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel-fixes tree

2022-02-01 Thread Tvrtko Ursulin
On 31/01/2022 22:27, Stephen Rothwell wrote: Hi all, After merging the drm-intel-fixes tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/i915/i915_vma.c: In function 'i915_vma_bind': drivers/gpu/drm/i915/i915_vma.c:451:25: error: 'ret' undeclared (first

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm-misc-next (rev2)

2022-02-01 Thread Patchwork
== Series Details == Series: drm-misc-next (rev2) URL : https://patchwork.freedesktop.org/series/31921/ State : warning == Summary == $ dim checkpatch origin/drm-tip 887f74cb4db5 drm-misc-next -:50: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 0 checks,

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Nuke intel_bw_calc_min_cdclk()

2022-02-01 Thread Lisovskiy, Stanislav
On Tue, Jan 18, 2022 at 11:23:50AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > intel_bw_calc_min_cdclk() is entirely pointless. All it manages to do is > somehow conflate the per-pipe min cdclk with dbuf min cdclk. There is no > (at least documented) dbuf min cdclk limit on pre-skl so

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915: Fix header test for !CONFIG_X86

2022-02-01 Thread Siva Mullati
Reviewed-by: Siva Mullati On 31/01/22 10:29 pm, Lucas De Marchi wrote: > Architectures others than x86 have a stub implementation calling > WARN_ON_ONCE(). The appropriate headers need to be included, otherwise > the header-test target will fail with: > > HDRTEST drivers/gpu/drm/i915/i915_mm.h

  1   2   >