Re: [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-08 Thread Abhinav Kumar
On 4/7/2022 4:12 PM, Rob Clark wrote: On Thu, Apr 7, 2022 at 3:59 PM Abhinav Kumar wrote: Hi Rob and Daniel On 4/7/2022 3:51 PM, Rob Clark wrote: On Wed, Apr 6, 2022 at 6:27 PM Jessica Zhang wrote: On 3/31/2022 8:20 AM, Daniel Vetter wrote: The stuff never really worked, and leads

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/dp: Factor out a function to probe a DPCD address (rev2)

2022-04-08 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/dp: Factor out a function to probe a DPCD address (rev2) URL : https://patchwork.freedesktop.org/series/102428/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11479_full -> Patchwork_22833_full

[Intel-gfx] ✓ Fi.CI.IGT: success for Update to GuC v70

2022-04-08 Thread Patchwork
== Series Details == Series: Update to GuC v70 URL : https://patchwork.freedesktop.org/series/102430/ State : success == Summary == CI Bug Log - changes from CI_DRM_11479_full -> Patchwork_22832_full Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/dp: Factor out a function to probe a DPCD address (rev2)

2022-04-08 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/dp: Factor out a function to probe a DPCD address (rev2) URL : https://patchwork.freedesktop.org/series/102428/ State : success == Summary == CI Bug Log - changes from CI_DRM_11479 -> Patchwork_22833

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/uncore: Warn only if unclaimed access remains flagged

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915/uncore: Warn only if unclaimed access remains flagged URL : https://patchwork.freedesktop.org/series/102424/ State : success == Summary == CI Bug Log - changes from CI_DRM_11479_full -> Patchwork_22830_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/dp: Factor out a function to probe a DPCD address (rev2)

2022-04-08 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/dp: Factor out a function to probe a DPCD address (rev2) URL : https://patchwork.freedesktop.org/series/102428/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/dp: Factor out a function to probe a DPCD address (rev2)

2022-04-08 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/dp: Factor out a function to probe a DPCD address (rev2) URL : https://patchwork.freedesktop.org/series/102428/ State : warning == Summary == $ dim checkpatch origin/drm-tip 29958f7974ac drm/dp: Factor out a function to probe a

Re: [Intel-gfx] [v2, 1/2] drm/dp: Factor out a function to probe a DPCD address

2022-04-08 Thread Imre Deak
On Sat, Apr 09, 2022 at 01:47:21AM +0300, Almahallawy, Khaled wrote: > On Fri, 2022-04-08 at 20:21 +0300, Imre Deak wrote: > > Factor out from drm_dp_dpcd_read() a function to probe a DPCD address > > with a 1-byte read access. This will be needed by the next patch > > doing a > > read from an

[Intel-gfx] [PATCH v3 2/2] drm/i915/dp: Add workaround for spurious AUX timeouts/hotplugs on LTTPR links

2022-04-08 Thread Imre Deak
Some ADLP DP link configuration at least with multiple LTTPRs expects the first DPCD access during the LTTPR/DPCD detection after hotplug to be a read from the LTTPR range starting with DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV. The side effect of this read is to put each LTTPR into the

Re: [Intel-gfx] [v2, 1/2] drm/dp: Factor out a function to probe a DPCD address

2022-04-08 Thread Almahallawy, Khaled
On Fri, 2022-04-08 at 20:21 +0300, Imre Deak wrote: > Factor out from drm_dp_dpcd_read() a function to probe a DPCD address > with a 1-byte read access. This will be needed by the next patch > doing a > read from an LTTPR address, which must happen without the preceding > wake-up read in

[Intel-gfx] ✓ Fi.CI.BAT: success for Update to GuC v70

2022-04-08 Thread Patchwork
== Series Details == Series: Update to GuC v70 URL : https://patchwork.freedesktop.org/series/102430/ State : success == Summary == CI Bug Log - changes from CI_DRM_11479 -> Patchwork_22832 Summary --- **WARNING** Minor unknown

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update to GuC v70

2022-04-08 Thread Patchwork
== Series Details == Series: Update to GuC v70 URL : https://patchwork.freedesktop.org/series/102430/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Update to GuC v70

2022-04-08 Thread Patchwork
== Series Details == Series: Update to GuC v70 URL : https://patchwork.freedesktop.org/series/102430/ State : warning == Summary == $ dim checkpatch origin/drm-tip ca0a801b1dda drm/i915/guc: Update context registration to new GuC API -:418: WARNING:IF_0: Consider removing the code enclosed by

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/dp: Factor out a function to probe a DPCD address

2022-04-08 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/dp: Factor out a function to probe a DPCD address URL : https://patchwork.freedesktop.org/series/102428/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11479 -> Patchwork_22831

Re: [Intel-gfx] [PATCH 3/4] drm/fourcc: Introduce format modifier for DG2 clear color

2022-04-08 Thread Maarten Lankhorst
Op 07-04-2022 om 15:37 schreef Juha-Pekka Heikkila: > Reviewed-by: Juha-Pekka Heikkila > > On 4.4.2022 16.38, Imre Deak wrote: >> From: Mika Kahola >> >> DG2 clear color render compression uses Tile4 layout. Therefore, we need >> to define a new format modifier for uAPI to support clear color

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/dp: Factor out a function to probe a DPCD address

2022-04-08 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/dp: Factor out a function to probe a DPCD address URL : https://patchwork.freedesktop.org/series/102428/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uncore: Warn only if unclaimed access remains flagged

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915/uncore: Warn only if unclaimed access remains flagged URL : https://patchwork.freedesktop.org/series/102424/ State : success == Summary == CI Bug Log - changes from CI_DRM_11479 -> Patchwork_22830

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL (rev2)

2022-04-08 Thread Vudum, Lakshminarayana
Issues are related to following (just filed #5614) https://gitlab.freedesktop.org/drm/intel/-/issues/636 [CI][DRMTIP]igt@kms_flip@2x-flip-vs-suspend - dmesg-warn - WARNING: CPU: \d PID: \d+ at drivers/misc/mei/hbm.c:\d+ mei_hbm_dispatch\+.* https://gitlab.freedesktop.org/drm/intel/-/issues/5614

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL (rev2)

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL (rev2) URL : https://patchwork.freedesktop.org/series/102352/ State : success == Summary == CI Bug Log - changes from CI_DRM_11477_full -> Patchwork_22829_full

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL (rev2)

2022-04-08 Thread Matt Roper
On Fri, Apr 08, 2022 at 06:47:48PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL > (rev2) > URL : https://patchwork.freedesktop.org/series/102352/ > State : failure > > == Summary == > > CI Bug Log - changes

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL (rev2)

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL (rev2) URL : https://patchwork.freedesktop.org/series/102352/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11477_full -> Patchwork_22829_full

[Intel-gfx] [PATCH 3/3] drm/i915/guc: Update to GuC version 70.1.1

2022-04-08 Thread John . C . Harrison
From: John Harrison Update to the latest GuC firmware release. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c

[Intel-gfx] [PATCH 2/3] drm/i915/guc: Update scheduling policies to new GuC API

2022-04-08 Thread John . C . Harrison
From: John Harrison The latest GuC firmware drops the individual scheduling policy update H2G commands in favour of a single KLV based H2G. So, change the update wrappers accordingly. Unfortunately, the API changes also mean losing the ability to set any scheduling policy values during context

[Intel-gfx] [PATCH 1/3] drm/i915/guc: Update context registration to new GuC API

2022-04-08 Thread John . C . Harrison
From: John Harrison The latest GuC firmware drops the context descriptor pool in favour of passing all creation data in the create H2G. It also greatly simplifies the work queue and removes the process descriptor used for multi-LRC submission. So, remove all mention of LRC and process

[Intel-gfx] [PATCH 0/3] Update to GuC v70

2022-04-08 Thread John . C . Harrison
From: John Harrison Update to the latest GuC firmware release. Note that this includes some significant backwards breaking API changes. One is about context registration - the descriptor pool is gone, all parameters are passed via the CTB instead. The second is about scheduling policy updates -

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix skl_pcode_try_request function

2022-04-08 Thread Lisovskiy, Stanislav
On Fri, Apr 08, 2022 at 06:59:07PM +0300, Ville Syrjälä wrote: > On Fri, Apr 08, 2022 at 06:46:00PM +0300, Ville Syrjälä wrote: > > On Fri, Apr 08, 2022 at 03:51:59PM +0300, Stanislav Lisovskiy wrote: > > > Currently skl_pcode_try_request function doesn't > > > properly handle return value it gets

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Swap ret and status returned from skl_pcode_request

2022-04-08 Thread Govindapillai, Vinod
On Fri, 2022-04-08 at 15:52 +0300, Stanislav Lisovskiy wrote: > If ret isn't zero, it is almost for sure ETIMEDOUT, because > we use it in wait_for macro which does continuous retries > until timeout is reached. If we still ran out of time and > retries, we most likely would be interested in

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix skl_pcode_try_request function

2022-04-08 Thread Lisovskiy, Stanislav
On Fri, Apr 08, 2022 at 06:46:00PM +0300, Ville Syrjälä wrote: > On Fri, Apr 08, 2022 at 03:51:59PM +0300, Stanislav Lisovskiy wrote: > > Currently skl_pcode_try_request function doesn't > > properly handle return value it gets from > > snb_pcode_rw, but treats status != 0 as success, > >

[Intel-gfx] [PATCH v2 2/2] drm/i915/dp: Add workaround for spurious AUX timeouts/hotplugs on LTTPR links

2022-04-08 Thread Imre Deak
Some ADLP DP link configuration at least with multiple LTTPRs expects the first DPCD access during the LTTPR/DPCD detection after hotplug to be a read from the LTTPR range starting with DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV. The side effect of this read is to put each LTTPR into the

[Intel-gfx] [PATCH v2 1/2] drm/dp: Factor out a function to probe a DPCD address

2022-04-08 Thread Imre Deak
Factor out from drm_dp_dpcd_read() a function to probe a DPCD address with a 1-byte read access. This will be needed by the next patch doing a read from an LTTPR address, which must happen without the preceding wake-up read in drm_dp_dpcd_read(). v2: Add a probe function instead of exporting

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix warnings about PSR lock not held (rev4)

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix warnings about PSR lock not held (rev4) URL : https://patchwork.freedesktop.org/series/102298/ State : success == Summary == CI Bug Log - changes from CI_DRM_11477_full -> Patchwork_22828_full

Re: [Intel-gfx] [PATCH] drm/i915/uncore: Warn only if unclaimed access remains flagged

2022-04-08 Thread Matt Roper
On Fri, Apr 08, 2022 at 09:48:37AM -0700, Lucas De Marchi wrote: > Commit 4b276ed3c7ac ("drm/i915/uncore: Warn on previous unclaimed > accesses") tried to improve our report of unclaimed register access, > however it unveiled cases that were not previously causing any harm. > > Downgrade the

[Intel-gfx] [PATCH] drm/i915/uncore: Warn only if unclaimed access remains flagged

2022-04-08 Thread Lucas De Marchi
Commit 4b276ed3c7ac ("drm/i915/uncore: Warn on previous unclaimed accesses") tried to improve our report of unclaimed register access, however it unveiled cases that were not previously causing any harm. Downgrade the first message to debug so we can still see them and eventually fix, but don't

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL (rev2)

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL (rev2) URL : https://patchwork.freedesktop.org/series/102352/ State : success == Summary == CI Bug Log - changes from CI_DRM_11477 -> Patchwork_22829

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix skl_pcode_try_request function

2022-04-08 Thread Ville Syrjälä
On Fri, Apr 08, 2022 at 06:46:00PM +0300, Ville Syrjälä wrote: > On Fri, Apr 08, 2022 at 03:51:59PM +0300, Stanislav Lisovskiy wrote: > > Currently skl_pcode_try_request function doesn't > > properly handle return value it gets from > > snb_pcode_rw, but treats status != 0 as success, > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix warnings about PSR lock not held (rev4)

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix warnings about PSR lock not held (rev4) URL : https://patchwork.freedesktop.org/series/102298/ State : success == Summary == CI Bug Log - changes from CI_DRM_11477 -> Patchwork_22828

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix skl_pcode_try_request function

2022-04-08 Thread Ville Syrjälä
On Fri, Apr 08, 2022 at 03:51:59PM +0300, Stanislav Lisovskiy wrote: > Currently skl_pcode_try_request function doesn't > properly handle return value it gets from > snb_pcode_rw, but treats status != 0 as success, > returning true, which basically doesn't allow > to use retry/timeout mechanisms

Re: [Intel-gfx] [PATCH 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-08 Thread Modem, Bhanuprakash
On Fri-08-04-2022 08:32 pm, Harry Wentland wrote: On 2022-04-08 02:53, Bhanuprakash Modem wrote: It's useful to know the connector's max supported bpc for IGT testing. Expose it via a debugfs file on the connector "output_bpc". Example: cat /sys/kernel/debug/dri/0/DP-1/output_bpc Cc: Jani

Re: [Intel-gfx] [PATCH 3/3] drm/amd/display: Move connector debugfs to drm

2022-04-08 Thread Modem, Bhanuprakash
On Fri-08-04-2022 08:33 pm, Harry Wentland wrote: On 2022-04-08 02:53, Bhanuprakash Modem wrote: As drm_connector already have the display_info, instead of creating "output_bpc" debugfs in vendor specific driver, move the logic to the drm layer. This patch will also move "Current" bpc to the

[Intel-gfx] ✓ Fi.CI.IGT: success for Fix issues in skl_pcode_request

2022-04-08 Thread Patchwork
== Series Details == Series: Fix issues in skl_pcode_request URL : https://patchwork.freedesktop.org/series/102410/ State : success == Summary == CI Bug Log - changes from CI_DRM_11477_full -> Patchwork_22827_full Summary ---

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Inherit submitter nice when scheduling requests

2022-04-08 Thread Daniel Vetter
On Fri, 8 Apr 2022 at 12:29, Tvrtko Ursulin wrote: > > > On 08/04/2022 10:50, Dave Airlie wrote: > > On Fri, 8 Apr 2022 at 18:25, Tvrtko Ursulin > > wrote: > >> > >> > >> On 08/04/2022 08:58, Daniel Vetter wrote: > >>> On Thu, Apr 07, 2022 at 04:16:27PM +0100, Tvrtko Ursulin wrote: > From:

Re: [Intel-gfx] [PATCH] drm/i915/uncore: Warn on previous unclaimed accesses

2022-04-08 Thread Lucas De Marchi
On Fri, Apr 08, 2022 at 01:44:44PM +0100, Tvrtko Ursulin wrote: On 05/04/2022 01:11, Lucas De Marchi wrote: Since gen6 we use FPGA_DBG register to detect unclaimed MMIO registers. This register is in the display engine IP and can only ever detect unclaimed accesses to registers in this area.

Re: [Intel-gfx] [PATCH v2 22/22] drm/i915/bios: Dump PNPID and panel name

2022-04-08 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 09:07:19PM +0300, Jani Nikula wrote: > On Tue, 05 Apr 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Dump the panel PNPID and name from the VBT. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/display/intel_bios.c | 24

Re: [Intel-gfx] [PATCH v4 18/22] drm/i915/bios: Determine panel type via PNPID match

2022-04-08 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 08:55:29PM +0300, Jani Nikula wrote: > On Wed, 06 Apr 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Apparently when the VBT panel_type==0xff we should trawl through > > the PNPID table and check for a match against the EDID. If a > > match is found the index

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-04-08 Thread Thomas Hellström
On 3/14/22 19:20, Ramalingam C wrote: From: Chris Wilson Even though the initial protocontext we load onto HW has the register cleared, by the time we save it into the default image, BB_OFFSET has had the enable bit set. Reclear BB_OFFSET for each new context. Testcase:

Re: [Intel-gfx] [PATCH 4/4] drm/i915/selftest: Always cancel semaphore on error

2022-04-08 Thread Thomas Hellström
On 3/14/22 19:20, Ramalingam C wrote: From: Chris Wilson Ensure that we always signal the semaphore when timing out, so that if it happens to be stuck waiting for the semaphore we will quickly recover without having to wait for a reset. Reported-by: CQ Tang Signed-off-by: Chris Wilson Cc:

Re: [Intel-gfx] [PATCH 3/4] drm/i915/selftest: Clear the output buffers before GPU writes

2022-04-08 Thread Thomas Hellström
On 3/14/22 19:20, Ramalingam C wrote: From: Chris Wilson When testing whether we can get the GPU to leak information about non-privileged state, we first need to ensure that the output buffer is set to a known value as the HW may opt to skip the write into memory for a non-privileged read of

Re: [Intel-gfx] [PATCH 2/4] drm/i915/selftests: Check for incomplete LRI from the context image

2022-04-08 Thread Intel
On 3/14/22 19:20, Ramalingam C wrote: From: Chris Wilson In order to keep the context image parser simple, we assume that all commands follow a similar format. A few, especially not MI commands on the render engines, have fixed lengths not encoded in a length field. This caused us to

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Fix warnings about PSR lock not held (rev4)

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix warnings about PSR lock not held (rev4) URL : https://patchwork.freedesktop.org/series/102298/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11477 -> Patchwork_22828

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Fix warnings about PSR lock not held (rev3)

2022-04-08 Thread Vudum, Lakshminarayana
Issue is related to https://gitlab.freedesktop.org/drm/intel/-/issues/5602 All tests - *ERROR* Scratch setup failed, DEBUG_LOCKS_WARN_ON(lock->magic != lock) Lakshmi. From: Souza, Jose Sent: Thursday, April 7, 2022 2:05 PM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Subject:

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL

2022-04-08 Thread Vudum, Lakshminarayana
Regression is related to https://gitlab.freedesktop.org/drm/intel/-/issues/5602 All tests - *ERROR* Scratch setup failed, DEBUG_LOCKS_WARN_ON(lock->magic != lock) Lakshmi. -Original Message- From: Roper, Matthew D Sent: Thursday, April 7, 2022 4:15 PM To:

Re: [Intel-gfx] [PATCH v2 17/22] drm/i915/bios: Refactor panel_type code

2022-04-08 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 08:49:00PM +0300, Jani Nikula wrote: > On Tue, 05 Apr 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Make the panel type code a bit more abstract along the > > lines of the source of the panel type. For the moment > > we have three classes: OpRegion, VBT,

Re: [Intel-gfx] [PATCH v2 12/22] drm/i915/bios: Split VBT parsing to global vs. panel specific parts

2022-04-08 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 08:23:03PM +0300, Jani Nikula wrote: > On Tue, 05 Apr 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Parsing the panel specific data from VBT is currently happening > > too early. Split the whole thing into global vs. panel specific > > parts so that we can

Re: [Intel-gfx] [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-08 Thread Wang, Zhi A
Hi Jani: Thanks so much for the help. Can you generate a new tag on drm-intel-next? I noticed that there was one patch moving the DMC related registers into display/intel_dmc_regs.h, which is not included in the latest tag on drm-intel-next. Guess it would be better that I can change this

Re: [Intel-gfx] [PATCH v3 09/22] drm/i915/bios: Get access to the tail end of the LFP data block

2022-04-08 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 08:07:24PM +0300, Jani Nikula wrote: > On Wed, 06 Apr 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We need to start parsing stuff from the tail end of the LFP data block. > > This is made awkward by the fact that the fp_timing table has variable > > size. So

[Intel-gfx] ✓ Fi.CI.BAT: success for Fix issues in skl_pcode_request

2022-04-08 Thread Patchwork
== Series Details == Series: Fix issues in skl_pcode_request URL : https://patchwork.freedesktop.org/series/102410/ State : success == Summary == CI Bug Log - changes from CI_DRM_11477 -> Patchwork_22827 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v2 07/22] drm/i915/bios: Reorder panel DTD parsing

2022-04-08 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 07:21:44PM +0300, Jani Nikula wrote: > On Tue, 05 Apr 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Reorder things so that we can parse the entier LFP data block > > *entire > > > in one go. For now we just stick to parsing the DTD from it. > > > > Also fix

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix issues in skl_pcode_request

2022-04-08 Thread Patchwork
== Series Details == Series: Fix issues in skl_pcode_request URL : https://patchwork.freedesktop.org/series/102410/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6934e112b8f9 drm/i915: Fix skl_pcode_try_request function -:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped

[Intel-gfx] ✗ Fi.CI.BAT: failure for Expose max and current bpc via debugfs

2022-04-08 Thread Patchwork
== Series Details == Series: Expose max and current bpc via debugfs URL : https://patchwork.freedesktop.org/series/102390/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11477 -> Patchwork_22825 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix i915_gem_object_wait_moving_fence

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915: fix i915_gem_object_wait_moving_fence URL : https://patchwork.freedesktop.org/series/102396/ State : failure == Summary == Applying: drm/i915: fix i915_gem_object_wait_moving_fence Using index info to reconstruct a base tree... M

Re: [Intel-gfx] [PATCH 3/3] drm/amd/display: Move connector debugfs to drm

2022-04-08 Thread kernel test robot
Hi Bhanuprakash, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip next-20220408] [cannot apply to drm/drm-next v5.18-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Expose max and current bpc via debugfs

2022-04-08 Thread Patchwork
== Series Details == Series: Expose max and current bpc via debugfs URL : https://patchwork.freedesktop.org/series/102390/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: 0.5.1 (Ubuntu: 0.5.1-2) Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH 2/2] drm/i915: Swap ret and status returned from skl_pcode_request

2022-04-08 Thread Stanislav Lisovskiy
If ret isn't zero, it is almost for sure ETIMEDOUT, because we use it in wait_for macro which does continuous retries until timeout is reached. If we still ran out of time and retries, we most likely would be interested in getting status, to understand what was the actual error propagated from

[Intel-gfx] [PATCH 1/2] drm/i915: Fix skl_pcode_try_request function

2022-04-08 Thread Stanislav Lisovskiy
Currently skl_pcode_try_request function doesn't properly handle return value it gets from snb_pcode_rw, but treats status != 0 as success, returning true, which basically doesn't allow to use retry/timeout mechanisms if PCode happens to be busy and returns EGAIN or some other status code not

[Intel-gfx] [PATCH 0/2] Fix issues in skl_pcode_request

2022-04-08 Thread Stanislav Lisovskiy
Couple of crucial fixes for skl_pcode_request function. 1) Correctly handle the error and do retires until timeout 2) Return PCode request status, when failure happens Stanislav Lisovskiy (2): drm/i915: Fix skl_pcode_try_request function drm/i915: Swap ret and status returned from

Re: [Intel-gfx] [PATCH] drm/i915/uncore: Warn on previous unclaimed accesses

2022-04-08 Thread Tvrtko Ursulin
On 05/04/2022 01:11, Lucas De Marchi wrote: Since gen6 we use FPGA_DBG register to detect unclaimed MMIO registers. This register is in the display engine IP and can only ever detect unclaimed accesses to registers in this area. However sometimes there are reports of this triggering for

Re: [Intel-gfx] [PATCH v11 01/13] drm/i915/guc: Update GuC ADS size for error capture lists

2022-04-08 Thread Tvrtko Ursulin
On 17/03/2022 18:56, Alan Previn wrote: Update GuC ADS size allocation to include space for the lists of error state capture register descriptors. Then, populate GuC ADS with the lists of registers we want GuC to report back to host on engine reset events. This list should include global,

Re: [Intel-gfx] [PATCH v2] drm/i915: fix i915_gem_object_wait_moving_fence

2022-04-08 Thread Matthew Auld
On 08/04/2022 10:48, Matthew Auld wrote: On 08/04/2022 09:59, Christian König wrote: Am 08.04.22 um 10:42 schrieb Matthew Auld: All of CI is just failing with the following, which prevents loading of the module: i915 :03:00.0: [drm] *ERROR* Scratch setup failed Best guess is that

Re: [Intel-gfx] [PATCH 20/20] drm/i915/gsc: allocate extended operational memory in LMEM

2022-04-08 Thread Matthew Auld
On Thu, 7 Apr 2022 at 14:00, Alexander Usyskin wrote: > > From: Tomas Winkler > > GSC requires more operational memory than available on chip. > Reserve 4M of LMEM for GSC operation. The memory is provided to the > GSC as struct resource to the auxiliary data of the child device. > >

Re: [Intel-gfx] [PATCH] drm/i915/display/debugfs: Add connector debugfs for "output_bpc"

2022-04-08 Thread Modem, Bhanuprakash
On Mon-04-04-2022 09:11 pm, Daniel Vetter wrote: On Mon, Apr 04, 2022 at 01:46:23PM +0300, Jani Nikula wrote: On Mon, 04 Apr 2022, "Modem, Bhanuprakash" wrote: On Fri-01-04-2022 06:10 pm, Jani Nikula wrote: On Tue, 29 Mar 2022, Bhanuprakash Modem wrote: This new debugfs will expose the

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Inherit submitter nice when scheduling requests

2022-04-08 Thread Tvrtko Ursulin
On 08/04/2022 10:50, Dave Airlie wrote: On Fri, 8 Apr 2022 at 18:25, Tvrtko Ursulin wrote: On 08/04/2022 08:58, Daniel Vetter wrote: On Thu, Apr 07, 2022 at 04:16:27PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Inherit submitter nice at point of request submission to account for

Re: [Intel-gfx] [PATCH] drivers: Fix spelling mistake "writting" -> "writing"

2022-04-08 Thread Jani Nikula
On Fri, 08 Apr 2022, cgel@gmail.com wrote: > From: Lv Ruyi > > There are some spelling mistakes in the comments. Fix it. Please prefer splitting by driver. This isn't even split by subsystem. I presume there are very few maintainers willing to pick this up as it is. BR, Jani. > >

Re: [Intel-gfx] [PATCH 12/15] drm/i915: drop bo->moving dependency

2022-04-08 Thread Jani Nikula
On Fri, 08 Apr 2022, Christian König wrote: > Am 08.04.22 um 11:05 schrieb Jani Nikula: >> On Thu, 07 Apr 2022, "Christian König" >> wrote: >>> That should now be handled by the common dma_resv framework. >>> >>> Signed-off-by: Christian König >>> Reviewed-by: Daniel Vetter >>> Cc:

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Inherit submitter nice when scheduling requests

2022-04-08 Thread Dave Airlie
On Fri, 8 Apr 2022 at 18:25, Tvrtko Ursulin wrote: > > > On 08/04/2022 08:58, Daniel Vetter wrote: > > On Thu, Apr 07, 2022 at 04:16:27PM +0100, Tvrtko Ursulin wrote: > >> From: Tvrtko Ursulin > >> > >> Inherit submitter nice at point of request submission to account for long > >> running

Re: [Intel-gfx] [PATCH v2] drm/i915: fix i915_gem_object_wait_moving_fence

2022-04-08 Thread Matthew Auld
On 08/04/2022 09:59, Christian König wrote: Am 08.04.22 um 10:42 schrieb Matthew Auld: All of CI is just failing with the following, which prevents loading of the module: i915 :03:00.0: [drm] *ERROR* Scratch setup failed Best guess is that this comes from the pin_map() for the

Re: [Intel-gfx] [PATCH 1/1] drm/i915/uc: Use platform specific defaults for GuC/HuC enabling

2022-04-08 Thread Tvrtko Ursulin
On 07/04/2022 21:49, John Harrison wrote: On 4/7/2022 08:49, Tvrtko Ursulin wrote: On 03/06/2021 17:48, Matthew Brost wrote: From: John Harrison The meaning of 'default' for the enable_guc module parameter has been updated to accurately reflect what is supported on current platforms. So

Re: [Intel-gfx] [PATCH 12/15] drm/i915: drop bo->moving dependency

2022-04-08 Thread Daniel Vetter
On Fri, 8 Apr 2022 at 11:27, Christian König wrote: > > Am 08.04.22 um 11:05 schrieb Jani Nikula: > > On Thu, 07 Apr 2022, "Christian König" > > wrote: > >> That should now be handled by the common dma_resv framework. > >> > >> Signed-off-by: Christian König > >> Reviewed-by: Daniel Vetter >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix i915_gem_object_wait_moving_fence

2022-04-08 Thread Christian König
Am 08.04.22 um 11:23 schrieb Tvrtko Ursulin: On 08/04/2022 10:12, Christian König wrote: Am 08.04.22 um 11:08 schrieb Tvrtko Ursulin: On 07/04/2022 17:45, Matthew Auld wrote: All of CI is just failing with the following, which prevents loading of the module: i915 :03:00.0: [drm]

Re: [Intel-gfx] [PATCH v2] drm/i915: fix i915_gem_object_wait_moving_fence

2022-04-08 Thread Petri Latvala
On Fri, Apr 08, 2022 at 09:42:05AM +0100, Matthew Auld wrote: > All of CI is just failing with the following, which prevents loading of > the module: > > i915 :03:00.0: [drm] *ERROR* Scratch setup failed > > Best guess is that this comes from the pin_map() for the scratch page, > which

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix i915_gem_object_wait_moving_fence

2022-04-08 Thread Tvrtko Ursulin
On 08/04/2022 10:12, Christian König wrote: Am 08.04.22 um 11:08 schrieb Tvrtko Ursulin: On 07/04/2022 17:45, Matthew Auld wrote: All of CI is just failing with the following, which prevents loading of the module: i915 :03:00.0: [drm] *ERROR* Scratch setup failed Best guess is

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix i915_gem_object_wait_moving_fence

2022-04-08 Thread Christian König
Am 08.04.22 um 11:08 schrieb Tvrtko Ursulin: On 07/04/2022 17:45, Matthew Auld wrote: All of CI is just failing with the following, which prevents loading of the module: i915 :03:00.0: [drm] *ERROR* Scratch setup failed Best guess is that this comes from the pin_map() for the

Re: [Intel-gfx] [PATCH 1/2] drm/dp: Export drm_dp_dpcd_access()

2022-04-08 Thread Imre Deak
On Thu, Apr 07, 2022 at 10:32:11PM +0300, Jani Nikula wrote: > On Thu, 07 Apr 2022, Imre Deak wrote: > > The next patch needs a way to read a DPCD register without the preceding > > wake-up read in drm_dp_dpcd_read(). Export drm_dp_dpcd_access() to allow > > this. > > I think I'd rather you

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix i915_gem_object_wait_moving_fence

2022-04-08 Thread Tvrtko Ursulin
On 07/04/2022 17:45, Matthew Auld wrote: All of CI is just failing with the following, which prevents loading of the module: i915 :03:00.0: [drm] *ERROR* Scratch setup failed Best guess is that this comes from the pin_map() for the scratch page, which does an

Re: [Intel-gfx] [PATCH 12/15] drm/i915: drop bo->moving dependency

2022-04-08 Thread Jani Nikula
On Thu, 07 Apr 2022, "Christian König" wrote: > That should now be handled by the common dma_resv framework. > > Signed-off-by: Christian König > Reviewed-by: Daniel Vetter > Cc: intel-gfx@lists.freedesktop.org So, where are the i915 maintainer acks for merging this (and the other patches in

Re: [Intel-gfx] [PATCH v9 4/9] drm/i915/gt: Pass the -EINVAL when emit_pte doesn't update any PTE

2022-04-08 Thread Intel
On 4/5/22 17:08, Ramalingam C wrote: When emit_pte doesn't update any PTE with return value as 0, interpret it as -EINVAL. v2: Add missing goto [Thomas] Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v3] tests/gem_lmem_swapping: limit lmem to 4G

2022-04-08 Thread Tvrtko Ursulin
On 28/03/2022 12:18, Petri Latvala wrote: On Mon, Mar 28, 2022 at 11:08:59AM +0100, Matthew Auld wrote: From: CQ Tang On some systems lmem can be as large as 16G, which seems to trigger various CI timeouts, and in the best case just takes a long time. For the purposes of the test we should

[Intel-gfx] [PATCH v2] drm/i915: fix i915_gem_object_wait_moving_fence

2022-04-08 Thread Matthew Auld
All of CI is just failing with the following, which prevents loading of the module: i915 :03:00.0: [drm] *ERROR* Scratch setup failed Best guess is that this comes from the pin_map() for the scratch page, which does an i915_gem_object_wait_moving_fence() somewhere. It looks like this now

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix broken build

2022-04-08 Thread Matthew Auld
On 07/04/2022 17:49, Christian König wrote: Am 07.04.22 um 18:45 schrieb Matthew Auld: I guess this was missed in the conversion or something. Fixes: 7bc80a5462c3 ("dma-buf: add enum dma_resv_usage v4") Signed-off-by: Matthew Auld Cc: Christian König Cc: Daniel Vetter My best guess is

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Inherit submitter nice when scheduling requests

2022-04-08 Thread Tvrtko Ursulin
On 08/04/2022 08:58, Daniel Vetter wrote: On Thu, Apr 07, 2022 at 04:16:27PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Inherit submitter nice at point of request submission to account for long running processes getting either externally or self re-niced. This accounts for the

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix i915_gem_object_wait_moving_fence

2022-04-08 Thread Matthew Auld
On 08/04/2022 06:00, Lucas De Marchi wrote: On Thu, Apr 07, 2022 at 05:45:32PM +0100, Matthew Auld wrote: All of CI is just failing with the following, which prevents loading of the module:    i915 :03:00.0: [drm] *ERROR* Scratch setup failed Best guess is that this comes from the

Re: [Intel-gfx] [PATCH 0/4] drm/i915/dg2: Add support for render/media decompression

2022-04-08 Thread Jani Nikula
On Fri, 08 Apr 2022, Jani Nikula wrote: > On Mon, 04 Apr 2022, Imre Deak wrote: >> This is a rebased version of patches 15-17 of [1], adding DG2 display >> engine support for decompressing render and media compressed >> framebuffers. >> >> The dependency patches from [1] should be merged already

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Inherit submitter nice when scheduling requests

2022-04-08 Thread Daniel Vetter
On Thu, Apr 07, 2022 at 04:16:27PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Inherit submitter nice at point of request submission to account for long > running processes getting either externally or self re-niced. > > This accounts for the current processing landscape where

Re: [Intel-gfx] [PATCH 0/4] drm/i915/dg2: Add support for render/media decompression

2022-04-08 Thread Jani Nikula
On Mon, 04 Apr 2022, Imre Deak wrote: > This is a rebased version of patches 15-17 of [1], adding DG2 display > engine support for decompressing render and media compressed > framebuffers. > > The dependency patches from [1] should be merged already to drm-tip. > > It addresses the review

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/dp: Don't rewrite link config when setting phy CTS test pattern with LTTPR

2022-04-08 Thread Patchwork
== Series Details == Series: drm/dp: Don't rewrite link config when setting phy CTS test pattern with LTTPR URL : https://patchwork.freedesktop.org/series/102385/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11474 -> Patchwork_22824

Re: [Intel-gfx] [PATCH v3 00/17] fbcon cleanups

2022-04-08 Thread Daniel Vetter
On Tue, Apr 05, 2022 at 11:03:18PM +0200, Daniel Vetter wrote: > Hi all, > > Finally got around to respin this. Changes: > - Bunch more acks and r-b, still not yet all patches. > - one tiny fix for a bisect issue, end result was all fine > - I dropped the last to patches to make registered_fb

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Fix warnings about PSR lock not held (rev3)

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix warnings about PSR lock not held (rev3) URL : https://patchwork.freedesktop.org/series/102298/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11472 -> Patchwork_22818

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL URL : https://patchwork.freedesktop.org/series/102352/ State : success == Summary == CI Bug Log - changes from CI_DRM_11472 -> Patchwork_22819

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL URL : https://patchwork.freedesktop.org/series/102352/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11472 -> Patchwork_22819

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL URL : https://patchwork.freedesktop.org/series/102352/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11472 -> Patchwork_22819

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL

2022-04-08 Thread Patchwork
== Series Details == Series: drm/i915: Sunset igpu legacy mmap support based on GRAPHICS_VER_FULL URL : https://patchwork.freedesktop.org/series/102352/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11472 -> Patchwork_22819

  1   2   >