Re: [Intel-gfx] [PATCH 6/9] drm/i915/gvt: Add missing module_put() in error unwind

2022-04-12 Thread Christoph Hellwig
On Tue, Apr 12, 2022 at 12:53:33PM -0300, Jason Gunthorpe wrote: > try_module_get() must be undone if kvmgt_guest_init() fails or we leak the > module reference count on the failure path since the close_device op is > never called in this case. > > Fixes: 9bdb073464d6 ("drm/i915/gvt: Change KVMGT

[Intel-gfx] [PULL] drm-intel-fixes

2022-04-12 Thread Joonas Lahtinen
Hi Dave & Daniel, Just one fix towards v5.18-rc3. Fix to align code with drm-tip to make sure full graphics IP version is used for legacy mmap disable check. Regards, Joonas *** drm-intel-fixes-2022-04-13: - Correct legacy mmap disabling to use GRAPHICS_VER_FULL The following changes since

Re: [Intel-gfx] [PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()

2022-04-12 Thread Christoph Hellwig
> - extern int vfio_pin_pages(struct device *dev, unsigned long *user_pfn, > + extern int vfio_pin_pages(struct vfio_device *vdev, unsigned long > *user_pfn, > int npage, int prot, unsigned long *phys_pfn); > > - extern int vfio_unpin_pages(struct

Re: [Intel-gfx] [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-12 Thread Christoph Hellwig
On Tue, Apr 12, 2022 at 12:53:28PM -0300, Jason Gunthorpe wrote: > All callers have a struct vfio_device trivially available, pass it in > directly and avoid calling the expensive vfio_group_get_from_dev(). Instead of bothering the drivers with the notifiers at all, the two notifier_blocks should

Re: [Intel-gfx] [PATCH 0/9] Make the rest of the VFIO driver interface use vfio_device

2022-04-12 Thread Christoph Hellwig
On Tue, Apr 12, 2022 at 12:53:27PM -0300, Jason Gunthorpe wrote: > There is a conflict with Christoph's gvt rework here: > > https://lore.kernel.org/all/20220411141403.86980-1-...@lst.de/ > > I've organized this so it is independent of Christoph's series, by adding > the temporary

[Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2

2022-04-12 Thread Anusha Srivatsa
Add Support for DC states on Dg2. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- drivers/gpu/drm/i915/display/intel_dmc.c | 10 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git

Re: [Intel-gfx] linux-next: manual merge of the amdgpu tree with the drm-misc tree

2022-04-12 Thread Stephen Rothwell
Hi all, On Wed, 6 Apr 2022 10:34:05 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the amdgpu tree got a conflict in: > > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > > between commit: > > fee2ede15542 ("drm/ttm: rework bulk move handling v5") > > from the drm-misc tree and

Re: [Intel-gfx] linux-next: build warnings after merge of the drm-misc tree

2022-04-12 Thread Stephen Rothwell
Hi all, On Wed, 6 Apr 2022 15:44:31 +1000 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (KCONFIG_NAME) htmldocs > produced these warnings: > > drivers/gpu/drm/drm_edid.c:1589:

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2022-04-12 Thread Stephen Rothwell
Hi all, On Wed, 6 Apr 2022 15:50:30 +1000 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > include/drm/ttm/ttm_resource.h:226: warning: Function parameter or member > 'pos' not described in 'ttm_lru_bulk_move' > >

Re: [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-12 Thread Abhinav Kumar
Hi Daniel On 4/8/2022 9:04 PM, Abhinav Kumar wrote: On 4/7/2022 4:12 PM, Rob Clark wrote: On Thu, Apr 7, 2022 at 3:59 PM Abhinav Kumar wrote: Hi Rob and Daniel On 4/7/2022 3:51 PM, Rob Clark wrote: On Wed, Apr 6, 2022 at 6:27 PM Jessica Zhang wrote: On 3/31/2022 8:20 AM, Daniel

[Intel-gfx] [PATCH 0/1] Update to GuC v70

2022-04-12 Thread John . C . Harrison
From: John Harrison Update to the latest GuC firmware release. Note that this includes some significant backwards breaking API changes. One is about context registration - the descriptor pool is gone, all parameters are passed via the CTB instead. The second is about scheduling policy updates -

[Intel-gfx] [PATCH 1/1] drm/i915/guc: Update to GuC version 70.1.1

2022-04-12 Thread John . C . Harrison
From: John Harrison The latest GuC firmware drops the context descriptor pool in favour of passing all creation data in the create H2G. It also greatly simplifies the work queue and removes the process descriptor used for multi-LRC submission. So, remove all mention of LRC and process

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-12 Thread Vinay Belgaumkar
This will ensure we don't have false positives when we run error injection tests. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 42 ++--- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git

[Intel-gfx] [PATCH 2/2] drm/i915/display/psr: Clear more PSR state during disable

2022-04-12 Thread José Roberto de Souza
After commit 805f04d42a6b ("drm/i915/display/psr: Use continuos full frame to handle frontbuffer invalidations") was merged we started to get some drm_WARN_ON(_priv->drm, !(tmp & PSR2_MAN_TRK_CTL_ENABLE)) in tests that are executed in pipe B. This is probably due psr2_sel_fetch_cff_enabled being

[Intel-gfx] [PATCH 1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails

2022-04-12 Thread José Roberto de Souza
If any of the PSR2 checks after intel_psr2_sel_fetch_config_valid() fails, enable_psr2_sel_fetch will be kept enabled causing problems in the functions that only checks for it and not for has_psr2. So here moving the check that do not depend on enable_psr2_sel_fetch and for the remaning ones

[Intel-gfx] [PATCH v3 5/5] drm/i915: stolen memory use ttm backend

2022-04-12 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 ++-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 -

[Intel-gfx] [PATCH v3 4/5] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-12 Thread Robert Beckett
stolen/kernel buffers should not be mmapable by userland. do not provide callbacks to facilitate this for these buffers. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 32 + 1 file changed, 27 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH v3 3/5] drm/i915: ttm move/clear logic fix

2022-04-12 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that

[Intel-gfx] [PATCH v3 2/5] drm/i915: sanitize mem_flags for stolen buffers

2022-04-12 Thread Robert Beckett
stolen regions are not page backed or considered iomem. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c

[Intel-gfx] [PATCH v3 0/5] drm/i915: ttm for stolen region

2022-04-12 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. v3: rebase to latest drm-tip. fix v2

[Intel-gfx] [PATCH v3 1/5] drm/i915: instantiate ttm ranger manager for stolen memory

2022-04-12 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31 +++- 2 files changed, 27

Re: [Intel-gfx] [PATCH] drm/i915: Check EDID before dpcd for possible HDR aux bl support

2022-04-12 Thread Lyude Paul
On Tue, 2022-04-12 at 08:25 +0300, Jouni Högander wrote: > We have now seen panel (XMG Core 15 e21 laptop) avertizing support > for Intel proprietary eDP backlight control via DPCD registers, but > actually working only with legacy pwm control. > > This patch adds panel EDID check for possible

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen region (rev2)

2022-04-12 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen region (rev2) URL : https://patchwork.freedesktop.org/series/102540/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11489 -> Patchwork_102540v2 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen region (rev2)

2022-04-12 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen region (rev2) URL : https://patchwork.freedesktop.org/series/102540/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v2 5/5] drm/i915: stolen memory use ttm backend

2022-04-12 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 ++-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 -

[Intel-gfx] [PATCH v2 4/5] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-12 Thread Robert Beckett
stolen/kernel buffers should not be mmapable by userland. do not provide callbacks to facilitate this for these buffers. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 32 + 1 file changed, 27 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH v2 3/5] drm/i915: ttm move/clear logic fix

2022-04-12 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that

[Intel-gfx] [PATCH v2 2/5] drm/i915: sanitize mem_flags for stolen buffers

2022-04-12 Thread Robert Beckett
stolen regions are not page backed or considered iomem. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c

[Intel-gfx] [PATCH v2 1/5] drm/i915: instantiate ttm ranger manager for stolen memory

2022-04-12 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31 +++- 2 files changed, 27

[Intel-gfx] [PATCH v2 0/5] drm/i915: ttm for stolen region

2022-04-12 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. Robert Beckett (5): drm/i915: instantiate ttm

Re: [Intel-gfx] [PATCH v3 14/17] fbcon: Move console_lock for register/unlink/unregister

2022-04-12 Thread Nathan Chancellor
Hi Daniel, On Tue, Apr 05, 2022 at 11:03:32PM +0200, Daniel Vetter wrote: > Ideally console_lock becomes an implementation detail of fbcon.c and > doesn't show up anywhere in fbmem.c. We're still pretty far from that, > but at least the register/unregister code is there now. > > With this the

Re: [Intel-gfx] [PATCH v5 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:29PM +, Sean Paul wrote: > From: Sean Paul > > Rebased set from November. Fixed a nit from Stephen in the msm patch and > moved hdcp registers into the trogdor dtsi file to avoid differences > with sc7180-based windows devices. The set is 4 patches lighter since

Re: [Intel-gfx] [PATCH v5 05/10] drm/i915/hdcp: Consolidate HDCP setup/state cache

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:34PM +, Sean Paul wrote: > From: Sean Paul > > Stick all of the setup for HDCP into a dedicated function. No functional > change, but this will facilitate moving HDCP logic into helpers. Reviewed-by: Rodrigo Vivi > > Acked-by: Jani Nikula >

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:35PM +, Sean Paul wrote: > From: Sean Paul > > The shim functions return error codes, but they are discarded in > intel_hdcp.c. This patch plumbs the return codes through so they are > properly handled. Reviewed-by: Rodrigo Vivi > > Acked-by: Jani Nikula >

Re: [Intel-gfx] [PATCH v5 03/10] drm/hdcp: Update property value on content type and user changes

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:32PM +, Sean Paul wrote: > From: Sean Paul > > This patch updates the connector's property value in 2 cases which were > previously missed: > > 1- Content type changes. The value should revert back to DESIRED from >ENABLED in case the driver must

Re: [Intel-gfx] [PATCH v5 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:31PM +, Sean Paul wrote: > From: Sean Paul > > Instead of forcing a modeset in the hdcp atomic check, simply return > true if the content protection value is changing and let the driver > decide whether a modeset is required or not. > > Acked-by: Jani Nikula >

Re: [Intel-gfx] [PATCH v5 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:30PM +, Sean Paul wrote: > From: Sean Paul > > This patch moves the hdcp atomic check from i915 to drm_hdcp so other > drivers can use it. No functional changes, just cleaned up some of the > code when moving it over. Reviewed-by: Rodrigo Vivi > >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Check EDID before dpcd for possible HDR aux bl support (rev2)

2022-04-12 Thread Patchwork
== Series Details == Series: drm/i915: Check EDID before dpcd for possible HDR aux bl support (rev2) URL : https://patchwork.freedesktop.org/series/102571/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11488 -> Patchwork_102571v2

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: low level EDID block read refactoring etc. (rev6)

2022-04-12 Thread Patchwork
== Series Details == Series: drm/edid: low level EDID block read refactoring etc. (rev6) URL : https://patchwork.freedesktop.org/series/102329/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11488 -> Patchwork_102329v6

Re: [Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup

2022-04-12 Thread Matthew Auld
On 11/04/2022 13:39, Christian König wrote: Am 11.04.22 um 10:56 schrieb Matthew Auld: If we hit the sync case, like when skipping clearing for kernel internal objects, or when falling back to cpu clearing, like in i915, we end up trying to add a NULL fence, but with some recent changes in this

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dg2: Add support for render/media decompression (rev2)

2022-04-12 Thread Imre Deak
On Tue, Apr 12, 2022 at 12:38:23AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dg2: Add support for render/media decompression (rev2) > URL : https://patchwork.freedesktop.org/series/102147/ > State : success Thanks for the patches and reviews, patchset pushed to

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Check EDID before dpcd for possible HDR aux bl support

2022-04-12 Thread Patchwork
== Series Details == Series: drm/i915: Check EDID before dpcd for possible HDR aux bl support URL : https://patchwork.freedesktop.org/series/102571/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11486 -> Patchwork_102571v1

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2] tests/drm_buddy: Add drm buddy test cases

2022-04-12 Thread Matthew Auld
On Mon, 11 Apr 2022 at 19:51, Arunpravin Paneer Selvam wrote: > > Add a set of drm buddy test cases to validate the > drm/drm_buddy.c memory allocator. > > v2: sorted in alphabetical order > > Signed-off-by: Arunpravin Paneer Selvam > Reviewed-by: Matthew Auld Tests look to be passing in CI

Re: [Intel-gfx] [PATCH v3 08/22] drm/i915/bios: Generate LFP data table pointers if the VBT lacks them

2022-04-12 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 07:53:13PM +0300, Jani Nikula wrote: > On Wed, 06 Apr 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Modern VBTs no longer contain the LFP data table pointers > > block (41). We are expecting to have one in order to be able > > to parse the LFP data block

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Check EDID before dpcd for possible HDR aux bl support

2022-04-12 Thread Patchwork
== Series Details == Series: drm/i915: Check EDID before dpcd for possible HDR aux bl support URL : https://patchwork.freedesktop.org/series/102571/ State : warning == Summary == Error: git fetch origin failed

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Check EDID before dpcd for possible HDR aux bl support

2022-04-12 Thread Patchwork
== Series Details == Series: drm/i915: Check EDID before dpcd for possible HDR aux bl support URL : https://patchwork.freedesktop.org/series/102571/ State : warning == Summary == Error: git fetch origin failed

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check EDID before dpcd for possible HDR aux bl support

2022-04-12 Thread Patchwork
== Series Details == Series: drm/i915: Check EDID before dpcd for possible HDR aux bl support URL : https://patchwork.freedesktop.org/series/102571/ State : warning == Summary == Error: git fetch origin failed

Re: [Intel-gfx] [PATCH] drm/i915: Check EDID before dpcd for possible HDR aux bl support

2022-04-12 Thread Jani Nikula
On Tue, 12 Apr 2022, Jouni Högander wrote: > We have now seen panel (XMG Core 15 e21 laptop) avertizing support > for Intel proprietary eDP backlight control via DPCD registers, but > actually working only with legacy pwm control. > > This patch adds panel EDID check for possible HDR static