[Intel-gfx] ✗ Fi.CI.BAT: failure for Remove unnecessary GuC err capture noise

2022-05-06 Thread Patchwork
== Series Details == Series: Remove unnecessary GuC err capture noise URL : https://patchwork.freedesktop.org/series/103709/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11620 -> Patchwork_103709v1 Summary ---

[Intel-gfx] [PATCH 0/1] Remove unnecessary GuC err capture noise

2022-05-06 Thread Alan Previn
This series remove unnecessary GuC err capture noise. Alan Previn (1): drm/i915/guc: Remove unnecessary GuC err capture noise .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 77 +-- 1 file changed, 2 insertions(+), 75 deletions(-) -- 2.25.1

[Intel-gfx] [PATCH 1/1] drm/i915/guc: Remove unnecessary GuC err capture noise

2022-05-06 Thread Alan Previn
GuC error capture blurts some debug messages about empty register lists for certain register types on engines during firmware initialization. These are not errors or warnings, so get rid of them. Signed-off-by: Alan Previn --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 77

Re: [Intel-gfx] [PATCH 5/5] drm/i915/sseu: Disassociate internal subslice mask representation from uapi

2022-05-06 Thread Matt Roper
On Thu, Apr 28, 2022 at 01:18:42PM +0100, Tvrtko Ursulin wrote: > > Hi, > > On 28/04/2022 00:07, Matt Roper wrote: > > Rather than storing subslice masks internally as u8[] (inside the sseu > > structure) and u32 (everywhere else), let's move over to using an > > intel_sseu_ss_mask_t typedef

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/dmabuf: dmabuf cleanup

2022-05-06 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dmabuf: dmabuf cleanup URL : https://patchwork.freedesktop.org/series/103696/ State : success == Summary == CI Bug Log - changes from CI_DRM_11618_full -> Patchwork_103696v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmc: Add MMIO range restrictions

2022-05-06 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Add MMIO range restrictions URL : https://patchwork.freedesktop.org/series/103693/ State : success == Summary == CI Bug Log - changes from CI_DRM_11618_full -> Patchwork_103693v1_full Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmc: Load DMC on DG2 (rev4)

2022-05-06 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Load DMC on DG2 (rev4) URL : https://patchwork.freedesktop.org/series/103625/ State : success == Summary == CI Bug Log - changes from CI_DRM_11618_full -> Patchwork_103625v4_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/reset: Add Wa_22011802037 for gen11 and execlist backend

2022-05-06 Thread Umesh Nerlige Ramappa
On Fri, May 06, 2022 at 10:13:28AM -0700, Umesh Nerlige Ramappa wrote: On Wed, May 04, 2022 at 07:09:09PM +0100, Tvrtko Ursulin wrote: On 04/05/2022 18:35, Umesh Nerlige Ramappa wrote: On Wed, May 04, 2022 at 09:10:42AM +0100, Tvrtko Ursulin wrote: On 03/05/2022 20:49, Umesh Nerlige Ramappa

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/dmabuf: dmabuf cleanup

2022-05-06 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dmabuf: dmabuf cleanup URL : https://patchwork.freedesktop.org/series/103696/ State : success == Summary == CI Bug Log - changes from CI_DRM_11618 -> Patchwork_103696v1

[Intel-gfx] [PATCH 2/2] drm/i915/dmabuf: Use scatterlist for_each_sg API

2022-05-06 Thread Michael J. Ruhl
Update open coded for loop to use the standard scatterlist for_each_sg API. Cc: Tvrtko Ursulin Signed-off-by: Michael J. Ruhl --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c

[Intel-gfx] [PATCH 1/2] drm/i915/dmabuf: dmabuf cleanup

2022-05-06 Thread Michael J. Ruhl
Some minor cleanup of some variables for consistency. Normalize struct sg_table to sgt. Normalize struct dma_buf_attachment to attach. checkpatch issues sizeof(), !NULL updates. Cc: Tvrtko Ursulin Signed-off-by: Michael J. Ruhl --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 47

[Intel-gfx] i915 dmabuf cleanup

2022-05-06 Thread Michael J. Ruhl
While studying this code I noticed a few inconsistencies and possible cleanups. Please consider these patches.

Re: [Intel-gfx] [PATCH 1/2] drm/i915/psr: Use full update In case of area calculation fails

2022-05-06 Thread Souza, Jose
On Fri, 2022-05-06 at 18:28 +, Hogander, Jouni wrote: > On Fri, 2022-05-06 at 15:29 +, Souza, Jose wrote: > > On Fri, 2022-05-06 at 08:48 +0300, Jouni Högander wrote: > > > Currently we have some corner cases where area calculation > > > fails. For > > > these sel fetch are calculation

[Intel-gfx] ✓ Fi.CI.IGT: success for Expose max and current bpc via debugfs (rev4)

2022-05-06 Thread Patchwork
== Series Details == Series: Expose max and current bpc via debugfs (rev4) URL : https://patchwork.freedesktop.org/series/102502/ State : success == Summary == CI Bug Log - changes from CI_DRM_11617_full -> Patchwork_102502v4_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Add MMIO range restrictions

2022-05-06 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Add MMIO range restrictions URL : https://patchwork.freedesktop.org/series/103693/ State : success == Summary == CI Bug Log - changes from CI_DRM_11618 -> Patchwork_103693v1 Summary ---

Re: [Intel-gfx] [PATCH 1/2] drm/i915/psr: Use full update In case of area calculation fails

2022-05-06 Thread Hogander, Jouni
On Fri, 2022-05-06 at 15:29 +, Souza, Jose wrote: > On Fri, 2022-05-06 at 08:48 +0300, Jouni Högander wrote: > > Currently we have some corner cases where area calculation > > fails. For > > these sel fetch are calculation ends up having update area as y1 = > > 0, > > y2 = 4. Instead of these

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: Add MMIO range restrictions

2022-05-06 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Add MMIO range restrictions URL : https://patchwork.freedesktop.org/series/103693/ State : warning == Summary == Error: dim checkpatch failed dfd1ba4479c1 drm/i915/dmc: Add MMIO range restrictions -:77: WARNING:LONG_LINE: line length of 101 exceeds

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Load DMC on DG2 (rev4)

2022-05-06 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Load DMC on DG2 (rev4) URL : https://patchwork.freedesktop.org/series/103625/ State : success == Summary == CI Bug Log - changes from CI_DRM_11618 -> Patchwork_103625v4 Summary ---

Re: [Intel-gfx] [PATCH 17/25] drm/edid: add drm_edid helper for drm_edid_to_sad()

2022-05-06 Thread Ville Syrjälä
On Fri, May 06, 2022 at 01:10:24PM +0300, Jani Nikula wrote: > +int drm_edid_to_sad(const struct edid *edid, struct cea_sad **sads) > +{ > + struct drm_edid drm_edid = { > + .edid = edid, > + .size = edid_size(edid), > + }; > + > + return _drm_edid_to_sad(_edid,

Re: [Intel-gfx] [PATCH 02/25] drm/edid: convert drm_for_each_detailed_block() to edid iter

2022-05-06 Thread Ville Syrjälä
On Fri, May 06, 2022 at 01:10:09PM +0300, Jani Nikula wrote: > We have an iterator for this, use it. It does include the base block, > but its tag is 0 and will be skipped. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.c | 8 +--- > 1 file

Re: [Intel-gfx] [PATCH 01/25] drm/edid: use else-if in CTA extension parsing

2022-05-06 Thread Ville Syrjälä
On Fri, May 06, 2022 at 01:10:08PM +0300, Jani Nikula wrote: > Only one of the conditions can be true. > > Suggested-by: Ville Syrjälä > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.c | 12 ++-- > 1 file changed, 6 insertions(+), 6

[Intel-gfx] [PATCH] drm/i915/dmc: Add MMIO range restrictions

2022-05-06 Thread Anusha Srivatsa
Bspec has added some steps that check forDMC MMIO range before programming them v2: Fix for CI v3: move register defines to .h (Anusha) - Check MMIO restrictions per pipe - Add MMIO restricton for v1 dmc header as well (Lucas) v4: s/_PICK/_PICK_EVEN and use it only for Pipe DMC scenario. - clean

Re: [Intel-gfx] [PATCH v2 05/12] drm/i915/pvc: Remove additional 3D flags from PIPE_CONTROL

2022-05-06 Thread Matt Roper
On Fri, May 06, 2022 at 10:23:41AM -0700, Lucas De Marchi wrote: > On Thu, May 05, 2022 at 02:38:05PM -0700, Matt Roper wrote: > > From: Stuart Summers > > > > Although we already strip 3D-specific flags from PIPE_CONTROL > > instructions when submitting to a compute engine, there are some > >

Re: [Intel-gfx] [PATCH v2 05/12] drm/i915/pvc: Remove additional 3D flags from PIPE_CONTROL

2022-05-06 Thread Lucas De Marchi
On Thu, May 05, 2022 at 02:38:05PM -0700, Matt Roper wrote: From: Stuart Summers Although we already strip 3D-specific flags from PIPE_CONTROL instructions when submitting to a compute engine, there are some additional flags that need to be removed when the platform as a whole lacks a 3D

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/display: Add smem fallback allocation for dpt

2022-05-06 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: Add smem fallback allocation for dpt URL : https://patchwork.freedesktop.org/series/103678/ State : success == Summary == CI Bug Log - changes from CI_DRM_11617_full -> Patchwork_103678v1_full

[Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2

2022-05-06 Thread Anusha Srivatsa
Add Support for DC states on Dg2. v2: Add dc9 as the max supported DC states and disable DC5. v3: set max_dc to 0. (Imre) v4: Add FIXME (Rodrigo) Cc: Imre Deak Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa Reviewed-by: Rodrigo Vivi (v1) ---

[Intel-gfx] [PATCH 0/1] DG2 DMC Support

2022-05-06 Thread Anusha Srivatsa
While DG2 supports DC5 and DC9, some of the tests in fast-feedback blew up DG2 when the tests forced transition from dc5->dc9 on suspend and dc9->dc5 on resume. Some local experiments performed with Rodrigo on a RIL system showed promising results when dc5 was completely diabled and i915 took

Re: [Intel-gfx] [PATCH] drm/i915/reset: Add Wa_22011802037 for gen11 and execlist backend

2022-05-06 Thread Umesh Nerlige Ramappa
On Wed, May 04, 2022 at 07:09:09PM +0100, Tvrtko Ursulin wrote: On 04/05/2022 18:35, Umesh Nerlige Ramappa wrote: On Wed, May 04, 2022 at 09:10:42AM +0100, Tvrtko Ursulin wrote: On 03/05/2022 20:49, Umesh Nerlige Ramappa wrote: On Tue, May 03, 2022 at 09:42:52AM +0100, Tvrtko Ursulin wrote:

Re: [Intel-gfx] [PATCH v2 03/12] drm/i915/pvc: Define MOCS table for PVC

2022-05-06 Thread Lucas De Marchi
On Thu, May 05, 2022 at 02:38:03PM -0700, Matt Roper wrote: From: Ayaz A Siddiqui v2 (MattR): - Clarify comment above RING_CMD_CCTL programming. - Remove bspec reference from field definition. (Lucas) - Add WARN if we try to use a (presumably uninitialized) wb_index of 0. On most platforms

Re: [Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup

2022-05-06 Thread Andrzej Hajda
On 06.05.2022 15:22, Javier Martinez Canillas wrote: Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove") attempted to fix a use-after-free error due driver freeing the fb_info in the .remove handler instead of doing it in .fb_destroy. But ironically that

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pxp: fix sparse warning for not declared symbol

2022-05-06 Thread Patchwork
== Series Details == Series: drm/i915/pxp: fix sparse warning for not declared symbol URL : https://patchwork.freedesktop.org/series/103673/ State : success == Summary == CI Bug Log - changes from CI_DRM_11617_full -> Patchwork_103673v1_full

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-05-06 Thread John Harrison
On 5/6/2022 00:18, Tvrtko Ursulin wrote: On 05/05/2022 19:36, John Harrison wrote: On 5/5/2022 10:21, Belgaumkar, Vinay wrote: On 5/5/2022 5:13 AM, Tvrtko Ursulin wrote: On 05/05/2022 06:40, Vinay Belgaumkar wrote: SLPC min/max frequency updates require H2G calls. We are seeing timeouts when

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-05-06 Thread Belgaumkar, Vinay
On 5/6/2022 12:18 AM, Tvrtko Ursulin wrote: On 05/05/2022 19:36, John Harrison wrote: On 5/5/2022 10:21, Belgaumkar, Vinay wrote: On 5/5/2022 5:13 AM, Tvrtko Ursulin wrote: On 05/05/2022 06:40, Vinay Belgaumkar wrote: SLPC min/max frequency updates require H2G calls. We are seeing

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev4)

2022-05-06 Thread Patchwork
== Series Details == Series: drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev4) URL : https://patchwork.freedesktop.org/series/102666/ State : success == Summary == CI Bug Log - changes from CI_DRM_11617_full -> Patchwork_102666v4_full

[Intel-gfx] ✓ Fi.CI.BAT: success for Expose max and current bpc via debugfs (rev4)

2022-05-06 Thread Patchwork
== Series Details == Series: Expose max and current bpc via debugfs (rev4) URL : https://patchwork.freedesktop.org/series/102502/ State : success == Summary == CI Bug Log - changes from CI_DRM_11617 -> Patchwork_102502v4 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Expose max and current bpc via debugfs (rev4)

2022-05-06 Thread Patchwork
== Series Details == Series: Expose max and current bpc via debugfs (rev4) URL : https://patchwork.freedesktop.org/series/102502/ State : warning == Summary == Error: dim checkpatch failed e8b34c163d1c drm/debug: Expose connector's max supported bpc via debugfs -:21: WARNING:BAD_SIGN_OFF:

Re: [Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup

2022-05-06 Thread Andi Shyti
Hi Javier, On Fri, May 06, 2022 at 03:22:25PM +0200, Javier Martinez Canillas wrote: > Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather > than .remove") attempted to fix a use-after-free error due driver freeing > the fb_info in the .remove handler instead of doing it in

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ensure damage clip area is within pipe area

2022-05-06 Thread Souza, Jose
On Fri, 2022-05-06 at 08:48 +0300, Jouni Högander wrote: > Current update area calculation is not handling situation where > e.g. cursor plane is fully or partially outside pipe area. > > Fix this by checking damage area against pipe_src area using > drm_rect_intersect. > > Closes:

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Support programming the EU priority in the GuC descriptor

2022-05-06 Thread Ceraolo Spurio, Daniele
On 5/6/2022 12:51 AM, Tvrtko Ursulin wrote: On 05/05/2022 19:56, John Harrison wrote: On 5/4/2022 16:46, Daniele Ceraolo Spurio wrote: From: Matthew Brost In GuC submission mode the EU priority must be updated by the GuC rather than the driver as the GuC owns the programming of the

Re: [Intel-gfx] [PATCH 1/2] drm/i915/psr: Use full update In case of area calculation fails

2022-05-06 Thread Souza, Jose
On Fri, 2022-05-06 at 08:48 +0300, Jouni Högander wrote: > Currently we have some corner cases where area calculation fails. For > these sel fetch are calculation ends up having update area as y1 = 0, > y2 = 4. Instead of these values safer option is full update. Aren't you able to reproduce

Re: [Intel-gfx] [PATCH v7 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces

2022-05-06 Thread Andi Shyti
Hi Jani, On Fri, May 06, 2022 at 02:53:50PM +0300, Jani Nikula wrote: > On Sat, 19 Mar 2022, Andi Shyti wrote: > > +#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \ > > + struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, > > _show, _store); \ > > + struct

[Intel-gfx] ✗ Fi.CI.BAT: failure for fbdev: efifb: Fix a use-after-free due early fb_info cleanup

2022-05-06 Thread Patchwork
== Series Details == Series: fbdev: efifb: Fix a use-after-free due early fb_info cleanup URL : https://patchwork.freedesktop.org/series/103680/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11617 -> Patchwork_103680v1

Re: [Intel-gfx] [PATCH 07/11] drm/i915/pvc: Engines definitions for new copy engines

2022-05-06 Thread Matt Roper
On Fri, May 06, 2022 at 08:21:46AM +0100, Tvrtko Ursulin wrote: > > On 05/05/2022 21:59, Matt Roper wrote: > > On Tue, May 03, 2022 at 09:05:43AM +0100, Tvrtko Ursulin wrote: > > > > > > On 02/05/2022 17:34, Matt Roper wrote: > > > > This patch adds the basic definitions needed to support > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display: Add smem fallback allocation for dpt

2022-05-06 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: Add smem fallback allocation for dpt URL : https://patchwork.freedesktop.org/series/103678/ State : success == Summary == CI Bug Log - changes from CI_DRM_11617 -> Patchwork_103678v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/display: Add smem fallback allocation for dpt

2022-05-06 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: Add smem fallback allocation for dpt URL : https://patchwork.freedesktop.org/series/103678/ State : warning == Summary == Error: dim checkpatch failed cb0cd39c87aa drm/i915/display: Add smem fallback allocation for dpt

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: fix sparse warning for not declared symbol

2022-05-06 Thread Patchwork
== Series Details == Series: drm/i915/pxp: fix sparse warning for not declared symbol URL : https://patchwork.freedesktop.org/series/103673/ State : success == Summary == CI Bug Log - changes from CI_DRM_11617 -> Patchwork_103673v1 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for Expose max and current bpc via debugfs (rev3)

2022-05-06 Thread Patchwork
== Series Details == Series: Expose max and current bpc via debugfs (rev3) URL : https://patchwork.freedesktop.org/series/102502/ State : success == Summary == CI Bug Log - changes from CI_DRM_11616_full -> Patchwork_102502v3_full Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: fix sparse warning for not declared symbol

2022-05-06 Thread Patchwork
== Series Details == Series: drm/i915/pxp: fix sparse warning for not declared symbol URL : https://patchwork.freedesktop.org/series/103673/ State : warning == Summary == Error: dim checkpatch failed 151a8d341bdd drm/i915/pxp: fix sparse warning for not declared symbol -:4:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev4)

2022-05-06 Thread Patchwork
== Series Details == Series: drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev4) URL : https://patchwork.freedesktop.org/series/102666/ State : success == Summary == CI Bug Log - changes from CI_DRM_11617 -> Patchwork_102666v4

Re: [Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup

2022-05-06 Thread Thomas Zimmermann
Am 06.05.22 um 15:22 schrieb Javier Martinez Canillas: Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove") attempted to fix a use-after-free error due driver freeing the fb_info in the .remove handler instead of doing it in .fb_destroy. But ironically that

[Intel-gfx] ✓ Fi.CI.IGT: success for Fixes for selective fetch area calculation

2022-05-06 Thread Patchwork
== Series Details == Series: Fixes for selective fetch area calculation URL : https://patchwork.freedesktop.org/series/103659/ State : success == Summary == CI Bug Log - changes from CI_DRM_11616_full -> Patchwork_103659v1_full Summary

[Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup

2022-05-06 Thread Javier Martinez Canillas
Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove") attempted to fix a use-after-free error due driver freeing the fb_info in the .remove handler instead of doing it in .fb_destroy. But ironically that change introduced yet another use-after-free since the

[Intel-gfx] [PATCH 2/2] drm/i915: Fix i915_vma_pin_iomap()

2022-05-06 Thread Juha-Pekka Heikkila
From: CQ Tang Display might allocate a smem object and call i915_vma_pin_iomap(), the existing code will fail. This fix was suggested by Chris P Wilson, that we pin the smem with i915_gem_object_pin_map_unlocked(). Signed-off-by: CQ Tang Signed-off-by: Juha-Pekka Heikkila Cc: Chris Wilson

[Intel-gfx] [PATCH 1/2] drm/i915/display: Add smem fallback allocation for dpt

2022-05-06 Thread Juha-Pekka Heikkila
Add fallback smem allocation for dpt if stolen memory allocation failed. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/display/intel_dpt.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpt.c

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: introduce struct drm_edid (rev2)

2022-05-06 Thread Patchwork
== Series Details == Series: drm/edid: introduce struct drm_edid (rev2) URL : https://patchwork.freedesktop.org/series/103665/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11616 -> Patchwork_103665v2 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: introduce struct drm_edid (rev2)

2022-05-06 Thread Patchwork
== Series Details == Series: drm/edid: introduce struct drm_edid (rev2) URL : https://patchwork.freedesktop.org/series/103665/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: introduce struct drm_edid (rev2)

2022-05-06 Thread Patchwork
== Series Details == Series: drm/edid: introduce struct drm_edid (rev2) URL : https://patchwork.freedesktop.org/series/103665/ State : warning == Summary == Error: dim checkpatch failed 49478b13e157 drm/edid: use else-if in CTA extension parsing 253ce252ebb2 drm/edid: convert

[Intel-gfx] [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol

2022-05-06 Thread Jani Nikula
Fix: drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c:61:6: warning: symbol 'intel_pxp_debugfs_register' was not declared. Should it be static? Sort and remove the redundant pxp prefixes from the includes while at it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 5

Re: [Intel-gfx] [CI 14/18] drm/i915: Sanitize the port -> DDI/AUX power domain mapping for each platform

2022-05-06 Thread Jani Nikula
On Fri, 15 Apr 2022, Imre Deak wrote: > Atm the port -> DDI and AUX power domain mapping is specified by relying > on the aliasing of the platform specific intel_display_power_domain enum > values. For instance D12+ platforms refer to the 'D' port and power > domain instances, which doesn't match

Re: [Intel-gfx] [PATCH v7 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces

2022-05-06 Thread Jani Nikula
On Sat, 19 Mar 2022, Andi Shyti wrote: > +#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \ > + struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, > _show, _store); \ > + struct device_attribute dev_attr_rps_##_name = __ATTR(rps_##_name, > _mode, _show,

[Intel-gfx] amdgpu sparse warnings (was: Re: ✗ Fi.CI.SPARSE: warning for drm/edid: introduce struct drm_edid)

2022-05-06 Thread Jani Nikula
Hey, do you ever run sparse on your driver? Whenever our CI ends up recompiling amdgpu, there's quite the spew. See below. You're not alone, but, sorry to say, the _Static_assert() from amdgv_sriovmsg.h has been pretty obnoxious for quite some time now. First, I don't think you should be using

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: introduce struct drm_edid

2022-05-06 Thread Patchwork
== Series Details == Series: drm/edid: introduce struct drm_edid URL : https://patchwork.freedesktop.org/series/103665/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11616 -> Patchwork_103665v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: introduce struct drm_edid

2022-05-06 Thread Patchwork
== Series Details == Series: drm/edid: introduce struct drm_edid URL : https://patchwork.freedesktop.org/series/103665/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: introduce struct drm_edid

2022-05-06 Thread Patchwork
== Series Details == Series: drm/edid: introduce struct drm_edid URL : https://patchwork.freedesktop.org/series/103665/ State : warning == Summary == Error: dim checkpatch failed d886c554f1a8 drm/edid: use else-if in CTA extension parsing 4cbaa4d285a2 drm/edid: convert

[Intel-gfx] ✓ Fi.CI.BAT: success for Expose max and current bpc via debugfs (rev3)

2022-05-06 Thread Patchwork
== Series Details == Series: Expose max and current bpc via debugfs (rev3) URL : https://patchwork.freedesktop.org/series/102502/ State : success == Summary == CI Bug Log - changes from CI_DRM_11616 -> Patchwork_102502v3 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Expose max and current bpc via debugfs (rev3)

2022-05-06 Thread Patchwork
== Series Details == Series: Expose max and current bpc via debugfs (rev3) URL : https://patchwork.freedesktop.org/series/102502/ State : warning == Summary == Error: dim checkpatch failed a180df33d330 drm/debug: Expose connector's max supported bpc via debugfs -:21: WARNING:BAD_SIGN_OFF:

[Intel-gfx] [PULL] drm-intel-next

2022-05-06 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-next-2022-05-06: drm/i915 feature pull #2 for v5.19: Features and functionality: - Add first set of DG2 PCI IDs for "motherboard down" designs (Matt Roper) - Add initial RPL-P PCI IDs as ADL-P subplatform (Matt Atwood) Refactoring and cleanups: - Power well

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes for selective fetch area calculation

2022-05-06 Thread Patchwork
== Series Details == Series: Fixes for selective fetch area calculation URL : https://patchwork.freedesktop.org/series/103659/ State : success == Summary == CI Bug Log - changes from CI_DRM_11616 -> Patchwork_103659v1 Summary ---

Re: [Intel-gfx] [PATCH 05/25] drm/edid: keep propagating drm_edid to display info

2022-05-06 Thread Jani Nikula
On Fri, 06 May 2022, Jani Nikula wrote: > We'll need to propagate drm_edid everywhere. I seem to have copy-pasted a TAB in some of the commit messages, in a way that does not show up in git log. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 50

[Intel-gfx] [PATCH 25/25] drm/edid: convert version_greater() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Also make version_greater() a function for type safety. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

[Intel-gfx] [PATCH 24/25] drm/displayid: convert to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 16 drivers/gpu/drm/drm_edid.c | 17 ++--- include/drm/drm_displayid.h | 6 +++--- include/drm/drm_edid.h | 6 -- 4 files changed,

[Intel-gfx] [PATCH 23/25] drm/edid: add drm_edid helper for drm_update_tile_info()

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index b453bbf2f642..82db7afb4f8e 100644 ---

[Intel-gfx] [PATCH 22/25] drm/edid: convert drm_edid_iter_begin() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 82a242a71ecf..b453bbf2f642 100644 ---

[Intel-gfx] [PATCH 21/25] drm/edid: convert cea_db_iter_edid_begin() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 706552ae00ea..82a242a71ecf 100644 ---

[Intel-gfx] [PATCH 20/25] drm/edid: add drm_edid helper for drm_detect_monitor_audio()

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 40 -- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[Intel-gfx] [PATCH 19/25] drm/edid: add drm_edid helper for drm_detect_hdmi_monitor()

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[Intel-gfx] [PATCH 18/25] drm/edid: add drm_edid helper for drm_edid_to_speaker_allocation()

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 39 -- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[Intel-gfx] [PATCH 17/25] drm/edid: add drm_edid helper for drm_edid_to_sad()

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[Intel-gfx] [PATCH 16/25] drm/edid: convert drm_for_each_detailed_block() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[Intel-gfx] [PATCH 15/25] drm/edid: convert get_monitor_name() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Drop incorrect NULL name check (Dan Carpenter) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

[Intel-gfx] [PATCH 14/25] drm/edid: convert mode_in_range() and drm_monitor_supports_rb() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 4b2d3453fc5c..b8deced8de01

[Intel-gfx] [PATCH 13/25] drm/edid: convert drm_mode_std() and children to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 52 -- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[Intel-gfx] [PATCH 12/25] drm/edid: convert drm_cvt_modes_for_range() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 3931c3318cf7..27655da6ef9c 100644 ---

[Intel-gfx] [PATCH 11/25] drm/edid: convert drm_gtf_modes_for_range() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 88bb6c7ac97c..3931c3318cf7 100644 ---

[Intel-gfx] [PATCH 10/25] drm/edid: convert drm_dmt_modes_for_range() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index b5d7347f32d9..88bb6c7ac97c 100644 ---

[Intel-gfx] [PATCH 08/25] drm/edid: convert struct detailed_mode_closure to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index fdc6ad651d3f..1abdd88ff64b

[Intel-gfx] [PATCH 09/25] drm/edid: convert drm_mode_detailed() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 1abdd88ff64b..b5d7347f32d9 100644 ---

[Intel-gfx] [PATCH 07/25] drm/edid: convert drm_edid_connector_update() to drm_edid fully

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 95 ++ 1 file changed, 46 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[Intel-gfx] [PATCH 06/25] drm/edid: propagate drm_edid to drm_edid_to_eld()

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index c9d48fbd0a76..74038be72ad3 100644 ---

[Intel-gfx] [PATCH 05/25] drm/edid: keep propagating drm_edid to display info

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 50 +++--- 1 file changed, 31 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[Intel-gfx] [PATCH 04/25] drm/edid: start propagating drm_edid to lower levels

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. This is a clunky start, but a start nonetheless. We'll eventually convert all of the EDID parsing to struct drm_edid. Initially, we'll just create the struct drm_edid in stack. This will be the compat layer for legacy struct edid code. In the future,

[Intel-gfx] [PATCH 03/25] drm/edid: add struct drm_edid container

2022-05-06 Thread Jani Nikula
Introduce new opaque type struct drm_edid to encapsulate the EDID data and the size allocated for it. The contents will be private to drm_edid.c. There are a number of reasons for adding a container around struct edid: * struct edid is a raw blob pointer to data that usually originates outside

[Intel-gfx] [PATCH 02/25] drm/edid: convert drm_for_each_detailed_block() to edid iter

2022-05-06 Thread Jani Nikula
We have an iterator for this, use it. It does include the base block, but its tag is 0 and will be skipped. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

[Intel-gfx] [PATCH 01/25] drm/edid: use else-if in CTA extension parsing

2022-05-06 Thread Jani Nikula
Only one of the conditions can be true. Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[Intel-gfx] [PATCH 00/25] drm/edid: introduce struct drm_edid

2022-05-06 Thread Jani Nikula
Introduce struct drm_edid and start converting struct edid * to struct drm_edid * in the EDID parsing. The rationale for drm_edid is explained in depth in commit message for patch 3. Initially, there's little functional benefit in the series, it's mostly just prep work. It's also intended to be

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc/rc: Use i915_probe_error instead of drm_error

2022-05-06 Thread Patchwork
== Series Details == Series: drm/i915/guc/rc: Use i915_probe_error instead of drm_error URL : https://patchwork.freedesktop.org/series/103656/ State : success == Summary == CI Bug Log - changes from CI_DRM_11614_full -> Patchwork_103656v1_full

Re: [Intel-gfx] [PATCH -next] drm/i915/gt: Fix build error without CONFIG_PM

2022-05-06 Thread Andi Shyti
Hi YueHaibing, On Fri, May 06, 2022 at 11:26:52AM +0800, YueHaibing wrote: > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c: In function ‘act_freq_mhz_show’: > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:276:20: error: implicit > declaration of function ‘sysfs_gt_attribute_r_max_func’ >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Fix build error without CONFIG_PM

2022-05-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix build error without CONFIG_PM URL : https://patchwork.freedesktop.org/series/103654/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11614_full -> Patchwork_103654v1_full Summary

Re: [Intel-gfx] [PATCH -next] drm/i915/gt: Fix build error without CONFIG_PM

2022-05-06 Thread Tvrtko Ursulin
On 06/05/2022 04:26, YueHaibing wrote: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c: In function ‘act_freq_mhz_show’: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:276:20: error: implicit declaration of function ‘sysfs_gt_attribute_r_max_func’ [-Werror=implicit-function-declaration] 276 |

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Support programming the EU priority in the GuC descriptor

2022-05-06 Thread Tvrtko Ursulin
On 05/05/2022 19:56, John Harrison wrote: On 5/4/2022 16:46, Daniele Ceraolo Spurio wrote: From: Matthew Brost In GuC submission mode the EU priority must be updated by the GuC rather than the driver as the GuC owns the programming of the context descriptor. Given that the GuC code uses

  1   2   >