On 18-11-2022 03:44, Rodrigo Vivi wrote:
On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote:
From: Vinay Belgaumkar
By defaut idle mesaging is disabled for GSC CS so to unblock RC6
entry on media tile idle messaging need to be enabled.
v2:
- Fix review comments (Vinay)
-
== Series Details ==
Series: Add module oriented dmesg output
URL : https://patchwork.freedesktop.org/series/111050/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12397 -> Patchwork_111050v1
Summary
---
**SUCCESS**
== Series Details ==
Series: Add module oriented dmesg output
URL : https://patchwork.freedesktop.org/series/111050/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Add module oriented dmesg output
URL : https://patchwork.freedesktop.org/series/111050/
State : warning
== Summary ==
Error: dim checkpatch failed
910945e13c6a drm/i915/gt: Start adding module oriented dmesg output
-:229: CHECK:MACRO_ARG_REUSE: Macro argument
From: John Harrison
Create a set of HuC printers and start using them.
Signed-off-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_huc.c | 31 ++
drivers/gpu/drm/i915/gt/uc/intel_huc.h | 23 +++
2 files changed, 35 insertions(+), 19 deletions(-)
From: John Harrison
Create a set of GuC printers and start using them.
Signed-off-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc.c| 32 --
drivers/gpu/drm/i915/gt/uc/intel_guc.h| 35 +++
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c| 8 +--
From: John Harrison
Re-work the existing GuC CT printers and extend as required to match
the new wrapping scheme.
Signed-off-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 222 +++---
1 file changed, 113 insertions(+), 109 deletions(-)
diff --git
From: John Harrison
Use the new module oriented output message helpers where possible.
Signed-off-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c| 108 +++
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 98 ++--
2 files changed, 99
From: John Harrison
When trying to analyse bug reports from CI, customers, etc. it can be
difficult to work out exactly what is happening on which GT in a
multi-GT system. So add GT oriented debug/error message wrappers. If
used instead of the drm_ equivalents, you get the same output but with
a
From: John Harrison
When trying to analyse bug reports from CI, customers, etc. it can be
difficult to work out exactly what is happening on which GT in a
multi-GT system. So add GT oriented debug/error message wrappers. If
used instead of the drm_ equivalents, you get the same output but with
a
On Thu, Nov 17, 2022 at 03:00:01PM -0800, Anusha Srivatsa wrote:
> From: Ville Syrjälä
>
> For MTL, changing cdclk from between certain frequencies has
> both squash and crawl. Use the current cdclk config and
> the new(desired) cdclk config to construtc a mid cdclk config.
== Series Details ==
Series: drm/i915/pxp: Add missing cleanup steps for PXP global-teardown
URL : https://patchwork.freedesktop.org/series/111047/
State : failure
== Summary ==
Error: make failed
CALLscripts/checksyscalls.sh
DESCEND objtool
MODPOST Module.symvers
ERROR: modpost:
On Thu, 2022-11-17 at 16:36 -0800, Alan Previn wrote:
> A driver bug was recently discovered where the security firmware was
> receiving internal HW signals indicating that session key expirations
> had occurred. Architecturally, the firmware was expecting a response
> from the GuC to acknowledge
A gap was recently discovered where if an application did not
invalidate all of the stream keys (intentionally or not), and the
driver did a full PXP global teardown on the GT subsystem, we
find that future session creation would fail on the security
firmware's side of the equation. i915 is the
A driver bug was recently discovered where the security firmware was
receiving internal HW signals indicating that session key expirations
had occurred. Architecturally, the firmware was expecting a response
from the GuC to acknowledge the event with the firmware side.
However the OS was in a
A customer issue was recently discovered and in the process a
gap in i915's PXP interaction with HW+FW architecure was also
realized. This series adds those missing pieces.
The patches explain the details.
Alan Previn (2):
drm/i915/pxp: Invalidate all PXP fw sessions during teardown
On Fri, Nov 18, 2022 at 09:06:36AM +1100, Stephen Rothwell wrote:
> Hi Nathan,
>
> On Thu, 17 Nov 2022 10:29:33 -0700 Nathan Chancellor
> wrote:
> >
> > This resolution is not quite right, as pointed out by clang:
> >
> > drivers/gpu/drm/vc4/vc4_hdmi.c:351:14: error: variable 'vc4_hdmi' is
== Series Details ==
Series: series starting with [1/3] drm/i915/display: Add missing checks for
cdclk crawling
URL : https://patchwork.freedesktop.org/series/111045/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12396 -> Patchwork_111045v1
== Series Details ==
Series: series starting with [1/3] drm/i915/display: Add missing checks for
cdclk crawling
URL : https://patchwork.freedesktop.org/series/111045/
State : warning
== Summary ==
Error: dim checkpatch failed
c105abf14fde drm/i915/display: Add missing checks for cdclk
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/dg2: Introduce Wa_18018764978
URL : https://patchwork.freedesktop.org/series/111042/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12396 -> Patchwork_111042v1
== Series Details ==
Series: drm/i915/dmc: Add MTL DMC firmware v2.10
URL : https://patchwork.freedesktop.org/series/111020/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12392_full -> Patchwork_111020v1_full
Summary
On Thu, 2022-11-17 at 11:04 -0500, Vivi, Rodrigo wrote:
> On Wed, Nov 16, 2022 at 04:30:14PM -0800, Alan Previn wrote:
> > Make intel_pxp_is_enabled a global check and implicitly find the
> > PXP-owning-GT.
> >
> > PXP feature support is a device-config flag. In preparation for MTL
> > PXP
As per bSpec MTL has 38.4 MHz Reference clock.
Adding the cdclk tables and cdclk_funcs that MTL
will use.
v2: Revert to using bxt_get_cdclk()
BSpec: 65243
Cc: Clint Taylor
Signed-off-by: Anusha Srivatsa
Reviewed-by: Clint Taylor
---
drivers/gpu/drm/i915/display/intel_cdclk.c | 22
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/dg2: Introduce Wa_18018764978
URL : https://patchwork.freedesktop.org/series/111042/
State : warning
== Summary ==
Error: dim checkpatch failed
7b856027caa8 drm/i915/dg2: Introduce Wa_18018764978
-:37:
cdclk_sanitize() function was written assuming vco was a signed integer.
vco gets assigned to -1 (essentially ~0) for the case where PLL
might be enabled and vco is not a frequency that will ever
get used. In such a scenario the right thing to do is disable the
PLL and re-enable it again with a
From: Ville Syrjälä
For MTL, changing cdclk from between certain frequencies has
both squash and crawl. Use the current cdclk config and
the new(desired) cdclk config to construtc a mid cdclk config.
Set the cdclk twice:
- Current cdclk -> mid cdclk
- mid cdclk -> desired cdclk
Driver should
On 11/3/2022 3:41 AM, Winkler, Tomas wrote:
Starting on MTL, the GSC FW is loaded at runtime and will be managed
directly by i915. This means we now have a naming clash around the GSC, as
we have 2 different aspects of it that we need to handle: the HECI interfaces
we export pre-mtl and the
== Series Details ==
Series: drm/i915/rpl-p: Add stepping info
URL : https://patchwork.freedesktop.org/series/111041/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12396 -> Patchwork_111041v1
Summary
---
**SUCCESS**
On Thu, 2022-11-17 at 11:02 -0500, Vivi, Rodrigo wrote:
> On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan Previn wrote:
> > In preparation for future MTL-PXP feature support, PXP control
> > context should only valid on the correct gt tile. Depending on the
> > device-info this depends on which
Wa_18019271663 applies to all DG2 steppings and skus.
Bspec: 66622
Signed-off-by: Matt Atwood
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 7 ---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git
Wa_18018764978 applies to specific steppings of DG2 (G10 C0+,
G11 and G12 A0+).
Bspec: 66622
Signed-off-by: Matt Atwood
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +++
drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +
2 files changed, 8 insertions(+)
diff --git
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/mtl: Fix dram info readout
URL : https://patchwork.freedesktop.org/series/111039/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12396 -> Patchwork_111039v1
On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote:
> From: Vinay Belgaumkar
>
> By defaut idle mesaging is disabled for GSC CS so to unblock RC6
> entry on media tile idle messaging need to be enabled.
>
> v2:
> - Fix review comments (Vinay)
> - Set GSC idle hysterisis to 5 us
Hi Nathan,
On Thu, 17 Nov 2022 10:29:33 -0700 Nathan Chancellor wrote:
>
> This resolution is not quite right, as pointed out by clang:
>
> drivers/gpu/drm/vc4/vc4_hdmi.c:351:14: error: variable 'vc4_hdmi' is
> uninitialized when used here [-Werror,-Wuninitialized]
>
On Mon, Nov 14, 2022 at 06:03:43PM +0530, Badal Nilawar wrote:
> This series includes the code changes to get CAGF, RC State and C6
> Residency of MTL.
>
> v3: Included "Use GEN12 RPSTAT register" patch
>
> v4:
> - Rebased
> - Dropped "Use GEN12 RPSTAT register" patch from this series
>
== Series Details ==
Series: drm: Analog TV Improvements (rev11)
URL : https://patchwork.freedesktop.org/series/107892/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12392_full -> Patchwork_107892v11_full
Summary
---
On Thu, Nov 17, 2022 at 01:41:32PM -0800, Matt Atwood wrote:
> Add stepping-substepping info in accordance to bpsec changes.
>
> Bspec: 55376
>
> Cc: Anusha Srivatsa
> Signed-off-by: Matt Atwood
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/intel_step.c | 7 +++
> 1 file
On Thu, Nov 17, 2022 at 01:30:15PM -0800, Radhakrishna Sripada wrote:
> MTL LPDDR5 reported 16b with 8 channels. Previous platforms
> reported 32b with 4 channels and hence needed a multiplication
> by a factor of 2. Skip increasing the channels for MTL.
>
> v2: Use version check instead of
== Series Details ==
Series: Fix live busy stats selftest failure (rev3)
URL : https://patchwork.freedesktop.org/series/110557/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12396 -> Patchwork_110557v3
Summary
---
On Thu, Nov 17, 2022 at 01:30:14PM -0800, Radhakrishna Sripada wrote:
> Register info read from the hardware is being cleared out. Preserve
> the register value and use extracted fields in the logic.
This description is kind of hard to understand if you don't already know
what the problem is (and
Add stepping-substepping info in accordance to bpsec changes.
Bspec: 55376
Cc: Anusha Srivatsa
Signed-off-by: Matt Atwood
---
drivers/gpu/drm/i915/intel_step.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_step.c
b/drivers/gpu/drm/i915/intel_step.c
MTL LPDDR5 reported 16b with 8 channels. Previous platforms
reported 32b with 4 channels and hence needed a multiplication
by a factor of 2. Skip increasing the channels for MTL.
v2: Use version check instead of platform check(MattR)
Bspec: 64631
Cc: Matt Roper
Signed-off-by: Radhakrishna
Register info read from the hardware is being cleared out. Preserve
the register value and use extracted fields in the logic.
Fixes: 825477e77912 ("drm/i915/mtl: Obtain SAGV values from MMIO instead of GT
pcode mailbox")
Cc: Matt Roper
Signed-off-by: Radhakrishna Sripada
---
== Series Details ==
Series: drm/i915/mtl: Enable Idle Messaging for GSC CS
URL : https://patchwork.freedesktop.org/series/111011/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12392_full -> Patchwork_111011v1_full
Summary
== Series Details ==
Series: drm/i915/mtl: Skip doubling channel numbers for LPDDR4/LPDDDR5
URL : https://patchwork.freedesktop.org/series/111036/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12396 -> Patchwork_111036v1
On Thu, Nov 17, 2022 at 11:22:04AM -0800, Radhakrishna Sripada wrote:
> MTL LPDDR5 reported 16b with 8 channels. Previous platforms
> reported 32b with 4 channels and hence needed a mulitplication
> by a factor of 2. Skip increasing the channels for MTL.
Looks like the bspec was just updated a
== Series Details ==
Series: drm/i915/gt: Manage uncore->lock while waiting on MCR register
URL : https://patchwork.freedesktop.org/series/111033/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12396 -> Patchwork_111033v1
MTL LPDDR5 reported 16b with 8 channels. Previous platforms
reported 32b with 4 channels and hence needed a mulitplication
by a factor of 2. Skip increasing the channels for MTL.
While at it fix the logic while reading dram info num channels.
Bspec: 64631
Fixes: 825477e77912 ("drm/i915/mtl:
Hi Dave, Daniel,
A few fixes for v6.1-rc6.
Most important one apears to be reverting a change that breaks DP-MST.
drm-misc-fixes-2022-11-17:
drm-misc-fixes for v6.1-rc6:
- Fix error handling in vc4_atomic_commit_tail()
- Set bpc for logictechno panels.
- Fix potential memory leak in
== Series Details ==
Series: drm/i915/display: Don't disable DDI/Transcoder when setting phy test
pattern (rev4)
URL : https://patchwork.freedesktop.org/series/108636/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12391_full -> Patchwork_108636v4_full
The GT MCR code currently relies on uncore->lock to avoid race
conditions on the steering control register during MCR operations. The
*_fw() versions of MCR operations expect the caller to already hold
uncore->lock, while the non-fw variants manage the lock internally.
However the sole callsite
Hi Stephen,
On Wed, Nov 16, 2022 at 10:57:02AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the drm-misc tree got a conflict in:
>
> drivers/gpu/drm/vc4/vc4_hdmi.c
>
> between commit:
>
> 682f99b8ae88 ("drm/vc4: hdmi: Take our lock to reset the link")
>
> from
On Thu, Nov 17, 2022 at 04:49:28PM +0100, Mauro Carvalho Chehab wrote:
> On Thu, 17 Nov 2022 10:29:01 +0100
> Maxime Ripard wrote:
>
> > From: Mateusz Kwiatkowski
> >
> > Add support for the following composite output modes (all of them are
> > somewhat more obscure than the previously defined
On Wed, Nov 16, 2022 at 04:30:16PM -0800, Alan Previn wrote:
> Ensure i915_pxp_tee_component_bind / unbind implicitly sorts out
> getting the correct per-GT PXP control-context from the PXP-owning-GT
> when establishing or ending connection. Thus, replace _i915_to_pxp_gt
> with
On Wed, Nov 16, 2022 at 04:30:15PM -0800, Alan Previn wrote:
> Make intel_pxp_is_active a global check and implicitly find
> the PXP-owning-GT.
>
> As per prior two patches, callers of this function shall now
> pass in i915 since PXP is a global GPU feature. Make
> intel_pxp_is_active implicitly
On Wed, Nov 16, 2022 at 04:30:14PM -0800, Alan Previn wrote:
> Make intel_pxp_is_enabled a global check and implicitly find the
> PXP-owning-GT.
>
> PXP feature support is a device-config flag. In preparation for MTL
> PXP control-context shall reside on of the two GT's. That said,
> update
On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan Previn wrote:
> In preparation for future MTL-PXP feature support, PXP control
> context should only valid on the correct gt tile. Depending on the
> device-info this depends on which tile owns the VEBOX and KCR.
> PXP is still a global feature though
On 11/16/2022 5:29 PM, Brian Norris wrote:
Hi Daniele,
On Thu, Nov 10, 2022 at 04:56:51PM -0800, Daniele Ceraolo Spurio wrote:
The fence is always initialized in huc_init_early, but the cleanup in
huc_fini is only being run if HuC is enabled. This causes a leaking of
the debug object when
On Thu, 17 Nov 2022 10:29:01 +0100
Maxime Ripard wrote:
> From: Mateusz Kwiatkowski
>
> Add support for the following composite output modes (all of them are
> somewhat more obscure than the previously defined ones):
>
> - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to
>
On Thu, Nov 17, 2022 at 03:35:57PM +0100, Mauro Carvalho Chehab wrote:
> On Thu, 17 Nov 2022 10:28:48 +0100
> Maxime Ripard wrote:
>
> > The TV mode property has been around for a while now to select and get the
> > current TV mode output on an analog TV connector.
> >
> > Despite that property
== Series Details ==
Series: series starting with [1/1] drm/i915: use the original Wa_14010685332
for PCH_ADP
URL : https://patchwork.freedesktop.org/series/110988/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12391_full -> Patchwork_110988v1_full
On Thu, 17 Nov 2022 10:28:48 +0100
Maxime Ripard wrote:
> The TV mode property has been around for a while now to select and get the
> current TV mode output on an analog TV connector.
>
> Despite that property name being generic, its content isn't and has been
> driver-specific which makes it
On Thu, 17 Nov 2022, Ville Syrjälä wrote:
> On Wed, Nov 09, 2022 at 04:42:06PM +0200, Jani Nikula wrote:
>> The HTI or HDPORT handling is sprinkled around. Centralize to one place.
>>
>> Add a note about how subtle the mapping from HDPORT_STATE register to
>> dpll mask actually is.
>>
>>
On Thu, Nov 17, 2022 at 03:24:51PM +0200, Ville Syrjälä wrote:
> On Mon, Nov 14, 2022 at 02:22:51PM +0200, Imre Deak wrote:
> > MTL+ requires the AUX_IO power for the main link only on eDP, so don't
> > enable it in other cases.
> >
> > v2:
> > - Rebased on checking intel_encoder_can_psr()
On Thu, Nov 17, 2022 at 02:41:06PM +0800, Zhenyu Wang wrote:
> On 2022.11.17 03:37:17 +, Vivi, Rodrigo wrote:
> > On Thu, 2022-11-17 at 11:02 +0800, Zhenyu Wang wrote:
> > > On 2022.11.15 10:36:59 -0500, Rodrigo Vivi wrote:
> > > > On Fri, Nov 11, 2022 at 04:59:03PM +0800, Zhenyu Wang wrote:
>
On Mon, Nov 14, 2022 at 02:22:51PM +0200, Imre Deak wrote:
> MTL+ requires the AUX_IO power for the main link only on eDP, so don't
> enable it in other cases.
>
> v2:
> - Rebased on checking intel_encoder_can_psr() instead of crtc->has_psr.
>
> Cc: Ville Syrjälä
> Signed-off-by: Imre Deak
>
On Wed, Nov 09, 2022 at 04:42:06PM +0200, Jani Nikula wrote:
> The HTI or HDPORT handling is sprinkled around. Centralize to one place.
>
> Add a note about how subtle the mapping from HDPORT_STATE register to
> dpll mask actually is.
>
> Signed-off-by: Jani Nikula
> ---
>
== Series Details ==
Series: drm/i915/pxp: Prepare intel_pxp entry points for MTL (rev4)
URL : https://patchwork.freedesktop.org/series/109429/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12390_full -> Patchwork_109429v4_full
== Series Details ==
Series: drm/i915/dmc: Add MTL DMC firmware v2.10
URL : https://patchwork.freedesktop.org/series/111020/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12392 -> Patchwork_111020v1
Summary
---
Den 17.11.2022 10.28, skrev Maxime Ripard:
> That file is included directly, so we can't use any MODULE macro. Let's
> leave a comment to avoid any future mistake.
>
> Signed-off-by: Maxime Ripard
> ---
Reviewed-by: Noralf Trønnes
On Thu, 13 Oct 2022 at 09:40, Nirmoy Das wrote:
>
> Add a function for ratelimitted debug print.
>
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: Thomas Zimmermann
> Cc: David Airlie
> Cc: Daniel Vetter
> Signed-off-by: Nirmoy Das
Reviewed-by: Matthew Auld
> ---
>
== Series Details ==
Series: i915: CAGF and RC6 changes for MTL (rev14)
URL : https://patchwork.freedesktop.org/series/108156/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12390_full -> Patchwork_108156v14_full
Summary
On Wed, 16 Nov 2022, Ville Syrjälä wrote:
> On Wed, Nov 16, 2022 at 05:06:57PM +0200, Jani Nikula wrote:
>> Panel power off delay is the time the panel power needs to remain off
>> after being switched off, before it can be switched on again.
>>
>> For the purpose of respecting panel power off
== Series Details ==
Series: drm: Analog TV Improvements (rev11)
URL : https://patchwork.freedesktop.org/series/107892/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12392 -> Patchwork_107892v11
Summary
---
On 13/10/2022 09:40, Nirmoy Das wrote:
Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause
dmesg spamming. Use ratelimit api to reduce log rate.
References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038
Cc: Matthew Auld
Signed-off-by: Nirmoy Das
Reviewed-by: Matthew
== Series Details ==
Series: drm: Analog TV Improvements (rev11)
URL : https://patchwork.freedesktop.org/series/107892/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/mtl: Enable Idle Messaging for GSC CS
URL : https://patchwork.freedesktop.org/series/111011/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12392 -> Patchwork_111011v1
Summary
---
== Series Details ==
Series: drm/i915: Finish (de)gamma readout (rev9)
URL : https://patchwork.freedesktop.org/series/79614/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12390_full -> Patchwork_79614v9_full
Summary
== Series Details ==
Series: drm/i915/edp: wait power off delay at driver remove to optimize probe
URL : https://patchwork.freedesktop.org/series/110971/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12390_full -> Patchwork_110971v1_full
On 11/16/2022 12:25 PM, Janusz Krzysztofik wrote:
Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work
with GuC") extended the API of intel_gt_retire_requests_timeout() with an
extra argument 'remaining_timeout', intended for passing back unconsumed
portion of requested
Looks very relevant to our recent hangcheck failures.
Acked-by: Nirmoy Das
On 11/16/2022 12:25 PM, Janusz Krzysztofik wrote:
Users of intel_gt_retire_requests_timeout() expect 0 return value on
success. However, we have no protection from passing back 0 potentially
returned by
This patch adds DMC firmware v2.10 for Meteorlake.
Release Notes:
1.DCstate residency counter
2.Traphit fix
3.LM TONEFACT fix
4.Ramp up timer fix(PFET)
Signed-off-by: Madhumitha Tolakanahalli Pradeep
---
drivers/gpu/drm/i915/display/intel_dmc.c | 4
1 file changed, 4 insertions(+)
diff
The following changes since commit daff40492bd0cd071c7f5521b339e12e4de718c1:
linux-firmware: update firmware for MT7986 (2022-11-16 08:53:28 -0500)
are available in the Git repository at:
git://anongit.freedesktop.org/drm/drm-firmware mtl_dmc_v2.10
for you to fetch changes up to
Now that the core can deal fine with analog TV modes, let's convert the
sun4i TV driver to leverage those new features.
Acked-by: Noralf Trønnes
Reviewed-by: Jernej Skrabec
Signed-off-by: Maxime Ripard
---
Changes in v6:
- Convert to new get_modes helper
Changes in v5:
- Removed the count
Now that the core can deal fine with analog TV modes, let's convert the vc4
VEC driver to leverage those new features.
We've added some backward compatibility to support the old TV mode property
and translate it into the new TV norm property. We're also making use of
the new analog TV
From: Mateusz Kwiatkowski
Add support for the following composite output modes (all of them are
somewhat more obscure than the previously defined ones):
- NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to
4.43361875 MHz (the PAL subcarrier frequency). Never used for
The analog TV connector drivers share some atomic_check logic, and the new
TV standard property have created some boilerplate that can be shared
across drivers too.
Let's create an atomic_check helper for those use cases.
Reviewed-by: Noralf Trønnes
Tested-by: Mateusz Kwiatkowski
The analog TV properties created by the drm_mode_create_tv_properties() are
not properly initialised at reset. Let's switch our implementation to call
drm_atomic_helper_connector_tv_reset().
Reviewed-by: Noralf Trønnes
Tested-by: Mateusz Kwiatkowski
Signed-off-by: Maxime Ripard
---
The drm_tv_create_properties() function will create a bunch of properties,
but it's up to each and every driver using that function to properly reset
the state of these properties leading to inconsistent behaviours.
Let's create a helper that will take care of it.
Reviewed-by: Noralf Trønnes
The framework will get the drm_display_mode from the drm_cmdline_mode it
got by parsing the video command line argument by calling
drm_connector_pick_cmdline_mode().
The heavy lifting will then be done by the
drm_mode_create_from_cmdline_mode() function.
In the case of the named modes though,
From: Mateusz Kwiatkowski
The VEC can accept pretty much any relatively reasonable mode, but still
has a bunch of constraints to meet.
Let's create an atomic_check() implementation that will make sure we
don't end up accepting a non-functional mode.
Acked-by: Noralf Trønnes
Signed-off-by:
From: Noralf Trønnes
Most of the TV connectors will need a similar get_modes implementation
that will, depending on the drivers' capabilities, register the 480i and
576i modes.
That implementation will also need to set the preferred flag and order
the modes based on the driver and users
Commit 3aeeb13d8996 ("drm/modes: Support modes names on the command
line") initially introduced the named modes support by essentially
matching the name passed on the command-line to the mode names defined
by the drivers.
This proved to be difficult to work with, since all drivers had to
provide
Now that we can easily extend the named modes list, let's add a few more
analog TV modes that were used in the wild, and some unit tests to make
sure it works as intended.
Reviewed-by: Noralf Trønnes
Tested-by: Mateusz Kwiatkowski
Signed-off-by: Maxime Ripard
---
Changes in v9:
- Document the
As part of the command line parsing rework coming in the next patches,
we'll need to lookup drm_connector_tv_mode values by their name, already
defined in drm_tv_mode_enum_list.
In order to avoid any code duplication, let's do a function that will
perform a lookup of a TV mode name and return its
The drm_create_tv_properties() will create the TV mode property
unconditionally.
However, since we'll gradually phase it out, let's register it only if we
have a list passed as an argument. This will make the transition easier.
Acked-by: Noralf Trønnes
Tested-by: Mateusz Kwiatkowski
Our new tv mode option allows to specify the TV mode from a property.
However, it can still be useful, for example to avoid any boot time
artifact, to set that property directly from the kernel command line.
Let's add some code to allow it, and some unit tests to exercise that code.
Reviewed-by:
Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and
625-lines modes in their drivers.
Since those modes are fairly standard, and that we'll need to use them
in more places in the future, it makes sense to move their definition
into the core framework.
However, analog display
The TV mode property has been around for a while now to select and get the
current TV mode output on an analog TV connector.
Despite that property name being generic, its content isn't and has been
driver-specific which makes it hard to build any generic behaviour on top
of it, both in kernel and
drm_mode_create_tv_properties(), among other things, will create the
"mode" property that stores the analog TV mode that connector is
supposed to output.
However, that property is getting deprecated, so let's rename that
function to mention it's deprecated. We'll introduce a new variant of
that
1 - 100 of 106 matches
Mail list logo
