Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ratelimit errors in display engine irq (rev2)

2022-12-15 Thread Yedireswarapu, SaiX Nandan
Hi, Issue re-reported, https://patchwork.freedesktop.org/series/111951/ Thanks, Y Sai Nandan -Original Message- From: De Marchi, Lucas Sent: Friday, December 16, 2022 5:55 AM To: intel-gfx@lists.freedesktop.org Cc: Yedireswarapu, SaiX Nandan Subject: Re: ✗ Fi.CI.BAT: failure for

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: ratelimit errors in display engine irq (rev2)

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915: ratelimit errors in display engine irq (rev2) URL : https://patchwork.freedesktop.org/series/111951/ State : success == Summary == CI Bug Log - changes from CI_DRM_12511 -> Patchwork_111951v2 Summary

Re: [Intel-gfx] [PATCH] drm/i915: improve the catch-all evict to handle lock contention

2022-12-15 Thread Mani Milani
This patch passed all my tests, some of which were failing before applying the patch. Thanks. Reviewed-by: Mani Milani Tested-by: Mani Milani On Thu, Dec 15, 2022 at 4:46 PM Mani Milani wrote: > > Thanks for the explanations Matthew. It all makes sense now. I will > now test this patch

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsb: DSB fixes/cleanups

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915/dsb: DSB fixes/cleanups URL : https://patchwork.freedesktop.org/series/111997/ State : success == Summary == CI Bug Log - changes from CI_DRM_12511 -> Patchwork_111997v1 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsb: DSB fixes/cleanups

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915/dsb: DSB fixes/cleanups URL : https://patchwork.freedesktop.org/series/111997/ State : warning == Summary == Error: dim checkpatch failed 5051d5d03037 drm/i915/dsb: Stop with the RMW a5525d4aab22 drm/i915/dsb: Inline DSB_CTRL writes into

[Intel-gfx] [PATCH 12/13] drm/i915/dsb: Define more DSB registers

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä Add definitions for more DSB registers. Less annoying spec trawling when working on the DSB code. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 50 +++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 13/13] drm/i915/dsb: Pimp debug/error prints

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä Print the crtc/DSB id information to make it clear which DSB engine we're talking about. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dsb.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH 05/13] drm/i915/dsb: Extract assert_dsb_has_room()

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä Pull the DSB command buffer size checks into a small helper so we don't have repeat the same thing multiple times. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dsb.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff

[Intel-gfx] [PATCH 11/13] drm/i915/dsb: Add mode DSB opcodes

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä Add all the know DSB instruction opcodes. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dsb.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c index

[Intel-gfx] [PATCH 10/13] drm/i915/dsb: Allow the caller to pass in the DSB buffer size

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä The caller should more or less know how many DSB commands it wants to emit into the command buffer, so allow it to specify the size of the command buffer rather than having the low level DSB code guess it. Technically we can emit as many as 134+1033 (for adl+ degamma + 10bit

[Intel-gfx] [PATCH 09/13] drm/i915/dsb: Introduce intel_dsb_align_tail()

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä Move the DSB tail cacheline alignment to a helper. No need to pollute the caller with mundane details like this. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dsb.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff

[Intel-gfx] [PATCH 08/13] drm/i915/dsb: Handle the indexed vs. not inside the DSB code

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä The DSB indexed register write insturction is purely an internal DSB implementation detail, no reason why the caller should have to know about it. So let's just have the caller emit blind register writes let the DSB code convert things to an indexed write if/when multiple

[Intel-gfx] [PATCH 06/13] drm/i915/dsb: Extract intel_dsb_emit()

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä Extract a small helper to emit a DSB intstruction. Should become useful if/when we need to start emitting other instructions besides register writes. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dsb.c | 30 1 file changed, 20

[Intel-gfx] [PATCH 04/13] drm/i915/dsb: Fix DSB command buffer size checks

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä free_pos is in dwords, DSB_BUF_SIZE in bytes. Directly comparing the two is nonsense. Fix it up, and make sure we also account for the 8byte alignment requirement for each instruction, and also assume that each instruction normally eats two dwords. Signed-off-by: Ville

[Intel-gfx] [PATCH 07/13] drm/i915/dsb: Improve the indexed reg write checks

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä Currently intel_dsb_indexed_reg_write() just assumes the previus instructions is also an indexed register write, and thus only checks the register offset. Make the check more robust by actually checking the instruction opcode as well. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH 02/13] drm/i915/dsb: Inline DSB_CTRL writes into intel_dsb_commit()

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä No point in having these wrappers for a simple DSB_CTRL write. Inline them into intel_dsb_commit(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dsb.c | 62 ++-- 1 file changed, 14 insertions(+), 48 deletions(-) diff --git

[Intel-gfx] [PATCH 03/13] drm/i915/dsb: Align DSB register writes to 8 bytes

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä Every DSB instruction has to be 8byte aligned. Make sure that is the case for the non-indexed register writes as well. The way this could end up unaligned is we emitted an odd number of indexed register writes beforehand. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH 01/13] drm/i915/dsb: Stop with the RMW

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä We don't want to keep random bits set in DSB_CTRL. Stop the harmful RMW. Also flip the reverse & around to appease my ocd. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dsb.c | 22 +++--- drivers/gpu/drm/i915/i915_reg.h | 2

[Intel-gfx] [PATCH 00/13] drm/i915/dsb: DSB fixes/cleanups

2022-12-15 Thread Ville Syrjala
From: Ville Syrjälä Bunch of DSB related fixes/refactoring/etc. Ville Syrjälä (13): drm/i915/dsb: Stop with the RMW drm/i915/dsb: Inline DSB_CTRL writes into intel_dsb_commit() drm/i915/dsb: Align DSB register writes to 8 bytes drm/i915/dsb: Fix DSB command buffer size checks

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ratelimit errors in display engine irq (rev2)

2022-12-15 Thread Lucas De Marchi
On Thu, Dec 15, 2022 at 08:39:47PM +, Patchwork wrote: == Series Details == Series: drm/i915: ratelimit errors in display engine irq (rev2) URL : https://patchwork.freedesktop.org/series/111951/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12511 -> Patchwork_111951v2

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Add initial gt workarounds

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add initial gt workarounds URL : https://patchwork.freedesktop.org/series/111994/ State : success == Summary == CI Bug Log - changes from CI_DRM_12511 -> Patchwork_111994v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Add initial gt workarounds

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add initial gt workarounds URL : https://patchwork.freedesktop.org/series/111994/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Add initial gt workarounds

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add initial gt workarounds URL : https://patchwork.freedesktop.org/series/111994/ State : warning == Summary == Error: dim checkpatch failed 782c85c8339a drm/i915/mtl: Add initial gt workarounds -:351: CHECK:MACRO_ARG_REUSE: Macro argument reuse

[Intel-gfx] [PATCH v2] drm/i915/mtl: Add initial gt workarounds

2022-12-15 Thread Matt Atwood
From: Matt Roper This patch introduces initial gt workarounds for the MTL platform. v2: drop redundant/stale comments specifying wa platforms affected (Lucas). Drop Wa_22011802037 for MTL. Bspec: 66622 Signed-off-by: Matt Atwood Signed-off-by: Matt Roper ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hwmon: Display clamped PL1 limit (rev2)

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Display clamped PL1 limit (rev2) URL : https://patchwork.freedesktop.org/series/111981/ State : success == Summary == CI Bug Log - changes from CI_DRM_12511 -> Patchwork_111981v2 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for fix dell wyse 3040 poweroff

2022-12-15 Thread Patchwork
== Series Details == Series: fix dell wyse 3040 poweroff URL : https://patchwork.freedesktop.org/series/111987/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/111987/revisions/1/mbox/ not applied Applying: fix dell wyse 3040 poweroff Using index

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ratelimit errors in display engine irq (rev2)

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915: ratelimit errors in display engine irq (rev2) URL : https://patchwork.freedesktop.org/series/111951/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12511 -> Patchwork_111951v2 Summary

[Intel-gfx] [PULL] drm-intel-next-fixes

2022-12-15 Thread Rodrigo Vivi
Hi Dave and Daniel, In case you end up sending more stuff towards 6.2-rc1, please consider sending these fixes below. The migrate related fixes seems to be the most important ones, but also I don't believe it looks so critical that it couldn't wait for the -rc2. Here goes

[Intel-gfx] [PATCH RFC] fix dell wyse 3040 poweroff

2022-12-15 Thread Alexey Lukyanchuk
Dell wyse 3040 cat't poweroff aftet kernel 5.11. It happens because i915_driver_shutdown function. Disabling of this function mitigate this problem. Fixes: 440b354f3 ("drivers/gpu/drm:power off troubles on dell wyse 3040") Signed-off-by: Alexey Lukyanchuk --- There is trouble with

[Intel-gfx] [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state

2022-12-15 Thread david . keisarschm
From: David Since the two functions prandom_byte_state and prandom_u32_state use the weak prng prandom_u32, we added the prefix predictable_rng, to their signatures so it is clear they are weak. Signed-off-by: David --- arch/x86/mm/kaslr.c | 2 +-

Re: [Intel-gfx] [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state

2022-12-15 Thread Eric Dumazet
On Wed, Dec 14, 2022 at 1:34 PM Stanislaw Gruszka wrote: > > On Mon, Dec 12, 2022 at 03:35:20PM +0100, Jason A. Donenfeld wrote: > > Please CC me on future revisions. > > > > As of 6.2, the prandom namespace is *only* for predictable randomness. > > There's no need to rename anything. So nack on

Re: [Intel-gfx] [PATCH 6/9] drm/qxl: stop using ttm_bo_wait

2022-12-15 Thread Dave Airlie
Acked-by: Dave Airlie On Fri, 16 Dec 2022 at 00:20, Christian König wrote: > > Am 25.11.22 um 11:21 schrieb Christian König: > > TTM is just wrapping core DMA functionality here, remove the mid-layer. > > No functional change. > > Any objections to this guys? > > I'm basically just following a

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reset twice

2022-12-15 Thread Rodrigo Vivi
On Wed, Dec 14, 2022 at 11:37:19PM +0100, Andi Shyti wrote: > Hi Rodrigo, > > On Tue, Dec 13, 2022 at 01:18:48PM +, Vivi, Rodrigo wrote: > > On Tue, 2022-12-13 at 00:08 +0100, Andi Shyti wrote: > > > Hi Rodrigo, > > > > > > On Mon, Dec 12, 2022 at 11:55:10AM -0500, Rodrigo Vivi wrote: > > >

Re: [Intel-gfx] [PATCH v15 1/7] overflow: Introduce overflows_type() and castable_to_type()

2022-12-15 Thread Gwan-gyeong Mun
On 12/15/22 5:09 PM, Andrzej Hajda wrote: On 15.12.2022 13:52, Gwan-gyeong Mun wrote: From: Kees Cook Implement a robust overflows_type() macro to test if a variable or constant value would overflow another variable or type. This can be used as a constant expression for static_assert()

Re: [Intel-gfx] [PATCH v3 6/7] drm/i915/mtl: Add function to send command to GSC CS

2022-12-15 Thread Teres Alexis, Alan Previn
On Wed, 2022-12-14 at 14:37 +0530, Suraj Kandpal wrote: > Add function that takes care of sending command to gsc cs. We start > of with allocation of memory for our command intel_hdcp_gsc_message that > contains gsc cs memory header as directed in specs followed by the > actual payload hdcp

Re: [Intel-gfx] [PATCH v3 1/7] drm/i915/gsc: Create GSC request submission mechanism

2022-12-15 Thread Teres Alexis, Alan Previn
On Wed, 2022-12-14 at 14:37 +0530, Kandpal, Suraj wrote: > HDCP and PXP will require a common function to allow it to > submit commands to the gsc cs. Also adding the gsc mtl header > that needs to be added on to the existing payloads of HDCP > and PXP. > > Cc: Daniele Ceraolo Spurio > Cc:

[Intel-gfx] [PATCH] drm/i915/hwmon: Display clamped PL1 limit

2022-12-15 Thread Ashutosh Dixit
HW allows arbitrary PL1 limits to be set but silently clamps these values to "typical but not guaranteed" min/max values in pkg_power_sku register. Follow the same pattern for sysfs, allow arbitrary PL1 limits to be set but display clamped values when read, so that users see PL1 limits HW is

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Display clamped PL1 limit

2022-12-15 Thread Jani Nikula
On Thu, 15 Dec 2022, Ashutosh Dixit wrote: > HW allows arbitrary PL1 limits to be set but silently clamps these values > to "typical but not guaranteed" min/max values in pkg_power_sku > register. Follow the same pattern for sysfs, allow arbitrary PL1 limits to > be set but display clamped values

[Intel-gfx] [PATCH] drm/i915/hwmon: Display clamped PL1 limit

2022-12-15 Thread Ashutosh Dixit
HW allows arbitrary PL1 limits to be set but silently clamps these values to "typical but not guaranteed" min/max values in pkg_power_sku register. Follow the same pattern for sysfs, allow arbitrary PL1 limits to be set but display clamped values when read. Signed-off-by: Ashutosh Dixit ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: Return Wa_22012654132 to just specific steppings

2022-12-15 Thread Matt Roper
On Thu, Dec 15, 2022 at 03:13:07AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dg2: Return Wa_22012654132 to just specific steppings > URL : https://patchwork.freedesktop.org/series/111912/ > State : failure > > == Summary == > > CI Bug Log - changes from

Re: [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+

2022-12-15 Thread Matt Roper
On Thu, Dec 15, 2022 at 05:38:22PM +, Tvrtko Ursulin wrote: > > On 25/08/2022 18:49, Sripada, Radhakrishna wrote: > > Hi G.G, > > > > > -Original Message- > > > From: Mun, Gwan-gyeong > > > Sent: Tuesday, August 23, 2022 11:14 PM > > > To: Roper, Matthew D ; Sripada, Radhakrishna >

Re: [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+

2022-12-15 Thread Tvrtko Ursulin
On 25/08/2022 18:49, Sripada, Radhakrishna wrote: Hi G.G, -Original Message- From: Mun, Gwan-gyeong Sent: Tuesday, August 23, 2022 11:14 PM To: Roper, Matthew D ; Sripada, Radhakrishna Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state

2022-12-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state URL : https://patchwork.freedesktop.org/series/111967/ State : success == Summary == CI Bug Log - changes from CI_DRM_12510 -> Patchwork_111967v1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/fdi: use intel_de_rmw if possible

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915/display/fdi: use intel_de_rmw if possible URL : https://patchwork.freedesktop.org/series/111964/ State : success == Summary == CI Bug Log - changes from CI_DRM_12510 -> Patchwork_111964v1 Summary

[Intel-gfx] [PATCH 2/2] drm/i915/dp_mst: don't pull unregistered connectors into state

2022-12-15 Thread Simon Ser
In intel_dp_mst_atomic_master_trans_check(), we pull connectors sharing the same DP-MST stream into the atomic state. However, if the connector is unregistered, this later fails with: [ 559.425658] i915 :00:02.0: [drm:drm_atomic_helper_check_modeset] [CONNECTOR:378:DP-7] is not

[Intel-gfx] [PATCH 1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state

2022-12-15 Thread Simon Ser
It can be surprising for user-space to see unrelated connectors, CRTCs and planes being implicitly pulled into the atomic commit. Log when that happens. Signed-off-by: Simon Ser Cc: Ville Syrjälä Cc: Jani Nikula Cc: Lyude Paul --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 1 file

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-15 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/111963/ State : success == Summary == CI Bug Log - changes from CI_DRM_12510 -> Patchwork_111963v1

Re: [Intel-gfx] [PATCH v15 1/7] overflow: Introduce overflows_type() and castable_to_type()

2022-12-15 Thread Andrzej Hajda
On 15.12.2022 13:52, Gwan-gyeong Mun wrote: From: Kees Cook Implement a robust overflows_type() macro to test if a variable or constant value would overflow another variable or type. This can be used as a constant expression for static_assert() (which requires a constant expression[1][2])

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-15 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/111963/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-15 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/111963/ State : warning == Summary == Error: dim checkpatch failed e789a2f6d47e overflow:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev8)

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915/dp: wait on timeout before retry include sw delay (rev8) URL : https://patchwork.freedesktop.org/series/111303/ State : success == Summary == CI Bug Log - changes from CI_DRM_12510 -> Patchwork_111303v8

Re: [Intel-gfx] [PATCH 6/9] drm/qxl: stop using ttm_bo_wait

2022-12-15 Thread Christian König
Am 25.11.22 um 11:21 schrieb Christian König: TTM is just wrapping core DMA functionality here, remove the mid-layer. No functional change. Any objections to this guys? I'm basically just following a suggestion from Daniel here and it already triggered a discussion about the timeout for

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev8)

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915/dp: wait on timeout before retry include sw delay (rev8) URL : https://patchwork.freedesktop.org/series/111303/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/display/intel_dsb.c:201: warning: Excess function

Re: [Intel-gfx] [PATCH v3] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-15 Thread Zheng Hacker
Hi Zhi, Thanks for your reply and suggestion about fix. I am a little bit busy now. I will review the code as soon as possible. Also thanks Joonas for the reminding. We'll try to think out the new fix. Best regards, Zheng Wang

Re: [Intel-gfx] [PATCH v4] drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence

2022-12-15 Thread Jani Nikula
On Wed, 14 Dec 2022, Ville Syrjälä wrote: > On Tue, Dec 13, 2022 at 11:59:24AM +0200, Jani Nikula wrote: >> Starting from ICL, the default for MIPI GPIO sequences seems to be using >> native GPIOs i.e. GPIOs available in the GPU. These native GPIOs reuse >> many pins that quite frankly seem scary

Re: [Intel-gfx] [PATCH] drm/i915/display/fdi: use intel_de_rmw if possible

2022-12-15 Thread Jani Nikula
On Thu, 15 Dec 2022, Andrzej Hajda wrote: > The helper makes the code more compact and readable. > > Signed-off-by: Andrzej Hajda Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_fdi.c | 148 +++ > 1 file changed, 44 insertions(+), 104 deletions(-) > >

Re: [Intel-gfx] [PATCH 3/4] drm/i915/mtl: Define new PTE encode for MTL

2022-12-15 Thread Das, Nirmoy
Hi Aravind, On 12/6/2022 8:37 AM, Aravind Iddamsetty wrote: Add a separate PTE encode function for MTL. The number of PAT registers have increased to 16 on MTL. All 16 PAT registers are available for PPGTT mapped pages, but only the lower 4 are available for GGTT mapped pages. BSPEC: 63884

[Intel-gfx] [PATCH] drm/i915/display/fdi: use intel_de_rmw if possible

2022-12-15 Thread Andrzej Hajda
The helper makes the code more compact and readable. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_fdi.c | 148 +++ 1 file changed, 44 insertions(+), 104 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c

[Intel-gfx] [PATCH v15 7/7] drm/i915: Remove truncation warning for large objects

2022-12-15 Thread Gwan-gyeong Mun
From: Chris Wilson Having addressed the issues surrounding incorrect types for local variables and potential integer truncation in using the scatterlist API, we have closed all the loop holes we had previously identified with dangerously large object creation. As such, we can eliminate the

[Intel-gfx] [PATCH v15 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

2022-12-15 Thread Gwan-gyeong Mun
The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it converts return value to -E2BIG. Cc: Chris

[Intel-gfx] [PATCH v15 4/7] drm/i915: Check for integer truncation on the configuration of ttm place

2022-12-15 Thread Gwan-gyeong Mun
There is an impedance mismatch between the first/last valid page frame number of ttm place in unsigned and our memory/page accounting in unsigned long. As the object size is under the control of userspace, we have to be prudent and catch the conversion errors. To catch the implicit truncation as

[Intel-gfx] [PATCH v15 5/7] drm/i915: Check if the size is too big while creating shmem file

2022-12-15 Thread Gwan-gyeong Mun
The __shmem_file_setup() function returns -EINVAL if size is greater than MAX_LFS_FILESIZE. To handle the same error as other code that returns -E2BIG when the size is too large, it add a code that returns -E2BIG when the size is larger than the size that can be handled. v4: If BITS_PER_LONG is

[Intel-gfx] [PATCH v15 3/7] drm/i915: Check for integer truncation on scatterlist creation

2022-12-15 Thread Gwan-gyeong Mun
From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table into which we try to fit very many pages. As the

[Intel-gfx] [PATCH v15 2/7] drm/i915/gem: Typecheck page lookups

2022-12-15 Thread Gwan-gyeong Mun
From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a more suitable long. Be pedantic and add integer typechecking to the lookup so that we can be sure that we are safe.

[Intel-gfx] [PATCH v15 1/7] overflow: Introduce overflows_type() and castable_to_type()

2022-12-15 Thread Gwan-gyeong Mun
From: Kees Cook Implement a robust overflows_type() macro to test if a variable or constant value would overflow another variable or type. This can be used as a constant expression for static_assert() (which requires a constant expression[1][2]) when used on constant values. This must be

[Intel-gfx] [PATCH v15 0/7] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-15 Thread Gwan-gyeong Mun
This patch series fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation, etc. We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead

[Intel-gfx] ✗ Fi.CI.IGT: failure for Enable HDCP2.x via GSC CS (rev3)

2022-12-15 Thread Patchwork
== Series Details == Series: Enable HDCP2.x via GSC CS (rev3) URL : https://patchwork.freedesktop.org/series/111876/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12502_full -> Patchwork_111876v3_full Summary ---

Re: [Intel-gfx] [PATCH v3] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-15 Thread Wang, Zhi A
On 12/15/2022 12:47 PM, Joonas Lahtinen wrote: > (+ Tvrtko as FYI) > > Zhenyu, can you take a look at the patch ASAP. > > Regards, Joonas Thanks so much for the reminding and patch. Actually I don't think it is proper fix as: split_2MB_gtt_entry() is going to allocate a new spt structure,

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Remove hardcoded value with a macro

2022-12-15 Thread Das, Nirmoy
On 12/13/2022 1:38 PM, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* drm/i915/selftests: Remove hardcoded value with a macro *URL:* https://patchwork.freedesktop.org/series/111891/ *State:*failure *Details:*

[Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read

2022-12-15 Thread Arun R Murthy
The busy timeout logic checks for the AUX BUSY, then waits for the timeout period and then after timeout reads the register for BUSY or Success. Instead replace interrupt with polling so as to read the AUX CTL register often before the timeout period. Looks like there might be some issue with

Re: [Intel-gfx] [PATCH 2/7] drm/i915/display: move more scanline functions to intel_vblank.[ch]

2022-12-15 Thread Jani Nikula
On Thu, 15 Dec 2022, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Thursday, December 15, 2022 3:50 PM >> To: Murthy, Arun R ; intel- >> g...@lists.freedesktop.org >> Subject: RE: [Intel-gfx] [PATCH 2/7] drm/i915/display: move more scanline >> functions to

Re: [Intel-gfx] [RFC 1/2] drm/connector: add connector list iteration with filtering

2022-12-15 Thread Daniel Vetter
On Wed, Oct 05, 2022 at 01:51:43PM +0300, Jani Nikula wrote: > Add new function drm_connector_list_iter_filter_begin() to initialize > connector list iterator with a filter function. Subsequent iteration on > the list will only return connectors on which the filter function > returns true. > >

Re: [Intel-gfx] [PATCH v3] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-15 Thread Joonas Lahtinen
(+ Tvrtko as FYI) Zhenyu, can you take a look at the patch ASAP. Regards, Joonas Quoting Dave Airlie (2022-10-27 08:12:31) > On Thu, 27 Oct 2022 at 13:26, Zheng Hacker wrote: > > > > Dave Airlie 于2022年10月27日周四 08:01写道: > > > > > > On Fri, 7 Oct 2022 at 11:38, Zheng Wang wrote: > > > > > > >

Re: [Intel-gfx] [PATCH 2/7] drm/i915/display: move more scanline functions to intel_vblank.[ch]

2022-12-15 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Thursday, December 15, 2022 3:50 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH 2/7] drm/i915/display: move more scanline > functions to intel_vblank.[ch] > > On Thu, 15 Dec 2022, "Murthy,

Re: [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read

2022-12-15 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Thursday, December 15, 2022 4:00 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org; ville.syrj...@linux.intel.com; Deak, Imre > > Cc: Murthy, Arun R > Subject: Re: [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: wait on timeout before retry include sw delay (rev6)

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915/dp: wait on timeout before retry include sw delay (rev6) URL : https://patchwork.freedesktop.org/series/111303/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12508 -> Patchwork_111303v6

Re: [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read

2022-12-15 Thread Jani Nikula
On Thu, 15 Dec 2022, Arun R Murthy wrote: > The busy timeout logic checks for the AUX BUSY, then waits for the > timeout period and then after timeout reads the register for BUSY or > Success. > Instead replace interrupt with polling so as to read the AUX CTL > register often before the timeout

Re: [Intel-gfx] [PATCH] drm/i915: fix TLB invalidation for Gen12.50 video and compute engines

2022-12-15 Thread Andi Shyti
On Wed, Dec 14, 2022 at 08:54:39AM +0100, Andrzej Hajda wrote: > In case of Gen12.50 video and compute engines, TLB_INV registers are > masked - to modify one bit, corresponding bit in upper half of the register > must be enabled, otherwise nothing happens. > > Fixes: 77fa9efc16a9

Re: [Intel-gfx] [PATCH 2/7] drm/i915/display: move more scanline functions to intel_vblank.[ch]

2022-12-15 Thread Jani Nikula
On Thu, 15 Dec 2022, "Murthy, Arun R" wrote: >> >> And how would you propose to drop the wrapper? The wrappers are all >> >> about readability in the caller side: >> >> >> > I didn’t mean to drop the wrapper, understand that wrapper is more >> readable, what I meant is to replace >>

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Implement workaround for CDCLK PLL disable/enable

2022-12-15 Thread Lisovskiy, Stanislav
On Wed, Dec 14, 2022 at 09:15:07PM +0200, Srivatsa, Anusha wrote: > > > > -Original Message- > > From: Lisovskiy, Stanislav > > Sent: Wednesday, December 14, 2022 2:31 AM > > To: Srivatsa, Anusha > > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani > > Subject: Re: [Intel-gfx] [PATCH

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev6)

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915/dp: wait on timeout before retry include sw delay (rev6) URL : https://patchwork.freedesktop.org/series/111303/ State : warning == Summary == Error: dim checkpatch failed 244c68782e95 drm/i915/dp: change aux_ctl reg read to polling read -:40:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: fix TLB invalidation for Gen12.50 video and compute engines

2022-12-15 Thread Patchwork
== Series Details == Series: drm/i915: fix TLB invalidation for Gen12.50 video and compute engines URL : https://patchwork.freedesktop.org/series/111920/ State : success == Summary == CI Bug Log - changes from CI_DRM_12502_full -> Patchwork_111920v1_full

Re: [Intel-gfx] [PATCH 2/7] drm/i915/display: move more scanline functions to intel_vblank.[ch]

2022-12-15 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Thursday, December 15, 2022 2:43 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH 2/7] drm/i915/display: move more scanline > functions to intel_vblank.[ch] > > On Thu, 15 Dec 2022, "Murthy,

[Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read

2022-12-15 Thread Arun R Murthy
The busy timeout logic checks for the AUX BUSY, then waits for the timeout period and then after timeout reads the register for BUSY or Success. Instead replace interrupt with polling so as to read the AUX CTL register often before the timeout period. Looks like there might be some issue with

Re: [Intel-gfx] [PATCH 2/7] drm/i915/display: move more scanline functions to intel_vblank.[ch]

2022-12-15 Thread Jani Nikula
On Thu, 15 Dec 2022, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Wednesday, December 14, 2022 2:45 PM >> To: Murthy, Arun R ; intel- >> g...@lists.freedesktop.org >> Subject: RE: [Intel-gfx] [PATCH 2/7] drm/i915/display: move more scanline >> functions to

Re: [Intel-gfx] [PATCHv5] drm/i915/dp: change aux_ctl reg read to polling read

2022-12-15 Thread Jani Nikula
On Wed, 14 Dec 2022, Arun R Murthy wrote: > The busy timeout logic checks for the AUX BUSY, then waits for the > timeout period and then after timeout reads the register for BUSY or > Success. > Instead replace interrupt with polling so as to read the AUX CTL > register often before the timeout

Re: [Intel-gfx] [PATCH] drm/i915: ratelimit errors in display engine irq

2022-12-15 Thread Jani Nikula
On Wed, 14 Dec 2022, Lucas De Marchi wrote: > While debugging page table faults it's useful not to kill the machine > with thousands of error mesages. Ratelimit all errors in > gen8_de_irq_handler(). > > Signed-off-by: Lucas De Marchi Reviewed-by: Jani Nikula > --- >

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/mtl/UAPI: Disable GET/SET_CACHING IOCTL for MTL+

2022-12-15 Thread Iddamsetty, Aravind
On 07-12-2022 05:19, Matt Roper wrote: > On Tue, Dec 06, 2022 at 01:57:39PM +0530, Aravind Iddamsetty wrote: >> From: Pallavi Mishra >> >> It's a noop on all new platforms starting from MTL. > > To me, saying "it's a noop" implies that the ioctl will succeed and > silently do nothing, which