> On Fri, Oct 28, 2022 at 03:23:02AM +, Murthy, Arun R wrote:
> > Gentle Reminder!
>
> Is the igt stuff merged, and did this pass the test?
>
With IGT alone the tests will fail without the kernel patch.
The
== Series Details ==
Series: DRM scheduling cgroup controller (rev3)
URL : https://patchwork.freedesktop.org/series/109902/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12577_full -> Patchwork_109902v3_full
Summary
== Series Details ==
Series: Enable YCbCr420 for VDSC
URL : https://patchwork.freedesktop.org/series/112777/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12579 -> Patchwork_112777v1
Summary
---
**SUCCESS**
No
== Series Details ==
Series: Enable YCbCr420 for VDSC
URL : https://patchwork.freedesktop.org/series/112777/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Now that we have laid the groundwork for YUV420 Enablement
we fill up native_420 field in vdsc_cfg and add appropriate
checks wherever required.
---v2
-adding native_422 field as 0 [Vandita]
-filling in second_line_bpg_offset, second_line_offset_adj
and nsl_bpg_offset in vds_cfg when native_420
Add function to check if slice design requirements are being
met as defined in Bspec: 49259 in the section
Slice Design Requirement
--v7
-remove full bspec link [Jani]
-rename intel_dsc_check_slice_design_req to
intel_dsc_slice_dimensions_valid [Jani]
Signed-off-by: Suraj Kandpal
---
Implementation of VDSC for YCbCr420.
Add QP tables for 8,10,12 BPC from rc_tables.h in intel_qp_tables.c
(Derived from C-Model, which is given along with DSC1.2a Spec from Vesa)
intel_lookup_range_min/max_qp functons need to take into account the
output format. Based on that appropriate qp table
Adding new DSC register which are introducted MTL onwards
Signed-off-by: Suraj Kandpal
Reviewed-by: Vandita Kulkarni
---
drivers/gpu/drm/i915/i915_reg.h | 28
1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h
This patch series aims to enable the YCbCr420 format
for DSC. Changes are mostly compute params related for
hdmi,dp and dsi along with the addition of new rc_tables
for native_420 and corresponding changes to macros used to
fetch them.
---v2
-add fields missed for vdsc_cfg [Vandita]
-add
From: Ankit Nautiyal
Go with DSC only if the given output_format is supported.
v2: Use drm helper to get DSC format support for sink.
Signed-off-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_dp.c | 30 +
1 file changed, 30 insertions(+)
diff --git
From: Ankit Nautiyal
Add helper function to check if the DP sink supports DSC with the given
output format.
Signed-off-by: Ankit Nautiyal
---
include/drm/display/drm_dp_helper.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/drm/display/drm_dp_helper.h
== Series Details ==
Series: drm/i915: Reject < 1x1 pixel plane source size
URL : https://patchwork.freedesktop.org/series/112743/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12577_full -> Patchwork_112743v1_full
Summary
== Series Details ==
Series: series starting with [1/2] drm: Add SDP Error Detection Configuration
Register
URL : https://patchwork.freedesktop.org/series/112774/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12579 -> Patchwork_112774v1
> -Original Message-
> From: Kandpal, Suraj
> Sent: Wednesday, January 11, 2023 11:09 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Nautiyal, Ankit K ; Kulkarni, Vandita
> ; Navare, Manasi D
> ; Kandpal, Suraj
> Subject: [PATCH v6 3/9] drm/i915: Adding the new registers for DSC
>
>
> -Original Message-
> From: Kandpal, Suraj
> Sent: Wednesday, January 11, 2023 11:09 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Nautiyal, Ankit K ; Kulkarni, Vandita
> ; Navare, Manasi D
> ; Kandpal, Suraj
> Subject: [PATCH v6 4/9] drm/i915: Enable YCbCr420 for VDSC
>
>
== Series Details ==
Series: series starting with [1/2] drm: Add SDP Error Detection Configuration
Register
URL : https://patchwork.freedesktop.org/series/112774/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
On 1/12/2023 8:37 PM, Dixit, Ashutosh wrote:
On Thu, 12 Jan 2023 20:26:34 -0800, Belgaumkar, Vinay wrote:
I think the ABI was changed by the patch mentioned in the commit
(a8a4f0467d70).
The ABI was originally changed in 80cf8af17af04 and 56a709cf77468.
Yes, you are right. @Andi, did we
Enable SDP error detection configuration, this will set CRC16 in
128b/132b link layer.
For DISPLAY13 a hardware bit31 in register VIDEO_DIP_CTL is added to
enable/disable SDP CRC applicable for DP2.0 only, but the default value
of this bit will enable CRC16 in 128b/132b hence skipping this write.
DP2.0 E11 defines a new register to facilitate SDP error detection by a
128B/132B capable DPRX device.
Signed-off-by: Arun R Murthy
---
include/drm/display/drm_dp.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
index
Hello Jani and Matt,
> -Original Message-
> From: Roper, Matthew D
> Sent: Thursday, January 12, 2023 11:03 PM
> To: Jani Nikula
> Cc: Borah, Chaitanya Kumar ; intel-
> g...@lists.freedesktop.org; Shankar, Uma ; Syrjala,
> Ville ; Srivatsa, Anusha
> ; Atwood, Matthew S
>
> Subject: Re:
On Thu, 12 Jan 2023 20:26:34 -0800, Belgaumkar, Vinay wrote:
>
> I think the ABI was changed by the patch mentioned in the commit
> (a8a4f0467d70).
The ABI was originally changed in 80cf8af17af04 and 56a709cf77468.
On 1/12/2023 7:15 PM, Dixit, Ashutosh wrote:
On Thu, 12 Jan 2023 18:27:52 -0800, Vinay Belgaumkar wrote:
Reading current root sysfs entries gives a min/max of all
GTs. Updating this so we return default (GT0) values when root
level sysfs entries are accessed, instead of min/max for the card.
== Series Details ==
Series: drm/i915/mtl: Connect root sysfs entries to GT0
URL : https://patchwork.freedesktop.org/series/112767/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12578 -> Patchwork_112767v1
Summary
---
On Thu, 12 Jan 2023 18:27:52 -0800, Vinay Belgaumkar wrote:
>
> Reading current root sysfs entries gives a min/max of all
> GTs. Updating this so we return default (GT0) values when root
> level sysfs entries are accessed, instead of min/max for the card.
> Tests that are not multi GT capable will
== Series Details ==
Series: drm/i915/gt: Move LSC_CHICKEN_BIT* workarounds to correct function
URL : https://patchwork.freedesktop.org/series/112764/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12578 -> Patchwork_112764v1
== Series Details ==
Series: drm/i915/pxp: Add missing cleanup steps for PXP global-teardown
URL : https://patchwork.freedesktop.org/series/112763/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12578 -> Patchwork_112763v1
Reading current root sysfs entries gives a min/max of all
GTs. Updating this so we return default (GT0) values when root
level sysfs entries are accessed, instead of min/max for the card.
Tests that are not multi GT capable will read incorrect sysfs
values without this change on multi-GT platforms
patch link:
https://lore.kernel.org/r/20230112203844.41179-1-mjrosato%40linux.ibm.com
patch subject: [Intel-gfx] [PATCH v2] vfio: fix potential deadlock on vfio
group lock
config: arc-randconfig-r043-20230112
compiler: arc-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget
https
== Series Details ==
Series: drm/i915/pxp: Add missing cleanup steps for PXP global-teardown
URL : https://patchwork.freedesktop.org/series/112763/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On Thu, Jan 12, 2023, Alex Williamson wrote:
> On Thu, 12 Jan 2023 23:29:53 +
> Sean Christopherson wrote:
>
> > On Thu, Jan 12, 2023, Matthew Rosato wrote:
> > > On 1/12/23 4:05 PM, Alex Williamson wrote:
> > > > On Thu, 12 Jan 2023 15:38:44 -0500
> > > > Matthew Rosato wrote:
> > > >>
== Series Details ==
Series: Add module oriented dmesg output (rev5)
URL : https://patchwork.freedesktop.org/series/111050/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12578 -> Patchwork_111050v5
Summary
---
== Series Details ==
Series: Add module oriented dmesg output (rev5)
URL : https://patchwork.freedesktop.org/series/111050/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
That register doesn't belong to a specific engine, so the proper
placement for workarounds programming it should be
general_render_compute_wa_init().
Signed-off-by: Gustavo Sousa
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 65 -
1 file changed, 36 insertions(+), 29
A driver bug was recently discovered where the security firmware was
receiving internal HW signals indicating that session key expirations
had occurred. Architecturally, the firmware was expecting a response
from the GuC to acknowledge the event with the firmware side.
However the OS was in a
From: Alexander Usyskin
Client on bus have only one vtag map slot and should disregard the vtag
value when cleaning pending read flag.
Fixes read flow control message unexpectedly generated when
clent on bus send messages with different vtags.
Signed-off-by: Alexander Usyskin
Signed-off-by:
A gap was recently discovered where if an application did not
invalidate all of the stream keys (intentionally or not), and the
driver did a full PXP global teardown on the GT subsystem, we
find that future session creation would fail on the security
firmware's side of the equation. i915 is the
During suspend flow, i915 currently achors' on the pm_suspend_prepare
callback as the location where we quiesce the entire GPU and perform
all necessary cleanup in order to go into suspend. PXP is also called
during this time to perform the arbitration session teardown (with
the assurance no
From: Alexander Usyskin
Add device link with i915 as consumer and mei_pxp as supplier
to ensure proper ordering of power flows.
V2: condition on absence of heci_pxp to filter out DG
Signed-off-by: Alexander Usyskin
Signed-off-by: Alan Previn
---
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 7
A customer issue was recently discovered and in the process a
gap in i915's PXP interaction with HW+FW architecure was also
realized. This series adds those missing pieces.
This fix includes changes where i915 calls into the mei
component interface in order to submit requests to the security
From: Alexander Usyskin
Asynchronous runtime resume is not possible while the system
is suspending.
The power management subsystem resumes the device only in the
suspend phase, not in the prepare phase.
Force resume device in prepare to allow drivers on mei bus
to communicate in their prepare
On Thu, 12 Jan 2023 23:29:53 +
Sean Christopherson wrote:
> On Thu, Jan 12, 2023, Matthew Rosato wrote:
> > On 1/12/23 4:05 PM, Alex Williamson wrote:
> > > On Thu, 12 Jan 2023 15:38:44 -0500
> > > Matthew Rosato wrote:
> > >> @@ -344,6 +345,35 @@ static bool
On 1/11/2023 14:56, Jason Ekstrand wrote:
On Wed, Jan 11, 2023 at 4:32 PM Matthew Brost
wrote:
On Wed, Jan 11, 2023 at 04:18:01PM -0600, Jason Ekstrand wrote:
> On Wed, Jan 11, 2023 at 2:50 AM Tvrtko Ursulin <
> tvrtko.ursu...@linux.intel.com> wrote:
>
> >
[snip]
>
Thanks for reviewing. Will fix all and re-rev.
On Thu, 2023-01-12 at 09:28 -0800, Ceraolo Spurio, Daniele wrote:
>
> On 1/11/2023 4:37 PM, Alan Previn wrote:
> > During suspend flow, i915 currently achors' on the
> > pm_suspend_prepare
> > callback as the location where we quiesce the entire GPU
On Thu, Jan 12, 2023, Matthew Rosato wrote:
> On 1/12/23 4:05 PM, Alex Williamson wrote:
> > On Thu, 12 Jan 2023 15:38:44 -0500
> > Matthew Rosato wrote:
> >> @@ -344,6 +345,35 @@ static bool vfio_assert_device_open(struct
> >> vfio_device *device)
> >>return
== Series Details ==
Series: drm: Optimize drm buddy top-down allocation method
URL : https://patchwork.freedesktop.org/series/112733/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12576_full -> Patchwork_112733v1_full
;
| ^~~
Caused by commit
07a2975c65f2 ("drm/vc4: bo: Fix drmm_mutex_init memory hog")
I have used the drm-misc-fixes tree from next-20230112 for today.
--
Cheers,
Stephen Rothwell
pgpm5mUQ2c9YI.pgp
Description: OpenPGP digital signature
On 1/12/23 4:05 PM, Alex Williamson wrote:
> On Thu, 12 Jan 2023 15:38:44 -0500
> Matthew Rosato wrote:
>
>> Currently it is possible that the final put of a KVM reference comes from
>> vfio during its device close operation. This occurs while the vfio group
>> lock is held; however, if the
== Series Details ==
Series: vfio: fix potential deadlock on vfio group lock
URL : https://patchwork.freedesktop.org/series/112759/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12578 -> Patchwork_112759v1
Summary
---
On Thu, Jan 05, 2023 at 01:35:52PM +, Tvrtko Ursulin wrote:
Okay to sum it up below with some final notes..
On 04/01/2023 19:34, Matt Roper wrote:
On Wed, Jan 04, 2023 at 09:58:13AM +, Tvrtko Ursulin wrote:
On 23/12/2022 18:28, Lucas De Marchi wrote:
On Fri, Dec 23, 2022 at
== Series Details ==
Series: drm: Generic fbdev and vga-switcheroo
URL : https://patchwork.freedesktop.org/series/112754/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12578 -> Patchwork_112754v1
Summary
---
On Thu, 12 Jan 2023 15:38:44 -0500
Matthew Rosato wrote:
> Currently it is possible that the final put of a KVM reference comes from
> vfio during its device close operation. This occurs while the vfio group
> lock is held; however, if the vfio device is still in the kvm device list,
> then the
On 1/12/2023 02:15, Tvrtko Ursulin wrote:
On 12/01/2023 02:53, john.c.harri...@intel.com wrote:
From: John Harrison
Engine resets are supposed to never fail. But in the case when one
does (due to unknown reasons that normally come down to a missing
w/a), it is useful to get as much
== Series Details ==
Series: drm: Generic fbdev and vga-switcheroo
URL : https://patchwork.freedesktop.org/series/112754/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On 1/12/2023 02:06, Tvrtko Ursulin wrote:
On 12/01/2023 02:53, john.c.harri...@intel.com wrote:
From: John Harrison
A hang situation has been observed where the only requests on the
context were either completed or not yet started according to the
breaadcrumbs. However, the register state
On 1/12/2023 02:01, Tvrtko Ursulin wrote:
On 12/01/2023 02:53, john.c.harri...@intel.com wrote:
From: John Harrison
There was a report of error captures occurring without any hung
context being indicated despite the capture being initiated by a 'hung
context notification' from GuC. The
Currently it is possible that the final put of a KVM reference comes from
vfio during its device close operation. This occurs while the vfio group
lock is held; however, if the vfio device is still in the kvm device list,
then the following call chain could result in a deadlock:
kvm_put_kvm
->
Set the framebuffer info for drivers that support VGA switcheroo. Only
affects the amdgpu and nouveau drivers, which use VGA switcheroo and
generic fbdev emulation. For other drivers, this does nothing.
This fixes a potential regression in the console code. Both, amdgpu and
nouveau, invoked
Always allow switching away via vga-switcheroo if the display is
uninitalized. Instead prevent switching to i915 if the device has
not been initialized.
This issue was introduced by commit 5df7bd130818 ("drm/i915: skip
display initialization when there is no display") protected, which
protects
Several lastclose helpers call vga_switcheroo_process_delayed_switch().
It's better to call the helper from drm_lastclose() after the kernel
client's screen has been restored. This way, all drivers can benefit
without having to implement their own lastclose helper. For drivers
without
(was: drm/fb-helper: Set framebuffer for vga-switcheroo clients)
This patch has now turned into a little series. The first two patches
are bug fixes for the existing code. The third patch cleans up the
drivers.
Patch 1 fixes i915 to do the correct thing if the device has not been
initialized
== Series Details ==
Series: drm/i915/display: Fix typo for reference clock
URL : https://patchwork.freedesktop.org/series/112729/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12575_full -> Patchwork_112729v1_full
Summary
== Series Details ==
Series: kvm/vfio: fix potential deadlock on vfio group lock (rev4)
URL : https://patchwork.freedesktop.org/series/112568/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/112568/revisions/4/mbox/ not
applied
Applying: KVM:
The following changes since commit a1ad1d5b50626f2d126adf1964ce0e98cbb8b39d:
amdgpu: add VCN4.0.4 firmware from amd-5.4 (2023-01-10 10:08:40 -0500)
are available in the Git repository at:
git://anongit.freedesktop.org/drm/drm-firmware dmc-adlp_2.18-mtl_2.11
for you to fetch changes up to
== Series Details ==
Series: Add new CDCLK step for RPL-U (rev4)
URL : https://patchwork.freedesktop.org/series/111472/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12575_full -> Patchwork_111472v4_full
Summary
---
On 11/01/2023 19:40, Matthew Brost wrote:
On Wed, Jan 11, 2023 at 08:50:37AM +, Tvrtko Ursulin wrote:
[snip]
This example is where it would hurt on large systems. Imagine only an even
wider media transcode card...
Second example is only a single engine class used (3d desktop?) but
On Thu, Jan 12, 2023 at 05:21:45PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> We don't have proper sub-pixel coordinate support (some platforms
> simply can't do it, for others we've not implemented it). This
> can cause us to treat a < 1 pixel source width/height as zero
> which is
On Mon, Dec 26, 2022 at 10:53:24PM -0700, Drew Davenport wrote:
> The error message suggests that the height of the src rect must be at
> least 1. Reject source with height of 0.
>
> Signed-off-by: Drew Davenport
>
> ---
> I was investigating some divide-by-zero crash reports on ChromeOS which
On 11/01/2023 17:52, Matthew Brost wrote:
On Wed, Jan 11, 2023 at 09:09:45AM +, Tvrtko Ursulin wrote:
[snip]
Anyway, since you are not buying any arguments on paper perhaps you are more
open towards testing. If you would adapt gem_wsim for Xe you would be able
to spawn N simulated
== Series Details ==
Series: DRM scheduling cgroup controller (rev3)
URL : https://patchwork.freedesktop.org/series/109902/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12577 -> Patchwork_109902v3
Summary
---
From: Tvrtko Ursulin
Use the same default for stdout and JSON output modes as it is for
interactive.
Previously added command line switch can be used to go back to showing all
physical engines.
Signed-off-by: Tvrtko Ursulin
Cc: Dmitry Rogozhkin
---
tools/intel_gpu_top.c | 3 ++-
1 file
From: Tvrtko Ursulin
Default mode is to aggreate engines per class but some users would prefer
to be able to start in physical engine mode too.
Signed-off-by: Tvrtko Ursulin
Cc: Dmitry Rogozhkin
---
man/intel_gpu_top.rst | 3 +++
tools/intel_gpu_top.c | 9 +++--
2 files changed, 10
From: Tvrtko Ursulin
Parsers need the whole output enclosed into square brackets so every
period sample becomes an array element.
So far we have been suggesting this in the man page but we can trivially
make the tool output that itself.
Signed-off-by: Tvrtko Ursulin
Cc: Eero Tamminen
---
From: Tvrtko Ursulin
New lines are not respected when rst2man generates the page so try to work
around that by followin advice from the Internet.
Signed-off-by: Tvrtko Ursulin
---
man/intel_gpu_top.rst | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git
From: Tvrtko Ursulin
Mostly by popular demand from
https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/109, although for
some of these changes I'd like some second opinions. For instance is it user
friendly to change the default aggregation mode for stdout and JSON output?
Tvrtko Ursulin
On Thu, Jan 12, 2023 at 09:40:42AM -0800, Matt Roper wrote:
> On Thu, Jan 12, 2023 at 03:11:31PM +0530, Chaitanya Kumar Borah wrote:
> > Fix typo for reference clock from 24400 to 24000
> >
> > Signed-off-by: Chaitanya Kumar Borah
>
> Fixes: 626426ff9ce4 ("drm/i915/adl_p: Add cdclk support for
On Thu, Jan 12, 2023 at 03:11:31PM +0530, Chaitanya Kumar Borah wrote:
> Fix typo for reference clock from 24400 to 24000
>
> Signed-off-by: Chaitanya Kumar Borah
Fixes: 626426ff9ce4 ("drm/i915/adl_p: Add cdclk support for ADL-P")
Reviewed-by: Matt Roper
> ---
>
== Series Details ==
Series: DRM scheduling cgroup controller (rev3)
URL : https://patchwork.freedesktop.org/series/109902/
State : warning
== Summary ==
Error: dim checkpatch failed
d566e8fb02ed drm: Track clients by tgid and not tid
365d4dcce2b7 drm: Update file owner during use
On Thu, Jan 12, 2023 at 01:03:44PM +0200, Jani Nikula wrote:
> On Thu, 12 Jan 2023, Chaitanya Kumar Borah
> wrote:
> > Add a new sub platform INTEL_SUBPLATFORM_480CDCLK to identify
> > device ids that need the 480MHz CDCLK step. Separate out RPLU
> > device ids and add them to both RPL and
On 1/11/2023 4:37 PM, Alan Previn wrote:
During suspend flow, i915 currently achors' on the pm_suspend_prepare
callback as the location where we quiesce the entire GPU and perform
all necessary cleanup in order to go into suspend. PXP is also called
during this time to perform the arbitration
On Thu, Jan 12, 2023 at 12:21:17PM -0500, Matthew Rosato wrote:
> So should I work up a v2 that does symbol gets for kvm_get_kvm_safe
> and kvm_put_kvm from vfio_main and drop kvm_put_kvm_async? Or is
> the patch Yi is working on changing things such that will also
> address the deadlock issue?
On 1/12/23 7:45 AM, Jason Gunthorpe wrote:
> On Wed, Jan 11, 2023 at 08:53:34PM +, Sean Christopherson wrote:
>> On Wed, Jan 11, 2023, Jason Gunthorpe wrote:
>>> On Wed, Jan 11, 2023 at 07:54:51PM +, Sean Christopherson wrote:
>>>
Something feels off. If KVM's refcount is 0, then
On Thu, Jan 12, 2023 at 10:54:25AM +0100, Lucas De Marchi wrote:
> On Thu, Jan 05, 2023 at 09:27:57PM +, Matthew Brost wrote:
> > On Tue, Jan 03, 2023 at 12:21:08PM +, Tvrtko Ursulin wrote:
> > >
> > > On 22/12/2022 22:21, Matthew Brost wrote:
> > > > Hello,
> > > >
> > > > This is a
From: Tvrtko Ursulin
When notified by the drm core we are over our allotted time budget, i915
instance will check if any of the GPU engines it is reponsible for is
fully saturated. If it is, and the client in question is using that
engine, it will throttle it.
For now throttling is done
From: Tvrtko Ursulin
Implement the drm_cgroup_ops->active_time_us callback.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_driver.c | 10
drivers/gpu/drm/i915/i915_drm_client.c | 76 ++
drivers/gpu/drm/i915/i915_drm_client.h | 2 +
3 files
From: Tvrtko Ursulin
Similar to CPU scheduling, implement a concept of weight in the drm cgroup
controller.
Uses the same range and default as the CPU controller - CGROUP_WEIGHT_MIN,
CGROUP_WEIGHT_DFL and CGROUP_WEIGHT_MAX.
Later each cgroup is assigned a time budget proportionaly based on the
From: Tvrtko Ursulin
We need the ability for DRM core to inform the cgroup controller when a
client has closed a DRM file descriptor. This will allow us not needing
to keep state relating to GPU time usage by tasks sets in the cgroup
controller itself.
Signed-off-by: Tvrtko Ursulin
---
From: Tvrtko Ursulin
To reduce the number of tracking going on, especially with drivers which
will not support any sort of control from the drm cgroup controller side,
lets express the funcionality as opt-in and use the presence of
drm_cgroup_ops as activation criteria.
Signed-off-by: Tvrtko
From: Tvrtko Ursulin
Add a driver callback and core helper which allow querying the time spent
on GPUs for processes belonging to a group.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/drm_cgroup.c | 24
include/drm/drm_clients.h| 2 ++
include/drm/drm_drv.h
From: Tvrtko Ursulin
Add a new callback via which the drm cgroup controller is notifying the
drm core that a certain process is above its allotted GPU time.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/drm_cgroup.c | 21 +
include/drm/drm_clients.h| 1 +
From: Tvrtko Ursulin
Entry points from the cgroup subsystem into the drm cgroup controller will
need to walk the file_priv structures associated with registered clients
and since those are not RCU protected lets add a hack for now to make this
safe.
Signed-off-by: Tvrtko Ursulin
---
From: Tvrtko Ursulin
To enable propagation of settings from the cgroup drm controller to drm we
need to start tracking which processes own which drm clients.
Implement that by tracking the struct pid pointer of the owning process in
a new XArray, pointing to a structure containing a list of
From: Tvrtko Ursulin
Skeleton controller without any functionality.
Signed-off-by: Tvrtko Ursulin
---
include/linux/cgroup_drm.h| 9 ++
include/linux/cgroup_subsys.h | 4 +++
init/Kconfig | 7 +
kernel/cgroup/Makefile| 1 +
kernel/cgroup/drm.c
From: Tvrtko Ursulin
With the typical model where the display server opends the file descriptor
and then hands it over to the client we were showing stale data in
debugfs.
Fix it by updating the drm_file->pid on ioctl access from a different
process.
The field is also made RCU protected to
From: Tvrtko Ursulin
Thread group id (aka pid from userspace point of view) is a more
interesting thing to show as an owner of a DRM fd, so track and show that
instead of the thread id.
In the next patch we will make the owner updated post file descriptor
handover, which will also be tgid based
From: Tvrtko Ursulin
This series contains a proposal for a DRM scheduling cgroup controller which
implements a weight based hierarchical GPU usage budget based controller
similar in concept to some of the existing controllers.
Motivation mostly comes from my earlier proposal where I identified
== Series Details ==
Series: drm/i915: Reject < 1x1 pixel plane source size
URL : https://patchwork.freedesktop.org/series/112743/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12577 -> Patchwork_112743v1
Summary
---
On Thu, 12 Jan 2023 16:38:18 +0100
Daniel Vetter wrote:
> > >
> > > Also if you do the allocation in ->prepare_job with dma_fence and not
> > > run_job, then I think can sort out fairness issues (if they do pop up) in
> > > the drm/sched code instead of having to think about this in each driver.
Am 11.01.23 um 16:18 schrieb Matthew Auld:
[SNIP]
Currently "dim rebuild-tip" doesn't work for me because of a conflict in
i915_gem_execbuffer.c
Seems to be working now.
Nope. When I do a fresh install with "drm setup" in a different working
directly I run into exactly this problem again.
Hi Jocelyn,
On Thu, Jan 12, 2023 at 11:08:17AM +0100, Jocelyn Falempe wrote:
> This patch does also solve a kernel crash when reading
> /sys/class/drm/card1/gt/gt0/* on a skylake machine:
> https://bugzilla.redhat.com/show_bug.cgi?id=2154880
Interesting, I wonder what aspect of this patch fixes
On Thu, 12 Jan 2023 at 13:08, Boris Brezillon
wrote:
> On Thu, 12 Jan 2023 11:42:57 +0100
> Daniel Vetter wrote:
>
> > On Thu, Jan 12, 2023 at 11:25:53AM +0100, Boris Brezillon wrote:
> > > On Thu, 12 Jan 2023 11:11:03 +0100
> > > Boris Brezillon wrote:
> > >
> > > > On Thu, 12 Jan 2023
1 - 100 of 148 matches
Mail list logo
