[Intel-gfx] ✓ Fi.CI.IGT: success for Drop TGL/DG1 workarounds for pre-prod steppings

== Series Details == Series: Drop TGL/DG1 workarounds for pre-prod steppings URL : https://patchwork.freedesktop.org/series/113453/ State : success == Summary == CI Bug Log - changes from CI_DRM_12658_full -> Patchwork_113453v1_full

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

On 1/27/23 11:00 AM, Andi Shyti wrote: Hi Gwan-gyeong, thanks for the review and the thorough explanation. On Fri, Jan 27, 2023 at 08:50:26AM +0200, Gwan-gyeong Mun wrote: On 1/11/23 5:36 PM, Andi Shyti wrote: On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: On Wed, 11 Jan

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix missing ecodes

On 1/26/2023 11:17, Teres Alexis, Alan Previn wrote: Firstly, thanks for catching this miss. Since I only have one trivial nit and one non-blocker ask. and the non-blocker ask will not impact the patch intent as it merely tweaks an existing debug message, I believe we have an rb: Reviewed-by:

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915/guc: Add GuC oriented print macros

On 1/24/2023 09:05, Michal Wajdeczko wrote: While we do have GT oriented print macros, add few more GuC specific to have common look and feel across all messages related to the GuC and to avoid chasing the gt pointer. We will use these macros shortly in upcoming patches. Signed-off-by: Michal

Re: [Intel-gfx] [PATCH v2 8/8] drm/i915/guc: Update GT/GuC messages in intel_uc.c

On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: pass gt to print_fw_ver Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 80 +-- 1 file changed, 39

Re: [Intel-gfx] [PATCH v2 7/8] drm/i915/guc: Update GuC messages in intel_guc_submission.c

On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: improve few existing messages Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 61

Re: [Intel-gfx] [PATCH v2 6/8] drm/i915/guc: Update GuC messages in intel_guc_log.c

On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: drop redundant GuC strings, minor improvements Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 37 -- 1 file

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/guc: Update GuC messages in intel_guc_ct.c

On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: drop unused helpers Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 23 --- 1

Re: [Intel-gfx] [PATCH v2 2/8] drm/i915/guc: Update GuC messages in intel_guc.c

On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: drop now redundant "GuC" word from the message Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 31

Re: [Intel-gfx] [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control

On Thu, Jan 12, 2023 at 04:56:07PM +, Tvrtko Ursulin wrote: ... > + /* > + * 1st pass - reset working values and update hierarchical weights and > + * GPU utilisation. > + */ > + if (!__start_scanning(root, period_us)) > + goto out_retry; /* > +

Re: [Intel-gfx] [PATCH v3 5/8] drm/i915/pxp: Add ARB session creation with new PXP API Ver4.3

With the acceptance of the explicit-px-fw-cmd-termination series upstream (https://patchwork.freedesktop.org/series/113307/), this patch #5 of this series will need a rerev with the addition of MTL's version of the explicit termination as well. ...alan On Wed, 2023-01-25 at 00:06 -0800, Teres

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: vblank stuff (rev2)

== Series Details == Series: drm/i915: vblank stuff (rev2) URL : https://patchwork.freedesktop.org/series/112170/ State : success == Summary == CI Bug Log - changes from CI_DRM_12656_full -> Patchwork_112170v2_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for Drop TGL/DG1 workarounds for pre-prod steppings

== Series Details == Series: Drop TGL/DG1 workarounds for pre-prod steppings URL : https://patchwork.freedesktop.org/series/113453/ State : success == Summary == CI Bug Log - changes from CI_DRM_12658 -> Patchwork_113453v1 Summary ---

[Intel-gfx] [PATCH 1/3] drm/i915/tgl: Drop support for pre-production steppings

Several post-TGL platforms have been brought up now, so we're well past the point where we usually drop the workarounds that are only applicable to internal/pre-production hardware. Production TGL hardware always has display stepping C0 or later and GT stepping B0 or later (this is true for both

[Intel-gfx] [PATCH 0/3] Drop TGL/DG1 workarounds for pre-prod steppings

As described in the comment on intel_detect_preproduction_hw(), Our policy for removing pre-production workarounds is to keep the current gen workarounds as a guide to the bring-up of the next gen (workarounds have a habit of persisting!). Anything older than that should be removed

[Intel-gfx] [PATCH 3/3] drm/i915/dg1: Drop final use of IS_DG1_GRAPHICS_STEP

All production DG1 hardware has graphics stepping B0; there is no such thing as C0. As such, we can simplify IS_DG1_GRAPHICS_STEP(uncore->i915, STEP_A0, STEP_C0) to just match DG1 in general. Bspec: 44463 Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2

[Intel-gfx] [PATCH 2/3] drm/i915/dg1: Drop support for pre-production steppings

Several post-DG1 platforms have been brought up now, so we're well past the point where we usually drop the workarounds that are only applicable to internal/pre-production hardware. Production DG1 hardware always has a B0 stepping for both display and GT. Bspec: 44463 Signed-off-by: Matt Roper

Re: [Intel-gfx] [PATCH v4] drm/i915: implement async_flip mode per plane tracking

On Fri, Jan 27, 2023 at 04:30:02PM +0100, Andrzej Hajda wrote: > Current implementation of async flip w/a relies on assumption that > previous atomic commit contains valid information if async_flip is still > enabled on the plane. It is incorrect. If previous commit did not modify > the plane its

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix potential bit_17 double-free

== Series Details == Series: drm/i915: Fix potential bit_17 double-free URL : https://patchwork.freedesktop.org/series/113447/ State : success == Summary == CI Bug Log - changes from CI_DRM_12656 -> Patchwork_113447v1 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: probe lmem before the stolen portion

== Series Details == Series: drm/i915: probe lmem before the stolen portion URL : https://patchwork.freedesktop.org/series/113435/ State : success == Summary == CI Bug Log - changes from CI_DRM_12655_full -> Patchwork_113435v1_full Summary

Re: [Intel-gfx] [PATCH v7 3/6] mei: clean pending read with vtag on bus

On Fri, Jan 27, 2023 at 10:09:31AM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 25, 2023 at 12:28:29PM -0500, Rodrigo Vivi wrote: > > > > Greg, ack on getting these 3 mei patches merged through intel-gfx? > > I only see 2 mei patches in this series, what am I missing? right... 2 mei patches

[Intel-gfx] [PATCH] drm/i915: Fix potential bit_17 double-free

From: Rob Clark A userspace with multiple threads racing I915_GEM_SET_TILING to set the tiling to I915_TILING_NONE could trigger a double free of the bit_17 bitmask. (Or conversely leak memory on the transition to tiled.) Move allocation/free'ing of the bitmask within the section protected by

Re: [Intel-gfx] [PATCH 5/9] drm/display/dp_mst: Fix the payload VCPI check in drm_dp_mst_dump_topology()

On Fri, Jan 27, 2023 at 09:42:39PM +0200, Ville Syrjälä wrote: > On Wed, Jan 25, 2023 at 01:48:48PM +0200, Imre Deak wrote: > > Fix an off-by-one error in the VCPI check in drm_dp_mst_dump_topology(). > > > > Cc: Lyude Paul > > Cc: dri-de...@lists.freedesktop.org > > Signed-off-by: Imre Deak >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: vblank stuff (rev2)

== Series Details == Series: drm/i915: vblank stuff (rev2) URL : https://patchwork.freedesktop.org/series/112170/ State : success == Summary == CI Bug Log - changes from CI_DRM_12656 -> Patchwork_112170v2 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 5/9] drm/display/dp_mst: Fix the payload VCPI check in drm_dp_mst_dump_topology()

On Wed, Jan 25, 2023 at 01:48:48PM +0200, Imre Deak wrote: > Fix an off-by-one error in the VCPI check in drm_dp_mst_dump_topology(). > > Cc: Lyude Paul > Cc: dri-de...@lists.freedesktop.org > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +- > 1 file

Re: [Intel-gfx] [PATCH] drm/i915/psr: Split sel fetch plane configuration into arm and noarm

On Fri, 2023-01-27 at 11:33 -0800, Lucas De Marchi wrote: > On Fri, Jan 27, 2023 at 07:12:29PM +0200, Luca Coelho wrote: > > On Fri, 2023-01-27 at 16:37 +0200, Jani Nikula wrote: > > > On Fri, 27 Jan 2023, Tvrtko Ursulin > > > wrote: > > > > On 26/01/2023 16:05, Jani Nikula wrote: > > > > > On

Re: [Intel-gfx] [PATCH] drm/i915/psr: Split sel fetch plane configuration into arm and noarm

On Fri, Jan 27, 2023 at 07:12:29PM +0200, Luca Coelho wrote: On Fri, 2023-01-27 at 16:37 +0200, Jani Nikula wrote: On Fri, 27 Jan 2023, Tvrtko Ursulin wrote: > On 26/01/2023 16:05, Jani Nikula wrote: > > On Thu, 26 Jan 2023, Luca Coelho wrote: > > > On Thu, 2023-01-26 at 14:11 +0200, Luca

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: implement async_flip mode per plane tracking (rev5)

== Series Details == Series: drm/i915: implement async_flip mode per plane tracking (rev5) URL : https://patchwork.freedesktop.org/series/108371/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12655_full -> Patchwork_108371v5_full

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Use unversioned blob path for ADLP DMC (rev2)

== Series Details == Series: Use unversioned blob path for ADLP DMC (rev2) URL : https://patchwork.freedesktop.org/series/113238/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/113238/revisions/2/mbox/ not applied Applying: drm/i915/dmc: Prepare

Re: [Intel-gfx] [PATCH v7 3/6] mei: clean pending read with vtag on bus

Hi Greg, appreciate your time on this, Patch #2 adds a device link between i915 and mei (at bind time) specifically for the PXP interface that is subject to the issue being fixed. Change is on i915 but implication is mei suspend-resume aligfnent with i915. Rodrigo has already reviewed it but

Re: [Intel-gfx] [RFC 1/2] drm/i915: Add RPL-U sub platform

On Fri, Jan 27, 2023 at 01:34:31AM -0800, Borah, Chaitanya Kumar wrote: > Hello Jani and Matt, > > > -Original Message- > > From: Jani Nikula > > Sent: Tuesday, January 24, 2023 8:02 PM > > To: Borah, Chaitanya Kumar ; intel- > > g...@lists.freedesktop.org > > Cc: Shankar, Uma ; Syrjala,

Re: [Intel-gfx] [PATCH v3 01/10] drm/client: Test for connectors before sending hotplug event

On Wednesday, January 25th, 2023 at 21:04, Thomas Zimmermann wrote: > Not having connectors indicates a driver bug. Is it? What if all connectors are of the DP-MST type, ie. they are created on-the-fly?

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: probe lmem before the stolen portion

== Series Details == Series: drm/i915: probe lmem before the stolen portion URL : https://patchwork.freedesktop.org/series/113435/ State : success == Summary == CI Bug Log - changes from CI_DRM_12655 -> Patchwork_113435v1 Summary ---

Re: [Intel-gfx] [PATCH v3 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup

On Fri, Jan 27, 2023 at 03:21:30PM +0100, Thomas Zimmermann wrote: > Hi > > Am 25.01.23 um 22:03 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Wed, Jan 25, 2023 at 09:04:09PM +0100, Thomas Zimmermann wrote: > > > Initialize the fb-helper structure immediately after its allocation > > > in

Re: [Intel-gfx] [PATCH v3 01/10] drm/client: Test for connectors before sending hotplug event

On Fri, Jan 27, 2023 at 03:13:50PM +0100, Thomas Zimmermann wrote: > Hi > > Am 25.01.23 um 21:52 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Wed, Jan 25, 2023 at 09:04:06PM +0100, Thomas Zimmermann wrote: > > > Test for connectors in the client code and remove a similar test > > > from the

[Intel-gfx] [PATCH v2 4/4] drm/i915: Reject wm levels that exceed vblank time

From: Ville Syrjälä The pipe needs a certain amount of time during vblank to prefill sufficiently. If the vblank is too short the relevant watermark level must be disabled. Start implementing the necessary calculations to check this. Scaler and DSC prefill are left out for now as handling those

[Intel-gfx] [PATCH v2 3/4] drm/i915: Extract skl_wm_latency()

From: Ville Syrjälä Extract the skl+ wm latency determination into a small helper so that everyone has the same idea what the latency should be. This introduces a slight functional change in that skl_cursor_allocation() will now start to account for the extra 4 usec that the kbk/cfl/cml IPC w/a

[Intel-gfx] [PATCH v2 2/4] drm/i915/psr: Fix the delayed vblank w/a

From: Ville Syrjälä Fix the code to correctly determine whether delayed vblank is used or not. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_psr.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c

[Intel-gfx] [PATCH v2 1/4] drm/i915/vrr: Fix "window2" handling

From: Ville Syrjälä The "window2" delay is just the difference of vactive (undelayed vblank) vs. vblank_start (delayed vblank). Just use vblank_start during the VRR calculations so that things work correctly regardless of whether delayed vblank is used or not. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff

From: Ville Syrjälä A bunch of stuff related to vblank length/start. v2: Fix inactive pipe handling Fix SAGV handling Fix some typos Ville Syrjälä (4): drm/i915/vrr: Fix "window2" handling drm/i915/psr: Fix the delayed vblank w/a drm/i915: Extract skl_wm_latency() drm/i915:

Re: [Intel-gfx] [PATCH i-g-t 1/6] intel_gpu_top: Fix man page formatting

Hi Tvrtko, On 2023-01-27 at 11:12:36 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > New lines are not respected when rst2man generates the page so try to work > around that by followin advice from the Internet. > > v2: > * Improve some wording. > * Tidy -o option description. > *

Re: [Intel-gfx] [PATCH] drm/i915/psr: Split sel fetch plane configuration into arm and noarm

On Fri, 2023-01-27 at 16:37 +0200, Jani Nikula wrote: > On Fri, 27 Jan 2023, Tvrtko Ursulin wrote: > > On 26/01/2023 16:05, Jani Nikula wrote: > > > On Thu, 26 Jan 2023, Luca Coelho wrote: > > > > On Thu, 2023-01-26 at 14:11 +0200, Luca Coelho wrote: > > > > > On Thu, 2023-01-26 at 14:00 +0200,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: implement async_flip mode per plane tracking (rev5)

== Series Details == Series: drm/i915: implement async_flip mode per plane tracking (rev5) URL : https://patchwork.freedesktop.org/series/108371/ State : success == Summary == CI Bug Log - changes from CI_DRM_12655 -> Patchwork_108371v5

Re: [Intel-gfx] [PATCH i-g-t 6/6] lib/igt_device_scan: Improve Intel discrete GPU selection

Hi Tvrtko, On 2023-01-27 at 11:12:41 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Now that DRM subsystem can contain PCI cards with the vendor set to Intel > but they are not Intel GPUs, we need a better selection logic than looking > at the vendor. Use the driver name instead. > >

Re: [Intel-gfx] [PATCH i-g-t 5/6] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU

Hi Tvrtko, On 2023-01-27 at 11:12:40 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Avoid trying to dereference null engines on exit when there are either > none which are supported, or kernel does not have i915 PMU support. > > Also fix a memory leak on the same failure path just so

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement async_flip mode per plane tracking (rev5)

== Series Details == Series: drm/i915: implement async_flip mode per plane tracking (rev5) URL : https://patchwork.freedesktop.org/series/108371/ State : warning == Summary == Error: dim checkpatch failed 39da81540542 drm/i915: implement async_flip mode per plane tracking -:14:

[Intel-gfx] [PATCH] drm/i915: probe lmem before the stolen portion

At the very least, we have some tests that force the BAR size for testing purposes, which would result in different BAR size with stolen-lmem vs normal lmem, since the BAR is only resized as part of the normal lmem probing. Signed-off-by: Matthew Auld Cc: Andrzej Hajda Cc: Nirmoy Das ---

[Intel-gfx] [PATCH v4] drm/i915: implement async_flip mode per plane tracking

Current implementation of async flip w/a relies on assumption that previous atomic commit contains valid information if async_flip is still enabled on the plane. It is incorrect. If previous commit did not modify the plane its state->uapi.async_flip can be false. As a result DMAR/PIPE errors can

Re: [Intel-gfx] [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control

On 27/01/2023 14:11, Michal Koutný wrote: On Fri, Jan 27, 2023 at 01:31:54PM +, Tvrtko Ursulin wrote: I think you missed the finish_suspend_scanning() part: if (root_drmcs.suspended_period_us) cancel_delayed_work_sync(_drmcs.scan_work); So if scanning was in

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Add selftests for TLB invalidation (rev5)

== Series Details == Series: drm/i915/gt: Add selftests for TLB invalidation (rev5) URL : https://patchwork.freedesktop.org/series/112894/ State : success == Summary == CI Bug Log - changes from CI_DRM_12654_full -> Patchwork_112894v5_full

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Split sel fetch plane configuration into arm and noarm

On Fri, 2023-01-27 at 14:00 +, Souza, Jose wrote: > On Fri, 2023-01-27 at 10:27 +0200, Jouni Högander wrote: > > SEL_FETCH_CTL registers are armed immediately when plane is > > disabled. > > SEL_FETCH_* instances of plane configuration are used when doing > > selective update and normal plane

Re: [Intel-gfx] [PATCH] drm/i915/psr: Split sel fetch plane configuration into arm and noarm

On Fri, 27 Jan 2023, Tvrtko Ursulin wrote: > On 26/01/2023 16:05, Jani Nikula wrote: >> On Thu, 26 Jan 2023, Luca Coelho wrote: >>> On Thu, 2023-01-26 at 14:11 +0200, Luca Coelho wrote: On Thu, 2023-01-26 at 14:00 +0200, Jani Nikula wrote: > On Thu, 26 Jan 2023, Luca Coelho wrote:

Re: [Intel-gfx] [PATCH v3] drm/i915: implement async_flip mode per plane tracking

On Fri, Jan 27, 2023 at 08:34:03AM +0100, Andrzej Hajda wrote: > Current implementation of async flip w/a relies on assumption that > previous atomic commit contains valid information if async_flip is still > enabled on the plane. It is incorrect. If previous commit did not modify > the plane its

Re: [Intel-gfx] [PATCH v3 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup

Hi Am 25.01.23 um 22:03 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 25, 2023 at 09:04:09PM +0100, Thomas Zimmermann wrote: Initialize the fb-helper structure immediately after its allocation in drm_fbdev_generic_setup(). That will make it easier to fill it with driver-specific values, such

Re: [Intel-gfx] [PATCH v3 02/10] drm/client: Add hotplug_failed flag

Hi Am 25.01.23 um 21:57 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 25, 2023 at 09:04:07PM +0100, Thomas Zimmermann wrote: Signal failed hotplugging with a flag in struct drm_client_dev. If set, the client helpers will not further try to set up the fbdev display. This used to be signalled

Re: [Intel-gfx] [PATCH v3 01/10] drm/client: Test for connectors before sending hotplug event

Hi Am 25.01.23 um 21:52 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 25, 2023 at 09:04:06PM +0100, Thomas Zimmermann wrote: Test for connectors in the client code and remove a similar test from the generic fbdev emulation. Do nothing if the test fails. Not having connectors indicates a driver

Re: [Intel-gfx] [PATCH] drm/i915/psr: Split sel fetch plane configuration into arm and noarm

On 26/01/2023 16:05, Jani Nikula wrote: On Thu, 26 Jan 2023, Luca Coelho wrote: On Thu, 2023-01-26 at 14:11 +0200, Luca Coelho wrote: On Thu, 2023-01-26 at 14:00 +0200, Jani Nikula wrote: On Thu, 26 Jan 2023, Luca Coelho wrote: On Wed, 2023-01-25 at 12:44 +0200, Jouni Högander wrote:

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Split sel fetch plane configuration into arm and noarm

On Fri, 2023-01-27 at 10:27 +0200, Jouni Högander wrote: > SEL_FETCH_CTL registers are armed immediately when plane is disabled. > SEL_FETCH_* instances of plane configuration are used when doing > selective update and normal plane register instances for full updates. > Currently all SEL_FETCH_*

Re: [Intel-gfx] [PATCH] drm/i915: Avoid potential vm use-after-free

On 27/01/2023 13:10, Matthew Auld wrote: On Mon, 23 Jan 2023 at 16:57, Tvrtko Ursulin wrote: + some more people based on e1a7ab4fca0c On 19/01/2023 17:32, Rob Clark wrote: From: Rob Clark Adding the vm to the vm_xa table makes it visible to userspace, which could try to race with us to

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 6/6] lib/igt_device_scan: Improve Intel discrete GPU selection

On Fri, Jan 27, 2023 at 11:53:38AM +, Tvrtko Ursulin wrote: > > On 27/01/2023 11:39, Petri Latvala wrote: > > On Fri, Jan 27, 2023 at 11:12:41AM +, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Now that DRM subsystem can contain PCI cards with the vendor set to Intel > >

Re: [Intel-gfx] [PATCH v8 5/6] drm/i915/mtl: Add function to send command to GSC CS

On Tue, 2023-01-24 at 15:12 +0530, Kandpal, Suraj wrote: > Add function that takes care of sending command to gsc cs. We start > of with allocation of memory for our command intel_hdcp_gsc_message that > contains gsc cs memory header as directed in specs followed by the > actual payload hdcp

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 0/8] Vendor agnostic gputop

On 26/01/2023 17:02, Kamil Konieczny wrote: Hi, please rebase and resend, also please change commit subject to start with lib: or lib/[name of lib changed]: rest od commit description Series should still apply as is so I don't think there is need to re-send. It will only conflict if I get

Re: [Intel-gfx] [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control

On 27/01/2023 13:01, Michal Koutný wrote: On Thu, Jan 12, 2023 at 04:56:07PM +, Tvrtko Ursulin wrote: +static int drmcs_can_attach(struct cgroup_taskset *tset) +{ + int ret; + + /* +* As processes are getting moved between groups we need to ensure +* both

Re: [Intel-gfx] [PATCH] drm/i915: Avoid potential vm use-after-free

On Mon, 23 Jan 2023 at 16:57, Tvrtko Ursulin wrote: > > > + some more people based on e1a7ab4fca0c > > On 19/01/2023 17:32, Rob Clark wrote: > > From: Rob Clark > > > > Adding the vm to the vm_xa table makes it visible to userspace, which > > could try to race with us to close the vm. So we

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Add selftests for TLB invalidation (rev5)

== Series Details == Series: drm/i915/gt: Add selftests for TLB invalidation (rev5) URL : https://patchwork.freedesktop.org/series/112894/ State : success == Summary == CI Bug Log - changes from CI_DRM_12654 -> Patchwork_112894v5 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Add selftests for TLB invalidation (rev5)

== Series Details == Series: drm/i915/gt: Add selftests for TLB invalidation (rev5) URL : https://patchwork.freedesktop.org/series/112894/ State : warning == Summary == Error: dim checkpatch failed 9ba7aae4 drm/i915/gt: Add selftests for TLB invalidation Traceback (most recent call last):

[Intel-gfx] [PATCH v4] drm/i915/gt: Add selftests for TLB invalidation

From: Chris Wilson Check that we invalidate the TLB cache, the updated physical addresses are immediately visible to the HW, and there is no retention of the old physical address for concurrent HW access. Signed-off-by: Chris Wilson [ahajda: adjust to upstream driver, v2+] Signed-off-by:

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 6/6] lib/igt_device_scan: Improve Intel discrete GPU selection

On 27/01/2023 11:39, Petri Latvala wrote: On Fri, Jan 27, 2023 at 11:12:41AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Now that DRM subsystem can contain PCI cards with the vendor set to Intel but they are not Intel GPUs, we need a better selection logic than looking at the vendor.

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 6/6] lib/igt_device_scan: Improve Intel discrete GPU selection

On Fri, Jan 27, 2023 at 11:12:41AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Now that DRM subsystem can contain PCI cards with the vendor set to Intel > but they are not Intel GPUs, we need a better selection logic than looking > at the vendor. Use the driver name instead. > >

Re: [Intel-gfx] [RFC v3 00/12] DRM scheduling cgroup controller

On 27/01/2023 10:04, Michal Koutný wrote: On Thu, Jan 26, 2023 at 05:57:24PM +, Tvrtko Ursulin wrote: So even if the RFC shows just a simple i915 implementation, the controller itself shouldn't prevent a smarter approach (via exposed ABI). scan/query + over budget notification is IMO

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Split sel fetch plane configuration into arm and noarm (rev2)

== Series Details == Series: drm/i915/psr: Split sel fetch plane configuration into arm and noarm (rev2) URL : https://patchwork.freedesktop.org/series/113321/ State : success == Summary == CI Bug Log - changes from CI_DRM_12652_full -> Patchwork_113321v2_full

[Intel-gfx] [PATCH i-g-t 6/6] lib/igt_device_scan: Improve Intel discrete GPU selection

From: Tvrtko Ursulin Now that DRM subsystem can contain PCI cards with the vendor set to Intel but they are not Intel GPUs, we need a better selection logic than looking at the vendor. Use the driver name instead. Caveat that the driver key was on a blacklist so far, and although I can't

[Intel-gfx] [PATCH i-g-t 5/6] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU

From: Tvrtko Ursulin Avoid trying to dereference null engines on exit when there are either none which are supported, or kernel does not have i915 PMU support. Also fix a memory leak on the same failure path just so Valgrind runs are quite. v2: * Fix a memory leak in the same failure mode

[Intel-gfx] [PATCH i-g-t 2/6] intel_gpu_top: Automatically enclose JSON output into brackets

From: Tvrtko Ursulin Parsers need the whole output enclosed into square brackets so every period sample becomes an array element. So far we have been suggesting this in the man page but we can trivially make the tool output that itself. Signed-off-by: Tvrtko Ursulin Cc: Eero Tamminen

[Intel-gfx] [PATCH i-g-t 4/6] intel_gpu_top: Aggregate engine classes in all output modes

From: Tvrtko Ursulin Use the same default for stdout and JSON output modes as it is for interactive. Previously added command line switch can be used to go back to showing all physical engines. Signed-off-by: Tvrtko Ursulin Cc: Dmitry Rogozhkin Reviewed-by: Kamil Konieczny ---

[Intel-gfx] [PATCH i-g-t 3/6] intel_gpu_top: Add command line switch to start in physical engine mode

From: Tvrtko Ursulin Default mode is to aggreate engines per class but some users would prefer to be able to start in physical engine mode too. Signed-off-by: Tvrtko Ursulin Cc: Dmitry Rogozhkin Reviewed-by: Kamil Konieczny --- man/intel_gpu_top.rst | 3 +++ tools/intel_gpu_top.c | 9

[Intel-gfx] [PATCH i-g-t 1/6] intel_gpu_top: Fix man page formatting

From: Tvrtko Ursulin New lines are not respected when rst2man generates the page so try to work around that by followin advice from the Internet. v2: * Improve some wording. * Tidy -o option description. * Update dates. * Convert the filter list to table. Signed-off-by: Tvrtko Ursulin

[Intel-gfx] [PATCH i-g-t 0/6] Assorted intel_gpu_top improvements

From: Tvrtko Ursulin Mostly by popular demand from https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/109, although for some of these changes I'd like some second opinions. For instance is it user friendly to change the default aggregation mode for stdout and JSON output? Plus a GPU

[Intel-gfx] [PULL] drm-intel-next

Hi Dave & Daniel - drm-intel-next-2023-01-27: drm/i915 feature pull #2 v6.3: Features and functionality: - Enable HF-EEODB by switching HDMI, DP and LVDS to use struct drm_edid (Jani) - Start using unversioned DMC firmware paths for new platforms (Gustavo) Refactoring and cleanups: - ELD

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Add selftests for TLB invalidation (rev4)

On 26.01.2023 18:42, Patchwork wrote: *Patch Details* *Series:* drm/i915/gt: Add selftests for TLB invalidation (rev4) *URL:* https://patchwork.freedesktop.org/series/112894/ *State:*success *Details:*

[Intel-gfx] [PATCH i-g-t] i915/gem_ppgtt: Terminate batch for evict-vs-shrink*

From: Chris Wilson Terminate the first upload batch (with MI_BB_END) as otherwise we trigger a sequence of $(nproc) GPU hangs, which take a long time to be processed. References: https://gitlab.freedesktop.org/drm/intel/-/issues/7961 Fixes: 4f22b49ee353 ("tests/i915/gem_ppgtt: verify GTT

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: implement async_flip mode per plane tracking (rev4)

== Series Details == Series: drm/i915: implement async_flip mode per plane tracking (rev4) URL : https://patchwork.freedesktop.org/series/108371/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12651_full -> Patchwork_108371v4_full

Re: [Intel-gfx] [RFC 1/2] drm/i915: Add RPL-U sub platform

Hello Jani and Matt, > -Original Message- > From: Jani Nikula > Sent: Tuesday, January 24, 2023 8:02 PM > To: Borah, Chaitanya Kumar ; intel- > g...@lists.freedesktop.org > Cc: Shankar, Uma ; Syrjala, Ville > ; Srivatsa, Anusha ; > Roper, Matthew D ; Atwood, Matthew S > ; Borah,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Split sel fetch plane configuration into arm and noarm (rev2)

== Series Details == Series: drm/i915/psr: Split sel fetch plane configuration into arm and noarm (rev2) URL : https://patchwork.freedesktop.org/series/113321/ State : success == Summary == CI Bug Log - changes from CI_DRM_12652 -> Patchwork_113321v2

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Split sel fetch plane configuration into arm and noarm

On Fri, 2023-01-27 at 10:27 +0200, Jouni Högander wrote: > SEL_FETCH_CTL registers are armed immediately when plane is disabled. > SEL_FETCH_* instances of plane configuration are used when doing > selective update and normal plane register instances for full updates. > Currently all SEL_FETCH_*

Re: [Intel-gfx] [PATCH v7 3/6] mei: clean pending read with vtag on bus

On Wed, Jan 25, 2023 at 12:28:29PM -0500, Rodrigo Vivi wrote: > > Greg, ack on getting these 3 mei patches merged through intel-gfx? I only see 2 mei patches in this series, what am I missing? thanks, greg k-h

Re: [Intel-gfx] [PATCH v7 1/6] mei: mei-me: resume device in prepare

On Wed, Jan 25, 2023 at 12:26:32AM -0800, Alan Previn wrote: > From: Alexander Usyskin > > Asynchronous runtime resume is not possible while the system > is suspending. > The power management subsystem resumes the device only in the > suspend phase, not in the prepare phase. > Force resume

Re: [Intel-gfx] [PATCH v7 3/6] mei: clean pending read with vtag on bus

On Wed, Jan 25, 2023 at 12:26:34AM -0800, Alan Previn wrote: > From: Alexander Usyskin > > Client on bus have only one vtag map slot and should disregard the vtag > value when cleaning pending read flag. > Fixes read flow control message unexpectedly generated when > clent on bus send messages

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

Hi Gwan-gyeong, thanks for the review and the thorough explanation. On Fri, Jan 27, 2023 at 08:50:26AM +0200, Gwan-gyeong Mun wrote: > > > On 1/11/23 5:36 PM, Andi Shyti wrote: > > On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: > > > On Wed, 11 Jan 2023, Andi Shyti wrote: > > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Split sel fetch plane configuration into arm and noarm (rev2)

== Series Details == Series: drm/i915/psr: Split sel fetch plane configuration into arm and noarm (rev2) URL : https://patchwork.freedesktop.org/series/113321/ State : warning == Summary == Error: dim checkpatch failed df442db34504 drm/i915/psr: Split sel fetch plane configuration into arm

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Split sel fetch plane configuration into arm and noarm

Hi Jouni, On Fri, 2023-01-27 at 10:27 +0200, Jouni Högander wrote: > SEL_FETCH_CTL registers are armed immediately when plane is disabled. > SEL_FETCH_* instances of plane configuration are used when doing > selective update and normal plane register instances for full updates. > Currently all

Re: [Intel-gfx] [PATCH] drm/i915/psr: Split sel fetch plane configuration into arm and noarm

On Thu, 2023-01-26 at 13:01 +, Govindapillai, Vinod wrote: > On Wed, 2023-01-25 at 12:44 +0200, Jouni Högander wrote: > > SEL_FETCH_CTL registers are armed immediately when plane is > > disabled. > > SEL_FETCH_* instances of plane configuration are used when doing > > selective update and

Re: [Intel-gfx] [PATCH] drm/i915/psr: Split sel fetch plane configuration into arm and noarm

On Thu, 2023-01-26 at 13:29 +0200, Luca Coelho wrote: > On Wed, 2023-01-25 at 12:44 +0200, Jouni Högander wrote: > > > SEL_FETCH_CTL registers are armed immediately when plane is > > > disabled. > > > SEL_FETCH_* instances of plane configuration are used when doing > > > selective update and

[Intel-gfx] [PATCH v2] drm/i915/psr: Split sel fetch plane configuration into arm and noarm

SEL_FETCH_CTL registers are armed immediately when plane is disabled. SEL_FETCH_* instances of plane configuration are used when doing selective update and normal plane register instances for full updates. Currently all SEL_FETCH_* registers are written as a part of noarm plane configuration. If

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: implement async_flip mode per plane tracking (rev4)

== Series Details == Series: drm/i915: implement async_flip mode per plane tracking (rev4) URL : https://patchwork.freedesktop.org/series/108371/ State : success == Summary == CI Bug Log - changes from CI_DRM_12651 -> Patchwork_108371v4