[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/mtl: Update cache coherency setting for context structure

2023-07-06 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Update cache coherency setting for context structure URL : https://patchwork.freedesktop.org/series/120315/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13351_full -> Patchwork_120315v1_full

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for PCI/VGA: Improve the default VGA device selection

2023-07-06 Thread Sui JIngfeng
Hi, This patch set could only be applied if a prerequisite patch[1] set applied [1] https://patchwork.freedesktop.org/series/120053/ Sorry, its my bad, I will respin my patch. On 2023/7/7 03:34, Patchwork wrote: == Series Details == Series: PCI/VGA: Improve the default VGA device

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: update request engine before removing virtual GuC engine (rev2)

2023-07-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: update request engine before removing virtual GuC engine (rev2) URL : https://patchwork.freedesktop.org/series/120238/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13351_full -> Patchwork_120238v2_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Convert to use time_before macro

2023-07-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Convert to use time_before macro URL : https://patchwork.freedesktop.org/series/120297/ State : success == Summary == CI Bug Log - changes from CI_DRM_13351_full -> Patchwork_120297v1_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: Use local64_try_cmpxchg in i915_pmu_event_read

2023-07-06 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Use local64_try_cmpxchg in i915_pmu_event_read URL : https://patchwork.freedesktop.org/series/120296/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13351_full -> Patchwork_120296v1_full

Re: [Intel-gfx] [PATCH v2] drm/i915: Refactor PAT/cache handling

2023-07-06 Thread Yang, Fei
> @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct > drm_i915_gem_object *obj) > if (IS_DGFX(i915)) > return false; > - /* > -* For objects created by userspace through GEM_CREATE with > pat_index > -* set

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Update cache coherency setting for context structure

2023-07-06 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Update cache coherency setting for context structure URL : https://patchwork.freedesktop.org/series/120315/ State : success == Summary == CI Bug Log - changes from CI_DRM_13351 -> Patchwork_120315v1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: update request engine before removing virtual GuC engine (rev2)

2023-07-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: update request engine before removing virtual GuC engine (rev2) URL : https://patchwork.freedesktop.org/series/120238/ State : success == Summary == CI Bug Log - changes from CI_DRM_13351 -> Patchwork_120238v2

[Intel-gfx] ✗ Fi.CI.IGT: failure for Covert to use time_before macro

2023-07-06 Thread Patchwork
== Series Details == Series: Covert to use time_before macro URL : https://patchwork.freedesktop.org/series/120295/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13349_full -> Patchwork_120295v1_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: update request engine before removing virtual GuC engine (rev2)

2023-07-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: update request engine before removing virtual GuC engine (rev2) URL : https://patchwork.freedesktop.org/series/120238/ State : warning == Summary == Error: dim checkpatch failed 35bc390bc9f2 drm/i915/gt: update request engine before removing virtual

[Intel-gfx] ✗ Fi.CI.BUILD: failure for PCI/VGA: Improve the default VGA device selection

2023-07-06 Thread Patchwork
== Series Details == Series: PCI/VGA: Improve the default VGA device selection URL : https://patchwork.freedesktop.org/series/120294/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/120294/revisions/1/mbox/ not applied Applying: video/aperture:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Convert to use time_before macro

2023-07-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Convert to use time_before macro URL : https://patchwork.freedesktop.org/series/120297/ State : success == Summary == CI Bug Log - changes from CI_DRM_13351 -> Patchwork_120297v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for PCI/VGA: Improve the default VGA device selection

2023-07-06 Thread Patchwork
== Series Details == Series: PCI/VGA: Improve the default VGA device selection URL : https://patchwork.freedesktop.org/series/120293/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/120293/revisions/1/mbox/ not applied Applying: video/aperture:

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Update cache coherency setting for context structure

2023-07-06 Thread Yang, Fei
> As context structure is shared memory for CPU/GPU, Wa_22016122933 is > needed for this memory block as well. > > Signed-off-by: Zhanjun Dong > CC: Fei Yang Reviewed-by: Fei Yang > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Use local64_try_cmpxchg in i915_pmu_event_read

2023-07-06 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Use local64_try_cmpxchg in i915_pmu_event_read URL : https://patchwork.freedesktop.org/series/120296/ State : success == Summary == CI Bug Log - changes from CI_DRM_13351 -> Patchwork_120296v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pmu: Use local64_try_cmpxchg in i915_pmu_event_read

2023-07-06 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Use local64_try_cmpxchg in i915_pmu_event_read URL : https://patchwork.freedesktop.org/series/120296/ State : warning == Summary == Error: dim checkpatch failed f8d5cc6a6ba8 drm/i915/pmu: Use local64_try_cmpxchg in i915_pmu_event_read -:7:

[Intel-gfx] ✗ Fi.CI.BUILD: failure for use refcount+RCU method to implement lockless slab shrink (rev2)

2023-07-06 Thread Patchwork
== Series Details == Series: use refcount+RCU method to implement lockless slab shrink (rev2) URL : https://patchwork.freedesktop.org/series/119926/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/119926/revisions/2/mbox/ not applied Applying: mm:

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-06 Thread Ville Syrjälä
On Thu, Jul 06, 2023 at 01:32:17PM +0300, Lisovskiy, Stanislav wrote: > On Thu, Jul 06, 2023 at 11:47:26AM +0300, Imre Deak wrote: > > On Thu, Jul 06, 2023 at 11:24:21AM +0300, Lisovskiy, Stanislav wrote: > > > On Wed, Jul 05, 2023 at 06:32:51PM +0300, Imre Deak wrote: > > > > On Thu, May 25, 2023

[Intel-gfx] [PATCH] drm/i915/mtl: Update cache coherency setting for context structure

2023-07-06 Thread Zhanjun Dong
As context structure is shared memory for CPU/GPU, Wa_22016122933 is needed for this memory block as well. Signed-off-by: Zhanjun Dong CC: Fei Yang --- drivers/gpu/drm/i915/gt/intel_lrc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [v2] drm/i915/mtl: s/MTL/METEORLAKE for platform/subplatform defines

2023-07-06 Thread Srivatsa, Anusha
> -Original Message- > From: Bhadane, Dnyaneshwar > Sent: Friday, June 30, 2023 4:40 AM > To: intel-gfx@lists.freedesktop.org > Cc: Ursulin, Tvrtko ; jani.nik...@linux.intel.com; > Srivatsa, Anusha ; Bhadane, Dnyaneshwar > > Subject: [v2] drm/i915/mtl: s/MTL/METEORLAKE for

Re: [Intel-gfx] [PATCH v2] drm/i915: Refactor PAT/cache handling

2023-07-06 Thread Tvrtko Ursulin
On 05/07/2023 01:09, Yang, Fei wrote: >>> From: Tvrtko Ursulin >>> >>> Informal commit message for now. >>> >>> I got a bit impatient and curious to see if the idea we discussed would >>> work so sketched something out. I think it is what I was describing back >>> then.. >>> >>> So

[Intel-gfx] [PATCH v2] drm/i915/gt: update request engine before removing virtual GuC engine

2023-07-06 Thread Andrzej Hajda
GuC virtual engines can be removed before request removal. On the other side driver expects rq->engine to be a valid pointer for a whole life of request. Setting rq->engine to an always valid engine should solve the issue. The patch fixes bug detected by KASAN with following signature: i915

[Intel-gfx] ✓ Fi.CI.BAT: success for Covert to use time_before macro

2023-07-06 Thread Patchwork
== Series Details == Series: Covert to use time_before macro URL : https://patchwork.freedesktop.org/series/120295/ State : success == Summary == CI Bug Log - changes from CI_DRM_13349 -> Patchwork_120295v1 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.BUILD: failure for nightly.conf: drop sound tree from drm-tip altogether

2023-07-06 Thread Patchwork
== Series Details == Series: nightly.conf: drop sound tree from drm-tip altogether URL : https://patchwork.freedesktop.org/series/120278/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/120278/revisions/1/mbox/ not applied Applying: nightly.conf:

Re: [Intel-gfx] [drm-rerere] nightly.conf: drop sound tree from drm-tip altogether

2023-07-06 Thread Alex Deucher
On Thu, Jul 6, 2023 at 5:29 AM Jani Nikula wrote: > > We used to have the sound branches be part of drm-tip to help > development of DP and HDMI audio. However, we always used to run into > problems with the sound branches merging Linus' master at non-tagged > random commits, wreaking havoc

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more

2023-07-06 Thread Tvrtko Ursulin
On 06/07/2023 13:06, Jani Nikula wrote: On Thu, 06 Jul 2023, Tvrtko Ursulin wrote: On 04/07/2023 10:48, Jani Nikula wrote: While the default for the mmio_debug parameter depends on CONFIG_DRM_I915_DEBUG_MMIO, we look it up and include all the code for unclaimed reg debugging even when

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Do not use stolen on MTL

2023-07-06 Thread Tvrtko Ursulin
On 06/07/2023 14:35, Nirmoy Das wrote: On 7/6/2023 3:32 PM, Tvrtko Ursulin wrote: On 30/06/2023 18:01, Nirmoy Das wrote: Use smem on MTL due to a HW bug in MTL that prevents reading from stolen memory using LMEM BAR. Does anything remain in stolen or could the memory region just not be

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Do not use stolen on MTL

2023-07-06 Thread Nirmoy Das
On 7/6/2023 3:32 PM, Tvrtko Ursulin wrote: On 30/06/2023 18:01, Nirmoy Das wrote: Use smem on MTL due to a HW bug in MTL that prevents reading from stolen memory using LMEM BAR. Does anything remain in stolen or could the memory region just not be created? GSC requires DSM which can't

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Do not use stolen on MTL

2023-07-06 Thread Tvrtko Ursulin
On 30/06/2023 18:01, Nirmoy Das wrote: Use smem on MTL due to a HW bug in MTL that prevents reading from stolen memory using LMEM BAR. Does anything remain in stolen or could the memory region just not be created? Regards, Tvrtko Cc: Oak Zeng Cc: Jani Nikula Cc: Joonas Lahtinen Cc:

[Intel-gfx] [PATCH v2 1/6] video/aperture: Add a helper to detect if an aperture contains firmware FB

2023-07-06 Thread Sui Jingfeng
From: Sui Jingfeng This patch adds the aperture_contain_firmware_fb() function to do the determination. Unfortunately due to the fact that apertures list will be freed dynamically, the location and size information of the firmware fb will be lost after dedicated drivers call

[Intel-gfx] [PATCH v1 4/4] drm/radeon: Implement the is_boot_device callback function

2023-07-06 Thread Sui Jingfeng
From: Sui Jingfeng [why] The vga_is_firmware_default() defined in drivers/pci/vgaarb.c is arch-dependent, it's a dummy on non-x86 architectures currently. This made VGAARB lost an important condition for the arbitration. It could still be wrong even if we remove the #ifdef and #endif guards.

[Intel-gfx] [PATCH v2] drm/i915/gt: Convert to use time_before macro

2023-07-06 Thread Zehao Zhang
Use time_before macro instead of open it for readability. Signed-off-by: Zehao Zhang --- v2: -update subject drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c

Re: [Intel-gfx] [PATCH v2 00/24] use vmalloc_array and vcalloc

2023-07-06 Thread Martin K. Petersen
Julia, > The functions vmalloc_array and vcalloc were introduced in > > commit a8749a35c399 ("mm: vmalloc: introduce array allocation functions") > > but are not used much yet. This series introduces uses of > these functions, to protect against multiplication overflows. Applied #7 and #24 to

Re: [Intel-gfx] [PATCH 24/29] mm: vmscan: make global slab shrink lockless

2023-07-06 Thread Paul E. McKenney
On Fri, Jun 23, 2023 at 04:29:39PM +1000, Dave Chinner wrote: > On Thu, Jun 22, 2023 at 05:12:02PM +0200, Vlastimil Babka wrote: > > On 6/22/23 10:53, Qi Zheng wrote: > > > @@ -1067,33 +1068,27 @@ static unsigned long shrink_slab(gfp_t gfp_mask, > > > int nid, > > > if (!mem_cgroup_disabled()

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Use local64_try_cmpxchg in i915_pmu_event_read

2023-07-06 Thread Uros Bizjak
On Tue, Jul 4, 2023 at 9:28 AM Jani Nikula wrote: > > On Mon, 03 Jul 2023, Uros Bizjak wrote: > > Use local64_try_cmpxchg instead of local64_cmpxchg (*ptr, old, new) == old > > in i915_pmu_event_read. x86 CMPXCHG instruction returns success in ZF flag, > > so this change saves a compare after

[Intel-gfx] [PATCH v2 6/6] drm/ast: Register as a vga client to vgaarb by calling vga_client_register()

2023-07-06 Thread Sui Jingfeng
From: Sui Jingfeng Becasuse the VGA Display Controller in the ASpeed BMC chip is also a PCIe device, the Software Programming guide of AST2400 say that it is Fully IBM VGA compliant, thus, it should also particiate in the arbitration. Cc: Thomas Zimmermann Cc: Jocelyn Falempe Cc: David Airlie

[Intel-gfx] [PATCH v1 2/4] PCI/VGA: Improve the default VGA device selection

2023-07-06 Thread Sui Jingfeng
From: Sui Jingfeng Currently, the default VGA device selection is not perfect. Potential problems are: 1) This function is a no-op on non-x86 architectures. 2) It does not take the PCI Bar may get relocated into consideration. 3) It is not effective for the PCI device without a dedicated VRAM

[Intel-gfx] [PATCH] drm/i915/pmu: Use local64_try_cmpxchg in i915_pmu_event_read

2023-07-06 Thread Uros Bizjak
Use local64_try_cmpxchg instead of local64_cmpxchg (*ptr, old, new) == old in i915_pmu_event_read. x86 CMPXCHG instruction returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg). Also, try_cmpxchg implicitly assigns old *ptr

Re: [Intel-gfx] [PATCH 24/29] mm: vmscan: make global slab shrink lockless

2023-07-06 Thread Qi Zheng
On 2023/7/4 11:45, Qi Zheng wrote: On 2023/7/4 00:39, Paul E. McKenney wrote: On Fri, Jun 23, 2023 at 04:29:39PM +1000, Dave Chinner wrote: On Thu, Jun 22, 2023 at 05:12:02PM +0200, Vlastimil Babka wrote: On 6/22/23 10:53, Qi Zheng wrote: @@ -1067,33 +1068,27 @@ static unsigned long

Re: [Intel-gfx] [PATCH 24/29] mm: vmscan: make global slab shrink lockless

2023-07-06 Thread Qi Zheng
On 2023/7/4 00:39, Paul E. McKenney wrote: On Fri, Jun 23, 2023 at 04:29:39PM +1000, Dave Chinner wrote: On Thu, Jun 22, 2023 at 05:12:02PM +0200, Vlastimil Babka wrote: On 6/22/23 10:53, Qi Zheng wrote: @@ -1067,33 +1068,27 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,

Re: [Intel-gfx] [PATCH 24/29] mm: vmscan: make global slab shrink lockless

2023-07-06 Thread Qi Zheng
Hi Dave, On 2023/6/24 19:08, Qi Zheng wrote: Hi Dave, On 2023/6/24 06:19, Dave Chinner wrote: On Fri, Jun 23, 2023 at 09:10:57PM +0800, Qi Zheng wrote: On 2023/6/23 14:29, Dave Chinner wrote: On Thu, Jun 22, 2023 at 05:12:02PM +0200, Vlastimil Babka wrote: On 6/22/23 10:53, Qi Zheng wrote:

[Intel-gfx] [PATCH v2 4/6] drm/radeon: Implement the is_boot_device callback function

2023-07-06 Thread Sui Jingfeng
From: Sui Jingfeng [why] The vga_is_firmware_default() defined in drivers/pci/vgaarb.c is arch-dependent, it's a dummy on non-x86 architectures currently. This made VGAARB lost an important condition for the arbitration. It could still be wrong even if we remove the #ifdef and #endif guards.

[Intel-gfx] [PATCH v2 2/6] PCI/VGA: Improve the default VGA device selection

2023-07-06 Thread Sui Jingfeng
From: Sui Jingfeng Currently, the default VGA device selection is not perfect. Potential problems are: 1) This function is a no-op on non-x86 architectures. 2) It does not take the PCI Bar may get relocated into consideration. 3) It is not effective for the PCI device without a dedicated VRAM

[Intel-gfx] [PATCH v2 3/6] drm/amdgpu: Implement the is_boot_device callback function

2023-07-06 Thread Sui Jingfeng
From: Sui Jingfeng [why] The vga_is_firmware_default() defined in drivers/pci/vgaarb.c is arch-dependent, it's a dummy on non-x86 architectures currently. This made VGAARB lost an important condition for the arbitration. It could still be wrong even if we remove the #ifdef and #endif guards.

[Intel-gfx] [PATCH v1 3/4] drm/amdgpu: Implement the is_boot_device callback function

2023-07-06 Thread Sui Jingfeng
From: Sui Jingfeng [why] The vga_is_firmware_default() defined in drivers/pci/vgaarb.c is arch-dependent, it's a dummy on non-x86 architectures currently. This made VGAARB lost an important condition for the arbitration. It could still be wrong even if we remove the #ifdef and #endif guards.

[Intel-gfx] [PATCH v1 1/4] video/aperture: Add a helper to detect if an aperture contains firmware FB

2023-07-06 Thread Sui Jingfeng
From: Sui Jingfeng This patch adds the aperture_contain_firmware_fb() function to do the determination. Unfortunately due to the fact that apertures list will be freed dynamically, the location and size information of the firmware fb will be lost after dedicated drivers call

Re: [Intel-gfx] [PATCH] Covert to use time_before macro

2023-07-06 Thread Zehao Zhang
Correct the format of the Subject in v2: https://lore.kernel.org/all/20230706072924.2562-1-zhangze...@vivo.com/

[Intel-gfx] [PATCH v2 0/6] PCI/VGA: Improve the default VGA device selection

2023-07-06 Thread Sui Jingfeng
From: Sui Jingfeng Currently, the default VGA device selection is not perfect. Potential problems are: 1) This function is a no-op on non-x86 architectures. 2) It does not take the PCI Bar may get relocated into consideration. 3) It is not effective for the PCI device without a dedicated VRAM

[Intel-gfx] [PATCH] Covert to use time_before macro

2023-07-06 Thread Zehao Zhang
Use time_before macro instead of open it for readability. Signed-off-by: Zehao Zhang --- drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c

[Intel-gfx] [PATCH v2 5/6] drm/i915: Implement the is_boot_device callback function

2023-07-06 Thread Sui Jingfeng
From: Sui Jingfeng This patch add a function to identify if a device is the default boot selected by the firmware, it require the GPU has firmware framebuffer driver support (such as efifb). If a specific hardware doesn't have firmware framebuffer support, then the introduced function will just

[Intel-gfx] [PATCH v1 0/4] PCI/VGA: Improve the default VGA device selection

2023-07-06 Thread Sui Jingfeng
From: Sui Jingfeng Currently, the default VGA device selection is not perfect. Potential problems are: 1) This function is a no-op on non-x86 architectures. 2) It does not take the PCI Bar may get relocated into consideration. 3) It is not effective for the PCI device without a dedicated VRAM

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Use local64_try_cmpxchg in i915_pmu_event_read

2023-07-06 Thread Uros Bizjak
On Tue, Jul 4, 2023 at 10:37 AM Jani Nikula wrote: > > On Tue, 04 Jul 2023, Uros Bizjak wrote: > > On Tue, Jul 4, 2023 at 9:28 AM Jani Nikula > > wrote: > >> You could save everyone a lot of time by actually documenting what these > >> functions do. Assume you don't know what

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more

2023-07-06 Thread Jani Nikula
On Thu, 06 Jul 2023, Tvrtko Ursulin wrote: > On 04/07/2023 10:48, Jani Nikula wrote: >> While the default for the mmio_debug parameter depends on >> CONFIG_DRM_I915_DEBUG_MMIO, we look it up and include all the code for >> unclaimed reg debugging even when CONFIG_DRM_I915_DEBUG_MMIO=n. Fix it. >>

[Intel-gfx] [PULL] drm-misc-next-fixes

2023-07-06 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the weekly PR for drm-misc-next-fixes. Best regards Thomas drm-misc-next-fixes-2023-07-06: Short summary of fixes pull: * panel: Fix mode on Starry-ili9882t The following changes since commit 861c249cd782cb9f2d5a881bbb32e8da7f0c1192: arch/sparc: Add module

Re: [Intel-gfx] [PATCH] drm/i915: Remove some dead "code"

2023-07-06 Thread Tvrtko Ursulin
On 05/07/2023 13:08, Jani Nikula wrote: On Wed, 05 Jul 2023, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit 2caffbf11762 ("drm/i915: Revoke mmaps and prevent access to fence registers across reset") removed the temporary implementation of a reset under stop machine but forgot to remove

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more

2023-07-06 Thread Tvrtko Ursulin
On 04/07/2023 10:48, Jani Nikula wrote: While the default for the mmio_debug parameter depends on CONFIG_DRM_I915_DEBUG_MMIO, we look it up and include all the code for unclaimed reg debugging even when CONFIG_DRM_I915_DEBUG_MMIO=n. Fix it. Cc: Lee Shawn C Signed-off-by: Jani Nikula ---

Re: [Intel-gfx] [PATCH 2/3] drm/i915/uncore: fix race around i915->params.mmio_debug

2023-07-06 Thread Tvrtko Ursulin
On 04/07/2023 10:48, Jani Nikula wrote: Only check the conditions for unclaimed reg debug once to avoid locking problems when i915->params.mmio_debug changes between header and footer. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8749 Cc: Lee Shawn C Signed-off-by: Jani Nikula

Re: [Intel-gfx] [PATCH 1/3] drm/i915/uncore: split unclaimed_reg_debug() to header and footer

2023-07-06 Thread Tvrtko Ursulin
On 04/07/2023 10:48, Jani Nikula wrote: Make it easier to have different logic for the two for follow-up. Cc: Lee Shawn C Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_uncore.c | 37 + 1 file changed, 22 insertions(+), 15 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-06 Thread Lisovskiy, Stanislav
On Thu, Jul 06, 2023 at 11:47:26AM +0300, Imre Deak wrote: > On Thu, Jul 06, 2023 at 11:24:21AM +0300, Lisovskiy, Stanislav wrote: > > On Wed, Jul 05, 2023 at 06:32:51PM +0300, Imre Deak wrote: > > > On Thu, May 25, 2023 at 01:10:36PM +0300, Stanislav Lisovskiy wrote: > > > > According to BSpec

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove some dead "code" (rev2)

2023-07-06 Thread Patchwork
== Series Details == Series: drm/i915: Remove some dead "code" (rev2) URL : https://patchwork.freedesktop.org/series/120222/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13347_full -> Patchwork_120222v2_full Summary

[Intel-gfx] [drm-rerere] nightly.conf: drop sound tree from drm-tip altogether

2023-07-06 Thread Jani Nikula
We used to have the sound branches be part of drm-tip to help development of DP and HDMI audio. However, we always used to run into problems with the sound branches merging Linus' master at non-tagged random commits, wreaking havoc especially during the merge windows. We only ever want to have

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-06 Thread Lisovskiy, Stanislav
On Thu, Jul 06, 2023 at 11:47:26AM +0300, Imre Deak wrote: > On Thu, Jul 06, 2023 at 11:24:21AM +0300, Lisovskiy, Stanislav wrote: > > On Wed, Jul 05, 2023 at 06:32:51PM +0300, Imre Deak wrote: > > > On Thu, May 25, 2023 at 01:10:36PM +0300, Stanislav Lisovskiy wrote: > > > > According to BSpec

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-06 Thread Imre Deak
On Thu, Jul 06, 2023 at 11:24:21AM +0300, Lisovskiy, Stanislav wrote: > On Wed, Jul 05, 2023 at 06:32:51PM +0300, Imre Deak wrote: > > On Thu, May 25, 2023 at 01:10:36PM +0300, Stanislav Lisovskiy wrote: > > > According to BSpec 49190, when enabling crtcs, we first setup > > > slave and then

Re: [Intel-gfx] [PATCH 00/13] drm/i915/sdvo: DDC rework and fixes

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > I have plans to switch the whole driver over to using > drm_connector_init_with_ddc(), and thus populate the > sysfs "ddc" consistently. The biggest hurdle is the > SDVO DDC handling, so start by cleaning that up. I support

Re: [Intel-gfx] [PATCH 05/13] drm/i915: Fully populate crtc_state->dpll

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Call *_calc_dpll_params() even in cases where the encoder has > computed the DPLL params for us. > > The SDVO TV output code doesn't populate crtc_state->dpll.dot > leading to the dotclock getting calculated as zero, and that >

Re: [Intel-gfx] [PATCH 13/13] drm/i915/sdvo: Print out the i2c pin and slave address

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > To reduce the guesswork a bit let's print out the SDVO > device i2c bus and slave address during init. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_sdvo.c | 4 >

Re: [Intel-gfx] [PATCH 12/13] drm/i915/sdvo: Rework DDC bus handling

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Each SDVO device can have up to three sets of DDC pins. > Currently we just register a single i2c_adapter for the > entire SDVO device and semi-randomly pick the "correct" > set of DDC pins during intel_sdvo_tmds_sink_detect().

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-06 Thread Lisovskiy, Stanislav
On Wed, Jul 05, 2023 at 06:32:51PM +0300, Imre Deak wrote: > On Thu, May 25, 2023 at 01:10:36PM +0300, Stanislav Lisovskiy wrote: > > According to BSpec 49190, when enabling crtcs, we first setup > > slave and then master crtc, however for disabling it should go > > vice versa, i.e first master,

Re: [Intel-gfx] [PATCH 11/13] drm/i915/sdvo: Get rid of the per-connector i2c symlink

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > We should switch over to the standard "ddc" per-connector > symlink instead of rolling our own thing. The i2c specific > symlink is also in the way of reworking the SDVO DDC handling > (which is a mess atm) so get rid of it. > >

Re: [Intel-gfx] [PATCH 10/13] drm/i915/sdvo: Nuke the duplicate sdvo->port

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > We already have encoder->port so get rid of the duplicate > sdvo->port. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_sdvo.c | 19 --- > 1 file changed,

Re: [Intel-gfx] [PATCH 09/13] drm/i915/sdvo: Initialize the encoder ealier

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Call drm_encoder_init() earlier so that we don't have to keep passing > the i915/dev_priv around separately. *earlier in the subject. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_sdvo.c | 35

[Intel-gfx] [PULL] drm-intel-next-fixes

2023-07-06 Thread Tvrtko Ursulin
Hi Dave, Daniel, A weekly collection of fixes for the drm-next/6.5 merge window. Mostly small display fixups, one for GuC/SLPC and one header file tidy. I see last week did not get pulled so this week contains those ones plus two more fixups - one code tidy actually and one fixup. Regards,

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-06 Thread Lisovskiy, Stanislav
On Wed, Jul 05, 2023 at 06:32:51PM +0300, Imre Deak wrote: > On Thu, May 25, 2023 at 01:10:36PM +0300, Stanislav Lisovskiy wrote: > > According to BSpec 49190, when enabling crtcs, we first setup > > slave and then master crtc, however for disabling it should go > > vice versa, i.e first master,

Re: [Intel-gfx] [PATCH 08/13] drm/i915/sdvo: Nuke attached_output tracking

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Instead of operating on the output the user specified (via the > connector) the current code tends to operate on whichever outputs > it has detected as attached. That is not how the kms uapi is supposed > to work. So simply get

Re: [Intel-gfx] [PATCH 07/13] drm/i915/sdvo: Fail gracefully if the TV dotclock is out of range

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Instead of warning and continuing with bogus state when the > requested dotclock isn't acceptable just print some debug > spew and fail gracefully. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [Intel-gfx] [PATCH 06/13] drm/i915/sdvo: Pick the TV dotclock from adjusted_mode

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > port_clock is what the encoder/dpll code is supposed to calculate, > it is not the input clock. Use the dotclock as the target we're > trying to achieve instead. > > TODO: the SDVO TV clocking is a mess atm and needs further

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Don't warn about zero N/P in *_calc_dpll_params()

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Allow *_calc_dpll_params() to be called even if the N/P dividers > are zero without warning. We'll want to call these to make sure the > derived values are fully computed, but not all users (VLV DSI in > particular) don't even

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove some dead "code" (rev2)

2023-07-06 Thread Patchwork
== Series Details == Series: drm/i915: Remove some dead "code" (rev2) URL : https://patchwork.freedesktop.org/series/120222/ State : success == Summary == CI Bug Log - changes from CI_DRM_13347 -> Patchwork_120222v2 Summary ---

Re: [Intel-gfx] [PATCH 03/13] drm/i915/sdvo: s/sdvo_inputs_mask/sdvo_num_inputs/

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > The SDVO inputs are reportes a simple number, not a bitmask. *reported as a > Adjust the code to match reality. > > Note that we don't actually support dual input SDVO devices, > and we just always use the first input. > >

Re: [Intel-gfx] [PATCH 02/13] drm/i915/sdvo: Protect macro args

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Put parens around macro argument evaluation for safety. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_sdvo.c | 13 ++--- > 1 file changed, 6 insertions(+), 7

Re: [Intel-gfx] [PATCH 01/13] drm/i915/sdvo: Issue SetTargetOutput prior ot GetAttachedDisplays

2023-07-06 Thread Jani Nikula
On Wed, 05 Jul 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > I have at least one SDVO device (some Lenovo DVI-I ADD2 card, > based on Conexant CX25904) where GetAttachedDisplays returns > success but fails to report any attached displays unless wet *we Also s/ot/to/ in subject. >