== Series Details ==
Series: drm/i915/dpt: Use shmem for dpt objects (rev2)
URL : https://patchwork.freedesktop.org/series/120885/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13394_full -> Patchwork_120885v2_full
Summary
== Series Details ==
Series: Reduce MTL-specific platform checks
URL : https://patchwork.freedesktop.org/series/120943/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13394_full -> Patchwork_120943v1_full
Summary
---
== Series Details ==
Series: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
URL : https://patchwork.freedesktop.org/series/120940/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13394_full -> Patchwork_120940v1_full
== Series Details ==
Series: drm/i915/dpt: Use shmem for dpt objects (rev2)
URL : https://patchwork.freedesktop.org/series/120885/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13394 -> Patchwork_120885v2
Summary
---
On Tue, 18 Jul 2023 12:49:47 -0700, Matt Roper wrote:
>
Hi Matt,
> On Thu, Mar 23, 2023 at 03:59:01PM -0700, Umesh Nerlige Ramappa wrote:
> > OAM does not work with media C6 enabled on some steppings of MTL.
>
> I just stumbled across this while looking at something else, but
> 14017512683 isn't
== Series Details ==
Series: Reduce MTL-specific platform checks
URL : https://patchwork.freedesktop.org/series/120943/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13394 -> Patchwork_120943v1
Summary
---
== Series Details ==
Series: Reduce MTL-specific platform checks
URL : https://patchwork.freedesktop.org/series/120943/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Reduce MTL-specific platform checks
URL : https://patchwork.freedesktop.org/series/120943/
State : warning
== Summary ==
Error: dim checkpatch failed
c3afd0a4c654 drm/i915: Consolidate condition for Wa_22011802037
448c3a48c6f6 drm/i915/xelpg: Call Xe_LPG
== Series Details ==
Series: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
URL : https://patchwork.freedesktop.org/series/120940/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13394 -> Patchwork_120940v1
Dpt objects that are created from internal get evicted when there is
memory pressure and do not get restored when pinned during scanout. The
pinned page table entries look corrupted and programming the display
engine with the incorrect pte's result in DE throwing pipe faults.
Create DPT objects
== Series Details ==
Series: series starting with [1/3] drm/i915: Avoid endless HPD poll detect loop
via runtime suspend/resume
URL : https://patchwork.freedesktop.org/series/120931/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13394_full -> Patchwork_120931v1_full
Although some of our Xe_LPG workarounds were already being applied based
on IP version correctly, others were matching on MTL as a base platform,
which is incorrect. Although MTL is the only platform right now that
uses Xe_LPG IP, this may not always be the case. If a future platform
re-uses
Stepping-specific display behavior shouldn't be tied to MTL as a
platform, but rather specifically to the Xe_LPM+ IP. Future non-MTL
platforms may re-use this IP and will need to follow the exact same
logic and apply the same workarounds. IS_MTL_DISPLAY_STEP() is dropped
in favor of a new macro
Most of the IS_METEORLAKE checks in the display code shouldn't actually
be tied to MTL as a platform, but rather to the Xe_LPD+ display IP
(which is used in MTL, but may show up again in future platforms). In
cases where we're trying to match that specific IP, use a version check
against
Now that we properly match the Xe_LPG IP versions associated with
various workarounds, there's no longer any need to define separate MTL
subplatform in the driver. Nothing in the code is conditional on MTL-M
or MTL-P base platforms. Furthermore, I'm not sure the "M" and "P"
designations are even
Many of the IS_METEORLAKE conditions throughout the driver are supposed
to be checks for Xe_LPG and/or Xe_LPM+ IP, not for the MTL platform
specifically. Update those checks to ensure that the code will still
operate properly if/when these IP versions show up on future platforms.
Signed-off-by:
The workaround bounds for Wa_22011802037 are somewhat complex and are
replicated in several places throughout the code. Pull the condition
out to a helper function to prevent mistakes if this condition needs to
change again in the future.
Signed-off-by: Matt Roper
---
Several workarounds are guarded by IS_MTL_GRAPHICS_STEP. However none
of these workarounds are actually tied to MTL as a platform; they only
relate to the Xe_LPG graphics IP, regardless of what platform it appears
in. At the moment MTL is the only platform that uses Xe_LPG with IP
versions 12.70
Stepping-specific media behavior shouldn't be tied to MTL as a platform,
but rather specifically to the Xe_LPM+ IP. Future non-MTL platforms may
re-use this IP and will need to follow the exact same logic and apply
the same workarounds. IS_MTL_MEDIA_STEP() is dropped in favor of a new
macro
Starting with MTL, the hardware moved to a disaggregated IP design where
graphics, media, and display are supposed to be treated independently of
the base platform that they're incorporated into. For driver logic that
is conditional on these IPs, the code should be checking the IP versions
(as
Hi Tvrtko,
> -Original Message-
> From: Tvrtko Ursulin
> Sent: Tuesday, July 18, 2023 3:08 AM
> To: Sripada, Radhakrishna ; intel-
> g...@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dpt: Use shmem for dpt objects
>
>
> On 18/07/2023 06:33, Radhakrishna Sripada
A proposed update to clang's -Wconstant-logical-operand to warn when the
left hand side is a constant shows the following instance in
nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ,
such as CONFIG_HZ=300:
In file included from drivers/gpu/drm/v3d/v3d_debugfs.c:12:
A proposed update to clang's -Wconstant-logical-operand to warn when the
left hand side is a constant shows the following instance in
nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ,
such as CONFIG_HZ=300:
drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: warning: use of
operand in nsecs_to_jiffies_timeout()
drivers/gpu/drm/i915/gem/i915_gem_wait.c | 2 +-
drivers/gpu/drm/v3d/v3d_drv.h| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
---
base-commit: fdf0eaf11452d72945af31804e2a1048ee1b574c
change-id:
20230718-nsecs_to_jiffies_timeout-constant-logical-operand-4a944690f3e9
Best regards,
--
Nathan Chancellor
== Series Details ==
Series: series starting with [CI,1/4] drm/i915: Move setting of rps thresholds
to init (rev3)
URL : https://patchwork.freedesktop.org/series/120857/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13394_full -> Patchwork_120857v3_full
On Tue, Jul 18, 2023 at 09:59:14AM +0100, Tvrtko Ursulin wrote:
>
> On 18/07/2023 09:11, Dnyaneshwar Bhadane wrote:
> > Follow consistent naming convention. Replace MTL with
> > METEORLAKE. Added defines that are replacing IS_MTL_GRAPHICS_STEP with
> > IS_METEORLAKE_P_GRAPHICS_STEP and
On Thu, Mar 23, 2023 at 03:59:01PM -0700, Umesh Nerlige Ramappa wrote:
> OAM does not work with media C6 enabled on some steppings of MTL.
I just stumbled across this while looking at something else, but
14017512683 isn't a valid workaround number; that's just a per-platform
identifier associated
On Tue, Jul 18, 2023 at 09:40:41AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Feature test also needs adjusting after sysfs helper API changes...
>
> Signed-off-by: Tvrtko Ursulin
> Fixes: d86ca7e17b58 ("tests/i915_pm_rps: Exercise sysfs thresholds")
> Reference: 54dc25efaf10
On Tue, 18 Jul 2023 01:40:41 -0700, Tvrtko Ursulin wrote:
>
> From: Tvrtko Ursulin
>
> Feature test also needs adjusting after sysfs helper API changes...
>
> Signed-off-by: Tvrtko Ursulin
> Fixes: d86ca7e17b58 ("tests/i915_pm_rps: Exercise sysfs thresholds")
> Reference: 54dc25efaf10
On Tue, 18 Jul 2023 11:00:36 -0700, Belgaumkar, Vinay wrote:
>
>
> On 7/17/2023 9:26 PM, Dixit, Ashutosh wrote:
> > On Mon, 17 Jul 2023 21:19:13 -0700, Belgaumkar, Vinay wrote:
> >>
> >> On 7/17/2023 6:50 PM, Dixit, Ashutosh wrote:
> >>> On Mon, 17 Jul 2023 11:42:13 -0700, Vinay Belgaumkar wrote:
== Series Details ==
Series: series starting with [1/3] drm/i915: Avoid endless HPD poll detect loop
via runtime suspend/resume
URL : https://patchwork.freedesktop.org/series/120931/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13394 -> Patchwork_120931v1
On 7/17/2023 9:26 PM, Dixit, Ashutosh wrote:
On Mon, 17 Jul 2023 21:19:13 -0700, Belgaumkar, Vinay wrote:
On 7/17/2023 6:50 PM, Dixit, Ashutosh wrote:
On Mon, 17 Jul 2023 11:42:13 -0700, Vinay Belgaumkar wrote:
Some subtests seem to be failing in CI, use igt_assert_(lt/eq) which
print the
== Series Details ==
Series: series starting with [1/3] drm/i915: Avoid endless HPD poll detect loop
via runtime suspend/resume
URL : https://patchwork.freedesktop.org/series/120931/
State : warning
== Summary ==
Error: dim checkpatch failed
0aa33f8c1790 drm/i915: Avoid endless HPD poll
== Series Details ==
Series: series starting with [1/3] drm/i915: Avoid endless HPD poll detect loop
via runtime suspend/resume
URL : https://patchwork.freedesktop.org/series/120931/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit
The issue fixed in
commit a8ddac7c9f06 ("drm/i915: Avoid HPD poll detect triggering a new detect
cycle")
on VLV, CHV is still present on platforms where the display hotplug
detection functionality is available whenever the device is in D0 state
(hence these platforms switch to HPD polling only
After the commit in the Fixes: line below, HPD polling stopped working
on i915, since after that change calling drm_kms_helper_poll_enable()
doesn't restart drm_mode_config::output_poll_work if the work was
stopped (no connectors needing polling) and enabling polling for a
connector (during
Add a helper to reschedule drm_mode_config::output_poll_work after
polling has been enabled for a connector (and needing a reschedule,
since previously polling was disabled for all connectors and hence
output_poll_work was not running).
This is needed by the next patch fixing HPD polling on i915.
On Tue, 18 Jul 2023 01:39:35 -0700, Lionel Landwerlin wrote:
>
Hi Lionel,
> On 18/07/2023 05:43, Ashutosh Dixit wrote:
> > The code in oa_buffer_check_unlocked() is correct only if the OA buffer is
> > 16 MB aligned (which seems to be the case today in i915). However when the
> > 16 MB alignment
On Tue, Jul 18, 2023 at 06:55:25AM -0700, Yi Liu wrote:
> Existing VFIO provides group-centric user APIs for userspace. Userspace
> opens the /dev/vfio/$group_id first before getting device fd and hence
> getting access to device. This is not the desired model for iommufd. Per
> the conclusion of
On Tue, Jul 18, 2023 at 06:55:47AM -0700, Yi Liu wrote:
> This adds ioctl for userspace to bind device cdev fd to iommufd.
>
> VFIO_DEVICE_BIND_IOMMUFD: bind device to an iommufd, hence gain DMA
> control provided by the iommufd. open_device
>
On Tue, Jul 18, 2023 at 06:55:45AM -0700, Yi Liu wrote:
> It's common to get a reference to the iommufd context from a given file
> descriptor. So adds an API for it. Existing users of this API are compiled
> only when IOMMUFD is enabled, so no need to have a stub for the IOMMUFD
> disabled case.
On Tue, Jul 18, 2023 at 03:55:41AM -0700, Yi Liu wrote:
> This copies the vfio_pci_dependent_device to userspace during looping each
> affected device for reporting vfio_pci_hot_reset_info. This avoids counting
> the affected devices and allocating a potential large buffer to store the
>
== Series Details ==
Series: drm/i915: Refactor PAT/object cache handling
URL : https://patchwork.freedesktop.org/series/120924/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13394 -> Patchwork_120924v1
Summary
---
== Series Details ==
Series: drm/i915: Refactor PAT/object cache handling
URL : https://patchwork.freedesktop.org/series/120924/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Refactor PAT/object cache handling
URL : https://patchwork.freedesktop.org/series/120924/
State : warning
== Summary ==
Error: dim checkpatch failed
ad8a0b08444d drm/i915: Refactor PAT/object cache handling
Traceback (most recent call last):
File
== Series Details ==
Series: series starting with [CI,1/4] drm/i915: Move setting of rps thresholds
to init (rev3)
URL : https://patchwork.freedesktop.org/series/120857/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13394 -> Patchwork_120857v3
== Series Details ==
Series: Add vfio_device cdev for iommufd support (rev19)
URL : https://patchwork.freedesktop.org/series/113696/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/113696/revisions/19/mbox/ not
applied
Applying: vfio: Allocate per
On Tue, Jul 18, 2023 at 02:28:26AM +0200, Andi Shyti wrote:
> Hi Matt,
>
> > > > > > + /*
> > > > > > +* Aux invalidations on Aux CCS platforms require
> > > > > > +* memory traffic is quiesced prior.
> > > > > > +*/
> > > > > > + if ((mode & EMIT_INVALIDATE) &&
== Series Details ==
Series: Update AUX invalidation sequence (rev5)
URL : https://patchwork.freedesktop.org/series/119798/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/119798/revisions/5/mbox/ not
applied
Applying: drm-tip:
On 17/07/2023 19:03, John Harrison wrote:
On 7/13/2023 05:11, Tvrtko Ursulin wrote:
On 13/07/2023 12:09, Andrzej Hajda wrote:
Hi,
On 13.07.2023 09:39, Tvrtko Ursulin wrote:
On 12/07/2023 19:54, John Harrison wrote:
On 7/12/2023 09:27, Andrzej Hajda wrote:
On 12.07.2023 14:35, Tvrtko
== Series Details ==
Series: series starting with [CI,1/4] drm/i915: Move setting of rps thresholds
to init (rev3)
URL : https://patchwork.freedesktop.org/series/120857/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
== Series Details ==
Series: series starting with [CI,1/4] drm/i915: Move setting of rps thresholds
to init (rev3)
URL : https://patchwork.freedesktop.org/series/120857/
State : warning
== Summary ==
Error: dim checkpatch failed
225af759e3c0 drm/i915: Move setting of rps thresholds to init
== Series Details ==
Series: Enhance vfio PCI hot reset for vfio cdev device (rev10)
URL : https://patchwork.freedesktop.org/series/116991/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13393_full -> Patchwork_116991v10_full
Hi Andi,
On 7/18/2023 3:38 PM, Andi Shyti wrote:
Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before
invalidation") has made sure that the memory is quiesced before
invalidating the AUX CCS table. Do it for all the other engines
and not just RCS.
Signed-off-by: Andi Shyti
Cc:
From: Tvrtko Ursulin
Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level") has
introduced PAT indices to i915 internal APIs, partially replacing the
usage of driver internal cache_level, but has also added a few
questionable design decisions which this patch tries to improve
This gives notes for userspace applications on device cdev usage.
Reviewed-by: Kevin Tian
Reviewed-by: Jason Gunthorpe
Signed-off-by: Yi Liu
---
Documentation/driver-api/vfio.rst | 139 ++
1 file changed, 139 insertions(+)
diff --git
vfio_group is not needed for vfio device cdev, so with vfio device cdev
introduced, the vfio_group infrastructures can be compiled out if only
cdev is needed.
Reviewed-by: Jason Gunthorpe
Tested-by: Nicolin Chen
Tested-by: Matthew Rosato
Tested-by: Yanting Jiang
Tested-by: Shameer Kolothum
This adds ioctl for userspace to bind device cdev fd to iommufd.
VFIO_DEVICE_BIND_IOMMUFD: bind device to an iommufd, hence gain DMA
control provided by the iommufd. open_device
op is called after bind_iommufd op.
Tested-by: Nicolin
This adds a local variable to store the user pointer cast result from arg.
It avoids the repeated casts in the code when more ioctls are added.
Reviewed-by: Jason Gunthorpe
Signed-off-by: Yi Liu
---
drivers/vfio/vfio_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
This adds ioctl for userspace to attach device cdev fd to and detach
from IOAS/hw_pagetable managed by iommufd.
VFIO_DEVICE_ATTACH_IOMMUFD_PT: attach vfio device to IOAS or hw_pagetable
managed by iommufd. Attach can be undo
The IOMMU_CAP_CACHE_COHERENCY check only applies to the physical devices
that are IOMMU-backed. But it is now in the group code. If want to compile
vfio_group infrastructure out, this check needs to be moved out of the group
code.
Another reason for this change is to fail the device registration
device_del() destroys the vfio-dev/vfioX under the sysfs for vfio_device.
There is no reason to keep it while the device is going to be unregistered.
This movement is also a preparation for adding vfio_device cdev. Kernel
should remove the cdev node of the vfio_device to avoid new registration
It's common to get a reference to the iommufd context from a given file
descriptor. So adds an API for it. Existing users of this API are compiled
only when IOMMUFD is enabled, so no need to have a stub for the IOMMUFD
disabled case.
Signed-off-by: Yi Liu
---
drivers/iommu/iommufd/main.c | 24
This prepares for adding DETACH ioctl for emulated VFIO devices.
Reviewed-by: Kevin Tian
Reviewed-by: Jason Gunthorpe
Tested-by: Terrence Xu
Tested-by: Nicolin Chen
Tested-by: Matthew Rosato
Tested-by: Yanting Jiang
Tested-by: Shameer Kolothum
Tested-by: Zhenzhong Duan
Signed-off-by: Yi
This saves some lines when adding the kvm get logic for the vfio_device
cdev path.
This also renames _vfio_device_get_kvm_safe() to be vfio_device_get_kvm_safe().
Suggested-by: Jason Gunthorpe
Reviewed-by: Jason Gunthorpe
Tested-by: Zhenzhong Duan
Signed-off-by: Yi Liu
---
VFIO group has historically allowed multi-open of the device FD. This
was made secure because the "open" was executed via an ioctl to the
group FD which is itself only single open.
However, no known use of multiple device FDs today. It is kind of a
strange thing to do because new device FDs can
This avoids endless vfio_device refcount increment by userspace, which
would keep blocking the vfio_unregister_group_dev().
Reviewed-by: Jason Gunthorpe
Tested-by: Nicolin Chen
Tested-by: Matthew Rosato
Tested-by: Yanting Jiang
Tested-by: Shameer Kolothum
Tested-by: Terrence Xu
Tested-by:
This prepares for adding DETACH ioctl for physical VFIO devices.
Reviewed-by: Kevin Tian
Reviewed-by: Jason Gunthorpe
Tested-by: Terrence Xu
Tested-by: Nicolin Chen
Tested-by: Matthew Rosato
Tested-by: Yanting Jiang
Tested-by: Shameer Kolothum
Tested-by: Zhenzhong Duan
Signed-off-by: Yi
This is for counting the devices that are opened via the cdev path. This
count is increased and decreased by the cdev path. The group path checks
it to achieve exclusion with the cdev path. With this, only one path
(group path or cdev path) will claim DMA ownership. This avoids scenarios
in which
Allow the vfio_device file to be in a state where the device FD is
opened but the device cannot be used by userspace (i.e. its .open_device()
hasn't been called). This inbetween state is not used when the device
FD is spawned from the group FD, however when we create the device FD
directly by
This defines KVM_DEV_VFIO_FILE* and make alias with KVM_DEV_VFIO_GROUP*.
Old userspace uses KVM_DEV_VFIO_GROUP* works as well.
Reviewed-by: Jason Gunthorpe
Reviewed-by: Kevin Tian
Tested-by: Terrence Xu
Tested-by: Nicolin Chen
Tested-by: Matthew Rosato
Tested-by: Yanting Jiang
Tested-by:
.bind_iommufd() will generate an ID to represent this bond, which is
needed by userspace for further usage. Store devid in vfio_device_file
to avoid passing the pointer in multiple places.
Reviewed-by: Kevin Tian
Reviewed-by: Jason Gunthorpe
Tested-by: Terrence Xu
Tested-by: Nicolin Chen
This adds cdev support for vfio_device. It allows the user to directly
open a vfio device w/o using the legacy container/group interface, as a
prerequisite for supporting new iommu features like nested translation
and etc.
The device fd opened in this manner doesn't have the capability to access
From: Nicolin Chen
Previously, the detach routine is only done by the destroy(). And it was
called by vfio_iommufd_emulated_unbind() when the device runs close(), so
all the mappings in iopt were cleaned in that setup, when the call trace
reaches this detach() routine.
Now, there's a need of a
This aligns the bind/attach logic with the coming vfio device cdev support.
Reviewed-by: Kevin Tian
Reviewed-by: Jason Gunthorpe
Tested-by: Terrence Xu
Tested-by: Nicolin Chen
Tested-by: Matthew Rosato
Tested-by: Yanting Jiang
Tested-by: Shameer Kolothum
Tested-by: Zhenzhong Duan
This moves the noiommu compat validation logic into vfio_df_group_open().
This is more consistent with what will be done in vfio device cdev path.
Reviewed-by: Kevin Tian
Reviewed-by: Jason Gunthorpe
Tested-by: Terrence Xu
Tested-by: Nicolin Chen
Tested-by: Matthew Rosato
Tested-by: Yanting
This renames kvm_vfio_group related helpers to prepare for accepting
vfio device fd. No functional change is intended.
Reviewed-by: Kevin Tian
Reviewed-by: Eric Auger
Reviewed-by: Jason Gunthorpe
Tested-by: Terrence Xu
Tested-by: Nicolin Chen
Tested-by: Matthew Rosato
Tested-by: Yanting
This avoids passing too much parameters in multiple functions. Per the
input parameter change, rename the function to be vfio_df_open/close().
Reviewed-by: Kevin Tian
Reviewed-by: Jason Gunthorpe
Reviewed-by: Eric Auger
Tested-by: Terrence Xu
Tested-by: Nicolin Chen
Tested-by: Matthew Rosato
This makes the vfio file kAPIs to accept vfio device files, also a
preparation for vfio device cdev support.
For the kvm set with vfio device file, kvm pointer is stored in struct
vfio_device_file, and use kvm_ref_lock to protect kvm set and kvm
pointer usage within VFIO. This kvm pointer will be
This prepares for making the below kAPIs to accept both group file
and device file instead of only vfio group file.
bool vfio_file_enforced_coherent(struct file *file);
void vfio_file_set_kvm(struct file *file, struct kvm *kvm);
Reviewed-by: Kevin Tian
Reviewed-by: Eric Auger
Reviewed-by:
This is preparation for adding vfio device cdev support. vfio device
cdev requires:
1) A per device file memory to store the kvm pointer set by KVM. It will
be propagated to vfio_device:kvm after the device cdev file is bound
to an iommufd.
2) A mechanism to block device access through
Existing VFIO provides group-centric user APIs for userspace. Userspace
opens the /dev/vfio/$group_id first before getting device fd and hence
getting access to device. This is not the desired model for iommufd. Per
the conclusion of community discussion[1], iommufd provides device-centric
kAPIs
Sorry! wrong format-patch :)
Please ignore patch 1.
Andi
On Tue, Jul 18, 2023 at 03:38:28PM +0200, Andi Shyti wrote:
> From: Robert Foss
>
> ---
> integration-manifest | 24
> 1 file changed, 24 insertions(+)
> create mode 100644 integration-manifest
>
> diff --git
Perform some refactoring with the purpose of keeping in one
single place all the operations around the aux table
invalidation.
With this refactoring add more engines where the invalidation
should be performed.
Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before
invalidation") has made sure that the memory is quiesced before
invalidating the AUX CCS table. Do it for all the other engines
and not just RCS.
Signed-off-by: Andi Shyti
Cc: Jonathan Cavitt
Cc: Matt Roper
---
From: Jonathan Cavitt
For platforms that use Aux CCS, wait for aux invalidation to
complete by checking the aux invalidation register bit is
cleared.
Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Signed-off-by: Jonathan Cavitt
Signed-off-by: Andi Shyti
Cc:
We always assumed that a device might either have AUX or FLAT
CCS, but this is an approximation that is not always true as it
requires some further per device checks.
Add the "has_aux_ccs" flag in the intel_device_info structure in
order to have a per device flag indicating of the AUX CCS.
In preparation of the next patch align with the datasheet (BSPEC
47112) with the naming of the pipe control set of flag values.
The variable "flags" in gen12_emit_flush_rcs() is applied as a
set of flags called Bit Group 1.
Define also the Bit Group 0 as bit_group_0 where currently only
From: Jonathan Cavitt
All memory traffic must be quiesced before requesting
an aux invalidation on platforms that use Aux CCS.
Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Signed-off-by: Jonathan Cavitt
Signed-off-by: Andi Shyti
Cc: # v5.8+
Reviewed-by:
Just a trivial refactoring for reducing the number of code
duplicate. This will come at handy in the next commits.
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44 +---
1 file changed, 23 insertions(+), 21 deletions(-)
diff --git
Fix the 'NV' definition postfix that is supposed to be INV.
Take the chance to also order properly the registers based on
their address and call the GEN12_GFX_CCS_AUX_INV address as
GEN12_CCS_AUX_INV like all the other similar registers.
Remove also VD1, VD3 and VE1 registers that don't exist
From: Robert Foss
---
integration-manifest | 24
1 file changed, 24 insertions(+)
create mode 100644 integration-manifest
diff --git a/integration-manifest b/integration-manifest
new file mode 100644
index 0..8642016b34817
--- /dev/null
+++
Hi,
as there are new hardware directives, we need a little adaptation
for the AUX invalidation sequence.
In this version we support all the engines affected by this
change.
The stable backport has some challenges because the original
patch that this series fixes has had more changes in between.
On 17.07.2023 20:49, Christophe JAILLET wrote:
All error handling paths go to 'out', except this one. Be consistent and
also branch to 'out' here.
Fixes: c10a652e239e ("drm/i915/selftests: Rework context handling in hugepages
selftests")
Signed-off-by: Christophe JAILLET
For me seems
On Tue, Jul 18, 2023 at 11:53:17AM +0100, Tvrtko Ursulin wrote:
On 18/07/2023 09:11, Dnyaneshwar Bhadane wrote:
From: Anusha Srivatsa
Driver refers to the platform Alderlake S as ADLS in places
and ALDERLAKE_S in some. Making the consistent change
to avoid confusion of the right naming
== Series Details ==
Series: Enhance vfio PCI hot reset for vfio cdev device (rev10)
URL : https://patchwork.freedesktop.org/series/116991/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13393 -> Patchwork_116991v10
Summary
On 18.07.2023 12:10, Su Hui wrote:
On 2023/7/18 13:39, Dan Carpenter wrote:
On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote:
On 17.07.2023 08:22, Su Hui wrote:
Clang warning: drivers/gpu/drm/i915/display/intel_tv.c:
line 991, column 22 Division by zero.
Assuming
== Series Details ==
Series: Enhance vfio PCI hot reset for vfio cdev device (rev10)
URL : https://patchwork.freedesktop.org/series/116991/
State : warning
== Summary ==
Error: dim checkpatch failed
7a4aaa443b7a vfio/pci: Update comment around group_fd get in
vfio_pci_ioctl_pci_hot_reset()
This is the way user to invoke hot-reset for the devices opened by cdev
interface. User should check the flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED
in the output of VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl before doing
hot-reset for cdev devices.
Suggested-by: Jason Gunthorpe
Reviewed-by: Jason
There are drivers that need to search vfio_device within a given dev_set.
e.g. vfio-pci. So add a helper.
vfio_pci_is_device_in_set() now returns -EBUSY in commit a882c16a2b7e
("vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set") where
it was trying to preserve the return of
1 - 100 of 146 matches
Mail list logo
