Re: [Intel-gfx] [PATCH] drm/i915/display: Dual refresh rate fastset fixes with VRR fastset

2023-08-10 Thread Srinivas, Vidya
Hello Mansi, I tried your patch for the VRR panel we have (bug https://gitlab.freedesktop.org/drm/intel/-/issues/8851). Have uploaded logs with your patch to the bug as well. But display is blanking out and also I get underrun. Could you kindly have a check please? Many thanks. Regards Vidya

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pxp/mtl: Update gsc-heci cmd submission

2023-08-10 Thread Patchwork
== Series Details == Series: drm/i915/pxp/mtl: Update gsc-heci cmd submission URL : https://patchwork.freedesktop.org/series/122328/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13504 -> Patchwork_122328v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/pxp/mtl: Update gsc-heci cmd submission

2023-08-10 Thread Patchwork
== Series Details == Series: drm/i915/pxp/mtl: Update gsc-heci cmd submission URL : https://patchwork.freedesktop.org/series/122328/ State : warning == Summary == Error: dim sparse failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp/mtl: Update gsc-heci cmd submission

2023-08-10 Thread Patchwork
== Series Details == Series: drm/i915/pxp/mtl: Update gsc-heci cmd submission URL : https://patchwork.freedesktop.org/series/122328/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] [PATCH v2 3/3] drm/i915/gt/pxp: User PXP contexts requires runalone bit in lrc

2023-08-10 Thread Alan Previn
On Meteorlake onwards, HW specs require that all user contexts that run on render or compute engines and require PXP must enforce run-alone bit in lrc. Add this enforcement for protected contexts. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/gt/intel_lrc.c | 12 1 file

[Intel-gfx] [PATCH v2 2/3] drm/i915/pxp/mtl: Update pxp-firmware packet size

2023-08-10 Thread Alan Previn
Update the GSC-fw input/output HECI packet size to match updated internal fw specs. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_cmd_interface_43.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_cmd_interface_43.h

[Intel-gfx] [PATCH v2 1/3] drm/i915/pxp/mtl: Update pxp-firmware response timeout

2023-08-10 Thread Alan Previn
Update the max GSC-fw response time to match updated internal fw specs. Because this response time is an SLA on the firmware, not inclusive of i915->GuC->HW handoff latency, when submitting requests to the GSC fw via intel_gsc_uc_heci_cmd_submit_nonpriv, start the count after the request hits the

[Intel-gfx] [PATCH v2 0/3] drm/i915/pxp/mtl: Update gsc-heci cmd submission

2023-08-10 Thread Alan Previn
For MTL, update the GSC-HECI packet size and the max firmware response timeout to match internal fw specs. Enforce setting run-alone bit in LRC for protected contexts. Signed-off-by: Alan Previn Alan Previn (3): drm/i915/pxp/mtl: Update pxp-firmware response timeout drm/i915/pxp/mtl: Update

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/selftest: Simplify Y-major tiling in blit selftest

2023-08-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftest: Simplify Y-major tiling in blit selftest URL : https://patchwork.freedesktop.org/series/122318/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13504 -> Patchwork_122318v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/selftest: Simplify Y-major tiling in blit selftest

2023-08-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftest: Simplify Y-major tiling in blit selftest URL : https://patchwork.freedesktop.org/series/122318/ State : warning == Summary == Error: dim sparse failed /home/kbuild/linux/maintainer-tools/dim: line 50:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftest: Simplify Y-major tiling in blit selftest

2023-08-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftest: Simplify Y-major tiling in blit selftest URL : https://patchwork.freedesktop.org/series/122318/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50:

[Intel-gfx] ✓ Fi.CI.BAT: success for Reduce MTL-specific platform checks (rev3)

2023-08-10 Thread Patchwork
== Series Details == Series: Reduce MTL-specific platform checks (rev3) URL : https://patchwork.freedesktop.org/series/120943/ State : success == Summary == CI Bug Log - changes from CI_DRM_13504 -> Patchwork_120943v3 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Reduce MTL-specific platform checks (rev3)

2023-08-10 Thread Patchwork
== Series Details == Series: Reduce MTL-specific platform checks (rev3) URL : https://patchwork.freedesktop.org/series/120943/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Reduce MTL-specific platform checks (rev3)

2023-08-10 Thread Patchwork
== Series Details == Series: Reduce MTL-specific platform checks (rev3) URL : https://patchwork.freedesktop.org/series/120943/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Align igt_spinner_create_request with hangcheck

2023-08-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Align igt_spinner_create_request with hangcheck URL : https://patchwork.freedesktop.org/series/122312/ State : success == Summary == CI Bug Log - changes from CI_DRM_13504 -> Patchwork_122312v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/selftests: Align igt_spinner_create_request with hangcheck

2023-08-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Align igt_spinner_create_request with hangcheck URL : https://patchwork.freedesktop.org/series/122312/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Align igt_spinner_create_request with hangcheck

2023-08-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Align igt_spinner_create_request with hangcheck URL : https://patchwork.freedesktop.org/series/122312/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Disable SF round to nearest even

2023-08-10 Thread Matt Roper
On Wed, Aug 09, 2023 at 12:10:43PM +0530, Shekhar Chauhan wrote: > Workaround for disabling round to nearest even in the SF unit. I don't think we want/need this workaround in i915 (see the explanation I just gave on the Xe patch for the same workaround). However we do need to _drop_ the

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc/slpc: Restore efficient freq earlier (rev3)

2023-08-10 Thread Rodrigo Vivi
On Wed, Aug 02, 2023 at 12:41:09AM +, Belgaumkar, Vinay wrote: >  > > > > 

Re: [Intel-gfx] [PATCH v1] drm/i915/pxp/mtl: Update gsc-heci cmd size and timeout

2023-08-10 Thread Teres Alexis, Alan Previn
On Fri, 2023-07-07 at 11:34 -0700, Teres Alexis, Alan Previn wrote: > Update the max GSC-HECI packet size and the max firmware > response timeout to match internal fw specs. > > Signed-off-by: Alan Previn I'm going to re-rev this and change the subject slightly to "Update gsc-heci cmd

[Intel-gfx] [PATCH 2/2] drm/i915: Eliminate has_4tile feature flag

2023-08-10 Thread Matt Roper
We don't really need a feature flag for has_4tile since there's a well-defined cutover point (DG2) at which all new platforms started using Tile4 as their Y-major tiling layout. The GT side of the code already handles Tile4 vs legacy TileY with checks on the IP version rather than looking at the

[Intel-gfx] [PATCH 1/2] drm/i915/selftest: Simplify Y-major tiling in blit selftest

2023-08-10 Thread Matt Roper
Rather than picking random tiling formats from a pool that contains both TileY and Tile4 and then trying to replace one with the other depending on the platform, it's simpler to just use a single enum value that represents whatever the platform-appropriate Y-major tiling format is (i.e., Tile4 on

Re: [Intel-gfx] [PATCH 1/1] drm/i915/selftests: Align igt_spinner_create_request with hangcheck

2023-08-10 Thread Matt Roper
On Thu, Aug 10, 2023 at 03:34:35PM -0700, Matt Roper wrote: > On Thu, Aug 10, 2023 at 01:36:20PM -0700, Jonathan Cavitt wrote: > > Align igt_spinner_create_request with the hang_create_request > > implementation in selftest_hangcheck.c. > > > > Signed-off-by: Jonathan Cavitt > > --- > >

Re: [Intel-gfx] [PATCH 1/1] drm/i915/selftests: Align igt_spinner_create_request with hangcheck

2023-08-10 Thread Matt Roper
On Thu, Aug 10, 2023 at 01:36:20PM -0700, Jonathan Cavitt wrote: > Align igt_spinner_create_request with the hang_create_request > implementation in selftest_hangcheck.c. > > Signed-off-by: Jonathan Cavitt > --- > drivers/gpu/drm/i915/selftests/igt_spinner.c | 3 +++ > 1 file changed, 3

[Intel-gfx] [PATCH v3 9/9] drm/i915: Replace several IS_METEORLAKE with proper IP version checks

2023-08-10 Thread Matt Roper
Many of the IS_METEORLAKE conditions throughout the driver are supposed to be checks for Xe_LPG and/or Xe_LPM+ IP, not for the MTL platform specifically. Update those checks to ensure that the code will still operate properly if/when these IP versions show up on future platforms. v2: - Update

[Intel-gfx] [PATCH v3 3/9] drm/i915/xelpg: Call Xe_LPG workaround functions based on IP version

2023-08-10 Thread Matt Roper
Although some of our Xe_LPG workarounds were already being applied based on IP version correctly, others were matching on MTL as a base platform, which is incorrect. Although MTL is the only platform right now that uses Xe_LPG IP, this may not always be the case. If a future platform re-uses

[Intel-gfx] [PATCH v3 7/9] drm/i915/mtl: Eliminate subplatforms

2023-08-10 Thread Matt Roper
Now that we properly match the Xe_LPG IP versions associated with various workarounds, there's no longer any need to define separate MTL subplatform in the driver. Nothing in the code is conditional on MTL-M or MTL-P base platforms. Furthermore, I'm not sure the "M" and "P" designations are even

[Intel-gfx] [PATCH v3 6/9] drm/i915: Eliminate IS_MTL_DISPLAY_STEP

2023-08-10 Thread Matt Roper
Stepping-specific display behavior shouldn't be tied to MTL as a platform, but rather specifically to the Xe_LPD+ IP. Future non-MTL platforms may re-use this IP and will need to follow the exact same logic and apply the same workarounds. IS_MTL_DISPLAY_STEP() is dropped in favor of a new macro

[Intel-gfx] [PATCH v3 2/9] drm/i915/xelpmp: Don't assume workarounds extend to future platforms

2023-08-10 Thread Matt Roper
The currently implemented Xe_LPM+ workarounds are specific to media version 13.00. When new IP versions show up in the future, they'll need their own workaround lists. Signed-off-by: Matt Roper Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++-- 1 file changed, 2

[Intel-gfx] [PATCH v3 8/9] drm/i915/display: Eliminate IS_METEORLAKE checks

2023-08-10 Thread Matt Roper
Most of the IS_METEORLAKE checks in the display code shouldn't actually be tied to MTL as a platform, but rather to the Xe_LPD+ display IP (which is used in MTL, but may show up again in future platforms). In cases where we're trying to match that specific IP, use a version check against

[Intel-gfx] [PATCH v3 1/9] drm/i915: Consolidate condition for Wa_22011802037

2023-08-10 Thread Matt Roper
The workaround bounds for Wa_22011802037 are somewhat complex and are replicated in several places throughout the code. Pull the condition out to a helper function to prevent mistakes if this condition needs to change again in the future. Signed-off-by: Matt Roper Reviewed-by: Gustavo Sousa

[Intel-gfx] [PATCH v3 4/9] drm/i915: Eliminate IS_MTL_GRAPHICS_STEP

2023-08-10 Thread Matt Roper
Several workarounds are guarded by IS_MTL_GRAPHICS_STEP. However none of these workarounds are actually tied to MTL as a platform; they only relate to the Xe_LPG graphics IP, regardless of what platform it appears in. At the moment MTL is the only platform that uses Xe_LPG with IP versions 12.70

[Intel-gfx] [PATCH v3 5/9] drm/i915: Eliminate IS_MTL_MEDIA_STEP

2023-08-10 Thread Matt Roper
Stepping-specific media behavior shouldn't be tied to MTL as a platform, but rather specifically to the Xe_LPM+ IP. Future non-MTL platforms may re-use this IP and will need to follow the exact same logic and apply the same workarounds. IS_MTL_MEDIA_STEP() is dropped in favor of

[Intel-gfx] [PATCH v3 0/9] Reduce MTL-specific platform checks

2023-08-10 Thread Matt Roper
Starting with MTL, the hardware moved to a disaggregated IP design where graphics, media, and display are supposed to be treated independently of the base platform that they're incorporated into. For driver logic that is conditional on these IPs, the code should be checking the IP versions (as

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Dual refresh rate fastset fixes with VRR fastset

2023-08-10 Thread Patchwork
== Series Details == Series: drm/i915/display: Dual refresh rate fastset fixes with VRR fastset URL : https://patchwork.freedesktop.org/series/122252/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13496_full -> Patchwork_122252v1_full

[Intel-gfx] [PATCH 1/1] drm/i915/selftests: Align igt_spinner_create_request with hangcheck

2023-08-10 Thread Jonathan Cavitt
Align igt_spinner_create_request with the hang_create_request implementation in selftest_hangcheck.c. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/selftests/igt_spinner.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/selftests/igt_spinner.c

[Intel-gfx] [PATCH 0/1] drm/i915/selftests: Align igt_spinner_create_request with hangcheck

2023-08-10 Thread Jonathan Cavitt
Align igt_spinner_create_request with the hang_create_request implementation in selftest_hangcheck.c. Signed-off-by: Jonathan Cavitt CC: Chris Wilson CC: Saurabhg Gupta CC: Andi Shyti CC: Stuart Summers CC: Nirmoy Das CC: Vinay Belgaumkar CC: Michal Winiarski CC: Matt Roper Jonathan

[Intel-gfx] [PULL] drm-intel-next

2023-08-10 Thread Rodrigo Vivi
Hi Dave and Daniel, This is likely our latest PR from drm-intel-next towards 6.6 drm-intel-next-2023-08-10: - Display SDVO fixes (Juha-Pekka, Jani) - Taking Stolen handling out of FBC code (Jouni) - Replace acronym with full platform name in defines (Dnyaneshwar, A\ nusha) - Display IRQ

[Intel-gfx] ✓ Fi.CI.BAT: success for DP2.0 SDP split support for DP-MST

2023-08-10 Thread Patchwork
== Series Details == Series: DP2.0 SDP split support for DP-MST URL : https://patchwork.freedesktop.org/series/122300/ State : success == Summary == CI Bug Log - changes from CI_DRM_13500 -> Patchwork_122300v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DP2.0 SDP split support for DP-MST

2023-08-10 Thread Patchwork
== Series Details == Series: DP2.0 SDP split support for DP-MST URL : https://patchwork.freedesktop.org/series/122300/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DP2.0 SDP split support for DP-MST

2023-08-10 Thread Patchwork
== Series Details == Series: DP2.0 SDP split support for DP-MST URL : https://patchwork.freedesktop.org/series/122300/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] ✓ Fi.CI.BAT: success for DSC misc fixes (rev7)

2023-08-10 Thread Patchwork
== Series Details == Series: DSC misc fixes (rev7) URL : https://patchwork.freedesktop.org/series/117662/ State : success == Summary == CI Bug Log - changes from CI_DRM_13500 -> Patchwork_117662v7 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DSC misc fixes (rev7)

2023-08-10 Thread Patchwork
== Series Details == Series: DSC misc fixes (rev7) URL : https://patchwork.freedesktop.org/series/117662/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DSC misc fixes (rev7)

2023-08-10 Thread Patchwork
== Series Details == Series: DSC misc fixes (rev7) URL : https://patchwork.freedesktop.org/series/117662/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update

2023-08-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update URL : https://patchwork.freedesktop.org/series/122286/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13500 -> Patchwork_122286v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update

2023-08-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update URL : https://patchwork.freedesktop.org/series/122286/ State : warning == Summary == Error: dim sparse failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update

2023-08-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update URL : https://patchwork.freedesktop.org/series/122286/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc:

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915: Avoid endless HPD poll detect loop via runtime suspend/resume (rev2)

2023-08-10 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Avoid endless HPD poll detect loop via runtime suspend/resume (rev2) URL : https://patchwork.freedesktop.org/series/122218/ State : success == Summary == CI Bug Log - changes from CI_DRM_13496_full ->

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Implement vblank synchronized MBUS join changes (rev2)

2023-08-10 Thread Patchwork
== Series Details == Series: drm/i915: Implement vblank synchronized MBUS join changes (rev2) URL : https://patchwork.freedesktop.org/series/122264/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13500 -> Patchwork_122264v2

[Intel-gfx] [PATCH 2/2] drm/i915/display: configure SDP split for DP MST

2023-08-10 Thread Vinod Govindapillai
Extend the SDP split configuration for the DP-MST Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c

[Intel-gfx] [PATCH 0/2] DP2.0 SDP split support for DP-MST

2023-08-10 Thread Vinod Govindapillai
Add DP2.0 SDP split support for DP-MST Vinod Govindapillai (2): drm/i915/display: streamline the dp audio config steps drm/i915/display: configure SDP split for DP MST drivers/gpu/drm/i915/display/intel_audio.c | 6 ++--- drivers/gpu/drm/i915/display/intel_audio.h | 3 +--

[Intel-gfx] [PATCH 1/2] drm/i915/display: streamline the dp audio config steps

2023-08-10 Thread Vinod Govindapillai
Combine dp audio config steps in to single a place from where intel_audio_compute_config is checked and SDP split decision is done. v2: combine different audio compute calls into one (Jani Nikula) Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_audio.c | 6 ++---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Implement vblank synchronized MBUS join changes (rev2)

2023-08-10 Thread Patchwork
== Series Details == Series: drm/i915: Implement vblank synchronized MBUS join changes (rev2) URL : https://patchwork.freedesktop.org/series/122264/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Implement vblank synchronized MBUS join changes (rev2)

2023-08-10 Thread Patchwork
== Series Details == Series: drm/i915: Implement vblank synchronized MBUS join changes (rev2) URL : https://patchwork.freedesktop.org/series/122264/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such

Re: [Intel-gfx] [PATCH] drm/i915: Implement vblank synchronized MBUS join changes

2023-08-10 Thread Almahallawy, Khaled
Thank You for the patch. This does the trick. No full modest because of Mbus joining Tested-by: Khaled Almahallawy On Thu, 2023-08-10 at 11:17 +0300, Stanislav Lisovskiy wrote: > Currently we can't change MBUS join status without doing a modeset, > because we are lacking mechanism to

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server

2023-08-10 Thread Greg KH
On Thu, Aug 10, 2023 at 12:29:48PM +0300, Jani Nikula wrote: > On Fri, 04 Aug 2023, Jani Nikula wrote: > > The current display probe is unable to differentiate between IVB Q and > > IVB D GT2 server, as they both have the same device id, but different > > subvendor and subdevice. This leads to

Re: [Intel-gfx] [PATCH 19/27] KVM: x86/mmu: Use page-track notifiers iff there are external users

2023-08-10 Thread Sean Christopherson
On Thu, Aug 10, 2023, Yan Zhao wrote: > On Thu, Aug 10, 2023 at 07:21:03AM +0800, Yan Zhao wrote: > > > Reading the value after acquiring mmu_lock ensures that both vCPUs will > > > see whatever > > > value "loses" the race, i.e. whatever written value is processed second > > > ('Y' in the > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP MST aux issue fix

2023-08-10 Thread Patchwork
== Series Details == Series: HDCP MST aux issue fix URL : https://patchwork.freedesktop.org/series/122267/ State : success == Summary == CI Bug Log - changes from CI_DRM_13500 -> Patchwork_122267v1 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP MST aux issue fix

2023-08-10 Thread Patchwork
== Series Details == Series: HDCP MST aux issue fix URL : https://patchwork.freedesktop.org/series/122267/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for HDCP MST aux issue fix

2023-08-10 Thread Patchwork
== Series Details == Series: HDCP MST aux issue fix URL : https://patchwork.freedesktop.org/series/122267/ State : warning == Summary == Error: dim sparse failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

Re: [Intel-gfx] [PATCH] drm/i915/gmch: fix build error var set but not used

2023-08-10 Thread Jani Nikula
On Thu, 10 Aug 2023, Wang Jinchao wrote: > When CONFIG_PNP is not defined, i915 will fail to compile with error bellow: > drivers/gpu/drm/i915/soc/intel_gmch.c:43:13: error: variable > ‘mchbar_addr’ set but not used > Fix it by surrounding variable declaration and assignment with ifdef > >

[Intel-gfx] [PATCH 16/20] drm/i915/dp: Separate out function to get compressed bpp with joiner

2023-08-10 Thread Ankit Nautiyal
Pull the code to get joiner constraints on maximum compressed bpp into separate function. Signed-off-by: Ankit Nautiyal Reviewed-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_dp.c | 54 ++--- 1 file changed, 30 insertions(+), 24 deletions(-) diff --git

[Intel-gfx] [PATCH 19/20] drm/i915/dp: Check if force_dsc_output_format is possible

2023-08-10 Thread Ankit Nautiyal
Currently for testing an output format with DSC, we just force the output format, without checking if it can be supported. This also creates an issue where there is a PCON which might need to convert from forced output format to the format to sink format. Signed-off-by: Ankit Nautiyal

[Intel-gfx] [PATCH 06/20] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

2023-08-10 Thread Ankit Nautiyal
As per Bsepc:49259, Bigjoiner BW check puts restriction on the compressed bpp for a given CDCLK, pixelclock in cases where Bigjoiner + DSC are used. Currently compressed bpp is computed first, and it is ensured that the bpp will work at least with the max CDCLK freq. Since the CDCLK is computed

[Intel-gfx] [PATCH 10/20] drm/i915/dp: Add functions to get min/max src input bpc with DSC

2023-08-10 Thread Ankit Nautiyal
Separate out functions for getting maximum and minimum input BPC based on platforms, when DSC is used. v2: Use HAS_DSC macro instead of platform check while getting min input bpc. (Stan) Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 35 +++-- 1

[Intel-gfx] [PATCH 15/20] drm/i915/dp: Add DSC BPC/BPP constraints while selecting pipe bpp with DSC

2023-08-10 Thread Ankit Nautiyal
Currently we check if the pipe_bpp selected is >= the min DSC bpc/bpp requirement. We do not check if it is <= the max DSC bpc/bpp requirement. Add checks for max DSC BPC/BPP constraints while computing the pipe_bpp when DSC is in use. v2: Fix the commit message. Signed-off-by: Ankit Nautiyal

[Intel-gfx] [PATCH 13/20] drm/i915/dp: Rename helper to get DSC max pipe_bpp

2023-08-10 Thread Ankit Nautiyal
The helper intel_dp_dsc_compute_bpp gives the maximum pipe bpp that is allowed with DSC. Rename the this to reflect that it returns max pipe bpp supported with DSC. Signed-off-by: Ankit Nautiyal Reviewed-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_dp.c | 8

[Intel-gfx] [PATCH 20/20] drm/i915: Query compressed bpp properly using correct DPCD and DP Spec info

2023-08-10 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Currently we seem to be using wrong DPCD register for reading compressed bpps, reading min/max input bpc instead of compressed bpp. Fix that, so that we now apply min/max compressed bpp limitations we get from DP Spec Table 2-157 DP v2.0 and/or correspondent DPCD

[Intel-gfx] [PATCH 18/20] drm/i915/dp: Check src/sink compressed bpp limit for edp

2023-08-10 Thread Ankit Nautiyal
Use checks for src and sink limits before computing compressed bpp for eDP. Signed-off-by: Ankit Nautiyal Reviewed-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_dp.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 12/20] drm/i915/dp: Avoid left shift of DSC output bpp by 4

2023-08-10 Thread Ankit Nautiyal
To make way for fractional bpp support, avoid left shifting the output_bpp by 4 in helper intel_dp_dsc_get_output_bpp. Signed-off-by: Ankit Nautiyal Reviewed-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_dp.c | 10 +++--- drivers/gpu/drm/i915/display/intel_dp_mst.c |

[Intel-gfx] [PATCH 17/20] drm/i915/dp: Get optimal link config to have best compressed bpp

2023-08-10 Thread Ankit Nautiyal
Currently, we take the max lane, rate and pipe bpp, to get the maximum compressed bpp possible. We then set the output bpp to this value. This patch provides support to have max bpp, min rate and min lanes, that can support the min compressed bpp. v2: -Avoid ending up with compressed bpp, same as

[Intel-gfx] [PATCH 11/20] drm/i915/dp: Check min bpc DSC limits for dsc_force_bpc also

2023-08-10 Thread Ankit Nautiyal
For DSC the min BPC is 8 for ICL+ and so the min pipe_bpp is 24. Check this condition for cases where bpc is forced by debugfs flag dsc_force_bpc. If the check fails, then WARN and ignore the debugfs flag. For MST case the pipe_bpp is already computed (hardcoded to be 24), and this check is not

[Intel-gfx] [PATCH 07/20] drm/i915/dp: Remove extra logs for printing DSC info

2023-08-10 Thread Ankit Nautiyal
DSC compressed bpp and slice counts are already getting printed at the end of dsc compute config. Remove extra logs. Signed-off-by: Ankit Nautiyal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_dp.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[Intel-gfx] [PATCH 09/20] drm/i915/dp: Avoid forcing DSC BPC for MST case

2023-08-10 Thread Ankit Nautiyal
For MST the bpc is hardcoded to 8, and pipe bpp to 24. So avoid forcing DSC bpc for MST case. v2: Warn and ignore the debug flag than to bail out. (Jani) v3: Fix dbg message to mention forced bpc instead of bpp. v4: Fix checkpatch longline warning. Signed-off-by: Ankit Nautiyal Reviewed-by:

[Intel-gfx] [PATCH 14/20] drm/i915/dp: Separate out functions for edp/DP for computing DSC bpp

2023-08-10 Thread Ankit Nautiyal
Refactor code to separate functions for eDP and DP for computing pipe_bpp/compressed bpp when DSC is involved. This will help to optimize the link configuration for DP later. v2: Fix checkpatch warning. Signed-off-by: Ankit Nautiyal Reviewed-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH 08/20] drm/display/dp: Fix the DP DSC Receiver cap size

2023-08-10 Thread Ankit Nautiyal
DP DSC Receiver Capabilities are exposed via DPCD 60h-6Fh. Fix the DSC RECEIVER CAP SIZE accordingly. Fixes: ffddc4363c28 ("drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT") Cc: Anusha Srivatsa Cc: Manasi Navare Cc: # v5.0+ Signed-off-by: Ankit Nautiyal

[Intel-gfx] [PATCH 03/20] drm/i915/dp_mst: Use output_format to get the final link bpp

2023-08-10 Thread Ankit Nautiyal
The final link bpp used to calculate the m_n values depend on the output_format. Though the output_format is set to RGB for MST case and the link bpp will be same as the pipe bpp, for the sake of semantics, lets calculate the m_n values with the link bpp, instead of pipe_bpp. Signed-off-by: Ankit

[Intel-gfx] [PATCH 05/20] drm/i915/dp: Update Bigjoiner interface bits for computing compressed bpp

2023-08-10 Thread Ankit Nautiyal
In Bigjoiner check for DSC, bigjoiner interface bits for DP for DISPLAY > 13 is 36 (Bspec: 49259). v2: Corrected Display ver to 13. v3: Follow convention for conditional statement. (Ville) v4: Fix check for display ver. (Ville) v5: Added note for 2 PPC. (Stan) Signed-off-by: Ankit Nautiyal

[Intel-gfx] [PATCH 04/20] drm/i915/dp: Use consistent name for link bpp and compressed bpp

2023-08-10 Thread Ankit Nautiyal
Currently there are many places where we use output_bpp for link bpp and compressed bpp. Lets use consistent naming: output_bpp : The intermediate value taking into account the output_format chroma subsampling. compressed_bpp : target bpp for the DSC encoder. link_bpp : final bpp used in the link.

[Intel-gfx] [PATCH 01/20] drm/i915/dp: Consider output_format while computing dsc bpp

2023-08-10 Thread Ankit Nautiyal
While using DSC the compressed bpp is computed assuming RGB output format. Consider the output_format and compute the compressed bpp during mode valid and compute config steps. For DP-MST we currently use RGB output format only, so continue using RGB while computing compressed bpp for MST case.

[Intel-gfx] [PATCH 00/20] DSC misc fixes

2023-08-10 Thread Ankit Nautiyal
This series is an attempt to address multiple issues with DSC, scattered in separate existing series. Patches 1-4 are DSC fixes from series to Handle BPC for HDMI2.1 PCON https://patchwork.freedesktop.org/series/107550/ Patches 5-6 are from series DSC fixes for Bigjoiner:

[Intel-gfx] [PATCH 02/20] drm/i915/dp: Move compressed bpp check with 420 format inside the helper

2023-08-10 Thread Ankit Nautiyal
Move the check for limiting compressed bite_per_pixel for 420,422 formats in the helper to compute bits_per_pixel. Signed-off-by: Ankit Nautiyal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_dp.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff

[Intel-gfx] [PATCH 1/2] drm/i915: Swap ggtt_vma during legacy cursor update

2023-08-10 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_cursor.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/drivers/gpu/drm/i915/display/intel_cursor.c index b342fad180ca..ab25f019eda1 100644 ---

[Intel-gfx] [PATCH 2/2] drm/i915: Handle legacy cursor update as normal update

2023-08-10 Thread Maarten Lankhorst
Abuse the vblank worker to make the changes as small as possible. We need a way to sync flip_done, but if we wait on flip_done, all async tests start failing. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_crtc.c| 21 ++--

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Fix Wa_22016122933 implementation

2023-08-10 Thread Andi Shyti
Hi Jonathan, pushed in drm-intel-gt-next. I added two links to the commit logs: the first one refers to this series, while the second refers to the series sent to CI which includes the rebase conflict fix. Hope this is fine. Thanks, Andi On Tue, Aug 01, 2023 at 08:32:39AM -0700, Jonathan

Re: [Intel-gfx] [PATCH 4/4] drm/i915/irq: move all PCH irq postinstall calls to display code

2023-08-10 Thread Jani Nikula
On Tue, 08 Aug 2023, Rodrigo Vivi wrote: > On Tue, Aug 08, 2023 at 06:53:31PM +0300, Jani Nikula wrote: >> Unify on making the calls from display code. Need to add an if ladder in >> gen8_de_irq_postinstall() for now, but the function looks like it could >> be overall be better split by platform.

[Intel-gfx] ✓ Fi.CI.IGT: success for Test conflict fix for "Fix Wa_22016122933 implementation" (rev5)

2023-08-10 Thread Patchwork
== Series Details == Series: Test conflict fix for "Fix Wa_22016122933 implementation" (rev5) URL : https://patchwork.freedesktop.org/series/122099/ State : success == Summary == CI Bug Log - changes from CI_DRM_13492_full -> Patchwork_122099v5_full

Re: [Intel-gfx] [PATCH v3 4/6] drm/i915/panelreplay: Initializaton and compute config for panel replay

2023-08-10 Thread Hogander, Jouni
On Fri, 2023-07-28 at 18:16 +0530, Animesh Manna wrote: > Modify existing PSR implementation to enable panel replay feature of > DP 2.0 > which is similar to PSR feature of EDP panel. There is different DPCD > address to check panel capability compare to PSR and vsc sdp header > is different. > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/irq: cleanups (rev2)

2023-08-10 Thread Patchwork
== Series Details == Series: drm/i915/irq: cleanups (rev2) URL : https://patchwork.freedesktop.org/series/122165/ State : success == Summary == CI Bug Log - changes from CI_DRM_13492_full -> Patchwork_122165v2_full Summary ---

Re: [Intel-gfx] [PATCH v3 6/6] drm/i915/panelreplay: enable/disable panel replay

2023-08-10 Thread Hogander, Jouni
On Fri, 2023-07-28 at 18:16 +0530, Animesh Manna wrote: > TRANS_DP2_CTL register is programmed to enable panel replay from > source > and sink is enabled through panel replay dpcd configuration address. > > Bspec: 1407940617 > > v1: Initial version. > v2: > - Use pr_* flags instead psr_* flags.

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix potential null pointer deref in GuC 'steal id' test

2023-08-10 Thread Andi Shyti
On Mon, Aug 07, 2023 at 12:46:46PM -0700, John Harrison wrote: > On 8/3/2023 06:28, Andi Shyti wrote: > > Hi John, > > > > On Wed, Aug 02, 2023 at 11:49:40AM -0700, john.c.harri...@intel.com wrote: > > > From: John Harrison > > > > > > It was noticed that if the very first 'stealing' request

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server

2023-08-10 Thread Jani Nikula
On Fri, 04 Aug 2023, Jani Nikula wrote: > The current display probe is unable to differentiate between IVB Q and > IVB D GT2 server, as they both have the same device id, but different > subvendor and subdevice. This leads to the latter being misidentified as > the former, and should just end up

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server

2023-08-10 Thread Jani Nikula
On Wed, 09 Aug 2023, Luca Coelho wrote: > Looks good to me. > > Reviewed-by: Luca Coelho Thanks for the reviews, pushed to drm-intel-next. BR, Jani. > > -- > Cheers, > Luca. -- Jani Nikula, Intel Open Source Graphics Center

[Intel-gfx] [PULL] drm-misc-next

2023-08-10 Thread Thomas Zimmermann
Hi Dave and Daniel, this is the PR for drm-misc-next; presumably the final one before -rc6. Half of the patches update fbdev drivers to make them use the provided helpers and macros. The big feature is nouveau's support for tracking virtual memory on the GPU, which enables Vulkan sparse binding

[Intel-gfx] [PATCH] drm/i915: Implement vblank synchronized MBUS join changes

2023-08-10 Thread Stanislav Lisovskiy
Currently we can't change MBUS join status without doing a modeset, because we are lacking mechanism to synchronize those with vblank. However then this means that we can't do a fastset, if there is a need to change MBUS join state. Fix that by implementing such change. We already call

Re: [Intel-gfx] [PATCH] video/hdmi: convert *_infoframe_init() functions to void

2023-08-10 Thread Maxime Ripard
Hi, On Tue, Aug 08, 2023 at 11:02:45AM -0700, Nikita Zhandarovich wrote: > Four hdmi_*_infoframe_init() functions that initialize different > types of hdmi infoframes only return the default 0 value, contrary to > their descriptions. Yet these functions are still unnecessarily checked > against

[Intel-gfx] [PATCH 4/4] drm/i915/hdcp: Adjust timeout for read in DPMST Scenario

2023-08-10 Thread Suraj Kandpal
Ignore the timeout for dpmst hdcp scenario. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c index

[Intel-gfx] [PATCH 3/4] drm/i915/hdcp: Send the correct aux for DPMST HDCP scenario

2023-08-10 Thread Suraj Kandpal
Up until now we were sending the base aux stored in dig_port which is not correct as this causes an issue when monitor is connected via a DPMST hub causing it to be remote hence we end up seeing AUX failures so let's send the remote aux in case of DPMST. Signed-off-by: Suraj Kandpal ---

[Intel-gfx] [PATCH 2/4] drm/i915/hdcp: Propagate aux info in DP HDCP functions

2023-08-10 Thread Suraj Kandpal
We were propagating dig_port info to dp hdcp2 specific functions. Let us clean that up and send drm_dp_aux instead n functions: intel_dp_hdcp2_wait_for_msg, get_receiver_id_list_rx_info, intel_dp_hdcp2_read_rx_status this optimises mst scenarios where aux ends up being remote and not stored in

[Intel-gfx] [PATCH 1/4] drm/i915/hdcp: Use intel_connector argument in intel_hdcp_shim

2023-08-10 Thread Suraj Kandpal
Update intel_hdcp_shim funcs specifically read_2_2_message, write_2_2_message and config_stream_type to use intel_connector argument instead of intel_digital_port as this will help in getting correct aux later for dp mst scenarios also already hdcp funcs derive digital_port from connector and then

  1   2   >