On Tue, 31 Oct 2023 at 15:23, Dave Airlie wrote:
>
> On Tue, 31 Oct 2023 at 15:09, Borah, Chaitanya Kumar
> wrote:
> >
> > Hello Mario,
> >
> > This is Chaitanya from the Linux graphics team in Intel.
> >
> > We are seeing a build issue in drm-tip[1]
>
> Sorry that was a mismerge from me, let me
On Tue, 31 Oct 2023 at 15:09, Borah, Chaitanya Kumar
wrote:
>
> Hello Mario,
>
> This is Chaitanya from the Linux graphics team in Intel.
>
> We are seeing a build issue in drm-tip[1]
Sorry that was a mismerge from me, let me go fix it for summon someone else.
Dave.
Hello Mario,
This is Chaitanya from the Linux graphics team in Intel.
We are seeing a build issue in drm-tip[1]
``
CALLscripts/checksyscalls.sh
DESCEND objtool
INSTALL
== Series Details ==
Series: drm/i915: Initialize residency registers earlier
URL : https://patchwork.freedesktop.org/series/125780/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13814 -> Patchwork_125780v1
Summary
---
== Series Details ==
Series: drm/i915: use ref_tracker library in i915
URL : https://patchwork.freedesktop.org/series/125770/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13814 -> Patchwork_125770v1
Summary
---
== Series Details ==
Series: drm/i915: use ref_tracker library in i915
URL : https://patchwork.freedesktop.org/series/125770/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: use ref_tracker library in i915
URL : https://patchwork.freedesktop.org/series/125770/
State : warning
== Summary ==
Error: dim checkpatch failed
79cf476bf7f5 drm/i915: Replace custom intel runtime_pm tracker with ref_tracker
library
-:441:
== Series Details ==
Series: drm/i915: Improve BW management on MST links (rev8)
URL : https://patchwork.freedesktop.org/series/125490/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13814 -> Patchwork_125490v8
Summary
If we skip RC6 init, residency registers do not get initialized,
leading to incorrect drpc debug output. Also release the wakeref
since we skip intel_rc6_enable() entirely when rc6_supported is false.
Fixes: 78d0b4552c37 ("drm/i915/gt: Use RC6 residency types as arguments to
residency
== Series Details ==
Series: drm/i915: Improve BW management on MST links (rev8)
URL : https://patchwork.freedesktop.org/series/125490/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Improve BW management on MST links (rev8)
URL : https://patchwork.freedesktop.org/series/125490/
State : warning
== Summary ==
Error: dim checkpatch failed
5162d630ca8b drm/i915/dp_mst: Fix race between connector registration and setup
fec65fed5b98
== Series Details ==
Series: drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence
(rev3)
URL : https://patchwork.freedesktop.org/series/125160/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13813 -> Patchwork_125160v3
On Fri, Oct 27, 2023 at 06:59:15AM -, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/mtl: Add Wa_22016670082
> URL : https://patchwork.freedesktop.org/series/125574/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_13786_full ->
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: c503e3eec382ac708ee7adf874add37b77c5d312 Add linux-next specific
files for 20231030
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202310052201.anvbpgpr-...@intel.com
https
Hi Dorcas,
On Fri, Oct 27, 2023 at 08:47:45PM +0300, Dorcas AnonoLitunya wrote:
> Removes space after opening parenthesis.
>
> Fixes the checkpatch.pl error:
> ERROR: space prohibited after that opening parenthesis '('
>
> Signed-off-by: Dorcas AnonoLitunya
> ---
>
Beside reusing existing code, the main advantage of ref_tracker is
tracking per instance of wakeref. It allows also to catch double
put.
On the other side we lose information about the first acquire and
the last release, but the advantages outweigh it.
Signed-off-by: Andrzej Hajda
Reviewed-by:
Track every intel_gt_pm_get() until its corresponding release in
intel_gt_pm_put() by returning a cookie to the caller for acquire that
must be passed by on released. When there is an imbalance, we can see who
either tried to free a stale wakeref, or who forgot to free theirs.
v2: track recently
This patchset replaces custom tracking solution
with ref_tracker library. This is follow-up of the
work from patchset[1]. Core part is already merged
and present in drm-tip. This is actually re-base of [1]
with minor fixes for code introduced later.
[1]:
Enable DSC using the DSC AUX device stored for this purpose in the
connector. For clarity add separate functions to enable/disable the
decompression, since these sequences will diverge more in follow-up
patches that also enable/disable DSC passthrough and on MST do the
actual enabling/disabling
At the moment modesetting a stream CRTC will fail if the stream's BW
along with the current BW of all the other streams on the same MST link
is above the total BW of the MST link. Make the BW sharing more dynamic
by trying to reduce the link bpp of one or more streams on the MST link
in this case.
From: Stanislav Lisovskiy
Currently we seem to be using wrong DPCD register for reading
compressed bpps, reading min/max input bpc instead of compressed bpp.
Fix that, so that we now apply min/max compressed bpp limitations we
get from DP Spec Table 2-157 DP v2.0 and/or correspondent DPCD
Factor out a helper to clear the pipe update flags, used by a follow-up
patch to modeset an MST topology.
v2:
- Move the intel_crtc_needs_modeset() check to the callers. (Ville)
Reviewed-by: Stanislav Lisovskiy (v1)
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_display.c |
Enabling / disabling DSC decompression in the branch device downstream
of the source may reset the whole branch device. To avoid this while the
streams are still active, force a modeset on all CRTC/ports connected to
this branch device.
v2:
- Check the CRTC state for each connector in the
After the previous patch the BW limits on the whole MST topology will be
checked after computing the state for all the streams in the topology.
Accordingly remove the check during the stream's encoder compute config
step, to prevent failing an atomic commit due to a BW limit, if this can
be
Enable DSC decompression for all streams. In particular atm if a sink is
connected to a last branch device that is downstream of the first branch
device connected to the source, decompression is not enabled for it.
Similarly it's not enabled if the sink supports this with the last
branch device
Enable passing through DSC streams to the sink in last branch devices.
v2:
- Fix the DPCD register address while setting/clearing the passthrough
flag.
Reviewed-by: Stanislav Lisovskiy
Reviewed-by: Ville Syrjälä
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp.c | 22
Enable/disable the DSC decompression in the sink/branch from the MST
encoder hooks. This prepares for an upcoming patch toggling DSC for each
stream as needed, but for now keeps the current behavior, as DSC is only
enabled for the first MST stream.
Reviewed-by: Stanislav Lisovskiy
Signed-off-by:
The Synaptics MST hubs expose some sink EDID modes with a reduced HBLANK
period, presumedly to save BW, which the hub expands before forwarding
the stream to the sink. In particular a 4k mode with a standard CVT
HBLANK period is exposed with either a CVT reduced blank RBv1,v2 (80,
160 pixel) or a
Disable the FEC ready flag in the sink during a disabling modeset.
Reviewed-by: Stanislav Lisovskiy
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_ddi.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git
As required by the DP standard wait for the sink to detect the FEC
decode enabling symbol sent by the source.
There is a difference between SST and MST when the source enables
the FEC encoding: on SST this happens only after enabling the
transcoder, whereas on MST it happens already after
Rename intel_ddi_disable_fec_state() to intel_ddi_disable_fec(), for
symmetry with intel_ddi_enable_fec().
Reviewed-by: Stanislav Lisovskiy
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_ddi.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
Atm the DSC PPS SDP will stay enabled after enabling and disabling DSC.
This leaves an output blank after switching off DSC on it. Make sure the
SDP is disabled for an uncompressed output.
v2:
- Disable the SDP already during output disabling. (Ville)
Cc: Ville Syrjälä
Reviewed-by: Stanislav
Add the missing DSC compression disabling step for MST streams,
similarly to how this is done for SST outputs.
Reviewed-by: Stanislav Lisovskiy
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
If an MST stream is modeset, its state must be checked along all the
other streams on the same MST link, for instance to resolve a BW
overallocation of a non-sink MST port or to make sure that the FEC is
enabled/disabled the same way for all these streams.
To prepare for that this patch adds all
Atm the DSC PPS SDP is programmed only if the first stream is compressed
and then it's programmed only for the first stream. This left all other
compressed streams blank. Program the SDP for all streams.
Reviewed-by: Stanislav Lisovskiy
Signed-off-by: Imre Deak
---
A follow-up MST patch will need to specify the total BW allocation
overhead, prepare for that here by passing the amount of overhead
to intel_link_compute_m_n(), keeping the existing behavior.
v2:
- Fix passing the correct crtc_state->fec_enable param in
intel_dp_mst_compute_link_config() /
The Synaptics MST branch devices support DSC decompression on all their
output ports, provided that they are last branch devices (with their
output ports connected to the sinks). The Thinkpad 40B0 TBT dock for
instance has two such branch devices, a secondary one connected to one
of the output
Add a quirk for Synaptics MST hubs, which require a workaround - at leat
on i915 - for some modes, on which the hub applies HBLANK expansion.
These modes will only work by enabling DSC decompression for them, a
follow-up patch will do this in i915.
v2:
- Fix the quirk name in its DocBook
Atm, the BW allocated for an MST stream doesn't take into account the
DSC control symbol (EOC) and data alignment overhead on the local (first
downstream) MST link (reflected by the data M/N/TU values) and - besides
the above overheads - the FEC symbol overhead on 8b/10b remote
(after a downstream
Add the DPCD flag to enable DSC passthrough in a last branch device,
used in a follow-up i915 patch.
Also add a flag to detect HBLANK expansion support in a branch device,
used by a workaround in a follow-up i915 patch.
Cc: Lyude Paul
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Stanislav
Add helpers drivers can use to calculate the BW allocation overhead -
due to SSC, FEC, DSC and data alignment on symbol cycles - and the
channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On
128b/132b links the FEC overhead is part of the coding efficiency, so
not accounted for in
Enable FEC in crtc_state, as soon as it's known it will be needed by
DSC. This fixes the calculation of BW allocation overhead, in case DSC
is enabled by falling back to it during the encoder compute config
phase (vs. enabling FEC due to DSC being enabled on other streams).
v2:
- Enable FEC only
A follow-up patch will add up all the overheads on a DP link, where it
makes more sense to specify each overhead factor in terms of the added
overhead amount vs. the reciprocal remainder (of usable BW remaining
after deducting the overhead). Prepare for that here, keeping the
existing behavior.
Factor out a helper to check the atomic state for one MST topology
manager, returning the MST port where the BW limit check has failed.
This will be used in a follow-up patch by the i915 driver to improve the
BW sharing between MST streams.
Cc: Lyude Paul
Cc: dri-de...@lists.freedesktop.org
From: Ville Syrjälä
The current code does '(bpp << 4) / 16' in the MST PBN
calculation, but that is just the same as 'bpp' so the
DSC codepath achieves absolutely nothing. Fix it up so that
the fractional part of the bpp value is actually used instead
of truncated away. 64*1006 has enough zero
drm_dp_mst_atomic_check_mgr() should check for BW limitation starting
from sink ports continuing towards the root port, so that drivers can
use the @failing_port returned to resolve a BW overallocation in an
ideal way. For instance from streams A,B,C in a topology A,B going
through @failing_port
Add drm_dp_mst_port_downstream_of_parent() required by the i915
driver in a follow-up patch to resolve a BW overallocation of MST
streams going through a given MST port.
Cc: Lyude Paul
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Lyude Paul
Signed-off-by: Imre Deak
---
After drm_connector_init() is called the connector is visible to the
rest of the kernel via the drm_mode_config::connector_list. Make
sure that the DSC AUX device and capabilities are setup by that time.
Another race condition is adding the connector to the connector list
before
This is v4 of [1] with the following changes:
- Fix a race condition between connector setup and registration
(added patch 1).
- Rename DRM_DP_OVERHEAD_SSC to DRM_DP_OVERHEAD_SSC_REF_CLK
(Ville, patch 9).
- Fix setting crtc_state->fec_enable, once crtc_state->port_clock
required for it is
On 25.10.2023 18:47, Dnyaneshwar Bhadane wrote:
> Implemented workaround for XeLPM+
> BSpec: 51762
>
> Signed-off-by: Dnyaneshwar Bhadane
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Balasubramani Vivekanandan
Regards,
Bala
>
>
On 27/10/2023 18:38, Tvrtko Ursulin wrote:
On 27/10/2023 18:28, Harshit Mogalapalli wrote:
When i915 perf interface is not available dereferencing it will lead to
NULL dereferences.
As returning -ENOTSUPP is pretty clear return when perf interface is not
available.
Fixes: 2fec539112e8
On Wed, 18 Oct 2023, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Since we're asked to disable FECSTALL_DIS_DPTSTREAM_DPTTG when
> the transcoder is disabled it seems prudent to also clear it
> when enabliing the transcoder w/o FEC, just in case
> someone else left it enabled by mistake.
>
>
On Wed, 18 Oct 2023, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Follow the bspec sequqnece more closely and clear ACT sent just
^ sequence
> before triggering the allocation. Can't see why we'd want to
> deviate from the spec sequence here.
>
> Signed-off-by: Ville
On Wed, 18 Oct 2023, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Follow the bspec sequqnece more closely and clear ACT sent just
> before triggering the allocation. Can't see why we'd want to
> deviate from the spec sequence here.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
On Wed, 18 Oct 2023, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Bspec tells us that we should disable the transcoder before
> deleting the payload. Looks like this has been reversed since
> MST support was added.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
>
On Wed, 18 Oct 2023, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The DP modeset sequence asks us to disable TRANSCONF before clearing
> the FECSTALL_DIS_DPTSTREAM_DPTTG bit, although we are still asked
> to wait for the transcoder to stop only after both steps have
> been done.
>
>
> -Original Message-
> From: Jani Nikula
> Sent: Monday, October 30, 2023 5:21 PM
> To: Borah, Chaitanya Kumar ; intel-
> g...@lists.freedesktop.org
> Cc: Syrjala, Ville ; sta...@vger.kernel.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Support HBR3 rate with C10
> phy and eDP
We are preparing for Xe driver. Xe driver doesn't have i915_sw_fence
implementation. Lets drop i915_sw_fence usage from display code and
use dma_fence interfaces directly.
For this purpose stack dma fences from related objects into new plane
state. Drm_gem_plane_helper_prepare_fb can be used for
On Wed, 18 Oct 2023, Chaitanya Kumar Borah
wrote:
> eDP specification supports HBR3 link rate since v1.4a. Moreover,
> C10 phy can support HBR3 link rate for both DP and eDP. Therefore,
> do not clamp the supported rates for eDP at 6.75Gbps.
>
> Cc:
>
> BSpec: 70073 74224
>
> Signed-off-by:
On Mon, 30 Oct 2023, "Garg, Nemesa" wrote:
> Hi Jani,
>
> Sometimes there is an issue of black screen on the display due to number of
> errors like invalid input buffers (black), some issue with display
> programming (no planes enabled, LUTs zeroed) which means some problem with
> DE. Upon
Hi Jani,
Sometimes there is an issue of black screen on the display due to number of
errors like invalid input buffers (black), some issue with display programming
(no planes enabled, LUTs zeroed) which means some problem with DE. Upon
detection following steps can be taken:
1.Print in dmesg
> -Original Message-
> From: Manna, Animesh
> Sent: Wednesday, October 11, 2023 4:40 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: dri-de...@lists.freedesktop.org; Manna, Animesh
> ; Hogander, Jouni ;
> Murthy, Arun R ; Nikula, Jani
>
> Subject: [PATCH v7 6/6] drm/i915/panelreplay:
> -Original Message-
> From: Manna, Animesh
> Sent: Tuesday, October 17, 2023 1:52 PM
> To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org
> Cc: dri-de...@lists.freedesktop.org; Hogander, Jouni
> ; Nikula, Jani
> Subject: RE: [PATCH v7 4/6] drm/i915/panelreplay: Enable panel replay
> -Original Message-
> From: Ville Syrjälä
> Sent: Friday, October 27, 2023 6:51 PM
> To: Manna, Animesh
> Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani
> Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/dsb: DSB code refactoring
>
> On Fri, Oct 27, 2023 at 05:59:45AM +, Manna,
On Tue, Oct 24, 2023 at 04:09:05AM +0300, Imre Deak wrote:
> Enable FEC in crtc_state, as soon as it's known it will be needed by
> DSC. This fixes the calculation of BW allocation overhead, in case DSC
> is enabled by falling back to it during the encoder compute config
> phase (vs. enabling FEC
On Mon, Oct 30, 2023 at 09:29:30AM +0200, Lisovskiy, Stanislav wrote:
> On Fri, Oct 27, 2023 at 05:53:17PM +0300, Imre Deak wrote:
> > On Fri, Oct 27, 2023 at 05:45:30PM +0300, Lisovskiy, Stanislav wrote:
> > > On Tue, Oct 24, 2023 at 04:09:20AM +0300, Imre Deak wrote:
> > > > Enable DSC
On Fri, Oct 27, 2023 at 05:53:17PM +0300, Imre Deak wrote:
> On Fri, Oct 27, 2023 at 05:45:30PM +0300, Lisovskiy, Stanislav wrote:
> > On Tue, Oct 24, 2023 at 04:09:20AM +0300, Imre Deak wrote:
> > > Enable DSC decompression for all streams. In particular atm if a sink is
> > > connected to a last
67 matches
Mail list logo
