Re: [Intel-gfx] [PATCH 1/3] drm: Add Adaptive Sync SDP logging

2023-11-23 Thread kernel test robot
Hi Mitul, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Mitul-Golani/drm-Add-Adaptive-Sync-SDP-logging/20231123-220931 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch

Re: [Intel-gfx] [PATCH] drm/i915/irq: Improve error logging for unexpected DE Misc interrupts

2023-11-23 Thread Borah, Chaitanya Kumar
> -Original Message- > From: Intel-gfx On Behalf Of Rahul > Rameshbabu > Sent: Thursday, November 23, 2023 11:27 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; dri-de...@lists.freedesktop.org; > Rahul Rameshbabu > Subject: [Intel-gfx] [PATCH] drm/i915/irq: Improve error

[Intel-gfx] [PATCH] drm/i915/display: do not use cursor size reduction on MTL

2023-11-23 Thread Andrzej Hajda
Cursor size reduction is not supported since MTL. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_display_device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h

Re: [Intel-gfx] [PATCH v2 0/4] eventfd: simplify signal helpers

2023-11-23 Thread Christian Brauner
On Wed, 22 Nov 2023 13:48:21 +0100, Christian Brauner wrote: > Hey everyone, > > This simplifies the eventfd_signal() and eventfd_signal_mask() helpers > significantly. They can be made void and not take any unnecessary > arguments. > > I've added a few more simplifications based on Sean's

Re: [Intel-gfx] [PATCH 1/3] drm: Add Adaptive Sync SDP logging

2023-11-23 Thread kernel test robot
Hi Mitul, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Mitul-Golani/drm-Add-Adaptive-Sync-SDP-logging/20231123-220931 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/1] drm/i915/pxp: Add missing tag for Wa_14019159160

2023-11-23 Thread Patchwork
== Series Details == Series: series starting with [v2,1/1] drm/i915/pxp: Add missing tag for Wa_14019159160 URL : https://patchwork.freedesktop.org/series/126784/ State : success == Summary == CI Bug Log - changes from CI_DRM_13913_full -> Patchwork_126784v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev6)

2023-11-23 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev6) URL : https://patchwork.freedesktop.org/series/123803/ State : success == Summary == CI Bug Log - changes from CI_DRM_13912_full -> Patchwork_123803v6_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915/psr: Don't send a NULL VSC SDP

2023-11-23 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/psr: Don't send a NULL VSC SDP URL : https://patchwork.freedesktop.org/series/126779/ State : success == Summary == CI Bug Log - changes from CI_DRM_13912_full -> Patchwork_126779v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Add support for atomic async page-flip

2023-11-23 Thread Patchwork
== Series Details == Series: drm: Add support for atomic async page-flip URL : https://patchwork.freedesktop.org/series/126776/ State : success == Summary == CI Bug Log - changes from CI_DRM_13912_full -> Patchwork_126776v1_full Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for eventfd: simplify signal helpers (rev2)

2023-11-23 Thread Patchwork
== Series Details == Series: eventfd: simplify signal helpers (rev2) URL : https://patchwork.freedesktop.org/series/120668/ State : success == Summary == CI Bug Log - changes from CI_DRM_13912_full -> Patchwork_120668v2_full Summary

Re: [Intel-gfx] linux-next: manual merge of the drm-intel tree with the amdgpu tree

2023-11-23 Thread Stephen Rothwell
Hi all, On Mon, 20 Nov 2023 12:28:18 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the drm-intel tree got a conflict in: > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > > between commits: > > a58555359a9f ("drm/amd/display: Fix DSC not Enabled on Direct

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/psr: Fix unsigned expression compared with zero

2023-11-23 Thread Patchwork
== Series Details == Series: drm/i915/psr: Fix unsigned expression compared with zero URL : https://patchwork.freedesktop.org/series/126748/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13912_full -> Patchwork_126748v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/irq: Improve error logging for unexpected DE Misc interrupts

2023-11-23 Thread Patchwork
== Series Details == Series: drm/i915/irq: Improve error logging for unexpected DE Misc interrupts URL : https://patchwork.freedesktop.org/series/126843/ State : success == Summary == CI Bug Log - changes from CI_DRM_13918 -> Patchwork_126843v1

Re: [Intel-gfx] [PATCH v5 00/20] remove I2C_CLASS_DDC support

2023-11-23 Thread Wolfram Sang
On Thu, Nov 23, 2023 at 10:40:20AM +0100, Heiner Kallweit wrote: > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. > Class-based device auto-detection is a legacy mechanism and shouldn't > be used in new

[Intel-gfx] ✗ Fi.CI.BAT: failure for Update vtotal based on closest possible panel timings

2023-11-23 Thread Patchwork
== Series Details == Series: Update vtotal based on closest possible panel timings URL : https://patchwork.freedesktop.org/series/126839/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13918 -> Patchwork_126839v1 Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable Adaptive Sync SDP Support for DP

2023-11-23 Thread Patchwork
== Series Details == Series: Enable Adaptive Sync SDP Support for DP URL : https://patchwork.freedesktop.org/series/126829/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13917 -> Patchwork_126829v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Adaptive Sync SDP Support for DP

2023-11-23 Thread Patchwork
== Series Details == Series: Enable Adaptive Sync SDP Support for DP URL : https://patchwork.freedesktop.org/series/126829/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2 0/4] eventfd: simplify signal helpers

2023-11-23 Thread Jens Axboe
On 11/22/23 5:48 AM, Christian Brauner wrote: > Hey everyone, > > This simplifies the eventfd_signal() and eventfd_signal_mask() helpers > significantly. They can be made void and not take any unnecessary > arguments. > > I've added a few more simplifications based on Sean's suggestion. > >

Re: [Intel-gfx] [PULL] drm-misc-next

2023-11-23 Thread Daniel Vetter
On Thu, Nov 23, 2023 at 01:58:50PM +0100, Maxime Ripard wrote: > Hi, > > Here's this week drm-misc-next PR. > > It's been fairly calm, but there's one big change: the IMG GPU driver is > now merged! > > Maxime > > drm-misc-next-2023-11-23: > drm-misc-next for 6.8: > > UAPI Changes: > >

Re: [Intel-gfx] [PULL] drm-intel-next

2023-11-23 Thread Daniel Vetter
On Thu, Nov 23, 2023 at 09:03:59PM +0200, Jani Nikula wrote: > > Hi Dave & Sima - > > The first i915 feature pull towards v6.8. > > The one thing to single out are the major DP MST, UHBR, and DSC > bandwidth management improvements from Imre. > > Alas, they also need to be singled out because

[Intel-gfx] ✓ Fi.CI.BAT: success for Prepare intel_fb for Xe (rev7)

2023-11-23 Thread Patchwork
== Series Details == Series: Prepare intel_fb for Xe (rev7) URL : https://patchwork.freedesktop.org/series/126507/ State : success == Summary == CI Bug Log - changes from CI_DRM_13917 -> Patchwork_126507v7 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Prepare intel_fb for Xe (rev7)

2023-11-23 Thread Patchwork
== Series Details == Series: Prepare intel_fb for Xe (rev7) URL : https://patchwork.freedesktop.org/series/126507/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prepare intel_fb for Xe (rev7)

2023-11-23 Thread Patchwork
== Series Details == Series: Prepare intel_fb for Xe (rev7) URL : https://patchwork.freedesktop.org/series/126507/ State : warning == Summary == Error: dim checkpatch failed b6b023df5953 drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c 5c4b02abe533 drm/i915/display: Convert

[Intel-gfx] [RFC 1/1] drm/i915/display: Update vtotal based on closest possible panel timings

2023-11-23 Thread Mitul Golani
For edp VRR supported panel, vtotal should be updated based on closest available panel timings and adjusted_mode panel configuration, instead of rounding up to nearest possible integer. This is to facilitate user about the refreh rate they're going to get when it is slightly off from list of

[Intel-gfx] [RFC 0/1] Update vtotal based on closest possible panel timings

2023-11-23 Thread Mitul Golani
For edp VRR supported panel, vtotal should be updated based on closest available panel timings and adjusted_mode panel configuration, instead of rounding up to nearest possible integer. This is to facilitate user about the refreh rate they're going to get when it is slightly off from list of

[Intel-gfx] [PULL] drm-intel-next

2023-11-23 Thread Jani Nikula
Hi Dave & Sima - The first i915 feature pull towards v6.8. The one thing to single out are the major DP MST, UHBR, and DSC bandwidth management improvements from Imre. Alas, they also need to be singled out because there are a number of updates in drm core and other drivers merged via

Re: [Intel-gfx] [PATCH 0/4] drm/i915: Fix LUT rounding

2023-11-23 Thread Ville Syrjälä
On Tue, Nov 21, 2023 at 11:51:10AM +0100, Maxime Ripard wrote: > On Mon, Nov 20, 2023 at 04:30:53PM +0200, Ville Syrjälä wrote: > > On Fri, Oct 13, 2023 at 04:13:58PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > The current LUT rounding is generating weird results. Adjust >

[Intel-gfx] [PULL] drm-intel-fixes

2023-11-23 Thread Jani Nikula
Hi Dave & Sima - drm-intel-fixes-2023-11-23: drm/i915 fixes for v6.7-rc3: - Fix race between DP MST connectore registration and setup - Fix GT memory leak on probe error path BR, Jani. The following changes since commit 98b1cc82c4affc16f5598d4fa14b1858671b2263: Linux 6.7-rc2 (2023-11-19

Re: [Intel-gfx] [PATCH v9 0/4] drm: Add support for atomic async page-flip

2023-11-23 Thread André Almeida
Em 23/11/2023 13:24, Simon Ser escreveu: Thanks! This iteration of the first 3 patches LGTM, I've pushed them to drm-misc-next. I've made two adjustments to make checkpatch.pl happy: Thank you! - s/uint64_t/u64/ - Fix indentation for a drm_dbg_atomic() ops :)

Re: [Intel-gfx] [PATCH v9 0/4] drm: Add support for atomic async page-flip

2023-11-23 Thread Simon Ser
Thanks! This iteration of the first 3 patches LGTM, I've pushed them to drm-misc-next. I've made two adjustments to make checkpatch.pl happy: - s/uint64_t/u64/ - Fix indentation for a drm_dbg_atomic()

Re: [Intel-gfx] [PATCH 1/3] drm: Add Adaptive Sync SDP logging

2023-11-23 Thread Nautiyal, Ankit K
On 11/23/2023 7:32 PM, Mitul Golani wrote: Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 15 +

Re: [Intel-gfx] [PATCH v5 1/4] pwm: rename pwm_apply_state() to pwm_apply_cansleep()

2023-11-23 Thread Lee Jones
On Sat, 18 Nov 2023, Sean Young wrote: > In order to introduce a pwm api which can be used from atomic context, > we will need two functions for applying pwm changes: > > int pwm_apply_cansleep(struct pwm *, struct pwm_state *); > int pwm_apply_atomic(struct pwm *, struct pwm_state

[Intel-gfx] [PATCH 2/3] drm/i915/display/: Add Read/Write support for Adaptive Sync SDP

2023-11-23 Thread Mitul Golani
Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_dp.c | 118

[Intel-gfx] [PATCH 3/3] drm/i915/display/:Compute and enable daptive Sync SDP

2023-11-23 Thread Mitul Golani
Add necessary functions and register definitions to enable and compute AS SDP data. The new `intel_dp_compute_as_sdp` function computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR). Signed-off-by: Mitul Golani ---

[Intel-gfx] [PATCH 1/3] drm: Add Adaptive Sync SDP logging

2023-11-23 Thread Mitul Golani
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 15 + include/drm/display/drm_dp.h| 1 +

[Intel-gfx] [PATCH 0/3] Enable Adaptive Sync SDP Support for DP

2023-11-23 Thread Mitul Golani
An Adaptive Sync SDP allows a DP protocol converter to forward Adaptive Sync video with minimal buffering overhead within the converter. An Adaptive-Sync-capable DP protocol converter indicates its support by setting the related bit in the DPCD register. Computes AS SDP values based on the

Re: [Intel-gfx] [PATCH v2 2/4] eventfd: simplify eventfd_signal()

2023-11-23 Thread Christian Brauner
> > * eventfd_signal - Adds @n to the eventfd counter. > > This still refers to @n here, and in patch 4. Fixed and folded. Thanks!

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Fix Wa_22016670082 (rev3)

2023-11-23 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Fix Wa_22016670082 (rev3) URL : https://patchwork.freedesktop.org/series/126740/ State : success == Summary == CI Bug Log - changes from CI_DRM_13914 -> Patchwork_126740v3 Summary ---

Re: [Intel-gfx] [PATCH v2 1/4] i915: make inject_virtual_interrupt() void

2023-11-23 Thread Christian Brauner
> > + if (!vgpu->msi_trigger) > > + return; > > + eventfd_signal(vgpu->msi_trigger, 1); > > } > > I think it's a little simpler to write as > if (vgpu->msi_trigger) > eventfd_signal(vgpu->msi_trigger, 1); Good point. I folded that suggestion into the patch.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Fix Wa_22016670082 (rev3)

2023-11-23 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Fix Wa_22016670082 (rev3) URL : https://patchwork.freedesktop.org/series/126740/ State : warning == Summary == Error: dim checkpatch failed 400788308645 drm/i915/mtl: Fix Wa_22016670082 -:14: ERROR:BAD_SIGN_OFF: Unrecognized email address:

[Intel-gfx] [PULL] drm-misc-next

2023-11-23 Thread Maxime Ripard
Hi, Here's this week drm-misc-next PR. It's been fairly calm, but there's one big change: the IMG GPU driver is now merged! Maxime drm-misc-next-2023-11-23: drm-misc-next for 6.8: UAPI Changes: Cross-subsystem Changes: Core Changes: - Drop deprecated drm_kms_helper.edid_firmware module

Re: [Intel-gfx] [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file

2023-11-23 Thread Hogander, Jouni
On Tue, 2023-11-14 at 10:20 +, Hogander, Jouni wrote: > On Mon, 2023-11-13 at 22:32 +0200, Juha-Pekka Heikkila wrote: > > Here created intel_dpt_common.c to hold intel_dpt_configure which > > is > > needed for both xe and i915. > > For the whole series: > > Reviewed-by: Jouni Högander

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix null pointer dereference in intel_dp_aux_wait_done and intel_dp_aux_xfer

2023-11-23 Thread Ville Syrjälä
On Thu, Nov 23, 2023 at 06:04:31PM +0800, Kunwu Chan wrote: > kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. When "intel_dp->aux.name" is NULL, > these error messages will trigger the null pointer dereference issue. How did you reach that

[Intel-gfx] [PULL] drm-misc-fixes

2023-11-23 Thread Maarten Lankhorst
Hi Dave, Daniel, Lots of small fixes for various drivers. Cheers, ~Maarten drm-misc-fixes-2023-11-23: Fixes for v6.7-rc3: - Panel fixes for innolux and auo,b101uan08.3 panel. - Fix ivpu MMIO reset. - AST fix on connetor disconnection. - nouveau gsp fix. - rockchip color fix. - Fix

Re: [Intel-gfx] [PATCH v5 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-23 Thread Andi Shyti
Hi Heiner, On Thu, Nov 23, 2023 at 10:40:35AM +0100, Heiner Kallweit wrote: > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. > Class-based device auto-detection is a legacy mechanism and shouldn't > be

[Intel-gfx] [PATCH v5 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[Intel-gfx] [PATCH v5 00/20] remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

Re: [Intel-gfx] [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-23 Thread Thomas Zimmermann
Hi Am 23.11.23 um 09:34 schrieb Heiner Kallweit: On 23.11.2023 09:19, Thomas Zimmermann wrote: Hi Am 23.11.23 um 08:16 schrieb Heiner Kallweit: On 23.11.2023 07:56, Thomas Zimmermann wrote: Hi Am 20.11.23 um 22:46 schrieb Heiner Kallweit: After removal of the legacy EEPROM driver and

Re: [Intel-gfx] [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
On 23.11.2023 09:19, Thomas Zimmermann wrote: > Hi > > Am 23.11.23 um 08:16 schrieb Heiner Kallweit: >> On 23.11.2023 07:56, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 20.11.23 um 22:46 schrieb Heiner Kallweit: After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Implement sel_fetch disable for planes (rev5)

2023-11-23 Thread Hogander, Jouni
Hello, Possible regression here are not related to my patch. Both of them are seen already earlier: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13913/bat-adlp-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-seque...@pipe-d-dp-5.html

Re: [Intel-gfx] [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-23 Thread Thomas Zimmermann
Hi Am 23.11.23 um 08:16 schrieb Heiner Kallweit: On 23.11.2023 07:56, Thomas Zimmermann wrote: Hi Am 20.11.23 um 22:46 schrieb Heiner Kallweit: After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.