Re: [Intel-gfx] [PATCH] drm/i915: Enable GSE interrupt on BDW+

On 12/04/2015 08:59 PM, Jani Nikula wrote: > On Fri, 04 Dec 2015, Daniel Vetter wrote: >> On Wed, Dec 02, 2015 at 12:17:10AM +0200, ville.syrj...@linux.intel.com >> wrote: >>> From: Ville Syrjälä >>> >>> We've never actually enabled or unmasked

Re: [Intel-gfx] [PATCH 1/2] acpi/video: Load the module even if ACPI is disabled

...@intel.com Cc: Rafael J. Wysocki r...@rjwysocki.net Cc: Len Brown l...@kernel.org Cc: linux-a...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: sta...@vger.kernel.org For both patches: Acked-by: Aaron Lu aaron...@intel.com Thanks, Aaron --- drivers/acpi/video.c | 10 ++ 1 file

[Intel-gfx] [PATCH] ACPI / video: update the skip case for acpi_video_device_in_dod

...@hotmail.es Cc: sta...@vger.kernel.org Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/acpi/video.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index 8b844931b936..c72e79d2c5ad 100644 --- a/drivers/acpi/video.c +++ b

Re: [Intel-gfx] [PATCH] ACPI / video: update the skip case for acpi_video_device_in_dod

On 12/15/2014 05:02 PM, Jani Nikula wrote: On Mon, 15 Dec 2014, Aaron Lu aaron...@intel.com wrote: If the firmware has declared more than 8 video output devices, and the one that control the internal panel's backlight is listed after the first 8 output devices, the _DOD will not include it due

Re: [Intel-gfx] [PATCH] drm/i915/opregion: work around buggy firmware that provides 8+ output devices

On 12/08/2014 07:04 PM, Jani Nikula wrote: On Mon, 08 Dec 2014, Jani Nikula jani.nik...@linux.intel.com wrote: On Mon, 08 Dec 2014, Aaron Lu aaron...@intel.com wrote: We have a new bug report that has the same problem: https://bugzilla.kernel.org/show_bug.cgi?id=88941 The posted patch solves

Re: [Intel-gfx] [PATCH] drm/i915/opregion: work around buggy firmware that provides 8+ output devices

this should be properly handled, that would be great. Thanks, Aaron On 03/04/2014 10:45 PM, Daniel Vetter wrote: On Wed, Feb 19, 2014 at 04:59:06PM +0800, Aaron Lu wrote: On 02/19/2014 03:33 PM, Matthew Garrett wrote: On Wed, Feb 19, 2014 at 03:31:29PM +0800, Aaron Lu wrote: DID2 is in system

Re: [Intel-gfx] ACPI/i915: Cannot configure display brightness on Dell Latitude E6440

On 09/26/2014 03:58 AM, Rafael J. Wysocki wrote: On Thursday, September 25, 2014 11:15:35 AM Aaron Lu wrote: Hi Hans, Thanks for following up and explaining the situation to Pali. On 09/25/2014 02:21 AM, Pali Rohár wrote: On Wednesday 24 September 2014 16:34:21 Hans de Goede wrote: Ok, so

[Intel-gfx] [PATCH] ACPI / i915: Update the condition to ignore firmware backlight change request

interface is not in use and the ACPI backlight interface is broken, we ignore the requests; oterwise, we keep processing them. Reference: https://lkml.org/lkml/2014/9/23/854 Reported-and-tested-by: Pali Rohár pali.ro...@gmail.com Cc: sta...@vger.kernel.org # v3.16 and later Signed-off-by: Aaron Lu

Re: [Intel-gfx] ACPI/i915: Cannot configure display brightness on Dell Latitude E6440

Hi Hans, Thanks for following up and explaining the situation to Pali. On 09/25/2014 02:21 AM, Pali Rohár wrote: On Wednesday 24 September 2014 16:34:21 Hans de Goede wrote: Ok, so the dell-laptop interface is just an obsolete wrapper around the i915 opregion code, which shows that the right

[Intel-gfx] [PATCH v3] drm/i915/opregion: ignore firmware requests for backlight change

anton.gubar...@gmail.com Signed-off-by: Aaron Lu aaron...@intel.com Acked-by: Jani Nikula jani.nik...@intel.com --- v3: - use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL; - add inline to stub as suggested by Rafael. drivers/acpi/video.c | 3 ++- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v3] drm/i915/opregion: ignore firmware requests for backlight change

On 07/08/2014 08:48 PM, Rafael J. Wysocki wrote: On Tuesday, July 08, 2014 04:09:25 PM Aaron Lu wrote: Some Thinkpad laptops' firmware will initiate a backlight level change request through operation region on the events of AC plug/unplug, but since we are not using firmware's interface to do

[Intel-gfx] [PATCH v2] drm/i915/opregion: ignore firmware requests for backlight change

anton.gubar...@gmail.com Signed-off-by: Aaron Lu aaron...@intel.com Acked-by: Jani Nikula jani.nik...@intel.com --- v2: add a debug message when ignoring opregion request as suggested by Jani Nikula. drivers/acpi/video.c | 3 ++- drivers/gpu/drm/i915/intel_opregion.c | 9

Re: [Intel-gfx] [PATCH v2] drm/i915/opregion: ignore firmware requests for backlight change

On 07/07/2014 09:01 PM, Rafael J. Wysocki wrote: On Monday, July 07, 2014 03:43:51 PM Aaron Lu wrote: Some Thinkpad laptops' firmware will initiate a backlight level change request through operation region on the events of AC plug/unplug, but since we are not using firmware's interface to do

Re: [Intel-gfx] [PATCH v2] drm/i915/opregion: ignore firmware requests for backlight change

On 07/07/2014 08:51 PM, Rafael J. Wysocki wrote: On Monday, July 07, 2014 03:43:51 PM Aaron Lu wrote: Some Thinkpad laptops' firmware will initiate a backlight level change request through operation region on the events of AC plug/unplug, but since we are not using firmware's interface to do

Re: [Intel-gfx] [PATCH] drm/i915/opregion: ignore firmware requests for backlight change

On 06/25/2014 07:08 PM, Jani Nikula wrote: On Tue, 24 Jun 2014, Aaron Lu aaron...@intel.com wrote: Some Thinkpad laptops' firmware will initiate a backlight level change request through operation region on the events of AC plug/unplug, but since we are not using firmware's interface to do

[Intel-gfx] [PATCH] drm/i915/opregion: ignore firmware requests for backlight change

anton.gubar...@gmail.com Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/acpi/video.c | 3 ++- drivers/gpu/drm/i915/intel_opregion.c | 7 +++ include/acpi/video.h | 2 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/video.c b

Re: [Intel-gfx] video: X sets brightness to zero after resume

On 06/12/2014 08:42 PM, Kalle Valo wrote: Hi Aaron, after your commit 0e9f81d3b7c (ACPI / video: Add systems that should favour native backlight interface) I have had an regression that every time after resume the display brightness has been set to zero and I need to manually set it to

Re: [Intel-gfx] Sluggish performance after resume//Re: Bug Report - [Acer Aspire V5-122P] Unable to adjust screen brightness

On 06/11/2014 06:54 AM, Ben Widawsky wrote: On Tue, Jun 10, 2014 at 08:59:32PM +0100, Lewis Toohey wrote: On 10 June 2014 17:58, Ben Widawsky b...@bwidawsk.net wrote: On Tue, Jun 10, 2014 at 01:33:51PM +0800, Aaron Lu wrote: +Ben Widawsky Daniel Vetter On 06/09/2014 03:38 PM, Lewis Toohey

[Intel-gfx] Sluggish performance after resume//Re: Bug Report - [Acer Aspire V5-122P] Unable to adjust screen brightness

+Ben Widawsky Daniel Vetter On 06/09/2014 03:38 PM, Lewis Toohey wrote: On 3 June 2014 02:22, Aaron Lu aaron...@intel.com wrote: On 05/30/2014 09:12 PM, Lewis Toohey wrote: Aaron I am in the process of performing this bisection, however, I need a bit of advice. I have got a mix

[Intel-gfx] [PATCH v3] drm/i915: restore backlight precision when converting from opregion

On 05/04/2014 03:22 PM, Chris Wilson wrote: 32b * 32b = 32b n = (u64)level * freq; to avoid overflow as you claim. Updated patch to fix this problem is here, thanks! From a0f41a92d949c814c203672ff7efe219a90ca6df Mon Sep 17 00:00:00 2001 From: Aaron Lu aaron...@intel.com Date: Mon, 28 Apr

[Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

On 04/28/2014 09:41 PM, Daniel Vetter wrote: 64bit divisions won't compile on 32bit. You need one of the DO_DIV macros, or whatever they're called again. I pain, I know ;-) Thanks for the correction, here is an updated patch :-) From: Aaron Lu aaron...@intel.com Date: Mon, 28 Apr 2014 11:02:52

Re: [Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

On 05/04/2014 03:22 PM, Chris Wilson wrote: On Sun, May 04, 2014 at 03:16:05PM +0800, Aaron Lu wrote: On 04/28/2014 09:41 PM, Daniel Vetter wrote: 64bit divisions won't compile on 32bit. You need one of the DO_DIV macros, or whatever they're called again. I pain, I know ;-) Thanks

Re: [Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

On 05/04/2014 06:41 PM, Chris Wilson wrote: On Sun, May 04, 2014 at 03:31:01PM +0800, Aaron Lu wrote: On 05/04/2014 03:22 PM, Chris Wilson wrote: Also this still has the same rounding error as before. I didn't get this, care to explain? The calculation you use, truncates, rather than say

[Intel-gfx] [PATCH] drm/i915: restore backlight precision when converting from opregion

=72491 Reported-and-tested-by: Nico Schottelius nico-bugzilla.kernel@schottelius.org Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/gpu/drm/i915/intel_panel.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drm/i915/opregion: work around buggy firmware that provides 8+ output devices

On 02/19/2014 03:33 PM, Matthew Garrett wrote: On Wed, Feb 19, 2014 at 03:31:29PM +0800, Aaron Lu wrote: DID2 is in system memory region and has some assigned value like 0x400 when we read it. For this case it is easy since there is only one output device that is of type LVDS so we can match

Re: [Intel-gfx] [PATCH v4] ACPI / video: Add systems that should favour native backlight interface

On 02/18/2014 11:46 PM, Mika Westerberg wrote: On Tue, Feb 18, 2014 at 04:22:27PM +0100, Rafael J. Wysocki wrote: On Tuesday, February 18, 2014 02:31:46 PM Takashi Iwai wrote: At Tue, 18 Feb 2014 12:34:42 +0200, Mika Westerberg wrote: On Tue, Feb 18, 2014 at 01:54:20PM +0800, Aaron Lu wrote

Re: [Intel-gfx] [PATCH] drm/i915/opregion: work around buggy firmware that provides 8+ output devices

On 02/13/2014 08:03 PM, Daniel Vetter wrote: On Thu, Feb 13, 2014 at 11:08 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Feb 13, 2014 at 05:10:25PM +0800, Aaron Lu wrote: On 02/12/2014 06:31 PM, Chris Wilson wrote: On Wed, Feb 12, 2014 at 11:05:40AM +0800, Aaron Lu wrote

[Intel-gfx] [PATCH v4] ACPI / video: Add systems that should favour native backlight interface

HP ProBook 4340s: Reported-and-tested-by: Vladimir Sherenkov a_12...@mail.ru Reference: http://redmine.russianfedora.pro/issues/1258 HP EliteBook/ProBook 2013 models, ZBook and some others: Provided-by: Takashi Iwai ti...@suse.de Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/acpi

Re: [Intel-gfx] [PATCH] drm/i915/opregion: work around buggy firmware that provides 8+ output devices

On 02/12/2014 06:31 PM, Chris Wilson wrote: On Wed, Feb 12, 2014 at 11:05:40AM +0800, Aaron Lu wrote: The ACPI table on ASUS UX302LA has more than 8 output devices under the graphics controller device node. The problem is, the real active output device, the LCD panel, is listed the last

[Intel-gfx] [PATCH] drm/i915/opregion: work around buggy firmware that provides 8+ output devices

firmware by replacing the last entry in CADL array with the one that has _BCM control method. There is no specific reason why the last entry is picked instead of others. Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=70241 Signed-off-by: Aaron Lu aaron...@intel.com Reported-and-tested

Re: [Intel-gfx] [PATCH v3] ACPI / video: Add systems that should favor native backlight interface

On 01/21/2014 11:17 AM, Matthew Garrett wrote: On Tue, 2014-01-21 at 10:24 +0800, Aaron Lu wrote: On 01/20/2014 09:34 PM, Matthew Garrett wrote: On Mon, 2014-01-20 at 16:12 +0800, Aaron Lu wrote: 1 remove the win8 OSI check, I've seen win7 laptops that also needs to have only the GPU

Re: [Intel-gfx] [PATCH] ACPI / video: Use native backlight control interface by default

On Thu, Dec 05, 2013 at 08:50:21AM +0100, Daniel Vetter wrote: On Thu, Dec 5, 2013 at 3:32 AM, Matthew Garrett mj...@srcf.ucam.org wrote: We had problems with the Intel backlight driver the last time we tried this, so let's push this through their tree for testing first? Cc:ed intel-gfx and

[Intel-gfx] [PATCH v2 rebased] ACPI / video: Add systems that should favor native backlight interface

backlight interface From: Aaron Lu aaron...@intel.com Date: Thu, 21 Nov 2013 11:24:48 +0800 Some system's ACPI video backlight control interface is broken and the native backlight control interface should be used by default. This patch sets the use_native_backlight parameter to true for those

[Intel-gfx] [PATCH v2] ACPI / video: Add systems that should favor native backlight interface

?id=63811 Dell Inspiron 7520: Reported-by: Rinat Ibragimov ibragimovri...@mail.ru Acer Aspire 5733Z: Reported-by: sov.i...@mail.ru Reference: https://bugzilla.kernel.org/show_bug.cgi?id=62941 Signed-off-by: Aaron Lu aaron...@intel.com --- v2: Add Acer Aspire 5733Z, see bug #62941; Remove Inspiron

Re: [Intel-gfx] [Acer Aspire V5-573G] Black screen on boot due to low brightness setting

On 11/14/2013 02:24 PM, Jani Nikula wrote: Hi Mario - On Wed, 13 Nov 2013, Mario Kleinsasser mario.kleinsasser+linux-ker...@gmail.com wrote: In the last three weeks I've narrowed down the bug described in the subject through Ubuntu launchpad. My new Laptop (Acer Aspire V5-573G) with new

Re: [Intel-gfx] [PATCH v5 0/4] Fix Win8 backlight issue

On 10/28/2013 04:09 PM, Jani Nikula wrote: On Mon, 28 Oct 2013, Aaron Lu aaron...@intel.com wrote: +static int __init video_set_use_native_backlight(const struct dmi_system_id *d) +{ +use_native_backlight = true; +return 0; +} Hi Aaron, it might be beneficial to make

Re: [Intel-gfx] [PATCH v5 0/4] Fix Win8 backlight issue

= { + DMI_MATCH(DMI_SYS_VENDOR, Dell Inc.), + DMI_MATCH(DMI_PRODUCT_VERSION, Inspiron 7520), + }, + }, Thanks Igor, updated patch follows: From: Aaron Lu aaron...@intel.com Subject: [PATCH] ACPI / video: Add systems that should favour native backlight

Re: [Intel-gfx] [PATCH v5 0/4] Fix Win8 backlight issue

On 10/16/2013 07:33 AM, Rafael J. Wysocki wrote: On Friday, October 11, 2013 09:27:42 PM Aaron Lu wrote: v5: 1 Introduce video.use_native_backlight module parameter and set its value to false by default as suggested by Rafael. For Win8 systems which have broken ACPI video backlight

[Intel-gfx] [PATCH v5 1/4] backlight: introduce backlight_device_registered

. avoid register its own on Win8 systems). Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/video/backlight/backlight.c | 31 +++ include/linux/backlight.h | 4 2 files changed, 35 insertions(+) diff --git a/drivers/video/backlight/backlight.c b

[Intel-gfx] [PATCH v5 2/4] ACPI / video: seperate backlight control and event interface

and/or event delivery functionality can be easily added once needed. Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/acpi/video.c | 434 +-- 1 file changed, 245 insertions(+), 189 deletions(-) diff --git a/drivers/acpi/video.c b/drivers/acpi

[Intel-gfx] [PATCH v5 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

there are systems that don't work well with this approach, a parameter for video module named use_native_backlight is introduced and has the value of false by default. For users who have a broken ACPI video backlight interface, video.use_native_backlight=1 is needed in kernel cmdline. Signed-off-by: Aaron

[Intel-gfx] [PATCH v5 4/4] thinkpad-acpi: fix handle locate for video and query of _BCL

the handle of a video output device node, which is child of the located video controller node from tpacpi_acpi_handle_locate. The two fix are necessary for some Thinkpad models to emit notification on backlight hotkey press as a result of evaluation of _BCL. Signed-off-by: Aaron Lu aaron

Re: [Intel-gfx] [PATCH v4 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

On 10/10/2013 08:59 PM, Rafael J. Wysocki wrote: On Thursday, October 10, 2013 09:02:55 AM Aaron Lu wrote: On 10/10/2013 08:29 AM, Rafael J. Wysocki wrote: On Tuesday, October 08, 2013 02:40:00 PM Aaron Lu wrote: According to Matthew Garrett, Windows 8 leaves backlight control up

Re: [Intel-gfx] [PATCH v4 1/4] backlight: introduce backlight_device_registered

On 10/10/2013 08:25 AM, Rafael J. Wysocki wrote: On Tuesday, October 08, 2013 02:39:58 PM Aaron Lu wrote: Introduce a new API for modules to query if a specific type of backlight device has been registered. This is useful for some backlight device provider module(e.g. ACPI video) to know

Re: [Intel-gfx] [PATCH v4 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

On 10/10/2013 08:29 AM, Rafael J. Wysocki wrote: On Tuesday, October 08, 2013 02:40:00 PM Aaron Lu wrote: According to Matthew Garrett, Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest

Re: [Intel-gfx] [PATCH v4 1/4] backlight: introduce backlight_device_registered

On 10/10/2013 12:29 PM, Jani Nikula wrote: On Thu, 10 Oct 2013, Aaron Lu aaron...@intel.com wrote: On 10/10/2013 08:25 AM, Rafael J. Wysocki wrote: On Tuesday, October 08, 2013 02:39:58 PM Aaron Lu wrote: +bool backlight_device_registered(enum backlight_type type) +{ + bool found = false

[Intel-gfx] [PATCH v4 1/4] backlight: introduce backlight_device_registered

. avoid register its own on Win8 systems). Signed-off-by: Aaron Lu aaron...@intel.com Tested-by: Igor Gnatenko i.gnatenko.br...@gmail.com Tested-by: Yves-Alexis Perez cor...@debian.org Tested-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/video/backlight/backlight.c | 31

[Intel-gfx] [PATCH v4 0/4] Fix Win8 backlight issue

exists. Patch 4/4 fixes some problems in thinkpad-acpi module. Technically, patch 2/4 is not required to fix the issue here. So if you think it is not necessary, I can remove it from the series. Aaron Lu (4): backlight: introduce backlight_device_registered ACPI / video: seperate backlight

[Intel-gfx] [PATCH v4 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

to keep ACPI video's backlight interface, the existing kernel cmdline option acpi_backlight=video can be used. Signed-off-by: Aaron Lu aaron...@intel.com Tested-by: Igor Gnatenko i.gnatenko.br...@gmail.com Tested-by: Yves-Alexis Perez cor...@debian.org Tested-by: Mika Westerberg mika.westerb

[Intel-gfx] [PATCH v4 2/4] ACPI / video: seperate backlight control and event interface

and/or event delivery functionality can be easily added once needed. Signed-off-by: Aaron Lu aaron...@intel.com Tested-by: Igor Gnatenko i.gnatenko.br...@gmail.com Tested-by: Yves-Alexis Perez cor...@debian.org Tested-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/acpi/video.c | 434

Re: [Intel-gfx] [PATCH v3 0/4] Fix Win8 backlight issue

:47 +0800, Aaron Lu wrote: v3: 1 Add a new patch 4/4 to fix some problems in thinkpad-acpi module; 2 Remove unnecessary function acpi_video_unregister introduced in patch 2/3 as pointed out by Jani Nikula. v2: v1 has the subject of Rework ACPI video driver and is posted here

Re: [Intel-gfx] [PATCH v3 4/4] thinkpad-acpi: fix handle locate for video and query of _BCL

On Wed, Sep 25, 2013 at 04:58:39PM -0300, Henrique de Moraes Holschuh wrote: On Tue, 24 Sep 2013, Aaron Lu wrote: locate handle for ACPI video by HID, the problem is, ACPI video node doesn't really have HID defined(i.e. no _HID control method is defined ACPI video is supposed to attach

Re: [Intel-gfx] [PATCH v3 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

On Wed, Sep 25, 2013 at 07:53:13PM +0200, Rafael J. Wysocki wrote: On Tuesday, September 24, 2013 05:47:31 PM Aaron Lu wrote: According to Matthew Garrett, Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence

[Intel-gfx] [PATCH v3 0/4] Fix Win8 backlight issue

video's backlight interface if: 1 Kernel cmdline option acpi_backlight=video is not given; 2 This is a Win8 system; 3 Native backlight control interface exists. Technically, patch 2/3 is not required to fix the issue here. So if you think it is not necessary, I can remove it from the series. Aaron Lu

[Intel-gfx] [PATCH v3 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

to keep ACPI video's backlight interface, the existing kernel cmdline option acpi_backlight=video can be used. Signed-off-by: Aaron Lu aaron...@intel.com Tested-by: Igor Gnatenko i.gnatenko.br...@gmail.com Tested-by: Yves-Alexis Perez cor...@debian.org --- drivers/acpi/internal.h | 5

[Intel-gfx] [PATCH v3 2/4] ACPI / video: seperate backlight control and event interface

and/or event delivery functionality can be easily added once needed. Signed-off-by: Aaron Lu aaron...@intel.com Tested-by: Igor Gnatenko i.gnatenko.br...@gmail.com Tested-by: Yves-Alexis Perez cor...@debian.org --- drivers/acpi/video.c | 434

[Intel-gfx] [PATCH v3 4/4] thinkpad-acpi: fix handle locate for video and query of _BCL

the handle of a video output device node, which is child of the located video controller node from tpacpi_acpi_handle_locate. The two fix are necessary for some Thinkpad models to emit notification on backlight hotkey press as a result of evaluation of _BCL. Signed-off-by: Aaron Lu aaron

Re: [Intel-gfx] [PATCH v3 2/4] ACPI / video: seperate backlight control and event interface

On 09/24/2013 05:47 PM, Aaron Lu wrote: The backlight control and event delivery functionality provided by ACPI video module is mixed together and registered all during video device enumeration time. As a result, the two functionality are also removed together on module unload time

Re: [Intel-gfx] [PATCH v2 0/3] Fix Win8 backlight issue

On 09/18/2013 08:36 PM, Igor Gnatenko wrote: On Wed, 2013-09-18 at 20:31 +0800, Aaron Lu wrote: On 09/18/2013 02:30 PM, Igor Gnatenko wrote: On Wed, 2013-09-18 at 09:03 +0800, Aaron Lu wrote: On 09/17/2013 09:34 PM, Igor Gnatenko wrote: Aaron, how about fix indicator on ThinkPads ? Can you

Re: [Intel-gfx] [PATCH v2 3/3] ACPI / video: Do not register backlight if win8 and native interface exists

On 09/20/2013 04:36 PM, Jani Nikula wrote: On Tue, 17 Sep 2013, Aaron Lu aaron...@intel.com wrote: According to Matthew Garrett, Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest that the Intel

Re: [Intel-gfx] [PATCH v2 0/3] Fix Win8 backlight issue

On 09/18/2013 02:30 PM, Igor Gnatenko wrote: On Wed, 2013-09-18 at 09:03 +0800, Aaron Lu wrote: On 09/17/2013 09:34 PM, Igor Gnatenko wrote: Aaron, how about fix indicator on ThinkPads ? Can you please describe the problem in detail, is it that when you adjust brightness level through

[Intel-gfx] [PATCH v2 0/3] Fix Win8 backlight issue

is not required to fix the issue here. So if you think it is not necessary, I can remove it from the series. Apply on top of v3.12-rc1. Aaron Lu (3): backlight: introduce backlight_device_registered ACPI / video: seperate backlight control and event interface ACPI / video: Do not register

[Intel-gfx] [PATCH v2 2/3] ACPI / video: seperate backlight control and event interface

and/or event delivery functionality can be easily added once needed. Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/acpi/video.c | 451 ++- include/acpi/video.h | 2 + 2 files changed, 264 insertions(+), 189 deletions(-) diff --git a/drivers

Re: [Intel-gfx] [PATCH v2 0/3] Fix Win8 backlight issue

On 09/17/2013 09:34 PM, Igor Gnatenko wrote: On Tue, 2013-09-17 at 17:23 +0800, Aaron Lu wrote: v1 has the subject of Rework ACPI video driver and is posted here: http://lkml.org/lkml/2013/9/9/74 Since the objective is really to fix Win8 backlight issues, I changed the subject in this version

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

On Wed, Sep 11, 2013 at 11:45:19AM +0300, Jani Nikula wrote: On Wed, 11 Sep 2013, Aaron Lu aaron...@intel.com wrote: It is possible the i915 driver decides not to register a backlight interface for the graphics card for some reason(memory allocation failed or it knows the native control

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

, Daniel On Mon, Sep 09, 2013 at 04:42:20PM +0800, Aaron Lu wrote: According to Matthew Garrett, Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest that the Intel driver for Windows [8] doesn't

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

On Tue, Sep 10, 2013 at 09:23:04PM +0200, Rafael J. Wysocki wrote: On Tuesday, September 10, 2013 04:53:40 PM Jani Nikula wrote: On Mon, 09 Sep 2013, Rafael J. Wysocki r...@sisk.pl wrote: On Monday, September 09, 2013 05:21:18 PM Daniel Vetter wrote: On Mon, Sep 09, 2013 at 02:16:12PM

[Intel-gfx] [PATCH 0/2] Rework ACPI video driver

problems with i915's backlight control interface, a module param is introduced to give user a chance to select if they want to remove ACPI video's backlight control interface. The param is set to false by default. Aaron Lu (2): ACPI / video: seperate backlight control and event interface ACPI / video

[Intel-gfx] [PATCH 1/2] ACPI / video: seperate backlight control and event interface

functionality alone so the function acpi_video_remove_notify_handler is not introduced, it can be easily added when needed. Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/acpi/video.c | 451 ++- include/acpi/video.h | 2 + 2 files changed

[Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

from earlier patches of Matthew Garrett, Chun-Yi Lee and Seth Forshee and is heavily based on two patches from Rafael: https://lkml.org/lkml/2013/7/17/720 https://lkml.org/lkml/2013/7/24/806 Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/acpi/internal.h | 2 ++ drivers/acpi/video.c

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

On 09/09/2013 07:44 PM, Igor Gnatenko wrote: On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index f466980..75fba17 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

On 09/10/2013 01:13 PM, Igor Gnatenko wrote: On Tue, 2013-09-10 at 11:27 +0800, Aaron Lu wrote: On 09/09/2013 07:44 PM, Igor Gnatenko wrote: On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index f466980

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

On 09/10/2013 01:22 PM, Igor Gnatenko wrote: On Tue, 2013-09-10 at 13:16 +0800, Aaron Lu wrote: On 09/10/2013 01:13 PM, Igor Gnatenko wrote: On Tue, 2013-09-10 at 11:27 +0800, Aaron Lu wrote: On 09/09/2013 07:44 PM, Igor Gnatenko wrote: On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: diff

Re: [Intel-gfx] [PATCH] drm/i915: try not to lose backlight CBLV precision

room for rounding errors. Use DIV_ROUND_UP for scaling back to CBLV to get back to the same values that were passed to _BCM, presuming the _BCM simply uses bclp = (in * 255) / 100 for scaling to BCLP. Reference: https://gist.github.com/aaronlu/6314920 Reported-by: Aaron Lu aaron

Re: [Intel-gfx] Backlight control only in the kernel?

On 08/07/2013 03:44 PM, Borislav Petkov wrote: On Sun, Jun 09, 2013 at 07:01:36PM -0400, Matthew Garrett wrote: Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have coincided with a range of vendors adding Windows 8 checks to their

Re: [Intel-gfx] i915 backlight

On 08/01/2013 04:07 PM, Borislav Petkov wrote: On Wed, Jul 31, 2013 at 11:16:52PM +0200, Rafael J. Wysocki wrote: Does reverting efaa14c help? Nope. But see my other reply to Aaron. Assume you have specified to use intel_backlight in xorg.conf, does booting with

Re: [Intel-gfx] i915 backlight

On 2 August 2013 08:00, Aaron Lu aaron...@intel.com wrote: On 08/01/2013 04:07 PM, Borislav Petkov wrote: On Wed, Jul 31, 2013 at 11:16:52PM +0200, Rafael J. Wysocki wrote: Does reverting efaa14c help? Nope. But see my other reply to Aaron. Assume you have specified to use intel_backlight

Re: [Intel-gfx] i915 backlight

On 08/01/2013 04:12 PM, Borislav Petkov wrote: On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: Can you please run acpi_listen and then press the Fn-Fx key, see if the events are correctly sent out? Like this? # acpi_listen video/brightnessdown BRTDN 0087 video

Re: [Intel-gfx] i915 backlight

On 08/01/2013 05:07 PM, Aaron Lu wrote: On 08/01/2013 04:12 PM, Borislav Petkov wrote: On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: Can you please run acpi_listen and then press the Fn-Fx key, see if the events are correctly sent out? Like this? # acpi_listen video

Re: [Intel-gfx] [Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

On 07/31/2013 08:01 AM, Rafael J. Wysocki wrote: On Thursday, July 18, 2013 02:16:09 AM Rafael J. Wysocki wrote: On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have

Re: [Intel-gfx] i915 backlight

On 08/01/2013 12:36 AM, Borislav Petkov wrote: On Wed, Jul 31, 2013 at 06:22:52PM +0200, Borislav Petkov wrote: Dudes, has anyone already reported this (happens on Linus of today + tip/master): Oh, one more thing: I can't control the backlight anymore on this x230 with the Fn-Fx keys and

Re: [Intel-gfx] Linux 3.11-rc2 [backlight] [ASUS N56VZ]

On 07/30/2013 03:36 AM, * SAMÍ * wrote: Hi Rafael, did you commit a full revert? Because I am experiencing quite weird things in rc3. Do we have a bug opened to discuss about it? Yes we have: https://bugzilla.kernel.org/show_bug.cgi?id=52951 I'll look into this issue. Thanks, Aaron

Re: [Intel-gfx] Linux 3.11-rc2 (acpi backlight, revert)

On Thu, Jul 25, 2013 at 9:00 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Monday, July 22, 2013 09:54:21 PM Rafael J. Wysocki wrote: On Monday, July 22, 2013 11:11:54 AM Linus Torvalds wrote: On Mon, Jul 22, 2013 at 6:02 AM, Rafael J. Wysocki r...@sisk.pl wrote: Linus, do you want

Re: [Intel-gfx] [Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

On 07/15/2013 07:42 PM, Rafael J. Wysocki wrote: On Monday, July 15, 2013 10:36:15 AM Aaron Lu wrote: On 07/13/2013 08:46 AM, Rafael J. Wysocki wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com According to Matthew Garrett, Windows 8 leaves backlight control up to individual graphics

Re: [Intel-gfx] [Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

on earlier patches from Matthew Garrett, Chun-Yi Lee and Seth Forshee and Aaron Lu's comments. Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Reviewed-by: Aaron Lu aaron...@intel.com BTW, I also tested on a Toshiba laptop Z830 where its AML code claims support of win8, the result

Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 07/07/2013 09:19 PM, Rafael J. Wysocki wrote: OK, the patch is appended. Please have a look and tell me what you think. Thanks, Rafael --- From: Rafael J. Wysocki rafael.j.wyso...@intel.com Subject: ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 07/06/2013 06:23 AM, Rafael J. Wysocki wrote: On Friday, July 05, 2013 11:40:02 PM Rafael J. Wysocki wrote: On Friday, July 05, 2013 10:00:55 PM Rafael J. Wysocki wrote: On Friday, July 05, 2013 02:20:14 PM Rafael J. Wysocki wrote: On Sunday, June 09, 2013 07:01:39 PM Matthew Garrett wrote:

Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/15/2013 12:19 PM, Matthew Garrett wrote: On Sat, Jun 15, 2013 at 12:14:42PM +0800, Aaron Lu wrote: On 06/15/2013 09:38 AM, Matthew Garrett wrote: Well, Windows 8 will only use the ACPI backlight interface if the GPU driver decides to, right? So the logic for deciding whether to remove

Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/10/2013 07:01 AM, Matthew Garrett wrote: Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest that the Intel driver for Windows doesn't use the ACPI interface, including the fact that it's broken

Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/15/2013 01:29 AM, Matthew Garrett wrote: On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: What about a priority based solution? We can introduce a new field named priority to backlight_device and instead of calling another module's function like the unregister one here(which cause

Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/15/2013 09:38 AM, Matthew Garrett wrote: On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: It's not easy to decide if they work or not sometimes, e.g. I came across a system that claims win8 in ACPI table and has an Intel GPU, while its ACPI video interface also works. With this patch