gt;
> Signed-off-by: Thorsten Blum
> ---
It's tricky to know which tree a patch like this would go through. We
used to have a trivial tree for this stuff but I guess that didn't work.
It's possible that it could go through linux-doc, but probably it has to
go as a set of patches through each o
ot; should be used when a
> bug is fixed, but not for harmless static analyzer reports.
>
> Besides, if we want to keep the Fixes tag we should also Cc
> stable, i guess checkpatch.pl complains about it.
>
> (BTW, Cc'ed in this mail we have the inventor of the tag and he
> can confirm after having had his morning coffee :-) ).
>
Good. I keep reminding people that I invented the Fixes tag because it
is my proudest achievement. :)
No. Only use Fixes tags for bug fixes.
regards,
dan carpenter
/20240310/202403101225.7ahejhzj-...@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes
if (IS_ERR(tunnel_mgr))
The real implementation of drm_dp_tunnel_mgr_create() returns NULL but
the stub implementation returns ERR_PTR(-EOPNOTSUPP).
794 return PTR_ERR(tunnel_mgr);
795
796 i915->display.dp_tunnel_mgr = tunnel_mgr;
797
798 return 0
.org/0day-ci/archive/20240225/202402250758.kqbqxyrz-...@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan
if (!rq) {
^^^
Previously we assumed "rq" could be NULL.
103 intel_engine_dump(engine, ,
104"%s heartbeat not ticking\n",
regards,
dan carpenter
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202402180310.gmdixajx-...@intel.com/
New smatch warnings:
drivers/gpu/drm/i915/display/intel_color.c:3867 intel_plane_tf_pipeline_init()
error: 'colorop' dereferencing possible ERR_PTR()
vim +/colorop +3867 drivers/gpu/drm/i915
-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202402171830.n4hwr2id-...@intel.com/
smatch warnings:
drivers/gpu/drm/i915/display/intel_psr.c:1253
_lnl_compute_aux_less_alpm_params() error: uninitialized symbol
'silence_period'.
vim +/silence_period +1253
/0day-ci/archive/20240131/202401311604.1pllaxek-...@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan
.
Fixes: e0f74ed4634d ("i915/gvt: Separate the MMIO tracking table from GVT-g")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gvt/handlers.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/handlers.c
b/drivers/gpu/drm/i915/gvt/handler
mutex_destroy(>flush);
278 }
regards,
dan carpenter
-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202310150454.s9qf86bl-...@intel.com/
smatch warnings:
drivers/gpu/drm/i915/display/skl_universal_plane.c:2126
gen12_plane_format_mod_supported() warn: ignoring unreachable code.
vim +2126 drivers/gpu/drm/i915/display/skl_universal_plane.c
}
381
382 intel_de_write_fw(dev_priv, DSB_TAIL(pipe, dsb->id),
383 i915_ggtt_offset(dsb->vma) + tail);
384 }
regards,
dan carpenter
intel_breadcrumbs_put(ve->base.breadcrumbs);
3659 if (ve->base.sched_engine)
^
But previous code had assumed the sched_engine could be NULL.
3660 i915_sched_engine_put(ve->base.sched_engine);
3661 intel_engine_free_request_pool(>base);
regards,
dan carpenter
if (!connector || connector->base.status !=
connector_status_connected)
^
Checked too late.
4337 return 0;
4338
regards,
dan carpenter
-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202309252243.l3lv6ixf-...@intel.com/
New smatch warnings:
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4181 guc_kernel_context_pin()
error: uninitialized symbol 'ret'.
vim +/ret +4181 drivers/gpu/drm/i915
Move the check for "if (IS_ERR(obj))" in front of the call to
i915_gem_object_set_cache_coherency() which dereferences "obj".
Otherwise it will lead to a crash.
Fixes: 43aa755eae2c ("drm/i915/mtl: Update cache coherency setting for context
structure")
Signed-off-b
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202309060644.uwp5zw4i-...@intel.com/
smatch warnings:
drivers/gpu/drm/i915/display/intel_dp.c:3779 intel_dp_vsc_sdp_pack() warn: was
&& intended here instead of ||?
vim +3779 drivers/gpu/drm/i915
On Wed, Jul 26, 2023 at 09:21:50AM +0800, Su Hui wrote:
> On 2023/7/25 13:51, Dan Carpenter wrote:
> > The reason why the first five attempts had bugs is because we are
> > trying to write it in the most complicated way possible, shifting by
> > logical not what?
> Wond
The reason why the first five attempts had bugs is because we are
trying to write it in the most complicated way possible, shifting by
logical not what?
regards,
dan carpenter
diff --git a/drivers/gpu/drm/i915/display/intel_tv.c
b/drivers/gpu/drm/i915/display/intel_tv.c
index 36b479b46b60
;
> > + mode->clock = clock / (tv_mode->oversample != 1 ?
> > + tv_mode->oversample >> !tv_mode->progressive : 1);
>
> Seems too smart to me, why not just:
> mode->clock = clock / tv_mode->oversample;
> if (!tv_mode->progressive)
> mode->clock <<= 1;
This is nice.
regards,
dan carpenter
doesn't
> know that a truncation has happened. So that if we save from an
> overflow here, we might encur to an unwanted access later when we
> would start using the array for the size we think is allocated.
SIZE_MAX allocations are guaranteed to fail, so the NULL check
will still return -ENOMEM.
>
> kmalloc_array(), for example, returns NULL of there is a
> multiplication overflow and I think that's a better behaviour,
> although more drastic.
It's the same either way.
regards,
dan carpenter
On Wed, Jun 07, 2023 at 06:44:54PM +, Teres Alexis, Alan Previn wrote:
> On Tue, 2023-06-06 at 21:32 +0300, Dan Carpenter wrote:
> > On Tue, Jun 06, 2023 at 06:07:19PM +, Teres Alexis, Alan Previn wrote:
> > > That was my bad, i could have sword i'd fixed that be
he fixes tag is significant.
>
The Fixes tag is correct. It's definitely a bug fix.
(I invented the Fixes tag so technically that makes me the worlds #1
expert on Fixes tags).
regards,
dan carpenter
The mmap_offset_attach() function returns error pointers, it doesn't
return NULL.
Fixes: eaee1c085863 ("drm/i915: Add a function to mmap framebuffer obj")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
This should return negative -EAGAIN instead of positive EAGAIN.
Fixes: e5e1e6d28ebc ("drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet
to GSC")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c | 2 +-
1 file changed, 1 insertion(+),
ts to solve that problem. Instead we were having the
opposite discussion the other week where the bpf people didn't want to
backport selftest stuff and Greg wanted to.
https://lore.kernel.org/all/2023052647-tacking-wince-85c5@gregkh/
regards,
dan carpenter
)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202305280453.8yzcms2i-...@intel.com/
smatch warnings:
drivers/gpu/drm/i915/display
/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202305280253.ab8brv2w-...@intel.com/
New smatch warnings:
drivers/gpu/drm/i915/display
On Fri, May 26, 2023 at 02:58:01PM +0200, Andi Shyti wrote:
> Hi Dan,
>
> On Fri, May 26, 2023 at 02:59:31PM +0300, Dan Carpenter wrote:
> > Return the error code if i915_gem_object_create_internal() fails,
> > instead of returning success.
> >
> > Fixes: cf58
ner_fini();
908 out_restore:
909 engine->props.preempt_timeout_ms = preempt_timeout_ms;
910 if (err)
911 pr_err("%s: %s error %d\n", __func__, engine->name,
err);
912 return err;
913 }
regards,
dan carpenter
8 out_pci_disable:
849 pci_disable_device(pdev);
--> 850 i915_probe_error(i915, "Device initialization failed (%d)\n",
ret);
Oops.
851 return ret;
852 }
regards,
dan carpenter
Return the error code if i915_gem_object_create_internal() fails,
instead of returning success.
Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gt/selftest_migrate.c | 4 +++-
1 file changed, 3 insertions(+),
err = PTR_ERR(obj);
1554 goto err_ctx_lo;
1555 }
1556
regards,
dan carpenter
kfree(data);
418 out_file:
419 fput(file);
420 return err;
421 }
regards,
dan carpenter
m_ops = obj->ops->mmap_ops;
1008 vma->vm_private_data = node->driver_private;
^^^^^^^^
Patch adds unchecked dereference.
1009 return 0;
1010 }
regards,
dan carpenter
t; 2110 return intel_rps_get_cagf(rps, freq);
Warning.
2111 }
regards,
dan carpenter
e_error(gt, "%s firmware %s: fetch failed %pe\n",
822intel_uc_fw_type_repr(uc_fw->type),
uc_fw->file_selected.path, ERR_PTR(err));
823 gt_info(gt, "%s firmware(s) can be downloaded from %s\n",
824 intel_uc_fw_type_repr(uc_fw->type),
INTEL_UC_FIRMWARE_URL);
825
826 release_firmware(fw);/* OK even if fw is NULL */
827 return err;
828 }
regards,
dan carpenter
On Thu, Mar 09, 2023 at 04:51:10PM +0200, Jani Nikula wrote:
> On Thu, 09 Mar 2023, Dan Carpenter wrote:
> > Hello Jani Nikula,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch 1b28c1c789d0: "drm/i915/dmc: add i9
ERSION_MAJOR(dmc->version),
1163 DMC_VERSION_MINOR(dmc->version));
Unchecked dereferences.
1164
regards,
dan carpenter
^^
Sleeping.
638 GEM_BUG_ON(rq->fence.error != -EIO);
639
640 engine_unlock_reset_tasklet(engine);
preempt enabled again.
641
642 /* Check that we do not resubmit the held request */
regards,
dan carpenter
ift a finger to help so who am I to talk...)
657 }
658
659 /* Signal that the GuC isn't running. */
660 intel_guc_sanitize(guc);
661
662 return 0;
663 }
regards,
dan carpenter
On Mon, Feb 06, 2023 at 04:59:36PM +, Tvrtko Ursulin wrote:
>
> On 06/02/2023 14:19, Dan Carpenter wrote:
> > [ Ancient code but the warning showed up again because the function was
> >renamed or something? - dan ]
> >
> > Hello Chris Wilson,
> >
&
ing of ENOMEM.
188 */
189 if (ret == -ENOSPC)
190 ret = -ENOMEM;
191
192 return ret;
193 }
regards,
dan carpenter
, kindly add following tag where applicable
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/display/drm_dp_mst_topology.c:3316 drm_dp_add_payload_part1()
warn: missing error code 'ret'
vim +/ret +3316 drivers/gpu/drm/display/drm_dp_mst_topology.c
test robot
| Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/drm_buddy.c:501 find_continuous_blocks() error: uninitialized
symbol 'block'.
vim +/block +501 drivers/gpu/drm/drm_buddy.c
8a257b57bc11a2 xinhui pan 2022-12-18 472 static struct drm_buddy_block *
8a257b57bc11a2 xinhui pan
The "fw" pointer is freed again in the clean up code at the end of the
function. Set it to NULL here to prevent a double free.
Fixes: 016241168dc5 ("drm/i915/uc: use different ggtt pin offsets for uc loads")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gt/uc/in
Call intel_vgpu_unpin_mm() on this error path.
Fixes: 418741480809 ("drm/i915/gvt: Adding ppgtt to GVT GEM context after
shadow pdps settled.")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gvt/scheduler.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/dr
On Thu, Sep 22, 2022 at 01:01:48PM -0700, John Harrison wrote:
> On 9/22/2022 07:26, Dan Carpenter wrote:
> > Hello Matthew Brost,
> >
> > The patch 6b540bf6f143: "drm/i915/guc: Implement multi-lrc
> > submission" from Oct 14, 2021, leads to the follow
t:
751 spin_unlock(>guc_state.lock);
--> 752 return err;
753 }
regards,
dan carpenter
This code uses struct_size() but it stores the result in an int so the
integer overflow checks are not effective. Record the types as size_t
to prevent the size from being truncated.
Fixes: bf3c50837506 ("drm/i915/query: Use struct_size() helper")
Signed-off-by: Dan Carpenter
---
I d
-ci/archive/20220830/202208301957.ulaot2oy-...@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:497
The shmem_pin_map() function doesn't return error pointers, it returns
NULL.
Fixes: be1cb55a07bf ("drm/i915/gt: Keep a no-frills swappable copy of the
default context state")
Signed-off-by: Dan Carpenter
Reviewed-by: Matthew Auld
---
v2: Correct the Fixes tag. Add Matthew's revie
On Fri, Jul 08, 2022 at 10:02:34AM +0100, Matthew Auld wrote:
> On 08/07/2022 09:40, Dan Carpenter wrote:
> > The shmem_pin_map() function doesn't return error pointers, it returns
> > NULL.
> >
> > Fixes: a0d3fdb628b8 ("drm/i915/gt: Split logical ring contex
The shmem_pin_map() function returns NULL, it doesn't return error
pointers.
Fixes: 97ea656521c8 ("drm/i915/gvt: Parse default state to update reg
whitelist")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 +++---
1 file changed, 3 insertions(+), 3
The shmem_pin_map() function doesn't return error pointers, it returns
NULL.
Fixes: a0d3fdb628b8 ("drm/i915/gt: Split logical ring contexts from execlist
submission"
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 8
1 file changed, 4 insert
This function is supposed to return zero or negative error codes but it
accidentally returns true on failure.
Fixes: 92a020747d6c ("drm/i915: Split shared dpll .get_dplls() into compute and
get phases")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/display/intel_dpll_mgr.c
!sg_dma_len(it_ccs.sg) {
884 err = -EINVAL;
885 break;
886 }
887
888 cond_resched();
889 } while (1);
890
891 out_ce:
892 return err;
893 }
regards,
dan carpenter
les, but unfortunately that warning is disabled by
default so we still have to rely on kbuild/Clang/Smatch to find the
bugs.
But hopefully the new API encourages people to write clearer code so it
prevents bugs in the long run.
regards,
dan carpenter
44
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3771,6 +3771,9 @@ EXPORT_SYMBOL(kmem_cache_free_bulk);
*
* Don't free memory not originally allocated by kmalloc()
* or you will run into trouble.
+ *
+ * CHECKER information
+ * frees: $0
*/
void kfree(const void *objp)
{
regards,
dan carpenter
for (port = 0; port < r8a66597->max_root_hub; port++) {
427 if (r8a66597->root_hub[port].dev == dev) {
^^^
428 r8a66597->root_hub[port].dev = NULL;
429 break;
430 }
431 }
Printing the freed pointer in debug code is another thing people do.
regards,
dan carpenter
On Mon, Feb 28, 2022 at 10:20:28AM -0800, Joe Perches wrote:
> On Mon, 2022-02-28 at 14:24 +0300, Dan Carpenter wrote:
>
> > a multi-line indent gets curly braces for readability even though
> > it's not required by C. And then both sides would get curly braces.
>
> T
lated part of a
patch is a bit vague and some maintainers will ask you to add or subtract
from a patch depending on their individual tastes. I don't really have
an exact answer, but I felt like this patch needs to be subtracted from.
Especially if there is a whole chunk of the patch which can be removed,
then to me, that obviously should be in a different patch.
regards,
dan carpenter
name(&_phy->dev));
> BUG();
> }
> } else {
> - sas_port_create_link(port, phy);
> - list_add_tail(>port_siblings, >phy_list);
> + sas_port_create_link(port, _phy);
> + list_add_tail(&_phy->port_siblings, >phy_list);
> port->num_phys++;
> }
> mutex_unlock(>phy_list_mutex);
regards,
dan carpenter
te now. Just delete it.
> - if (group && >list == >tid_group_list.list)
> + if (!group)
> goto bail_eagain;
> group = list_prepare_entry(group, >tid_group_list.list,
> list);
regards,
dan carpenter
--
> drivers/media/pci/saa7134/saa7134-alsa.c | 4 ++--
> drivers/perf/xgene_pmu.c | 13 +++--
> 3 files changed, 11 insertions(+), 10 deletions(-)
These are all bug fixes.
1) Send them as 3 separate patches.
2) Add Fixes tags.
regards,
dan carpenter
pped = stopped;
> spin_unlock_irqrestore(>dev->lock, flags);
> return -EINVAL;
> @@ -954,7 +957,6 @@ net2272_dequeue(struct usb_ep *_ep, struct usb_request
> *_req)
> dev_dbg(ep->dev->dev, "unlink (%s) pio\n", _ep->name);
> net2272_done(ep, req, -ECONNRESET);
> }
> - req = NULL;
Another unrelated change. These are all good changes but send them as
separate patches.
> ep->stopped = stopped;
>
> spin_unlock_irqrestore(>dev->lock, flags);
regards,
dan carpenter
a->resource);
If "vma->resource" is NULL here then it leads to a crash in
i915_vma_resource_get().
488 work->cache_level = cache_level;
489 work->flags = bind_flags;
490
regards,
dan carpenter
ow that relationship is not so clear so it causes a Smatch warning.
923 if (ret)
924 return ret;
925
926 data_rate = intel_bw_data_rate(dev_priv, new_bw_state);
927 data_rate = DIV_ROUND_UP(data_rate, 1000);
928
regards,
dan carpenter
On Fri, Jan 28, 2022 at 07:20:02AM +0100, Thomas Hellström wrote:
> On Thu, 2022-01-27 at 17:26 -0500, Rodrigo Vivi wrote:
> > On Thu, Jan 27, 2022 at 11:51:15AM +0300, Dan Carpenter wrote:
> > > This "ret" declaration shadows an existing "ret" variable
This "ret" declaration shadows an existing "ret" variable at the top of
the function. Delete it.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/i915_vma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i
There were two error paths in __cancel_reset() which return success
instead of a negative error code as expected.
Fixes: 4e6835466771 ("drm/i915/selftests: Add a cancel request selftest that
triggers a reset")
Signed-off-by: Dan Carpenter
---
>From static analysis. I am
ror: potential divide by zero bug '/ rec->dst_width'.
Prevent this by ensuring that the dst height and width are non-zero.
Fixes: 02e792fbaadb ("drm/i915: implement drmmode overlay support v4")
Signed-off-by: Dan Carpenter
---
>From static analysis. Not tested.
drivers/g
_and_wake_up_bit(bit, lock);
1623 }
1624 local_bh_enable();
1625 }
regards,
dan carpenter
code dereferences it without checking.
1016 flags, work);
1017 if (err)
regards,
dan carpenter
The "offset" is a u32 that comes from the user. The bug is that the
"offset + bytes" operation can have an integer overflow problem which
leads to an out of bounds access.
Fixes: 4d60c5fd3f87 ("drm/i915/gvt: vGPU PCI configuration space
virtualization"
ke there should be a
human reading them but it's not me... The system is broken, but who is
fixing it?
regards,
dan carpenter
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_10911_full -> Patchwork_21650_full
>
>
This function returns a bool type so returning -EBUSY is equivalent to
returning true. It should return false instead.
Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
1 file changed, 1 inser
On Thu, Nov 18, 2021 at 03:15:31PM +, Matthew Auld wrote:
> On 18/11/2021 15:01, Dan Carpenter wrote:
> > Hello Matthew Auld,
> >
> > The patch 7ae034590cea: "drm/i915/ttm: add tt shmem backend" from Oct
> > 18, 2021, leads to the following Smatch static
ill on TTM's LRU
lists */
338 return i915_gem_object_evictable(obj);
339 }
regards,
dan carpenter
The intel_engine_create_virtual() function does not return NULL. It
returns error pointers.
Fixes: e5e32171a2cf ("drm/i915/guc: Connect UAPI to GuC multi-lrc interface")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 4 ++--
1 file changed, 2
460c33821 ("drm/i915: Multi-BB execbuf")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
in
The "ret" variable is checked on the previous line so we know it's
zero. No need to check again.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/display/intel_fb_pin.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i9
of feel like we shouldn't work around static checker bugs.
But when we do then there shouldn't be a Fixes tag.
regards,
dan carpenter
On Mon, Oct 04, 2021 at 01:52:27PM -0700, Lucas De Marchi wrote:
> Cc'ing Dan Carpenter
>
> On Fri, Oct 01, 2021 at 12:57:13PM +0300, Jani Nikula wrote:
> > On Fri, 01 Oct 2021, Chris Wilson wrote:
> > > Quoting Lucas De Marchi (2021-10-01 08:40:41)
> > >
The "digi_port" pointer can't be NULL and we have already dereferenced
it so checking for NULL is not necessary. Delete the check.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/display/intel_ddi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drive
On Fri, Oct 01, 2021 at 05:20:17PM +0300, Ville Syrjälä wrote:
> On Fri, Oct 01, 2021 at 04:25:35PM +0300, Dan Carpenter wrote:
> > Hello Imre Deak,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch 3e0abc7661c8: "d
kfree(dig_port);
regards,
dan carpenter
) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/gpu/drm/drm_hdcp.c:1208 drm_hdcp_helper_enable_hdcp() error:
uninitialized symbol 'check_link_interval'.
Old smatch warnings:
drivers/gpu
If the intel_engine_create_pinned_context() function returns an error
pointer, then dereferencing "ce" will Oops. Use "vm" instead of
"ce->vm".
Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration")
Signed-off-by: Dan Carpenter
---
drivers/gpu
'rq'.
drivers/gpu/drm/i915/gt/selftest_migrate.c:193 clear() error: uninitialized
symbol 'vaddr'.
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:819
__unwind_incomplete_requests() error: uninitialized symbol 'pl'.
regards,
dan carpenter
ke_up_bit(bit, lock);
1623 }
1624 local_bh_enable();
1625 }
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
which involves dropping some locks), if we see any other
> error then the loop is terminated with ww->loop = false, which then
> hits the goto err_out.
>
Ah, yeah, you're right. False positive.
I hadn't looked at this code in context (I only had reviewed the email).
Now that I've pulled th
On Fri, Jul 02, 2021 at 02:07:27PM +0300, Dan Carpenter wrote:
> On Fri, Jul 02, 2021 at 11:32:45AM +0100, Matthew Auld wrote:
> > On Fri, 2 Jul 2021 at 09:45, Dan Carpenter wrote:
> > > cf586021642d80 Chris Wilson 2021-06-17 84
> > > cf586021642d80 Chris Wilson 2021
On Fri, Jul 02, 2021 at 11:32:45AM +0100, Matthew Auld wrote:
> On Fri, 2 Jul 2021 at 09:45, Dan Carpenter wrote:
> >
> > tree: git://anongit.freedesktop.org/drm-intel drm-intel-gt-next
> > head: 5cd57f676bb946a00275408f0dd0d75dbc466d25
> > commit: cf586021642d8017
(Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/gpu/drm/i915/selftests/intel_memory_region.c:227 igt_mock_reserve()
error: 'mem' dereferencing possible ERR_PTR()
vim +/mem
9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/gpu/drm/i915/gt/selftest_migrate.c:102 copy() error: uninitialized
symbol 'rq'.
drivers/gpu/drm/i915/gt/selftest_migrate.c:113 copy
440 mutex_unlock(>send_mutex);
441
442 return ret;
443 }
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
This code should propagate the error from intel_overlay_pin_fb()
but currently it returns success.
Fixes: 1b321026e213 ("drm/i915: Pass ww ctx to intel_pin_to_display_plane")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/display/intel_overlay.c | 4 +++-
1 file changed, 3
and make everything consistent.
Fixes: c5d71cb31723 ("drm/i915/gvt: Move vGPU type related code into gvt file")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gvt/gvt.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/gvt.c b/d
1 - 100 of 298 matches
Mail list logo
