I've just been talking with Ben about nouveau having some issues since
this path,
ttm_resource can be subclassed by drivers, and the code below that
copies ttm_resources around pretty much seems to destroy that.
> + struct ttm_resource *src_mem = >mem;
> + struct
On Wed, 11 Aug 2021 at 17:11, Jani Nikula wrote:
>
> On Wed, 11 Aug 2021, Joonas Lahtinen wrote:
> > Quoting Dave Airlie (2021-08-11 06:48:39)
> >> dim: db47fe727e1f ("drm/i915/step:
> >> s/_revid_tbl/_revids"): committer Signed-off-by
> >&
dim: db47fe727e1f ("drm/i915/step:
s/_revid_tbl/_revids"): committer Signed-off-by
missing.
I'm not sure how much pain it is to fix that up, but
commit db47fe727e1fc516cf60fc9ab8299605ef3c2d54
Author: Anusha Srivatsa
Commit: Matt Roper
drm/i915/step: s/_revid_tbl/_revids
Simplify the
On Fri, 16 Jul 2021 at 21:07, Maarten Lankhorst
wrote:
>
> Hi Dave & Daniel,
>
> Lots of stuff this time around.
>
> Enjoy!
I've pulled this but there is an outstanding warning
/home/airlied/devel/kernel/dim/src/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:
In function ‘hibmc_unload’:
..@jlekstrand.net/
>
> v3: Since Christian has fixed amdgpu now in
>
> commit 8c505bdc9c8b955223b054e34a0be9c3d841cd20 (drm-misc/drm-misc-next)
> Author: Christian König
> Date: Wed Jun 9 13:51:36 2021 +0200
>
> drm/amdgpu: rework dma_resv handling v3
>
> Use the audit covered in this commit message as the excuse to update
> the dma-buf docs around dma_buf.resv usage across drivers.
>
> Since dynamic importers have different rules also hammer these in
> again while we're at it.
>
> v4:
> - Add the missing "through the device" in the dynamic section that I
> overlooked.
> - Fix a kerneldoc markup mistake, the link didn't connect
>
This is pretty epic commit msg, thanks for the investment, the commit
msg should be required reading.
Reviewed-by: Dave Airlie
Dave.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, 14 Jun 2021 at 19:37, Joonas Lahtinen
wrote:
>
> Quoting Joonas Lahtinen (2021-06-11 14:13:02)
> > Quoting Joonas Lahtinen (2021-06-11 13:40:56)
> > > Quoting Maarten Lankhorst (2021-06-11 12:27:15)
> > > > Pull request for drm-misc-next and drm-intel-gt-next.
> > > >
> > > >
On Fri, 18 Jun 2021 at 12:26, Dave Airlie wrote:
>
> when I pulled this in drm-next I got these.
>
> were the mst fixes meant for next or fixes btw? I'm not really sure,
> but either way I don't think this is a local reason it doesn't build
> or did I miss something?
Hi Thom
when I pulled this in drm-next I got these.
were the mst fixes meant for next or fixes btw? I'm not really sure,
but either way I don't think this is a local reason it doesn't build
or did I miss something?
Dave.
/home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:
In
assumptions
> > (Daniel Stone)
> > - Add links to priority spec
> >
> > Cc: Christian König
> > Cc: Luben Tuikov
> > Cc: Alex Deucher
> > Cc: Steven Price
> > Cc: Jon Bloomfield
> > Cc: Jason Ekstrand
> > Cc: Dave Airlie
> &g
On Wed, 2 Jun 2021 at 14:17, Dave Airlie wrote:
>
> On Wed, 2 Jun 2021 at 10:28, Dave Airlie wrote:
> >
> > This has these two patches applied, and it doesn't build.
> >
> > drm/i915: drop the __i915_active_call pointer packing
> > drm/i915: Fix crash in
On Wed, 2 Jun 2021 at 10:28, Dave Airlie wrote:
>
> This has these two patches applied, and it doesn't build.
>
> drm/i915: drop the __i915_active_call pointer packing
> drm/i915: Fix crash in auto_retire
>
> The latter patch shouldn't be necessary after the former,
This has these two patches applied, and it doesn't build.
drm/i915: drop the __i915_active_call pointer packing
drm/i915: Fix crash in auto_retire
The latter patch shouldn't be necessary after the former, please fix
that up and resend and please build test trees before I get them in
future.
On Thu, 27 May 2021 at 20:04, Daniel Vetter wrote:
>
> On Wed, May 26, 2021 at 10:35:49AM +1000, Dave Airlie wrote:
> > On Wed, 12 May 2021 at 03:05, Daniel Vetter wrote:
> > > On Tue, May 11, 2021 at 10:31:39AM +0200, Zbigniew Kempczyński wrote:
> > > > We ha
ore there's pretty strong indications it's buggy, since the
> code to use it by default as the only option had to be reverted:
>
> commit ad5d95e4d538737ed3fa25493777decf264a3011
> Author: Dave Airlie
> Date: Tue Sep 8 15:41:17 2020 +1000
>
> Revert "drm/i915/gem: Async
e need extend transition period and support relocations for two
> > other igfx platforms - Rocketlake and Alderlake.
> >
> > Signed-off-by: Zbigniew Kempczyński
> > Cc: Dave Airlie
> > Cc: Daniel Vetter
> > Cc: Jason Ekstrand
>
> So the annoying thing he
https://bugzilla.redhat.com/show_bug.cgi?id=1964252
dmesg below.
Feel free to point me at any fixes already in flight.
Dave.
[ 140.302041] list_add double add: new=9ed109790fe0,
prev=9ed109790fe0, next=9ed109465b38.
[ 140.302076] [ cut here ]
[ 140.302078]
Can someone land this in drm-intel-next asap? it's breaking drm-tip development.
Dave.
On Sat, 22 May 2021 at 16:44, Lucas De Marchi wrote:
>
> On Fri, May 21, 2021 at 10:40:47AM -0700, Anusha Srivatsa wrote:
> >Propogate changes to macros name containing CSR_*
> >to DMC_* from display side.
>
Reviewed-by: Dave Airlie
Can we get this fix in, having a regression spanning 3 kernels isn't a
good look, we can work out why it matters later in life if anyone
cares.
Dave.
On Tue, 27 Apr 2021 at 00:31, Simon Rettberg
wrote:
>
> When resetting CACHE_MODE registers, don't enable H
since I think I've
> found a much better solution to tegra's issues:
> https://patchwork.freedesktop.org/series/89420/
I've given this a general once over, seems like a good plan and since
it's mostly mechanical.
for the series:
Reviewed-by: Dave Airlie
Dave.
_
eing over engineering, I hope they have a
good future use case.
The plan seems like a good plan.
Acked-by: Dave Airlie
Dave.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Tue, 23 Mar 2021 at 18:45, Daniel Vetter wrote:
>
> Motivated by the pre-review process for i915 gem/gt features, but
> probably useful in general for complex stuff.
>
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Jason Ekstrand
> Cc: Dave Airl
On Tue, 23 Mar 2021 at 23:17, Daniel Vetter wrote:
>
> On Tue, Mar 23, 2021 at 09:44:52AM +0100, Daniel Vetter wrote:
> > We've discussed a bit how to get the gem/gt team better integrated
> > and collaborate more with the wider community and agreed to the
> > following:
> >
> > - all gem/gt
On Thu, 11 Mar 2021 at 21:28, Rodrigo Vivi wrote:
>
> Hi Dave and Daniel,
>
> Things are very quiet. Only 1 fix this round.
> Since I will be out next week, if this trend continues I will
> accumulate 2 weeks and send when in -rc4.
>
> Here goes drm-intel-fixes-2021-03-11:
>
> - Wedge the GPU if
API. That means these
> applications will remain ABI compatible through this change.
>
> Acked-by: Keith Packard
Acked-by: Dave Airlie
Dave.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Wed, 3 Mar 2021 at 09:28, Linus Torvalds
wrote:
>
> Adding the right people.
>
> It seems that the three commits that needed reverting are
>
> f885056a48cc ("mm: simplify swapdev_block")
> 3e3126cf2a6d ("mm: only make map_swap_entry available for
> CONFIG_HIBERNATION")
> 48d15436fde6
On Wed, 3 Mar 2021 at 03:27, Sarvela, Tomi P wrote:
>
> The regression has been identified; Chris Wilson found commits touching
>
> swapfile.c, and reverting them the issue couldn’t be reproduced any more.
>
>
>
> https://patchwork.freedesktop.org/series/87549/
>
>
>
> This revert will be applied
On Wed, 24 Feb 2021 at 20:27, Thomas Zimmermann wrote:
>
> Hi Dave and Daniel,
>
> here's this week's PR for drm-misc-fixes. One of the patches is a memory
> leak; the rest is for hardware issues.
>
This is based on 5.11 and I'm not currently in the market for a
backmege now before rc1 so can
On Mon, 8 Feb 2021 at 20:53, Chris Wilson wrote:
>
> Re-enable secure dispatch for gen6/gen7, primarily to workaround the
> command parser and overly zealous command validation on Haswell. For
> example this prevents making accurate measurements using a journal for
> store results from the GPU
On Wed, 20 Jan 2021 at 07:43, Chris Wilson wrote:
>
> Simplify the frontbuffer unpin by removing the lock requirement. The LRU
> bumping was primarily to protect the GTT from being evicted and from
> frontbuffers being eagerly shrunk. Now we protect frontbuffers from the
> shrinker, and we avoid
From: Dave Airlie
Migrate this code out like the skylake code.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/i9xx_plane.c| 119 +++
drivers/gpu/drm/i915/display/i9xx_plane.h| 4 +
drivers/gpu/drm/i915/display/intel_display.c
From: Dave Airlie
This just migrates the hsw+ code to a better place.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_display.c | 212 +
drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 216 ++
drivers/gpu/drm/i915/display/intel_dpll_mgr.h
From: Dave Airlie
This moves the code from various places and consolidates it
into one new file.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/icl_dsi.c| 1 +
drivers/gpu/drm/i915/display/intel_atomic.c | 2
From: Dave Airlie
There is no need for this to be out of line.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_display.c | 9 -
drivers/gpu/drm/i915/display/intel_display.h | 1 -
drivers/gpu/drm/i915/display
From: Dave Airlie
This moves the older i9xx/vlv/chv enable/disable to dpll file.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_display.c | 512 ---
drivers/gpu/drm/i915/display/intel_display.h | 3 -
drivers/gpu/drm/i915
From: Dave Airlie
Daniel suggested this should move here.
v2: move vrr code.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_crtc.c | 245
drivers/gpu/drm/i915/display/intel_sprite.c | 242
From: Dave Airlie
This just cleans these up a bit.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_sprite.c| 7 +++
drivers/gpu/drm/i915/display/skl_universal_plane.c | 4 ++--
2 files changed, 5 insertions
From: Dave Airlie
Daniel asked for this, but it's a bit messy and I'm not sure
how best to clean it up yet.
Signed-off-by: Dave Airlie
[Jani: also moved fdi buf trans to intel_fdi.c.]
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_crt.c | 1
This is a repost of the last series, rebased to include the VRR
and GEN12 CCS changes.
It also has to scaler and ddi pll state movement patches that need
review, I think the rest should be pretty good to push sooner so
I don't fall into any more rebase traps.
Dave.
From: Dave Airlie
This moves the older i9xx/vlv/chv enable/disable to dpll file.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_display.c | 512 ---
drivers/gpu/drm/i915/display/intel_display.h | 3 -
drivers/gpu/drm/i915
From: Dave Airlie
This just migrates the hsw+ code to a better place.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_display.c | 212 +
drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 216 ++
drivers/gpu/drm/i915/display/intel_dpll_mgr.h
From: Dave Airlie
This moves the code from various places and consolidates it
into one new file.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/icl_dsi.c| 1 +
drivers/gpu/drm/i915/display/intel_atomic.c | 2
From: Dave Airlie
Migrate this code out like the skylake code.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/i9xx_plane.c| 119 +++
drivers/gpu/drm/i915/display/i9xx_plane.h| 4 +
drivers/gpu/drm/i915/display/intel_display.c
From: Dave Airlie
There is no need for this to be out of line.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_display.c | 8
drivers/gpu/drm/i915/display/intel_display.h | 1 -
drivers/gpu/drm/i915/display
From: Dave Airlie
Daniel suggested this should move here.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_crtc.c | 230
drivers/gpu/drm/i915/display/intel_sprite.c | 228 ---
2
From: Dave Airlie
This just cleans these up a bit.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_sprite.c| 7 +++
drivers/gpu/drm/i915/display/skl_universal_plane.c | 4 ++--
2 files changed, 5 insertions
From: Dave Airlie
Daniel asked for this, but it's a bit messy and I'm not sure
how best to clean it up yet.
Signed-off-by: Dave Airlie
[Jani: also moved fdi buf trans to intel_fdi.c.]
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_crt.c | 1
This is the previous set but the ddi translations is fixed up to
add the missing rocketlake pieces.
This series adds two more to the end, one patch to refactor
skylake scaler code to a new file, and one to move some more pll
state to the pll mgr.
Dave.
From: Dave Airlie
This moves the older i9xx/vlv/chv enable/disable to dpll file.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_display.c | 512 ---
drivers/gpu/drm/i915/display/intel_display.h | 3 -
drivers/gpu/drm/i915
From: Dave Airlie
Migrate this code out like the skylake code.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/i9xx_plane.c| 119 +++
drivers/gpu/drm/i915/display/i9xx_plane.h| 4 +
drivers/gpu/drm/i915/display/intel_display.c
From: Dave Airlie
There is no need for this to be out of line.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_display.c | 8
drivers/gpu/drm/i915/display/intel_display.h | 1 -
drivers/gpu/drm/i915/display
From: Dave Airlie
Daniel suggested this should move here.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_crtc.c | 230
drivers/gpu/drm/i915/display/intel_sprite.c | 228 ---
2
From: Dave Airlie
This just cleans these up a bit.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_sprite.c| 7 +++
drivers/gpu/drm/i915/display/skl_universal_plane.c | 4 ++--
2 files changed, 5 insertions
From: Dave Airlie
Daniel asked for this, but it's a bit messy and I'm not sure
how best to clean it up yet.
Signed-off-by: Dave Airlie
[Jani: also moved fdi buf trans to intel_fdi.c.]
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_crt.c | 1
This rebases, fixes up the headers (thanks Jani, for pointing that out),
and adds missing tags and review tags.
I think only patch 3 is missing an r-b, I've fixed the header issues
he pointed out.
Dave.
___
Intel-gfx mailing list
On Fri, 15 Jan 2021 at 01:57, Ville Syrjälä
wrote:
>
> On Thu, Jan 14, 2021 at 01:13:50PM +0200, Jani Nikula wrote:
> > From: Dave Airlie
> >
> > Rework the plane init calls to do the gen test one level higher.
> >
> > Rework some of the plane
On Mon, 18 Jan 2021 at 10:59, Stephen Rothwell wrote:
>
> Hi all,
>
> On Mon, 11 Jan 2021 10:56:54 +1100 Stephen Rothwell
> wrote:
> >
> > On Fri, 8 Jan 2021 12:25:40 +1100 Stephen Rothwell
> > wrote:
> > >
> > > On Fri, 8 Jan 2021 11:55:18 +1100 Stephen Rothwell
> > > wrote:
> > > >
> > >
From: Dave Airlie
This moves the older i9xx/vlv/chv enable/disable to dpll file.
---
drivers/gpu/drm/i915/display/intel_display.c | 512 ---
drivers/gpu/drm/i915/display/intel_display.h | 3 -
drivers/gpu/drm/i915/display/intel_dp.c | 1 +
drivers/gpu/drm/i915/display
From: Dave Airlie
Migrate this code out like the skylake code.
---
drivers/gpu/drm/i915/display/i9xx_plane.c| 119 +++
drivers/gpu/drm/i915/display/i9xx_plane.h| 2 +
drivers/gpu/drm/i915/display/intel_display.c | 119 ---
3 files changed, 121
From: Dave Airlie
There is no need for this to be out of line.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_display.c | 8
drivers/gpu/drm/i915/display/intel_display.h | 1 -
drivers/gpu/drm/i915/display/intel_display_types.h | 8
3 files
From: Dave Airlie
Daniel suggested this should move here.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_crtc.c | 230
drivers/gpu/drm/i915/display/intel_sprite.c | 228 ---
2
From: Dave Airlie
This just cleans these up a bit.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_sprite.c| 7 +++
drivers/gpu/drm/i915/display/skl_universal_plane.c | 4 ++--
2 files changed, 5 insertions
From: Dave Airlie
Daniel asked for this, but it's a bit messy and I'm not sure
how best to clean it up yet.
Signed-off-by: Dave Airlie
[Jani: also moved fdi buf trans to intel_fdi.c.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_crt.c | 1 +
drivers/gpu/drm/i915
From: Dave Airlie
This just refactors out the fdi code to a separate file.
Signed-off-by: Dave Airlie
[Jani: cleaned up intel_fdi.h a bit.]
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display
From: Dave Airlie
This pulls a large chunk of the pll calculation code out of
intel_display.c to a new file.
One function makes sense to be an inline, otherwise this
is pretty much a straight copy cover. Also all the
remaining hooks for g45 and older end up the same now.
Signed-off-by: Dave
From: Dave Airlie
There may be more crtc code that can be pulled out, but this
is a good start.
v2: move plane before this.
Signed-off-by: Dave Airlie
[Jani: cleaned up intel_crtc.h a bit.]
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/Makefile
Hi Jani and Ville,
This is a rebased taking into account the changes that happened since
and the backmerge.
Some of these are reviewed already so it would be good to get them
pushed asap.
Dave.
___
Intel-gfx mailing list
Hi Jani and Ville,
This is a rebased taking into account the changes that happened since
and the backmerge.
Some of these are reviewed already so it would be good to get them
pushed asap.
Dave.
___
Intel-gfx mailing list
ng to fix gem_ctx_persistence.userptr.
>
> Signed-off-by: Maarten Lankhorst
Acked-by: Dave Airlie
This isn't a review so much as a land this over objections.
Dave.
> ---
> .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 101 ++-
> drivers/gpu/drm/i915/gem/i915_gem_object.h| 3
Acked-by: Dave Airlie
burn with the fire.
Dave.
On Wed, 6 Jan 2021 at 01:46, Maarten Lankhorst
wrote:
>
> We should not allow this any more, as it will break with the new userptr
> implementation, it could still be made to work, but there's no point in
> doing so.
&g
From: Dave Airlie
Daniel suggested this should move here.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_crtc.c | 230
drivers/gpu/drm/i915/display/intel_sprite.c | 228 ---
2
From: Dave Airlie
Migrate this code out like the skylake code.
---
drivers/gpu/drm/i915/display/i9xx_plane.c| 119 +++
drivers/gpu/drm/i915/display/i9xx_plane.h| 2 +
drivers/gpu/drm/i915/display/intel_display.c | 119 ---
3 files changed, 121
From: Dave Airlie
This moves the older i9xx/vlv/chv enable/disable to dpll file.
---
drivers/gpu/drm/i915/display/intel_display.c | 512 ---
drivers/gpu/drm/i915/display/intel_display.h | 3 -
drivers/gpu/drm/i915/display/intel_dp.c | 1 +
drivers/gpu/drm/i915/display
From: Dave Airlie
There is no need for this to be out of line.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_display.c | 8
drivers/gpu/drm/i915/display/intel_display.h | 1 -
drivers/gpu/drm/i915/display/intel_display_types.h | 8
3 files
From: Dave Airlie
This just cleans these up a bit.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_sprite.c| 7 +++
drivers/gpu/drm/i915/display/skl_universal_plane.c | 4 ++--
2 files changed, 5 insertions
From: Dave Airlie
This pulls a large chunk of the pll calculation code out of
intel_display.c to a new file.
One function makes sense to be an inline, otherwise this
is pretty much a straight copy cover. Also all the
remaining hooks for g45 and older end up the same now.
Signed-off-by: Dave
From: Dave Airlie
Ville suggested this, these tables are probably better being
standalone.
This fixes up the cnl/bxt interfaces to be like the others,
the intel one I left alone since it has a few extra entrypoints.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/Makefile
From: Dave Airlie
Daniel asked for this, but it's a bit messy and I'm not sure
how best to clean it up yet.
Signed-off-by: Dave Airlie
[Jani: also moved fdi buf trans to intel_fdi.c.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_crt.c | 1 +
drivers/gpu/drm/i915
From: Dave Airlie
This just refactors out the fdi code to a separate file.
Signed-off-by: Dave Airlie
[Jani: cleaned up intel_fdi.h a bit.]
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display
From: Dave Airlie
This file is a monster, let's start simple, the cursor plane code
seems pretty standalone, and splits out easily enough.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
[Jani: cleaned up intel_cursor.h a bit.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915
From: Dave Airlie
Ville suggested this as a good idea, let's move this before moving
the crtc code.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/Makefile| 3 +-
drivers/gpu/drm/i915/display/i9xx_plane.c| 704 +++
drivers
From: Dave Airlie
This function is going to be used in a later change, so clean it
up first before moving it.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 78 +--
.../drm/i915/display
From: Dave Airlie
There may be more crtc code that can be pulled out, but this
is a good start.
v2: move plane before this.
Signed-off-by: Dave Airlie
[Jani: cleaned up intel_crtc.h a bit.]
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/Makefile
Okay the first 8 patches of this should probably get landed, they have
all the tags in place.
The subsequent patches have seen some rework:
Added a patch to move the buf_trans to a separate file as suggested
by Ville. I reworked some of the interfaces while doing so, but only
minorly.
The skl
From: Dave Airlie
There is no need for a comma use here.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display
From: Dave Airlie
This will be used for some refactoring in other files, so move it
first.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 6 --
drivers/gpu/drm/i915/display/intel_display_types.h
From: Dave Airlie
There is no need for this to be out of line.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_display.c | 8
drivers/gpu/drm/i915/display/intel_display.h | 1 -
drivers/gpu/drm/i915/display/intel_display_types.h | 8
3 files
From: Dave Airlie
Daniel suggested this should move here.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_crtc.c | 230
drivers/gpu/drm/i915/display/intel_sprite.c | 228 ---
2
From: Dave Airlie
This just cleans these up a bit.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_sprite.c| 7 +++
drivers/gpu/drm/i915/display/skl_universal_plane.c | 4 ++--
2 files changed, 5 insertions
From: Dave Airlie
This just refactors out the fdi code to a separate file.
Signed-off-by: Dave Airlie
[Jani: cleaned up intel_fdi.h a bit.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/intel_display.c | 685
From: Dave Airlie
This pulls a large chunk of the pll calculation code out of
intel_display.c to a new file.
One function makes sense to be an inline, otherwise this
is pretty much a straight copy cover. Also all the
remaining hooks for g45 and older end up the same now.
Signed-off-by: Dave
From: Dave Airlie
Daniel asked for this, but it's a bit messy and I'm not sure
how best to clean it up yet.
Signed-off-by: Dave Airlie
[Jani: also moved fdi buf trans to intel_fdi.c.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_crt.c | 1 +
drivers/gpu/drm/i915
From: Dave Airlie
This function is going to be used in a later change, so clean it
up first before moving it.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 78 +--
.../drm/i915/display
From: Dave Airlie
Ville suggested this as a good idea, let's move this before moving
the crtc code.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/Makefile| 3 +-
drivers/gpu/drm/i915/display/i9xx_plane.c| 704 +++
drivers/gpu/drm/i915/display
From: Dave Airlie
There may be more crtc code that can be pulled out, but this
is a good start.
v2: move plane before this.
Signed-off-by: Dave Airlie
[Jani: cleaned up intel_crtc.h a bit.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile| 1 +
drivers/gpu/drm
From: Dave Airlie
There is no need for a comma use here.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display
From: Dave Airlie
This will be used for some refactoring in other files, so move it
first.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 6 --
drivers/gpu/drm/i915/display/intel_display_types.h
From: Dave Airlie
This file is a monster, let's start simple, the cursor plane code
seems pretty standalone, and splits out easily enough.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
[Jani: cleaned up intel_cursor.h a bit.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915
Thanks Jani for cleaning up the last bits, I started from your patches
and changed things around a little.
This move the i915 plane code to i9xx_plane.[ch]
The later skl plane now moves to skl_universal_plane.[ch]
I think I've also taken Ville's suggestsion on board for that file,
and I've use
From: Dave Airlie
Daniel suggested this should move here.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_crtc.c | 230
drivers/gpu/drm/i915/display/intel_sprite.c | 228 ---
2 files changed, 230 insertions(+), 228 deletions(-)
diff
From: Dave Airlie
This just refactors out the fdi code to a separate file.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/intel_display.c | 685 +-
.../drm/i915/display/intel_display_types.h| 9
201 - 300 of 781 matches
Mail list logo
