Re: [PATCH 00/13] Panel Replay eDP prepare

2024-06-11 Thread Hogander, Jouni
On Mon, 2024-06-10 at 09:30 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, June 7, 2024 7:19 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Kahola, Mika > > ; Hogande

Re: [PATCH v6 11/26] drm/i915/psr: Move vblank length check to separate function

2024-06-07 Thread Hogander, Jouni
On Fri, 2024-06-07 at 16:19 +0300, Hogander, Jouni wrote: > On Fri, 2024-06-07 at 11:09 +, Manna, Animesh wrote: > > > > > > > -Original Message----- > > > From: Hogander, Jouni > > > Sent: Thursday, June 6, 2024 9:12 PM > > > To: Manna

Re: [PATCH v6 11/26] drm/i915/psr: Move vblank length check to separate function

2024-06-07 Thread Hogander, Jouni
On Fri, 2024-06-07 at 11:09 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Thursday, June 6, 2024 9:12 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: Kahola, Mika >

Re: [PATCH v6 10/26] drm/i915/psr: Print Panel Replay status instead of frame lock status

2024-06-07 Thread Hogander, Jouni
On Fri, 2024-06-07 at 10:09 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, June 7, 2024 3:34 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: Kahola, Mika > > S

Re: [PATCH v6 10/26] drm/i915/psr: Print Panel Replay status instead of frame lock status

2024-06-07 Thread Hogander, Jouni
On Fri, 2024-06-07 at 09:59 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Thursday, June 6, 2024 9:08 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: Kahola, Mika >

Re: [PATCH v6 07/26] drm/i915/alpm: Make alpm support checks non-static

2024-06-06 Thread Hogander, Jouni
On Thu, 2024-06-06 at 14:44 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, June 5, 2024 3:56 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Kahola, Mika > > ; Hogander

Re: [PATCH v6 14/26] dmr/i915/psr: Wake time is aux less wake time for Panel Replay

2024-06-06 Thread Hogander, Jouni
On Thu, 2024-06-06 at 13:26 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, June 5, 2024 3:56 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Kahola, Mika > > ; Hogander

Re: [PATCH v6 11/26] drm/i915/psr: Move vblank length check to separate function

2024-06-06 Thread Hogander, Jouni
On Thu, 2024-06-06 at 14:58 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, June 5, 2024 3:56 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Kahola, Mika > > ; Hogander

Re: [PATCH v6 10/26] drm/i915/psr: Print Panel Replay status instead of frame lock status

2024-06-06 Thread Hogander, Jouni
On Thu, 2024-06-06 at 14:35 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, June 5, 2024 3:56 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Kahola, Mika > > ; Hogander

Re: Fixes that failed to pick to v6.10-rc2

2024-06-05 Thread Hogander, Jouni
On Wed, 2024-06-05 at 13:06 +0300, Jani Nikula wrote: > > Jouni, Animesh, there are some PSR commits with Fixes: pointing at > commits in v6.9 or v6.10-rc1. > > This does not apply cleanly to -rc1: > d07a578703db ("drm/i915/display: Do not print "psr: enabled" for on > Panel Replay") > > This

Re: [PATCH] drm/i915: Fix assert on pending async-put power domain work when it requeues itself

2024-06-04 Thread Hogander, Jouni
On Thu, 2024-05-30 at 13:53 +0300, Imre Deak wrote: > Commit dd839aa857eb ("drm/i915: Fix incorrect assert about pending > power domain async-put work") > > fixed the assert about a pending work dropping a display power > reference > asynchronously, leading to the > >

Re: [PATCH 0/6] Region Early Transport debugfs support

2024-06-03 Thread Hogander, Jouni
On Mon, 2024-06-03 at 07:30 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, May 29, 2024 3:09 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Kahola, Mika > > ; Hogand

Re: [PATCH 0/5] Panel Replay eDP debugfs support

2024-05-29 Thread Hogander, Jouni
On Wed, 2024-05-29 at 08:41 +0300, Hogander, Jouni wrote: > On Tue, 2024-05-28 at 14:44 +0300, Jouni Högander wrote: > > This is a subset of Panel Replay eDP patch set > > (https://patchwork.freedesktop.org/series/133684). This contains > > debugfs changes and is supposed to

Re: [PATCH 0/5] Panel Replay eDP debugfs support

2024-05-28 Thread Hogander, Jouni
On Tue, 2024-05-28 at 14:44 +0300, Jouni Högander wrote: > This is a subset of Panel Replay eDP patch set > (https://patchwork.freedesktop.org/series/133684). This contains > debugfs changes and is supposed to be safe to be merged alone  > Sending > here to get CI result for this subset before

Re: [PATCH v6 0/6] Link off between frames for edp

2024-05-27 Thread Hogander, Jouni
On Mon, 2024-05-27 at 13:56 +0530, Animesh Manna wrote: > Link Off Between Active Frames (LOBF) allows an eDP link to be turned > Off and On > durning long VBLANK durations without enabling any of the PSR/PSR2/PR > modes of operation. > > Bspec: 71477 > > Note: Lobf need to be enabled adaptive

Re: [PATCH v2 00/17] Panel Replay eDP support

2024-05-27 Thread Hogander, Jouni
On Fri, 2024-05-24 at 05:53 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Tuesday, May 21, 2024 2:17 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Kahola, Mika > > ; Hogander,

Re: [PATCH v2 04/17] drm/i915/psr: Move printing PSR mode to own function

2024-05-24 Thread Hogander, Jouni
On Fri, 2024-05-24 at 05:59 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Tuesday, May 21, 2024 2:17 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Kahola, Mika > > ; Hogander

Re: [PATCH v2 00/17] Panel Replay eDP support

2024-05-24 Thread Hogander, Jouni
On Fri, 2024-05-24 at 05:53 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Tuesday, May 21, 2024 2:17 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Kahola, Mika > > ; Hogander,

Re: [PATCH v2 01/17] drm/i915/psr: Store pr_dpcd in intel_dp

2024-05-24 Thread Hogander, Jouni
On Fri, 2024-05-24 at 05:55 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Tuesday, May 21, 2024 2:17 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Kahola, Mika > > ; Hogander

Re: [PATCH 04/13] drm/i915: Simplify PIPESRC_ERLY_TPT definition

2024-05-20 Thread Hogander, Jouni
On Mon, 2024-05-20 at 12:37 +0300, Jani Nikula wrote: > On Mon, 20 May 2024, Jani Nikula wrote: > > On Thu, 16 May 2024, Ville Syrjala > > wrote: > > > From: Ville Syrjälä > > > > > > PIPESRC_ERLY_TPT is a pipe register, and it lives in the 0x7 > > > range. > > > so using _MMIO_TRANS2()

Re: [PATCH 1/3] drm/i915/psr: LunarLake IO and Fast Wake time line count maximums are 63

2024-05-19 Thread Hogander, Jouni
On Fri, 2024-05-17 at 08:14 +, Shankar, Uma wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, May 17, 2024 1:02 PM > > To: Shankar, Uma ; > > intel-gfx@lists.freedesktop.org > > Subject: Re: [PATCH 1/3] drm/i91

Re: [PATCH 1/3] drm/i915/psr: LunarLake IO and Fast Wake time line count maximums are 63

2024-05-17 Thread Hogander, Jouni
On Fri, 2024-05-17 at 06:28 +, Shankar, Uma wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf > > Of Jouni > > Högander > > Sent: Friday, May 3, 2024 11:36 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Hogand

Re: [PATCH v10 00/12] Panel replay selective update support

2024-05-15 Thread Hogander, Jouni
On Fri, 2024-05-10 at 12:38 +0300, Jouni Högander wrote: > This patch set is implementing panel replay selective update support > for Intel hardware. These are now merged into drm-intel-next including "drm/panelreplay: dpcd register definition for panelreplay SU". Thank you Animesh and Maarten

Re: [PATCH v4 4/6] drm/i915/alpm: Add compute config for lobf

2024-05-13 Thread Hogander, Jouni
On Thu, 2024-05-09 at 11:01 +0530, Animesh Manna wrote: > Link Off Between Active Frames, is a new feature for eDP > that allows the panel to go to lower power state after > transmission of data. This is a feature on top of ALPM, AS SDP. > Add compute config during atomic-check phase. > > v1: RFC

Re: [PATCH v10 05/12] drm/panelreplay: dpcd register definition for panelreplay SU

2024-05-10 Thread Hogander, Jouni
On Fri, 2024-05-10 at 12:45 +0300, Jani Nikula wrote: > On Fri, 10 May 2024, Jouni Högander wrote: > > Add definitions for panel replay selective update > > > > v2: Remove unnecessary Cc from commit message > > > > Signed-off-by: Jouni Högander > > Reviewed-by: Animesh Manna > > Needs to be

Re: [PATCH v9 08/12] drm/i915/psr: Panel replay uses SRD_STATUS to track it's status

2024-05-09 Thread Hogander, Jouni
On Thu, 2024-05-09 at 15:13 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, May 3, 2024 12:04 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Hogander, Jouni > > > &g

Re: [PATCH 17/19] drm/i915: pass dev_priv explicitly to ALPM_CTL2

2024-05-06 Thread Hogander, Jouni
On Thu, 2024-05-02 at 13:40 +0300, Jani Nikula wrote: > On Tue, 30 Apr 2024, Rodrigo Vivi wrote: > > On Tue, Apr 30, 2024 at 01:10:11PM +0300, Jani Nikula wrote: > > > Avoid the implicit dev_priv local variable use, and pass dev_priv > > > explicitly to the ALPM_CTL2 register macro. > > > > > >

Re: [PATCH v3 0/6] Link off between frames for edp

2024-05-03 Thread Hogander, Jouni
On Thu, 2024-04-25 at 00:08 +0530, Animesh Manna wrote: > Link Off Between Active Frames (LOBF) allows an eDP link to be turned > Off and On > durning long VBLANK durations without enabling any of the PSR/PSR2/PR > modes of operation. You could describe a bit more about what this patch set is

Re: [PATCH v3 4/6] drm/i915/alpm: Add compute config for lobf

2024-05-03 Thread Hogander, Jouni
On Fri, 2024-05-03 at 08:42 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, May 3, 2024 12:49 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: dri-de...@lists.freedesk

Re: [PATCH v3 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-05-03 Thread Hogander, Jouni
On Fri, 2024-05-03 at 08:30 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, May 3, 2024 1:02 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: dri-de...@lists.freedesk

Re: [PATCH v3 5/6] drm/i915/alpm: Enable lobf from source in ALPM_CTL

2024-05-03 Thread Hogander, Jouni
On Fri, 2024-05-03 at 08:19 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, May 3, 2024 1:18 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: dri-de...@lists.freedesk

Re: [PATCH v3 5/6] drm/i915/alpm: Enable lobf from source in ALPM_CTL

2024-05-03 Thread Hogander, Jouni
On Thu, 2024-04-25 at 00:08 +0530, Animesh Manna wrote: > Set the Link Off Between Frames Enable bit in ALPM_CTL register. > > Note: Lobf need to be enabled adaptive sync fixed refresh mode > where vmin = vmax = flipline, which will arise after cmmr feature > enablement. Will add enabling

Re: [PATCH v3 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-05-03 Thread Hogander, Jouni
On Thu, 2024-04-25 at 00:08 +0530, Animesh Manna wrote: > For validation purpose add debugfs for LOBF. > > Signed-off-by: Animesh Manna > --- >  drivers/gpu/drm/i915/display/intel_alpm.c | 48 > +++ >  drivers/gpu/drm/i915/display/intel_alpm.h |  2 + >  

Re: [PATCH v3 4/6] drm/i915/alpm: Add compute config for lobf

2024-05-03 Thread Hogander, Jouni
On Thu, 2024-04-25 at 00:08 +0530, Animesh Manna wrote: > Link Off Between Active Frames, is a new feature for eDP > that allows the panel to go to lower power state after > transmission of data. This is a feature on top of ALPM, AS SDP. > Add compute config during atomic-check phase. > > v1: RFC

Re: [PATCH v8 01/11] drm/i915/psr: Rename has_psr2 as has_sel_update

2024-04-30 Thread Hogander, Jouni
On Mon, 2024-04-29 at 19:08 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Manna, Animesh > > Sent: Tuesday, April 30, 2024 12:24 AM > > To: Hogander, Jouni ; intel- > > g...@lists.freedesktop.org > > Subject: RE: [PAT

Re: [PATCH v8 01/11] drm/i915/psr: Rename has_psr2 as has_sel_update

2024-04-30 Thread Hogander, Jouni
On Mon, 2024-04-29 at 18:54 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Monday, April 29, 2024 5:38 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Hogander, Jouni > > > >

Re: [PATCH v7 06/11] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay

2024-04-29 Thread Hogander, Jouni
On Mon, 2024-04-29 at 11:45 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Manna, Animesh > > Sent: Monday, April 29, 2024 5:04 PM > > To: Hogander, Jouni ; intel- > > g...@lists.freedesktop.org > > Subject:

Re: [PATCH v7 06/11] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay

2024-04-29 Thread Hogander, Jouni
On Mon, 2024-04-29 at 11:02 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, April 19, 2024 5:42 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Hogander, Jouni > > > >

Re: [PATCH v8 6/6] drm/{i915,xe}: Implement fbdev emulation as in-kernel client

2024-04-23 Thread Hogander, Jouni
On Tue, 2024-04-23 at 13:13 +0200, Thomas Zimmermann wrote: > Hi > > Am 22.04.24 um 16:11 schrieb Hogander, Jouni: > > On Tue, 2024-04-09 at 10:04 +0200, Thomas Zimmermann wrote: > > > Replace all code that initializes or releases fbdev emulation > > > througho

Re: [PATCH v8 6/6] drm/{i915,xe}: Implement fbdev emulation as in-kernel client

2024-04-22 Thread Hogander, Jouni
On Tue, 2024-04-09 at 10:04 +0200, Thomas Zimmermann wrote: > Replace all code that initializes or releases fbdev emulation > throughout the driver. Instead initialize the fbdev client by a > single call to intel_fbdev_setup() after i915 has registered its > DRM device. Just like similar code in

Re: [PATCH v8 4/6] drm/{i915,xe}: Unregister in-kernel clients

2024-04-22 Thread Hogander, Jouni
On Tue, 2024-04-09 at 10:04 +0200, Thomas Zimmermann wrote: > Unregister all in-kernel clients before unloading the i915 driver. > For > other drivers, drm_dev_unregister() does this automatically. As i915 > and > xe do not use this helper, they have to perform the call by > themselves. > > Note

Re: [PATCH v8 1/6] drm/client: Export drm_client_dev_unregister()

2024-04-22 Thread Hogander, Jouni
On Tue, 2024-04-09 at 10:04 +0200, Thomas Zimmermann wrote: > Export drm_client_dev_unregister() for use by the i915 driver. The > driver does not use drm_dev_unregister(), so it has to clean up the > in-kernel DRM clients by itself. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Jouni

Re: [PATCH v10 0/6] QGV/SAGV related fixes

2024-04-19 Thread Hogander, Jouni
On Fri, 2024-04-05 at 14:35 +0300, Vinod Govindapillai wrote: > We have couple of customer issues, related to SAGV/QGV point > calculation. Those patches contain fixes plus some additional > debugs for those issues. For the whole set (with assumption you take care of that one naming change

Re: [PATCH v2 5/6] drm/i915/alpm: Enable lobf from source in ALPM_CTL

2024-04-16 Thread Hogander, Jouni
On Tue, 2024-04-16 at 08:20 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Monday, April 15, 2024 3:39 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: dri-de...@lists.fr

Re: [PATCH v2 4/6] drm/i915/alpm: Add compute config for lobf

2024-04-16 Thread Hogander, Jouni
On Tue, 2024-04-16 at 08:15 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Monday, April 15, 2024 3:36 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: dri-de...@lists.fr

Re: [PATCH v2 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-04-15 Thread Hogander, Jouni
On Fri, 2024-04-12 at 21:22 +0530, Animesh Manna wrote: > For validation purpose add debugfs for LOBF. > > Signed-off-by: Animesh Manna > --- >  drivers/gpu/drm/i915/display/intel_alpm.c | 47 > +++ >  drivers/gpu/drm/i915/display/intel_alpm.h |  2 + >  

Re: [PATCH v2 5/6] drm/i915/alpm: Enable lobf from source in ALPM_CTL

2024-04-15 Thread Hogander, Jouni
On Fri, 2024-04-12 at 21:22 +0530, Animesh Manna wrote: > Set the Link Off Between Frames Enable bit in ALPM_CTL register. > > Signed-off-by: Animesh Manna > --- >  drivers/gpu/drm/i915/display/intel_alpm.c  | 5 + >  drivers/gpu/drm/i915/display/intel_display_types.h | 1 + >  2 files

Re: [PATCH v2 4/6] drm/i915/alpm: Add compute config for lobf

2024-04-15 Thread Hogander, Jouni
On Fri, 2024-04-12 at 21:22 +0530, Animesh Manna wrote: > Link Off Between Active Frames, is a new feature for eDP > that allows the panel to go to lower power state after > transmission of data. This is a feature on top of ALPM, AS SDP. > Add compute config during atomic-check phase. > > v1: RFC

Re: [PATCH] drm/i915/psr: Use crtc_state->port_clock instead of intel_dp->link_rate

2024-04-11 Thread Hogander, Jouni
On Thu, 2024-04-11 at 05:32 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Tuesday, April 9, 2024 2:28 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Hogander, Jouni > > > &g

Re: [PATCH v4] drm/i915/panelreplay: Panel replay workaround with VRR

2024-04-10 Thread Hogander, Jouni
On Wed, 2024-04-10 at 07:35 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, April 10, 2024 12:54 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: vil

Re: [PATCH v4] drm/i915/panelreplay: Panel replay workaround with VRR

2024-04-10 Thread Hogander, Jouni
On Thu, 2024-03-28 at 10:13 +0530, Animesh Manna wrote: > Panel Replay VSC SDP not getting sent when VRR is enabled > and W1 and W2 are 0. So Program Set Context Latency in > TRANS_SET_CONTEXT_LATENCY register to at least a value of 1. > > HSD: 14015406119 > > v1: Initial version. > v2: Update

Re: [PATCH 0/8] Panel Replay fixes and clean ups

2024-04-08 Thread Hogander, Jouni
Hello All, These are now merged. Thank you Animesh for reviewing these patches. BR, Jouni Högander On Fri, 2024-04-05 at 14:35 +0300, Jouni Högander wrote: > This patch set is a subset of Panel Replay selective update support > set: > > https://patchwork.freedesktop.org/series/128193/ > > It

Re: [PATCH v2 02/17] drm/i915/psr: Disable PSR when bigjoiner is used

2024-04-07 Thread Hogander, Jouni
On Fri, 2024-04-05 at 22:34 +0300, Ville Syrjälä wrote: > On Fri, Apr 05, 2024 at 06:58:44AM +0000, Hogander, Jouni wrote: > > On Fri, 2024-04-05 at 00:34 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Bigjoiner seem to be causing all

Re: [PATCH v7 6/6] drm/i915: Implement fbdev emulation as in-kernel client

2024-04-05 Thread Hogander, Jouni
On Fri, 2024-04-05 at 10:59 +0200, Thomas Zimmermann wrote: > Hi > > Am 05.04.24 um 10:34 schrieb Hogander, Jouni: > [...] > > >   > > > diff --git a/drivers/gpu/drm/i915/i915_driver.c > > > b/drivers/gpu/drm/i915/i915_driver.c > > > index e0f13c6

Re: [PATCH v7 4/6] drm/i915: Initialize fbdev DRM client with callback functions

2024-04-05 Thread Hogander, Jouni
On Fri, 2024-03-01 at 14:42 +0100, Thomas Zimmermann wrote: > Initialize i915's fbdev client by giving an instance of struct > drm_client_funcs to drm_client_init(). Also clean up with > drm_client_release(). > > Doing this in i915 prevents fbdev helpers from initializing and > releasing the

Re: [PATCH v7 6/6] drm/i915: Implement fbdev emulation as in-kernel client

2024-04-05 Thread Hogander, Jouni
On Fri, 2024-03-01 at 14:42 +0100, Thomas Zimmermann wrote: > Replace all code that initializes or releases fbdev emulation > throughout the driver. Instead initialize the fbdev client by a > single call to intel_fbdev_setup() after i915 has registered its > DRM device. Just like similar code in

Re: [PATCH v7 5/6] drm/i915: Implement fbdev client callbacks

2024-04-05 Thread Hogander, Jouni
On Fri, 2024-03-01 at 14:42 +0100, Thomas Zimmermann wrote: > Move code from ad-hoc fbdev callbacks into DRM client functions > and remove the old callbacks. The functions instruct the client > to poll for changed output or restore the display. > > The DRM core calls both, the old callbacks and

Re: [PATCH v2 02/17] drm/i915/psr: Disable PSR when bigjoiner is used

2024-04-05 Thread Hogander, Jouni
On Fri, 2024-04-05 at 00:34 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Bigjoiner seem to be causing all kinds of grief to the PSR > code currently. I don't believe there is any hardware issue > but the code simply not handling this correctly. For now > just disable PSR when bigjoiner

Re: [PATCH v3 04/21] drm/i915/psr: Rename intel_psr_enabled

2024-04-02 Thread Hogander, Jouni
On Mon, 2024-02-05 at 04:50 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, February 2, 2024 1:17 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Subject:

Re: [PATCH v5 0/5] ALPM AUX-Less

2024-04-02 Thread Hogander, Jouni
On Thu, 2024-03-28 at 05:33 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, March 22, 2024 4:00 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Ville Syrjälä ; Manna, Animesh > >

Re: [PATCH 5/5] drm/i915/display: Implement Wa_16021440873

2024-03-28 Thread Hogander, Jouni
On Thu, 2024-03-28 at 12:57 +, Kahola, Mika wrote: > > -Original Message- > > From: Hogander, Jouni > > Sent: Tuesday, March 19, 2024 2:33 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Kahola, Mika ; Hogander, Jouni > > > > Subjec

Re: [PATCH v6 4/4] drm/i915/display: Increase number of fast wake precharge pulses

2024-03-14 Thread Hogander, Jouni
On Wed, 2024-03-13 at 16:01 +0200, Ville Syrjälä wrote: > On Wed, Mar 13, 2024 at 03:32:21PM +0200, Jouni Högander wrote: > > Increasing number of fast wake sync pulses seem to fix problems > > with > > certain PSR panels. This should be ok for other panels as well as > > the eDP > > specification

Re: [PATCH v3 6/6] drm/i915/psr: Do not write ALPM configuration for PSR1 or DP2.0 Panel Replay

2024-03-13 Thread Hogander, Jouni
On Wed, 2024-03-13 at 11:18 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, March 6, 2024 4:15 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Ville Syrjälä ; Manna, Animesh > >

Re: [PATCH v3 5/6] drm/i915/psr: Enable ALPM for eDP Panel replay

2024-03-13 Thread Hogander, Jouni
On Wed, 2024-03-13 at 11:15 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, March 6, 2024 4:15 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Ville Syrjälä ; Manna, Animesh > >

Re: [PATCH v3 3/6] drm/i915/psr: Calculate aux less wake time

2024-03-13 Thread Hogander, Jouni
On Wed, 2024-03-13 at 11:14 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, March 6, 2024 4:15 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Ville Syrjälä ; Manna, Animesh > >

Re: [PATCH v3 1/6] drm/display: Add missing aux less alpm wake related bits

2024-03-13 Thread Hogander, Jouni
On Wed, 2024-03-13 at 11:14 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, March 6, 2024 4:15 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Ville Syrjälä ; Manna, Animesh > >

Re: [PATCH v5 5/5] drm/i915/display: Increase number of fast wake precharge pulses

2024-03-13 Thread Hogander, Jouni
On Tue, 2024-03-12 at 18:44 +0200, Ville Syrjälä wrote: > On Fri, Mar 08, 2024 at 01:00:39PM +0200, Jouni Högander wrote: > > Increasing number of fast wake sync pulses seem to fix problems > > with > > certain PSR panels. This should be ok for other panels as well as > > the eDP > > specification

Re: [PATCH v5 4/5] drm/i915/psr: Add IO buffer wake times for LunarLake and beyond

2024-03-12 Thread Hogander, Jouni
On Fri, 2024-03-08 at 16:56 +0200, Ville Syrjälä wrote: > On Fri, Mar 08, 2024 at 04:39:55PM +0200, Ville Syrjälä wrote: > > On Fri, Mar 08, 2024 at 01:00:38PM +0200, Jouni Högander wrote: > > > IO buffer wake time used for IO wake calculation is dependent on > > > port clock > > > on LunarLake

Re: [RFC 2/3] drm/i915/alpm: Add compute config for lobf

2024-03-08 Thread Hogander, Jouni
On Mon, 2024-03-04 at 13:13 +0530, Animesh Manna wrote: > Link Off Between Active Frames, is a new feature for eDP > that allows the panel to go to lower power state after > transmission of data. This is a feature on top of ALPM, AS SDP. > Add compute config during atomic-check phase. > >

Re: [PATCH v4 4/5] drm/i915/psr: Add IO buffer wake times for LunarLake and beyond

2024-03-08 Thread Hogander, Jouni
On Fri, 2024-03-08 at 12:11 +0200, Ville Syrjälä wrote: > On Fri, Mar 08, 2024 at 08:39:36AM +0000, Hogander, Jouni wrote: > > On Thu, 2024-03-07 at 19:15 +0200, Ville Syrjälä wrote: > > > On Wed, Mar 06, 2024 at 10:34:26AM +0200, Jouni Högander wrote: > > > > IO buf

Re: [PATCH v4 4/5] drm/i915/psr: Add IO buffer wake times for LunarLake and beyond

2024-03-08 Thread Hogander, Jouni
On Thu, 2024-03-07 at 19:15 +0200, Ville Syrjälä wrote: > On Wed, Mar 06, 2024 at 10:34:26AM +0200, Jouni Högander wrote: > > IO buffer wake time used for IO wake calculation is dependent on > > port clock > > on LunarLake and beyond. Take this into account in > > get_io_buffer_wake_time. > > > >

Re: [PATCH v4 3/5] drm/i915/psr: Calculate IO wake and fast wake lines for DISPLAY_VER < 12

2024-03-08 Thread Hogander, Jouni
On Thu, 2024-03-07 at 19:16 +0200, Ville Syrjälä wrote: > On Wed, Mar 06, 2024 at 10:34:25AM +0200, Jouni Högander wrote: > > Bspec mentions 50 us for IO wake time and 32 us for fast wake time. > > 32 us > > is most probably wrong as it doesn't meet the specification as fast > > wake > > time is

Re: [PATCH 2/3] drm/i915/psr: Improve fast and IO wake lines calculation

2024-02-22 Thread Hogander, Jouni
On Wed, 2024-02-21 at 23:45 +0200, Ville Syrjälä wrote: > On Wed, Feb 21, 2024 at 09:16:22PM +0200, Ville Syrjälä wrote: > > On Wed, Feb 21, 2024 at 09:05:43PM +0200, Ville Syrjälä wrote: > > > On Wed, Feb 21, 2024 at 09:53:21AM +0200, Jouni Högander wrote: > > > > Current fast and IO wake lines

Re: [PATCH 3/3] drm/i915/display: Increase number of fast wake precharge pulses

2024-02-22 Thread Hogander, Jouni
On Wed, 2024-02-21 at 21:11 +0200, Ville Syrjälä wrote: > On Wed, Feb 21, 2024 at 09:53:22AM +0200, Jouni Högander wrote: > > Increasing number of fast wake sync pulses seem to fix problems > > with > > certain PSR panels. This should be ok for other panels as well as > > the eDP > > specification

Re: [PATCH 2/3] drm/i915/psr: Improve fast and IO wake lines calculation

2024-02-22 Thread Hogander, Jouni
Thank you Ville for checking my patch. Please see my responses inline below. On Wed, 2024-02-21 at 21:05 +0200, Ville Syrjälä wrote: > On Wed, Feb 21, 2024 at 09:53:21AM +0200, Jouni Högander wrote: > > Current fast and IO wake lines calculation is assuming fast wake > > sync > > length is 18

Re: [PATCH 2/2] drm/i915: Prevent HW access during init from connector get_modes hooks

2024-02-07 Thread Hogander, Jouni
On Tue, 2024-02-06 at 17:39 +0200, Imre Deak wrote: > Prevent accessing the HW from the get_modes hooks of connectors > deriving > the mode list from the display's EDID. drm_edid_connector_add_modes() > will return the mode list based on the EDID which was cached during a > previous

Re: [PATCH 1/2] drm/i915: Prevent HW access during init from SDVO TV get_modes hook

2024-02-07 Thread Hogander, Jouni
On Wed, 2024-02-07 at 16:16 +0200, Imre Deak wrote: > On Wed, Feb 07, 2024 at 03:45:15PM +0200, Hogander, Jouni wrote: > > On Wed, 2024-02-07 at 15:26 +0200, Hogander, Jouni wrote: > > > On Tue, 2024-02-06 at 17:39 +0200, Imre Deak wrote: > > > > Prevent accessing the

Re: [PATCH] drm/i915/panelreplay: Panel replay workaround with VRR

2024-02-07 Thread Hogander, Jouni
On Wed, 2024-02-07 at 20:05 +0530, Animesh Manna wrote: > Panel Replay VSC SDP not getting sent when VRR is enabled > and W1 and W2 are 0. So Program Set Context Latency in > TRANS_SET_CONTEXT_LATENCY register to at least a value of 1. Do you have Bspec number. You could add it here. > >

Re: [PATCH 1/2] drm/i915: Prevent HW access during init from SDVO TV get_modes hook

2024-02-07 Thread Hogander, Jouni
On Wed, 2024-02-07 at 15:26 +0200, Hogander, Jouni wrote: > On Tue, 2024-02-06 at 17:39 +0200, Imre Deak wrote: > > Prevent accessing the HW from the SDVO/TV get_modes connector hook. > > Returning 0 from the hook will make the caller - > > drm_helper_probe_single_con

Re: [PATCH 1/2] drm/i915: Prevent HW access during init from SDVO TV get_modes hook

2024-02-07 Thread Hogander, Jouni
On Tue, 2024-02-06 at 17:39 +0200, Imre Deak wrote: > Prevent accessing the HW from the SDVO/TV get_modes connector hook. > Returning 0 from the hook will make the caller - > drm_helper_probe_single_connector_modes() - keep the previously > detected > mode list of the connector. I don't see where

Re: [PATCH v3 1/4] drm/i915/alpm: Add ALPM register definitions

2024-02-07 Thread Hogander, Jouni
On Tue, 2024-02-06 at 15:25 +, Murthy, Arun R wrote: > > > -Original Message- > > From: Hogander, Jouni > > Sent: Tuesday, January 30, 2024 4:41 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Murthy, Arun R ; Hogander, Jouni > > ; Nikula

Re: [PATCH v3 11/21] drm/i915/psr: Modify VSC SDP calculation to support panel replay + su

2024-02-05 Thread Hogander, Jouni
On Fri, 2024-02-02 at 13:58 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, January 19, 2024 3:40 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Hogander, Jouni > >

Re: [PATCH v3 06/21] drm/i915/psr: Check possible errors for panel replay as well

2024-02-02 Thread Hogander, Jouni
On Fri, 2024-02-02 at 08:10 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, January 19, 2024 3:40 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Hogander, Jouni > >

Re: [PATCH v3 04/21] drm/i915/psr: Rename intel_psr_enabled

2024-02-01 Thread Hogander, Jouni
On Fri, 2024-02-02 at 07:34 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Friday, January 19, 2024 3:40 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Hogander, Jouni > >

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-31 Thread Hogander, Jouni
On Tue, 2024-01-23 at 12:28 +0200, Imre Deak wrote: > Add support for Display Port DP tunneling. For now this includes the > support for Bandwidth Allocation Mode, leaving adding Panel Replay > support for later. > > BWA allows using displays that share the same (Thunderbolt) link with > their

Re: [PATCH v2 4/4] drm/i915/alpm: Alpm aux wake configuration for lnl

2024-01-30 Thread Hogander, Jouni
On Tue, 2024-01-30 at 08:28 +, Murthy, Arun R wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf > > Of Jouni > > Högander > > Sent: Friday, January 5, 2024 7:45 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH v2 4/4] drm/i915/alpm: Alpm aux wake

Re: [PATCH 03/19] drm/i915/dp: Add support to notify MST connectors to retry modesets

2024-01-29 Thread Hogander, Jouni
On Tue, 2024-01-23 at 12:28 +0200, Imre Deak wrote: > On shared (Thunderbolt) links with DP tunnels, the modeset may need > to > be retried on all connectors on the link due to a link BW limitation > arising only after the atomic check phase. To support this add a > helper > function queuing a

Re: [PATCH v2 3/4] drm/i915/alpm: Calculate ALPM Entry check

2024-01-28 Thread Hogander, Jouni
On Mon, 2024-01-29 at 02:08 +, Murthy, Arun R wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf > > Of Jouni > > Högander > > Sent: Friday, January 5, 2024 7:45 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH v2 3/4] drm/i915/alpm: Calculate ALPM Entry

Re: [PATCH v2 2/4] drm/i915/psr: Add alpm_parameters struct

2024-01-24 Thread Hogander, Jouni
On Wed, 2024-01-24 at 09:28 +, Murthy, Arun R wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, January 24, 2024 2:55 PM > > To: Murthy, Arun R ; > > intel-gfx@lists.freedesktop.org > > Subject: Re: [PATCH

Re: [PATCH v2 2/4] drm/i915/psr: Add alpm_parameters struct

2024-01-24 Thread Hogander, Jouni
On Wed, 2024-01-24 at 09:17 +, Murthy, Arun R wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf > > Of Jouni > > Högander > > Sent: Friday, January 5, 2024 7:45 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH v2 2/4] drm/i915/psr: Add alpm_parameters

Re: [PATCH] drm/i915/psr: Request modeset on initial commit to compute PSR state

2024-01-23 Thread Hogander, Jouni
On Tue, 2024-01-23 at 10:07 +0200, Ville Syrjälä wrote: > On Tue, Jan 23, 2024 at 07:57:00AM +0000, Hogander, Jouni wrote: > > On Tue, 2024-01-23 at 09:41 +0200, Ville Syrjälä wrote: > > > On Tue, Jan 23, 2024 at 09:11:03AM +0200, Jouni Högander wrote: > > > > W

Re: [PATCH] drm/i915/psr: Request modeset on initial commit to compute PSR state

2024-01-22 Thread Hogander, Jouni
On Tue, 2024-01-23 at 09:41 +0200, Ville Syrjälä wrote: > On Tue, Jan 23, 2024 at 09:11:03AM +0200, Jouni Högander wrote: > > We want to request full modeset in initial fast check to force PSR > > state > > computation. Otherwise PSR is not enabled on initial commit but on > > first > > commit

Re: [PATCH] drm/i915/psr: Only allow PSR in LPSP mode on HSW non-ULT

2024-01-19 Thread Hogander, Jouni
On Thu, 2024-01-18 at 23:21 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > On HSW non-ULT (or at least on Dell Latitude E6540) external displays > start to flicker when we enable PSR on the eDP. We observe a much > higher > SR and PC6 residency than should be possible with an external >

Re: [PATCH v2 8/9] drm/i915: Perform vblank evasion around legacy cursor updates

2024-01-18 Thread Hogander, Jouni
On Tue, 2024-01-16 at 22:49 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Our legacy cursor updates are actually mailbox updates. > Ie. the hardware latches things once per frame on start of > vblank, but we issue an number of updates per frame, > withough any attempt to synchronize

Re: [PATCH v2 8/9] drm/i915: Perform vblank evasion around legacy cursor updates

2024-01-17 Thread Hogander, Jouni

Re: [PATCH v2 8/9] drm/i915: Perform vblank evasion around legacy cursor updates

2024-01-17 Thread Hogander, Jouni

Re: [PATCH 2/2] drm/i915/psr: CAN_PSR and CAN_PANEL_REPLAY can be now local defines

2024-01-14 Thread Hogander, Jouni
On Wed, 2024-01-10 at 14:55 +0200, Lisovskiy, Stanislav wrote: > On Tue, Jan 09, 2024 at 12:05:17PM +0200, Jouni Högander wrote: > > CAN_PSR and CAN_PANEL_REPLAY are not used outside intel_psr.c > > anymore. Make > > them as intel_psr.c local defines. > > > > Signed-off-by: Jouni Högander > >

Re: [PATCH] drm/xe/display: Disable aux ccs framebuffers

2024-01-12 Thread Hogander, Jouni
On Wed, 2024-01-10 at 15:09 -0500, Rodrigo Vivi wrote: > On Tue, Jan 09, 2024 at 08:40:24PM +, Souza, Jose wrote: > > On Mon, 2024-01-08 at 17:18 -0500, Rodrigo Vivi wrote: > > > On Tue, Jan 02, 2024 at 09:44:48PM +0200, Jani Nikula wrote: > > > > On Tue, 02 Jan 2024, Juha-Pekka Heikkila > > >

Re: [PATCH v2 08/13] drm/i915/psr: Add sink_panel_replay_su_support to intel_psr

2024-01-12 Thread Hogander, Jouni
On Fri, 2024-01-12 at 11:19 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf > > Of Jouni > > Högander > > Sent: Wednesday, January 10, 2024 6:43 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH v2 08/13] drm/i915/psr: Add > >

Re: [PATCH v2 03/13] drm/i915/psr: Do not check alpm on DP or capability change for panel replay

2024-01-10 Thread Hogander, Jouni
On Thu, 2024-01-11 at 06:14 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf > > Of Jouni > > Högander > > Sent: Wednesday, January 10, 2024 6:43 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH v2 03/13] drm/i915/psr: Do not check alpm

  1   2   3   4   >