Re: [RFC PATCH 0/3] Introducing I915_FORMAT_MOD_4_TILED_XE2_CCS Modifier for Xe2

2024-05-14 Thread Joonas Lahtinen
Quoting Kenneth Graunke (2024-05-11 03:58:34) > On Tuesday, May 7, 2024 3:56:57 PM PDT Matt Roper wrote: > > On Mon, May 06, 2024 at 09:52:35PM +0300, Juha-Pekka Heikkila wrote: > > > These patches introduce I915_FORMAT_MOD_4_TILED_XE2_CCS modifier, which, > > > from the kernel's perspective,

[PULL] drm-intel-gt-next

2024-04-26 Thread Joonas Lahtinen
Hi Dave & Sima, Here's the drm-intel-gt-next PR for v6.10 in one shot. We are adding a new uAPI for Mesa to request higher GT frequency for compute contexts on GuC platform. Then there is a W/A for DG2 to move to fixed CCS load balancing and make all DG2 SKUs appear with single CCS with all the

Re: [PATCH] drm/i915: Add includes for BUG_ON/BUILD_BUG_ON in i915_memcpy.c

2024-03-19 Thread Joonas Lahtinen
Pushed this, thanks for the review. Regards, Joonas Quoting Vivi, Rodrigo (2024-03-18 14:40:56) > On Thu, 2024-03-14 at 14:48 +0200, Joonas Lahtinen wrote: > > Quoting Rodrigo Vivi (2024-03-08 16:58:04) > > > On Fri, Mar 08, 2024 at 04:46:43PM +0200, Joonas Lahtinen wrote: >

Re: [PATCH] drm/i915: Add includes for BUG_ON/BUILD_BUG_ON in i915_memcpy.c

2024-03-14 Thread Joonas Lahtinen
Quoting Rodrigo Vivi (2024-03-08 16:58:04) > On Fri, Mar 08, 2024 at 04:46:43PM +0200, Joonas Lahtinen wrote: > > Add standalone includes for BUG_ON and BUILD_BUG_ON to avoid build failure > > after linux-next include refactoring. > > any lore link so we can use

[PATCH] drm/i915: Add includes for BUG_ON/BUILD_BUG_ON in i915_memcpy.c

2024-03-08 Thread Joonas Lahtinen
Add standalone includes for BUG_ON and BUILD_BUG_ON to avoid build failure after linux-next include refactoring. Signed-off-by: Joonas Lahtinen Cc: Chris Wilson Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_memcpy.c | 2 ++ 1 file changed, 2 insertions

Re: linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2024-03-07 Thread Joonas Lahtinen
Quoting Stephen Rothwell (2024-03-07 04:10:27) > Hi all, > > Today's linux-next merge of the drm tree got a conflict in: > > drivers/gpu/drm/i915/display/intel_dp.c > > between commit: > > 984318aaf7b6 ("drm/i915/panelreplay: Move out psr_init_dpcd() from > init_connector()") > > from

[PULL] drm-intel-fixes

2024-03-07 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes the final drm-intel-fixes for v6.8. This PR will appear to contain more patches than it does. It's 4 patches on top of drm-fixes after Sima pulled the previous PR as you can observe from git log. Fixes for kernel crash on UHD 730, boot delay regression on PSR, DP DSC

Re: [PATCH v3 1/4] drm/i915/gt: Refactor uabi engine class/instance list creation

2024-03-05 Thread Joonas Lahtinen
Quoting Andi Shyti (2024-03-01 01:28:56) > For the upcoming changes we need a cleaner way to build the list > of uabi engines. > > Suggested-by: Tvrtko Ursulin > Signed-off-by: Andi Shyti > --- > drivers/gpu/drm/i915/gt/intel_engine_user.c | 29 - > 1 file changed, 17

[PULL] drm-intel-fixes

2024-03-01 Thread Joonas Lahtinen
Hi Dave & Sima, Here's the drm-intel-fixes towards v6.8(-rc7). One NULL check for mmu notifier and HDCP fix to read from primary connector. Regards, Joonas *** drm-intel-fixes-2024-03-01: - Fix to extract HDCP information from primary connector - Check for NULL mmu_interval_notifier before

Re: [PATCH] MAINTAINERS: Update email address for Tvrtko Ursulin

2024-02-29 Thread Joonas Lahtinen
to the > main one. > > Signed-off-by: Tvrtko Ursulin > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi Acked-by: Joonas Lahtinen Regards, Joonas

[PULL] drm-intel-fixes

2024-02-22 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes drm-intel-fixes for v6.8-rc6. Just a single fixup patch for TV mode. Best Regards, Joonas *** drm-intel-fixes-2024-02-22: - Fixup for TV mode The following changes since commit b401b621758e46812da61fa58a67c3fd8d91de0d: Linux 6.8-rc5 (2024-02-18 12:56:25 -0800)

Re: [PULL] drm-intel-gt-next

2024-02-20 Thread Joonas Lahtinen
Quoting Joonas Lahtinen (2024-02-16 11:41:44) > (+ Jonathan) > > Quoting Dave Airlie (2024-02-16 04:58:03) > > On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin > > wrote: > > > > > > Hi Dave, Daniel, > > > > > > First pull request for 6.

Re: [PULL] drm-intel-gt-next

2024-02-16 Thread Joonas Lahtinen
(+ Jonathan) Quoting Dave Airlie (2024-02-16 04:58:03) > On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin > wrote: > > > > Hi Dave, Daniel, > > > > First pull request for 6.9 with probably one more coming in one to two > > weeks. > > > > Nothing to interesting in this one, mostly a sprinkle of small

[PULL] drm-intel-fixes

2024-02-15 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes drm-intel-fixes towards v6.8-rc5. Two fixes. Fix for #10172 (blank screen on JSL Chromebooks) and limiting SST link rate within supported range. Best Regards, Joonas *** drm-intel-fixes-2024-02-15: Fix for #10172: Blank screen on JSL Chromebooks. Stable fix to limit

[PULL] drm-intel-fixes

2024-02-08 Thread Joonas Lahtinen
2024-02-05 15:56:47 +0200) - Just includes gvt-fixes-2024-02-05 Dan Carpenter (1): drm/i915/gvt: Fix uninitialized variable in handle_mmio() Joonas Lahtine

Re: [RFC] drm/i915: Add GuC submission interface version query

2024-02-07 Thread Joonas Lahtinen
a single-shot init time query so I guess u64 is fine too, to keep the code straightforward. > Compile tested only. If Mesa folks confirm this is working for them and after you add link to the Mesa PR, then you can add my: Reviewed-by: Joonas Lahtinen Regards, Joonas > Signed-off-by: Tvrtko

Re: [RFC PATCH] drm/i915: Add GETPARAM for GuC submission version

2024-02-07 Thread Joonas Lahtinen
n Wed, 2024-01-24 at 08:55 +, Tvrtko Ursulin wrote: > >>>>> On 24/01/2024 08:19, Joonas Lahtinen wrote: > >>>>>> Add reporting of the GuC submissio/VF interface version via GETPARAM > >>>>>> properties. Mesa intends to use this

Re: [PULL] gvt-fixes

2024-02-01 Thread Joonas Lahtinen
Hi Zhenyu, I'm getting the following: dim: ff833b32ccc4 ("drm/i915: Replace dead 01.org link"): mandatory review missing. dim: ERROR: issues in commits detected, aborting Can you fix the commit? Regards, Joonas Quoting Zhenyu Wang (2024-01-31 11:38:51) > > Hi, Joonas > > Here is another

[PULL] drm-intel-fixes

2024-01-26 Thread Joonas Lahtinen
Hi Dave & Sima, Just one Cc stable patch (the rest was already in drm-intel-next-fixes). Tried to wait for CI results, but none yet. Best Regards, Joonas *** drm-intel-fixes-2024-01-26: - PSR fix for HSW The following changes since commit 6613476e225e090cc9aad49be7fa504e290dd33d: Linux

[RFC PATCH] drm/i915: Add GETPARAM for GuC submission version

2024-01-24 Thread Joonas Lahtinen
Add reporting of the GuC submissio/VF interface version via GETPARAM properties. Mesa intends to use this information to check for old firmware versions with known bugs before enabling features like async compute. Signed-off-by: Joonas Lahtinen Cc: Kenneth Graunke Cc: Jose Souza Cc: Sagar

[PULL] drm-intel-next-fixes

2024-01-19 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes drm-intel-next-fixes for v6.8. Build warning fix for GCC11, fix for #10071 and DP test pattern fix, one OA fix for XeHP+. Regards, Joonas *** drm-intel-next-fixes-2024-01-19: - DSI sequence revert to fix GitLab #10071 and DP test-pattern fix - Drop

[PULL] drm-intel-next-fixes

2024-01-11 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes drm-intel-next-fixes towards 6.8 merge window now that drm-intel-gt-next is also merged. Most importantly fixes for linux-next added build warnings and then a couple display fixes. CI results for drm-next seem to have regressed with regards to the shard runs somewhere

Re: disable large folios for shmem file used by xfs xfile

2024-01-10 Thread Joonas Lahtinen
Quoting Joonas Lahtinen (2024-01-10 17:20:24) > Quoting Matthew Wilcox (2024-01-10 14:37:18) > > On Wed, Jan 10, 2024 at 10:21:07AM +0100, Christoph Hellwig wrote: > > > Hi all, > > > > > > Darrick reported that the fairly new XFS xfile code blows up w

Re: disable large folios for shmem file used by xfs xfile

2024-01-10 Thread Joonas Lahtinen
Quoting Matthew Wilcox (2024-01-10 14:37:18) > On Wed, Jan 10, 2024 at 10:21:07AM +0100, Christoph Hellwig wrote: > > Hi all, > > > > Darrick reported that the fairly new XFS xfile code blows up when force > > enabling large folio for shmem. This series fixes this quickly by disabling > > large

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-08 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2024-01-05 12:39:31) > > On 04/01/2024 21:23, Andi Shyti wrote: > >>> +void intel_gt_apply_ccs_mode(struct intel_gt *gt) > >>> +{ > >>> + mutex_lock(>ccs.mutex); > >>> + __intel_gt_apply_ccs_mode(gt); > >>> + mutex_unlock(>ccs.mutex); > >>> +} > >>> + > >>> +void

Re: [PATCH 1/3] drm/i915/gt: Support fixed CCS mode

2023-12-22 Thread Joonas Lahtinen
tings. It involves assigning only one CCS to all > the slices. > > Based on a patch by Chris Wilson > and Tejas Upadhyay . > > Signed-off-by: Andi Shyti > Cc: Chris Wilson > Cc: Joonas Lahtinen > Cc: Niranjana Vishwanathapura > Cc: Tejas Upadhyay > +++ b/drivers/g

[PULL] drm-intel-gt-next

2023-12-15 Thread Joonas Lahtinen
Hi Dave & Sima, Final drm-intel-gt-next PR for v6.8. Elimination of kmap_atomic() from the driver to allow kernel wide cleanup. One new DG2 W/A and static checker/spelling fixes. Best Regards, Joonas *** drm-intel-gt-next-2023-12-15: Driver Changes: - Eliminate use of kmap_atomic() in i915

Re: [PATCH 04/12] drm/i915: Bypass LMEMBAR/GTTMMADR for MTL stolen memory access

2023-12-13 Thread Joonas Lahtinen
Quoting Ville Syrjala (2023-12-13 02:42:29) > From: Ville Syrjälä > > On MTL accessing stolen memory via the BARs is somehow borked, > and it can hang the machine. As a workaround let's bypass the > BARs and just go straight to DSMBASE/GSMBASE instead. > > Note that on every other platform this

[PULL] drm-intel-gt-next

2023-12-08 Thread Joonas Lahtinen
Hi Dave & Sima, A rather late first drm-intel-gt-next PR towards v6.8. As most significant change we have addition of the DRM fdinfo memory stats functionality. Then DG2 and MTL workaround additions and fixes and a few for older platforms as well. PMU WARN_ON splat cleanup. The rest is mostly

[Intel-gfx] [PULL] drm-intel-gt-next

2023-08-11 Thread Joonas Lahtinen
null pointer deref in GuC 'steal id' test Jonathan Cavitt (3): drm/i915/gt: Simplify shmem_create_from_object map_type selection drm/i915: Make i915_coherent_map_type GT-centric drm/i915/gt: Apply workaround 22016122933 correctly Joonas Lahtinen (1): Merge drm/drm-next into

[Intel-gfx] [PULL] drm-intel-gt-next

2023-08-04 Thread Joonas Lahtinen
Hi Dave & Daniel, Here goes the first drm-intel-gt-next PR for v6.6. We have a fix for infinite GPU wait race condition found by CI, then improved tweakability of RPS algo and fixes to GuC SLPC for tuning the frequency behavior of the system. OA report zeroing fix, Aux CCS invalidation fix on

[Intel-gfx] [PULL] drm-intel-fixes

2023-06-08 Thread Joonas Lahtinen
Hi Dave & Daniel, Here's the drm-intel-fixes PR for v6.4-rc6. Couple of display compatibility fixes and two static checker fixes for selftests. Regards, Joonas *** drm-intel-fixes-2023-06-08: CDCLK voltage fix for ADL-P and eDP wake sync pulse fix. Two error handling fixes to selftests (to

Re: [Intel-gfx] [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Joonas Lahtinen
Quoting Andi Shyti (2023-06-06 13:18:06) > On Tue, Jun 06, 2023 at 11:10:04AM +0100, Tvrtko Ursulin wrote: > > > > On 06/06/2023 11:00, Andi Shyti wrote: > > > From: Fei Yang > > > > > > To comply with the design that buffer objects shall have immutable > > > cache setting through out their

Re: [Intel-gfx] [PATCH v15 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Joonas Lahtinen
Quoting Yang, Fei (2023-06-06 09:51:06) > >> On 31/05/2023 18:10, fei.y...@intel.com wrote: > >>> From: Fei Yang > >>> > >>> To comply with the design that buffer objects shall have immutable > >>> cache setting through out their life cycle, {set, get}_caching ioctl's > >>> are no longer

[Intel-gfx] [PULL] drm-intel-fixes

2023-06-01 Thread Joonas Lahtinen
Hi Dave & Daniel, One fix appeared this morning, related to OA API for non-power-of-two reports. Full CI results not in yet, BAT is looking good so please check before pulling the trigger. Regards, Joonas *** drm-intel-fixes-2023-06-01: - Fix for OA reporting to allow detecting

[Intel-gfx] [PULL] drm-intel-fixes

2023-05-25 Thread Joonas Lahtinen
Hi Dave & Daniel, Here goes drm-intel-fixes for v4.6-rc4. Again just one fix, for pipejoiner config pipe disabling. Regards, Joonas *** drm-intel-fixes-2023-05-25: PIPEDMC disabling fix for bigjoiner config The following changes since commit 44c026a73be8038f03dbdeef028b642880cf1511:

[Intel-gfx] Extension detection by enumeration vs attempt to use extension (Was: Re: [PATCH v10 2/2] drm/i915: Allow user to set cache at BO creation)

2023-05-25 Thread Joonas Lahtinen
Quoting Jordan Justen (2023-05-21 07:30:52) > On 2023-05-18 22:11:03, wrote: > > From: Fei Yang > > > > To comply with the design that buffer objects shall have immutable > > cache setting through out their life cycle, {set, get}_caching ioctl's > > are no longer supported from MTL onward. With

[Intel-gfx] [PULL] drm-intel-fixes

2023-05-17 Thread Joonas Lahtinen
Hi Dave & Daniel, Here goes drm-intel-fixes for v6.4-rc3. Just one missing null check addition for HDCP code. Regards, Joonas *** drm-intel-fixes-2023-05-17: Add missing null check for HDCP code. The following changes since commit f1fcbaa18b28dec10281551dfe6ed3a3ed80e3d6: Linux 6.4-rc2

[Intel-gfx] [PULL] drm-intel-fixes

2023-05-11 Thread Joonas Lahtinen
Hi Dave & Daniel, Here goes drm-intel-fixes for v6.4-rc2. Important fix to taint kernel when force_probe is used, two display fixes (null deref/div-by-zero) and a GuC error capture register list correction. Regards, Joonas PS. Again had to remove one commit with incorrect Fixes: tag so check

[Intel-gfx] [PULL] drm-intel-next-fixes

2023-05-04 Thread Joonas Lahtinen
Hi Dave & Daniel, One Cc stable DSI sequence fix and missing CPU transcoders for MTL plus a smaller GuC cornern case fix. Best Regards, Joonas *** drm-intel-next-fixes-2023-05-04-1: Add missing GPU transcoder masks for MTL and fix DSI power on sequence for Nextbook Ares 8A. Fix GuC version

Re: [Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEM_CREATE_EXTENSIONS query item

2023-05-02 Thread Joonas Lahtinen
be implemented for the drm/xe driver. Regards, Joonas Quoting Jordan Justen (2023-05-02 23:57:44) > Cc: Fei Yang > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen > Cc: Daniel Vetter > Signed-off-by: Jordan Justen > --- > drivers/gpu/drm/i915/gem/i915_gem_create.c | 30

[Intel-gfx] [PULL] drm-intel-next-fixes

2023-04-27 Thread Joonas Lahtinen
Hi Dave & Daniel, Just one Cc stable SKL+ pipe source size fix for #8357: CML-U: external 5120x2160 monitor can't play video. Best Regards, Joonas *** drm-intel-next-fixes-2023-04-27: One cc stable for pipe source size check on SKL+ The following changes since commit

[Intel-gfx] IOCTL feature detection (Was: Re: [PATCH 8/8] drm/i915: Allow user to set cache at BO creation)

2023-04-25 Thread Joonas Lahtinen
(+ Faith and Daniel as they have been involved in previous discussions) Quoting Jordan Justen (2023-04-24 20:13:00) > On 2023-04-24 02:08:43, Tvrtko Ursulin wrote: > > > > Being able to "list" supported extensions sounds like a reasonable > > principle, albeit a departure from the design

[Intel-gfx] [PULL] drm-intel-next-fixes

2023-04-20 Thread Joonas Lahtinen
Hi Dave & Daniel, Here's another drm-intel-next-fixes pull request. One Cc stable CSC plane index fix, then MST PLL fix and smaller null/oob/leak fixes. Regards, Joonas *** drm-intel-next-fixes-2023-04-20-1: Active port PLL MST fix for second stream, CSC plane index fix, null and oob array

[Intel-gfx] [PULL] drm-intel-next-fixes

2023-04-13 Thread Joonas Lahtinen
Hi Dave & Daniel, Just one Cc:stable fix for indirect sampler state this week on drm-intel-next-fixes. Regards, Joonas *** drm-intel-next-fixes-2023-04-13: Short summary of fixes pull (less than what git shortlog provides): Just one Cc:stable fix for sampler indirect state in bindless heap.

[Intel-gfx] [PULL] drm-intel-gt-next

2023-04-06 Thread Joonas Lahtinen
Hi Dave & Daniel, Here goes the final drm-intel-gt-next pull request for v6.4. As top items we have a fix for context runtime accounting, Meteorlake enabling, DMAR error noise elimination due to GPU error capture, BAR resizing forcewake fix and memory contents clearing fix for discrete. More

[Intel-gfx] [PULL] drm-intel-gt-next

2023-03-16 Thread Joonas Lahtinen
Hi Dave & Daniel, Here's the first batch of drm-intel-gt-next towards v6.4. There is an important performance monitoring fix (#6333), more resiliency to pcode load delay and avoiding caching problems on LLC systems for ring buffers. Stolen memory probing fix and a missing register whitelisting

Re: [Intel-gfx] [PATCH v3] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-15 Thread Joonas Lahtinen
(+ Tvrtko as FYI) Zhenyu, can you take a look at the patch ASAP. Regards, Joonas Quoting Dave Airlie (2022-10-27 08:12:31) > On Thu, 27 Oct 2022 at 13:26, Zheng Hacker wrote: > > > > Dave Airlie 于2022年10月27日周四 08:01写道: > > > > > > On Fri, 7 Oct 2022 at 11:38, Zheng Wang wrote: > > > > > > >

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/mtl: Add OA support by enabling 32 bit OAG formats for MTL

2022-12-12 Thread Joonas Lahtinen
(Switching to my @linux.intel.com address) Quoting Umesh Nerlige Ramappa (2022-12-08 19:08:46) > On Wed, Nov 30, 2022 at 05:05:35PM -0800, Umesh Nerlige Ramappa wrote: > >Without an entry in oa_init_supported_formats, OA will not be functional > >in MTL. Enable OA support by enabling 32 bit OAG

[Intel-gfx] [PULL] drm-intel-gt-next

2022-11-18 Thread Joonas Lahtinen
rison (3): drm/i915/guc: Remove excessive line feeds in state dumps drm/i915/guc: Properly initialise kernel contexts drm/i915/guc: Don't deadlock busyness stats vs reset Joonas Lahtinen (1): Merge drm/drm-next into drm-intel-gt-next Lucas De Marchi (2): Documentat

[Intel-gfx] [PULL] drm-intel-gt-next

2022-11-03 Thread Joonas Lahtinen
Hi Dave & Daniel, This amends the previous PR that did cause a build error with clang: https://lists.freedesktop.org/archives/dri-devel/2022-October/377713.html Quite naturally, it includes a fix to the hwmon code tested with Clang version 14.0.5 and GCC 12.2.1. Additionally there is a screen

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

2022-11-02 Thread Joonas Lahtinen
Quoting Jani Nikula (2022-10-28 11:46:21) > On Fri, 28 Oct 2022, Gwan-gyeong Mun wrote: > > Resend, because some content was accidentally omitted from the previous > > reply. > > Please ignore the previous email. > > > > Hi all, > > > > I should have written the original commit message more

[Intel-gfx] [PULL] drm-intel-gt-next

2022-10-31 Thread Joonas Lahtinen
Hi Dave & Daniel, Here goes first drm-intel-gt-next pull req towards 6.2. We have a fix for #6222 (kernel memory corruption issue) and fix for display regression after resume. A missing W/A for Gen12 iGPUs and extension of compute pre-emption timeout to 7.5 seconds to account for compute corner

Re: [Intel-gfx] [PATCH] drm/i915/dgfx: Temporary hammer to keep autosuspend control 'on'

2022-10-12 Thread Joonas Lahtinen
I think I commented on this already, but the patch subject should really be as informative as possible like: "Disable PCI runtime PM on dGPUs" as that is exactly what the patch does. Also bit unsure if the Fixes: tag should really point to the runtime PM commit but maybe instead to the

[Intel-gfx] [PULL] drm-intel-gt-next

2022-09-16 Thread Joonas Lahtinen
Hi Dave & Daniel, Here goes the final drm-intel-gt-next towards 6.1. For stable platforms we have fixes for throttle reasons decoding to sysfs, GuC version update to 7.5, XeHP SDV GSC support and the usual pile of smaller fixes. DG2 and DG1 runtime PM is now mostly fixed for LMEM access via

Re: [Intel-gfx] [PATCH v2] drm/i915/DG{1, 2}: FIXME Temporary hammer to disable rpm

2022-09-15 Thread Joonas Lahtinen
Quoting Anshuman Gupta (2022-09-14 19:13:29) > DG1 and DG2 has lmem, and cpu can access the lmem objects > via mmap and i915 internal i915_gem_object_pin_map() for > i915 own usages. Both of these methods has pre-requisite > requirement to keep GFX PCI endpoint in D0 for a supported > iomem

Re: [Intel-gfx] [PATCH v2] drm/i915/DG{1, 2}: FIXME Temporary hammer to disable rpm

2022-09-15 Thread Joonas Lahtinen
On the patch subject, could we aim to be a bit more readable and concise. Something like: "drm/i915: Temporarily disable RPM on DG1/DG2" The patch title definitely should not have a FIXME in it if we're going to merge it in that form. There's nothing to be fixed about the patch itself, we are

Re: [Intel-gfx] [PATCH v7 00/15] GSC support for XeHP SDV and DG2

2022-09-12 Thread Joonas Lahtinen
Quoting Vivi, Rodrigo (2022-09-09 19:33:45) > On Fri, 2022-09-09 at 08:17 -0700, Ceraolo Spurio, Daniele wrote: > > > > > > On 9/9/2022 3:24 AM, Joonas Lahtinen wrote: > > > Dave, do you have a preference how to deal with the mishap here, > > > shall I do

Re: [Intel-gfx] [PATCH 6/7] drm/i915/guc: Make GuC log sizes runtime configurable

2022-09-12 Thread Joonas Lahtinen
Quoting Joonas Lahtinen (2022-08-26 09:23:08) > Quoting John Harrison (2022-08-25 19:31:39) > > On 8/25/2022 00:15, Joonas Lahtinen wrote: > > > Quoting John Harrison (2022-08-24 21:45:09) > > >> We also don't want to tie the GuC logging buffer size to the DRM >

[Intel-gfx] [PULL] drm-intel-gt-next

2022-09-09 Thread Joonas Lahtinen
p logging John Harrison (4): drm/i915/guc: Make GuC log sizes runtime configurable drm/i915/guc: Reduce spam from error capture drm/i915/uc: Support for version reduced and multiple firmware files drm/i915/uc: Add patch level version number support Joonas Lahtinen (1):

Re: [Intel-gfx] [PATCH v7 00/15] GSC support for XeHP SDV and DG2

2022-09-09 Thread Joonas Lahtinen
Dave, do you have a preference how to deal with the mishap here, shall I do a force-push to drm-intel-gt-next to correctly record the Acked-by or revert and re-push? Or just leave it as is? Quoting Greg Kroah-Hartman (2022-09-01 18:09:09) > On Sat, Aug 06, 2022 at 03:26:21PM +0300, Tomas Winkler

Re: [Intel-gfx] [PATCH] Revert "drm/i915/dg2: Add preemption changes for Wa_14015141709"

2022-09-05 Thread Joonas Lahtinen
Quoting Matt Roper (2022-08-27 00:02:33) > This reverts commit ca6920811aa5428270dd78af0a7a36b10119065a. > > The intent of Wa_14015141709 was to inform us that userspace can no > longer control object-level preemption as it has on past platforms > (i.e., by twiddling register bit CS_CHICKEN1[0]).

Re: ✓ Fi.CI.BAT: success for drm/i915/guc: Remove log size module parameters (rev2)

2022-08-29 Thread Joonas Lahtinen
Quoting Patchwork (2022-08-26 13:54:30) > Patch Details > > Series: drm/i915/guc: Remove log size module parameters (rev2) > URL: https://patchwork.freedesktop.org/series/107780/ > State: success > Details: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107780v2/index.html > > CI

[Intel-gfx] [PATCH v2] drm/i915/guc: Remove log size module parameters

2022-08-26 Thread Joonas Lahtinen
Remove the module parameters for configuring GuC log size. We should instead rely on tuning the defaults to be usable for reporting bugs. v2: - Use correct 1M unit Fixes: 8ad0152afb1b ("drm/i915/guc: Make GuC log sizes runtime configurable") Signed-off-by: Joonas Lahtinen Cc: Jani

[Intel-gfx] [PATCH] drm/i915/guc: Remove log size module parameters

2022-08-26 Thread Joonas Lahtinen
Remove the module parameters for configuring GuC log size. We should instead rely on tuning the defaults to be usable for reporting bugs. Fixes: 8ad0152afb1b ("drm/i915/guc: Make GuC log sizes runtime configurable") Signed-off-by: Joonas Lahtinen Cc: Jani Nikula Cc: Rodrigo Vivi

Re: [Intel-gfx] [PATCH 6/7] drm/i915/guc: Make GuC log sizes runtime configurable

2022-08-26 Thread Joonas Lahtinen
Quoting John Harrison (2022-08-25 19:31:39) > On 8/25/2022 00:15, Joonas Lahtinen wrote: > > Quoting John Harrison (2022-08-24 21:45:09) > >> On 8/24/2022 02:01, Joonas Lahtinen wrote: > >>> NACK on this one. Let's get this reverted or fixed to elimina

Re: [Intel-gfx] [PATCH 6/7] drm/i915/guc: Make GuC log sizes runtime configurable

2022-08-25 Thread Joonas Lahtinen
Quoting John Harrison (2022-08-24 21:45:09) > On 8/24/2022 02:01, Joonas Lahtinen wrote: > > NACK on this one. Let's get this reverted or fixed to eliminate > > new module parameters. > > > > What prevents us just from using the maximum sizes? Or alternatively >

[Intel-gfx] [PULL] drm-intel-gt-next

2022-08-24 Thread Joonas Lahtinen
Hi Dave & Daniel, Here goes the first drm-intel-gt-next PR towards 6.1. Quite a small one. As primary things, there's the parallel support of GuC v69 and v70 which already went in via -fixes, improvements to the TLB invalidation performance regressions, further DG2 enabling and improved

Re: [Intel-gfx] [PATCH v2] drm/i915/dg2: Add Wa_1509727124

2022-08-24 Thread Joonas Lahtinen
Quoting Matt Roper (2022-08-02 18:09:16) > On Mon, Aug 01, 2022 at 02:38:39PM -0700, Harish Chegondi wrote: > > Bspec: 46052 > > Reviewed-by: Matt Roper > > Signed-off-by: Harish Chegondi > > Applied to drm-intel-gt-next. Thanks for the patch. This patch is completely lacking the commit

Re: [Intel-gfx] [PATCH 6/7] drm/i915/guc: Make GuC log sizes runtime configurable

2022-08-24 Thread Joonas Lahtinen
NACK on this one. Let's get this reverted or fixed to eliminate new module parameters. What prevents us just from using the maximum sizes? Or alternatively we could check the already existing drm.debug variable or anything else but addding 3 new module parameters. For future reference, please do

[Intel-gfx] [PULL] drm-intel-fixes

2022-05-19 Thread Joonas Lahtinen
Hi Dave & Daniel, Here's the previous PR + additional fix for regression #5806: GPU hangs and display artifacts on 5.18-rc3 on Intel GM45. Was also discussed here: https://lore.kernel.org/all/CAHk-=wj0ghsg6iw3d8ufptm9a_dvtsqrrofy9wopobbybyu...@mail.gmail.com/ Regards, Joonas ***

[Intel-gfx] [PULL] drm-intel-fixes

2022-05-18 Thread Joonas Lahtinen
Hi Dave & Daniel, Two final -fixes for v5.18. One is to reject DMC with out-of-spec MMIO (Cc: stable) and another to correctly mark guilty contexts on GuC reset. Regards, Joonas *** drm-intel-fixes-2022-05-19: - Reject DMC firmware with out-of-spec MMIO addresses. - Correctly mark guilty

[Intel-gfx] [PULL] drm-intel-fixes

2022-05-12 Thread Joonas Lahtinen
Hi Dave & Daniel, One fix for memory corruption under heavy load (#5732, Cc: stable). Regards, Joonas *** drm-intel-fixes-2022-05-12: Fix for #5732: (Cc stable) kernel memory corruption when running a lot of OpenCL tests in parallel The following changes since commit

Re: [Intel-gfx] [PATCH 16/16] drm/i915: Drop display.has_fpga_db from device info

2022-05-10 Thread Joonas Lahtinen
Quoting Souza, Jose (2022-05-09 17:19:28) > On Mon, 2022-05-09 at 15:38 +0300, Joonas Lahtinen wrote: > > Quoting José Roberto de Souza (2022-05-07 16:28:50) > > > No need to have this parameter in intel_device_info struct > > > as this feature is supported by Broad

Re: [Intel-gfx] [PATCH 16/16] drm/i915: Drop display.has_fpga_db from device info

2022-05-09 Thread Joonas Lahtinen
Quoting José Roberto de Souza (2022-05-07 16:28:50) > No need to have this parameter in intel_device_info struct > as this feature is supported by Broadwell, Haswell all platforms with > display version 9 or newer. This is opposite of the direction we want to move to. We want to embrace the

[Intel-gfx] [PULL] drm-intel-fixes

2022-04-28 Thread Joonas Lahtinen
Hi Dave & Daniel, Here goes drm-intel-fixes PR for v5.18-rc5. Fixes for backlight control on XMG Core 15 e21 (#5284, regression since 5.15) and black display plane on Acer One AO532h. Then two smaller display fixes picked up by tooling. Regards, Joonas *** drm-intel-fixes-2022-04-28: - Fix

Re: [Intel-gfx] [PULL v2] gvt-next

2022-04-21 Thread Joonas Lahtinen
+ Tvrtko Quoting Christoph Hellwig (2022-04-21 08:47:38) > On Thu, Apr 21, 2022 at 04:57:34AM +, Wang, Zhi A wrote: > > Is it possible that I can send two different pull based on the same branch? > > I was thinking I can remove this line in the original patch and then add a > > small patch to

Re: [Intel-gfx] [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-21 Thread Joonas Lahtinen
+ Tvrtko Quoting Jason Gunthorpe (2022-04-13 17:45:48) > On Wed, Apr 13, 2022 at 02:26:23PM +, Wang, Zhi A wrote: > > On 4/13/22 1:43 PM, Jason Gunthorpe wrote: > > > On Wed, Apr 13, 2022 at 01:39:35PM +, Wang, Zhi A wrote: > > > > > >> It seems Jani's makefile clean patch has already

Re: [Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-21 Thread Joonas Lahtinen
Quoting Ville Syrjälä (2022-04-20 19:23:57) > On Wed, Apr 20, 2022 at 05:32:43PM +0200, Hans de Goede wrote: > > Hi Ville, > > > > On 4/20/22 16:03, Ville Syrjälä wrote: > > > On Mon, Apr 18, 2022 at 05:09:36PM +0200, Hans de Goede wrote: > > >> Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl

[Intel-gfx] [PULL] drm-intel-fixes

2022-04-20 Thread Joonas Lahtinen
Hi Dave & Daniel, Here go drm-intel-fixes for v5.18-rc4. Two display fixes: Disable VRR if user disables it from panel settings and avoid claiming PSR2 is enabled when it is not supported by config. Regards, Joonas *** drm-intel-fixes-2022-04-20: - Unset enable_psr2_sel_fetch if PSR2

Re: [Intel-gfx] [PATCH v7 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-04-13 Thread Joonas Lahtinen
(+ Tvrtko and Jani) Quoting Ramalingam C (2022-04-02 06:02:38) > On 2022-04-01 at 16:31:19 +0200, Christian König wrote: > > I would be nicer to push this through drm-misc-next, but the intel branch > > works for me as well. > Hi Christian > > I have pushed this patch into drm-misc-next. I've

[Intel-gfx] [PULL] drm-intel-fixes

2022-04-12 Thread Joonas Lahtinen
Hi Dave & Daniel, Just one fix towards v5.18-rc3. Fix to align code with drm-tip to make sure full graphics IP version is used for legacy mmap disable check. Regards, Joonas *** drm-intel-fixes-2022-04-13: - Correct legacy mmap disabling to use GRAPHICS_VER_FULL The following changes since

Re: [Intel-gfx] Small bar recovery vs compressed content on DG2

2022-03-17 Thread Joonas Lahtinen
Quoting Thomas Hellström (2022-03-16 09:25:16) > Hi! > > Do we somehow need to clarify in the headers the semantics for this? > > From my understanding when discussing the CCS migration series with > Ram, the kernel will never do any resolving (compressing / > decompressing) migrations or

[Intel-gfx] [PULL] drm-intel-next-fixes

2022-03-17 Thread Joonas Lahtinen
Hi Dave & Daniel, Fix for vm_access() out-of-bounds access and PSR not staying disabled during fastset once determined not reliable. Then a naming fix to avoid conflicts for potential future fixes. Regards, Joonas *** drm-intel-next-fixes-2022-03-17: - Do not re-enable PSR after it was

Re: [Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-16 Thread Joonas Lahtinen
essarily available for both > >>> geometry and compute, two queries will need to exist. This introduces > >>> the first, when passing a valid engine class and engine instance in the > >>> flags returns a topology describing geometry. > >>> > >>

[Intel-gfx] [PULL] drm-intel-next-fixes

2022-03-09 Thread Joonas Lahtinen
ce overzealous alignment constraints for GGTT - Add missing mdev attribute "name" for GVT - Async flip fixes (Ville) - Static checker fix (Ville) -------- Joonas Lahtinen (1): Merge tag 'gvt-next-2022-03-07' of https://github.com/in

Re: [Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next

2022-03-08 Thread Joonas Lahtinen
Quoting Wang, Zhi A (2022-03-08 12:07:04) > Which suits better for you? For me, I am OK with both. If you are not in a > rush of closing the window, I can submit through drm-intel-next-fixes. I pulled this into drm-intel-next-fixes now. For future reference, let's have fixes only PRs as

[Intel-gfx] [PULL] drm-intel-gt-next

2022-03-02 Thread Joonas Lahtinen
Hi Dave & Daniel, Here is the last feature PR for v5.18. For new platforms we have got more DG2 enabling: small BAR foundations, 64K page support and accelerated migration. For XeHP SDV we've got flat CCS detection and compute command streamer being added. Disabling i915 build on PREEMPT_RT for

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915/gt: Create per-tile RC6 sysfs interface

2022-02-18 Thread Joonas Lahtinen
Quoting Andi Shyti (2022-02-17 17:53:58) > Hi Tvrtko, > > > > Now tiles have their own sysfs interfaces under the gt/ > > > directory. Because RC6 is a property that can be configured on a > > > tile basis, then each tile should have its own interface > > > > > > The new sysfs structure will

[Intel-gfx] [PULL] drm-intel-gt-next

2022-02-17 Thread Joonas Lahtinen
5/guc: Temporarily bump the GuC load timeout drm/i915/guc: Update to GuC version 69.0.3 drm/i915/guc: Improve GuC loading status check/error reports Joonas Lahtinen (1): Merge drm/drm-next into drm-intel-gt-next Juston Li (1): drm/i915/pxp: Hold RPM wakelock during PXP unb

Re: [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-02-08 Thread Joonas Lahtinen
Quoting Jani Nikula (2022-02-07 12:48:08) > On Mon, 07 Feb 2022, Christoph Hellwig wrote: > > On Mon, Feb 07, 2022 at 08:28:13AM +, Wang, Zhi A wrote: > >> 1) About having the mmio_table.h, I would like to keep the stuff in a > >> dedicated header as putting them in intel_gvt.h might needs

[Intel-gfx] [PULL] drm-intel-fixes

2022-02-03 Thread Joonas Lahtinen
Hi Dave & Daniel, Tvrtko is out today, so sending the -rc3 -fixes PR on behalf of him (picked and CI tested by Tvtko). Major items are fix for GitLab #4698 (Dell DA310 Type-C dock issue) and engine busyness inconsitent value/timeout fixes when running with GuC. Then two fixes for error paths

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-18 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2022-01-17 18:02:50) > > On 17/01/2022 15:09, Andi Shyti wrote: > > The GT has its own properties and in sysfs they should be grouped > > in the 'gt/' directory. > > > > Create a 'gt/' directory in sysfs which will contain gt0...gtN > > directories related to each tile

Re: [Intel-gfx] [PATCH] dma_fence_array: Fix PENDING_ERROR leak in dma_fence_array_signaled()

2021-11-29 Thread Joonas Lahtinen
(Switching to my @linux.intel.com address) Quoting Christian König (2021-11-29 14:55:37) > Am 29.11.21 um 13:46 schrieb Thomas Hellström: > > On Mon, 2021-11-29 at 13:33 +0100, Christian König wrote: > >> Am 29.11.21 um 13:23 schrieb Thomas Hellström: > >>> Hi, Christian, > >>> > >>> On Mon,

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel-gt tree

2021-11-17 Thread Joonas Lahtinen
+ intel-gfx mailing list (Stephen, can you include this going forward?) Adding Thomas for this specific patch. Regards, Joonas Quoting Stephen Rothwell (2021-11-17 01:02:23) > Hi all, > > After merging the etnaviv tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > >

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v2

2021-11-10 Thread Joonas Lahtinen
Quoting Christoph Hellwig (2021-11-09 09:59:57) > On Thu, Nov 04, 2021 at 02:59:18PM +0200, Joonas Lahtinen wrote: > > The minimal we should do is to eliminate the double underscore > > prefixed functions. But I would prefer to have the symbol exports by > > default

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v2

2021-11-04 Thread Joonas Lahtinen
Hi Zhenyu and Zhi, Can you have somebody from the GVT team to review the patches that are fully contained in gvt/ ? I also started discussion on patch 6 which is about defining the interface between the modules. I remember there is prior work to shrink the interface. Do you have links to such

Re: [Intel-gfx] [PATCH 06/29] drm/i915/gvt: move the gvt code into kvmgt.ko

2021-11-04 Thread Joonas Lahtinen
+ Thomas, Maarten and Matt (Also, Zhi and Zhenyu, please see down) Quoting Christoph Hellwig (2021-11-02 09:05:38) > Instead of having an option to build the gvt code into the main i915 > module, just move it into the kvmgt.ko module. This only requires > a new struct with three entries that

Re: [Intel-gfx] [PATCH 02/29] drm/i915/gvt: integrate into the main Makefile

2021-11-04 Thread Joonas Lahtinen
Quoting Christoph Hellwig (2021-11-02 09:05:34) > Remove the separately included Makefile and just use the relative > reference from the main i915 Makefile as for source files in other > subdirectories. The thinking behind the split is to avoid any merge conflicts as the gvt/ subdirectory is

Re: [Intel-gfx] [PATCH v8] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-11-01 Thread Joonas Lahtinen
Vivi > > Cc: Jani Nikula > > Cc: Chris Wilson > > Cc: Tvrtko Ursulin > > Cc: William Tseng > > Cc: Shawn C Lee > > Cc: Pawel Wilma > > Signed-off-by: Cooper Chiou > > Reviewed-by: Tvrtko Ursulin Thanks for following through with all the tes

  1   2   3   4   5   6   7   8   9   10   >