Em Fri, 29 Mar 2024 17:00:28 +
Easwar Hariharan escreveu:
> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave"
> with more appropriate terms. Inspired by and following on to Wolfram's
> series to fix drivers/i2c/[1], fix the terminology for users of
> I2C_ALGOBIT
On Wed, 11 Oct 2023 16:17:39 +0200
Janusz Krzysztofik wrote:
> When igt_kunit() was converted to a helper and wrapped with a new function
> promoted to take the name and role of the library API, related
> documentation was left unchanged and still placed in front the demoted
> function. Update
On Wed, 11 Oct 2023 16:17:37 +0200
Janusz Krzysztofik wrote:
> Function fcntl(..., F_GETFL, ...) that returns file status flags may also
> return a negative error code. Handle that error instead of blindly using
> the returned value as flags.
>
> Signed-off-by: Janusz Krzysztofik
>
On Wed, 11 Oct 2023 16:17:36 +0200
Janusz Krzysztofik wrote:
> A workaround was implemented in IGT KTAP parser so it could accepted KTAP
> reports with missing top level KTAP version and test suite plan headers.
> While the issue has been fixed by a kernel side commit c95e7c05c139
> ("kunit:
ore debug statements,
> - integrate common code around kunit_result_free() into it.
> v2: Interrupt blocking read() on modprobe failure.
>
> Signed-off-by: Janusz Krzysztofik
> Acked-by: Mauro Carvalho Chehab # v2
> ---
> lib/igt_kmod.c | 261 +++
> lib/igt
d and execute igt_dynamic() for each kunit
> result obtained from igt_ktap_parse() called from the main thread.
>
> Also, drop no longer needed functions from igt_ktap soruces.
>
> v2: Interrupt blocking read() on modprobe failure.
>
> Signed-off-by: Janusz Krzysztofik
L
btest names from module names,
> there is a great chance that those two names match. Take this into
> account when composing names for IGT dynamic sub-subtest names and drop
> the leading test suite name component when it is the same as subtest name.
>
> Signed-off-by: Janusz Krzysztofik
Revie
we use default SIGINT signal handler, read() should never fail with
> errno set to EINTR on user interrupt, only the whole process should be
> terminated. Drop checks for errno == EINTR as not applicable.
This explanation makes sense to me.
Acked-by: Mauro Carvalho Chehab
>
>
On Tue, 19 Sep 2023 08:25:22 +0200
Mauro Carvalho Chehab wrote:
> On Mon, 18 Sep 2023 15:42:55 +0200
> Janusz Krzysztofik wrote:
>
> > In a body of a subtest with dynamic sub-subtests, it is illegal to call
> > igt_fail() and its variants from outside of a dyn
gt; called when only listing subtests.
>
> Signed-off-by: Janusz Krzysztofik
> Cc: Mauro Carvalho Chehab
LGTM.
Acked-by: Mauro Carvalho Chehab
> ---
> lib/igt_kmod.c | 76 +++---
> 1 file changed, 23 insertions(+), 53 deletions(-)
; Signed-off-by: Janusz Krzysztofik
> Acked-by: Mauro Carvalho Chehab # v1
LGTM.
Reviewed-by: Mauro Carvalho Chehab
> ---
> lib/igt_kmod.c | 7 +-
> lib/igt_ktap.c | 66 +-
> 2 files changed, 28 insertions(+), 45 deletions(-)
&g
On Fri, 8 Sep 2023 14:32:47 +0200
Janusz Krzysztofik wrote:
Forgot to mention on my past review:
> +, ) == 1 && len == strlen(buf))) {
> + /*
> + * TODO: drop the following workaround as soon as
> + * kernel side issue
On Wed, 13 Sep 2023 16:04:10 +0200
Janusz Krzysztofik wrote:
> On Monday, 11 September 2023 11:01:42 CEST Mauro Carvalho Chehab wrote:
> > On Fri, 8 Sep 2023 14:32:41 +0200
> > Janusz Krzysztofik wrote:
> >
> > > While reading KTAP data from /dev/kmsg w
unit test module from a separate thread
> and process the intermediate results immediately, as soon as available
> from the background parser, without waiting for completion of module
> loading.
LGTM.
Acked-by: Mauro Carvalho Chehab
>
> Signed-of
nction with some
> example data and verifies correctness of their parsing is also provided.
>
> v2: Fix incorrect and missing includes in the test source file,
> - add license and copyright clauses to the test source file.
>
> Signed-off-by: Janusz Krzysztofik
Acked-by: Mauro Carvalh
_test" or "_kunit" suffix, those parts of the names don't carry any
> useful information. Strip those suffixes from IGT subtest names.
LGTM.
Reviewed-by: Mauro Carvalho Chehab
>
> Signed-off-by: Janusz Krzysztofik
> ---
> lib/igt_kmod.c | 26 ++
ng
> results.
LGTM.
Acked-by: Mauro Carvalho Chehab
>
> Signed-off-by: Janusz Krzysztofik
> ---
> lib/igt_kmod.c | 28
> lib/igt_ktap.c | 25 +
> lib/igt_ktap.h | 6 --
> 3 files changed, 25 insertions(+), 3
ysztofik
Yeah, makes sense to me.
Reviewed-by: Mauro Carvalho Chehab
> ---
> lib/igt_kmod.c | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index 020df286b8..988ac164cb 100644
> --- a/lib/igt_kmod.
AGAIN responses, waiting for more KTAP data. Since we have no sleeps
> inside those loops, extremely high CPU usage can be observed.
>
> Simplify reading KTAP reports by first switching the file descriptor back
> to blocking mode.
LGTM.
Acked-by: Mauro Carvalho Chehab
&g
> unload the "kunit" module explicitly on cleanup. Drop the unnecessary
> operation.
>
> Signed-off-by: Janusz Krzysztofik
LGTM.
Acked-by: Mauro Carvalho Chehab
> ---
> lib/igt_kmod.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/lib/ig
passed to
> functions that actually read the data, there it is converted back to a
> file descriptor with fileno() and the data is read with read().
>
> Drop the unnecessary conversions and teach functions to accept and process
> just the file descriptor of /dev/kmsg.
LGTM.
Acked-by
On Mon, 11 Sep 2023 11:28:32 +0200
Janusz Krzysztofik wrote:
> Hi Mauro,
>
> Thanks for review.
>
> On Monday, 11 September 2023 10:52:51 CEST Mauro Carvalho Chehab wrote:
> > On Fri, 8 Sep 2023 14:32:39 +0200
> > Janusz Krzysztofik wrote:
> >
> > &g
> whether we should continue parsing or return a failure. Drop that flag.
>
> Signed-off-by: Janusz Krzysztofik
LGTM.
Reviewed-by: Mauro Carvalho Chehab
> ---
> lib/igt_ktap.c | 32
> 1 file changed, 32 deletions(-)
>
> diff --git
t
> after that failure. If the KTAP thread sleeps for some reason then we
> can fail to break the test immediately.
>
> Cancel the KTAP parser thread right after module load error and before
> joining it.
LGTM.
Reviewed-by: Mauro Carvalho Chehab
>
> Signed-off-by: Janusz Krzysztofi
On Fri, 8 Sep 2023 14:32:41 +0200
Janusz Krzysztofik wrote:
> While reading KTAP data from /dev/kmsg we now ignore interrupt signals
> that may occur during read() and we continue reading the data. No
> explanation has been provided on what that could be needed for.
The reason is that kunit
code on KTAP parser startup with a value that
> indicates a failure, then change it to success when so indicated by result
> of KTAP parsing.
>
> Signed-off-by: Janusz Krzysztofik
Reviewed-by: Mauro Carvalho Chehab
> ---
> lib/igt_ktap.c | 5 ++---
> 1 file changed, 2 ins
On Fri, 8 Sep 2023 14:32:39 +0200
Janusz Krzysztofik wrote:
> In a body of a subtest with dynamic sub-subtests, it is illegal to call
> igt_fail() and its variants from outside of a dynamic sub-subtest body.
> On the other hand, it is perfectly legal to call either igt_skip() and
> friends or
Moreover, using more advanced variants of igt_skip() and igt_fail() where
> applicable makes the code more compact. Go for it.
Reviewed-by: Mauro Carvalho Chehab
>
> Signed-off-by: Janusz Krzysztofik
> ---
> lib/igt_kmod.c | 14 +++---
> 1 file changed, 3 inserti
invalidation in MMIO memory. The result is a leaner, more
targeted proposal.
Series look good to me. Feel free to add my R-B to the patches I didn't
sign already.
Reviewed-by: Mauro Carvalho Chehab
Other patches from the original series might follow.
Thanks,
Andi
[1] https
On 2/6/23 18:00, Rodrigo Vivi wrote:
On Tue, Jan 31, 2023 at 02:03:01PM +0100, Mauro Carvalho Chehab wrote:
On 1/24/23 20:39, Rodrigo Vivi wrote:
On Sat, Jan 21, 2023 at 04:08:53PM -0300, Gustavo Sousa wrote:
The wildchar ("*") used in the function name patterns in the
doc
nline literal markup and, for consistency, do the
same for the other function names mentioned.
Fixes: 0c3064cf33fb ("drm/i915/doc: Document where to implement register
workarounds")
Reported-by: kernel test robot
Signed-off-by: Gustavo Sousa
Cc: Mauro Carvalho Chehab
just in case he sees some bette
===
[13:23:42]
[13:23:42] Testing complete. Ran 18 tests: passed: 18
[13:23:42] Elapsed time: 302.766s total, 0.003s configuring, 280.393s building,
22.341s running
Mauro Carvalho Chehab (3):
drm/i915: place selftest
In order to prepare for a new KUnit module that will run
selftests, export all mock selftest functions to I915_SELFTEST
namespace.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See
The selftest preparation logic should also be used by KUnit. So,
place it on a separate function and export it.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH 0/3] at:
https://lore.kernel.org/all
echo "[0.00] TAP version 14" >logs
dmesg >>logs
./tools/testing/kunit/kunit.py parse logs
Note: kunit.py is currently broken with modules, not producing any
results if "TAP version xx" is not found. It also shows the results
duplicated.
On Thu, 17 Nov 2022 10:29:01 +0100
Maxime Ripard wrote:
> From: Mateusz Kwiatkowski
>
> Add support for the following composite output modes (all of them are
> somewhat more obscure than the previously defined ones):
>
> - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to
>
On Thu, 17 Nov 2022 10:28:48 +0100
Maxime Ripard wrote:
> The TV mode property has been around for a while now to select and get the
> current TV mode output on an analog TV connector.
>
> Despite that property name being generic, its content isn't and has been
> driver-specific which makes it
On Mon, 7 Nov 2022 15:16:17 -0800
Daniel Latypov wrote:
> On Mon, Nov 7, 2022 at 10:38 AM Michał Winiarski
> wrote:
> >
> > On Thu, Nov 03, 2022 at 04:23:02PM +0100, Mauro Carvalho Chehab wrote:
> > > Hi,
> > >
> > > I'm facing a couple of i
On Fri, 4 Nov 2022 08:49:55 +0100
Mauro Carvalho Chehab wrote:
> On Thu, 3 Nov 2022 15:43:26 -0700
> Daniel Latypov wrote:
>
> > On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab
> > wrote:
> > >
> > > Hi,
> > >
> > > I'm facing a
On Thu, 3 Nov 2022 15:43:26 -0700
Daniel Latypov wrote:
> On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab
> wrote:
> >
> > Hi,
> >
> > I'm facing a couple of issues when testing KUnit with the i915 driver.
> >
> > The DRM subsystem and the i915 dr
have just two levels (test suite and tests).
Are there a way to add test groups there?
Regards,
Mauro
Forwarded message:
Date: Thu, 3 Nov 2022 14:51:38 +0000
From: Mauro Carvalho Chehab
To:
Cc: Thomas Hellström ,
linux-kselft...@vger.kernel.org, Michał Winiarski ,
dri-de...@lists.freedeskt
some tests might fail
on newer hardware.
---
v2:
- changes outside KUnit module moved to separate patches;
- added support for running live and perf selftests on bare metal;
- made the KUnit test logic identical to i915 selftest.
Mauro Carvalho Chehab (8):
drm/i915: export all selftest func
The selftest preparation logic should also be used by KUnit. So,
place it on a separate function and export it.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH RFC v2 0/8] at:
https
/0x1b9 [i915]
[ 316.846119] __igt_mmap+0xfe/0x680 [i915]
Unfortunately, when KUnit module runs, it doesn't create an
user context, causing mmap tests to fail.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See
Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH RFC v2 0/8] at:
https://lore.kernel.org/all/cover.1667486144.git.mche...@kernel.org/
drivers/gpu/drm/i915/selftests/i915_kunit.c | 100
1 file changed, 100
In order to prepare for a new KUnit module that will run
selftests, export all selftest functions to I915_SELFTEST
namespace.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH
The PCI-specific KUnit tests that run in bare metal got added,
so we can remove the __maybe_unused from such functions.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH RFC v2 0/8] at:
https
echo "[0.00] TAP version 14" >logs
dmesg >>logs
./tools/testing/kunit/kunit.py parse logs
Note: kunit.py is currently broken with modules, not producing any
results if "TAP version xx" is not found. It also shows the results
duplicated.
Now that i915 KUnit has PCI support, add live tests as well.
NOTE: currently, some tests are failing when excecuting via
KUnit. I'll do a further investigation to check why, and if
this patch can be safely merged or not.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large
Now that i915 KUnit has PCI support, add perf tests as well.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH RFC v2 0/8] at:
https://lore.kernel.org/all/cover.1667486144.git.mche...@kernel.org
echo "[0.00] TAP version 14" >logs
dmesg >>logs
./tools/testing/kunit/kunit.py parse logs
Note: kunit.py is currently broken with modules, not producing any
results if "TAP version xx" is not found. It also shows the results
duplicated.
Signe
Em Fri, 9 Sep 2022 05:06:46 -0400
Rodrigo Vivi escreveu:
> On Fri, Sep 09, 2022 at 09:34:34AM +0200, Mauro Carvalho Chehab wrote:
> > There are several documented GT kAPI that aren't currently part
> > of the docs. Add them, as this allows identifying issues with
> >
Em Fri, 16 Sep 2022 17:03:27 +0300
Gwan-gyeong Mun escreveu:
> > /**
> > - * Called when user space has done writes to this buffer
> > + * i915_gem_sw_finish_ioctl - Called when user space has done writes to
> > + * this buffer
> As per this link[1], the brief description does not
Em Mon, 12 Sep 2022 10:19:04 -0700
Matt Roper escreveu:
> > Those *appear* to be kernel-doc markups, but they aren't, because
> > the structs themselves are not properly marked. See, for instance
> > struct intel_context.
> >
> > scripts/kerneldoc will *only* consider what's there as a proper
>
Hi Luis,
On Mon, 9 May 2022 13:38:28 -0700
Luis Chamberlain wrote:
> On Mon, May 09, 2022 at 06:23:35PM +0200, Mauro Carvalho Chehab wrote:
> > Currently, kernel/module annotates module dependencies when
> > request_symbol is used, but it doesn't cover more complex inter-driver
&
On Tue, 13 Sep 2022 14:04:40 +0200
Janusz Krzysztofik wrote:
> Starting from commit 0edabd8a4a08 ("core_hotunplug: fix audio unbind
> logic") audio modules are unloaded unconditionally before graphics driver
> unbind. This is required for i915 to be unbound cleanly from a graphics
> device.
> Signed-off-by: Janusz Krzysztofik
Makes sense to me, once we have patch 3/4 applied. So,
Reviewed-by: Mauro Carvalho Chehab
> ---
> tests/core_hotunplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/core_hotunplug.c b/tests/core_
ned-off-by: Janusz Krzysztofik
LGTM.
Reviewed-by: Mauro Carvalho Chehab
> ---
> tests/core_hotunplug.c | 22 ++
> 1 file changed, 22 insertions(+)
>
> diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
> index 733ea8efb0..c375688
-off-by: Janusz Krzysztofik
Reviewed-by: Mauro Carvalho Chehab
> ---
> tests/core_hotunplug.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
> index a0d29b799a..733ea8efb0 100644
> --- a/tests/core_hotunplug.c
> +
Hi Matt,
Em Mon, 12 Sep 2022 08:09:57 -0700
Matt Roper escreveu:
> > --- a/drivers/gpu/drm/i915/gt/intel_context_types.h
> > +++ b/drivers/gpu/drm/i915/gt/intel_context_types.h
>
> Several of the comments in this file do appear to be kerneldoc (in fact
> kerneldoc that was specifically
There are several documented GuC kAPI that aren't currently part
of the docs. Add them, as this allows identifying issues with
badly-formatted tags.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
The doc markup should not end with ":", as it would generate a
warning on Sphinx while generating the cross-reference tag.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
Currently, functions inside GuC aren't presented as part of the
GuC documentation.
Add them.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https
The intel_gt_pm.h file contains some convenient macros to be used
in GT code in order to get/put runtime PM references and for
checking them.
Add descriptions based on the ones at intel_wakeref.h and
intel_runtime_pm.c.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large
There are some parameters missing at the kernel-doc markups on
some gem files. Some of those are trivial enough to be added.
Document them.
Reviewed-by: Nirmoy Das
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
Currently, 91% of kernel-doc function declarations don't have
parenthesis on it. Let's be consistent inside the driver by
removing the parenthesis from the other ones.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
Kernel-doc dump_flags parameter is missing at i915_capture_error_state().
Document it.
Fixes: a6f0f9cf330a ("drm/i915/guc: Plumb GuC-capture into gpu_coredump")
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, on
There are several documented GEM/TTM kAPI that aren't currently part
of the docs. Add them, as this allows identifying issues with
badly-formatted tags.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were
by:
- lack of function name at the kernel-doc markup;
- renamed parameters.
Address them.
Reviewed-by: Nirmoy Das
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https
, using
a list, in order for it to be properly parsed during documentation
build time.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org
'flags' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:401: warning: Function
parameter or member 'version' not described in 'guc_log_buffer_state'
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large
fi; done >aaa
Add them to i915.rst as well.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all/cover.1662708705.git.mche...
'
drivers/gpu/drm/i915/gt/intel_engine_types.h:276: warning: Function
parameter or member 'preempt_hang' not described in 'intel_engine_execlists'
That are due undocumented parameters.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people
-string without end-string.
That's because @foo evaluates into **foo**, and placing anything
after it without spaces cause Sphinx to warn and do the wrong
thing.. So, replace them by a different Sphinx-compatible tag.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid
commit d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr")
added a rbtree list to allow searching for obj/ctx.
Document it.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on
The way it is, it produces this warning:
Documentation/gpu/i915:150:
./drivers/gpu/drm/i915/display/skl_scaler.c:213: WARNING: Block quote ends
without a blank line; unexpected unindent.
Use list markups to suppress the warning.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho
drigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all/cover.1662708705.git.mche...@kernel.org/
drivers/gpu/drm/i915/intel
Prevent this Sphinx warning:
Documentation/foo/i915:728: ./drivers/gpu/drm/i915/i915_gem.c:447:
WARNING: Inline emphasis start-string without end-string.
By using @data to identify the data field, as expected by kernel-doc.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho
The DOC: tag waits for a one-line short title for the doc
section. Using multiple lines will produce a weird output.
So, add a shorter description for the title, while keeping
the current content below it.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing
'
Those are due to wrong parameter of function name. Address them.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all/cover.1662708705
This is a large struct used to describe gem objects. It is
currently partially documented. Finish its documentation, filling
the gaps from git logs.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
This file is licensed with MIT license. Change its license text
to use SPDX.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all
-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all/cover.1662708705.git.mche...@kernel.org/
drivers/gpu/drm/i915/display/intel_fb.c | 2 +-
1 file changed, 1 insertion(+), 1
There are several documented GVT kAPI that aren't currently part
of the docs. Add them, as this allows identifying issues with
badly-formatted tags.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
The return codes for i915_gem_wait_ioctl() have identation issues,
and will be displayed on a very confusing way. Use lists to improve
its output.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
There are some occurrences of "/**" that aren't actually part of
a kernel-doc markup. Replace them by "/*", in order to make easier
to identify what i915 files contain kernel-doc markups.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombi
:
./drivers/gpu/drm/i915/display/intel_dp_link_training.c:186: WARNING:
Definition list ends without a blank line; unexpected unindent.
Use table markups to fix it.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing
and do the wrong
thing.. So, replace them by a different Sphinx-compatible tag.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all
Both intel_runtime_pm.h and intel_pm.c contains kAPI for
runtime PM. So, add them to the documentation.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37
There are several documented GT kAPI that aren't currently part
of the docs. Add them, as this allows identifying issues with
badly-formatted tags.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3
Two new fields were added to __i915_gem_ttm_object_init() without
their corresponding documentation.
Document them.
Fixes: 9b78b5dade2d ("drm/i915: add i915_gem_object_create_region_at()")
Reviewed-by: Nirmoy Das
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a la
This file is licensed with MIT license. Change its license text
to use SPDX.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all
There are several documented kAPI at the display side that
aren't currently part of the docs. Add them, as this allows
identifying issues with badly-formatted tags.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing
/gvt/vgpu.c:358: warning: expecting prototype for
intel_gvt_destroy_vgpu(). Prototype was for intel_gvt_destroy_idle_vgpu()
instead
Reviewed-by: Rodrigo Vivi
Acked-by: Zhenyu Wang
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C
nd, documenting some structs
at i915_gem_object_types.h and intel_gt_pm.h, plus adding
intel-guc.c internal functions to the generated documentation.
Mauro Carvalho Chehab (37):
drm/i915: fix kernel-doc trivial warnings on i915/*.[ch] files
drm/i915: display: fix kernel-doc markup warnings
in 'i915_ttm_restore_region'
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all/cover.1662708705.git.mche...@kernel.org/
drivers/gpu/drm
/intel_wakeref.h:149: warning: expecting prototype
for intel_wakeref_put_flags(). Prototype was for __intel_wakeref_put() instead
Fix them.
Additionally, improve title for intel_wakeref_get_if_active().
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large
Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all/cover.1662708705.git.mche...@kernel.org/
drivers/gpu/drm/i915/i915_active.h | 14 +++---
drivers/gpu/drm/i915
On Tue, 9 Aug 2022 06:20:57 -0400
Rodrigo Vivi wrote:
> On Wed, Jul 13, 2022 at 09:12:23AM +0100, Mauro Carvalho Chehab wrote:
> > There are other files with kernel-doc markups:
> >
> > $ git grep -l "/\*\*" $(git ls-files|grep drivers/gpu/drm/i915/)
> &
On Tue, 9 Aug 2022 06:01:53 -0400
Rodrigo Vivi wrote:
> On Wed, Jul 13, 2022 at 09:12:18AM +0100, Mauro Carvalho Chehab wrote:
> > There are several documented GT kAPI that aren't currently part
> > of the docs. Add them, as this allows identifying issues with
> >
1 - 100 of 377 matches
Mail list logo
