On 11.06.2024 22:32, John Harrison wrote:
> On 6/11/2024 07:30, Michal Wajdeczko wrote:
>> There are many GuC ABI definitions named in the same way by the i915
>> and Xe drivers, preventing proper generation of the documentation.
>>
>> Promote GuC ABI definitions
Some KLVs were not used by the Xe driver, but are used by the i915.
Add scheduling policy update key and another workaround key.
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/intel/guc/abi/guc_klvs_abi.h | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/intel/guc
GuC ABI definitions are not strictly tied to the i915 driver.
Move them to a separate section.
Signed-off-by: Michal Wajdeczko
---
Documentation/gpu/drivers.rst | 1 +
Documentation/gpu/guc.rst | 16
Documentation/gpu/i915.rst| 9 -
3 files changed, 17
Move SR-IOV GuC ABI definitions to shared location and include
them in the generated GuC documentation chapter.
Signed-off-by: Michal Wajdeczko
---
Documentation/gpu/guc.rst | 7 +++
.../gpu/drm/{xe => intel/guc}/abi/guc_actions_sriov_abi.h | 0
.../gpu/
We no longer need to maintain some of the GuC ABI definitions
inside the i915 driver as the shared one are exactly the same.
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/Makefile | 5 +
.../gt/uc/abi/guc_communication_ctb_abi.h | 170 ---
.../gt/uc/abi
Add missing definition of the CTB_STATUS_UNUSED bit.
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/intel/guc/abi/guc_communication_ctb_abi.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/intel/guc/abi/guc_communication_ctb_abi.h
b/drivers/gpu/drm/intel/guc/abi
For documentation purposes, use shared GuC ABI definitions instead
of local i915 definitions.
Signed-off-by: Michal Wajdeczko
---
Documentation/gpu/guc.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/gpu/guc.rst b/Documentation/gpu/guc.rst
index
GuC ABI definitions do not have to be the Xe driver specific.
Move them to shared location for later reuse by the i915 driver.
While at it, fixup few improper kernel-doc annotations.
Signed-off-by: Michal Wajdeczko
---
.../{xe => intel/guc}/abi/guc_communication_ctb_abi.h | 0
.../
: Lucas De Marchi
Cc: Matthew Brost
Cc: Daniele Ceraolo Spurio
Cc: John Harrison
Michal Wajdeczko (7):
drm/xe/guc: Promote GuC ABI headers to shared location
Documentation/gpu: Separate GuC ABI section
Documentation/gpu: Switch to shared GuC ABI definitions
drm/intel/guc: Update CTB
On 21.05.2024 07:48, Patchwork wrote:
> == Series Details ==
>
> Series: drm/xe: Cleanup xe_mmio.h
> URL : https://patchwork.freedesktop.org/series/133825/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_14785_full -> Patchwork_133825v1_full
>
++
It's already reviewed, but since this touches shared code, extra acks
are still welcomed
On 17.05.2024 18:34, Michal Wajdeczko wrote:
> We already have some drm printk functions that need to duplicate
> a code to get a similar format of the final result, for example:
>
> [ ]
On 21.05.2024 16:01, Francois Dugast wrote:
> Hi Michal,
>
> On Mon, May 20, 2024 at 08:18:13PM +0200, Michal Wajdeczko wrote:
>> These compilation units use udelay() or some GT oriented printk
>> functions without explicitly including proper header files, and
>>
MIO ioctl")
we don't need forward declarations of drm_device and drm_file.
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/xe/xe_mmio.c | 7 +--
drivers/gpu/drm/xe/xe_mmio.h | 9 +
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/driv
These compilation units use udelay() or some GT oriented printk
functions without explicitly including proper header files, and
relying on #includes from the xe_mmio.h instead. Fix that.
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/xe/xe_device.c | 2 ++
drivers/gpu/drm/xe
Unfortunately, this is cross i915/Xe series.
Cc: Jani Nikula
Cc: Lucas De Marchi
Michal Wajdeczko (3):
drm/i915/display: Add missing include to intel_vga.c
drm/xe: Don't rely on indirect includes from xe_mmio.h
drm/xe: Cleanup xe_mmio.h
drivers/gpu/drm/i915/display/intel_vga.c | 1
This compilation unit uses udelay() function without including
it's header file. Fix that to break dependency on other code.
Signed-off-by: Michal Wajdeczko
Cc: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_vga.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915
With recent introduction of a generic drm dev printk function, we
can now store and use location where drm_dbg_printer was invoked
and output it's symbolic name like we do for all drm debug prints.
Cc: Jani Nikula
Reviewed-by: Jani Nikula
Signed-off-by: Michal Wajdeczko
---
v2: use full cast
Updated code of drm_dbg_printer() is already printing symbolic
name of the caller like drm_dbg() does.
Reviewed-by: Jani Nikula
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
drivers/gpu/drm/i915/gt/selftest_context.c | 2 +-
2 files changed, 2
the
final message like all other existing function do and allows us
to keep the formatting code in one place.
Cc: Jani Nikula
Signed-off-by: Michal Wajdeczko
---
v2: make it static, keep it simple and use braces (Jani)
---
drivers/gpu/drm/drm_print.c | 52 +
1
it static, keep it simple and use braces (Jani)
Michal Wajdeczko (3):
drm/print: Add generic drm dev printk function
drm/print: Improve drm_dbg_printer
drm/i915: Don't use __func__ as prefix for drm_dbg_printer
drivers/gpu/drm/drm_print.c| 53 --
drivers
On 17.05.2024 15:33, Jani Nikula wrote:
> On Fri, 17 May 2024, Michal Wajdeczko wrote:
>> We already have some drm printk functions that need to duplicate
>> a code to get a similar format of the final result, for example:
>>
>> [ ] :00:00.0: [drm:foo] bar
Updated code of drm_dbg_printer() is already printing symbolic
name of the caller like drm_dbg() does.
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
drivers/gpu/drm/i915/gt/selftest_context.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
the
final message like all other existing function do and allows us
to keep the formatting code in one place.
Signed-off-by: Michal Wajdeczko
Cc: Jani Nikula
---
drivers/gpu/drm/drm_print.c | 49 -
include/drm/drm_print.h | 3 +++
2 files changed, 30
With recent introduction of a generic drm dev printk function, we
can now store and use location where drm_dbg_printer was invoked
and output it's symbolic name like we do for all drm debug prints.
Signed-off-by: Michal Wajdeczko
Cc: Jani Nikula
---
drivers/gpu/drm/drm_print.c | 3 +--
include
the
final message like all other existing function do and allows us
to keep the formatting code in one place.
Above also allows to improve drm_dbg_printer() that today lacks
of outputing symbolic name of the caller, like drm_dbg() does.
Cc: Maxime Ripard
Cc: Jani Nikula
Michal Wajdeczko (3
On 05.10.2023 00:07, Jonathan Cavitt wrote:
> From: Prathap Kumar Valsan
>
snip
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> index 6e22af31513a5..1ee4d4a988398 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> +++
On 05.10.2023 00:07, Jonathan Cavitt wrote:
> Add pci (device info) flags for if GuC TLB Invalidation is enabled.
nit: maybe avoid using "PCI flag" term here (and in the title) as this
could be little misleading - better stick to "device info flag"
>
> Signed-off-by: Jonathan Cavitt
> ---
>
k in
shift operator, which may lead to undefined behavior on 32-bit system.
Use unsigned mask to enforce expected integer promotion.
Reported-by: Linyu Yuan
Signed-off-by: Michal Wajdeczko
Cc: Linyu Yuan
Cc: Jani Nikula
---
drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 2 +-
1 file changed, 1
On 25.08.2023 07:50, Linyu Yuan wrote:
>
> On 8/25/2023 1:37 PM, Jani Nikula wrote:
>> On Fri, 25 Aug 2023, Linyu Yuan wrote:
>>> GCC report GUC_KLV_0_KEY and GUC_KLV_0_LEN is not constant when do
>>> preprocessing.
>> Please paste the actual compiler warning.
>
>
> CC
We've already switched to new HXG definitions some time ago,
drop legacy CTB definitions to avoid mistakes.
Signed-off-by: Michal Wajdeczko
Cc: Piotr Piórkowski
Cc: John Harrison
---
.../gt/uc/abi/guc_communication_ctb_abi.h | 21 ---
drivers/gpu/drm/i915/gt/uc
IELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>^~
>
> Make sure that GUC_KLV_0_KEY is an unsigned value to avoid the warning.
>
> Fixes: 77b6f79df66e ("drm/i915/guc: Update to GuC version 69.0.3")
> Signed-off-by: Arnd Bergmann
Reviewed-by: Michal Wa
On 07.02.2023 06:07, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> Update more print messages to the new scheme.
>
> v2: Also change all errors to %pe rather than %d (MichalW).
> Few other tweaks.
>
> Signed-off-by: John Harrison
LGTM, series is
Revie
ratelimited, _fmt, ##__VA_ARGS__)
>
> +#define guc_notice_ratelimited(_guc, _fmt, ...) \
> + guc_printk((_guc), notice_ratelimited, _fmt, ##__VA_ARGS__)
> +
> #define guc_probe_error(_guc, _fmt, ...) \
> guc_printk((_guc), probe_error, _fmt, ##__VA_ARGS__)
>
Reviewed-by: Michal Wajdeczko
ERR_PTR(ret));
> + guc_probe_error(guc, "SLPC Reset event returned (%pe)\n",
> ERR_PTR(ret));
> return ret;
> }
>
> @@ -743,7 +729,7 @@ int intel_guc_slpc_enable(struct intel_guc_slpc *slpc)
> if (unlikely(ret < 0))
> return ret;
>
> - intel_guc_pm_intrmsk_enable(to_gt(i915));
> + intel_guc_pm_intrmsk_enable(slpc_to_gt(slpc));
>
> slpc_get_rp_values(slpc);
>
> @@ -753,16 +739,14 @@ int intel_guc_slpc_enable(struct intel_guc_slpc *slpc)
> /* Set SLPC max limit to RP0 */
> ret = slpc_use_fused_rp0(slpc);
> if (unlikely(ret)) {
> - i915_probe_error(i915, "Failed to set SLPC max to RP0 (%pe)\n",
> - ERR_PTR(ret));
> + guc_probe_error(guc, "Failed to set SLPC max to RP0 (%pe)\n",
> ERR_PTR(ret));
> return ret;
> }
>
> /* Revert SLPC min/max to softlimits if necessary */
> ret = slpc_set_softlimits(slpc);
> if (unlikely(ret)) {
> - i915_probe_error(i915, "Failed to set SLPC softlimits (%pe)\n",
> - ERR_PTR(ret));
> + guc_probe_error(guc, "Failed to set SLPC softlimits (%pe)\n",
> ERR_PTR(ret));
> return ret;
> }
>
Acked-by: Michal Wajdeczko
but better if we should be more consistent when printing error codes and
maybe while around worth to update all to %pe ?
On 03.02.2023 01:11, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> Update a bunch more debug prints to use the new GT based scheme.
>
> Signed-off-by: John Harrison
> ---
> drivers/gpu/drm/i915/gt/uc/selftest_guc.c | 35 ++-
>
, "gsc_context");
> if (IS_ERR(ce)) {
> - drm_err(>i915->drm,
> - "failed to create GSC CS ctx for FW communication\n");
> + gt_err(gt, "failed to create GSC CS ctx for FW
> communication\n");
>
On 03.02.2023 01:11, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> Update a bunch more debug prints to use the new GT based scheme.
>
> Signed-off-by: John Harrison
> ---
> drivers/gpu/drm/i915/gt/uc/intel_uc.c| 42
> drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c |
Like we did it for GuC, introduce some helper print macros for
HuC to have unified format of messages that also include GT#.
While around improve some messages and use %pe if possible.
v2: update GSC/PXP timeout message
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Cc: Daniele Ceraolo
Like we did it for GuC, introduce some helper print macros for
HuC to have unified format of messages that also include GT#.
While around improve some messages and use %pe if possible.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_huc.c | 44
Just recently we switched over to new GuC oriented log macros but in
the meantime yet another message was added that we missed to update.
While around improve that new message by adding engine name and use
existing helpers to check for context state.
Signed-off-by: Michal Wajdeczko
Cc: John
Use new macros to have common prefix that also include GT#.
v2: improve few existing messages
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 61 ---
1 file changed, 26 insertions(+), 35
Use new macros to have common prefix that also include GT#.
v2: drop unused helpers
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff
Use new macros to have common prefix that also include GT#.
v2: pass gt to print_fw_ver
v3: prefer guc_dbg in suspend/resume logs
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 80 +--
1 file changed, 39 insertions(+), 41
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt
Use new macros to have common prefix that also include GT#.
v2: drop now redundant "GuC" word from the message
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 31 +-
1 file c
Use new macros to have common prefix that also include GT#.
v2: drop redundant GuC strings, minor improvements
v3: more message improvements
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 38 +++---
1 file changed, 19
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc
rsulin
Cc: John Harrison
Michal Wajdeczko (8):
drm/i915/guc: Add GuC oriented print macros
drm/i915/guc: Update GuC messages in intel_guc.c
drm/i915/guc: Update GuC messages in intel_guc_ads.c
drm/i915/guc: Update GuC messages in intel_guc_ct.c
drm/i915/guc: Update GuC messages in inte
While we do have GT oriented print macros, add few more GuC
specific to have common look and feel across all messages
related to the GuC and to avoid chasing the gt pointer.
We will use these macros shortly in upcoming patches.
Signed-off-by: Michal Wajdeczko
Cc: Tvrtko Ursulin
Cc: John
Use new macros to have common prefix that also include GT#.
v2: drop redundant GuC strings, minor improvements
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 37 --
1 file changed, 20 insertions(+), 17 deletions(-)
diff
While we do have GT oriented print macros, add few more GuC
specific to have common look and feel across all messages
related to the GuC and to avoid chasing the gt pointer.
We will use these macros shortly in upcoming patches.
Signed-off-by: Michal Wajdeczko
Cc: Tvrtko Ursulin
Cc: John
Use new macros to have common prefix that also include GT#.
v2: pass gt to print_fw_ver
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 80 +--
1 file changed, 39 insertions(+), 41 deletions(-)
diff --git a/drivers/gpu/drm
Use new macros to have common prefix that also include GT#.
v2: drop unused helpers
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/i915
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt
Use new macros to have common prefix that also include GT#.
v2: improve few existing messages
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 61 ---
1 file changed, 26 insertions(+), 35 deletions(-)
diff --git a/drivers
This is a follow up series for existing commit 67804e48b494
("drm/i915/gt: Start adding module oriented dmesg output")
that was focusing just on the GT.
Now extend changes to uc/ folder and focus on the GuC.
v2: applying feedback from John
Cc: Tvrtko Ursulin
Cc: John Harrison
Use new macros to have common prefix that also include GT#.
v2: drop now redundant "GuC" word from the message
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 31 +-
1 file changed, 15 insertions(+), 16 deletion
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc
On 24.01.2023 00:01, John Harrison wrote:
> On 1/20/2023 08:40, Michal Wajdeczko wrote:
>> Use new macros to have common prefix that also include GT#.
>>
>> Signed-off-by: Michal Wajdeczko
>> Cc: John Harrison
>> ---
>> drivers/
On 24.01.2023 00:27, John Harrison wrote:
> On 1/20/2023 08:40, Michal Wajdeczko wrote:
>> While we do have GT oriented print macros, add few more GuC
>> specific to have common look and feel across all messages
>> related to the GuC and to avoid chasing the gt point
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 60 ---
1 file changed, 26 insertions(+), 34 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
b/drivers/gpu
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
b/drivers/gpu/drm
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 31 +-
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
b
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 35 +++---
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
b/drivers
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 74 +--
1 file changed, 36 insertions(+), 38 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
b
While we do have GT oriented print macros, add few more GuC
specific to have common look and feel across all messages
related to the GuC and to avoid chasing the gt pointer.
We will use these macros shortly in upcoming patches.
Signed-off-by: Michal Wajdeczko
Cc: Tvrtko Ursulin
Cc: John
This is a follow up series for existing commit 67804e48b494
("drm/i915/gt: Start adding module oriented dmesg output")
that was focusing just on the GT.
Now extend changes to uc/ folder and focus on the GuC.
Cc: Tvrtko Ursulin
Cc: John Harrison
Michal Wajdeczko (8):
drm/i915/gu
On 05.12.2022 14:16, Tvrtko Ursulin wrote:
>
> On 02/12/2022 20:14, John Harrison wrote:
>
and while for dbg level messages it doesn't matter, I assume we should
be consistent for err/warn/info messages (as those will eventually show
up to the end user) so let maintainers
On 01.12.2022 01:41, John Harrison wrote:
> On 11/23/2022 12:45, Michal Wajdeczko wrote:
>> On 23.11.2022 02:25, John Harrison wrote:
>>> On 11/22/2022 09:54, Michal Wajdeczko wrote:
>>>> On 18.11.2022 02:58, john.c.harri...@intel.com wrote:
>>>>
On 23.11.2022 02:25, John Harrison wrote:
> On 11/22/2022 09:54, Michal Wajdeczko wrote:
>> On 18.11.2022 02:58, john.c.harri...@intel.com wrote:
>>> From: John Harrison
>>>
>>> Re-work the existing GuC CT printers and extend as required to match
>>>
On 18.11.2022 02:58, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> Re-work the existing GuC CT printers and extend as required to match
> the new wrapping scheme.
>
> Signed-off-by: John Harrison
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 222 +++---
>
On 18.11.2022 02:58, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> Create a set of GuC printers and start using them.
>
> Signed-off-by: John Harrison
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc.c| 32 --
> drivers/gpu/drm/i915/gt/uc/intel_guc.h| 35
On 18.11.2022 02:58, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> Create a set of HuC printers and start using them.
>
> Signed-off-by: John Harrison
> ---
> drivers/gpu/drm/i915/gt/uc/intel_huc.c | 31 ++
> drivers/gpu/drm/i915/gt/uc/intel_huc.h | 23
On 18.11.2022 02:58, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> When trying to analyse bug reports from CI, customers, etc. it can be
> difficult to work out exactly what is happening on which GT in a
> multi-GT system. So add GT oriented debug/error message wrappers. If
>
On 18.11.2022 11:52, Jani Nikula wrote:
> On Thu, 17 Nov 2022, john.c.harri...@intel.com wrote:
>> From: John Harrison
>>
>> When trying to analyse bug reports from CI, customers, etc. it can be
>> difficult to work out exactly what is happening on which GT in a
>> multi-GT system. So add GT
On 10.11.2022 10:55, Tvrtko Ursulin wrote:
>
> On 09/11/2022 19:57, Michal Wajdeczko wrote:
>
> [snip]
>
>>> Is it really a problem to merge this patch now to get the process
>>> started? And other sub-components get updated as and when people get the
>
On 09.11.2022 18:46, John Harrison wrote:
> On 11/9/2022 03:05, Tvrtko Ursulin wrote:
>> On 08/11/2022 20:15, John Harrison wrote:
>>> On 11/8/2022 01:01, Tvrtko Ursulin wrote:
On 07/11/2022 19:14, John Harrison wrote:
> On 11/7/2022 08:17, Tvrtko Ursulin wrote:
>> On 07/11/2022
On 01.09.2022 09:45, Jani Nikula wrote:
> On Wed, 31 Aug 2022, Radhakrishna Sripada
> wrote:
...
>> struct ip_version graphics;
>> +struct ip_version media;
>> +struct ip_version display;
>
> The runtime display info is now in an unnamed struct under struct
>
On 28.07.2022 04:42, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> When the KMD sends a CLIENT_RESET request to GuC (as part of the
> suspend sequence), GuC will mark the CTB buffer as 'UNUSED'. If the
hmm, GuC shouldn't do that on CLIENT_RESET, GuC shall only mark CTB as
UNUSED
On 14.07.2022 14:06, Mauro Carvalho Chehab wrote:
> From: Prathap Kumar Valsan
>
> Add routines to interface with GuC firmware for selective TLB invalidation
> supported on XeHP.
>
> Signed-off-by: Prathap Kumar Valsan
> Cc: Matthew Brost
> Signed-off-by: Mauro Carvalho Chehab
> ---
>
>
On 14.07.2022 14:06, Mauro Carvalho Chehab wrote:
> From: Prathap Kumar Valsan
>
> Add routines to interface with GuC firmware for TLB invalidation.
>
> Signed-off-by: Prathap Kumar Valsan
> Cc: Bruce Chang
> Cc: Michal Wajdeczko
> Cc: Matthew Brost
> Cc:
On 02.06.2022 19:21, Zhanjun Dong wrote:
> We are seeing error message of "No response for request". Some cases happened
> while waiting for response and reset/suspend action was triggered. In this
> case, no response is not an error, active requests will be cancelled.
>
> This patch will
CFG_REQUEST_MSG_1_KLV_KEY (0x << 16)
> +#define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_KEY (0xU << 16)
nit: maybe for consistency we should update all these hex constants to
be explicitly marked as "unsigned" (as that was the intention) and
On 21.03.2022 22:14, Lucas De Marchi wrote:
> On Thu, Mar 03, 2022 at 11:30:10PM +0530, Balasubramani Vivekanandan wrote:
>> memcpy_from_wc functions in i915_memcpy.c will be removed and replaced
>> by the implementation in drm_cache.c.
>> Updated to use the functions provided by drm_cache.c.
On 19.03.2022 00:39, Andi Shyti wrote:
> From: Tvrtko Ursulin
>
> On a multi-tile platform, each tile has its own registers + GGTT
> space, and BAR 0 is extended to cover all of them.
>
> Up to four GTs are supported in i915->gt[], with slot zero
> shadowing the existing i915->gt0 to enable
On 17.02.2022 15:41, Andi Shyti wrote:
> From: Sujaritha Sundaresan
>
> This patch adds the following new sysfs frequency attributes;
> - punit_req_freq_mhz
> - throttle_reason_status
> - throttle_reason_pl1
> - throttle_reason_pl2
> - throttle_reason_pl4
>
On 17.02.2022 15:41, Andi Shyti wrote:
> The "gt_is_root(struct intel_gt *gt)" helper return true if the
> gt is the root gt, which means that its id is 0. Return false
> otherwise.
>
> Suggested-by: Michal Wajdeczko
> Signed-off-by: Andi Shyti
> ---
> driv
On 17.02.2022 15:41, Andi Shyti wrote:
> With the upcoming multitile support each tile will have its own
> local memory. Mark the current LMEM with the suffix '0' to
> emphasise that it belongs to the root tile.
>
> Suggested-by: Michal Wajdeczko
> Signed-off-by: Andi Shyti
On 25.02.2022 18:18, Tvrtko Ursulin wrote:
>
> On 25/02/2022 16:46, John Harrison wrote:
>
driver we don't care that much that we failed to load HWconfig and
'notice' is enough.
but I'm fine with all messages being drm_err (as we will not have to
change that once
- Replace hwconfig param with guc in __guc_action_get_hwconfig()
>>> - Move zero size check into guc_hwconfig_discover_size()
>>> - Change comment to say zero size offset/size is needed to get size
>>> - Add has_guc_hwconfig to devinfo and drop has_table()
&g
ize
>- Add has_guc_hwconfig to devinfo and drop has_table()
> - Change drm_err to notice in __uc_init_hw() and use %pe
>
> Cc: Michal Wajdeczko
> Signed-off-by: Rodrigo Vivi
> Signed-off-by: John Harrison
> Reviewed-by: Matthew Brost
> Acked-by: Jon Bloomfield
> Si
On 22.02.2022 16:11, Janusz Krzysztofik wrote:
> The library provides igt_device_get_pci_device() function that allows to
> get access to a PCI device from an open DRM device file descriptor. It
> can be used on VF devices as long as a DRM driver is bound to them.
> However, SR-IOV tests may
On 08.02.2022 22:05, Jordan Justen wrote:
> i915_drm.h now defines the format of the returned
> DRM_I915_QUERY_HWCONFIG_BLOB query item. Since i915 receives this from
> the black box GuC software, it should verify that the data matches
> that format before sending it to user-space.
>
> The
ffer.
>
> Note that the table is only available on ADL-P and later platforms.
>
> Cc: Michal Wajdeczko
> Signed-off-by: Rodrigo Vivi
> Signed-off-by: John Harrison
> Reviewed-by: Matthew Brost
> ---
> drivers/gpu/drm/i915/Makefile | 1 +
> .../gp
On 13.01.2022 17:27, Matthew Brost wrote:
> Move the multi-lrc guc_id from the lower allocation partition (0 to
> number of multi-lrc guc_ids) to upper allocation partition (number of
> single-lrc to max guc_ids).
>
> This will help when a native driver transitions to a PF after driver
> load
Hi Andi,
few more late nits below
On 17.01.2022 20:32, Andi Shyti wrote:
> The GT has its own properties and in sysfs they should be grouped
> in the 'gt/' directory.
>
> Create a 'gt/' directory in sysfs which will contain gt0...gtN
> directories related to each tile configured in the GPU.
Hi Andi,
please find few late nits below
On 17.01.2022 20:32, Andi Shyti wrote:
> From: Tvrtko Ursulin
>
> On a multi-tile platform, each tile has its own registers + GGTT
> space, and BAR 0 is extended to cover all of them.
>
> Up to four gts are supported in i915->gt[], with slot zero
On 13.01.2022 00:26, Matthew Brost wrote:
> On Thu, Jan 13, 2022 at 12:21:17AM +0100, Michal Wajdeczko wrote:
>> On 11.01.2022 17:30, Matthew Brost wrote:
...
>>> @@ -1863,6 +1861,33 @@ static void guc_submit_request(struct i915_request
>>> *rq)
>>>
1 - 100 of 1919 matches
Mail list logo
