d if not sure before
> >calling igt_device_free().
> >
> > Any preferences?
>
> I would enforce rescan.
>
> BTW I wonder how it can happen if runner is executing each subtest
> in new process so you're starting from scratch and rescan should be
> executed automatically.
>
> Is is the case you're running few tests from the console?
For the record, igt_runner has --multiple-mode where multiple subtests
are executed in the same exec.
--
Petri Latvala
On Fri, Jan 27, 2023 at 11:53:38AM +, Tvrtko Ursulin wrote:
>
> On 27/01/2023 11:39, Petri Latvala wrote:
> > On Fri, Jan 27, 2023 at 11:12:41AM +, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > Now that DRM subsystem can contain
; + idev->driver = strdup_nullsafe(get_attr(idev, "driver"));
> + igt_assert(idev->driver);
> }
>
> return idev;
> @@ -776,7 +778,7 @@ static bool __find_first_i915_card(struct igt_device_card
> *card, bool discrete)
>
>
*/
> + if (flags & DMA_BUF_SYNC_WRITE)
> + pfd.events |= POLLOUT;
> + else if (flags & DMA_BUF_SYNC_READ)
> + pfd.events |= POLLIN;
> +
> + return poll(, 1, 0) == 0;
> +}
> +
> +bool sync_file_busy(int sync_file)
> +{
> +
lose(fd, oh.handle);
> + }
> }
>
> /* All devices should at least have system memory */
> @@ -631,6 +768,134 @@ static void test_query_regions_sanity_check(int fd)
> free(regions);
> }
>
> +#define rounddown(x, y) (x - (x % y))
> +#defin
; }
>
> + igt_describe("Test reponse to an invalid query call");
Typo, reponse -> response.
--
Petri Latvala
> igt_subtest("query-garbage")
> test_query_garbage(fd);
>
> + igt_describe("Test response to inva
__user tells me you didn't
get this header through `make headers_install`.
Also please include the used kernel sha in the commit message.
I tried to replicate this with the current drm-tip version and there
are some differences. Most probably because of not using
headers_install for this patch.
arallel" it would be better to avoid use-after-free.
>
> With this:
>
> Reviewed-by: Zbigniew Kempczyński
Tvrtko is away this week so I made this change and merged.
--
Petri Latvala
>
> --
> Zbigniew
>
> > }
> >
> > /**
> > --
> > 2.32.0
> >
On Fri, May 27, 2022 at 11:50:42AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Be nice and explicitly free all memory on exit.
>
> Also fix a Valgrind reported unitilised conditional jump.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Petri Latvala
Re
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Petri Latvala
> ---
> lib/igt_drm_fdinfo.c | 8
> lib/igt_drm_fdinfo.h | 4 ++--
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lib/igt_drm_fdinfo.c b/lib/igt_drm_fdinfo.c
> index b422f67a4ace..250d9e
: IGPU_PCI);
Checked all usage of 'clients' below this, and everything handles NULL
properly.
That said, nothing seems to free() it, am I reading that correctly?
Anyway, that can be left for another patch, this change is
Reviewed-by: Petri Latvala
> init_engine_classes(engines);
> if (clients) {
> clients->num_classes = engines->num_classes;
> --
> 2.32.0
>
("drm/i915: drop bo->moving dependency")
> Signed-off-by: Matthew Auld
> Cc: Christian König
> Cc: Lucas De Marchi
> Cc: Daniel Vetter
> Reviewed-by: Christian König #v1
For the record, patchwork is disabled at this time. Trybot is still up
if you want CI to ve
.
>
> Signed-off-by: CQ Tang
> Signed-off-by: Matthew Auld
> Cc: Thomas Hellström
> Cc: Nirmoy Das
> Cc: Petri Latvala
> Reviewed-by: Thomas Hellström
> Reviewed-by: Nirmoy Das
> ---
> tests/i915/gem_lmem_swapping.c | 12 +++-
> 1 fi
s_get() handily tells you if lmem_size exists.
igt_debug might not be good for that kind of a print, log buffer isn't
dumped on igt_runner timeouts. igt_info maybe, igt_warn might be
overkill.
--
Petri Latvala
> igt_require_gem(i915);
>
5 missing lmem_size modparam support\n");
> + igt_assert_eq(igt_i915_driver_load(NULL), 0);
> + }
Does the driver load truly fail with an unknown param?
--
Petri Latvala
> +
> + i915 = __drm_open_driver(DRIVER_INTEL);
>
nts to load the module with different params, we save some
time.
If loading the module again doesn't work we should see some fireworks
in CI results elsewhere anyway. Due to module loading problems we used
to limit them to known places (reloading tests, selftests, ...) so we
might need to revisit this topic later. But no need to FUD it at this
time.
--
Petri Latvala
ted batch did not trigger an hang!");
> + igt_assert_f(0, "unterminated batch did not trigger a hang!");
Ouch, this is a bug that could use a drive-by fix in this same commit:
Add a newline after that text.
With that,
Reviewed-by: Petri Latvala
> }
> }
&
> Cc: Daniel Vetter
>
> Will someone ack this or we carry this code until it ships, if it hasn't
> already?
Does that question mean client busyness will some day return?
Either way,
Acked-by: Petri Latvala
>
> Regards,
>
> Tvrtko
>
> > -
On Fri, Nov 19, 2021 at 05:41:08PM +0200, Petri Latvala wrote:
> On Fri, Nov 19, 2021 at 03:34:54PM +, Tvrtko Ursulin wrote:
> > On 19/11/2021 13:53, Petri Latvala wrote:
> > > On Fri, Nov 19, 2021 at 12:59:42PM +, Tvrtko Ursulin wrote:
> > Okay I wasn't sufficien
On Fri, Nov 19, 2021 at 03:34:54PM +, Tvrtko Ursulin wrote:
>
> On 19/11/2021 13:53, Petri Latvala wrote:
> > On Fri, Nov 19, 2021 at 12:59:42PM +, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > .../lib/igt_thread.c: In functi
erread]
>68 | pthread_setspecific(__igt_is_main_thread, (void*) 0x1);
> | ^~
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Petri Latvala
> ---
> lib/igt_core.c | 6 --
> lib/igt_thread.c | 4 +++-
_whitelist(struct intel_engine_cs
> *engine)
>
> wa_init_start(w, "whitelist", engine->name);
>
> - if (IS_XEHPSDV(i915))
> + if (IS_DG2(i915))
> + dg2_whitelist_build(engine);
> + else if (IS_XEHPSDV(i915))
>
On Fri, Nov 12, 2021 at 12:02:24PM +0200, Petri Latvala wrote:
> On Thu, Nov 11, 2021 at 09:57:34PM +0200, Vudum, Lakshminarayana wrote:
> > spec@arb_gpu_shader_fp64@execution@built-in-functions@fs-abs-dvec3 test is
> > not in CI bug log yet.
> >
> > So, I can address
erge are fed to cibuglog only if there's
failures to keep the cpu usage required by test listing under
control. Because of that, handling premerge failures like this is a
bit awkward. Recommendation for this is to just ignore it, looks like
snb just had a bad day running anything.
--
P
On Wed, Nov 03, 2021 at 11:49:47AM -0700, John Harrison wrote:
> On 11/3/2021 02:36, Petri Latvala wrote:
> > On Tue, Nov 02, 2021 at 06:45:38PM -0700, John Harrison wrote:
> > > On 11/2/2021 16:34, Matthew Brost wrote:
> > > > On Thu, Oct 21, 2021 at 04:40:40PM -0
give them beyond
> 'SHORT_PREEMPT_TIMEOUT' or some such. And the whole point of the helper
> function is that the values are programmed in one place only and not used
> anywhere else. So there is no worry about repetition of magic numbers.
In about one year everyone has forg
On Mon, Oct 18, 2021 at 07:10:02PM +0300, Imre Deak wrote:
> On Mon, Oct 18, 2021 at 06:42:38PM +0300, Petri Latvala wrote:
> > On Mon, Oct 18, 2021 at 03:10:54PM +0300, Imre Deak wrote:
> > > Hi Petri, Tomi,
> > >
> > > could you check the failure below?
>
that). Because overall timeout got triggered, igt_results was invoked
against that shard execution in jenkins master host, overwriting the
DUT-written one, and because the journal didn't state the subtest
started, it was parsed as being incomplete.
The logs unfortunately were not able to give any in
On Thu, Sep 16, 2021 at 10:27:41AM -0700, John Harrison wrote:
> On 9/16/2021 01:59, Petri Latvala wrote:
> > On Wed, Sep 15, 2021 at 02:55:58PM -0700, john.c.harri...@intel.com wrote:
> > > From: Rodrigo Vivi
> > >
> > > Newer platforms have an
define DRM_I915_QUERY_MEMORY_REGIONS 4
> +#define DRM_I915_QUERY_HWCONFIG_TABLE 5
> /* Must be kept compact -- no holes and well documented */
Please update i915_drm.h with a copy from the kernel and state in the
commit message which kernel commit sha it's from. If this change is
not in t
On Mon, Sep 06, 2021 at 11:04:13AM +0100, Tvrtko Ursulin wrote:
>
> On 03/09/2021 14:01, Petri Latvala wrote:
> > On Fri, Sep 03, 2021 at 12:29:51PM +0100, Tvrtko Ursulin wrote:
> > >
> > > On 03/09/2021 01:31, jim.cro...@gmail.com wrote:
> > > >
> &
ul mailto:ly...@redhat.com>>
> > Date: Mon Apr 15 14:57:23 2019 -0400
> >
> > and applied it
> > it fixed the one problem
> >
> > then I looked at previous head
> >
> > commit f052e49a43cc9704ea5f240df15dd9d3dfed68ab (origin/master, origin/HEAD)
> > Author: Simon Ser mailto:simon@intel.com>>
> > Date: Wed Apr 24 19:15:26 2019 +0300
> >
> > It sure seems that tree is stale.
That tree's master ref does not get updated. It's only for storing tags.
That test result comparison was too long to fit into patchwork so the
build information at the bottom is missing, but the BAT results have
it:
IGT_6193: 080869f804cb86b25a38889e5ce9a870571cd8c4 @
https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
--
Petri Latvala
t happens before syncing the
files to AWS. The file sync can fail or take an undetermined amount of
time so it's done asynchronously. Typically the files get synced
within around 2 minutes of posting to patchwork but sometimes (~once a
month) sync fails and the files get there as part of the next test
result sync job.
--
Petri Latvala
On Wed, Jul 28, 2021 at 06:53:50PM -0700, Dixit, Ashutosh wrote:
> On Tue, 27 Jul 2021 23:08:40 -0700, Petri Latvala wrote:
> >
> > On Tue, Jul 27, 2021 at 07:01:24PM -0700, Dixit, Ashutosh wrote:
> > > On Mon, 26 Jul 2021 05:03:04 -0700, Matthew Auld wrote:
> > >
lib/i915/gem_mman.c
> > @@ -497,6 +497,43 @@ void *gem_mmap_offset__cpu(int fd, uint32_t handle,
> > uint64_t offset,
> > return ptr;
> > }
> >
> > +#define LOCAL_I915_MMAP_OFFSET_FIXED 4
>
> Cc: @Petri Latvala
>
> This use of LOCAL declarations
r")
> Cc: Desmond Cheong Zhi Xi
> Cc: Emil Velikov
> Cc: sta...@vger.kernel.org
> Signed-off-by: Daniel Vetter
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: Thomas Zimmermann
> Cc: David Airlie
> Cc: Daniel Vetter
You have your "dim fixes" comman
deConnector and caused this SIGSEGV fault
> when release it. Make sure drmModeConnector is available before
> free it can avoid this issue.
>
> Signed-off-by: Lee Shawn C
Reviewed-by: Petri Latvala
> ---
> tests/kms_dp_dsc.c | 5 +++--
> 1 file changed, 3 insertions
d read() checks the buffer
with __builtin_object_size() that it has room for the read. Which it
can only do here if the address is a literal.
Reviewed-by: Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
-0
The default view in the CI results only shows tests that have
issues. "view -> shards all" from the top shows all tests.
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5907/shards-all.html?testfilter=kms_big_fb
--
Petri Latvala
___
Inte
ed.
Meaning, something like:
==
tests/kms_plane_alpha_blend: Don't set primary fb color in
coverage-vs-premult-vs-constant
Similar change has already been done in tests xxx and yyy.
This fixes CRC mismatches seen with some Gen11 systems.
Signed-off-b
oi(tmp),
> + "Request expiry not supported!");
Newline missing at the end.
--
Petri Latvala
> + free(tmp);
>
> - igt_params_save_and_set(i915, "request_timeout_ms",
> -
b.c | 2 +-
> tests/prime_busy.c | 1 +
> tests/prime_mmap.c | 2 +-
> tests/prime_mmap_kms.c | 2 +-
> tests/prime_self_import.c | 2 +-
> tests/prime_vgem.c | 1 +
> tools/intel_reg.c | 2 +-
> 149 files changed, 1447 insertions(+), 134 deletions(-)
> create mode 100644 lib/i915/gem_create.h
> create mode 100644 lib/i915/intel_memory_region.c
> create mode 100644 lib/i915/intel_memory_region.h
Series is
Acked-by: Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Wed, May 19, 2021 at 12:36:17PM +0100, Matthew Auld wrote:
> On Wed, 19 May 2021 at 12:00, Petri Latvala wrote:
> >
> > On Wed, May 19, 2021 at 11:45:17AM +0100, Matthew Auld wrote:
> > > On Wed, 19 May 2021 at 09:49, Petri Latvala
> > > wrote:
> > &g
On Wed, May 19, 2021 at 11:45:17AM +0100, Matthew Auld wrote:
> On Wed, 19 May 2021 at 09:49, Petri Latvala wrote:
> >
> > On Wed, May 19, 2021 at 09:13:37AM +0100, Matthew Auld wrote:
> > > On Tue, 11 May 2021 at 17:52, Matthew Auld wrote:
> > > >
> &
t break? Can we have cases where the
query gives garbage? Can it give two million smem regions? Can it give
0 regions, or -1 regions? And what happens then?
Is it just gem_create_ext that's hiding behind CONFIG_BROKEN or also
the querying?
--
Petri Latvala
___
On Tue, May 11, 2021 at 05:51:12PM +0100, Matthew Auld wrote:
> Sync to get gem_create_ext and the regions query stuff.
Kernel commit sha in commit message please.
--
Petri Latvala
>
> Signed-off-by: Matthew Auld
> ---
> include/drm-uapi/i
stats. (Tvrtko Ursulin)
- - igt_runner can now limit the disk space used by a single test. (Petri
Latvala)
And many other bug fixes, improvements, cleanups and new tests.
Full changelog:
Abhinav Kumar (5):
tools: rename intel_dp_compliance_hotplug to igt_dp_compliance_hotplug
lib
On Thu, Apr 08, 2021 at 10:13:16PM +0200, Daniel Vetter wrote:
> On Thu, Apr 01, 2021 at 03:03:49PM +0300, Petri Latvala wrote:
> > On Thu, Apr 01, 2021 at 12:43:16PM +0100, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > Correct
On Thu, Apr 01, 2021 at 12:43:16PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Correcting a brain malfunction while typing in Makefile.sources.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Petri Latvala
> ---
> tests/Makefile.sources | 2 +-
> 1 f
int err;
>
> - err = check_relocations(>exec[i]);
> + err = check_relocations(eb, >exec[i]);
> if (err)
> return err;
> }
Disclaimer: I don't know deeply how any of this works.
check_relocations() is only called if eb_relocate_parse goes on its
slowpath, fast path doesn't check for gen. Should it, or am I
misunderstanding something?
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
it's now on patchwork.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, Jan 07, 2021 at 09:49:23AM +, Chris Wilson wrote:
> Quoting Petri Latvala (2021-01-07 09:40:02)
> > On Wed, Jan 06, 2021 at 09:41:37AM +, Chris Wilson wrote:
> > > Quoting Janusz Krzysztofik (2020-12-04 19:50:07)
> > > > We may still be intere
ositives are frustrating.
> -Chris
Do you have a link to a test run where this happened? This patch
didn't change the between-tests abort checks.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
r several
> versions of the series, including mine. I would've applied the early
> patches already if I'd gotten some test results.
What gives is the part of the patch that contains
-#define INTEL_CRTC_FUNCS \
-.gamma_set = drm_atomic_helper_legacy_gamma_set, \
which doesn't appl
d-off-by: Chris Wilson
> Cc: Petri Latvala
For the series,
Reviewed-by: Petri Latvala
Thanks!
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
result for it so overall we still
catch tainting cases.
Chris's comments have been clarified off-list not to mean directly
opposing this patch, so
Reviewed-by: Petri Latvala
> ---
> runner/executor.c | 26 --
> 1 file changed, 20 insertions(+), 6 deletions
> - hsw_set_frame_start_delay(new_crtc_state);
> + hsw_set_frame_start_delay(new_crtc_state);
Indentation for this is wrong now.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
binaries in CI's deploy dir.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Sep 11, 2020 at 02:00:11PM +0200, Janusz Krzysztofik wrote:
> Hi Petri,
>
> On Fri, 2020-09-11 at 14:51 +0300, Petri Latvala wrote:
> > On Fri, Sep 11, 2020 at 12:30:38PM +0200, Janusz Krzysztofik wrote:
> > > Subject: [PATCH i-g-t v6 23/24] tests/core_hotun
On Fri, Sep 11, 2020 at 03:15:43PM +0200, Janusz Krzysztofik wrote:
> Hi Petri,
>
> On Fri, 2020-09-11 at 15:22 +0300, Petri Latvala wrote:
> > On Fri, Sep 11, 2020 at 12:30:36PM +0200, Janusz Krzysztofik wrote:
> > > Unbinding the i915 driver on some Haswell
able_audio_runtime_pm();
What happens without this? Is it just a kernel warning, or does the
operation also fail?
If the former, what does this gain? All it does is we lose the
capability to track whether the kernel still has that issue, we still
have to filter this warning in cibuglog.
--
On Fri, Sep 11, 2020 at 12:30:39PM +0200, Janusz Krzysztofik wrote:
> Subject: [PATCH i-g-t v6 24/24] tests/core_hotunplug: Add unbind-rebind
> subtest to BAT scope
Same here, prefix with intel-ci
--
Petri Latvala
___
Intel-gfx mailing list
On Fri, Sep 11, 2020 at 12:30:38PM +0200, Janusz Krzysztofik wrote:
> Subject: [PATCH i-g-t v6 23/24] tests/core_hotunplug: Un-blocklist *bind*
> subtests
Change to
intel-ci: Un-blocklist *bind* subtests of core_hotunplug
--
Petri Latvala
___
ient; \
> + (tmp > 0); (tmp)--, (c)++)
> +
> +static struct clients *init_clients(void)
> +{
> + struct clients *clients = malloc(sizeof(*clients));
> +
> + return memset(clients, 0, sizeof(*clients));
> +}
> +
> +#define SYSFS_CLIENTS "/sys/class/
n the i-g-t committers list, so I cannot push it.
Let's fix that. Please apply in gitlab.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
er unbind-rebind cycle.
> The driver needs to be fixed for the kernel warning not be triggered
> and the tests succeed.
Is there an ETA for the driver fix?
>
> I think the *bind* subtests in their current shape are perfectly ready
> for inclusion in CI runs.
Agreed otherwise, except for the known incomplete. Introducing new
incompletes without a fix in sight is real bad.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
or the whole series?
This one is for the whole series:
Reviewed-by: Petri Latvala
>
> Thanks!
>
> -Lionel
>
> > ---
> > tests/i915/perf.c| 8
> > tools/i915-perf/i915_perf_recorder.c | 2 +-
> > 2 files changed, 5 insertions(+)
CI is going to tell you that
something is not passing. Without this it will be a skip, along with
skipping in the case that should just work already without actual test
changes.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Wed, May 13, 2020 at 06:02:23PM +0100, Chris Wilson wrote:
> diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_drm.h
In a separate commit please, with the commit message stating which
kernel git sha it's from.
--
Petri Latv
On Mon, May 11, 2020 at 10:53:58AM +0100, Chris Wilson wrote:
> Quoting Petri Latvala (2020-05-11 10:49:10)
> > On Mon, May 11, 2020 at 10:39:24AM +0100, Chris Wilson wrote:
> > > Change the basic pre-mergetest to do a single pass over all engines
> > > simultaneously.
ize.
>
> v2: Move around the quiescence and requires to avoid calling them from
> the children.
>
> Signed-off-by: Chris Wilson
> Cc: Petri Latvala
> ---
> tests/i915/gem_ringfill.c | 31 ---
> tests/intel-ci/fast-feedback.testlist |
xecution_engine2 *e;
> +
> + __for_each_physical_engine(fd, e)
> + igt_fork(child, 1)
> + run_test(fd, e->flags, 0, 1);
Will it happen simultaneously though without synchronization?
(Obvious quip about executing too fast)
run_test() calls igt_re
rt_on_f() on device reopen failure (Petri),
> - if any timeout set with igt_set_timeout() inside a subtest expires,
> call igt_abort_on_f() from a follow-up igt_fixture (Petri),
> - when running on a i915 device, require GEM and call
> igt_abort_on_f() if no usable GEM
> > On ARM (32bits), this cast creates a compilation error since the
> > > pointer size isn't an uint64_t.
> >
> > Does casting to uintptr_t before uint64_t fix it?
>
> It does yep. Casting to uintptr_t alone also works
to_user_pointer(out_fence_ptr)
--
Petri Latval
On Mon, Apr 06, 2020 at 09:53:09AM +0100, Chris Wilson wrote:
> An important ingredient to using igt_subtest_with_dynamic is to include
> an igt_dynamic at some point.
>
> Reported-by: Petri Latvala
> Fixes: 311cb1b360b7 ("i915/perf_pmu: Dynamic active engine tests"
On Mon, Mar 30, 2020 at 06:56:36PM -0300, Melissa Wen wrote:
> Generalize description of fd since it is not restricted to i915 driver fd
>
> Signed-off-by: Melissa Wen
Reviewed-by: Petri Latvala
Please send future IGT patches to igt-...@lists.freedesktop.o
On Mon, Mar 30, 2020 at 06:55:32PM -0300, Melissa Wen wrote:
> Typo found in word transparent.
> Correct the word transparant, replacing the last letter -a- with -e-
> (transpar-a-nt to transpar-e-nt).
>
> Signed-off-by: Melissa Wen
Reviewed-by: Petri Latvala
Martin, test r
Lakshmi, see below.
On Tue, Mar 17, 2020 at 09:53:51AM +0100, Janusz Krzysztofik wrote:
> Hi,
>
> On Mon, 2020-03-16 at 19:25 +, Patchwork wrote:
> > == Series Details ==
> >
> > Series: tests/gem_userptr_blits: Refresh other now MMAP_GTT dependent
> > subtests (rev2)
> > URL :
igned-off-by: Chris Wilson
> Cc: Petri Latvala
> ---
> tests/intel-ci/blacklist.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index 948b47569..184c23c37 100644
> --- a/tests
On 2/28/20 8:52 PM, Souza, Jose wrote:
On Fri, 2020-02-28 at 12:21 +0200, Petri Latvala wrote:
On Thu, Feb 27, 2020 at 11:42:03PM +, Souza, Jose wrote:
The following changes since commit
efcfa03ae6100dfe523ebf612e03c3a90fc4c794:
linux-firmware: Update firmware file for Intel Bluetooth
On Fri, Feb 28, 2020 at 10:12:36AM +, Chris Wilson wrote:
> Use a fixed duration rather than a fixed amount of work.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/1325
> Signed-off-by: Chris Wilson
Reviewed-by: Petri Latvala
> ---
> tests/i915/gem_softpin
_06.bin
Patchwork didn't pick up this PR, I suspect the extra newlines to be
the issue. Can you try resending this without the automatic newlines
before the commit shas?
If patchwork recognizes it as a pull request, it will appear in here:
https://patchwork.freedesktop.org/api/1.0/projects
We
> need to manually control the nesting of cleanup, and so need to use
> __drm_open_driver() to avoid the default exithandler.
>
> References: https://gitlab.freedesktop.org/drm/intel/issues/1085#note_419148
> Signed-off-by: Chris Wilson
Reviewed-by: Petri Latvala
> ---
> tests/pe
On Thu, Feb 13, 2020 at 11:29:48AM -0800, Dale B Stimson wrote:
> On 2020-02-13 10:29:55, Petri Latvala wrote:
> > On Wed, Feb 12, 2020 at 05:28:40PM -0800, Dale B Stimson wrote:
> > > At the start of igt_main, failure of the initial tests for successful
> > > init
making the test result 'notrun' instead of the correct 'skip'
or 'fail'.
What is the problem this is trying to solve? Incorrect engine list
used? If you have a subtest per static engine, all CI does is execute
per static engine. Converting this test to use dynamic subtests for
engines is the way fo
@@ TESTS_progs = \
> vgem_slow \
> $(NULL)
>
> +TESTS_progs += sysfs_heartbeat_interval
> +sysfs_heartbeat_interval_SOURCES = i915/sysfs_heartbeat_interval
Another missing .c
--
Petri Latvala
___
Intel-gfx mailing list
const char *fmt, ...);
> uint32_t gem_engine_mmio_base(int i915, const char *engine);
>
> +void dyn_sysfs_engines(int i915, int engines, const char *file,
> +void (*test)(int i915, int engine));
> +
> #endif /* GEM_ENGINE_TOPOLOGY_H */
>
On Tue, Feb 11, 2020 at 11:37:32AM +0200, Petri Latvala wrote:
> On Tue, Feb 11, 2020 at 11:30:03AM +0200, Jani Nikula wrote:
> > On Tue, 11 Feb 2020, Petri Latvala wrote:
> > >> diff --git a/lib/i915/gem_mmio_base.c b/lib/i915/gem_mmio_base.c
> > >> new file m
On Tue, Feb 11, 2020 at 11:30:03AM +0200, Jani Nikula wrote:
> On Tue, 11 Feb 2020, Petri Latvala wrote:
> >> diff --git a/lib/i915/gem_mmio_base.c b/lib/i915/gem_mmio_base.c
> >> new file mode 100644
> >> index 0..8718c092f
> >> --- /dev/n
ase.c
> @@ -0,0 +1,346 @@
> +// Copyright (C) 2020 Intel Corporation
> +//
> +// SPDX-License-Identifier: MIT
We don't use SPDX headers in IGT, please use the MIT license comment
block instead.
--
Petri Latvala
> +
> +#include
> +
> +#include
> +
> +#include
On Mon, Feb 10, 2020 at 10:11:35AM +, Chris Wilson wrote:
> In hindsignt,
Your h is damaged.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Jan 31, 2020 at 02:12:33PM +0100, Janusz Krzysztofik wrote:
> I'm adding a cover letter in case it is required for having a related
> kernel side patch been tested with this one.
For the record, Test-With doesn't require the IGT side to have a cover
letter.
--
Petri L
On Thu, Jan 23, 2020 at 12:01:34PM +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Quick fixup to the test so correct way of iterating the static engine list
> is used. More comprehensive fixes to the test are in progress.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed
and dynamic engine enumeration.
> >
> > This patch makes one more step in that direction by removing the
> > dependency on the static list when generating probed engine names.
> >
> > Signed-off-by: Tvrtko Ursulin
> > Cc: Andi Shyti
> &
t; Fix it.
>
> Signed-off-by: Janusz Krzysztofik
> Reviewed-by: Ewelina Musial
> ---
> Assuming the R-b: from Ewelina is sufficient, can someone push this,
> please? I can't do that myself as I have no push permissions.
>
Pushed, thanks fo
/* no set-domain as we want to verify the pagefault is async */
> + ptr[256] = 0;
> + igt_reset_timeout();
> +
> + munmap(ptr, 4096);
> + }
> +
> + igt_spin_free(i915, spin);
> +}
> +
> +static void close
y: Chris Wilson
> ---
> tests/Makefile.sources | 3 -
> tests/i915/gem_cpu_reloc.c | 309 -
> tests/meson.build | 1 -
Remove igt@gem_cpu_reloc@basic from fast-feedback.testlist too.
--
Petri Latvala
__
On Fri, Nov 22, 2019 at 09:20:11AM +, Chris Wilson wrote:
> Quoting Petri Latvala (2019-11-22 09:14:07)
> > On Thu, Nov 21, 2019 at 05:19:30PM +0200, Mika Kuoppala wrote:
> > > Add vulnerability checker for cve-2019-0155
> > >
> > > v2: sync, bailout early
/Makefile.sources | 5 +
> cve/cve-2019-0155.c | 470 +++
> cve/meson.build | 12 ++
> meson.build | 1 +
Why do we need a new source directory and new install directory for
this? Can't this be in tools/?
--
Petri Latvala
nt of view of reading a particular test.
>
> A comment above the test function seems more appropriate, at least you don't
> have to look at 2 different places to find out about a particular test.
>
>
> Unless there is some untold goal here, like producing some kind of re
1 - 100 of 508 matches
Mail list logo
