.
I feel that we might have other cases there that could deserve a
protection like this.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Luca Coelho
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/driver
other precedences on this and agree this is safe and
better.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Luca Coelho
> ---
> drivers/gpu/drm/i915/display/intel_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_c
On Mon, May 27, 2024 at 04:00:25PM +0100, Andi Shyti wrote:
> On Mon, May 27, 2024 at 11:47:49AM +0100, Andi Shyti wrote:
> > On Fri, May 24, 2024 at 10:07:44AM -0400, Rodrigo Vivi wrote:
> > > On Fri, May 24, 2024 at 01:58:53AM +0200, Andi Shyti wrote:
> > > > Follo
On Fri, May 24, 2024 at 01:58:53AM +0200, Andi Shyti wrote:
> Following the guidelines it takes 3 seconds to perform an FLR
> reset. Let's give it a bit more slack because this time can
> change depending on the platform and on the firmware
But did we see any issue with that?
if that changes per
On Fri, May 24, 2024 at 11:17:32AM +0300, Jani Nikula wrote:
> On Thu, 23 May 2024, Rodrigo Vivi wrote:
> > On Wed, May 22, 2024 at 08:33:42PM +0300, Jani Nikula wrote:
> >> We'll need to start identifying the platforms independently in display
> >> code in order
.
An alternative way would be to keep the state->wakeref, returning
them only at the workers. But this could lead in unbalanced scenarios
if workers gets canceled. So, the preference was to keep it simple
and get a new reference inside the thread.
Cc: Matthew Auld
Cc: Francois Dugast
Cc: Imre Deak
On Wed, May 22, 2024 at 08:33:42PM +0300, Jani Nikula wrote:
> We'll need to start identifying the platforms independently in display
> code in order to break free from the i915 and xe IS_()
> macros. This is fairly straightforward, as we already identify most
> platforms by PCI ID in display
On Wed, May 22, 2024 at 08:33:44PM +0300, Jani Nikula wrote:
> We'll need to identify all platforms, including the ones that have
> display defined by GMD ID. Add MTL and LNL. Their display info will
> still be probed via GMD ID.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-
On Wed, May 22, 2024 at 08:33:45PM +0300, Jani Nikula wrote:
> Add enum intel_display_platform and add that and name to all platform
> descriptors.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
> .../drm/i915/display/intel_display_device.c | 48
subplatform. This is different from i915 core, and is notable in the
> handling of ULT/ULX and RPL/RPL-U.
Only used to print information in the next patch?
But I guess other future use in mind as well?
anyway it is a good organization by itself.
Reviewed-by: Rodrigo Vivi
>
> Signe
On Wed, May 22, 2024 at 08:33:47PM +0300, Jani Nikula wrote:
> Add an info message about which display device was probed.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_display_device.c | 5 +
> 1 file cha
s.
although it might get harder to distinguish the intersection, this
might be a good idea indeed.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
> include/drm/i915_pciids.h | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/includ
e. or perhaps gmd_id_disp ?
But I'm bad with nameing, so up to you:
Reviewed-by: Rodrigo Vivi
> void __iomem *addr;
> u32 val;
> int i;
>
> - /* The caller expects to ver, rel and step to be initialized
> - * here, and there's no good
On Wed, May 22, 2024 at 08:33:40PM +0300, Jani Nikula wrote:
> The main change here is that the check for platforms without display is
> now also done for GMD ID based platforms. However, without matches, the
> end result is the same.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-
915_private
> *i915)
> DISPLAY_RUNTIME_INFO(i915)->ip.rel = rel;
> DISPLAY_RUNTIME_INFO(i915)->ip.step = step;
> }
> +
> + return;
> +
> +no_display:
> + DISPLAY_INFO(i915) = _display;
now I understood why you moved it over and I believe display_runtime_info
is really not needed when no_display, so:
Reviewed-by: Rodrigo Vivi
> }
>
> void intel_display_device_remove(struct drm_i915_private *i915)
> --
> 2.39.2
>
p.step = step;
> }
> -
> - intel_display_params_copy(>display.params);
I confess I got lost on the macros there. But from what I could
see, none of the things in between these 2 points would change
anything related to the params that are getting copied here.
Reviewed-by: Rodrigo Vivi
> }
>
> void intel_display_device_remove(struct drm_i915_private *i915)
> --
> 2.39.2
>
On Wed, May 22, 2024 at 09:36:40PM +0300, Jani Nikula wrote:
> On Wed, 22 May 2024, Gustavo Sousa wrote:
> > Quoting Jani Nikula (2024-05-22 14:33:37-03:00)
> >>Add independent platform probe in display, in preparation for breaking
> >>free from i915 and xe code.
> >>
> >>Up next would be adding
On Wed, May 15, 2024 at 07:56:51PM +0300, Jani Nikula wrote:
> Now that the PCI ID macros allow us to pass in the macro to use, stop
> redefining INTEL_VGA_DEVICE.
Reviewed-by: Rodrigo Vivi
>
> Cc: Lucas De Marchi
> Cc: Rodrigo Vivi
> Signed-off-by: Jani Nikula
> ---
&g
On Wed, May 15, 2024 at 07:56:51PM +0300, Jani Nikula wrote:
> Now that the PCI ID macros allow us to pass in the macro to use, stop
> redefining INTEL_VGA_DEVICE.
Reviewed-by: Rodrigo Vivi
>
> Cc: Lucas De Marchi
> Cc: Rodrigo Vivi
> Signed-off-by: Jani Nikula
> ---
&g
a special case, and
> unconditionally uses INTEL_QUANTA_VGA_DEVICE().
>
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Cc: Lucas De Marchi
> Cc: Rodrigo Vivi
> Signed-off-by: Jani Nikula
>
> ---
>
> Tip: It's probably easiest to apply and use 'git show --col
On Mon, May 13, 2024 at 02:14:51AM -0400, Deming Wang wrote:
> The mapings should be replaced by mappings.
>
> Signed-off-by: Deming Wang
Reviewed-by: Rodrigo Vivi
and pushed to drm-intel-gt-next
thanks for the patch
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c |
On Fri, May 10, 2024 at 02:22:20PM +0300, Jani Nikula wrote:
> Most other PCI ID macros do not encode the gen in the name. Follow suit
> for TGL.
Reviewed-by: Rodrigo Vivi
>
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Jani Nikula
> ---
>
On Fri, May 10, 2024 at 02:22:19PM +0300, Jani Nikula wrote:
> Most other PCI ID macros do not encode the gen in the name. Follow suit
> for ICL.
Reviewed-by: Rodrigo Vivi
>
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Jani Nikula
> ---
>
go by the idea that if a platform has a name, group its PCI IDs
> together.
>
> That said, AML is special, having both KBL and CFL variants. Leave that
> alone.
fine by me, and thanks for the CML WHL.
Reviewed-by: Rodrigo Vivi
>
> v2: Also split out WHL not just CML (Rodr
On Fri, May 10, 2024 at 02:22:17PM +0300, Jani Nikula wrote:
> Add INTEL_IVB_IDS() to identify all IVBs except IVB Q transcode.
>
Reviewed-by: Rodrigo Vivi
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Jani Nikula
> ---
> arch/x86/
On Fri, May 10, 2024 at 02:22:16PM +0300, Jani Nikula wrote:
> Add INTEL_SNB_IDS() to identify all SNBs.
Reviewed-by: Rodrigo Vivi
>
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Jani Nikula
> ---
> arch/x86/kernel/early-quirks.c
On Fri, May 10, 2024 at 02:22:15PM +0300, Jani Nikula wrote:
> Most other PCI ID macros use platform acronyms. Follow suit for ILK. Add
> INTEL_ILK_IDS() to identify all ILKs.
Reviewed-by: Rodrigo Vivi
>
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-o
On Fri, May 10, 2024 at 02:22:14PM +0300, Jani Nikula wrote:
> Most other PCI ID macros use platform acronyms. Follow suit for PNV. Add
> INTEL_PNV_IDS() to identify all PNVs.
>
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Jani Nikula
Reviewe
On Wed, May 08, 2024 at 06:47:56PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the TRANS_VRR_VSYNC register macro.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/displ
On Wed, May 08, 2024 at 06:47:55PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the TRANS_PUSH register macro.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/displ
O_TRANS2(dev_priv, trans,
> _TRANS_VRR_STATUS2_A)
ditto,
Reviewed-by: Rodrigo Vivi
> #define VRR_STATUS2_VERT_LN_CNT_MASK REG_GENMASK(19, 0)
>
> #define _TRANS_PUSH_A0x60A70
> --
> 2.39.2
>
On Wed, May 08, 2024 at 06:47:53PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the TRANS_VRR_FLIPLINE register macro.
>
Reviewed-by: Rodrigo Vivi
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/d
dev_priv, trans) _MMIO_TRANS2(dev_priv,
> trans, \
> _TRANS_VRR_VTOTAL_PREV_A)
ditto,
Reviewed-by: Rodrigo Vivi
> #define VRR_VTOTAL_FLIP_BEFR_BNDR REG_BIT(31)
> #define VRR_VTOTAL_FLIP_AFTER_BNDR REG_BIT(30)
> --
> 2.39.2
>
On Wed, May 08, 2024 at 06:47:51PM +0300, Jani Nikula wrote:
61;7600;1c> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the TRANS_VRR_STATUS register macro.
>
Reviewed-by: Rodrigo Vivi
> Signed-off-by: Jani Nikula
> ---
> drivers/gp
2(dev_priv, trans, \
unused? should we remove?
or one of those with wip around that is going to get used soon?
if so,
Reviewed-by: Rodrigo Vivi
> _TRANS_VRR_VMAXSHIFT_A)
> #define VRR_VMAXSHIFT_DEC_MASK REG_GENMASK(29, 16)
> #define VRR_VMAXSHIFT_DEC REG_BIT(16)
> --
> 2.39.2
>
On Wed, May 08, 2024 at 06:47:49PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the TRANS_VRR_VMIN register macro.
>
Reviewed-by: Rodrigo Vivi
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/displ
On Wed, May 08, 2024 at 06:47:48PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the TRANS_VRR_VMAX register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/displ
On Wed, May 08, 2024 at 06:47:47PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the TRANS_VRR_CTL register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/displa
On Mon, May 06, 2024 at 12:36:02PM +0200, Maarten Lankhorst wrote:
> The DPT bo should not be allocated when pinning, but in advance when
> creating the framebuffer.
why is that? (just trying to understand to see if I'm able to help
with this review)
> Split allocation from bo pinning and GGTT
On Mon, May 06, 2024 at 12:36:01PM +0200, Maarten Lankhorst wrote:
> This is invalid with display code when reworking DPT pinning.
> The only reason we added it, was because originally all display
> allocations also had the bit set.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-b
Hi Dave and Sima,
Here goes our last fixes for v6.9.
drm-intel-fixes-2024-05-08:
- Automate CCS Mode setting during engine resets (Andi)
- Fix audio time stamp programming for DP (Chaitanya)
- Fix parsing backlight BDB data (Karthikeyan)
The following changes since commit
On Wed, May 08, 2024 at 04:01:56PM +0300, Jani Nikula wrote:
> On Wed, 08 May 2024, Rodrigo Vivi wrote:
> > On Tue, May 07, 2024 at 03:56:51PM +0300, Jani Nikula wrote:
> >> For HSW/BDW ULX machines are also considered ULT. For the sake of
> >> sim
On Tue, May 07, 2024 at 03:56:51PM +0300, Jani Nikula wrote:
> For HSW/BDW ULX machines are also considered ULT. For the sake of
> simplicity and clarity, handle this at the IS_XXX_ULT() macro level
> instead of two simultaneous subplatforms.
>
> Signed-off-by: Jani Nikula
> ---
>
On Tue, May 07, 2024 at 03:56:50PM +0300, Jani Nikula wrote:
> RPL-S is a subplatform of ADL-S and RPL-P is a subplatform of
> ADL-P. It's a bit much that RPL-P also matches RPL-U. Separate RPL-U
> from RPL-P, and make RPL-U a standalone subplatform of ADL-P.
Now I confess I got lost. And I
Anyway, it looks like the right thing and we should
probably change Xe too.
Reviewed-by: Rodrigo Vivi
>
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Jani Nikula
> ---
> arch/x86/kernel/early-quirks.c | 1 +
> d
On Wed, May 08, 2024 at 11:33:43AM +0300, Jani Nikula wrote:
> On Tue, 07 May 2024, Rodrigo Vivi wrote:
> > On Tue, May 07, 2024 at 03:56:48PM +0300, Jani Nikula wrote:
> >> @@ -535,11 +541,7 @@
> >>INTEL_WHL_U_GT1_IDS(info), \
> >>INTEL_WHL_U_GT2_IDS(
0 ]---
> > >
> > > We defer actually closing, unbinding and destroying a VMA until next idle
> > > point, or until the object is freed in the meantime. By postponing the
> > > unbind, we allow for the VMA to be reopened by the client, avoiding the
> > > work require
On Tue, May 07, 2024 at 03:56:48PM +0300, Jani Nikula wrote:
> It's confusing for INTEL_CFL_IDS() to include all CML PCI IDs. Even if
> we treat them the same in a lot of places, CML is a platform of its own,
> and the lists of PCI IDs should not conflate them.
>
> Cc: Bjorn Helgaas
> Cc:
ew of it so we can work to understand
> >> >and fix any potential issue around our async vblanks.
> >> >
> >> >Please notice that the every struct here follows exactly the GuC
> >> >shared data buffer, so the next step of the integration would be
&
hat the releasing after the unprepare sounds more logical,
but if there's no actual issue with that and it is working for
everybody, let's do that.
Reviewed-by: Rodrigo Vivi
Acked-by: Rodrigo Vivi
(to get through drm-misc with everything else if you prefer)
> - kfree(fb_helper);
> -
our async vblanks.
> >
> >Please notice that the every struct here follows exactly the GuC shared data
> >buffer, so the next step of the integration would be smooth and almost
> >transparent to this intel_metrics on the display side.
> >
> >Cc: Uma Shankar
On Sat, May 04, 2024 at 04:29:48PM -0700, Niranjana Vishwanathapura wrote:
please use intel...@lists.freedesktop.org for patches touching only xe.
probably a good idea to use some gitconfig identities:
[sendemail "i915"]
to = intel-gfx@lists.freedesktop.org
[sendemail "xe"]
to =
On Fri, May 03, 2024 at 02:04:15PM -0700, Easwar Hariharan wrote:
> On 5/3/2024 12:34 PM, Rodrigo Vivi wrote:
> > On Fri, May 03, 2024 at 06:13:24PM +, Easwar Hariharan wrote:
> >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced
> >> "master/s
rs of
> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
> in the specification.
>
> Compile tested, no functionality changes intended
>
> [1]:
> https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/
>
> Revie
On Thu, May 02, 2024 at 12:28:33PM +0300, Jani Nikula wrote:
> On Tue, 30 Apr 2024, Rodrigo Vivi wrote:
> > On Tue, Apr 30, 2024 at 01:09:59PM +0300, Jani Nikula wrote:
> >> Avoid the implicit dev_priv local variable use, and pass dev_priv
> >> explicitly to the EDP
Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 3 ++-
> drivers/gpu/drm/i915/display/intel_psr_regs.h | 4 ++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/g
On Thu, May 02, 2024 at 03:14:23PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> This extra macro level between the region IDs and their bitmasks
> just makes it harder to see what is used where. Get rid of the
> wrappers.
>
> Signed-off-by: Ville Syrjälä
Revi
On Thu, May 02, 2024 at 03:14:22PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The name 'HAS_REGION()' suggests we are checking for a single
> region, so seem more sensible to pass in the region ID rather
> than a bitmask.
>
> Signed-off-by: Ville Syrjälä
Revi
SMEM is always
> available, but also not checking what was intended.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/gt/intel_gt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/
Reviewed-by: Rodrigo Vivi
On Tue, Apr 30, 2024 at 01:10:13PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the PORT_ALPM_LFPS_CTL register macro.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/d
On Tue, Apr 30, 2024 at 01:10:12PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the PORT_ALPM_CTL register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/d
On Tue, Apr 30, 2024 at 01:10:11PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the ALPM_CTL2 register macro.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_psr_regs.h | 2 +-
> 1 file changed, 1
On Tue, Apr 30, 2024 at 01:10:10PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the ALPM_CTL register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/in
On Tue, Apr 30, 2024 at 01:10:09PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the PIPE_SRCSZ_ERLY_TPT register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gp
On Tue, Apr 30, 2024 at 01:10:08PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the PSR2_MAN_TRK_CTL register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/d
On Tue, Apr 30, 2024 at 01:10:07PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the _PSR2_SU_STATUS register macro.
>
> Signed-off-by: Jani Nikula
why aren't we going one level up here already?
> ---
>
On Tue, Apr 30, 2024 at 01:10:06PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the EDP_PSR2_STATUS register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/d
On Tue, Apr 30, 2024 at 01:10:05PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the PSR_EVENT register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/in
On Tue, Apr 30, 2024 at 01:10:04PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the EDP_PSR2_CTL register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/d
On Tue, Apr 30, 2024 at 01:10:03PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the EDP_PSR_DEBUG register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/d
On Tue, Apr 30, 2024 at 01:10:02PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the EDP_PSR_PERF_CNT register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/d
On Tue, Apr 30, 2024 at 01:10:01PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the EDP_PSR_STATUS register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/d
On Tue, Apr 30, 2024 at 01:10:00PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the EDP_PSR_AUX_DATA register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/d
5.
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
> drivers/gpu/drm/i915/display/intel_psr_regs.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm
On Tue, Apr 30, 2024 at 01:09:58PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the TRANS_PSR_IIR register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/i
On Tue, Apr 30, 2024 at 01:09:57PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the TRANS_PSR_IMR register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/i
On Tue, Apr 30, 2024 at 01:09:56PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the EDP_PSR_CTL register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/in
On Tue, Apr 30, 2024 at 01:09:55PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the TRANS_EXITLINE register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/d
ned-off-by: Easwar Hariharan
I'm glad to see this change!
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/dvo_ch7017.c | 14 -
> drivers/gpu/drm/i915/display/dvo_ch7xxx.c | 18 +--
> drivers/gpu/drm/i915/display/dvo_ivch.c | 16 +-
Hi Dave and Sima,
Here goes one extra, and really the last one targeting 6.10.
We have decided to do this extra one so we could include the
good clean-up on i915/xe's fbdev work done by Thomas Zimmermann.
And it looks like he has more work on top of that, so it would
be good to propagate this
On Mon, Apr 29, 2024 at 09:29:15AM -0700, Ashutosh Dixit wrote:
> Switching from xe_device_mem_access_get/put to xe_pm_runtime_get/put
> results in the following WARNING in xe_oa:
>
> [11614.356168] xe :00:02.0: Missing outer runtime PM protection
> [11614.356187] WARNING: CPU: 1 PID: 13075
On Mon, Apr 29, 2024 at 05:02:21PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the PIPE_WGC_C22 register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/dis
On Mon, Apr 29, 2024 at 05:02:20PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the PIPE_WGC_C21_C20 register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/dis
On Mon, Apr 29, 2024 at 05:02:19PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the PIPE_WGC_C12 register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/dis
On Mon, Apr 29, 2024 at 05:02:18PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the PIPE_WGC_C11_C10 register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/dis
On Mon, Apr 29, 2024 at 05:02:17PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the PIPE_WGC_C02 register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/dis
On Mon, Apr 29, 2024 at 05:02:16PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the PIPE_WGC_C01_C00 register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/dis
On Mon, Apr 29, 2024 at 05:02:15PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the PALETTE register macro.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/int
On Thu, Apr 25, 2024 at 12:56:57PM -0700, Vinay Belgaumkar wrote:
> Pcode can dynamically update RPe frequency. Use the latest value
> in tests that check it.
>
> Signed-off-by: Vinay Belgaumkar
Reviewed-by: Rodrigo Vivi
> ---
> tests/intel/xe_gt_freq.c | 7 +++
&g
On Fri, Apr 26, 2024 at 04:09:45PM +0300, Jani Nikula wrote:
> On Fri, 26 Apr 2024, Jani Nikula wrote:
> > Hey all, it's time to stop using the implicit dev_priv local variable in
> > register macros. Yes, this is huge. It's also (almost) completely
> > scripted.
>
> Okay, I was first going to
t; Update its location with a URL matching other fd.o GitLab kernel trees.
> > >
> > > Signed-off-by: Ryszard Knop
> >
> > Acked-by: Lucas De Marchi
> >
> > Also Cc'ing maintainers
>
> Thanks,
>
> Acked-by: Tvrtko Ursulin
Acked-by: Rodr
db31251bb26 ("drm/i915/gt: Enable only one CCS for compute workload")
> Reported-by: Gnattu OC
> Signed-off-by: Andi Shyti
> Cc: Chris Wilson
> Cc: Joonas Lahtinen
> Cc: Matt Roper
> Cc: # v6.2+
Reviewed-by: Rodrigo Vivi
> ---
> Hi Gnattu,
>
> thanks ag
On Wed, Apr 10, 2024 at 08:18:10AM +0530, Arun R Murthy wrote:
> Use mul_u32_u32 to avoid potential overflow in multiplying two u32 and
> store the u64 result.
>
> v2: remove u64 typecast and use mul_u32_u32 (Ville)
> v3: Reframe the commit message
I still believe that the message is not that
Hi Sima and Dave,
Here goes our last pull request towards 6.10.
drm-intel-next-2024-04-24:
Core Changes:
- Some DP/DP_MST DRM helpers (Imre)
Driver Changes (i915 Display):
- PLL refactoring (Ville)
- Limit eDP MSO pipe only for display version 20 (Luca)
- More display refactor towards
t; selection. If the register address depends on DISPLAY_MMIO_BASE(), this
> removes the need to figure the base out for each register, and it only
> needs to be added once.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> .../drm/i915/display/intel_display_reg_defs.h |
e, no?
perhaps at least a comment somewhere there?
but up to you...
>
> Signed-off-by: Jani Nikula
>
> ---
>
> If we can think of a better name for the macros, now would be a good
> time!
I'm definitely not good with names and would be open to any good name
Reviewed-by: Ro
On Mon, Apr 22, 2024 at 06:16:59PM -0300, Gustavo Sousa wrote:
> Quoting Rodrigo Vivi (2024-04-22 18:10:50-03:00)
> >On Fri, Apr 19, 2024 at 01:04:06PM +0300, Jani Nikula wrote:
> >> Stop relying on the dev_priv local variable in the DSI register
> >> macros. Pass s
color-words' is probably
> the easiest way to review.
wow! this is indeed a nice feature for this case. I had never tried it before.
Thanks for showing that.
But the registers changes were easier to review the old way. ;)
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/displ
ice clean-up
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/vlv_dsi.c | 134 +++--
> 1 file changed, 60 insertions(+), 74 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c
> b/dr
by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/vlv_dsi.c | 6 +++---
> drivers/gpu/drm/i915/display/vlv_dsi_regs.h | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c
> b/dr
1 - 100 of 5644 matches
Mail list logo
