[Intel-gfx] [PATCH] drm/i915: do not set redundant DP dpms mode

2012-10-23 Thread Simon Que
Add a check to intel_dp_dpms() to skip setting the DP's DPMS mode if the current mode is the same as the new one. Signed-off-by: Simon Que s...@chromium.org --- drivers/gpu/drm/i915/intel_dp.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] xf86-video-intel: change order of DPMS operations

2011-12-07 Thread Simon Que
) kernel: enable backlight, backlight=0 This restores the saved nonzero backlight value during the force on. Signed-off-by: Simon Que s...@chromium.org --- src/intel_display.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/intel_display.c b/src

[Intel-gfx] [PATCH v3] drivers: i915: Default backlight PWM frequency

2011-11-11 Thread Simon Que
results in no change to the PWM registers. Signed-off-by: Simon Que s...@chromium.org To: intel-gfx@lists.freedesktop.org To: Jesse Barnes jbar...@virtuousgeek.org To: Chris Wilson ch...@chris-wilson.co.uk To: Eric Anholt e...@anholt.net To: Matthew Garrett mj...@srcf.ucam.org Cc: Olof Johansson ol

[Intel-gfx] [PATCH v4] drivers: i915: Default backlight PWM frequency

2011-11-11 Thread Simon Que
results in no change to the PWM registers. Signed-off-by: Simon Que s...@chromium.org --- drivers/gpu/drm/i915/intel_panel.c | 38 ++- 1 files changed, 32 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/2] drivers: i915: Fix BLC PWM register setup

2011-11-10 Thread Simon Que
There is an error in i915_read_blc_pwm_ctl, where the register values are not being copied correctly. BLC_PWM_CTL and BLC_PWM_CTL2 are getting mixed up. This patch fixes that so that saveBLC_PWM_CTL2 and not saveBLC_PWM_CTL is copied to the BLC_PWM_CTL2 register. Signed-off-by: Simon Que s

[Intel-gfx] [PATCH v2] drivers: i915: Default backlight PWM frequency

2011-11-10 Thread Simon Que
results in no change to the PWM registers. Signed-off-by: Simon Que s...@chromium.org --- drivers/gpu/drm/i915/i915_reg.h|1 + drivers/gpu/drm/i915/intel_panel.c | 37 +-- 2 files changed, 31 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/2] drivers: i915: Fix BLC PWM register setup

2011-11-08 Thread Simon Que
There is an error in i915_read_blc_pwm_ctl, where the register values are not being copied correctly. BLC_PWM_CTL and BLC_PWM_CTL2 are getting mixed up. This patch fixes that so that saveBLC_PWM_CTL2 and not saveBLC_PWM_CTL is copied to the BLC_PWM_CTL2 register. Signed-off-by: Simon Que s

[Intel-gfx] [PATCH v3 2/2] drivers: i915: Default max backlight brightness value

2011-11-08 Thread Simon Que
Use 0x1000 as the default backlight PWM max value and period. This is passed in as a module parameter to i915_drv and is used to program the PWM registers. It can be set to other values based on the needs of each system. Signed-off-by: Simon Que s...@chromium.org --- Matthew, this patch has

Re: [Intel-gfx] [PATCH v3 2/2] drivers: i915: Default max backlight brightness value

2011-11-08 Thread Simon Que
On Tue, Nov 8, 2011 at 1:42 PM, Matthew Garrett mj...@srcf.ucam.org wrote: I feel like I'm missing something here. Where's the firmware getting its initial value from? My understanding is that normally, the firmware's VBIOS can program the value of the PWM register. But if the firmware

Re: [Intel-gfx] [PATCH v3 2/2] drivers: i915: Default max backlight brightness value

2011-11-08 Thread Simon Que
On Tue, Nov 8, 2011 at 2:10 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Tue, Nov 08, 2011 at 02:05:14PM -0800, Simon Que wrote: On Tue, Nov 8, 2011 at 1:42 PM, Matthew Garrett mj...@srcf.ucam.org wrote: I feel like I'm missing something here. Where's the firmware getting its

Re: [Intel-gfx] [PATCH v3 2/2] drivers: i915: Default max backlight brightness value

2011-11-08 Thread Simon Que
On Tue, Nov 8, 2011 at 2:28 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Tue, Nov 08, 2011 at 02:27:04PM -0800, Simon Que wrote: This is for an x86-based Chromebook. Its firmware doesn't have the VBIOS support. Previously, we had our own backlight driver that also did a similar

Re: [Intel-gfx] [PATCH v2] drivers: i915: Default max backlight brightness value

2011-11-02 Thread Simon Que
On Tue, Nov 1, 2011 at 7:54 PM, Matthew Garrett mj...@srcf.ucam.org wrote: Again, adding arbitrary constants without any explanation for why you're making this the default really isn't acceptable. We have no way to determine whether fixing one machine is worth making things worse for another.

[Intel-gfx] drivers: i915: Default max backlight brightness value

2011-11-01 Thread Simon Que
Use 0x1000 as the default backlight PWM max value and period. This is passed in as a module parameter to i915_drv and is used to program the PWM registers. It can be set to other values based on the needs of each system. Signed-off-by: Simon Que s...@chromium.org --- drivers/gpu/drm/i915

Re: [Intel-gfx] drivers: i915: Default max backlight brightness value

2011-11-01 Thread Simon Que
Sorry, this is the wrong patch, please disregard. On Tue, Nov 1, 2011 at 6:58 PM, Simon Que s...@chromium.org wrote: Use 0x1000 as the default backlight PWM max value and period. This is passed in as a module parameter to i915_drv and is used to program the PWM registers. It can be set

[Intel-gfx] [PATCH v2] drivers: i915: Default max backlight brightness value

2011-11-01 Thread Simon Que
Use 0x1000 as the default backlight PWM max value and period. This is passed in as a module parameter to i915_drv and is used to program the PWM registers. It can be set to other values based on the needs of each system. Signed-off-by: Simon Que s...@chromium.org --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drivers: i915: Default max backlight brightness value

2011-10-31 Thread Simon Que
On Fri, Oct 14, 2011 at 4:46 PM, Simon Que s...@chromium.org wrote: In the native backlight driver, use 4096 (0x1000) as the default backlight period, and use the period as the default max brightness. The default brightness is defined in a separate function that can be expanded to allow

Re: [Intel-gfx] [PATCH] drivers: i915: Default max backlight brightness value

2011-10-25 Thread Simon Que
Hi, could I get some feedback on this patch, please? Simon On Fri, Oct 14, 2011 at 4:46 PM, Simon Que s...@chromium.org wrote: In the native backlight driver, use 4096 (0x1000) as the default backlight period, and use the period as the default max brightness. The default brightness

[Intel-gfx] [PATCH] drivers: i915: Default max backlight brightness value

2011-10-14 Thread Simon Que
: Ie783b53dd034dcd7bf42e24ffc911cf2f10a5676 Signed-off-by: Simon Que s...@chromium.org --- drivers/gpu/drm/i915/i915_reg.h|1 + drivers/gpu/drm/i915/intel_panel.c | 22 ++ 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers

Re: [Intel-gfx] [PATCH] CHROMIUM: i915: Select non-alternate SSC frequency for some systems

2011-10-06 Thread Simon Que
Do you expect to have other settings that you won't get from a VBIOS VBT (e.g. video timings, dual refresh info)? If so, it might make more sense to have an alternate init path for the non-VBT values to replace all the VBT parsing.  I.e. if your DMI match happens, call into something other

[Intel-gfx] [PATCH] CHROMIUM: i915: Select non-alternate SSC frequency for some systems

2011-10-05 Thread Simon Que
for systems that are to use the non-alternate frequency. Currently, only Lumpy is on the list. Signed-off-by: Simon Que s...@chromium.org --- drivers/gpu/drm/i915/intel_bios.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3] CHROMIUM: i915: Added function to initialize VBT settings

2010-09-28 Thread Simon Que
devices will want dithering enabled. Signed-off-by: Simon Que s...@chromium.org BUG=none TEST=Splash screen looks dithered upon boot. Change-Id: If19c763824ee938ad107f655d8d94c65e39cfa56 --- drivers/gpu/drm/i915/intel_bios.c | 29 +++-- 1 files changed, 19 insertions

[Intel-gfx] [PATCH v2] CHROMIUM: i915: Added default LVDS options for the no-VBT case

2010-09-27 Thread Simon Que
for the no-VBT case Added a function that sets the LVDS values to default settings (currently only dither bit) when there is no VBT (video BIOS table) found. Also updated dither bit in parse function to be set by default. Signed-off-by: Simon Que s...@chromium.org BUG=none TEST=Splash screen looks