[PATCH 2/2] drm/i915/psr: Implment WA to help reach PC10

2024-06-06 Thread Suraj Kandpal
led and VBI is disabled and flips and pushes are not happening. WA: 16023497226 Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_psr.c | 75 +++- 1 file changed, 73 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/

[PATCH 0/2] Implement WA to fix increased power usage

2024-06-06 Thread Suraj Kandpal
When DPKGC is enabled we see an increase in power consumption for PSR1: When gap between vblank and delayed vblank is >= 6 PSR2: When deep sleep is enabled. WA adds condition to avoid the above conditions WA: 16023497226 Signed-off-by: Suraj Kandpal Suraj Kandpal (2): drm/i915/psr: Add ret

[PATCH 1/2] drm/i915/psr: Add return bool value for hsw_activate_psr1

2024-06-06 Thread Suraj Kandpal
Convert hsw_activate_psr1 from void to bool as going forward there is a chance psr1 is not enabled. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_psr.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b

[PATCH] drm/i915/hdcp: Fix IS_METEORLAKE usage for HDCP line rekeying

2024-05-26 Thread Suraj Kandpal
Replace IS_METEORLAKE usage with a more appropriate macro. While we are at it also add the stepping restrictions for other platforms. Fixes: 6a3691ca4799 ("drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI") Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/in

[PATCH 2/2] drm/i915/hdcp: Check mst_port to determine connector type

2024-05-21 Thread Suraj Kandpal
Check mst_port field in intel_connector to check connector type rather than rely on encoder as it may not be attached to connector at times. --v2 -Add closes tag [Imre] Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10898 Signed-off-by: Suraj Kandpal Reviewed-by: Imre Deak

[PATCH 1/2] drm/i915/hdcp: Move aux assignment after connector type check

2024-05-21 Thread Suraj Kandpal
Move assignment of aux after connector type check as port may not exist if connector is not DPMST. --v2 -Fix unwanted change in intel_encoder check [Jani] Signed-off-by: Suraj Kandpal Reviewed-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- 1 file changed, 2 insertions

[PATCH 0/2] Fixes in hdcp remote capability

2024-05-21 Thread Suraj Kandpal
This patch series aims to avoid page fault errors caused by aux early assignment as connector may not be mst and using encoder to check for connector type. Signed-off-by: Suraj Kandpal Suraj Kandpal (2): drm/i915/hdcp: Move aux assignment after connector type check drm/i915/hdcp: Check

[PATCH 2/2] drm/i915/hdcp: Check mst_port to determine connector type

2024-05-19 Thread Suraj Kandpal
Check mst_port field in intel_connector to check connector type rather than rely on encoder as it may not be attached to connector at times. --v2 -Add closes tag [Imre] Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10898 Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915

[PATCH] drm/i915/pps: Disable DPLS_GATING around pps sequence

2024-05-08 Thread Suraj Kandpal
Disable bit 29 of SCLKGATE_DIS register around pps sequence when we turn panel power on. --v2 -Squash two commit together [Jani] -Use IS_DISPLAY_VER [Jani] -Fix multiline comment [Jani] --v3 -Define register in a more appropriate place [Mitul] Bspec: 49304 Signed-off-by: Suraj Kandpal

[PATCH] drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI

2024-05-07 Thread Suraj Kandpal
Bspec: 69964 Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 23 +++ drivers/gpu/drm/i915/i915_reg.h | 2 ++ 2 files changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_

[PATCH 7/7] drm/i915/dp: Write panel override luminance values

2024-05-06 Thread Suraj Kandpal
Write panel override luminance values which helps the TCON decide if tone mapping needs to be enabled or not. Signed-off-by: Suraj Kandpal Reviewed-by: Sebastian Wick --- .../drm/i915/display/intel_dp_aux_backlight.c | 25 +++ 1 file changed, 25 insertions(+) diff --git

[PATCH 6/7] drm/i915/dp: Enable AUX based backlight for HDR

2024-05-06 Thread Suraj Kandpal
[Sebastian] Signed-off-by: Suraj Kandpal Reviewed-by: Sebastian Wick --- .../drm/i915/display/intel_dp_aux_backlight.c | 98 --- 1 file changed, 87 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display

[PATCH 2/7] drm/i915/dp: Rename intel struct inside intel_panel

2024-05-06 Thread Suraj Kandpal
Rename intel to intel cap which is present inside panel.edp struct to make it more sensible to tell us what it contains. Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_display_types.h | 2 +- .../gpu/drm/i915/display/intel_dp_aux_backlight.c

[PATCH 5/7] drm/i915/dp: Drop comments on EDP HDR DPCD registers

2024-05-06 Thread Suraj Kandpal
Drop comments for EDP HDR DPCD registers as the code and conditions will tell us what can be written where. --v2 -Drop the comments altogether instead of just renaming them [Sebastian] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display

[PATCH 4/7] drm/i915/dp: Fix Register bit naming

2024-05-06 Thread Suraj Kandpal
Change INTEL_EDP_HDR_TCON_SDP_COLORIMETRY enable to INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX as this bit tells TCON to ignore DPCD colorimetry values and take the one's sent through SDP. --v2 -Fix typo in commit message [Arun] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu

[PATCH 3/7] drm/i915/dp: Add TCON HDR capability checks

2024-05-06 Thread Suraj Kandpal
Add checks to see the HDR capability of TCON panel. Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_display_types.h| 5 + drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++ 2 files changed, 15 insertions(+) diff --git

[PATCH 0/7] Enable Aux Based EDP HDR

2024-05-06 Thread Suraj Kandpal
This series enables Aux based EDP HDR and backlight controls. The DPCD written to are intel proprietary and are filled based on the specs that were provided to TCON vendors. Signed-off-by: Suraj Kandpal Suraj Kandpal (7): drm/i915/dp: Make has_gamut_metadata_dip() non static drm/i915/dp

[PATCH 1/7] drm/i915/dp: Make has_gamut_metadata_dip() non static

2024-05-06 Thread Suraj Kandpal
-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index

[PATCH 0/2] Fixes in hdcp remote capability

2024-05-06 Thread Suraj Kandpal
This patch series aims to avoid page fault errors caused by aux early assignment as connector may not be mst and using encoder to check for connector type. Signed-off-by: Suraj Kandpal Suraj Kandpal (2): drm/i915/hdcp: Move aux assignment after connector type check drm/i915/hdcp: Check

[PATCH 2/2] drm/i915/hdcp: Check mst_port to determine connector type

2024-05-06 Thread Suraj Kandpal
Check mst_port field in intel_connector to check connector type rather than rely on encoder as it may not be attached to connector at times. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/2] drm/i915/hdcp: Move aux assignment after connector type check

2024-05-06 Thread Suraj Kandpal
Move assignment of aux after connector type check as port may not exist if connector is not DPMST. --v2 -Fix unwanted change in intel_encoder check [Jani] Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH] drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI

2024-05-01 Thread Suraj Kandpal
--v4 -Add comment regarding need of this WA when in TMDS mode [Chaitanya] -Write in chicken register for MTL [CHaitanya] --v5 -Fix comment [Chaitanya] -Use correct set and clear value in intel_de_rmw [Chaitanya] Bspec: 49273 Bspec: 69964 Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/d

[PATCH 2/2] drm/i915/hdcp: Check mst_port to determine connector type

2024-04-30 Thread Suraj Kandpal
Check mst_port field in intel_connector to check connector type rather than rely on encoder as it may not be attached to connector at times. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/2] drm/i915/hdcp: Move aux assignment after connector type check

2024-04-30 Thread Suraj Kandpal
Move assignment of aux after connector type check as port may not exist if connector is not DPMST. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c

[PATCH 0/2] Fixes in hdcp remote capability

2024-04-30 Thread Suraj Kandpal
This patch series aims to avoid page fault errors caused by aux early assignment as connector may not be mst and using encoder to check for connector type. Signed-off-by: Suraj Kandpal Suraj Kandpal (2): drm/i915/hdcp: Move aux assignment after connector type check drm/i915/hdcp: Check

[RFC 3/3] drm/i915: Schedule darkscreen detection work

2024-04-24 Thread Suraj Kandpal
Schedule darkscreen detection work whenever we hit FIFO underrun. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c b/drivers/gpu/drm/i915/display

[RFC 2/3] drm/i915/darkscreen: Enable darkscreen detection

2024-04-24 Thread Suraj Kandpal
Add functions to enable darkscreen detection and corresponding additions to Makefile to build them. The enable and detect functions will be used in case we encounter a FIFO underrun which will help to check if a darkscreen occurred. Signed-off-by: Suraj Kandpal Signed-off-by: Nemesa Garg

[RFC 1/3] drm/i915: Add Dark screen detection registers

2024-04-24 Thread Suraj Kandpal
Add Dark screen detection related register and field definitions. Signed-off-by: Suraj Kandpal Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/i915_reg.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index

[RFC 0/3] Enable darkscreen detection

2024-04-24 Thread Suraj Kandpal
-by: Suraj Kandpal Suraj Kandpal (3): drm/i915: Add Dark screen detection registers drm/i915/darkscreen: Enable darkscreen detection drm/i915: Schedule darkscreen detection work drivers/gpu/drm/i915/Makefile | 1 + .../gpu/drm/i915/display/intel_darkscreen.c | 139

[PATCH] drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI

2024-04-23 Thread Suraj Kandpal
--v4 -Add comment regarding need of this WA when in TMDS mode [Chaitanya] -Write in chicken register for MTL [CHaitanya] Bspec: 49273 Bspec: 69964 Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 26 +++ drivers/gpu/drm/i915/i915_reg.h

[PATCH 6/6] drm/i915/dp: Write panel override luminance values

2024-04-21 Thread Suraj Kandpal
Write panel override luminance values which helps the TCON decide if tone mapping needs to be enabled or not. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 25 +++ 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[PATCH 4/6] drm/i915/dp: Drop comments on EDP HDR DPCD registers

2024-04-21 Thread Suraj Kandpal
Drop comments for EDP HDR DPCD registers as the code and conditions will tell us what can be written where. --v2 -Drop the comments altogether instead of just renaming them [Sebastian] Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 ++-- 1 file

[PATCH 5/6] drm/i915/dp: Enable AUX based backlight for HDR

2024-04-21 Thread Suraj Kandpal
[Sebastian] Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 98 --- 1 file changed, 87 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c index

[PATCH 1/6] drm/i915/dp: Make has_gamut_metadata_dip() non static

2024-04-21 Thread Suraj Kandpal
-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index

[PATCH 2/6] drm/i915/dp: Add TCON HDR capability checks

2024-04-21 Thread Suraj Kandpal
Add checks to see the HDR capability of TCON panel. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display_types.h| 5 + drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++ 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i915

[PATCH 3/6] drm/i915/dp: Fix Register bit naming

2024-04-21 Thread Suraj Kandpal
Change INTEL_EDP_HDR_TCON_SDP_COLORIMETRY enable to INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX as this bit is tells TCON to ignore DPCD colorimetry values and take the one's sent through SDP. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +- 1 file changed

[PATCH 0/6] Enable Aux Based EDP HDR

2024-04-21 Thread Suraj Kandpal
This series enables Aux based EDP HDR and backlight controls. The DPCD written to are intel proprietary and are filled based on the specs that were provided to TCON vendors. Signed-off-by: Suraj Kandpal Suraj Kandpal (6): drm/i915/dp: Make has_gamut_metadata_dip() non static drm/i915/dp

[PATCH] drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI

2024-04-17 Thread Suraj Kandpal
[Jani] Bspec: 49273 Bspec: 69964 Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 17 + drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 18 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/d

[PATCH] drm/i915/pps: Disable DPLS_GATING around pps sequence

2024-04-16 Thread Suraj Kandpal
Disable bit 29 of SCLKGATE_DIS register around pps sequence when we turn panel power on. --v2 -Squash two commit together [Jani] -Use IS_DISPLAY_VER [Jani] -Fix multiline comment [Jani] Bspec: 49304 Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_pps.c | 12

[PATCH] drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI

2024-04-16 Thread Suraj Kandpal
Disable HDCP Line Rekeying when HDCP ver > 1.4 and when we are on HDMI TMDS operation for DISPLAY_VER >= 14. --v2 -Wa to be mentioned in comments not in commit message [Jani] -Remove blankline [Jani] Bspec: 49273 Bspec: 69964 Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/d

[PATCH 0/2] Disable DPLS Gating around PPS

2024-04-16 Thread Suraj Kandpal
Disable DPLS Gating around Panel Power on Sequence. WA:16023567976 Signed-off-by: Suraj Kandpal Suraj Kandpal (2): drm/i915: Add SCLKGATE_DIS register definition drm/i915/pps: Disable DPLS_GATING around pps sequence drivers/gpu/drm/i915/display/intel_pps.c | 12 drivers/gpu

[PATCH 2/2] drm/i915/pps: Disable DPLS_GATING around pps sequence

2024-04-16 Thread Suraj Kandpal
Disable bit 29 of SCLKGATE_DIS register around pps sequence when we turn panel power on. WA: 16023567976 Bspec: 49304 Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_pps.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[PATCH 1/2] drm/i915: Add SCLKGATE_DIS register definition

2024-04-16 Thread Suraj Kandpal
Add SCLKGATE_DIS register and it's register definition which will be used the next patch. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/i915_reg.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 3f34efcd7d6c

[PATCH] drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI

2024-04-15 Thread Suraj Kandpal
Disable HDCP Line Rekeying when HDCP ver > 1.4 and when we are on HDMI TMDS operation for DISPLAY_VEY >= 14. WA: 16022217614 Bspec: 49273 Bspec: 69964 Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 16 drivers/gpu/drm/i915/i915_reg.h

[PATCH 6/6] drm/i915/dp: Write panel override luminance values

2024-04-11 Thread Suraj Kandpal
Write panel override luminance values which helps the TCON decide if tone mapping needs to be enabled or not. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 25 +++ 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[PATCH 5/6] drm/i915/dp: Enable AUX based backlight for HDR

2024-04-11 Thread Suraj Kandpal
for hdr mode check [Jani] -Fix the condition which tells us if we are in HDR mode or not [Sebastian] Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 105 -- 1 file changed, 94 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/display

[PATCH 3/6] drm/i915/dp: Fix Register bit naming

2024-04-11 Thread Suraj Kandpal
Change INTEL_EDP_HDR_TCON_SDP_COLORIMETRY enable to INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX as this bit is tells TCON to ignore DPCD colorimetry values and take the one's sent through SDP. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +- 1 file changed

[PATCH 4/6] drm/i915/dp: Drop comments on EDP HDR DPCD registers

2024-04-11 Thread Suraj Kandpal
Drop comments for EDP HDR DPCD registers as the code and conditions will tell us what can be written where. --v2 -Drop the comments altogether instead of just renaming them [Sebastian] Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 ++-- 1 file

[PATCH 1/6] drm/i915/dp: Make has_gamut_metadata_dip() non static

2024-04-11 Thread Suraj Kandpal
Make has_gamut_metadata_dip() non static so it can also be used to at other places eg in intel_dp_aux_backlight. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2 files changed, 4 insertions(+), 3 deletions

[PATCH 2/6] drm/i915/dp: Add TCON HDR capability checks

2024-04-11 Thread Suraj Kandpal
Add checks to see the HDR capability of TCON panel. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display_types.h| 5 + drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++ 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i915

[PATCH 0/6] Enable Aux Based EDP HDR

2024-04-11 Thread Suraj Kandpal
This series enables Aux based EDP HDR and backlight controls. The DPCD written to are intel proprietary and are filled based on the specs that were provided to TCON vendors. Signed-off-by: Suraj Kandpal Suraj Kandpal (6): drm/i915/dp: Make has_gamut_metadata_dip() non static drm/i915/dp

[PATCH 7/7] drm/i915/dp: Limit brightness level to vbt min brightness

2024-04-05 Thread Suraj Kandpal
brightness that PWM method uses [Jani] Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display

[PATCH 7/7] drm/i915/dp: Limit brightness level to 20

2024-04-03 Thread Suraj Kandpal
Limit minimum brightness to 20 when using aux based brightness control to avoid letting the screen going completely blank. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[PATCH 6/7] drm/i915/dp: Write panel override luminance values

2024-04-03 Thread Suraj Kandpal
Write panel override luminance values which helps the TCON decide if tone mapping needs to be enabled or not. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 25 +++ 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[PATCH 5/7] drm/i915/dp: Enable AUX based backlight for HDR

2024-04-03 Thread Suraj Kandpal
bits. -Check colorspace before setting BT2020 --v6 -Use intel_dp_has_gamut_dip to check if we have capability to send sdp [Ville] -Seprate filling of all hdr tcon related bits into it's own function. -Check eotf data to make sure we are in HDR mode [Sebastian] Signed-off-by: Suraj Kandpal

[PATCH 4/7] drm/i915/dp: Fix comments on EDP HDR DPCD registers

2024-04-03 Thread Suraj Kandpal
Change comments from Pre-TGL+ to Pre-ICL as mentioned in specs Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm

[PATCH 3/7] drm/i915/dp: Fix Register bit naming

2024-04-03 Thread Suraj Kandpal
Change INTEL_EDP_HDR_TCON_SDP_COLORIMETRY enable to INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX as this bit is tells TCON to ignore DPCD colorimetry values and take the one's sent through SDP. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +- 1 file changed

[PATCH 2/7] drm/i915/dp: Add TCON HDR capability checks

2024-04-03 Thread Suraj Kandpal
Add checks to see the HDR capability of TCON panel. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display_types.h| 5 + drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++ 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i915

[PATCH 1/7] drm/i915/dp: Make has_gamut_metadata_dip() non static

2024-04-03 Thread Suraj Kandpal
Make has_gamut_metadata_dip() non static so it can also be used to at other places eg in intel_dp_aux_backlight. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2 files changed, 4 insertions(+), 3 deletions

[PATCH 0/7] Enable Aux Based EDP HDR

2024-04-03 Thread Suraj Kandpal
This series enables Aux based EDP HDR and backlight controls. The DPCD written to are intel proprietary and are filled based on the specs that were provided to TCON vendors. Signed-off-by: Suraj Kandpal Suraj Kandpal (7): drm/i915/dp: Make has_gamut_metadata_dip() non static drm/i915/dp

[PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function

2024-03-31 Thread Suraj Kandpal
HDCP 1.x capability needs to be checked even if setup is not HDCP 2.x capable. --v2 -Assign hdcp_capable and hdcp2_capable to false [Chaitanya] --v3 -Fix variable assignment [Chaitanya] Fixes: 813cca96e4ac ("drm/i915/hdcp: Add new remote capability check shim function") Signed-off

[PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function

2024-03-31 Thread Suraj Kandpal
HDCP 1.x capability needs to be checked even if setup is not HDCP 2.x capable. --v2 -Assign hdcp_capable and hdcp2_capable to false [Chaitanya] Fixes: 813cca96e4ac ("drm/i915/hdcp: Add new remote capability check shim function") Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i9

[PATCH 1/2] drm/i915/display: Initialize capability variables

2024-03-31 Thread Suraj Kandpal
Initialize HDCP capability variables to false to avoid UBSAN warning in boolean value as some functions invoking this could return without filling the two capability values. --v2 -Fix Typo [Chaitanya] Signed-off-by: Suraj Kandpal Reviewed-by: Chaitanya Kumar Borah --- drivers/gpu/drm/i915

[PATCH 0/2] Fix UBSAN warning in hdcp_info

2024-03-31 Thread Suraj Kandpal
This patch series fixes the UBSAN warning which gets called when hdcp_info is invoked accompanied by some other logical fixes required in the hdcp capability function. Signed-off-by: Suraj Kandpal Suraj Kandpal (2): drm/i915/display: Initialize capability variables drm/i915/hdcp: Fix get

[PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function

2024-03-26 Thread Suraj Kandpal
HDCP 1.x capability needs to be checked even if setup is not HDCP 2.x capable. Fixes: 813cca96e4ac ("drm/i915/hdcp: Add new remote capability check shim function") Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 9 - 1 file changed, 4 insert

[PATCH 1/2] drm/i915/display: Initialize capability variables

2024-03-26 Thread Suraj Kandpal
Initialize HDCP capability variables to false to avoid UBSAN warning in boolean value. --v2 -Fix Typo [Chaitanya] Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915

[PATCH 0/2] Fix UBSAN warning in hdcp_info

2024-03-26 Thread Suraj Kandpal
This patch series fixes the UBSAN warning which gets called when hdcp_info is invoked accompanied by some other logical fixes required in the hdcp capability function. Signed-off-by: Suraj Kandpal Suraj Kandpal (2): drm/i915/display: Initialize capability variables drm/i915/hdcp: Fix get

[PATCH] drm/i915/display: Initalizalize capability variables

2024-03-25 Thread Suraj Kandpal
Initialize HDCP capability variables to false to avoid UBSAN warning in boolean value. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c

[PATCH] drm/i915/dp: Enable AUX based backlight for HDR

2024-03-14 Thread Suraj Kandpal
bits. -Check colorspace before setting BT2020 Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_display_types.h| 3 + .../drm/i915/display/intel_dp_aux_backlight.c | 57 --- 2 files changed, 52 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display

[PATCH] drm/i915/dp: Enable AUX based backlight for HDR

2024-03-10 Thread Suraj Kandpal
the size sent in drm_dpcd_write [Jani] --v3 -Content Luminance needs to be sent only for pre-ICL after that it is directly picked up from hdr metadata [Ville] --v4 -Add checks for HDR TCON cap bits [Ville] -Check eotf of hdr_output_data and sets bits base of that value. Signed-off-by: Suraj

[PATCH] drm/i915/dp: Enable AUX based backlight for HDR

2024-03-07 Thread Suraj Kandpal
the size sent in drm_dpcd_write [Jani] --v3 -Content Luminance needs to be sent only for pre-ICL after that it is directly picked up from hdr metadata [Ville] Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 33 ++- 1 file changed, 25 insertions

[PATCH] drm/i915/dp: Enable AUX based backlight for HDR

2024-03-06 Thread Suraj Kandpal
the size sent in drm_dpcd_write [Jani] Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 30 ++- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display

[PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file

2024-03-05 Thread Suraj Kandpal
Move intel_hdcp_gsc_message definition into intel_hdcp_gsc.c so that intel_hdcp_gsc_message can be redefined for xe as needed. --v2 -Correct commit message to reflect what patch is actually doing [Arun] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy Acked-by: Jani Nikula --- drivers

[PATCH 2/4] drm/xe/hdcp: Use xe_device struct

2024-03-05 Thread Suraj Kandpal
Use xe_device struct instead of drm_i915_private so as to not cause confusion and comply with Xe standards as drm_i915_private is xe_device under the hood. --v2 -Fix commit message [Daniele] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/xe/display/xe_hdcp_gsc.c

[PATCH 4/4] drm/xe/hdcp: Enable HDCP for XE

2024-03-05 Thread Suraj Kandpal
-Squash commits for buildability --v6 -Order includes alphabetically [Lucas] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 202 ++- drivers/gpu/drm/xe/xe_gsc_submit.c

[PATCH 3/4] drm/xe: Use gsc_proxy_init_done to check proxy status

2024-03-05 Thread Suraj Kandpal
Expose gsc_proxy_init_done so that we can check if gsc proxy has been initialized or not. --v2 -Check if GSC FW is enabled before taking forcewake ref [Daniele] --v3 -Directly call proxy check function inside if condition Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy Reviewed

[PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file

2024-03-05 Thread Suraj Kandpal
Move intel_hdcp_gsc_message definition into intel_hdcp_gsc.c so that intel_hdcp_gsc_message can be redefined for xe as needed. --v2 -Correct commit message to reflect what patch is actually doing [Arun] Signed-off-by: Suraj Kandpal Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display

[PATCH 0/4] XE HDCP Enablement

2024-03-05 Thread Suraj Kandpal
This patch series enables HDCP on XE. Mainly includes rewriting functions that were responsible for sending hdcp messages via gsc cs. Signed-off-by: Suraj Kandpal Acked-by: Lucas De Marchi Suraj Kandpal (4): drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file drm/xe/hdcp

[PATCH] drm/i915/dp: Enable AUX based backlight for HDR

2024-03-05 Thread Suraj Kandpal
As of now whenerver HDR is switched on we use the PWM to change the backlight as opposed to AUX based backlight changes in terms of nits. This patch writes to the appropriate DPCD registers to enable aux based backlight using values in nits. Signed-off-by: Suraj Kandpal --- .../drm/i915/display

[PATCH 3/4] drm/xe: Use gsc_proxy_init_done to check proxy status

2024-02-27 Thread Suraj Kandpal
Expose gsc_proxy_init_done so that we can check if gsc proxy has been initialized or not. --v2 -Check if GSC FW is enabled before taking forcewake ref [Daniele] --v3 -Directly call forcewake get function inside if condition Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy Reviewed

[PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file

2024-02-26 Thread Suraj Kandpal
Move intel_hdcp_gsc_message definition into intel_hdcp_gsc.c so that intel_hdcp_gsc_message can be redefined for xe as needed. --v2 -Correct commit message to reflect what patch is actually doing [Arun] Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 6

[PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file

2024-02-26 Thread Suraj Kandpal
Move intel_hdcp_gsc_message definition into intel_hdcp_gsc.h so that intel_hdcp_gsc_message can be redefined for xe as needed. --v2 -Correct commit message to reflect what patch is actually doing [Arun] Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 6

[PATCH 4/4] drm/xe/hdcp: Enable HDCP for XE

2024-02-26 Thread Suraj Kandpal
-Squash commits for buildability Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 198 ++- drivers/gpu/drm/xe/xe_gsc_submit.c | 15 ++ drivers/gpu/drm/xe

[PATCH 2/4] drm/xe/hdcp: Use xe_device struct

2024-02-26 Thread Suraj Kandpal
Use xe_device struct instead of drm_i915_private so as to not cause confusion and comply with Xe standards as drm_i915_private is xe_device under the hood. --v2 -Fix commit message [Daniele] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/xe/display/xe_hdcp_gsc.c

[PATCH 3/4] drm/xe: Use gsc_proxy_init_done to check proxy status

2024-02-26 Thread Suraj Kandpal
Expose gsc_proxy_init_done so that we can check if gsc proxy has been initialized or not. --v2 -Check if GSC FW is enabled before taking forcewake ref [Daniele] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/xe/display

[PATCH 0/4] XE HDCP Enablement

2024-02-26 Thread Suraj Kandpal
This patch series enables HDCP on XE. Mainly includes rewriting functions that were responsible for sending hdcp messages via gsc cs. Signed-off-by: Suraj Kandpal Suraj Kandpal (4): drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file drm/xe/hdcp: Use xe_device struct drm

[PATCH 5/5] drm/i915/hdcp: Read Rxcaps for robustibility

2024-02-25 Thread Suraj Kandpal
We see some monitors and docks report incorrect hdcp version and capability in first few reads so we read rx_caps three times before we conclude the monitor's or docks HDCP capability --v2 -Add comment to justify the 3 time read loop for hdcp capability[Ankit] Signed-off-by: Suraj Kandpal

[PATCH 3/5] drm/i915/hdcp: Don't enable HDCP1.4 directly from check_link

2024-02-25 Thread Suraj Kandpal
enablement. Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index 1023153ba9d4

[PATCH 4/5] drm/i915/hdcp: Allocate stream id after HDCP AKE stage

2024-02-25 Thread Suraj Kandpal
required_content_stream function [Ankit] Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 137 ++ 1 file changed, 65 insertions(+), 72 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm

[PATCH 2/5] drm/i915/hdcp: Don't enable HDCP2.2 directly from check_link

2024-02-25 Thread Suraj Kandpal
enablement. --v2 -Don't change the function prototype in this function [Ankit] Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 25 ++- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH 1/5] drm/i915/hdcp: Extract hdcp structure from correct connector

2024-02-25 Thread Suraj Kandpal
Currently intel_hdcp is not being extracted from primary connector this patch fixes that. Fixes: 524240b231ea ("drm/i915/hdcp: Propagate aux info in DP HDCP functions") Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 7 +

[PATCH 0/5] HDCP MST Type1 fixes

2024-02-25 Thread Suraj Kandpal
, derive hdcp structure correctly and increase robustability if rxcaps HDCP capability reporting. Rebased on latest commits. Signed-off-by: Suraj Kandpal Suraj Kandpal (5): drm/i915/hdcp: Extract hdcp structure from correct connector drm/i915/hdcp: Don't enable HDCP2.2 directly from check_link

[PATCH 06/13] drm/i915/hdcp: Add new remote capability check shim function

2024-02-25 Thread Suraj Kandpal
hdcp2_prerequisite check condition -Move intel_dp_hdcp_get_remote_capability to dp_mst shim instead of having it in dp shim [Ankit] Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_display_types.h| 4 +++ drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 27 +++ drivers/gpu

[PATCH 12/13] drm/i915/hdcp: Allocate stream id after HDCP AKE stage

2024-02-23 Thread Suraj Kandpal
required_content_stream function [Ankit] Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 137 ++ 1 file changed, 65 insertions(+), 72 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm

[PATCH 07/13] drm/i915/hdcp: HDCP Capability for the downstream device

2024-02-23 Thread Suraj Kandpal
] --v5 -No need to have the MST Hub version in i915_hdcp_sink_capability[Ankit] Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- .../drm/i915/display/intel_display_debugfs.c | 21 ++- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH 11/13] drm/i915/hdcp: Don't enable HDCP1.4 directly from check_link

2024-02-23 Thread Suraj Kandpal
enablement. Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index 1023153ba9d4

[PATCH 13/13] drm/i915/hdcp: Read Rxcaps for robustibility

2024-02-23 Thread Suraj Kandpal
We see some monitors and docks report incorrect hdcp version and capability in first few reads so we read rx_caps three times before we conclude the monitor's or docks HDCP capability --v2 -Add comment to justify the 3 time read loop for hdcp capability[Ankit] Signed-off-by: Suraj Kandpal

[PATCH 09/13] drm/i915/hdcp: Extract hdcp structure from correct connector

2024-02-23 Thread Suraj Kandpal
Currently intel_hdcp is not being extracted from primary connector this patch fixes that. Fixes: 524240b231ea ("drm/i915/hdcp: Propagate aux info in DP HDCP functions") Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 7 +

[PATCH 10/13] drm/i915/hdcp: Don't enable HDCP2.2 directly from check_link

2024-02-23 Thread Suraj Kandpal
enablement. --v2 -Don't change the function prototype in this function [Ankit] Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 25 ++- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH 08/13] drm/i915/hdcp: Remove additional timing for reading mst hdcp message

2024-02-23 Thread Suraj Kandpal
Now that we have moved back to direct reads the additional timing is not required hence this can be removed. --v2 -Add Fixes tag [Ankit] Fixes: 3974f9c17bb9 ("drm/i915/hdcp: Adjust timeout for read in DPMST Scenario") Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- d

  1   2   3   4   5   6   7   8   >