Re: [Intel-gfx] Possible i915 regression with 4.4-rc

gt; > > > On Thu, Dec 03, 2015 at 09:00:55PM +0100, Takashi Iwai wrote: > > > >> Hi, > > > >> > > > >> I've experienced a few graphics issues recently, and I tend to believe > > > >> that it has happened since 4.4-rc. Namely,

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Add get_eld audio component

On Fri, 04 Dec 2015 17:15:59 +0100, Daniel Vetter wrote: > > On Fri, Dec 04, 2015 at 05:03:55PM +0100, Takashi Iwai wrote: > > On Fri, 04 Dec 2015 16:54:32 +0100, > > Daniel Vetter wrote: > > > > > > On Fri, Dec 04, 2015 at 04:15:24PM +0100, Takashi Iwai wro

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Add get_eld audio component

On Fri, 04 Dec 2015 17:49:43 +0100, Daniel Vetter wrote: > > On Fri, Dec 04, 2015 at 05:27:12PM +0100, Takashi Iwai wrote: > > On Fri, 04 Dec 2015 17:20:15 +0100, > > Takashi Iwai wrote: > > > > > > On Fri, 04 Dec 2015 17:15:59 +0100, > > > Daniel

Re: [Intel-gfx] [PATCH v2 8/9] ALSA: hda - Skip ELD notification during PM process

On Tue, 01 Dec 2015 17:09:57 +0100, Takashi Iwai wrote: > > The ELD notification can be received asynchronously from the graphics > side, and this may happen just at the moment the sound driver is > processing the suspend or the resume, and it would confuse the whole > procedure.

[Intel-gfx] Possible i915 regression with 4.4-rc

Hi, I've experienced a few graphics issues recently, and I tend to believe that it has happened since 4.4-rc. Namely, after some long time usage on my HSW laptop (two or three days), the mouse cursor vanished suddenly. It kept pointing but just became invisible. Also, after some S3 cycles,

Re: [Intel-gfx] Possible i915 regression with 4.4-rc

On Thu, 03 Dec 2015 21:33:29 +0100, Ville Syrjälä wrote: > > On Thu, Dec 03, 2015 at 09:00:55PM +0100, Takashi Iwai wrote: > > Hi, > > > > I've experienced a few graphics issues recently, and I tend to believe > > that it has happened since 4.4-rc. Namely, after

[Intel-gfx] [PATCH v2 5/9] ALSA: hda - Split ELD update code from hdmi_present_sense()

This is a preliminary patch for the later change to support ELD/jack handling with i915 audio component. This splits the ELD update code from hdmi_present_sense() so that it can be called from other places. Just a code refactoring, no functional change. Signed-off-by: Takashi Iwai <

[Intel-gfx] [PATCH v2 4/9] drm/i915: Add reverse mapping between port and intel_encoder

This patch adds a reverse mapping from a digital port number to intel_encoder object containing the corresponding intel_digital_port. It simplifies the query of the encoder a lot. Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/gpu/drm/i915/i915_drv.h| 2 ++ drivers/gpu/dr

[Intel-gfx] [PATCH v2 6/9] ALSA: hda - Use component ops for i915 HDMI/DP audio jack handling

(with the direct access to the graphics driver, we need really no repoll, in anyway). Signed-off-by: Takashi Iwai <ti...@suse.de> --- v1->v2: * Deferred invocation of get_eld from the eld_notify in HDA side * A bit more code refactoring sound/pci/hda/patch_hdm

[Intel-gfx] [PATCH v2 0/9] Add get_eld audio component for i915/HD-audio

rom a port number to the encoder * Deferred invocation of get_eld from the eld_notify in HDA side * A bit more code refactoring in HDA side * Move audio component accessors to hdac_i915.c Takashi Iwai (9): drm/i915: Remove superfluous NULL check drm/i915: Add get_eld audio component drm/i

[Intel-gfx] [PATCH v2 2/9] drm/i915: Add get_eld audio component

this implementation, a new field audio_enabled is added to struct intel_digital_port. This is set/reset at each audio enable/disable call in intel_audio.c. It's protected with the modeset lock as well. Signed-off-by: Takashi Iwai <ti...@suse.de> --- v1->v2: * Use modeset lock for get_eld lock

[Intel-gfx] [PATCH v2 1/9] drm/i915: Remove superfluous NULL check

to_intel_crtc() always returns a non-NULL pointer. Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/gpu/drm/i915/intel_audio.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 4dccd9b003a1..0c38cc

[Intel-gfx] [PATCH v2 8/9] ALSA: hda - Skip ELD notification during PM process

, we can skip it when received during PM process. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/hda/patch_hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 4dc21ecf7230..75815acb77db 100644 --- a/sound/p

[Intel-gfx] [PATCH v2 7/9] ALSA: hda - Do zero-clear in snd_hdmi_parse_eld() itself

Instead of doing in each caller side, snd_hdmi_parse_eld() does zero-clear of the parsed data by itself. This is safer and simplifies the code. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/hda/hda_eld.c| 1 + sound/pci/hda/patch_hdmi.c | 2 -- 2 files changed, 1 insertion

[Intel-gfx] [PATCH v2 3/9] drm/i915: refactoring audio component functions

We have a common loop of encoder to look for the given audio port in two audio component functions. Split out a local helper function to do it for the code simplification. Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/gpu/drm/i915/intel_audio.

[Intel-gfx] [PATCH v2 9/9] ALSA: hda - Move audio component accesses to hdac_i915.c

mapping is also moved to hdac_i915.c, so that it can be fixed / enhanced more cleanly. Signed-off-by: Takashi Iwai <ti...@suse.de> --- include/sound/hda_i915.h | 14 ++ sound/hda/hdac_i915.c | 66 sound/pci/hda/patch_hdmi.

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Add get_eld audio component

On Mon, 30 Nov 2015 17:09:33 +0100, Ville Syrjälä wrote: > > On Mon, Nov 30, 2015 at 05:24:41PM +0200, Ville Syrjälä wrote: > > On Mon, Nov 30, 2015 at 02:37:46PM +0100, Takashi Iwai wrote: > > > Implement a new i915_audio_component_ops, get_eld(). It's called by > >

Re: [Intel-gfx] [PATCH 5/7] ALSA: hda - Use component ops for i915 HDMI/DP audio jack handling

On Mon, 30 Nov 2015 17:42:33 +0100, Vinod Koul wrote: > > On Mon, Nov 30, 2015 at 02:37:49PM +0100, Takashi Iwai wrote: > > Since we have a new audio component ops to fetch the current ELD and > > state now, we can reduce the usage of unsol event of HDMI/DP pins. > > Th

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Add get_eld audio component

On Mon, 30 Nov 2015 16:24:41 +0100, Ville Syrjälä wrote: > > On Mon, Nov 30, 2015 at 02:37:46PM +0100, Takashi Iwai wrote: > > Implement a new i915_audio_component_ops, get_eld(). It's called by > > the audio driver to fetch the current ELD of the given HDMI/DP port. >

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Add get_eld audio component

On Mon, 30 Nov 2015 16:34:22 +0100, David Henningsson wrote: > > > > On 2015-11-30 16:29, Takashi Iwai wrote: > > On Mon, 30 Nov 2015 16:24:41 +0100, > > Ville Syrjälä wrote: > >> > >> On Mon, Nov 30, 2015 at 02:37:46PM +0100, Takashi Iwai wrote: >

Re: [Intel-gfx] [PATCH 4/7] ALSA: hda - Split ELD update code from hdmi_present_sense()

On Mon, 30 Nov 2015 17:00:33 +0100, Vinod Koul wrote: > > On Mon, Nov 30, 2015 at 02:37:48PM +0100, Takashi Iwai wrote: > > > > +/* update per_pin ELD from the given new ELD; > > + * setup info frame and notification accordingly > > + */ > > nitpick, c

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Add get_eld audio component

On Mon, 30 Nov 2015 15:11:16 +0100, Daniel Vetter wrote: > > On Mon, Nov 30, 2015 at 02:37:46PM +0100, Takashi Iwai wrote: > > Implement a new i915_audio_component_ops, get_eld(). It's called by > > the audio driver to fetch the current ELD of the given HDMI/DP port. >

Re: [Intel-gfx] [PATCH 3/7] drm/i915: refactoring audio component functions

On Mon, 30 Nov 2015 15:14:03 +0100, Daniel Vetter wrote: > > On Mon, Nov 30, 2015 at 02:37:47PM +0100, Takashi Iwai wrote: > > We have a common loop of encoder to look for the given audio port in > > two audio component functions. Split out a local helper function to >

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Add get_eld audio component

On Mon, 30 Nov 2015 15:17:05 +0100, Daniel Vetter wrote: > > On Mon, Nov 30, 2015 at 03:11:16PM +0100, Daniel Vetter wrote: > > On Mon, Nov 30, 2015 at 02:37:46PM +0100, Takashi Iwai wrote: > > > diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h >

[Intel-gfx] [PATCH 6/7] ALSA: hda - Do zero-clear in snd_hdmi_parse_eld() itself

Instead of doing in each caller side, snd_hdmi_parse_eld() does zero-clear of the parsed data by itself. This is safer and simplifies the code. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/hda/hda_eld.c| 1 + sound/pci/hda/patch_hdmi.c | 2 -- 2 files changed, 1 insertion

[Intel-gfx] [PATCH 1/7] drm/i915: Remove superfluous NULL check

to_intel_crtc() always returns a non-NULL pointer. Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/gpu/drm/i915/intel_audio.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 4dccd9b003a1..0c38cc

[Intel-gfx] [PATCH 0/7] Add get_eld audio component for i915/HD-audio

version, posted to both i915 and alsa-devel for review. The current patchset is found in sound git tree test/hdmi-jack branch. Takashi Takashi Iwai (7): drm/i915: Remove superfluous NULL check drm/i915: Add get_eld audio component drm/i915: refactoring audio component functions ALSA: hda

[Intel-gfx] [PATCH 2/7] drm/i915: Add get_eld audio component

audio_enabled is added to struct intel_digital_port. This is set/reset at each audio enable/disable call in intel_audio.c. Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/gpu/drm/i915/intel_audio.c | 40 ++ drivers/gpu/drm/i915/intel_drv.h | 1 + i

[Intel-gfx] [PATCH 3/7] drm/i915: refactoring audio component functions

We have a common loop of encoder to look for the given audio port in two audio component functions. Split out a local helper function to do it for the code simplification. Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/gpu/drm/i915/intel_audio.

[Intel-gfx] [PATCH 5/7] ALSA: hda - Use component ops for i915 HDMI/DP audio jack handling

designed for the pin sense read and unsol events, both of which aren't used any longer in our case. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/hda/patch_hdmi.c | 84 -- 1 file changed, 82 insertions(+), 2 deletions(-) diff --git a/sound/p

[Intel-gfx] [PATCH 7/7] ALSA: hda - Skip ELD notification during PM process

, we can skip it when received during PM process. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/hda/patch_hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 23a4292c355f..0492f3cf744e 100644 --- a/sound/p

[Intel-gfx] [PATCH 4/7] ALSA: hda - Split ELD update code from hdmi_present_sense()

This is a preliminary patch for the later change to support ELD/jack handling with i915 audio component. This splits the ELD update code from hdmi_present_sense() so that it can be called from other places. Just a code refactoring, no functional change. Signed-off-by: Takashi Iwai <

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Fri, 27 Nov 2015 14:45:31 +0100, David Henningsson wrote: > > > > On 2015-11-27 14:38, Takashi Iwai wrote: > > On Fri, 27 Nov 2015 03:55:28 +0100, > > Zhang, Xiong Y wrote: > >> > >>> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

_get_state(codec->card) != SNDRV_CTL_POWER_D0) > > + return; > > + > > check_presence_and_report(codec, pin_nid); > > } > > > [Zhang, Xiong Y] yes, this patch could remove the error message. Alright, then it's indeed a failure in the sound driver side. Below is the official patch

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Thu, 26 Nov 2015 08:57:30 +0100, Zhang, Xiong Y wrote: > > > > > BTW, I have a patchset to avoid the audio h/w wakeup by a new > > > > component ops to get ELD and connection states. It was posted to > > > > alsa-devel shortly ago just as a reference, but this should work well > > > > in such

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Thu, 26 Nov 2015 10:16:17 +0100, Zhang, Xiong Y wrote: > > > > On Thu, 26 Nov 2015 08:57:30 +0100, > > Zhang, Xiong Y wrote: > > > > > > > > > BTW, I have a patchset to avoid the audio h/w wakeup by a new > > > > > > component ops to get ELD and connection states. It was posted to > > > > >

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Thu, 26 Nov 2015 16:08:06 +0100, David Henningsson wrote: > > > > On 2015-11-26 10:24, Takashi Iwai wrote: > > On Thu, 26 Nov 2015 10:16:17 +0100, > > Zhang, Xiong Y wrote: > >> > >> > >>> On Thu, 26 Nov 2015 08:57:30 +0100, > >>

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Thu, 26 Nov 2015 16:29:12 +0100, David Henningsson wrote: > > > > On 2015-11-26 16:23, Takashi Iwai wrote: > > On Thu, 26 Nov 2015 16:08:06 +0100, > > David Henningsson wrote: > >> > >> > >> > >> On 2015-11-26 10:24, Takashi Iwai

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Thu, 26 Nov 2015 16:43:23 +0100, Ville Syrjälä wrote: > > On Thu, Nov 26, 2015 at 04:29:12PM +0100, David Henningsson wrote: > > > > > > On 2015-11-26 16:23, Takashi Iwai wrote: > > > On Thu, 26 Nov 2015 16:08:06 +0100, > > > David Henningsson wrote:

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Thu, 26 Nov 2015 16:58:09 +0100, Ville Syrjälä wrote: > > On Thu, Nov 26, 2015 at 04:51:04PM +0100, Takashi Iwai wrote: > > On Thu, 26 Nov 2015 16:43:23 +0100, > > Ville Syrjälä wrote: > > > > > > On Thu, Nov 26, 2015 at 04:29

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Thu, 26 Nov 2015 07:06:56 +0100, Zhang, Xiong Y wrote: > > > On Wed, 25 Nov 2015 11:57:13 +0100, > > Zhang, Xiong Y wrote: > > > > > > > On Wed, 25 Nov 2015 10:56:51 +0100, > > > > Zhang, Xiong Y wrote: > > > > > > > > > > Recently I always see the following error message during S4 or S3 > >

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Wed, 25 Nov 2015 10:56:51 +0100, Zhang, Xiong Y wrote: > > Recently I always see the following error message during S4 or S3 resume with > drm-intel-nightly. > [ 97.778063] PM: Syncing filesystems ... done. > [ 97.801550] Freezing user space processes ... (elapsed 0.002 seconds) done. > [

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Wed, 25 Nov 2015 11:57:13 +0100, Zhang, Xiong Y wrote: > > > On Wed, 25 Nov 2015 10:56:51 +0100, > > Zhang, Xiong Y wrote: > > > > > > Recently I always see the following error message during S4 or S3 resume > > with drm-intel-nightly. > > > [ 97.778063] PM: Syncing filesystems ... done. > >

[Intel-gfx] [PATCH] drm/i915: Don't compare has_drrs strictly in pipe config

/show_bug.cgi?id=956397 Fixes: cfb23ed622d0 ('drm/i915: Allow fuzzy matching in pipe_config_compare, v2') Cc: <sta...@vger.kernel.org> # v4.3+ Reported-and-tested-by: Max Lin <m...@suse.com> Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/gpu/drm/i915/intel_display.c | 1

Re: [Intel-gfx] [PATCH] drm/i915: Don't override output type for DDI HDMI

On Thu, 19 Nov 2015 17:04:20 +0100, Takashi Iwai wrote: > > On Thu, 19 Nov 2015 16:51:05 +0100, > Daniel Vetter wrote: > > > > On Thu, Nov 19, 2015 at 12:09:56PM +0100, Takashi Iwai wrote: > > > Currently a DDI port may register the DP hotplug handler even th

[Intel-gfx] [PATCH] drm/i915: Don't override output type for DDI HDMI

MST support (v0.7)') Cc: <sta...@vger.kernel.org> # v3.17+ Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/gpu/drm/i915/intel_dp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index

Re: [Intel-gfx] [PATCH 1/1] drm/i915/audio: apply SKL codec wake up patch to BXT

On Thu, 19 Nov 2015 10:09:01 +0100, Jani Nikula wrote: > > On Thu, 19 Nov 2015, Jani Nikula wrote: > > On Thu, 19 Nov 2015, han...@intel.com wrote: > >> From: "Lu, Han" > >> > >> Signed-off-by: Lu, Han > >> > >> diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Don't override output type for DDI HDMI

On Thu, 19 Nov 2015 16:51:05 +0100, Daniel Vetter wrote: > > On Thu, Nov 19, 2015 at 12:09:56PM +0100, Takashi Iwai wrote: > > Currently a DDI port may register the DP hotplug handler even though > > it's used with HDMI, and the DP HPD handler overrides the encoder >

Re: [Intel-gfx] A wrong DDI encoder override from HDMI to DP at hotplug

On Wed, 18 Nov 2015 16:38:03 +0100, Ville Syrjälä wrote: > > On Wed, Nov 18, 2015 at 04:23:06PM +0100, Takashi Iwai wrote: > > Hi, > > > > currently a DDI port may register both DP and HDMI and it shares the > > same encoder. The bug we've got a report is about

Re: [Intel-gfx] A wrong DDI encoder override from HDMI to DP at hotplug

On Wed, 18 Nov 2015 22:30:32 +0100, Dave Airlie wrote: > > On 19 November 2015 at 02:00, Takashi Iwai <ti...@suse.de> wrote: > > On Wed, 18 Nov 2015 16:38:03 +0100, > > Ville Syrjälä wrote: > >> > >> On Wed, Nov 18, 2015 at 04:23:06PM +0100, Takashi Iwai

Re: [Intel-gfx] [PATCH v6 4/4] drm/i915: set proper N/CTS in modeset

On Mon, 19 Oct 2015 10:25:22 +0200, Jani Nikula wrote: > > On Wed, 02 Sep 2015, Takashi Iwai <ti...@suse.de> wrote: > > On Wed, 02 Sep 2015 11:02:42 +0200, > > Jani Nikula wrote: > >> > >> >> Nitpick. I'd prefer some sharing with the similar blo

Re: [Intel-gfx] [PATCH v2] drm/i915: Improve kernel-doc for i915_audio_component struct

On Mon, 12 Oct 2015 10:17:51 +0200, David Henningsson wrote: > > > > On 2015-10-12 10:07, David Henningsson wrote: > > To make kernel-doc happy, the i915_audio_component_audio_ops struct > > cannot be nested. > > > > Signed-off-by: David Henningsson > > --- >

Re: [Intel-gfx] 4.2-rc4 kernel warnings on HSW laptop [regression]

On Mon, 12 Oct 2015 14:29:19 +0200, Takashi Iwai wrote: > > > > Then a warning when I start powertop: > > > > > > WARNING: CPU: 1 PID: 1674 at drivers/gpu/drm/drm_atomic.c:889 > > > drm_atomic_get_property+0x232/0x2b0 [drm]() > > > CPU

Re: [Intel-gfx] 4.2-rc4 kernel warnings on HSW laptop [regression]

On Mon, 12 Oct 2015 09:04:20 +0200, Daniel Vetter wrote: > > Another pile of regressions for Jairo to track ... > > On Sat, Oct 10, 2015 at 11:46:29AM +0200, Takashi Iwai wrote: > > Hi, > > > > I noticed that a HSW laptop gets a few new warnings since 4.2-rc &g

[Intel-gfx] 4.2-rc4 kernel warnings on HSW laptop

Hi, I noticed that a HSW laptop gets a few new warnings since 4.2-rc kernels. One error messages pops at each boot time: Console: switching to colour dummy device 80x25 [drm] Replacing VGA console driver [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [drm] Driver supports

[Intel-gfx] [PATCH] drm/i915: Add missing const to audio_rate_need_prog()

ed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/gpu/drm/i915/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 30f6859dcb36..dffd0b4c5f17 100644 --- a/drivers/gpu/drm/i915/intel_a

Re: [Intel-gfx] [PATCH] drm/i915: Add missing const to audio_rate_need_prog()

On Wed, 30 Sep 2015 14:31:31 +0200, Daniel Vetter wrote: > > On Wed, Sep 30, 2015 at 09:45:03AM +0200, Takashi Iwai wrote: > > The lack of const leads to a compile warning after merging i915 > > upstream tree: > >drivers/gpu/drm/i915/intel_audio.c:147:13

Re: [Intel-gfx] [PATCH v2] drm/i915: set proper N/CTS in modeset

On Fri, 25 Sep 2015 10:01:48 +0200, Jani Nikula wrote: > > On Fri, 25 Sep 2015, libin.y...@intel.com wrote: > > From: Libin Yang > > > > When modeset occurs and the TMDS frequency is set to some > > speical values, the N/CTS need to be set manually if audio > > is playing.

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/CTS in modeset

On Wed, 16 Sep 2015 15:03:15 +0200, Jani Nikula wrote: > > > diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h > > index e6d35d7..89dc7d6 100644 > > --- a/include/drm/i915_component.h > > +++ b/include/drm/i915_component.h > > @@ -24,8 +24,18 @@ > > #ifndef

Re: [Intel-gfx] [PATCH] drm/i915: add kerneldoc for i915_audio_component

On Wed, 09 Sep 2015 17:09:52 +0200, Daniel Vetter wrote: > > On Wed, Sep 09, 2015 at 01:45:47AM +, Yang, Libin wrote: > > Hi Daniel, > > > > As Takashi has already accepted the first 3 patches for > > sync_audio_rate() and the patches are not merged > > into -nightly branch. If I make a

[Intel-gfx] [PATCH] drm/i915: Fix CSR MMIO address check

Wlogical-op] Fixes: eb805623d8b1 ('drm/i915/skl: Add support to load SKL CSR firmware.') Cc: <sta...@vger.kernel.org> # v4.2 Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/gpu/drm/i915/intel_csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/

Re: [Intel-gfx] [PATCH] drm/i915: Improve kernel-doc for i915_audio_component struct

On Fri, 04 Sep 2015 12:33:45 +0200, David Henningsson wrote: > > > > On 2015-09-04 10:03, Daniel Vetter wrote: > > Also please use the new inline style for struct members. > > I tried that, but I couldn't get it to work. This was with Takashi's > for-next tree, do I need to apply some docbook

Re: [Intel-gfx] [PATCH 0/4 v5] i915 to call hda driver on HDMI plug/unplug

On Thu, 03 Sep 2015 09:52:00 +0200, David Henningsson wrote: > > > > On 2015-08-28 19:02, David Henningsson wrote: > > Hopefully last version? :-) > > > > * Added commit text about duplicate events (patch 4/4) > > * Added locks in bind/unbind on i915 side (patch 2/4) > > * Fixed docbook

Re: [Intel-gfx] [PATCH v6 4/4] drm/i915: set proper N/CTS in modeset

On Fri, 04 Sep 2015 03:56:26 +0200, Yang, Libin wrote: > > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Wednesday, September 02, 2015 11:36 PM > > To: Daniel Vetter > > Cc: Jani Nikula; Yang, Libin; alsa-

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Wed, 02 Sep 2015 10:00:44 +0200, Daniel Vetter wrote: > > On Fri, Aug 28, 2015 at 04:10:36PM +0300, Jani Nikula wrote: > > On Thu, 20 Aug 2015, Takashi Iwai <ti...@suse.de> wrote: > > > On Thu, 20 Aug 2015 11:41:42 +0200, > > > David Henningsson wrote: >

Re: [Intel-gfx] [PATCH v6 4/4] drm/i915: set proper N/CTS in modeset

On Wed, 02 Sep 2015 17:22:01 +0200, Daniel Vetter wrote: > > On Wed, Sep 02, 2015 at 03:46:40PM +0200, Takashi Iwai wrote: > > On Wed, 02 Sep 2015 15:44:34 +0200, > > Jani Nikula wrote: > > > > > > On Wed, 02 Sep 2015, Takashi Iwai <ti...@suse.de> w

Re: [Intel-gfx] [PATCH 0/4 v5] i915 to call hda driver on HDMI plug/unplug

On Wed, 02 Sep 2015 13:45:03 +0200, Daniel Vetter wrote: > > On Fri, Aug 28, 2015 at 08:14:48PM +0300, Jani Nikula wrote: > > On Fri, 28 Aug 2015, David Henningsson > > wrote: > > > Hopefully last version? :-) > > > > > > * Added commit text about duplicate

Re: [Intel-gfx] [PATCH v6 4/4] drm/i915: set proper N/CTS in modeset

On Wed, 02 Sep 2015 11:02:42 +0200, Jani Nikula wrote: > > >> Nitpick. I'd prefer some sharing with the similar blocks from the > >> earlier patch. Also a debug message on n == 0 would be nice; you > >> probably didn't notice your audio_config_get_rate() wasn't working > >> right > >> because

Re: [Intel-gfx] [PATCH v6 4/4] drm/i915: set proper N/CTS in modeset

On Wed, 02 Sep 2015 15:44:34 +0200, Jani Nikula wrote: > > On Wed, 02 Sep 2015, Takashi Iwai <ti...@suse.de> wrote: > > On Wed, 02 Sep 2015 11:02:42 +0200, > > Jani Nikula wrote: > >> > >> >> Nitpick. I'd prefer some sharing with the similar blo

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Wed, 02 Sep 2015 10:32:34 +0200, Daniel Vetter wrote: > > On Wed, Sep 02, 2015 at 10:03:55AM +0200, Takashi Iwai wrote: > > On Wed, 02 Sep 2015 10:00:44 +0200, > > Daniel Vetter wrote: > > > > > > On Fri, Aug 28, 2015 at 04:10:36PM +0300, Jani Nikul

Re: [Intel-gfx] [PATCH v5 2/4] drm/i915: implement sync_audio_rate callback

On Mon, 24 Aug 2015 14:53:19 +0200, Ville Syrjälä wrote: On Mon, Aug 24, 2015 at 02:38:14AM +, Yang, Libin wrote: -Original Message- From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] Sent: Friday, August 21, 2015 11:14 PM To: Yang, Libin Cc:

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Thu, 20 Aug 2015 11:41:42 +0200, David Henningsson wrote: On 2015-08-20 11:28, Takashi Iwai wrote: On Wed, 19 Aug 2015 10:48:58 +0200, David Henningsson wrote: Whenever there is an event from the i915 driver, wake the codec and recheck plug/unplug + ELD status. This fixes

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

On Wed, 19 Aug 2015 10:48:58 +0200, David Henningsson wrote: Whenever there is an event from the i915 driver, wake the codec and recheck plug/unplug + ELD status. This fixes the issue with lost unsol events in power save mode, the codec and controller can now sleep in D3 and still know

Re: [Intel-gfx] [PATCH v3 3/4] ALSA: hda - display audio call sync_audio_rate callback

it would be easier to take this series from drm tree. Feel free to my ack Reviewed-by: Takashi Iwai ti...@suse.de thanks, Takashi --- sound/pci/hda/patch_hdmi.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: set proper N/CTS in modeset

On Mon, 10 Aug 2015 09:32:11 +0200, libin.y...@intel.com wrote: From: Libin Yang libin.y...@intel.com When modeset occurs and the TMDS frequency is set to some speical value, the N/CTS need to be set manually if audio is playing. Signed-off-by: Libin Yang libin.y...@intel.com ---

Re: [Intel-gfx] [PATCH 3/4] ALSA: hda - display audio call ncts callback

On Thu, 06 Aug 2015 08:52:56 +0200, libin.y...@intel.com wrote: From: Libin Yang libin.y...@intel.com On some Intel platforms, display audio need set N/CTS manually at some TMDS frequencies. Signed-off-by: Libin Yang libin.y...@intel.com --- sound/pci/hda/patch_hdmi.c | 7 +++ 1

Re: [Intel-gfx] [alsa-devel] [PATCH 2/4] drm/i915: implement set_ncts callback

On Thu, 06 Aug 2015 08:52:55 +0200, libin.y...@intel.com wrote: From: Libin Yang libin.y...@intel.com Display audio may not work at some frequencies with the HW provided N/CTS. This patch sets the proper N value for the given audio sample rate at the impacted frequencies. At other

Re: [Intel-gfx] [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

On Thu, 30 Jul 2015 17:32:28 +0200, Theodore Ts'o wrote: On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: On Wed, Jul 29, 2015 at 10:18:16PM -0700, Linus Torvalds wrote: drivers/gpu/drm/drm_atomic_helper.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

Re: [Intel-gfx] [PATCH v3 0/4] i915 to call hda driver on HDMI plug/unplug

On Thu, 23 Jul 2015 17:26:15 +0200, David Henningsson wrote: Changes since v2 is that the patch set has diminished to not transfer connector/eld information, since it might be better that such information to be transferred by a separate call in the ordinary direction. That could be added in

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

On Thu, 23 Jul 2015 08:25:21 +0200, David Henningsson wrote: On 2015-07-23 08:17, David Henningsson wrote: I'm about to go on vacation so it would be good to get some closure here. If you both prefer this setup, how about I remove struct i915_audio_hotplug_info for now? We will then

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

On Wed, 22 Jul 2015 19:52:23 +0200, David Henningsson wrote: On 2015-07-22 16:13, Vinod Koul wrote: On Wed, Jul 22, 2015 at 10:55:55AM +0200, Takashi Iwai wrote: On Wed, 22 Jul 2015 10:50:03 +0200, David Henningsson wrote: struct i915_audio_component { struct device

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

On Wed, 22 Jul 2015 10:50:03 +0200, David Henningsson wrote: struct i915_audio_component { struct device *dev; + struct hdac_bus *hdac_bus; If we want to be more generic, using a struct device would be better, e.g. struct device *audio_dev; Does this work? If we want

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

On Tue, 21 Jul 2015 09:57:24 +0200, David Henningsson wrote: This struct will be used to transfer information from the i915 driver to the hda driver on HDMI hotplug events. Signed-off-by: David Henningsson david.hennings...@canonical.com Looks good to me, just a few nitpicking: ---

Re: [Intel-gfx] [PATCH 0/4] i915 to call hda driver on HDMI plug/unplug

On Tue, 21 Jul 2015 19:37:17 +0200, R, Durgadoss wrote: Hi David, -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of David Henningsson Sent: Tuesday, July 21, 2015 1:27 PM To: alsa-de...@alsa-project.org;

Re: [Intel-gfx] [PATCH 3/4] ALSA: hda - Dispatch incoming HDMI hotplug i915 callback

On Tue, 21 Jul 2015 09:57:26 +0200, David Henningsson wrote: This lets interested codec(s) be notified of HDMI hotplug events sent from the i915 driver. Signed-off-by: David Henningsson david.hennings...@canonical.com --- include/sound/hdaudio.h |4 sound/hda/hdac_i915.c |

Re: [Intel-gfx] [PATCH 3/4] ALSA: hda - Dispatch incoming HDMI hotplug i915 callback

On Wed, 22 Jul 2015 15:56:37 +0200, Vinod Koul wrote: On Wed, Jul 22, 2015 at 10:30:57AM +0200, Takashi Iwai wrote: On Tue, 21 Jul 2015 09:57:26 +0200, David Henningsson wrote: This lets interested codec(s) be notified of HDMI hotplug events sent from the i915 driver

Re: [Intel-gfx] [PATCH 3/4] snd: add support for displayport multi-stream to hda codec.

At Tue, 23 Jun 2015 07:51:22 +, Kaskinen, Tanu wrote: (Added pulseaudio-discuss to CC.) On Mon, 2015-06-22 at 17:44 +0200, Takashi Iwai wrote: At Mon, 22 Jun 2015 15:21:16 +, Kaskinen, Tanu wrote: On Mon, 2015-06-22 at 14:29 +0100, Liam Girdwood wrote: On Mon, 2015-06

Re: [Intel-gfx] [PATCH 3/4] snd: add support for displayport multi-stream to hda codec.

At Mon, 22 Jun 2015 15:21:16 +, Kaskinen, Tanu wrote: On Mon, 2015-06-22 at 14:29 +0100, Liam Girdwood wrote: On Mon, 2015-06-22 at 15:23 +0200, Takashi Iwai wrote: At Mon, 22 Jun 2015 14:54:29 +0200, Daniel Vetter wrote: On Fri, Jun 19, 2015 at 01:15:57PM +0200, Takashi

Re: [Intel-gfx] [PATCH 3/4] snd: add support for displayport multi-stream to hda codec.

At Mon, 22 Jun 2015 14:54:29 +0200, Daniel Vetter wrote: On Fri, Jun 19, 2015 at 01:15:57PM +0200, Takashi Iwai wrote: At Fri, 19 Jun 2015 20:33:39 +1000, Dave Airlie wrote: On 19 June 2015 at 19:54, Lin, Mengdong mengdong@intel.com wrote: Hi Takashi/Dave, Shall we

Re: [Intel-gfx] [PATCH 3/4] snd: add support for displayport multi-stream to hda codec.

At Fri, 19 Jun 2015 20:33:39 +1000, Dave Airlie wrote: On 19 June 2015 at 19:54, Lin, Mengdong mengdong@intel.com wrote: Hi Takashi/Dave, Shall we move or cc this discussion on audio driver side to ALSA ML? Oops I thought I had cc'ed these patches to alsa-devel as well when I sent

Re: [Intel-gfx] [alsa-devel] DP MST audio support

At Thu, 14 May 2015 09:10:33 +1000, Dave Airlie wrote: On 12 May 2015 at 13:27, Dave Airlie airl...@gmail.com wrote: On 12 May 2015 at 11:50, Dave Airlie airl...@gmail.com wrote: Hi, So I have a branch that makes no sound, http://cgit.freedesktop.org/~airlied/linux/log/?h=dp-mst-audio

Re: [Intel-gfx] [PATCH-V3 1/2] drm/i915/audio: add codec wakeup override enabled/disable callback

of [1]. We can add it back once that gets resolved. OK, now I applied these two patches to for-next branch. Thanks! Takashi BR, Jani. [1] http://mid.gmane.org/87fv7i9bgu@intel.com BR, Han Lu -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent

Re: [Intel-gfx] [PATCH-V3 1/2] drm/i915/audio: add codec wakeup override enabled/disable callback

At Wed, 29 Apr 2015 17:49:25 +0800, han...@intel.com wrote: From: Lu, Han han...@intel.com Add support for enabling codec wakeup override signal to allow re-enumeration of the controller on SKL after resume from low power state. v3 by Jani: Simplify to only support toggling the

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

0a599838737a2527c35e4d94f794aefe59df1781 Merge: 2d846c7 a59d719 Author: Takashi Iwai ti...@suse.de Date: Wed Apr 8 11:29:56 2015 +0200 Merge branch 'for-linus' into for-next Back merge HD-audio quirks to for-next branch, so that we can apply a couple of more quirks

Re: [Intel-gfx] [Linux v4.0-rc5] Warnings in drm_framebuffer_reference() and drm_atomic_check_only()

At Fri, 27 Mar 2015 12:01:33 +0100, Sedat Dilek wrote: On Wed, Mar 25, 2015 at 3:34 PM, Takashi Iwai ti...@suse.de wrote: At Wed, 25 Mar 2015 14:26:50 +0100, Daniel Vetter wrote: On Tue, Mar 24, 2015 at 07:09:03PM +0100, Sedat Dilek wrote: On Mon, Mar 23, 2015 at 9:25 AM, Daniel

Re: [Intel-gfx] [Linux v4.0-rc5] Warnings in drm_framebuffer_reference() and drm_atomic_check_only()

At Mon, 23 Mar 2015 09:25:06 +0100, Daniel Vetter wrote: On Mon, Mar 23, 2015 at 07:25:27AM +0100, Sedat Dilek wrote: Hi, I did my weekly update of the Linux RC (here: v4.0-rc5) and fell over some warning in the drm area. Please have a look... Just to confirm: Both are new in

Re: [Intel-gfx] [Linux v4.0-rc5] Warnings in drm_framebuffer_reference() and drm_atomic_check_only()

At Wed, 25 Mar 2015 14:26:50 +0100, Daniel Vetter wrote: On Tue, Mar 24, 2015 at 07:09:03PM +0100, Sedat Dilek wrote: On Mon, Mar 23, 2015 at 9:25 AM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Mar 23, 2015 at 07:25:27AM +0100, Sedat Dilek wrote: Hi, I did my weekly update of

Re: [Intel-gfx] [git pull] drm fixes

At Wed, 25 Mar 2015 15:00:08 +0100, Daniel Vetter wrote: On Wed, Mar 25, 2015 at 09:11:17AM -0400, Josh Boyer wrote: On Wed, Mar 25, 2015 at 4:54 AM, Daniel Vetter dan...@ffwll.ch wrote: commit f55548b5af87ebfc586ca75748947f1c1b1a4a52 Author: Damien Lespiau damien.lesp...@intel.com

Re: [Intel-gfx] [PULL] topic/i915-hda-componentized

At Mon, 12 Jan 2015 23:47:42 +0100, Daniel Vetter wrote: Hi Takashi, So here's the stable tag with Imre's i915/hda componentized refactoring, based upon 3.19-rc4. I'll pull in the same tag into drm-intel-next. Great, I pulled the branch now. Thanks! Takashi Cheers, Daniel The

Re: [Intel-gfx] [PATCH v4 0/6] sanitize hda/i915 interface using the component fw

At Mon, 12 Jan 2015 02:32:16 +0100, Daniel Vetter wrote: On Fri, Jan 9, 2015 at 11:20 AM, Takashi Iwai ti...@suse.de wrote: At Fri, 9 Jan 2015 10:18:45 +0100, Daniel Vetter wrote: On Thu, Jan 08, 2015 at 05:54:12PM +0200, Imre Deak wrote: This is v4 of [1] addressing the review

<    1   2   3   4   5   6   >