Re: [PATCH] drm/i915: Add includes for BUG_ON/BUILD_BUG_ON in i915_memcpy.c

On Thu, 2024-03-14 at 14:48 +0200, Joonas Lahtinen wrote: > Quoting Rodrigo Vivi (2024-03-08 16:58:04) > > On Fri, Mar 08, 2024 at 04:46:43PM +0200, Joonas Lahtinen wrote: > > > Add standalone includes for BUG_ON and BUILD_BUG_ON to avoid > > > build failure > > > after linux-next include

Re: [Intel-gfx] [PATCH v3] drm/i915: handle uncore spinlock when not available

On Fri, 2023-11-03 at 09:47 +, Tvrtko Ursulin wrote: > > On 03/11/2023 08:58, Coelho, Luciano wrote: > > On Fri, 2023-11-03 at 03:31 +, Vivi, Rodrigo wrote: > > > > > > > > > > Any other suggestions? > > > > > > >

Re: [Intel-gfx] [PATCH v3] drm/i915: handle uncore spinlock when not available

> > > > Any other suggestions? > > I think it will boil down to the reason uncore lock is held over the > respective sections ie. the comment in i915_get_crtc_scanoutpos. > > If it is timing sensitive to the extent irq off was needed it may > apply > to Xe as well. Likewise the need to use

Re: [Intel-gfx] [PATCH] gpu: drm: i915: fix documentation style

On Mon, 2023-08-21 at 14:00 -0700, Ceraolo Spurio, Daniele wrote: > > > On 8/21/2023 9:22 AM, Jani Nikula wrote: > > On Mon, 21 Aug 2023, "Ricardo B. Marliere" > > wrote: > > > This patch fixes the following sphinx warnings in the htmldocs > > > make target: > > > > > >

Re: [Intel-gfx] [PATCH] drm/i915/mtl: do not enable render power-gating on MTL

On Wed, 2023-05-17 at 17:12 +0200, Das, Nirmoy wrote: > > On 5/17/2023 3:59 PM, Andrzej Hajda wrote: > > Multiple CI tests fails with forcewake ack timeouts > > if render power gating is enabled. > > BSpec 52698 clearly states it should be 0 for MTL. > > > > Closes:

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/gt: Move LSC_CHICKEN_BIT* workarounds to correct function

On Thu, 2023-01-19 at 19:24 -0300, Gustavo Sousa wrote: > On Thu, Jan 19, 2023 at 04:57:09PM -0500, Rodrigo Vivi wrote: > > On Wed, Jan 18, 2023 at 12:52:49PM -0300, Gustavo Sousa wrote: > > > That register doesn't belong to a specific engine, so the proper > > > placement for workarounds

Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Add initial gt workarounds

On Fri, 2023-01-06 at 19:33 +, Sripada, Radhakrishna wrote: Pushed with the nit's fixed. Thanks for the patch and review. Next time please modify, resend and wait the BAT. We had seen cases in the past where the modification ended in a bad code that broken compilation and everyone else.

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned firmware paths

On Wed, 2022-12-28 at 19:00 -0300, Gustavo Sousa wrote: > On Fri, Dec 23, 2022 at 10:36:05AM -0500, Rodrigo Vivi wrote: > > On Fri, Dec 23, 2022 at 08:51:59AM -0300, Gustavo Sousa wrote: > > > On Thu, Dec 22, 2022 at 04:52:21PM -0800, Lucas De Marchi wrote: > > > > On Thu, Dec 22, 2022 at

Re: [Intel-gfx] [PATCH v2] drm/i915/hwconfig: Remove comment block

On Tue, 2022-12-13 at 13:50 +0800, Jiapeng Chong wrote: > No functional modification involved. > > drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:112: warning: > expecting prototype for intel_guc_hwconfig_init(). Prototype was for > guc_hwconfig_init() instead. Thank you for the patch and for

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reset twice

On Tue, 2022-12-13 at 00:08 +0100, Andi Shyti wrote: > Hi Rodrigo, > > On Mon, Dec 12, 2022 at 11:55:10AM -0500, Rodrigo Vivi wrote: > > On Mon, Dec 12, 2022 at 05:13:38PM +0100, Andi Shyti wrote: > > > From: Chris Wilson > > > > > > After applying an engine reset, on some platforms like > > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: use fetch_and_zero if applicable

On Thu, 2022-12-08 at 14:32 +0200, Jani Nikula wrote: > On Thu, 08 Dec 2022, Andrzej Hajda wrote: > > Simplify the code. > > Personally, I absolutely hate fetch_and_zero(). > > I understand the point, but there are two main traps: > > First, the name implies atomicity, which there is none at

Re: [Intel-gfx] [PATCH v7 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

On Fri, 2022-12-02 at 19:21 +, Teres Alexis, Alan Previn wrote: > > > On Fri, 2022-12-02 at 11:22 -0500, Vivi, Rodrigo wrote: > > On Thu, Dec 01, 2022 at 05:14:07PM -0800, Alan Previn wrote: > > > Starting with MTL, there will be two GT-tiles, a render and media >

Re: [Intel-gfx] [PATCH v3 0/2] mei: add timeout to send

On Wed, 2022-11-30 at 18:43 +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 30, 2022 at 09:20:28AM -0500, Rodrigo Vivi wrote: > > On Wed, Nov 16, 2022 at 02:47:33PM +0200, Alexander Usyskin wrote: > > > When driver wakes up the firmware from the low power state, > > > it is sending a memory ready

Re: [Intel-gfx] [PATCH v6 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

On Wed, 2022-11-30 at 09:32 -0800, Matt Roper wrote: > On Tue, Nov 29, 2022 at 06:02:45PM -0800, Alan Previn wrote: > > Starting with MTL, there will be two GT-tiles, a render and media > > tile. PXP as a service for supporting workloads with protected > > Drive-by comment:  we've been a bit

Re: [Intel-gfx] [PATCH v3] drm/i915/dmc: Update DG2 DMC version to v2.08

On Wed, 2022-11-30 at 10:42 -0300, Gustavo Sousa wrote: > On Thu, Nov 24, 2022 at 01:27:40PM -0300, Gustavo Sousa wrote: > > Just a quick note: firmware PR hasn't been applied yet. Waiting... > > Firmware PR merged into linux-firmware! Thanks for the patch and the heads up. Patch is now pushed

Re: [Intel-gfx] [PATCH] drm/i915: Remove CONFIG_PM dependency from RC6.

On Wed, 2022-11-30 at 11:47 +, Tvrtko Ursulin wrote: > > On 30/11/2022 02:29, Rodrigo Vivi wrote: > > RC6 is a sleep state that doesn't depend on the cpu sleep, > > or any of the APM or ACPI or anything related to the > > CONFIG_PM. > > > > A long time ago we have removed the module

Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS

On Sat, 2022-11-19 at 09:02 +0530, Nilawar, Badal wrote: > > > On 19-11-2022 00:07, Vivi, Rodrigo wrote: > > On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: > > > From: Vinay Belgaumkar > > > > > > By defaut idle messaging is disabled for GSC

Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS

On Fri, 2022-11-18 at 13:37 -0800, Dixit, Ashutosh wrote: > On Fri, 18 Nov 2022 10:37:37 -0800, Vivi, Rodrigo wrote: > > > > On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: > > > From: Vinay Belgaumkar > > > > > > By defaut idle messagin

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

On Mon, 2022-11-21 at 11:39 +, Tvrtko Ursulin wrote: > > On 17/11/2022 22:34, Teres Alexis, Alan Previn wrote: > > On Thu, 2022-11-17 at 11:02 -0500, Vivi, Rodrigo wrote: > > > On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan Previn wrote: > > > > In prepa

Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS

On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: > From: Vinay Belgaumkar > > By defaut idle messaging is disabled for GSC CS so to unblock RC6 > entry on media tile idle messaging need to be enabled. > > v2: >  - Fix review comments (Vinay) >  - Set GSC idle hysteresis as per spec

Re: [Intel-gfx] [PULL] gvt-next

On Thu, 2022-11-17 at 11:02 +0800, Zhenyu Wang wrote: > On 2022.11.15 10:36:59 -0500, Rodrigo Vivi wrote: > > On Fri, Nov 11, 2022 at 04:59:03PM +0800, Zhenyu Wang wrote: > > > Hi, > > > > > > Here's current accumulated changes in gvt-next. Sorry that I > > > delayed > > > to refresh them on time

Re: [Intel-gfx] [PULL] drm-intel-next

On Sat, 2022-10-29 at 02:41 +0300, Ville Syrjälä wrote: > On Fri, Oct 28, 2022 at 02:22:33PM -0400, Rodrigo Vivi wrote: > > Hi Dave and Daniel, > > > > Here goes the first chunk of drm-intel-next targeting 6.2 > > > > The highlight goes to Ville with many display related clean-up > > and

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

On Wed, 2022-09-28 at 12:31 +, Tangudu, Tilak wrote: > + > > > -Original Message- > > From: Tangudu, Tilak > > Sent: Wednesday, September 28, 2022 5:46 PM > > To: Tangudu, Tilak ; Vivi, Rodrigo > > ; Nikula, Jani > > Cc: Wilson,

Re: [Intel-gfx] [PATCH] drm/i915: Allow D3 when we are not actively managing a known PCI device.

Rafael, could you please add your thoughts here? On Thu, 2022-09-22 at 12:40 +, Gupta, Anshuman wrote: > > > > -Original Message- > > From: Gupta, Anshuman > > Sent: Thursday, September 22, 2022 4:40 PM > > To: Vivi, Rodrigo ; Tvrtko Ursulin > >

Re: [Intel-gfx] [PULL] drm-intel-fixes

On Sun, 2022-09-11 at 19:22 +0200, Jason A. Donenfeld wrote: > Hi Rodrigo, > > On Thu, Sep 08, 2022 at 09:59:54AM -0400, Rodrigo Vivi wrote: > > Hi Dave and Daniel, > > > > A few fixes, but most targeting stable. > > > > [...] > > > > Ville Syrjälä (2): > >   drm/i915: Implement

Re: [Intel-gfx] [PATCH 6/8] drm/i915/debugfs: Add perf_limit_reasons in debugfs

On Fri, 2022-09-09 at 08:38 -0700, Dixit, Ashutosh wrote: On Fri, 09 Sep 2022 03:13:05 -0700, Rodrigo Vivi wrote: On Wed, Sep 07, 2022 at 10:22:49PM -0700, Ashutosh Dixit wrote: From: Tilak Tangudu mailto:tilak.tang...@intel.com>> diff --git a/drivers/gpu/drm/i915/i915_reg.h

Re: [Intel-gfx] [PATCH v7 00/15] GSC support for XeHP SDV and DG2

On Fri, 2022-09-09 at 08:17 -0700, Ceraolo Spurio, Daniele wrote: > > > On 9/9/2022 3:24 AM, Joonas Lahtinen wrote: > > Dave, do you have a preference how to deal with the mishap here, > > shall I do a > > force-push to drm-intel-gt-next to correctly record the Acked-by or > > revert and > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Let's avoid even early init if SLPC is used.

On Fri, 2022-09-02 at 07:16 -0700, Dixit, Ashutosh wrote: > On Fri, 02 Sep 2022 02:51:26 -0700, Rodrigo Vivi wrote: > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c > > b/drivers/gpu/drm/i915/gt/intel_rps.c > > index 6fadde4ee7bf..c29652281f2e 100644 > > ---

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move some of the request decisions out of rps_boost function.

On Fri, 2022-09-02 at 11:07 +0200, Das, Nirmoy wrote: > Hi Rodrigo, > > On 9/1/2022 9:32 PM, Rodrigo Vivi wrote: > > Ideally all the decisions should be made before calling the boost > > function. > > And rps functions only receiving the rps struct. At least lets move > > most > > of the

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Let's fix the PCODE min freq table setup for SLPC

On Tue, 2022-08-30 at 17:45 -0700, Dixit, Ashutosh wrote: > On Tue, 30 Aug 2022 12:16:20 -0700, Rodrigo Vivi wrote: > > > > Hi Rodrigo, > > > @@ -65,13 +63,8 @@ static bool get_ia_constants(struct intel_llc > > *llc, > > /* convert DDR frequency from units of 266.6MHz to > > bandwidth

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Set rps' min and max frequencies even with SLPC.

On Thu, 2022-08-25 at 16:59 -0700, Dixit, Ashutosh wrote: On Thu, 25 Aug 2022 15:23:15 -0700, Rodrigo Vivi wrote: We need to inform PCODE of a desired ring frequencies so PCODE update the memory frequencies to us. rps->min_freq and rps->max_freq are the frequencies used in that request. However

Re: [Intel-gfx] [PATCH i-g-t] i915/guc: Disable i915_pm_rps when SLPC is enabled

On Thu, 2022-08-18 at 13:42 -0700, Vinay Belgaumkar wrote: > These tests were specifically designed for host Turbo. Skip > them when SLPC is enabled as they fail frequently. We will look > to keep adding to SLPC test coverage with these scenarios. > > Bug:

Re: [Intel-gfx] [PULL] gvt-fixes

On Thu, 2022-08-18 at 17:27 +0300, Jani Nikula wrote: On Thu, 18 Aug 2022, Jani Nikula mailto:jani.nik...@intel.com>> wrote: On Wed, 17 Aug 2022, "Colin King (gmail)" mailto:colin.i.k...@gmail.com>> wrote: On 17/08/2022 21:07, Vivi, Rodrigo wrote: On Tue, 2022-08-16 at 12

Re: [Intel-gfx] [PULL] gvt-fixes

On Tue, 2022-08-16 at 12:43 +0800, Zhenyu Wang wrote: > On 2022.08.16 12:05:08 +0800, Zhenyu Wang wrote: > > On 2022.08.15 19:32:45 -0400, Rodrigo Vivi wrote: > > > On Mon, Aug 15, 2022 at 10:38:55AM +0800, Zhenyu Wang wrote: > > > > > > > > Hi, > > > > > > > > Here's one gvt-fixes pull for

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: pass a pointer for tlb seqno at vma_invalidate_tlb()

On Tue, 2022-08-09 at 01:09 +0200, Andi Shyti wrote: > Hi Rodrigo, > > On Mon, Aug 08, 2022 at 03:04:13PM -0400, Rodrigo Vivi wrote: > > On Mon, Aug 08, 2022 at 06:37:58PM +0200, Andi Shyti wrote: > > > Hi Mauro, > > > > > > On Thu, Aug 04, 2022 at 09:37:22AM +0200, Mauro Carvalho Chehab > > >

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

On Thu, 2022-08-04 at 05:32 +, Tangudu, Tilak wrote: > > > > -Original Message- > > From: Vivi, Rodrigo > > Sent: Thursday, August 4, 2022 2:01 AM > > To: Tangudu, Tilak > > Cc: Ewins, Jon ; Belgaumkar, Vinay > > ; Roper, Matthew D &g

Re: [Intel-gfx] [PULL] drm-intel-gt-next

On Wed, 2022-07-13 at 17:31 -0400, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > On behalf of Tvrtko, who is recovering from Covid, > here goes the latest drm-intel-gt-next pull request > targeting 5.20. Hi Folks, any particular issue with this pull request? We just realized it is not yet part

Re: [Intel-gfx] [PATCH] drm/i915: Fix 32-bit build

On Sun, 2022-07-17 at 09:20 -0700, Guenter Roeck wrote: > Commit aff1e0b09b54 ("drm/i915/ttm: fix sg_table construction") > introduces > an additional parameter to i915_rsgt_from_mm_node(). The parameter is > used > to calculate segment_pages. This in turn is used in DIV_ROUND_UP() as > divisor.

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2

On Thu, 2022-05-05 at 09:58 -0700, Anusha Srivatsa wrote: > Add Support for DC states on Dg2. > > v2: Add dc9 as the max supported DC states and disable DC5. > v3: set max_dc to 0. (Imre) > > Cc: Imre Deak > Cc: Rodrigo Vivi > Signed-off-by: Anusha Srivatsa > Reviewed-by: Rodrigo Vivi (v1) >

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

On Tue, 2022-04-19 at 22:54 -0700, Dixit, Ashutosh wrote: > On Fri, 15 Apr 2022 03:21:26 -0700, Rodrigo Vivi wrote: > > On Thu, Apr 14, 2022 at 03:31:07PM -0700, Dixit, Ashutosh wrote: > > > On Thu, 14 Apr 2022 06:28:57 -0700, Jani Nikula wrote: > > > > > > > > On Wed, 13 Apr 2022, Ashutosh Dixit

Re: [Intel-gfx] [PATCH] drm/i915: Reserving some Multi-thread forcewake bits.

On Thu, 2022-04-14 at 14:14 -0700, Matt Roper wrote: > On Wed, Apr 13, 2022 at 05:39:27PM -0400, Rodrigo Vivi wrote: > > Bit 0: Currently bit used by i915. Ideally only i915 touches it > >    in a Linux stack. > > > > Bits 1 and 2: A while ago we were using Bit 1 for i915 and bit 2 > >    

Re: [Intel-gfx] [PATCH 0/4] drm/i915/dg2: Add support for render/media decompression

On Mon, 2022-04-11 at 15:38 +0300, Imre Deak wrote: > Hi Rodrigo, Jani, > > On Mon, Apr 04, 2022 at 04:38:42PM +0300, Imre Deak wrote: > > This is a rebased version of patches 15-17 of [1], adding DG2 > > display > > engine support for decompressing render and media compressed > > framebuffers. >

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for iommu/vt-d: Add RPLS to quirk list to skip TE disabling (rev3)

rom: Surendrakumar Upadhyay, TejaskumarX > > Sent: Wednesday, March 2, 2022 5:20 AM > To: intel-gfx@lists.freedesktop.org > Cc: Vivi, Rodrigo ; Meena, Mahesh > ; Vudum, Lakshminarayana > > Subject: RE: ✗ Fi.CI.IGT: failure for iommu/vt-d: Add RPLS to quirk > list to

Re: [Intel-gfx] [PULL] drm-intel-gt-next

On Tue, 2022-02-22 at 11:44 -0800, Lucas De Marchi wrote: > On Mon, Feb 21, 2022 at 11:21:35AM +0200, Jani Nikula wrote: > > On Mon, 21 Feb 2022, Dave Airlie wrote: > > > On Thu, 17 Feb 2022 at 20:26, Joonas Lahtinen > > > wrote: > > > > > > > > Hi Dave & Daniel, > > > > > > > > Here is the

Re: [Intel-gfx] [PATCH] drm/i915: delete shadow "ret" variable

On Fri, 2022-01-28 at 09:36 +0300, Dan Carpenter wrote: > On Fri, Jan 28, 2022 at 07:20:02AM +0100, Thomas Hellström wrote: > > On Thu, 2022-01-27 at 17:26 -0500, Rodrigo Vivi wrote: > > > On Thu, Jan 27, 2022 at 11:51:15AM +0300, Dan Carpenter wrote: > > > > This "ret" declaration shadows an

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/pxp: Hold RPM wakelock during PXP unbind

On Mon, 2022-01-17 at 13:21 +0200, Jani Nikula wrote: > On Thu, 13 Jan 2022, Rodrigo Vivi wrote: > > On Thu, Jan 06, 2022 at 12:02:36PM -0800, Juston Li wrote: > > > Similar to commit b8d8436840ca ("drm/i915/gt: Hold RPM wakelock > > > during > > > PXP suspend") but to fix the same warning for

Re: [Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next-queued

On Fri, 2022-01-07 at 14:43 +, Wang, Zhi A wrote: > Hi folks: > > Happy holidays! This pull mostly contains the code re-factors patches > from Guenter Roeck and Rikard. Also a minor change from Zhenyu. > > Zhi > > The following changes since commit >

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gt: Improve "race-to-idle" at low frequencies

On Tue, 2021-11-23 at 09:17 +, Tvrtko Ursulin wrote: > > On 22/11/2021 18:44, Rodrigo Vivi wrote: > > On Wed, Nov 17, 2021 at 02:49:55PM -0800, Vinay Belgaumkar wrote: > > > From: Chris Wilson > > > > > > While the power consumption is proportional to the frequency, > > > there is > > >

Re: [Intel-gfx] [PATCH 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

On Thu, 2021-11-11 at 14:42 +0200, Ville Syrjälä wrote: > On Wed, Nov 10, 2021 at 05:24:22PM -0500, Rodrigo Vivi wrote: > > On Wed, Nov 10, 2021 at 01:46:46PM +0200, Ville Syrjälä wrote: > > > On Wed, Nov 10, 2021 at 10:59:26AM +0530, Tilak Tangudu wrote: > > > > Enable runtime pm autosuspend by

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Revert 'guc_id' from i915_request tracepoint

On Wed, 2021-10-27 at 14:15 +0300, Joonas Lahtinen wrote: + Jani and Rodrigo in order to pick this to -fixes. picked up to drm-intel-next-fixes. thanks, Rodrigo. Quoting Patchwork (2021-10-27 13:31:33) Patch Details Series: drm/i915: Revert 'guc_id' from i915_request tracepoint URL:

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dmabuf: fix broken build

On Wed, 2021-10-27 at 10:48 +0100, Matthew Auld wrote: > On Wed, 27 Oct 2021 at 10:44, Jani Nikula > wrote: > > > > On Wed, 27 Oct 2021, Matthew Auld > > wrote: > > > On Wed, 27 Oct 2021 at 09:58, Jani Nikula > > > wrote: > > > > > > > > On Wed, 27 Oct 2021, Matthew Auld > > > > wrote: > > >

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Enable runtime pm autosuspend by default

On Mon, 2021-09-13 at 16:27 +0530, Gupta, Anshuman wrote: > > > > -Original Message- > > From: Vivi, Rodrigo > > Sent: Friday, September 10, 2021 11:15 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Vivi, Rodrigo ; Daniel Vetter > > ; David

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Disallow D3Cold.

On Mon, 2021-09-13 at 16:22 +0530, Gupta, Anshuman wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf > > Of Rodrigo > > Vivi > > Sent: Friday, September 10, 2021 11:15 PM > > To: intel-gfx@lists.freedesktop.org > > Cc:

Re: [Intel-gfx] [PATCH 4/5] drm/i915/display: stop returning errors from debugfs registration

On Wed, 2021-09-01 at 20:02 +0300, Jani Nikula wrote: > On Wed, 01 Sep 2021, Rodrigo Vivi wrote: > > On Mon, Aug 30, 2021 at 03:53:43PM +0300, Jani Nikula wrote: > > > Failures to register debugfs should be ignored anyway, so stop > > > propagating errors altogether for clarity and simplicity. No

Re: [Intel-gfx] [GIT PULL] drm-misc + drm-intel: Add support for out-of-band hotplug notification

On Thu, 2021-08-26 at 10:23 +0200, Maxime Ripard wrote: > On Wed, Aug 25, 2021 at 04:03:43PM +0000, Vivi, Rodrigo wrote: > > On Tue, 2021-08-24 at 18:48 +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 8/24/21 10:45 AM, Jani Nikula wrote: > > >

Re: [Intel-gfx] [GIT PULL] drm-misc + drm-intel: Add support for out-of-band hotplug notification

On Tue, 2021-08-24 at 18:48 +0200, Hans de Goede wrote: > Hi, > > On 8/24/21 10:45 AM, Jani Nikula wrote: > > On Fri, 20 Aug 2021, Hans de Goede wrote: > > > Hello drm-misc and drm-intel maintainers, > > > > > > My "Add support for out-of-band hotplug notification" patchset: > > >

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Make workaround upper bounds exclusive

On Tue, 2021-08-10 at 15:58 +0300, Jani Nikula wrote: > On Mon, 19 Jul 2021, "Souza, Jose" wrote: > > On Fri, 2021-07-16 at 22:14 -0700, Matt Roper wrote: > > > Workarounds are documented in the bspec with an exclusive upper > > > bound > > > (i.e., a "fixed" stepping that no longer needs the

Re: [Intel-gfx] [PATCH 25/25] drm/i915: finish removal of CNL

On Wed, 2021-07-28 at 17:32 -0700, Lucas De Marchi wrote: > On Wed, Jul 28, 2021 at 02:59:46PM -0700, Lucas De Marchi wrote: > > With all the users removed, finish removing the CNL platform > > definitions. > > We will leave the PCI IDs around as those are exposed to userspace. > > Even if mesa

Re: [Intel-gfx] [PATCH CI] drm/i915: Initialize err in remap_io_sg()

On Mon, 2021-05-17 at 23:31 +0300, Jani Nikula wrote: > On Mon, 17 May 2021, "Souza, Jose" wrote: > > Rodrigo, Jani: So "i915: fix remap_io_sg to verify the pgprot" was > > not merged into any drm-intel branch, how should I merge this after > > get CI green > > light? > > I think Rodrigo should

Re: [Intel-gfx] [PULL] gvt-gt-next

On Wed, 2021-01-20 at 14:21 +0200, Joonas Lahtinen wrote: > Quoting Zhenyu Wang (2021-01-18 07:07:39) > > > > Hi, > > > > This is GVT next for 5.12 against drm-intel-gt-next which is mostly > > for cmd parser enhancement which adds extra check on register load > > depending on initial context

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

On Mon, 2021-01-11 at 13:25 -0800, Lucas De Marchi wrote: > On Mon, Jan 11, 2021 at 12:57:43PM -0800, Matt Roper wrote: > > On Mon, Jan 11, 2021 at 10:18:45PM +0200, Jani Nikula wrote: > > > On Mon, 11 Jan 2021, Jani Nikula > > > wrote: > > > > On Fri, 08 Jan 2021, Matt Roper > > > > wrote: > >

Re: [Intel-gfx] [RFC-v19 02/13] drm/i915/pxp: set KCR reg init during the boot time

> Sean > > -Original Message- > From: Joonas Lahtinen > Sent: Friday, January 8, 2021 3:31 AM > To: Huang, Sean Z ; > Intel-gfx@lists.freedesktop.org; Vivi, Rodrigo < > rodrigo.v...@intel.com> > Subject: Re: [Intel-gfx] [RFC-v19 02/13] drm/i915/pxp: set

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce Intel PXP component - Mesa single session (rev19)

On Wed, 2021-01-06 at 23:47 +, Patchwork wrote: > == Series Details == > > Series: Introduce Intel PXP component - Mesa single session (rev19) > URL   : https://patchwork.freedesktop.org/series/84620/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > fbdd4e2e287d

Re: [Intel-gfx] [RFC-v19 12/13] drm/i915/pxp: User interface for Protected buffer

On Wed, 2021-01-06 at 15:12 -0800, Huang, Sean Z wrote: > From: Bommu Krishnaiah > > This api allow user mode to create Protected buffer and context > creation. > > Signed-off-by: Bommu Krishnaiah > Cc: Telukuntla Sreedhar > Cc: Kondapally Kalyan > Cc: Gupta Anshuman > Cc: Huang Sean Z >

Re: [Intel-gfx] [RFC-v19 09/13] drm/i915/pxp: Expose session state for display protection flip

On Wed, 2021-01-06 at 15:12 -0800, Huang, Sean Z wrote: > Implement the intel_pxp_gem_object_status() to allow i915 display > querying the current PXP session state. In the design, display > should not perform protection flip on the protected buffers if > there is no PXP session alive. And

Re: [Intel-gfx] [RFC-v19 08/13] drm/i915/pxp: Enable PXP power management

On Wed, 2021-01-06 at 15:12 -0800, Huang, Sean Z wrote: > During the power event S3+ sleep/resume, hardware will lose all the > encryption keys for every hardware session, even though the > software session state was marked as alive after resume. So to > handle such case, PXP should terminate all

Re: [Intel-gfx] [RFC-v19 05/13] drm/i915/pxp: Func to send hardware session termination

On Wed, 2021-01-06 at 15:12 -0800, Huang, Sean Z wrote: > Implement the functions to allow PXP to send a GPU command, in > order to terminate the hardware session, so hardware can recycle > this session slot for the next usage. > > Signed-off-by: Huang, Sean Z > --- >  

Re: [Intel-gfx] [RFC-v19 00/13] Introduce Intel PXP component - Mesa single session

On Wed, 2021-01-06 at 15:12 -0800, Huang, Sean Z wrote: > PXP (Protected Xe Path) is an i915 component, available on > GEN12+ that helps to establish the hardware protected session > and manage the status of the alive software session, as well > as its life cycle. > > This patch series is to

Re: [Intel-gfx] [RFC-v19 04/13] drm/i915/pxp: Create the arbitrary session after boot

On Wed, 2021-01-06 at 15:12 -0800, Huang, Sean Z wrote: > Create the arbitrary session, with the fixed session id 0xf, after > system boot, for the case that application allocates the protected > buffer without establishing any protection session. Because the > hardware requires at least one alive

Re: [Intel-gfx] [RFC-v19 03/13] drm/i915/pxp: Implement funcs to create the TEE channel

On Wed, 2021-01-06 at 15:12 -0800, Huang, Sean Z wrote: > Implement the funcs to create the TEE channel, so kernel can > send the TEE commands directly to TEE for creating the arbitrary > (defualt) session. > > Signed-off-by: Huang, Sean Z > --- >  drivers/gpu/drm/i915/Makefile    |   3

Re: [Intel-gfx] [RFC-v19 02/13] drm/i915/pxp: set KCR reg init during the boot time

On Wed, 2021-01-06 at 15:12 -0800, Huang, Sean Z wrote: > Set the KCR init during the boot time, which is > required by hardware, to allow us doing further > protection operation such as sending commands to > GPU or TEE. > > Signed-off-by: Huang, Sean Z > --- >  

Re: [Intel-gfx] [RFC-v19 01/13] drm/i915/pxp: Introduce Intel PXP component

On Wed, 2021-01-06 at 15:12 -0800, Huang, Sean Z wrote: > PXP (Protected Xe Path) is an i915 componment, available on GEN12+, > that helps to establish the hardware protected session and manage > the status of the alive software session, as well as its life cycle. > > This patch series is to

Re: [Intel-gfx] [PULL] drm-intel-fixes v2

On Wed, 2020-12-09 at 14:11 +0200, Ville Syrjälä wrote: > On Thu, Dec 03, 2020 at 05:47:05AM -0800, Rodrigo Vivi wrote: > > Hi Dave and Daniel, > > > > Please ignore the pull request I had sent yesterday and use only > > this one. > > > > I had missed one patch: 14d1eaf08845 ("drm/i915/gt:

Re: [Intel-gfx] [PULL] drm-intel-fixes

> On Nov 12, 2020, at 4:32 PM, Dave Airlie wrote: > > On Fri, 13 Nov 2020 at 09:08, Rodrigo Vivi wrote: >> >> Hi Dave and Daniel, >> >> This is the same set as last week + couple new fixes targeting stable. >> > > But I merged last weeks set and it's in rc3, maybe you can generate > the

Re: [Intel-gfx] [PATCH] drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms

> On Nov 4, 2020, at 9:17 PM, Anshuman Gupta wrote: > > On 2020-11-03 at 17:06:42 -0500, Rodrigo Vivi wrote: >> On Fri, Oct 30, 2020 at 11:46:58AM +0530, Anshuman Gupta wrote: >>> From: Bob Paauwe >>> >>> The WA specifies that we need to toggle a SDE chicken bit on and then >>> off as the

Re: [Intel-gfx] [PULL] gvt-fixes

> On Oct 29, 2020, at 10:21 PM, Zhenyu Wang wrote: > > On 2020.10.28 11:18:45 +0000, Vivi, Rodrigo wrote: > >> >> I'm actually pulling it off. I had bypassed dim, considering this was an old >> issue with our email decoder, >> but it happens that >>

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

> ; intel-gfx@ intel-gfx@lists.freedesktop.org>; Souza, Jose ; > dri-devel@ ; > Surendrakumar Upadhyay, TejaskumarX > ; K, SrinivasX > ; Vivi, Rodrigo ; Meena, > Mahesh > Subject: RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe > protection >

Re: [Intel-gfx] [PULL] gvt-fixes

On Oct 27, 2020, at 1:46 PM, Rodrigo Vivi mailto:rodrigo.v...@intel.com>> wrote: On Tue, Oct 27, 2020 at 11:17:40AM +0800, Zhenyu Wang wrote: Hi, Here's first gvt fixes for 5.10 which includes more vGPU suspend/resume fix in HWSP reset handling, and also fix for host i915 suspend regression

Re: [Intel-gfx] [PATCH] drm/i915/dp: Tweak initial dpcd backlight.enabled value

> On Oct 12, 2020, at 2:47 PM, Lyude Paul wrote: > > Just pushed this, but it's not in drm-tip because it would seem that > rebuilding > drm-tip has failed, and the conflict doesn't appear to be from any of the > patches I pushed so I'm getting the feeling from the DRM maintainer docs I >

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

: Souza, Jose > Sent: 06 October 2020 23:33 > To: Vivi, Rodrigo ; ch...@chris-wilson.co.uk > Cc: Ausmus, James ; Nikula, Jani > ; Pandey, Hariom ; Roper, > Matthew D ; intel-gfx@lists.freedesktop.org; > dri-de...@lists.freedesktop.org; K, SrinivasX ; > Surendrakumar Upadh

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

> On Oct 6, 2020, at 10:48 AM, Chris Wilson wrote: > > Quoting Souza, Jose (2020-10-06 18:46:45) >> +Rodrigo and Jani >> >> On Tue, 2020-10-06 at 14:56 +, Kamati Srinivas wrote: >>> Removing force probe protection from EHL platform. Did >>> not observe warnings, errors, flickering or any

Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent

> On Sep 14, 2020, at 1:05 PM, Vivi, Rodrigo wrote: > > > >> On Sep 11, 2020, at 9:00 PM, Dhanavanthri, Swathi >> wrote: >> >> It is in the if statement: if (IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) { > > duh! sorry... > > more bel

Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent

> On Sep 11, 2020, at 9:00 PM, Dhanavanthri, Swathi > wrote: > > It is in the if statement: if (IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) { duh! sorry... more below: > > -Original Message- > From: Rodrigo Vivi > Sent: Friday, September 11, 2020 6:10 PM > To: Dhanavanthri,

Re: [Intel-gfx] [PULL] gvt-next

> On Sep 13, 2020, at 7:34 PM, Zhenyu Wang wrote: > > On 2020.09.11 19:58:25 -0400, Rodrigo Vivi wrote: >> On Thu, Sep 10, 2020 at 01:37:20PM +0800, Zhenyu Wang wrote: >>> >>> Hi, >>> >>> As we split pull request for 5.10 this time, here's gvt-next pull >>> for 5.10. For gvt ww lock fix,

Re: [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register lookup

> On Sep 8, 2020, at 4:39 PM, Srivatsa, Anusha > wrote: > > We currenty check for platform at multiple parts in the driver > to grab the correct PLL. Let us begin to centralize it through a > helper function. > > v2: s/intel_get_pll_enable_reg()/intel_combo_pll_enable_reg() (Ville) > > v3:

Re: [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register lookup

> On Sep 3, 2020, at 10:04 AM, Srivatsa, Anusha > wrote: > > > >> -Original Message- >> From: Vivi, Rodrigo >> Sent: Wednesday, September 2, 2020 2:32 PM >> To: Srivatsa, Anusha >> Cc: intel-gfx@lists.freedesktop.org >> Subjec

Re: [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register lookup

> On Sep 2, 2020, at 12:30 PM, Srivatsa, Anusha > wrote: > > > >> -Original Message- >> From: Rodrigo Vivi >> Sent: Tuesday, September 1, 2020 12:30 PM >> To: Srivatsa, Anusha >> Cc: intel-gfx@lists.freedesktop.org >> Subject: Re: [Intel-gfx] [PATCH] drm/i915/pll: Centralize

Re: [Intel-gfx] [Regression] "drm/i915: Implement display w/a #1143" breaks HDMI on ASUS GL552VW

Art, any comment here? I just checked and the W/a 1143 is implemented as described, but it is failing HDMI on this hybrid system. > On Aug 12, 2020, at 9:07 PM, Kai-Heng Feng > wrote: > > Hi, > > There's a regression reported that HDMI output stops working after os upgrade: >

Re: [Intel-gfx] [PULL] gvt-next

> On Jul 21, 2020, at 5:42 PM, Zhenyu Wang wrote: > > On 2020.07.21 14:04:41 +0300, Joonas Lahtinen wrote: >> Quoting Zhenyu Wang (2020-07-20 11:05:41) >>> >>> Hi, >>> >>> Sorry that this might be a bit late as last week our QA people were >>> busy on something else..So this is gvt changes

Re: [Intel-gfx] [PATCH] drm/i915: drop alpha_support for good in favour of force_probe

On Jan 21, 2020, at 4:01 AM, Joonas Lahtinen mailto:joonas.lahti...@linux.intel.com>> wrote: Quoting Jani Nikula (2020-01-21 12:30:20) It's been a long enough transition period since the DRM_I915_FORCE_PROBE config and i915.force_probe module parameter were introduced in commit 7ef5ef5cdead

Re: [Intel-gfx] [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private

> On Dec 11, 2019, at 7:25 AM, Joonas Lahtinen > wrote: > > Quoting Jani Nikula (2019-12-11 12:36:10) >> On Fri, 15 Nov 2019, Chris Wilson wrote: >>> Quoting Jani Nikula (2019-11-15 11:04:28) On Fri, 15 Nov 2019, Chris Wilson wrote: > Quoting Jani Nikula (2019-11-15 10:18:40)

Re: [Intel-gfx] [PULL] gvt-fixes

pulled, thanks > On Nov 11, 2019, at 10:18 PM, Zhenyu Wang wrote: > > > Hi, > > Here's one GVT dmabuf reference drop fix from Pan Bian. > > Thanks > -- > The following changes since commit ee2c5ef8a9d640ee1617ec97b84fe2f634284e51: > > drm/i915/dp: Do not switch aux to TBT mode for non-TC

Re: [Intel-gfx] Merge in the drm-intel tree

Outch, it reapared on the backmerge I did yesterday and I didn't noticed. Sorry Chris has fixed this now. Thank you both. > On Aug 22, 2019, at 3:20 AM, Stephen Rothwell wrote: > > Hi all, > > I noticed that the drm tree has been back merge into the drm-intel > tree. Unfortunately, it seems

Re: [Intel-gfx] [PATCH] drm/i915/vbt: Fix VBT parsing for the PSR section

> On Jul 30, 2019, at 2:48 PM, Sasha Levin wrote: > > On Tue, Jul 30, 2019 at 01:42:45PM -0700, Rodrigo Vivi wrote: >> Hi Sasha, > > Hello! > >> On Thu, Jul 18, 2019 at 5:45 PM Sasha Levin wrote: >>> >>> Hi, >>> >>> [This is an automated email] >> >> Where did you get this patch from?

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/psr: Move logic to get TPS registers values to another function

> On Mar 11, 2019, at 5:15 PM, Pandiyan, Dhinakaran > wrote: > >> On Mon, 2019-03-11 at 16:28 -0700, Rodrigo Vivi wrote: >> On Tue, Mar 05, 2019 at 03:47:33PM -0800, José Roberto de Souza >> wrote: >>> This will make hsw_activate_psr1() more easy to read and will make >>> future modification

Re: [Intel-gfx] I messed up drm-intel-next-queued!

Hi Hans, I’m traveling on vacation and didn’t bring my laptop. I believe Joonas and Jani are out this week as well. I’m in favor of the forced push if you are sure you have the latest one with you. In case you are not sure about the latest sabe head: I had done a drm-intel-next tag last

Re: [Intel-gfx] [PATCH] [intel-gfx] drm/i915/csr Added DC5 and DC6 counter register for ICL in debugfs entry.

> On Oct 2, 2018, at 9:20 PM, Yadav, Jyoti R wrote: > > DC5 and DC6 counter register tells about residency of DC5 and DC6. > These registers are same for SKL and ICL. > > v2 : Remove csr_version check. > Added generic check regarding DC counters for Gen9 onwards. (Rodrigo) > v3 :

Re: [Intel-gfx] [PATCH] drm/i915/edp: Only use alternate fixed mode when requested

> On Apr 12, 2018, at 2:21 PM, Taylor, Clinton A > wrote: > > > >> On 04/11/2018 04:11 PM, Chris Wilson wrote: >> Quoting clinton.a.tay...@intel.com (2018-04-12 00:13:26) >>> From: Clint Taylor >>> >>> In commit dc911f5bd8aa

Re: [Intel-gfx] [PATCH] drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

On Jan 4, 2018, at 10:07 PM, Kenneth Graunke > wrote: On Thursday, January 4, 2018 4:41:35 PM PST Rodrigo Vivi wrote: On Thu, Jan 04, 2018 at 11:39:23PM +, Kenneth Graunke wrote: On Thursday, January 4, 2018 1:23:06 PM PST Chris Wilson

Re: [Intel-gfx] [drm-tip:drm-tip 1/7] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:219:6: error: redefinition of 'dm_dp_mst_dc_sink_create'

Drm-tip rebuild created this function duplication in some merge resolution... not sure where that came from or started... But Lucas had warned me yesterday morning... So, yesterday night I added a fix-up on drm-rerere that remove the duplication on drm-tip... and that should be fixed by now I

  1   2   3   4   5   >