Re: [Intel-gfx] [PATCH] drm/i915/display: Pass drm_i915_private as param to i915 funcs

2023-02-10 Thread Das, Nirmoy
On 2/10/2023 1:21 PM, Andi Shyti wrote: Hi Jani, On Thu, Jan 19, 2023 at 12:58:47PM +0200, Jani Nikula wrote: On Thu, 19 Jan 2023, Nirmoy Das wrote: For i915 functions pass struct drm_i915_private directly instead of struct drm_device. Reviewed-by: Jani Nikula but maybe let's wait until

Re: [Intel-gfx] [PATCH] drm/i915/display: Pass drm_i915_private as param to i915 funcs

2023-02-10 Thread Andi Shyti
Hi Jani, On Thu, Jan 19, 2023 at 12:58:47PM +0200, Jani Nikula wrote: > On Thu, 19 Jan 2023, Nirmoy Das wrote: > > For i915 functions pass struct drm_i915_private directly instead of > > struct drm_device. > > Reviewed-by: Jani Nikula > > but maybe let's wait until we've synced up with

Re: [Intel-gfx] [PATCH] drm/i915/display: Pass drm_i915_private as param to i915 funcs

2023-01-25 Thread Das, Nirmoy
On 1/25/2023 8:50 AM, Andrzej Hajda wrote: On 24.01.2023 15:17, Nirmoy Das wrote: For i915 functions pass struct drm_i915_private directly instead of struct drm_device. Cc: Rodrigo Vivi Suggested-by: Jani Nikula Signed-off-by: Nirmoy Das Reviewed-by: Jani Nikula Reviewed-by: Andrzej

Re: [Intel-gfx] [PATCH] drm/i915/display: Pass drm_i915_private as param to i915 funcs

2023-01-24 Thread Andrzej Hajda
On 24.01.2023 15:17, Nirmoy Das wrote: For i915 functions pass struct drm_i915_private directly instead of struct drm_device. Cc: Rodrigo Vivi Suggested-by: Jani Nikula Signed-off-by: Nirmoy Das Reviewed-by: Jani Nikula Reviewed-by: Andrzej Hajda ---

[Intel-gfx] [PATCH] drm/i915/display: Pass drm_i915_private as param to i915 funcs

2023-01-24 Thread Nirmoy Das
For i915 functions pass struct drm_i915_private directly instead of struct drm_device. Cc: Rodrigo Vivi Suggested-by: Jani Nikula Signed-off-by: Nirmoy Das Reviewed-by: Jani Nikula Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_display.c | 2 +-

Re: [Intel-gfx] [PATCH] drm/i915/display: Pass drm_i915_private as param to i915 funcs

2023-01-19 Thread Das, Nirmoy
On 1/19/2023 3:06 PM, Andrzej Hajda wrote: On 19.01.2023 10:58, Nirmoy Das wrote: For i915 functions pass struct drm_i915_private directly instead of struct drm_device. Cc: Rodrigo Vivi Suggested-by: Jani Nikula Signed-off-by: Nirmoy Das It could be good start for boring refactoring :)

Re: [Intel-gfx] [PATCH] drm/i915/display: Pass drm_i915_private as param to i915 funcs

2023-01-19 Thread Andrzej Hajda
On 19.01.2023 10:58, Nirmoy Das wrote: For i915 functions pass struct drm_i915_private directly instead of struct drm_device. Cc: Rodrigo Vivi Suggested-by: Jani Nikula Signed-off-by: Nirmoy Das It could be good start for boring refactoring :) of similar cases, for example:

Re: [Intel-gfx] [PATCH] drm/i915/display: Pass drm_i915_private as param to i915 funcs

2023-01-19 Thread Das, Nirmoy
On 1/19/2023 11:58 AM, Jani Nikula wrote: On Thu, 19 Jan 2023, Nirmoy Das wrote: For i915 functions pass struct drm_i915_private directly instead of struct drm_device. Reviewed-by: Jani Nikula but maybe let's wait until we've synced up with drm-misc-next to avoid the unnecessary conflict

Re: [Intel-gfx] [PATCH] drm/i915/display: Pass drm_i915_private as param to i915 funcs

2023-01-19 Thread Jani Nikula
On Thu, 19 Jan 2023, Nirmoy Das wrote: > For i915 functions pass struct drm_i915_private directly instead of > struct drm_device. Reviewed-by: Jani Nikula but maybe let's wait until we've synced up with drm-misc-next to avoid the unnecessary conflict in drm-tip and linux-next? > > Cc:

[Intel-gfx] [PATCH] drm/i915/display: Pass drm_i915_private as param to i915 funcs

2023-01-19 Thread Nirmoy Das
For i915 functions pass struct drm_i915_private directly instead of struct drm_device. Cc: Rodrigo Vivi Suggested-by: Jani Nikula Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 8