Re: [Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook

2022-09-19 Thread Nathan Chancellor
On Tue, Sep 13, 2022 at 01:55:27PM -0700, Nathan Huckleberry wrote: > All of the functions used for intel_dvo_dev_ops.mode_valid have a return > type of enum drm_mode_status, but the mode_valid field in the struct > definition has a return type of int. > > The mismatched return type breaks

[Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook

2022-09-19 Thread Nathan Huckleberry
All of the functions used for intel_dvo_dev_ops.mode_valid have a return type of enum drm_mode_status, but the mode_valid field in the struct definition has a return type of int. The mismatched return type breaks forward edge kCFI since the underlying function definitions do not match the

Re: [Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook

2022-09-15 Thread Jani Nikula
On Tue, 13 Sep 2022, Nathan Chancellor wrote: > On Tue, Sep 13, 2022 at 01:55:27PM -0700, Nathan Huckleberry wrote: >> All of the functions used for intel_dvo_dev_ops.mode_valid have a return >> type of enum drm_mode_status, but the mode_valid field in the struct >> definition has a return type

Re: [Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook

2022-09-14 Thread Andrzej Hajda
On 13.09.2022 22:55, Nathan Huckleberry wrote: All of the functions used for intel_dvo_dev_ops.mode_valid have a return type of enum drm_mode_status, but the mode_valid field in the struct definition has a return type of int. The mismatched return type breaks forward edge kCFI since the