Re: [Intel-gfx] [PATCH] drm/i915: HSW GT3 Slices: exec flag to warn kernel that userspace is using predication

2013-11-02 Thread Rodrigo Vivi
On Fri, Nov 1, 2013 at 8:39 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Oct 31, 2013 at 09:07:09PM -0200, Rodrigo Vivi wrote: If Userspace isn't using MI_PREDICATE all slices must be enabled for backward compatibility. If I915_EXEC_USE_PREDICATE isn't set and defaul is set to

Re: [Intel-gfx] [PATCH] drm/i915: HSW GT3 Slices: exec flag to warn kernel that userspace is using predication

2013-11-02 Thread Chris Wilson
On Sat, Nov 02, 2013 at 10:49:32AM -0200, Rodrigo Vivi wrote: On Fri, Nov 1, 2013 at 8:39 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Oct 31, 2013 at 09:07:09PM -0200, Rodrigo Vivi wrote: If Userspace isn't using MI_PREDICATE all slices must be enabled for backward

Re: [Intel-gfx] [PATCH] drm/i915: HSW GT3 Slices: exec flag to warn kernel that userspace is using predication

2013-11-01 Thread Chris Wilson
On Thu, Oct 31, 2013 at 09:07:09PM -0200, Rodrigo Vivi wrote: If Userspace isn't using MI_PREDICATE all slices must be enabled for backward compatibility. If I915_EXEC_USE_PREDICATE isn't set and defaul is set to half, kernel will force all slices on. v2: fix the inverted logic for

[Intel-gfx] [PATCH] drm/i915: HSW GT3 Slices: exec flag to warn kernel that userspace is using predication

2013-10-31 Thread Rodrigo Vivi
If Userspace isn't using MI_PREDICATE all slices must be enabled for backward compatibility. If I915_EXEC_USE_PREDICATE isn't set and defaul is set to half, kernel will force all slices on. v2: fix the inverted logic for backwards compatibility USE_PREDICATE unset force gt_full when defaul

Re: [Intel-gfx] [PATCH] drm/i915: HSW GT3 Slices: exec flag to warn kernel that userspace is using predication

2013-10-25 Thread Chris Wilson
On Thu, Oct 24, 2013 at 06:24:18PM -0200, Rodrigo Vivi wrote: If Userspace isn't using MI_PREDICATE all slices must be enabled for backward compatibility. If I915_EXEC_USE_PREDICATE isn't set and defaul is set to half, kernel will force all slices on. v2: fix the inverted logic for

[Intel-gfx] [PATCH] drm/i915: HSW GT3 Slices: exec flag to warn kernel that userspace is using predication

2013-10-24 Thread Rodrigo Vivi
If Userspace isn't using MI_PREDICATE all slices must be enabled for backward compatibility. If I915_EXEC_USE_PREDICATE isn't set and defaul is set to half, kernel will force all slices on. v2: fix the inverted logic for backwards compatibility USE_PREDICATE unset force gt_full when defaul

Re: [Intel-gfx] [PATCH] drm/i915: HSW GT3 Slices: exec flag to warn kernel that userspace is using predication

2013-10-22 Thread Chris Wilson
On Mon, Oct 21, 2013 at 07:00:18PM -0200, Rodrigo Vivi wrote: static int +i915_legacy_userspace_busy(struct drm_device *dev, +struct intel_ring_buffer *ring) s/i915_legacy_userspace_busy/gt_legacy_userspace_busy/ As that is a bit more distinctive. +{ +

Re: [Intel-gfx] [PATCH] drm/i915: HSW GT3 Slices: exec flag to warn kernel that userspace is using predication

2013-10-22 Thread Chris Wilson
On Tue, Oct 22, 2013 at 03:33:16PM -0200, Rodrigo Vivi wrote: I still think state_default is working, enough and simpler... or do you really want me to use config and max_config instead? I think keeping the hw config separate from the requested config helps a lot when reviewing the code in 6

[Intel-gfx] [PATCH] drm/i915: HSW GT3 Slices: exec flag to warn kernel that userspace is using predication

2013-10-21 Thread Rodrigo Vivi
If Userspace isn't using MI_PREDICATE all slices must be enabled for backward compatibility. If I915_EXEC_USE_PREDICATE isn't set and defaul is set to half, kernel will force all slices on. v2: fix the inverted logic for backwards compatibility USE_PREDICATE unset force gt_full when defaul