Re: [Intel-gfx] [PATCH] drm/i915: Move fd_install after last use of fence

2023-02-06 Thread Tvrtko Ursulin
On 03/02/2023 18:15, Rob Clark wrote: On Fri, Feb 3, 2023 at 8:49 AM Rob Clark wrote: From: Rob Clark Because eb_composite_fence_create() drops the fence_array reference after creation of the sync_file, only the sync_file holds a ref to the fence. But fd_install() makes that reference

Re: [Intel-gfx] [PATCH] drm/i915: Move fd_install after last use of fence

2023-02-03 Thread Rob Clark
On Fri, Feb 3, 2023 at 8:49 AM Rob Clark wrote: > > From: Rob Clark > > Because eb_composite_fence_create() drops the fence_array reference > after creation of the sync_file, only the sync_file holds a ref to the > fence. But fd_install() makes that reference visable to userspace, so > it must

[Intel-gfx] [PATCH] drm/i915: Move fd_install after last use of fence

2023-02-03 Thread Rob Clark
From: Rob Clark Because eb_composite_fence_create() drops the fence_array reference after creation of the sync_file, only the sync_file holds a ref to the fence. But fd_install() makes that reference visable to userspace, so it must be the last thing we do with the fence. Signed-off-by: Rob