Re: [Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma

2019-12-21 Thread Nathan Chancellor
On Tue, Dec 03, 2019 at 10:45:22AM -0800, Nick Desaulniers wrote: > On Tue, Dec 3, 2019 at 5:42 AM Chris Wilson wrote: > > > > Quoting Nick Desaulniers (2019-12-02 19:18:20) > > > On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson > > > wrote: > > > > > > > > Quoting Nathan Chancellor (2019-11-23

Re: [Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma

2019-12-03 Thread Nick Desaulniers
On Tue, Dec 3, 2019 at 5:42 AM Chris Wilson wrote: > > Quoting Nick Desaulniers (2019-12-02 19:18:20) > > On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson > > wrote: > > > > > > Quoting Nathan Chancellor (2019-11-23 19:53:22) > > > > -Wtautological-compare was recently added to -Wall in LLVM,

Re: [Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma

2019-12-03 Thread Chris Wilson
Quoting Nick Desaulniers (2019-12-02 19:18:20) > On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson > wrote: > > > > Quoting Nathan Chancellor (2019-11-23 19:53:22) > > > -Wtautological-compare was recently added to -Wall in LLVM, which > > > exposed an if statement in i915 that is always false: > >

Re: [Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma

2019-12-02 Thread Nick Desaulniers
On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson wrote: > > Quoting Nathan Chancellor (2019-11-23 19:53:22) > > -Wtautological-compare was recently added to -Wall in LLVM, which > > exposed an if statement in i915 that is always false: > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma

2019-11-23 Thread Chris Wilson
Quoting Nathan Chancellor (2019-11-23 19:53:22) > -Wtautological-compare was recently added to -Wall in LLVM, which > exposed an if statement in i915 that is always false: > > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning: > result of comparison of constant 576460752303423487

[Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma

2019-11-23 Thread Nathan Chancellor
-Wtautological-compare was recently added to -Wall in LLVM, which exposed an if statement in i915 that is always false: ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning: result of comparison of constant 576460752303423487 with expression of type 'unsigned int' is always false